May 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] mshtml: Added more parser compatMode tests.
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25597 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] user32/tests: Test that sending WM_CANCELMODE cancels tracking in window's menu bar.
by Dmitry Timoshkov May 17, 2013

May 17, 2013

Ken Thomases <ken(a)codeweavers.com> wrote: > dlls/user32/tests/menu.c | 21 ++++++++++++++++++++- Please add a message test instead, it would much more clearer show what is going on. > + {MSG msg; while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessage(&msg);} Please avoid creating such embedded blocks. -- Dmitry.

2 2

Re: winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Ken Thomases May 16, 2013

May 16, 2013

Hi Kevin, I'm bringing this back to wine-devel. Please CC the list unless you intend to take things private, in which case please say so. On May 10, 2013, at 6:48 PM, Kevin Eaves wrote: > I should have made everything clear, sorry. It was for personal use, so it's pretty nasty, but works great. The only real problem is with user32. Everything else is easy to clean up and get working with Wine properly without any issues. Just wanted to show that. Sure, that's what I figured. > On May 9, 2013, at 9:56 PM, Ken Thomases wrote: > >>> The fullscreen button appears if a main window is resizable. >> >> We may want to narrow this down a bit. For example, the common file dialogs are resizable, but probably shouldn't be full-screen-enabled. Perhaps no owned window should be. > > Only windows in the windows cycle should be fullscreen enabled. If the window can be manually moved to its own space, then it should be able to go fullscreen. No dialogs are enabled. These follow the main window to spaces. If in Cocoa fullscreen, the new window automatically opens fullscreen in its own space. Everything works just like Mac applications with this setting. Ah, I failed to notice before that the use of NSWindowCollectionBehaviorFullScreenPrimary was only in the same code path as NSWindowCollectionBehaviorParticipatesInCycle. Yes, that makes sense. >> From cocoa_window.m.diff: >> >>> +#import <Cocoa/Cocoa.h> >> >> >> Was that actually needed? cocoa_window.h already imports <AppKit/AppKit.h>. >> >> ... >> >>> + if (style & NSResizableWindowMask) >>> + [[self standardWindowButton:NSWindowZoomButton] setEnabled:!self.disabled]; > > These should have not been included in the diff. It's unrelated to Cocoa fullscreen, however, the zoom button is currently bugged. It is not disabled when the window is disabled. To reproduce the problem: launch regedit, open the import window, and click the zoom button on the main window. I sent a patch for it. I'm not seeing that problem happen here. Mind you, I'm currently testing on 10.6. I'll have to run some tests on 10.7+ tomorrow. I find it improbable that removing NSResizableWindowMask from the style doesn't disable the zoom button. That style is the only thing which enables the zoom button to begin with. In other words, in a normal Mac app, one would not need to disable the zoom button separately. >>> - if (captured || fullscreen) >>> + if (captured || (fullscreen && !(normalStyleMask & NSResizableWindowMask))) >> >> You're trying to distinguish between a window that was full-screened at the instigation of the Windows program versus one which has been full-screened by Cocoa, right? Hmm. I think we need a better technique to determine that. I agree that it's not likely the Windows program would make its window full-screen while still allowing it to be resized but it feels wrong to assume that. >> >> Also, I think we can entirely avoid setting the window level for windows that have been Cocoa full-screened. Setting the window level is mostly about relationship to other windows, but a Cocoa full-screen window should be on a space by itself, shouldn't it? >> >>> + else if ([self styleMask] & NSFullScreenWindowMask) >>> + level = NSMainMenuWindowLevel + 2; >> >> I'm not following why Cocoa full-screened windows should be at +2 vs. +1. > > The window levels are automatically adjusted and the menu is in a hover state. We need to prevent the menu from being hidden, and hide the menu if the Windows program goes fullscreen while in Cocoa fullscreen (+1 doesn't cut it). I'm going to have to do some testing to understand this, too. NSMainMenuWindowLevel should be in the same level as the menu (meaning could be above or below due to normal window ordering operations). NSMainMenuWindowLevel + 1 should always be above the menu, regardless. NSMainMenuWindowLevel + 2 should not be necessary. But maybe something weird is going on. Also, if the Windows program changes a window from resizable to non-resizable, then we should probably pull the window out of Cocoa fullscreen. The Windows program _may_ have intended to make the window full-screen but we can't know that. It may simply be changing the window style for some other purpose, and that may make it no longer a candidate for Cocoa full-screen mode. >>> + - (NSSize)window:(NSWindow *)window willUseFullScreenContentSize:(NSSize)proposedSize >>> + { >>> + return NSMakeSize(proposedSize.width, proposedSize.height); >>> + } >> >> Is this actually needed? I assume that's the default behavior when the delegate method is absent. (Also, if it is necessary, it can just return proposedSize without making a new size struct.) > > This little gem will resize ANY window — non-resizable, disabled, a dialog box... Add this and poof!! There is no reason to ever disable Cocoa fullscreen. Mac applications don't so neither should Wine. I disagree. Windows programs that are not expecting their window to resize (because they haven't made them resizable) can misbehave badly if the window does resize. Just because that didn't happen in your testing doesn't mean it won't. As you mentioned in your original email, Cocoa full-screen is roughly akin to window resizing. So, it should be disabled if/when the window is made non-resizable. > I haven't tested this enough with non-resizable windows, but it is possible to resize any window. I don't follow this. It is possible to resize any window even non-resizable ones? To what are you referring? Possible how? Do you mean specifically just with this full-screen patch? > I use this feature to resize a few non-resizable game windows. Maybe add a registry key to allow non-resizable windows to go fullscreen. Perhaps. Cheers, Ken

2 2

Re: [PATCH 1/6] fonts: Add default glyph to Tahoma.
by Alexandre Julliard May 16, 2013

May 16, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > fonts/tahoma.sfd | 94 +++++++++++++++++++++++++++++------------------------- > fonts/tahoma.ttf | Bin 100420 -> 97836 bytes > 2 files changed, 50 insertions(+), 44 deletions(-) We already have .notdef, we shouldn't need a second one. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: configure: try to use -Werror=unknown-warning-option if available (2/2)
by Alexandre Julliard May 16, 2013

May 16, 2013

Austin English <austinenglish(a)gmail.com> writes: > @@ -1773,6 +1773,7 @@ then > fi > > dnl Check for some compiler flags > + WINE_TRY_CFLAGS([-Werror=unknown-warning-option]) > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) I don't think we want to build with that, it should be used only for the configure checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: vbscript: Round half to even in to_int.
by Marvin May 16, 2013

May 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25581 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Participate in GSoC
by Adam Chyła May 16, 2013

May 16, 2013

Hi all, I'm a student who would like to participate in GSoC with task "Tools - Winetest Graphical User Interface". What should I do? Adam Ch.

2 1

Re: WM_IME_REQUEST gets passed into ImmIsUIMessage
by Alexandre Julliard May 15, 2013

May 15, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/imm32/imm.c | 2 ++ > dlls/user32/defwnd.c | 19 +++++++++++++++++++ > dlls/winemac.drv/ime.c | 34 ++++++++++++++++++++++++++++++++++ > dlls/winex11.drv/ime.c | 34 ++++++++++++++++++++++++++++++++++ > 4 files changed, 89 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -M imm32.dll -T ../../.. -p imm32_test.exe.so imm32.c && touch imm32.ok imm32.c:580: Test failed: ImmIsUIMessageA returned 1 for 288 imm32.c:584: Test failed: ImmIsUIMessageA returned 1 for 288 make: *** [imm32.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] wined3d: Use d3d_level_from_gl_info in match_dx10_capable
by Henri Verbeet May 15, 2013

May 15, 2013

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -613,14 +635,7 @@ static BOOL match_apple_nonr500ati(const struct wined3d_gl_info *gl_info, const > static BOOL match_dx10_capable(const struct wined3d_gl_info *gl_info, const char *gl_renderer, > enum wined3d_gl_vendor gl_vendor, enum wined3d_pci_vendor card_vendor, enum wined3d_pci_device device) > { > - /* DX9 cards support 40 single float varyings in hardware, most drivers report 32. ATI misreports > - * 44 varyings. So assume that if we have more than 44 varyings we have a dx10 card. > - * This detection is for the gl_ClipPos varying quirk. If a d3d9 card really supports more than 44 > - * varyings and we subtract one in dx9 shaders its not going to hurt us because the dx9 limit is > - * hardcoded > - * > - * dx10 cards usually have 64 varyings */ > - return gl_info->limits.glsl_varyings > 44; > + return d3d_level_from_gl_info(gl_info) >= 10; > } > I'm not sure d3d_level_from_gl_info() is quite reliable enough for this. For example, Mesa doesn't implement EXT_gpu_shader4, and possibly never will. Using an actual hardware limit seems more reliable.

1 0

Re: [PATCH 5/6] d3d: d3d9ex does not do video memory accounting for D3DPOOL_DEFAULT resources
by Henri Verbeet May 15, 2013

May 15, 2013

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -922,6 +922,8 @@ enum wined3d_display_rotation > #define WINED3DCREATE_DISABLE_DRIVER_MANAGEMENT 0x00000100 > #define WINED3DCREATE_ADAPTERGROUP_DEVICE 0x00000200 > > +#define WINED3DCREATE_NO_VIDMEM_ACCOUNTING 0x10000000 > + I think it makes more sense to make this a wined3d_create() flag, and in invert it, since we also want this for d3d10+. E.g. something along the lines of WINED3D_NO_GPU_VMM.

1 0

Wacom Graphire3 tablet not detected as tablet (MacOSX 10.8)
by Andrey Upadyshev May 14, 2013

May 14, 2013

Hi, I have Wacom Graphire3 tablet and it's working well under Windows, MacOS or MacOS + X (Inkscape). But Wine can't detect it as tablet and disables the wintab support. The actual stylus device is Device 6 [id 8|name pen|type |num_classes 2|use 4], but log says it is not apparently a tablet cursor type device. There is a wintab log: > trace:wintab32:DllMain 0x43d60000, 1, 0x0 > trace:wintab32:DllMain Initialization > trace:wintab32:TABLET_WindowProc Incoming Message 0x81 (0x00000000, > 0x0032f6b0) > trace:wintab32:TABLET_WindowProc Incoming Message 0x83 (0x00000000, > 0x0032f400) > trace:wintab32:TABLET_WindowProc Incoming Message 0x1 (0x00000000, > 0x0032f6b0) > trace:wintab32:TABLET_WindowProc Incoming Message 0x5 (0x00000000, > 0x00000000) > trace:wintab32:TABLET_WindowProc Incoming Message 0x3 (0x00000000, > 0x00000000) > trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x10126 > trace:wintab32:X11DRV_LoadTabletInfo XListInputDevices reports 9 devices > trace:wintab32:X11DRV_LoadTabletInfo Device 0: [id 2|name Virtual core > pointer|type |num_classes 2|use 0] > trace:wintab32:X11DRV_LoadTabletInfo Device 1: [id 3|name Virtual core > keyboard|type |num_classes 1|use 1] > trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 4|name Virtual core > XTEST pointer|type |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 2 [name Virtual core > XTEST pointer|type ]; not apparently a tablet cursor type device. If this > is wrong, please report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 3: [id 5|name Virtual core > XTEST keyboard|type |num_classes 1|use 3] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo No buttons, Non Tablet Device > trace:wintab32:X11DRV_LoadTabletInfo Device 4: [id 6|name xquartz virtual > pointer|type |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 4 [name xquartz > virtual pointer|type ]; not apparently a tablet cursor type device. If > this is wrong, please report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 5: [id 7|name xquartz virtual > keyboard|type |num_classes 1|use 3] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo No buttons, Non Tablet Device > trace:wintab32:X11DRV_LoadTabletInfo Device 6: [id 8|name pen|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 6 [name pen|type ]; > not apparently a tablet cursor type device. If this is wrong, please > report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 7: [id 9|name cursor|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo ButtonInput 0: [class 1|length > 12|num_buttons 3] > trace:wintab32:X11DRV_LoadTabletInfo ValidatorInput 1: [class 2|length > 80|num_axes 5|mode 1|motion_buffer 256] > trace:wintab32:trace_axes Axis 0: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 1: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 2: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 3: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:trace_axes Axis 4: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:X11DRV_LoadTabletInfo Device 8: [id 10|name eraser|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo ButtonInput 0: [class 1|length > 12|num_buttons 3] > trace:wintab32:X11DRV_LoadTabletInfo ValidatorInput 1: [class 2|length > 80|num_axes 5|mode 1|motion_buffer 256] > trace:wintab32:trace_axes Axis 0: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 1: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 2: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 3: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:trace_axes Axis 4: [resolution 1|min_value > -65536|max_value 65536] > warn:wintab32:X11DRV_LoadTabletInfo Did not find a valid stylus, unable to > determine system context parameters. Wintab is disabled. > It would be great if someone can fix this problem. Thank you, Andrey Upadyshev

1 0

Re: [PATCH 3/3] d3dx9_36: Add support for D3DFMT_P8 and conversion to other ARGB formats + tests.
by Alexandre Julliard May 14, 2013

May 14, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -36,6 +36,16 @@ static void la_to_rgba(const struct vec4 *la, struct vec4 *rgba) > rgba->w = la->w; > } > > +static void index_to_rgba(const struct vec4 *index, struct vec4 *rgba, const PALETTEENTRY *palette) > +{ > + ULONG idx = (ULONG)(index->x * 255.0f + 0.5f); > + > + rgba->x = palette[idx].peBlue / 255.0f; > + rgba->y = palette[idx].peGreen / 255.0f; > + rgba->z = palette[idx].peRed / 255.0f; > + rgba->w = palette[idx].peFlags / 255.0f; > +} PALETTEENTRY doesn't seem to be the right type for what you need. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32/tests: Added capture test for child window when parent window is disabled.(try 4)
by Alexandre Julliard May 14, 2013

May 14, 2013

Guo Jian <orzhvs(a)gmail.com> writes: > This is my first patch, could you please have a review? Thank you. Looks OK, but you could probably merge it into one of the existing capture tests, it doesn't really need a brand-new window. Also when sending patches that depend on each other, please number them so that the testbot can make sense of it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (resend).
by Alexandre Julliard May 14, 2013

May 14, 2013

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-streaming sites as well). > > With this patch the SIO_ADDRESS_LIST_CHANGE call gets passed on to > NotifyAddrChange, which effectively fixes a problem where Silverlight > apps can loop forever calling SIO_ADDRESS_LIST_CHANGE (Bug #32328). > Part 2 actually implements the NotifyAddrChange call on Linux, though > this patch is sufficient to resolve the bug since the overlapped IO > event no longer gets triggered. The notification is supposed to be tied to the socket. I don't think that NotifyAddrChange can do the job. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: Disable the zoom button for windows that are disabled.
by Ken Thomases May 14, 2013

May 14, 2013

Hi Kevin, As mentioned in the other thread, I'm not seeing the problem that this is meant to solve on 10.6. I will test 10.7+ tomorrow. Also, I'm pretty sure that setting the style mask after disabling the buttons can reenable them. At least in some versions of the frameworks, we've seen that -setStyleMask: basically resets the standard buttons from scratch. Indeed, in my testing, this patch reenables the close and minimize buttons on a disabled window. Regards, Ken

1 2

[PATCH 1/2] Added test to show EnableWindow cause wrong ReleaseCapture (try 3)
by Guo Jian May 14, 2013

May 14, 2013

Hello everyone, This is my first patch to wine, which has been submitting since the last day. Please help that what is the safe way sending patches that makes sure the patch is not corrupt by my mail client? Is it the most correct way to attach a path with .txt suffix rather than past inline? Or which mail client should I use that may avoid this problem? Thunderbird wraps long lines and join lines terminating with a space, I have to manually correct that, it does slows me down. Thanks. Guo Jian A window will lose capture if it's disabled, but it's children should not. Related to bug 33542. The test is to show that mouse capture of a window is lost when disabling its parent window. It has been tested fine with newtestbot. --- dlls/user32/tests/win.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+)

2 1

Re: user32: Use PostMessage to send WM_DRAWCLIPBOARD
by Alexandre Julliard May 13, 2013

May 13, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/clipboard.c | 4 +-- > dlls/user32/tests/clipboard.c | 78 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 80 insertions(+), 2 deletions(-) We already have tests that show that this is wrong: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:12683: Test failed: set viewer NULL->1: 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12690: Test failed: clear clipbd (viewer=owner=1): 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12695: Test failed: clear clipbd (viewer=1, owner=2): 1: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12700: Test failed: set viewer 1->1: 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12751: Test failed: clear clipbd (no viewer, owner=1): 0: the msg sequence is not complete: expected 0307 - actual 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Pass the state and private data to shader_select
by Henri Verbeet May 13, 2013

May 13, 2013

On 12 May 2013 15:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Disable shaders */ > - device->shader_backend->shader_select(context, WINED3D_SHADER_MODE_NONE, WINED3D_SHADER_MODE_NONE); > + device->shader_backend->shader_select(context, WINED3D_SHADER_MODE_NONE, WINED3D_SHADER_MODE_NONE, > + NULL, device->shader_priv); I think that's a bit questionable. Passing NULL state happens to work for this set of arguments, but I don't think we want that to be part of the interface.

3 3

Re: po: Fix typos in German translation
by Julian Rüger May 13, 2013

May 13, 2013

Hi André, > -msgstr "Datagramme gesendet" > +msgstr "Datenpakete gesendet" In all my university classes, (UDP) Datagrams were translated or referred to as "Datagramme" and more or less strictly distinguished from packets. "Vollzugriff" vs. "voller Zugriff" is a matter of taste, I picked the first because back when I used Windows, that was a common term to read, but that could have just been my firewall or something. I would have preferred for it to be added to Francois' wordlist, but whatever. Best, Julian

2 1

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify (try 2).
by Marvin May 13, 2013

May 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25553 Your paranoid android. === WXPX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === WVISTAX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === W7PROX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === TEST64_W7SP1 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120

1 0

Re: [PATCH 4/5] wined3d: Explicitly pass the state to shader_load_constants
by Henri Verbeet May 13, 2013

May 13, 2013

On 12 May 2013 15:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -806,7 +806,8 @@ struct wined3d_shader_backend_ops > void (*shader_deselect_depth_blt)(void *shader_priv, const struct wined3d_gl_info *gl_info); > void (*shader_update_float_vertex_constants)(struct wined3d_device *device, UINT start, UINT count); > void (*shader_update_float_pixel_constants)(struct wined3d_device *device, UINT start, UINT count); > - void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS); > + void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS, > + const struct wined3d_state *state, void *shader_priv); > void (*shader_load_np2fixup_constants)(void *shader_priv, const struct wined3d_gl_info *gl_info, > const struct wined3d_state *state); > void (*shader_destroy)(struct wined3d_shader *shader); > I think we'll want shader_priv to be the first argument, for consistency with the other calls. I don't think usePS and useVS are needed anymore.

1 0

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.
by Hans Leidekker May 13, 2013

May 13, 2013

On Mon, 2013-05-06 at 19:23 -0600, Erich E. Hoover wrote: > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -210,8 +210,14 @@ DWORD WINAPI AllocateAndGetIpAddrTableFromStack(PMIB_IPADDRTABLE *ppIpAddrTable, > */ > BOOL WINAPI CancelIPChangeNotify(LPOVERLAPPED overlapped) > { > - FIXME("(overlapped %p): stub\n", overlapped); > - return FALSE; > + HANDLE handle; > + > + TRACE("(overlapped %p)\n", overlapped); > + > + if (!overlapped) > + return FALSE; > + handle = (HANDLE) overlapped->u.Pointer; > + return TerminateThread(handle, STATUS_CANCELLED); > } TerminateThread is not the right tool here. If the thread is blocked on the recv call while being terminated it will leak the netlink socket. You'd need a way to synchronize the threads, but an overhead of one thread per caller is rather costly in the first place. This suggests that the server should poll the socket.

3 9

Re: [2/2] server: Remove a not necessary check for 'current' being not NULL.
by Alexandre Julliard May 13, 2013

May 13, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > 'current' is already dereferenced twice before this point. > --- > server/request.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) You can't do that. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [website] Simplified Chinese translation for release 1.5.30
by Qian Hong May 13, 2013

May 13, 2013

2013/5/11 Jactry Zeng <jactry92(a)gmail.com>: > + <li>WinInet 对代理旁路的支持。</li> This translation seems suspect, but I don't have a very good alternative yet. In 'Internet Options' setting of MSIE7, 'Bypass proxy server for local address' is translated to '跳过本地地址的代理服务器' Thanks for the work. -- Regards, Qian Hong - http://www.winehq.org

2 2

IPC between linux processes and wine processes
by Alexandre Bique May 12, 2013

May 12, 2013

Hi, I plan to write a Linux VST bridge to Windows VST. This could improve windows VST support in our native DAW. I wonder what is the best strategy and what do you recommend? - spawn a wine vst host process from the linux vst and then do IPC through unix socket - spawn a wine vst host process from the linux vst and then do IPC through tcp socket - spawn a wine vst host process from the linux vst and then do IPC through shared memory - load the windows vst into the Linux process and directly call its functions (with appropriate calling convention). Thanks a lot! Regards, -- Alexandre Bique

3 4

Re : Full software of Wine version 1.4
by Nick Kucan May 11, 2013

May 11, 2013

Dear Sir/madam, My name is Nick Kucan and I have ubuntu 11.04 at home - In the last three month I had a major issue with my the operating system (which I am currently investigating the source error) - Each time the system crashes (fails to load and screen says "input signal out of range" and does not load Ubuntu 11.04). I have tried Ubuntu 12.10 but unfortunatly there is a major issue with my modem - Every time i tried to connect - less than a second later - it cuts it right off. I have tried get help with the ubuntu website and provider - no such luck at this point of time. There is no such issue with version 11.04. I am forced to re-install and restore from backup - the wine program that I backed up wont even load so I am forced to download at least 170mb (and at least 1 hour to download from your headquaters website which I am tired of downloading the last 30 times - that cost me a lot of money to from my pre-paid account. I wish to download that .deb package from another source and burn into a dvd for my personal use only instead of downloading every time from your website each time and restore everything from its point. Can provide me a good link that I can directly download that file and I need to burn only one copy for my home pc so it can make my life a little easy - this copy of windows wine will NOT be distributed to anyone else except for my own stand alone pc in an emergency so that I can restore it back the way it is please. I have backed up the firefox and adobe flashplayer on the backup dvd - it works fine - the only issue is that the wine program full file cant get it working so its forced me to go back to the software source and download that painfully long software again!. Can u help me please.... Nick Kucan.

2 1

Re: [1/2] winex11: Cache XRandR 1.0 display mode. (try 2)
by Ruslan Kabatsayev May 10, 2013

May 10, 2013

Hi, Won't such code fail if the mode is changed outside wine? Regards, Ruslan On Fri, May 10, 2013 at 8:07 PM, Sam Edwards <cfsworks(a)gmail.com> wrote: > > > >

2 1

Re: [1/3] winex11: Select for XRandR screen change events and implement an event handler.
by Alexandre Julliard May 10, 2013

May 10, 2013

Sam Edwards <cfsworks(a)gmail.com> writes: > This patch adds an event handler to xrandr.c to process > RRScreenChangeNotify events, so that when non-Wine applications change > the display resolution, Wine can find out about it. > > Two main discussion points: > > - Previously, there was nothing pulling events out of gdi_display's > queue, thus necessitating the need for a new event handler. I opted to > put it in xrandr.c since this handler only manages XRandR events, but > it might be cleaner to move it over to event.c. > > - Are we okay with having to call the event handler, or would this > work better in a continuously-running background thread instead? It's okay only because you are not actually calling it ;-) But no, you can't select for events on the gdi display; actually I don't think you want to do it this way at all. Handling external resizes should be done in the desktop process, and most likely involves the wineserver too. It certainly won't be an easy task. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [2/3] kernel32: Terminate threads before unloading DLLs on process exit.
by Alexandre Julliard May 10, 2013

May 10, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > If it's not yet time to make this change please let me know what else needs > to be tested/fixed/investigated. The heap behavior would need testing, since freeing memory is probably the most common thing done in a detach routine. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] d3dcompiler: Add a LUT to find compilation targets info. (try 3)
by Alexandre Julliard May 10, 2013

May 10, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > - if (strlen(target) != 6 || target[1] != 's' || target[2] != '_' || target[4] != '_') > + for (i = 0; i < nb_targets; i++) > { > - FIXME("Unknown compilation target %s.\n", debugstr_a(target)); > - return D3DERR_INVALIDCALL; > + if (!strcmp(target, targets_info[i].name) || > + (targets_info[i].altname && !strcmp(target, targets_info[i].altname))) A binary search would be much better. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ieframe: Added more InternetExplorer object tests.
by Marvin May 10, 2013

May 10, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25508 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: [PATCH] mscms: Use lcms2, when available
by wine.dev＠web.de May 10, 2013

May 10, 2013

Hi Hans. >> lcms2 was released on 8. May 2010 >> lcms v1 is on the way to be phased out in the newest >> distribution versions. >Are there any distributions that have released without v1? I don't know, but Ubuntu has a bug for replacing lcms v1. There is no reason, that Wine is the last app, which depends on lcms v1. -- By by ... Detlef

4 4

Re: Re: Ask for mentor - Improve Bcrypt
by Marek Chmiel May 10, 2013

May 10, 2013

Hey Kaiyi Zhang, Welcome to wine dev! If you decide to move forward with this(DH and DSS), I wish to share with you all that I have finished up to now. Using a few things from RSAENH I have all the related algorithms functioning. Also using LibTomCrypt I have partially implemented DSA but you would have to choose on the PRNG that DSA will use. My plan was to use RC4 but have not gotten to test that. I have yet to touch anything with DH_EPHEM (Ephemeral) or DH_SF (Store and Forward). If you have any questions shoot them to Juan or me (Juan is the better choice). Best of luck! -- Marek >Hi Kaiyi Zhang, > >(or is Zhang Kaiyi?) > >I think there's a little misconception in your proposal. Bcrypt the >algorithm is not the same as the BCrypt functions in crypt32. I believe >that Microsoft redesigned their CryptoAPI and more or less renamed their >functions BCrypt*. I don't believe they have any relationship to the Bcrypt >algorithm by Niels Provos and David Mazieres. I don't know how many >applications depend on the Bcrypt* functions in newer crypt32 >implementations, vs. the the Crypt* functions that are present in all >versions of crypt32. > >If you want feedback on Wine crypto stuff, I'm probably the best to help >you with that. Sorry if I've been a little absent, I'm pretty busy between >my family and my day job of late. > >I have another idea for you that I think is tractable, and perhaps up your >alley. The DH and DSS algorithms are still unimplemented in Wine. We >already have tests for them, so I think it should be possible to contribute >implementations. See the tests in dlls/dssenh/tests. > >I hope that helps. >--Juan

2 1

Ask for mentor - Improve Bcrypt
by Kaiyi Zhang May 10, 2013

May 10, 2013

Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of GSOC. However, There are some exams which takes a lot of time, So lack of communication with the wine developers. I know it is late to apply for GSoC, however, I'm still interesting to the cryptography work in Wine even if I'm not accept as an official GSoC2013 student. Cryptography work is difficult, and Wine is difficult, so cryptography in Wine is double difficult for a beginner like me, could I ask for a mentor for the cryptography work even if my proposal is not accepted? To my dear kindly future mentor: I don't know how to thank you, but I'll work hard on contributing to the Wine project as more as I can. Sincerely appreciate. My idea is bcrypt improvement, I think it's very suitable for me, I learned the information security. Cryptography is one of my courses. I once development a Elliptic curve cryptography Demonstration system which makes the ECC Graphical. And i found there is blank in bcrypt, I want to do some improvement in this. I know there it's difficult for me to develop. but i can code some test code firstly. I read the dlls/rsaendh/tests/rsaenh.c: test_hashes(),test_des(),test_rsa() etc. and test the code on ubuntu successfully. Here is my plan: Week 1 - Week 2 - Get the Winedebug and document more adept - Get more information about bcrypt - Bcrypt Wiki: http://en.wikipedia.org/wiki/Bcrypt - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - File of Bcrypt: http://bcrypt.sourceforge.net/ - Read the Document of MSDN about Bcrypt and code some examples - MSDN about Bcrypt: http://msdn.microsoft.com/en-us/library/windows/desktop/aa833130(v=vs.85).a… Week 3 - Week 5 -Read some wine tests code and run some tests like: - the basic encryption dll/crypt32/ - Understand the bcrypt algorithm, there is a lot of code for learning like: - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - https://github.com/rg3/bcrypt - https://code.google.com/p/py-bcrypt/source/browse/bcrypt/bcrypt.c Week 6 - Week 11 - Code the BCrypt. According to the MSDN The Steps of Bcrypt - Open the Algorithm Provider - Get or Set Algorithm Properties - Create or Import a key - Perform Cryptiographic Operations - Close the Algorithm Provider There is a cross platform Bcrypt at http://bcrypt.sourceforge.net. if it is possible we can use it and its license compatible with the wine lgpl license. - add stub functions for Tests functions() and code the Tests functions(). The dlls/rsaenh/tests/rsaenh.c is a good reference. encrypt the pdData and compare with the right value. stub BCryptCreateHash() BCryptHashData() BCryptDuplicateHash() BCryptDuplicateHash BCryptDestroyHash() for test_hashes(). stub BCryptGenerateSymmetricKey() BCryptKeyDerivation() BCryptDestroyKey() for test_key_derivation(). stub BCryptGenRandom() for test_gen_random(). Week 12 - End - There are also some more cryptions need to tests, I can do more improvement these Thank you.

2 2

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.
by Alexandre Julliard May 9, 2013

May 9, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) > { > ID3DXFileImpl *object; > HRESULT ret; > + const char expand_string[] = "expand_string"; > > TRACE("(%p)\n", d3dxfile); > > @@ -701,6 +702,11 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) > object->ID3DXFile_iface.lpVtbl = &ID3DXFile_Vtbl; > object->ref = 1; > > + /* Enable string expansion extension in d3dxof */ > + ret = IDirectXFile_RegisterTemplates(object->dxfile, (void*)expand_string, sizeof(expand_string)); > + if (ret != DXFILE_OK) > + ERR("Native d3dxof.dll used. Use builtin one to avoid problem.\n"); That's really ugly. You have to find a better way. -- Alexandre Julliard julliard(a)winehq.org

2 4

Patches 96113 & 96114
by Christian Costa May 9, 2013

May 9, 2013

Hi, Is there anything wrong with these patches? http://source.winehq.org/patches/data/96113 http://source.winehq.org/patches/data/96114 Christian

1 0

Re: [PATCH 2/3] oleaut32: COM cleanup for ITypeInfo object
by Andrew Eikum May 9, 2013

May 9, 2013

Looks like I missed replacing the ITypeInfo casts with impl_from calls, e.g.: static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, ITypeComp * *ppTComp) { ITypeInfoImpl *This = (ITypeInfoImpl *)iface; You can apply these, or wait until I amend them to fix that, too. Whichever. Andrew On Wed, May 08, 2013 at 03:12:45PM -0500, Andrew Eikum wrote: > --- > dlls/oleaut32/typelib.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index e62fa84..c6d2189 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -1094,8 +1094,8 @@ typedef struct tagTLBImplType > /* internal TypeInfo data */ > typedef struct tagITypeInfoImpl > { > - const ITypeInfo2Vtbl *lpVtbl; > - const ITypeCompVtbl *lpVtblTypeComp; > + ITypeInfo2 ITypeInfo2_iface; > + ITypeComp ITypeComp_iface; > LONG ref; > BOOL not_attached_to_typelib; > TYPEATTR TypeAttr ; /* _lots_ of type information. */ > @@ -1125,7 +1125,7 @@ typedef struct tagITypeInfoImpl > > static inline ITypeInfoImpl *info_impl_from_ITypeComp( ITypeComp *iface ) > { > - return (ITypeInfoImpl *)((char*)iface - FIELD_OFFSET(ITypeInfoImpl, lpVtblTypeComp)); > + return CONTAINING_RECORD(iface, ITypeInfoImpl, ITypeComp_iface); > } > > static const ITypeInfo2Vtbl tinfvt; > @@ -4884,7 +4884,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if (pTypeInfo->Name && !strcmpW(pTypeInfo->Name, szName)) > { > *pDescKind = DESCKIND_TYPECOMP; > - pBindPtr->lptcomp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + pBindPtr->lptcomp = &pTypeInfo->ITypeComp_iface; > ITypeComp_AddRef(pBindPtr->lptcomp); > TRACE("module or enum: %s\n", debugstr_w(szName)); > return S_OK; > @@ -4894,7 +4894,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if ((pTypeInfo->TypeAttr.typekind == TKIND_MODULE) || > (pTypeInfo->TypeAttr.typekind == TKIND_ENUM)) > { > - ITypeComp *pSubTypeComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + ITypeComp *pSubTypeComp = &pTypeInfo->ITypeComp_iface; > HRESULT hr; > > hr = ITypeComp_Bind(pSubTypeComp, szName, lHash, wFlags, ppTInfo, pDescKind, pBindPtr); > @@ -4910,7 +4910,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if ((pTypeInfo->TypeAttr.typekind == TKIND_COCLASS) && > (pTypeInfo->TypeAttr.wTypeFlags & TYPEFLAG_FAPPOBJECT)) > { > - ITypeComp *pSubTypeComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + ITypeComp *pSubTypeComp = &pTypeInfo->ITypeComp_iface; > HRESULT hr; > ITypeInfo *subtypeinfo; > BINDPTR subbindptr; > @@ -5013,9 +5013,9 @@ static HRESULT WINAPI ITypeLibComp_fnBindType( > if (pTypeInfo->Name && !strcmpiW(pTypeInfo->Name, szName)) > { > TRACE("returning %p\n", pTypeInfo); > - *ppTInfo = (ITypeInfo *)&pTypeInfo->lpVtbl; > + *ppTInfo = (ITypeInfo *)&pTypeInfo->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > - *ppTComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + *ppTComp = &pTypeInfo->ITypeComp_iface; > ITypeComp_AddRef(*ppTComp); > return S_OK; > } > @@ -5046,8 +5046,8 @@ static ITypeInfoImpl* ITypeInfoImpl_Constructor(void) > pTypeInfoImpl = heap_alloc_zero(sizeof(ITypeInfoImpl)); > if (pTypeInfoImpl) > { > - pTypeInfoImpl->lpVtbl = &tinfvt; > - pTypeInfoImpl->lpVtblTypeComp = &tcompvt; > + pTypeInfoImpl->ITypeInfo2_iface.lpVtbl = &tinfvt; > + pTypeInfoImpl->ITypeComp_iface.lpVtbl = &tcompvt; > pTypeInfoImpl->ref = 0; > pTypeInfoImpl->hreftype = -1; > pTypeInfoImpl->TypeAttr.memidConstructor = MEMBERID_NIL; > @@ -5238,7 +5238,7 @@ static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, > > TRACE("(%p)->(%p)\n", This, ppTComp); > > - *ppTComp = (ITypeComp *)&This->lpVtblTypeComp; > + *ppTComp = &This->ITypeComp_iface; > ITypeComp_AddRef(*ppTComp); > return S_OK; > } > @@ -6999,7 +6999,7 @@ static HRESULT WINAPI ITypeInfo_fnGetRefTypeInfo( > > if ((This->hreftype != -1) && (This->hreftype == hRefType)) > { > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > result = S_OK; > } > @@ -7913,7 +7913,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > if (FAILED(hr)) > return hr; > *pDescKind = DESCKIND_FUNCDESC; > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } else { > @@ -7923,7 +7923,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > if (FAILED(hr)) > return hr; > *pDescKind = DESCKIND_VARDESC; > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } > @@ -7934,7 +7934,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > ITypeInfo *pTInfo; > ITypeComp *pTComp; > HRESULT hr; > - hr=ITypeInfo_GetRefTypeInfo((ITypeInfo *)&This->lpVtbl, This->impltypes[0].hRef, &pTInfo); > + hr=ITypeInfo2_GetRefTypeInfo(&This->ITypeInfo2_iface, This->impltypes[0].hRef, &pTInfo); > if (SUCCEEDED(hr)) > { > hr = ITypeInfo_GetTypeComp(pTInfo,&pTComp); > -- > 1.8.2.2 > > > >

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow
by Qian Hong May 9, 2013

May 9, 2013

Hello Guo Jian, On Fri, May 10, 2013 at 1:36 AM, Guo Jian <orzhvs(a)gmail.com> wrote: > A window should not lose mouse capture even when it's parent window is > disabled. Did you forget to remove the todo_wine introduced in [patch 1/2]? Thanks for your work on it. -- Regards, Qian Hong

2 1

Re: [PATCH] user32: initialize just the members we need (Coverity)
by Marvin May 9, 2013

May 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25499 Your paranoid android. === W2KPROSP4 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WXPPROSP2 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=4154256 max=0 scroll.c:446: Test failed: unexpected initialization === WXPX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=32203072 max=0 scroll.c:446: Test failed: unexpected initialization === W2K3R2SESP2 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WVISTAX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=16706472 scroll.c:446: Test failed: unexpected initialization === W2K8SE (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === W7PROX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2684764 max=1965166079 scroll.c:446: Test failed: unexpected initialization === TEST64_W7SP1 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2684764 max=1952452095 scroll.c:446: Test failed: unexpected initialization === WXPX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WVISTAX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization === W7PROX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization === TEST64_W7SP1 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization

1 0

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture
by Qian Hong May 8, 2013

May 8, 2013

Hi orzhvs, Thanks for your work on it, however, it seems gmail's line wrap 'feature' (hmm, isn't that a bug...) breaks your patch, you could try fight with that feature or send your patch as attachment instead.

1 0

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture
by Marvin May 8, 2013

May 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25486 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3dx9_36: Fix typo in ID3DXFileDataImpl_GetName.
by Dmitry Timoshkov May 8, 2013

May 8, 2013

Christian Costa <titan.costa(a)gmail.com> wrote: > - if (!name || !size) > + if (!name && !size) > return E_POINTER; > > dxfile_size = *size; So, what happens if name is not NULL, but size is? -- Dmitry.

2 1

Ask for mentor - Improve Bcrypt
by Kaiyi Zhang May 8, 2013

May 8, 2013

Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of GSOC. However, There are some exams which takes a lot of time, So lack of communication with the wine developers. I know it is late to apply for GSoC, however, I'm still interesting to the cryptography work in Wine even if I'm not accept as an official GSoC2013 student. Cryptography work is difficult, and Wine is difficult, so cryptography in Wine is double difficult for a beginner like me, could I ask for a mentor for the cryptography work even if my proposal is not accepted? To my dear kindly future mentor: I don't know how to thank you, but I'll work hard on contributing to the Wine project as more as I can. Sincerely appreciate. My idea is bcrypt improvement, I think it's very suitable for me, I learned the information security. Cryptography is one of my courses. I once development a Elliptic curve cryptography Demonstration system which makes the ECC Graphical. And i found there is blank in bcrypt, I want to do some improvement in this. I know there it's difficult for me to develop. but i can code some test code firstly. I read the dlls/rsaendh/tests/rsaenh.c: test_hashes(),test_des(),test_rsa() etc. and test the code on ubuntu successfully. Here is my plan: Week 1 - Week 2 - Get the Winedebug and document more adept - Get more information about bcrypt - Bcrypt Wiki: http://en.wikipedia.org/wiki/Bcrypt - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - File of Bcrypt: http://bcrypt.sourceforge.net/ - Read the Document of MSDN about Bcrypt and code some examples - MSDN about Bcrypt: http://msdn.microsoft.com/en-us/library/windows/desktop/aa833130(v=vs.85).a… Week 3 - Week 5 -Read some wine tests code and run some tests like: - the basic encryption dll/crypt32/ - Understand the bcrypt algorithm, there is a lot of code for learning like: - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - https://github.com/rg3/bcrypt - https://code.google.com/p/py-bcrypt/source/browse/bcrypt/bcrypt.c Week 6 - Week 11 - Code the BCrypt. According to the MSDN The Steps of Bcrypt - Open the Algorithm Provider - Get or Set Algorithm Properties - Create or Import a key - Perform Cryptiographic Operations - Close the Algorithm Provider There is a cross platform Bcrypt at http://bcrypt.sourceforge.net. if it is possible we can use it and its license compatible with the wine lgpl license. - add stub functions for Tests functions() and code the Tests functions(). The dlls/rsaenh/tests/rsaenh.c is a good reference. encrypt the pdData and compare with the right value. stub BCryptCreateHash() BCryptHashData() BCryptDuplicateHash() BCryptDuplicateHash BCryptDestroyHash() for test_hashes(). stub BCryptGenerateSymmetricKey() BCryptKeyDerivation() BCryptDestroyKey() for test_key_derivation(). stub BCryptGenRandom() for test_gen_random(). Week 12 - End - There are also some more cryptions need to tests, I can do more improvement these Thank you.

1 0

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)
by Alexandre Julliard May 8, 2013

May 8, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > { > - FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), debugstr_w(lpCaption), > - uType, wLanguageId, f); > - return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); > + FIXME("(%p, %s, %s, %u, 0x%08x, 0x%08x): semi-stub\n", hWnd, debugstr_w(lpText), > + debugstr_w(lpCaption), uType, wLanguageId, f); > + return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); That sort of thing is not useful. If you are changing the function for other reasons you can update the trace, but otherwise it's just adding noise in the change history. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: gdi32: Simplify font->aveWidth sanity-checking to fix possible division by zero. (try 2)
by Christian Costa May 8, 2013

May 8, 2013

Le 08/05/2013 11:45, Sam Edwards a écrit : > After feedback from Dmitry (thanks!), I redid this patch with the > following changes: > > * I misunderstood before what the test did; I initially thought this > was just a workaround to get aveWidth to behave, but as it turns out, > Windows has the same "maximum ratio of 100" limit. I changed the > comment to reflect that; hopefully this stops someone else from making > my mistake. :) > * Negative aveWidth checking is removed. I agree that there should be > a test to put this in, but Windows treats negative aveWidths as > invalid (according to Aric), so it can't be tested on Windows. That's > a much bigger mess than a simple "fix divide by zero" patch is worth. > * The division is done differently, to avoid potential overflow > problems. The result of the comparison is still exactly the same as > before the patch, except zero values are now handled gracefully. > > This supersedes 96111 (which, I forgot to mention before, supersedes > 96053 and 96047). > > Best, > Sam > + if (font->aveWidth && + (font->aveWidth - 1) / 100 >= font->potm->otmTextMetrics.tmHeight) { - if ((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / font->potm->otmTextMetrics.tmHeight > 100) - { Hi Sam, The test in the if is not that long. Shouldn't this fit into a single like as the previous test? Christian

1 0

Re: [2/2] comdlg32: Add a test for nCopies/dmCopies returned by PrintDlg.
by Marvin May 8, 2013

May 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25483 Your paranoid android. === WVISTAX64 (32 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W2K8SE (32 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W7PROX64 (32 bit printdlg) === Timeout === TEST64_W7SP1 (32 bit printdlg) === Timeout === WVISTAX64 (64 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W7PROX64 (64 bit printdlg) === Timeout === TEST64_W7SP1 (64 bit printdlg) === Timeout

1 0

Re: [PATCH] mscms: Use lcms2, when available
by Hans Leidekker May 8, 2013

May 8, 2013

On Tue, 2013-05-07 at 22:45 +0200, Detlef Riekenberg wrote: > lcms2 was released on 8. May 2010 and should be present in important > distributions since a while. > > lcms v1 is on the way to be phased out in the newest distribution > versions. Are there any distributions that have released without v1?

1 0

Re: [1/5] kernel32: Add more remote process tests.
by Marvin May 8, 2013

May 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25479 Your paranoid android. === TEST64_W7SP1 (32 bit loader) === loader.c:1210: Test failed: expected thread exit code 195, got 259 loader.c:1210: Test failed: expected thread exit code 195, got 259 loader.c:1220: Test failed: expected WAIT_ABANDONED, got 0x102 loader.c:1236: Test failed: expected WAIT_OBJECT_0, got 0x102 loader.c:1238: Test failed: expected WAIT_OBJECT_0, got 0x102

2 1

Re: gdi32: Simplify font->aveWidth sanity-checking to remove possible division by zero.
by Dmitry Timoshkov May 8, 2013

May 8, 2013

Sam Edwards <cfsworks(a)gmail.com> wrote: > It makes the most sense to get rid of this sanity check altogether, but > until then, this should be a more robust way of doing it. > + * TODO: This sounds like a workaround for a much deeper bug involving > + * aveWidth's calculation. We should investigate if/why this is needed. > + */ This comment is confusing and wrong. There is a test case for which this check is required. > + if (font->aveWidth < 0 || font->aveWidth > font->potm->otmTextMetrics.tmHeight * 100) A check for an overflow is probably needed. Also a check for negative aveWidth should be a separate patch at best, and needs a test case. -- Dmitry.

1 0

Re: [PATCH 1/8] ole32: Use MSHLFLAGS_TABLEWEAK marshaling in CoRegisterClassObject.
by Alexandre Julliard May 7, 2013

May 7, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/ole32/compobj.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wscript.exe -T ../../.. -p wscript.exe_test.exe.so run.c && touch run.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x555a9468 (thread 0088), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x555a9468). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555a9468 ESP:0033f7d0 EBP:0033f868 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:555d2cac ECX:0033f810 EDX:00000001 ESI:00000000 EDI:0033f828 Stack dump: 0x0033f7d0: 0033f828 00000005 00000000 555c7f30 0x0033f7e0: 0033f814 001407a4 0000000c 0013c414 0x0033f7f0: 0000000c 00000000 00000000 00000000 0x0033f800: 00142020 00000000 00000000 001373b0 0x0033f810: ffffffff 00000000 0033f868 7b85382e 0x0033f820: 00000000 00000001 178fc166 4e24f585 Backtrace: =>0 0x555a9468 Global_CreateObject+0x178() in vbscript (0x0033f868) 1 0x555b6b3c DispatchEx_InvokeEx+0x65b(iface=<couldn't compute location>, id=<couldn't compute location>, lcid=<couldn't compute location>, wFlags=<couldn't compute location>, pdp=<couldn't compute location>, pvarRes=<couldn't compute location>, pei=<couldn't compute location>, pspCaller=<couldn't compute location>) [/home/julliard/wine/wine/dlls/vbscript/vbdisp.c:215] in vbscript (0x0033f958) 2 0x555b899d disp_call+0x9c(ctx=0x1373b0, disp=0x13f368, id=0xaf, dp=0x33fa40, retv=0x33fa80) [/home/julliard/wine/wine/dlls/vbscript/../../include/dispex.h:299] in vbscript (0x0033f9e8) 3 0x555af05c do_icall+0x20b(ctx=<is not available>, res=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:511] in vbscript (0x0033fa68) 4 0x555af1dd interp_icall+0x2c(ctx=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:558] in vbscript (0x0033fa98) 5 0x555aeb42 exec_script+0x191(ctx=<is not available>, func=<is not available>, this_obj=<is not available>, dp=<is not available>, res=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:1918] in vbscript (0x0033fb58) 6 0x555be4a7 exec_global_code+0x46(ctx=0x1373b0, code=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/vbscript.c:83] in vbscript (0x0033fb88) 7 0x555bedab VBScript_SetScriptState+0x17a() in vbscript (0x0033fbe8) 8 0x684fc3dd wWinMain+0x9bc(hInst=<couldn't compute location>, hPrevInst=<couldn't compute location>, cmdline=<couldn't compute location>, cmdshow=<couldn't compute location>) [/home/julliard/wine/wine/programs/wscript/../../include/activscp.h:1013] in wscript (0x0033fd88) 9 0x684fc671 wmain+0xb0(argc=0x5, argv=0x110380) [/home/julliard/wine/wine/dlls/winecrt0/exe_wmain.c:50] in wscript (0x0033fe18) 10 0x684fc5a5 __wine_spec_exe_wentry+0x84(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_wentry.c:36] in wscript (0x0033fe58) 11 0x7b86053c call_process_entry+0xb() in kernel32 (0x0033fe78) 12 0x7b86171b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0033feb8) 13 0x7bc7a800 call_thread_func_wrapper+0xb() in ntdll (0x0033fed8) 14 0x7bc7d70d call_thread_func+0x7c(entry=0x7b8616b0, arg=0x7ffdf000, frame=0x33ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2567] in ntdll (0x0033ffa8) 15 0x7bc7a7de call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 16 0x7bc5004e start_process+0x1d(kernel_start=0x7b8616b0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2691] in ntdll (0x0033ffe8) 17 0x6802947d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 18 0x6802953b wine_switch_to_stack+0x2a(func=0x7bc50030, arg=0x7b8616b0, stack=0x340000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffeb7758) 19 0x7bc55b27 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2747] in ntdll (0xffeb77c8) 20 0x7b867d00 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xffeb86d8) 21 0x7bc561f3 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2956] in ntdll (0xffeb8768) 22 0x680270c2 wine_init+0x2a1(argc=0x6, argv=0xffeb8cb4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xffeb87c8) 23 0x7bf00e7b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffeb8c08) 24 0x681cee46 __libc_start_main+0xe5() in libc.so.6 (0xffeb8c88) 0x555a9468 Global_CreateObject+0x178 in vbscript: movl 0x0(%eax),%edx -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] msvcrt: fix character/byte confusion in buffer overflow branch
by Max Kellermann May 7, 2013

May 7, 2013

The first memcpy() call in puts_clbk_str_w() confuses character count and byte count. It uses the number of characters (out->len) as number of bytes. This leaves half of the buffer undefined. Interestingly, the second memcpy() call in the same function is correct. This bug potentially makes applications expose internal (secret) data. Usually, the destination buffer is on the stack, and the stack often contains secrets. Therefore, one could argue that this bug constitutes a security vulnerability. --- dlls/msvcrt/printf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h index cfba4b7..8b749bc 100644 --- a/dlls/msvcrt/printf.h +++ b/dlls/msvcrt/printf.h @@ -48,7 +48,7 @@ static int FUNC_NAME(puts_clbk_str)(void *ctx, int len, const APICHAR *str) return len; if(out->len < len) { - memcpy(out->buf, str, out->len); + memcpy(out->buf, str, out->len*sizeof(APICHAR)); out->buf += out->len; out->len = 0; return -1;

3 4

Re: [PATCH] dlls/gdi32/freetype.c: A better divide by zero fix, report bad fonts.
by Sam Edwards May 7, 2013

May 7, 2013

On 05/06/2013 03:05 PM, Max TenEyck Woodbury wrote: > Just to make this clear, the most recent version of this patch is such > a graceful handling, right? I haven't worked on gdi32/freetype.c much, so I wouldn't be the one to say for sure (you should probably talk to Alexandre Julliard, Dmitry Timoshkov, or Huw Davies), but I'll give you my thoughts anyway: On 05/05/2013 12:48 PM, max(a)mtew.isa-geek.net wrote: > > + /* HACKHACK: If a font has tmHeight=0, let us know. */ > + if (!font->potm->otmTextMetrics.tmHeight) { > + ERR("Font named '%s' has tmHeight=0, aveWidth=%d!\n", font->ft_face->family_name, font->aveWidth); > + } > + Since we've learned that tmHeight=0 is not actually an error, it doesn't make sense to log it using ERR(...). I would suggest a TRACE(...) or (preferably) nothing at all. Also, when I wrote the ERR message patch for you, it was intended only to help you locate the problematic font and wasn't meant to be included in upstream Wine. (Which is why I marked it with HACKHACK and didn't bother to use debugstr_a.) As for the actual check, it makes sense to consider what the math is trying to do: If aveWidth is extremely large (relative to tmHeight), then assume aveWidth is wrong and set it to 0. If tmHeight is 0, then it seems reasonable to assume that aveWidth isn't valid either. I'm not sure why the sanity check cares to do this: (aveWidth+tmHeight-1) / tmHeight > 100 When it can just do this: (aveWidth+tmHeight-1) / tmHeight > 100 = (aveWidth-1)/tmHeight + 1 > 100 = (aveWidth-1)/tmHeight > 99 = (aveWidth-1) > tmHeight*99 = aveWidth > tmHeight*99 + 1 ≈ aveWidth > tmHeight*100 This allows us to write out tmHeight just once, and is also much easier to understand at a glance. So, I would just simplify the whole sanity check to something like: /* Make sure that the font has sane width/height ratio */ if (font->aveWidth > font->potm->otmTextMetrics.tmHeight * 100) { WARN("Ignoring too large font->aveWidth %d\n", font->aveWidth); font->aveWidth = 0; } But even then, the sanity check itself sounds like a workaround for a much deeper bug. Maybe add a "FIXME: Investigate why this is necessary" comment while you're at it? Best, Sam

2 1

Re: user32: Implement IMR_QUERYCHARPOSITION handling in the edit control
by Dmitry Timoshkov May 7, 2013

May 7, 2013

Aric Stewart <aric(a)codeweavers.com> wrote: > dlls/user32/edit.c | 21 +++++++++++++++++++++ > include/imm.h | 9 +++++++++ > 2 files changed, 30 insertions(+) Using usual 4 spaces indentation would slightly improve the readability. -- Dmitry.

2 2

Re: [PATCH 6/8] ieframe: Added more InternetExplorer object tests.
by Marvin May 7, 2013

May 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25463 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.
by Dmitry Timoshkov May 6, 2013

May 6, 2013

max(a)mtew.isa-geek.net wrote: > + if ( font->aveWidth && font->potm->otmTextMetrics.tmHeight ) { > + if (((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / > + font->potm->otmTextMetrics.tmHeight) > 100) { > WARN("Ignoring too large font->aveWidth %d\n", font->aveWidth); > font->aveWidth = 0; > } In which case font->potm->otmTextMetrics.tmHeight is going to be 0? -- Dmitry.

6 19

Re: d3dx9 [patch 2 / 3]: Avoid useless computations in D3DXMatrixAffineTransformation
by Rico Schüller May 6, 2013

May 6, 2013

On 05.05.2013 23:01, Nozomi Kodama wrote: > > + FLOAT xw, xx, xy, xz, yw, yy, yz, zw, zz; > I'm not very happy with the additional amount of variables... Please have a look at the attached patches. I think something like the first one (d3dx9: Apply rotationcenter only when a rotation is done.) should be done but has no influence on your patch (it is only attached, because the second patch influences the same part). 1. The amount of variables needed could be reduced to 3 by reordering the calculations (see patch 2, lines 36 - 58). This could also be done in your patch. Though I'm not sure that's a good idea ... comments and other opinions are welcome. Below this the points are not directly related to your patch: 2. In the next step we could also avoid a couple of multiplications by multiplying the scaling and adjusting the constants (see patch 2, lines 70 - 79). 3. We could also avoid the temps by reordering the calculation (Doing rotationcenter before the scaling). This way the tempxx could be avoided by using the out matrix directly. Cheers Rico

1 0

Re: d3dx9 [patch 1 / 3]: Avoid useless computations in D3DXMatrixAffineTransformation2D
by Rico Schüller May 6, 2013

May 6, 2013

On 05.05.2013 23:00, Nozomi Kodama wrote: > + FLOAT tmp1, tmp2; > > + tmp1 = cosf(rotation); > + tmp2 = sinf(rotation); > As of it is really clear what's in those variables, we may name them with a better name instead of tmp1/tmp2 ... but I'm fine with either version. Cheers Rico

1 0

Re: [1/3] server: Add a process flag indicating whether the process is terminating, use it to block thread creation in a bei
by Marvin May 6, 2013

May 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25445 Your paranoid android. === W7PROX64 (64 bit loader) === loader.c:1638: Test failed: expected WAIT_OBJECT_0, got 0x102 loader.c:1648: Test failed: expected thread exit code 196, got 259 loader.c:1210: Test failed: expected thread exit code 196, got 259 loader.c:1220: Test failed: expected WAIT_ABANDONED, got 0x102 loader.c:1236: Test failed: expected WAIT_OBJECT_0, got 0x102

2 1

GSoC 2013 - Registry Merging Project
by orzhvs May 4, 2013

May 4, 2013

Hi, everyone. Thank you for your viewing and comments on the proposal. Sorry that the rough plan is kind of mess and now I've rewritten this part a little more like a Time Schedule. I appreciate it if you have a glance at it. >From now to 27th, May. Work on some basic knowledge such as the usage of WineTestBot, getting familiar to debugging in wine or so, with help of the community, and do some favor if possible. 28th, May to 16th, June. Have interviews with the mentor at any time if convenient. Put forward my initial frame design and make puzzles clear, then adjust the plan under the guide of the mentor. So that the testing and development plan will be settled down after this part. 17th, June to 24, June. Carry out pre-work tests on variety versions of Windows. Write test reports which definite some questions and guesses. I wish to report some bugs during this part once I found one. Some invoking tests vie different layer of dlls both some additional test code (maybe for difference between versions of windows) to the existing one in the advapi32.dll should be written. 25th, June to 24th, July. Prophase of the official development. I'll implement almost all of the registry merging feature, especially code in the server part, so that I can submit my patch and looking forward to feedbacks as early as possible. 25th, July to 31st, July. The Mid-term evaluations will be finished and submitted. 1st, Auguest to 31st, August. Second stage of the development. Implement the rest part of our scheme. In this part, changes will be real-time reported in the mailing-list and apply improvement timely to make it closer to a final product. 1st, September to 27th, September. Only clean-ups and small fix of code should be left here. I'll write and verify the final evaluations and final test results, together with other documents produced in the project. Then with some modification from the mentor it's submitted to Google. The schedule will be carried out up to speed so that I may finish ahead of the end date in each part, in which case I'd like make prepare for the next part and contritube my spare time to the commutiry, rather that only such narrowed in one project. Considering that it may be a little fuzzy in boundarys of different phases, I came up with some Possible Milestones : 1.Pre-development test works are finished. 2.Complete the mostly full test codes. 3.Merging of classes in HKCU and HKLM is implemented in server part. 4.Merging is implemented in all aviable layer. 5.Compatibility of different Windows versions are fullfilled. 6.All the work including documents are done on time. That's most of the schedule I can think of now, and I'll be very happy to improve it before submitting it to the mentor If you have futher advise, to save time and make the communication smoother. Best Regards, Guo Jian

1 0

Re: winex11.drv: Fixed XInput2 errors with mislabeled mice axis. (try 2)
by Alexandre Julliard May 4, 2013

May 4, 2013

Christopher Cope <ccope3(a)utk.edu> writes: > @@ -286,8 +286,10 @@ static void enable_xinput2(void) > class->number, class->min, class->max, class->resolution, class->mode, > XGetAtomName( data->display, class->label )); > if (class->label == x11drv_atom( Rel_X ) || class->label == x11drv_atom( Rel_Y )) count++; > - /* workaround for drivers that don't provide labels */ > - if (!class->label && class->number <= 1 && class->mode == XIModeRelative) count++; > + /* workaround for drivers that don't provide correct labels */ > + if (((!class->label && class->number <= 1) || class->label == x11drv_atom( Abs_X ) || > + class->label == x11drv_atom( Abs_Y )) > + && class->mode == XIModeRelative) count++; The whole point of testing labels was because some platforms don't set the relative mode correctly, so this is going to break them again. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/6] ole32: Added IExternalConnection support.
by Alexandre Julliard May 3, 2013

May 3, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/ole32/compobj_private.h | 2 ++ > dlls/ole32/stubmanager.c | 16 ++++++++++++++++ > 2 files changed, 18 insertions(+) It doesn't work here: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so defaulthandler.c && touch defaulthandler.ok defaulthandler.c:189: Test failed: unexpected interface: {00000019-0000-0000-C000-000000000046} make: *** [defaulthandler.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3dcompiler: Add a LUT to find compilation targets info.
by Matteo Bruni May 3, 2013

May 3, 2013

2013/5/2 Christian Costa <titan.costa(a)gmail.com>: > > --- > dlls/d3dcompiler_43/compiler.c | 101 +++++++++++++++++++++++------ > dlls/d3dcompiler_43/d3dcompiler_private.h | 1 > 2 files changed, 81 insertions(+), 21 deletions(-) > > diff --git a/dlls/d3dcompiler_43/compiler.c b/dlls/d3dcompiler_43/compiler.c > index 4942985..a6a9867 100644 > --- a/dlls/d3dcompiler_43/compiler.c > +++ b/dlls/d3dcompiler_43/compiler.c > @@ -490,6 +490,66 @@ HRESULT WINAPI D3DAssemble(const void *data, SIZE_T datasize, const char *filena > return hr; > } > > +struct { Please make it static const. > + const char *name; > + enum shader_type type; > + DWORD sm_major; > + DWORD sm_minor; > + DWORD level_major; > + DWORD level_minor; > + BOOL sw; > + BOOL support; > +} targets_info[] = { > + /* SM 1 */ > + { "vs_1_0", ST_VERTEX, 1, 0, 0, 0, FALSE, TRUE }, > + { "vs_1_1", ST_VERTEX, 1, 1, 0, 0, FALSE, TRUE }, > + { "ps_1_0", ST_PIXEL, 1, 0, 0, 0, FALSE, TRUE }, > + { "ps_1_1", ST_PIXEL, 1, 1, 0, 0, FALSE, FALSE }, > + { "ps_1_2", ST_PIXEL, 1, 2, 0, 0, FALSE, FALSE }, > + { "ps_1_3", ST_PIXEL, 1, 3, 0, 0, FALSE, FALSE }, > + { "ps_1_4", ST_PIXEL, 1, 4, 0, 0, FALSE, FALSE }, > + { "tx_1_0", ST_UNKNOWN, 1, 0, 0, 0, FALSE, FALSE }, > + /* SM 2 */ > + { "vs_2_0", ST_VERTEX, 2, 0, 0, 0, FALSE, TRUE }, > + { "vs_2_a", ST_VERTEX, 2, 1, 0, 0, FALSE, FALSE }, > + { "vs_2_sw", ST_VERTEX, 2, 0, 0, 0, TRUE, FALSE }, > + { "ps_2_0", ST_PIXEL, 2, 0, 0, 0, FALSE, TRUE }, > + { "ps_2_a", ST_PIXEL, 2, 1, 0, 0, FALSE, FALSE }, > + { "ps_2_b", ST_PIXEL, 2, 2, 0, 0, FALSE, FALSE }, > + { "ps_2_sw", ST_PIXEL, 2, 0, 0, 0, TRUE, FALSE }, > + { "fx_2_0", ST_UNKNOWN, 2, 0, 0, 0, FALSE, FALSE }, > + /* SM 3 */ > + { "vs_3_0", ST_VERTEX, 3, 0, 0, 0, FALSE, TRUE }, > + { "vs_3_sw", ST_VERTEX, 3, 0, 0, 0, TRUE, FALSE }, > + { "ps_3_0", ST_PIXEL, 3, 0, 0, 0, FALSE, TRUE }, > + { "ps_3_sw", ST_PIXEL, 3, 0, 0, 0, TRUE, FALSE }, > + /* SM 4 */ > + { "vs_4_0_level_9_0", ST_VERTEX, 4, 0, 9, 0, FALSE, FALSE }, > + { "vs_4_0_level_9_1", ST_VERTEX, 4, 0, 9, 1, FALSE, FALSE }, > + { "vs_4_0_level_9_3", ST_VERTEX, 4, 0, 9, 3, FALSE, FALSE }, > + { "vs_4_0", ST_VERTEX, 4, 0, 0, 0, FALSE, TRUE }, > + { "vs_4_1", ST_VERTEX, 4, 1, 0, 0, FALSE, TRUE }, > + { "ps_4_0_level_9_0", ST_PIXEL, 4, 0, 9, 0, FALSE, FALSE }, > + { "ps_4_0_level_9_1", ST_PIXEL, 4, 0, 9, 1, FALSE, FALSE }, > + { "ps_4_0_level_9_3", ST_PIXEL, 4, 0, 9, 3, FALSE, FALSE }, > + { "ps_4_0", ST_PIXEL, 4, 0, 0, 0, FALSE, TRUE }, > + { "ps_4_1", ST_PIXEL, 4, 1, 0, 0, FALSE, TRUE }, > + { "gs_4_0", ST_UNKNOWN, 4, 0, 0, 0, FALSE, FALSE }, > + { "gs_4_1", ST_UNKNOWN, 4, 1, 0, 0, FALSE, FALSE }, > + { "cs_4_0", ST_UNKNOWN, 4, 0, 0, 0, FALSE, FALSE }, > + { "cs_4_1", ST_UNKNOWN, 4, 1, 0, 0, FALSE, FALSE }, > + { "fx_4_0", ST_UNKNOWN, 4, 0, 0, 0, FALSE, FALSE }, > + { "fx_4_1", ST_UNKNOWN, 4, 1, 0, 0, FALSE, FALSE }, > + /* SM 5 */ > + { "vs_5_0", ST_VERTEX, 5, 0, 0, 0, FALSE, TRUE }, > + { "ps_5_0", ST_PIXEL, 5, 0, 0, 0, FALSE, TRUE }, > + { "hs_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "gs_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "ds_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "cs_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "fx_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > +}; > + > static HRESULT compile_shader(const char *preproc_shader, const char *target, const char *entrypoint, > ID3DBlob **shader_blob, ID3DBlob **error_messages) > { > @@ -500,38 +560,37 @@ static HRESULT compile_shader(const char *preproc_shader, const char *target, co > ID3DBlob *buffer; > char *pos; > enum shader_type shader_type; > + ULONG i; > + ULONG nb = sizeof(targets_info) / sizeof(targets_info[0]); > > TRACE("Preprocessed shader source: %s\n", debugstr_a(preproc_shader)); > > TRACE("Parsing compilation target %s.\n", debugstr_a(target)); > - if (strlen(target) != 6 || target[1] != 's' || target[2] != '_' || target[4] != '_') > + for (i = 0; i < nb; i++) > { > - FIXME("Unknown compilation target %s.\n", debugstr_a(target)); > - return D3DERR_INVALIDCALL; > + if (!strcmp(target, targets_info[i].name)) > + { > + if (!targets_info[i].support) > + { > + FIXME("Compilation target %s not yet supported\n", debugstr_a(target)); > + return D3DERR_INVALIDCALL; > + } > + else > + { > + shader_type = targets_info[i].type; > + major = targets_info[i].sm_major; > + minor = targets_info[i].sm_minor; > + break; > + } > + } > } > > - if (target[0] == 'v') > - shader_type = ST_VERTEX; > - else if (target[0] == 'p') > - shader_type = ST_PIXEL; > - else > + if (i == nb) > { > - FIXME("Unsupported shader target type %s.\n", debugstr_a(target)); > + FIXME("Unknown compilation target %s\n", debugstr_a(target)); > return D3DERR_INVALIDCALL; > } > > - major = target[3] - '0'; > - if (major == 0 || major > 5) > - { > - FIXME("Unsupported shader target major version %d.\n", major); > - return D3DERR_INVALIDCALL; > - } > - minor = target[5] - '0'; > - if (minor > 1 || (minor == 1 && (shader_type != ST_VERTEX || major > 1))) > - { > - FIXME("Unsupported shader target minor version %d.\n", minor); > - return D3DERR_INVALIDCALL; > - } > shader = parse_hlsl_shader(preproc_shader, shader_type, major, minor, entrypoint, &messages); > > if (messages) > diff --git a/dlls/d3dcompiler_43/d3dcompiler_private.h b/dlls/d3dcompiler_43/d3dcompiler_private.h > index c8a92f1..63745e0 100644 > --- a/dlls/d3dcompiler_43/d3dcompiler_private.h > +++ b/dlls/d3dcompiler_43/d3dcompiler_private.h > @@ -51,6 +51,7 @@ enum shader_type > { > ST_VERTEX, > ST_PIXEL, > + ST_UNKNOWN > }; > I'd prefer ST_UNKNOWN to be in the first place here (so that it doesn't get pushed down when we'll add more target types) but it's not a big deal. > typedef enum BWRITER_COMPARISON_TYPE { > > > The patch is probably fine otherwise but can you check that targets in the form "vs.1.0" aren't accepted by native D3DCompile? I suppose those tokens are assembler-only, but better be safe than sorry.

2 1

IID mess
by Daniel Jeliński May 3, 2013

May 3, 2013

Hello, I just tried compiling all of Wine with my patch series applied and, to my surprise, compilation failed. The reason was that IID_IResourceManager was already declared elsewhere. Now, according to this page: http://mikolajapp.appspot.com/uuid/query?q={56a868ac-0ad4-11ce-b03a-0020af0… Wine's strmif.h declares IID_IResourceManager, while SDK declares __declspec(uuid) as IResourceManager. SDK declares IID_IResourceManager elsewhere: http://mikolajapp.appspot.com/uuid/query?q={03741d21-87eb-11ce-8081-0080c75… I'm new to COM, so I'm not sure what exactly is the difference between IID and declspec(uuid). Could anyone explain or suggest a fix? Thanks, Daniel

2 3

Re: [PATCH 5/6] ieframe: Added more InternetExplorer object tests.
by Marvin May 3, 2013

May 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25429 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: [AppDB] version: Only display comments section in case version has maintainers
by Hin-Tak Leung May 3, 2013

May 3, 2013

------------------------------ On Fri, May 3, 2013 00:35 BST Rosanne DiMesio wrote: >On Thu, 2 May 2013 23:26:24 +0100 (BST) >Hin-Tak Leung <htl10(a)users.sourceforge.net> wrote: >> >> - "volunteer" is what it means: "volunteer". To try to make anybody "volunteer" in any activity any manner which is less than whole-heartedly willingly, sounds wrong. >> > >Nobody's trying to make anyone volunteer. I doubt anyone will. > >> There is no reason why the AppDB shouldn't work that way. i.e. just deal with the persistent ones, and let the individual readers skip over the occasional rest as they come. > >And who do you propose should "deal with" the persistent spammers? people who are bothered by them, or people who are paid to spend such time. I am neither. To be honest, i am more bothered by this thread (in a list which i subscribe to) than spam on appdb (which i don't). >> To ban such exchanges - between people who ask for help and might even offer incentives, and those who can offer help but not willing/possible to commit to a regular role - seem over-zealous. > >We have a perfectly good user's forum for such exchanges. > >-- >Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: [AppDB] version: Only display comments section in case version has maintainers
by Frédéric Delanoy May 2, 2013

May 2, 2013

On Thu, May 2, 2013 at 7:23 PM, Rosanne DiMesio <dimesio(a)earthlink.net>wrote: > On Thu, 2 May 2013 17:57:16 +0200 > Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > > > > > This won't prevent it, but I'm not sure hiding/disabling comments won't > do > > more harm than good. > > My opinion, based on close to 5 years experience as an active AppDB admin > and maintainer, is it will inconvenience a few people, but overall do far > more good than harm, for reasons that go beyond simple spam control. The > number of unmaintained apps with an active community of commenters is > small; in most unmaintained apps, questions posted just sit there > unanswered. Users seeking help would be much better off posting on the forum. > Of course, but we don't want people to ask the same questions over and over again on the forum. I thought the whole point of the appdb entry was to centralize information on running apps with wine (comments being common to all versions of the software tested)... > Since Andre's patch (thank you, Andre) merely disables comments for > unmaintained apps, any user who really thinks it's vital that the comments > appear in a particular entry can make that happen themselves simply by > volunteering to be a maintainer. If it's not important enough to someone to > put forth the trivial effort required to do that, then it's not important > to them, period. Maintaining/testing app entries may not be so trivial for everyone, and you can't expect everyone wanting to know how to run an app to become a maintainer... Maybe merely disabling *new* (vs all) comments for unmaintained apps would also do the job??? Frédéric

3 2

Google Summer of Code 2013, Tools - Implement new control panel applets
by Brock York May 2, 2013

May 2, 2013

Hey Everyone, I've been wanting to get into Google Summer of Code and Wine development for quite a while now. I was looking on the wine ideas page : http://wiki.winehq.org/SummerOfCode I'm interested in doing the first one: Tools - Implement new control panel applets, but am wondering what I would actually be able to do. I've done basic opengl applications before but using a library like SDL to do the lowerlevel stuff. What kind of opengl test would be preferred? Something like a port of GLXgears to wine or something that just tests if it can create a Opengl context and then exits saying success? I don't know how to test whether opengl was compiled into wine either, would that be very hard to do? I've never had write code to test if a feature was enabled before. Any suggestions on what kind of test I should try and implement would be greatly appreciated so I can try and get a proposal in. I know I'm leaving it pretty late but I only found out it was open a few hours ago. For a background of my knowledge I'm currently in my 3rd year of a computer science degree at my University, I also did a year of programming at a college. I've been using linux for 6 years but haven't been able to get to grips with programming for wine I always get confused or lost when trying to learn how wine works when trying to debug a game. I'm hoping doing something like this will be able to get me started on wine with a mentors help to guide me. Thanks. Regards Brock York

2 1

Re: [2/6] uuid: add transact.h and txdtc.h
by Frédéric Delanoy May 2, 2013

May 2, 2013

On Wed, May 1, 2013 at 11:19 PM, Daniel Jeliński <djelinski1(a)gmail.com>wrote: > #include "msdasc.h" > > +#include "transact.h" > +#include "txdtc.h" > > A patch only adding new headers for inclusion is likely not acceptable. You should merge it with another patch making use of it. Frédéric

2 1

Re: [AppDB] version: Only display comments section in case version has maintainers
by Christopher Cope May 2, 2013

May 2, 2013

I understand the premise, but I disagree. A lot of apps that I use don't have maintainers. However, the comments are typically helpful. I believe this should be approached differently. "André Hentschel" <nerv(a)dawncrow.de> wrote: >Am 28.04.2013 18:57, schrieb Rosanne DiMesio: >> Forced moderation of comments could work for apps with maintainers >who are doing their job, but most of the spam I recently deleted was in >unmaintained apps. My suggestion would be to block comments altogether >on unmaintained apps, not just because of spam, but because of other >inappropriate things that are not being monitored, such as posting >links to illegal downloads. As for the maintainers who clearly aren't >doing their jobs (about 20-25% of the spam I found was in entries with >maintainers), admins already have the capability of removing them. > > >--- > include/version.php | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/include/version.php b/include/version.php >index 8f02b24..bf1d7ab 100644 >--- a/include/version.php >+++ b/include/version.php >@@ -1180,9 +1180,12 @@ class version { > > echo note::displayNotesForEntry($this->iVersionId); > >- // Comments Section >- if($this->iVersionId) >- Comment::view_app_comments($this->iVersionId); >+ if(sizeof($aMaintainers)>0) >+ { >+ // Display comments section in case version has >maintainers >+ if($this->iVersionId) >+ Comment::view_app_comments($this->iVersionId); >+ } > } > > public static function lookup_name($versionId) >-- >1.7.10.4

3 4

Re: Re: msi/tests: Add a trailing '\n' to an ok() call.
by Marvin May 2, 2013

May 2, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25396 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msi/tests: Add a trailing '\n' to an ok() call.
by Christian Costa May 2, 2013

May 2, 2013

2013/5/2 Francois Gouget <fgouget(a)free.fr> > --- > dlls/msi/tests/install.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c > index e5d996e..0c322be 100644 > --- a/dlls/msi/tests/install.c > +++ b/dlls/msi/tests/install.c > @@ -3110,7 +3110,7 @@ static void test_continuouscabs(void) > > /* Filename from msi is right and the one from cab is wrong */ > create_cc_test_files(); > - ok(MoveFile("test2.cab", "test2_.cab"), "Cannot rename test3.cab to > test3_.cab"); > + ok(MoveFile("test2.cab", "test2_.cab"), "Cannot rename test3.cab to > test3_.cab\n"); > create_database(msifile, cc3_tables, sizeof(cc3_tables) / > sizeof(msi_table)); > > MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL); > -- > 1.7.10.4 > > > Hi François, Can you fix the typo test3 to test2 as well please ? Thanks Christian

1 0

Re: [1/6] include: add transact.h, txdtc.h and txcoord.h (try 2)
by Alexandre Julliard May 2, 2013

May 2, 2013

Daniel Jeliński <djelinski1(a)gmail.com> writes: > From 6b7cd0b30b3eaf22d9b9bbef733163e74cc04ca8 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Wed, 1 May 2013 20:28:10 +0200 > Subject: include: add transact.h, txdtc.h and txcoord.h > > this time based on minGW headers. Originals found here: > http://sourceforge.net/apps/trac/mingw-w64/browser/experimental/headers_add… This clearly needs to be generated from idl instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-patches
by Daniel Jeliński May 2, 2013

May 2, 2013

Hello, I sent a ~200KB patch to wine-patches last night and it disappeared without a trace. I'm wondering if it got lost or just went to moderation. Regards, Daniel PS.I just resent it, still no luck.

2 1

Re: [2/4] include: added transact.idl (resend)
by Alexandre Julliard May 1, 2013

May 1, 2013

Daniel Jeliński <djelinski1(a)gmail.com> writes: > +import "unknwn.idl"; > + > +interface ITransaction; > +interface ITransactionDispenser; > +interface ITransactionOptions; > +interface ITransactionOutcomeEvents; > +interface ITransactionCompletionEvents; > + > +/*========================================================================== > + * Transaction related types > + *==========================================================================*/ > + > +[local,pointer_default(unique)] > +interface BasicTransactionTypes > + { > + > + typedef struct BOID { > + byte rgb[16]; > + } BOID; > + > + cpp_quote("#define BOID_NULL (*((BOID*)(&IID_NULL)))") > + > + /* change the following two line together */ > + cpp_quote("#ifndef MAX_TRAN_DESC_DEFINED") /* conflicts with uimsg.h. This is temporary work around */ > + cpp_quote("#define MAX_TRAN_DESC_DEFINED") > + typedef enum TX_MISC_CONSTANTS > + { > + MAX_TRAN_DESC = 40 > + } TX_MISC_CONSTANTS; > + cpp_quote("#endif") > + > + /* Unit Of Work. */ > + > + typedef BOID XACTUOW; > + > + /* Data type for isolation level values. */ > + > + typedef LONG ISOLEVEL; > + > + /* Constants that specifiy isolation level of a transaction. */ > + > + typedef enum ISOLATIONLEVEL { > + ISOLATIONLEVEL_UNSPECIFIED = 0xFFFFFFFF, > + ISOLATIONLEVEL_CHAOS = 0x00000010, > + ISOLATIONLEVEL_READUNCOMMITTED = 0x00000100, > + ISOLATIONLEVEL_BROWSE = 0x00000100, /* Synonym for _READUNCOMITTED */ > + ISOLATIONLEVEL_CURSORSTABILITY = 0x00001000, > + ISOLATIONLEVEL_READCOMMITTED = 0x00001000, /* Synonym for _CURSORSTABILITY */ > + ISOLATIONLEVEL_REPEATABLEREAD = 0x00010000, > + ISOLATIONLEVEL_SERIALIZABLE = 0x00100000, > + ISOLATIONLEVEL_ISOLATED = 0x00100000, /* Synonym for _SERIALIZABLE */ > + } ISOLATIONLEVEL; > + > + /* Transaction information structure, used in ITransaction */ > + > + typedef struct XACTTRANSINFO { > + XACTUOW uow; /* The current unit of work */ > + ISOLEVEL isoLevel; /* The isolation level for the current UOW */ > + ULONG isoFlags; /* Values from ISOFLAG enumeration */ > + DWORD grfTCSupported; /* Flags indicating capabilities */ > + DWORD grfRMSupported; /* ... of this transaction wrt */ > + DWORD grfTCSupportedRetaining; /* ... parameters to Commit */ > + DWORD grfRMSupportedRetaining; /* ... */ > + } XACTTRANSINFO; > + > + typedef struct XACTSTATS { > + ULONG cOpen; /* The number of currently extant transactions. */ > + ULONG cCommitting; /* The number of transactions which are proceding towards committing. */ > + ULONG cCommitted; /* The number of transactions that are have been committed. */ > + ULONG cAborting; /* The number of transactions which are in the process of aborting. */ > + ULONG cAborted; /* The number of transactions that are have been aborted. */ > + ULONG cInDoubt; /* The number of transactions which are presently in doubt. */ > + ULONG cHeuristicDecision; /* The number of transactions that have completed by heuristic decision. */ > + FILETIME timeTransactionsUp; /* The amount of time that this transaction service has been up. */ > + } XACTSTATS; This is clearly a straight copy of the SDK header. You can't do that. -- Alexandre Julliard julliard(a)winehq.org

3 3

GSoC proposal
by George Stephanos May 1, 2013

May 1, 2013

Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the "Arab Academy for Science and Technology" situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't developed for Wine before though I've always been a big fan of the project. I'm fairly good with C/C++ and Python and I think I have enough Win32 API experience. I've previously developed small WinSock, DirectX and classic GUI applications (with and without MFC). I'm a freelancer. I've worked (alone) on around 25-30 projects rating 4+/5 in each. I've enrolled in Google Code-In 2010 and 2011 (which is basically GSoC for high school students) writing lots of ARM assembly code for VideoLAN (#x264dev on freenode). In 2011, I would have ranked 12th if not for an issue that occurred between VideoLAN and Google. Proposal: I've read your ideas page and the only registry task [1] has particularly caught my attention. I'm aware of what I need to do. I've read [2], [3] and [4]. I haven't yet browsed the Wine tree at all and I'll probably be missing implementation strategies but that'll hopefully be worked out with my mentor. [1] - http://wiki.winehq.org/SummerOfCode?#head-40e316e01066b5a129cd65073fa4b89dd… [2] - http://bugs.winehq.org/show_bug.cgi?id=14771 [3] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724475(v=vs.85).a… [4] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… Tell me if you need more information. Hope you consider me! Thanks, George

3 2

Re: server: Map update region to children even if window just moved.
by Alexandre Julliard May 1, 2013

May 1, 2013

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -1618,7 +1618,7 @@ static void set_window_pos( struct window *win, struct window *previous, > const rectangle_t old_visible_rect = win->visible_rect; > const rectangle_t old_client_rect = win->client_rect; > rectangle_t rect; > - int client_changed, frame_changed; > + int client_changed, frame_changed, frame_moved = 0; > int visible = (win->style & WS_VISIBLE) || (swp_flags & SWP_SHOWWINDOW); > > if (win->parent && !is_visible( win->parent )) visible = 0; > @@ -1727,9 +1727,10 @@ static void set_window_pos( struct window *win, struct window *previous, > client_rect->bottom - old_client_rect.bottom != y_offset || > !valid_rects || > memcmp( &valid_rects[0], client_rect, sizeof(*client_rect) )); > + frame_moved = x_offset || y_offset; > } > > - if (frame_changed || client_changed) > + if (frame_changed || client_changed || frame_moved) It doesn't make sense to have all these complicated tests if we are going to always repaint anyway, which is essentially what your patch does. There has to be more to it than that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Marvin May 1, 2013

May 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25385 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Hans Leidekker May 1, 2013

May 1, 2013

On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..4145c76 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, > > if (strcmpiW( mi->cabinet, cab )) > { > - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); > - goto done; > + LPSTR next_cab; > + > + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table => use latter one\n", debugstr_w(cab), debugstr_w(mi->cabinet)); > + > + /* Use cabinet name from the media table */ > + next_cab = strdupWtoA(mi->cabinet); > + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ > + strcat(pfdin->psz3, "\\"); > + strcat(pfdin->psz3, next_cab); > + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ > + *pfdin->psz1 = 0; > + msi_free(next_cab); The cabinet name alone can be up 256 characters so you should at least check that you're not overflowing the buffer.

2 1

winex11.drv
by Christopher Cope May 1, 2013

May 1, 2013

I am unsure how the "enum x11drv_atoms" in the file dlls/winex11.dev/x11drv.h works. My /usr/include/Xatom.h defines XA_LAST_PREDEFINED as 68. Presumably, therefore XATOM_Rel_X and XATOM_Rel_X should be 81 and 82 respectively. However, when I dump the values I get 195 and 196. I am attempting to add XATOM_Abs_X and XATOM_Abs_X with values of 480 and 481 for a patch I'm working on. I could simply define the values elsewhere, but I assumed I should try to make it blend with the other code as much as possible. Any help is appreciated thank you.

2 4

GSoC proposal
by George Stephanos May 1, 2013

May 1, 2013

Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the "Arab Academy for Science and Technology" situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't developed for Wine before though I've always been a big fan of the project. I'm fairly good with C/C++ and Python and I think I have enough Win32 API experience. I've previously developed small WinSock, DirectX and classic GUI applications (with and without MFC). I'm a freelancer. I've worked (alone) on around 25-30 projects rating 4+/5 in each. I've enrolled in Google Code-In 2010 and 2011 (which is basically GSoC for high school students) writing lots of ARM assembly code for VideoLAN (#x264dev on freenode). In 2011, I would have ranked 12th if not for an issue that occurred between VideoLAN and Google. Proposal: I've read your ideas page and the only registry task [1] has particularly caught my attention. I'm aware of what I need to do. I've read [2], [3] and [4]. I haven't yet browsed the Wine tree at all and I'll probably be missing implementation strategies but that'll hopefully be worked out with my mentor. [1] - http://wiki.winehq.org/SummerOfCode?#head-40e316e01066b5a129cd65073fa4b89dd… [2] - http://bugs.winehq.org/show_bug.cgi?id=14771 [3] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724475(v=vs.85).a… [4] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… Tell me if you need more information. Hope you consider me! Thanks, George

1 0

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)
by Alexandre Julliard May 1, 2013

May 1, 2013

Sam Edwards <cfsworks(a)gmail.com> writes: > Content-wise, this is the same as try 2. However, there are two differences: > > 1. I merged the tests down into the same patch. > 2. This won't crash anymore: see patch 1 in this series. It still crashes: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389 6389 ((unsigned int)src[hmul * x + rgb_interval * 2] << 0) | (gdb) bt #0 0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389 #1 0x00007ffff550fd1e in freetype_GetGlyphOutline (dev=0x40df0, glyph=<optimized out>, format=<optimized out>, lpgm=0x22c9f0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:7133 #2 0x00007ffff54fcd84 in GetGlyphOutlineW (hdc=<optimized out>, uChar=103, fuFormat=17, lpgm=0x22c9f0, cbBuffer=288, lpBuffer=0x538c4, lpmat2=0x7ffff5535140) at ../../../wine/dlls/gdi32/font.c:2813 #3 0x00007ffff54c97b5 in render_string (hdc=0x490031, dib=<optimized out>, font=0x43cb0, x=95, y=11, flags=12288, str=0x51b70, count=13, dx=0x53470, clipped_rects=0x22cbb0, bounds=0x22cba0) at ../../../wine/dlls/gdi32/dibdrv/graphics.c:707 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] d3dx9_36: Remove todo in tests as it works now with last d3dxof fixes.
by Matteo Bruni May 1, 2013

May 1, 2013

2013/4/29 Christian Costa <titan.costa(a)gmail.com>: > > --- > dlls/d3dx9_36/tests/xfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c > index 1238bcd..e514a5f 100644 > --- a/dlls/d3dx9_36/tests/xfile.c > +++ b/dlls/d3dx9_36/tests/xfile.c > @@ -77,7 +77,7 @@ static void test_templates(void) > ok(ret == D3DXFERR_BADFILEFLOATSIZE, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_BADFILEFLOATSIZE); > > ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates_parse_error, sizeof(templates_parse_error) - 1); > - todo_wine ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); > + ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); > > ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates, sizeof(templates) - 1); > ok(ret == S_OK, "RegisterTemplates failed with %#x\n", ret); Hi Christian, good catch for that todo_wine. However, this should be merged with the patch actually fixing the test (I guess it's patch 2).

2 1

Re: [1/4] xolehlp: fix calling convention
by Nikolay Sivov May 1, 2013

May 1, 2013

On 5/1/2013 01:43, Daniel Jeliński wrote: Please fix spec file accordingly.

2 2