May 2013 - Wine-Devel - list.winehq.org

Re: (try 2)macdrv: rework the way we handle cursor position and composition text
by Ken Thomases May 29, 2013

May 29, 2013

On May 29, 2013, at 1:11 PM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 5 --- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 6 +-- > 5 files changed, 29 insertions(+), 77 deletions(-) > > > <0014-macdrv-rework-the-way-we-handle-cursor-position-and-co.txt> Looks good to me. -Ken

1 0

Re: macdrv: rework the way we handle cursor position and composition text
by Ken Thomases May 29, 2013

May 29, 2013

On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 3 -- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 5 +-- > 5 files changed, 29 insertions(+), 74 deletions(-) I know I reviewed this several times, but I failed to notice until now: you didn't remove the definition of IM_SET_CURSOR_POS in the enum and the entry in the table in dbgstr_event(). -Ken

2 1

GSoC 2013 has begun!
by Austin English May 29, 2013

May 29, 2013

Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by Nikolay Sivov Zhan Jianyu, "Improve and add missing feature of vbscript component" mentored by Jacek Caban Welcome to Wine and good luck on your projects! As a reminder, here are the next few big dates: May 27th - June 17: community bonding period. Students/mentors should use this time to iron out details of the project, learn the code base and get to know others on the project. June 17: coding officially begins July 29th - Aug 2nd: mid-term reviews are submitted. Mentors/students, please feel free to contact me or André Hentschel if you have any GSoC administrative/procedural questions. Otherwise use wine-devel or ask your mentor for help with learning the Wine development process/codebase/etc. -- -Austin

1 1

Re: [1/3] DWrite: Added missing JUSTIFIED text alignment mode.
by Nikolay Sivov May 29, 2013

May 29, 2013

Hi, Fabian. You forgot to attach patches 2 and 3.

1 0

re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Maarten Lankhorst May 29, 2013

May 29, 2013

NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

2 1

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.
by gurketsky May 29, 2013

May 29, 2013

Hi, just saw that a bit late. Is there a reason for the rewrite of hr? Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to overwrite the result anyway to D3D_OK on success, so I see no reason to change the hr to D3D_OK in parse_skin_mesh_info. Cheers Rico On 28.05.2013 22:16, Alexandre Julliard wrote: > + if (SUCCEEDED(hr)) > + hr = mesh_data->skin_info->lpVtbl->SetBoneOffsetMatrix(mesh_data->skin_info, index, > + (const D3DMATRIX*)(data + nb_influences * (sizeof(DWORD) + sizeof(FLOAT)))); > + if (FAILED(hr)) > + goto end; > + } > + > + hr = D3D_OK;

2 1

Re: Increment, Decrement, and Assignment Operators
by Alexandre Julliard May 29, 2013

May 29, 2013

Stephen Leibowitz <librestephen(a)gmail.com> writes: > Hello: > > This is my first patch. The changes are minor. If it works out, I may > attempt something more substantial. Doing cosmetic changes like this across the code base is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32: Ask for a newer FreeType version
by Alexandre Julliard May 29, 2013

May 29, 2013

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3686,7 +3686,8 @@ static BOOL init_freetype(void) > WINE_MESSAGE( > "Wine cannot find the FreeType font library. To enable Wine to\n" > "use TrueType fonts please install a version of FreeType greater than\n" > - "or equal to 2.0.5.\n" > + "or equal to 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" > "http://www.freetype.org\n"); > return FALSE; > } > @@ -3749,6 +3750,7 @@ sym_not_found: > "Wine cannot find certain functions that it needs inside the FreeType\n" > "font library. To enable Wine to use TrueType fonts please upgrade\n" > "FreeType to at least version 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" That's not useful. There are probably very few users who still have such an old Freetype, and even if they do, telling them about vertical metrics will only confuse them. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Increment, Decrement, and Assignment Operators
by Dan Kegel May 28, 2013

May 28, 2013

Watch http://source.winehq.org/patches/ for your patch's status (see legend at bottom). It might be rejected since it doesn't actually fix any behavioral problem in Wine. IIRC trivial cleanups in code are frowned upon, especially if they cross many modules. Better to pick some small real problem and fix it. How about http://bugs.winehq.org/show_bug.cgi?id=32922 ?

1 0

Re: gdi32/tests: Do not try to test OS/2 win metrics on non-windows fonts
by Dmitry Timoshkov May 28, 2013

May 28, 2013

Aric Stewart <aric(a)codeweavers.com> wrote: > + ascent = GET_BE_WORD(tt_os2.usWinAscent); > + descent = GET_BE_WORD(tt_os2.usWinDescent); > + cell_height = ascent + descent; > + ok(ntm->ntmCellHeight == cell_height, "%s: ntmCellHeight %u != %u, os2.usWinAscent/os2.usWinDescent %u/%u\n", > + font_name, ntm->ntmCellHeight, cell_height, ascent, descent); > + > + SetLastError(0xdeadbeef); The SetLastError() call should be left at its previous position. -- Dmitry.

1 0

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker May 28, 2013

May 28, 2013

On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > schemes is |= in the called function, but not > initialized before. > > Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so it would be better to fix it in that helper, without touching the parameter on error.

1 0

Re: [PATCH] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Marvin May 28, 2013

May 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25741 Your paranoid android. === WXPPROSP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === W2K3R2SESP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (64 bit dsound) === dsound.c:1433: Test failed: validbits: 0

1 0

Re: [5/5] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 2)
by Alexandre Julliard May 28, 2013

May 28, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This closes bug 14819. > > try 2: > * tests/heap.c was updated to avoid dependency on heap reallocation > strategies. > * Use HeapAlloc instead of LocalAlloc in some places. In those cases, > they want large memory blocks, not pinned memory addresses. They are using LMEM_MOVEABLE though. A few more tests for this flag would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

dxgi, directx 11 and code duplication
by John Yani May 28, 2013

May 28, 2013

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

2 1

dxgi, directx 11 and code duplication
by John Yani May 27, 2013

May 27, 2013

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

1 0

Release plans
by Alexandre Julliard May 27, 2013

May 27, 2013

Folks, Now that the Mac driver is fully merged and all the bugs fixed (right?), it's time to think about the next stable release. I would like to start the code freeze after the next release cycle, so two weeks from now. Hopefully, like last time we can keep the freeze period relatively short, so that it won't impact the Summer of Code projects too much. Note that in general, new test cases can be accepted during code freeze, and it's always a good idea to start a GSoC project by writing tests. On a related note, the test results on test.winehq.org haven't been looking very good lately; in particular, we need to make the full test suite succeed on the new testbot VMs, since the old ones are being phased out. Fixes to make tests succeed on Windows can go in during code freeze, since by definition they don't impact the Wine code, so this would be a good opportunity to try to improve the situation. OTOH the regression status is looking good, I'm very pleased with how we've kept the regression count under control during the 1.5 series. Hopefully we can even fix a few more during code freeze and set a lower baseline for the next development series. Thanks all for your help, and let's make this another great release! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: load winealsa if winepulse is found
by cfsworks＠gmail.com May 27, 2013

May 27, 2013

Wouldn't this cause applications which use winmm for waveout to be diverted to ALSA as well? Maybe both drivers should be loaded side by side, with winepulse handling everything but MIDI.

1 0

Re: [PATCH v23] winepulse: add pulseaudio driver
by Marvin May 27, 2013

May 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25724 Your paranoid android. === WVISTAX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W2K8SE (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W7PROX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === TEST64_W7SP1 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === WVISTAX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 0000000000000000 === W7PROX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000 === TEST64_W7SP1 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000

1 0

Making SetThreadPriorityBoost claim success
by Dan Kegel May 27, 2013

May 27, 2013

http://bugs.winehq.org/show_bug.cgi?id=22280 just got another dup. How awful would it be to make SetThreadPriorityBoost just return success, as in the patch attached to http://bugs.winehq.org/show_bug.cgi?id=22280#c1 http://bugs.winehq.org/attachment.cgi?id=27224&action=diff&context=patch&co… ? We'd have to mark one more test TODO_WINE. Related if catty discussion: http://www.codinghorror.com/blog/2006/08/thread-priorities-are-evil.html

2 1

Re: [PATCH 4/5] d3drm: Avoid LPDIRECT3DRMTEXTURE.
by Christian Costa May 27, 2013

May 27, 2013

Le 27/05/2013 09:22, Henri Verbeet a écrit : > --- > dlls/d3drm/d3drm.c | 20 ++++++++------------ > dlls/d3drm/frame.c | 22 +++++++--------------- > dlls/d3drm/meshbuilder.c | 14 +++++++------- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > include/d3drm.h | 4 ++-- > include/d3drmobj.h | 26 +++++++++++++------------- > 6 files changed, 45 insertions(+), 57 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 8dfa4bb..fe728a8 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -317,24 +317,20 @@ static HRESULT WINAPI IDirect3DRMImpl_CreateUserVisual(IDirect3DRM* iface, D3DRM > return E_NOTIMPL; > } > > -static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM* iface, const char* filename, > - LPDIRECT3DRMTEXTURE* Texture) > +static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM *iface, > + const char *filename, IDirect3DRMTexture **texture) > { > - IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); > - > - FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture); > + FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > > Do you really need to change the way traces are displayed?

2 6

Re: jscript: Added RegExp.toString() implementation.
by Marvin May 27, 2013

May 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25722 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: riched20: Added tests for ITextDocument::Open
by Alexandre Julliard May 27, 2013

May 27, 2013

Jactry Zeng <jactry92(a)gmail.com> writes: > diff --git a/dlls/riched20/tests/test.txt b/dlls/riched20/tests/test.txt > new file mode 100644 > index 0000000..e69de29 If you need an external file you have to create a temp file in the test. You can't rely on running from inside the source tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Spam again ...
by Joerg Schiermeier May 26, 2013

May 26, 2013

Hi maintainer, ---<cite>--- Message: 1 Date: Sun, 26 May 2013 01:07:06 +0000 (UTC) From: xerox_xerox2000(a)yahoo.co.uk To: <wine-devel(a)winehq.org>, <vidar268(a)yahoo.com>, <vladdy(a)utchat.com> Subject: RE: Message-ID: <823277.37895.bm(a)smtp104.mail.ir2.yahoo.com> Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06 ---</cite>--- UCE/Spam again in this list ...! Please remove this user. Thanks a lot. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

d3dx9: Avoid useless computations in D3DXMatrixTransformation2D
by Nozomi Kodama May 26, 2013

May 26, 2013

Hello What happens for this patch? Nozomi

1 1

Re: [PATCH] wininet: do avoid overwriting the buffer (Coverity)
by Marvin May 26, 2013

May 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25714 Your paranoid android. === WXPX64 (32 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA === WXPX64 (64 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0