May 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin May 21, 2013

May 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25647 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin May 21, 2013

May 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25646 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Jacek Caban May 21, 2013

May 21, 2013

Hi Zhan, On 05/17/13 16:53, Zhan Jianyu wrote: > This patch is built based on Jaceks's newly-submitted patch: > > commit 48a862306288d69d3623d5ecdc0f5a5a40addafe > ( vbscript: Round half to even in to_int) > > Thanks, Jacek. :-) > > With his patch, CInt could be implementd in a clean way, without > any introduced helper function. > > This patch also add tests for any corner cases, and it has passed testbot's > testing. > > --- > dlls/vbscript/global.c | 14 ++++++++++++-- > dlls/vbscript/tests/api.vbs | 23 +++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 2 deletions(-) As you may check here: http://source.winehq.org/patches/ your patch is marked as 'Apply failure'. Did you prepare the patch against recent Wine Git? Please rebase and resend the patch. Cheers, Jacek

1 0

Re: Troubles configuring and building wine-1.5.30 on Debian wheezy
by Hugh McMaster May 21, 2013

May 21, 2013

On Monday May 20 at 22:24:58, Alan W. Irwin wrote: >wine at raven> wine64 >wine64: error while loading shared libraries: libwine.so.1: cannot >open shared object file: No such file or directory Hi Alan, This error is caused by a regression in Wine 1.5.30. It is not present in version 1.5.29. The general source for Wine 1.5.30 on WineHQ does contain a patch to resolve the issue. The patch is available from http://source.winehq.org/git/wine.git/patch/ce4b6451aabbe83809c7483c748cfa0…. To apply it, you will need to save the patch with either the extension .patch or .txt in the Wine source directory. You will then need to run the patch command from the source directory: patch -p1 < name.patch Alternatively, you can use Git to obtain the latest source: git clone git://source.winehq.org/git/wine.git ~/wine-git This option will come with the patch already applied and a lot of other changes. --- Hugh

1 0

Re: [1/4] server: Add support for console font size, maximum window size, etc.
by Dmitry Timoshkov May 20, 2013

May 20, 2013

Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > This patch modifies server/protocol.def and server/console.c to add support > for console font size detection and console window size rendering. It also > tidies up a few inconsistencies in the repeated usage of aspects of the > screen buffer struct. Your patches are full of formatting and white space changes, please don't do that. -- Dmitry.

2 1

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Charles Davis May 20, 2013

May 20, 2013

On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index f8904df..646f3a7 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl = { > BitmapImpl_SetResolution > }; > > +static HRESULT WINAPI IMILBitmapImpl_QueryInterface(IMILBitmapSource *iface, REFIID iid, > + void **ppv) > +{ > + BitmapImpl *This = impl_from_IMILBitmapSource(iface); > + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > + > + if (!ppv) return E_INVALIDARG; > + > + if (IsEqualIID(&IID_IUnknown, iid) || > + IsEqualIID(&IID_IMILBitmapSource, iid)) > + { > + *ppv = &This->IMILBitmapSource_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + return S_OK; > + } You're violating COM rules here: when you QI an object for an interface pointer, the QI must always return the same result no matter what. Here, however, you're returning this interface pointer in response to a query for IUnknown, when the already-existing QueryInterface method on the IWICBitmap interface returns *itself* for IUnknown! Now when you QI for IUnknown on both of these interfaces, they won't compare equal. (I suspect you're not convinced. After all, native might violate COM rules here, too. I doubt that (see below), but it might. So, write a test that QI's for IUnknown from both interfaces, and checks if they're equal or not. Then we'll see who's right.) > diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h > index dddb327..29f7726 100644 > --- a/dlls/windowscodecs/wincodecs_private.h > +++ b/dlls/windowscodecs/wincodecs_private.h > @@ -27,6 +27,46 @@ DEFINE_GUID(GUID_WineContainerFormatTga, 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47 > > DEFINE_GUID(GUID_VendorWine, 0xddf46da1,0x7dc1,0x404e,0x98,0xf2,0xef,0xa4,0x8d,0xfc,0x95,0x0a); > > +DEFINE_GUID(IID_IMILBitmapSource,0x7543696a,0xbc8d,0x46b0,0x5f,0x81,0x8d,0x95,0x72,0x89,0x72,0xbe); > +#define INTERFACE IMILBitmapSource > +DECLARE_INTERFACE_(IMILBitmapSource,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; You know you can just use the STDMETHOD() macro (no trailing underscore), e.g.: STDMETHOD(QueryInterface)(THIS_ REFIID,void **) PURE; for methods that return an HRESULT, right? Or do you prefer explicitly declaring the return type like that, even if it is more typing? > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > + /*** IMILBitmapSource methods ***/ > + STDMETHOD_(HRESULT,GetSize)(THIS_ UINT *,UINT *); > + STDMETHOD_(HRESULT,GetPixelFormat)(THIS_ int *); > + STDMETHOD_(HRESULT,GetResolution)(THIS_ double *,double *); > + STDMETHOD_(HRESULT,CopyPalette)(THIS_ IWICPalette *); > + STDMETHOD_(HRESULT,CopyPixels)(THIS_ const WICRect *,UINT,UINT,BYTE *); > + STDMETHOD_(HRESULT,UnknownMethod1)(THIS_ void **); > +}; > +#undef INTERFACE > + > +#define INTERFACE IMILUnknown1 > +DECLARE_INTERFACE_(IMILUnknown1,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > +}; > +#undef INTERFACE Wouldn't that just make this interface a plain old IUnknown? Or does it have its own IID? (Or does that not even matter, given that it's returned from that "UnknownMethod1" above?) If it is nothing more than a plain IUnknown, why did you even add this, since it doesn't really extend the IUnknown interface with any new methods? It's telling that its v-table is the very first v-table in the object. This probably indicates that this really is the canonical IUnknown (i.e. the one that gets returned when you QI for IUnknown), and the other interfaces' IUnknown methods just delegate to this one. If I haven't missed my guess about this object's QI implementation, then this is the IUnknown that should get returned from a QI for IUnknown. This might actually be an object that supports aggregation; you may want to test for that, too ;). Chip

2 1

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests
by Henri Verbeet May 20, 2013

May 20, 2013

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > These tests have the potential to break on Windows when other > applications create or release a large number of video memory resources > while the test is running. > Yeah, maybe we don't really need this to be in the tree, although it's good to see for reference.

4 3

Re: msvcm80: Remove pre-attach handler for a dll with manifest.
by Alexandre Julliard May 20, 2013

May 20, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Manifest prevents loading of a native dll anyway. Not if it's installed globally. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.
by Dmitry Timoshkov May 20, 2013

May 20, 2013

Qian Hong <qhong(a)codeweavers.com> wrote: > Fixed http://bugs.winehq.org/show_bug.cgi?id=33076 > > Reference: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms741621%28v=vs.85%… > > See also comment in WSAIoctl: > /* AsyncSelect()'ed sockets are always nonblocking */ This change requires a test case, MSDN is often wrong, so its claims at least need to be very carefully checked. -- Dmitry.

2 5

Re: oledb32: Support DBSTATUS_S_ISNULL when converting to VARIANT
by Marvin May 20, 2013

May 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25629 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Marvin May 19, 2013

May 19, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25624 Your paranoid android. === WVISTAX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77370897 === W2K8SE (32 bit bitmap) === bitmap: unhandled exception c0000005 at 778A81CB === W7PROX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77E035F2 === TEST64_W7SP1 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77593772 === W7PROX64 (64 bit bitmap) === No test summary line found === TEST64_W7SP1 (64 bit bitmap) === Timeout

1 0

Duplicate relocations in DLL
by Alessandro Pignotti May 19, 2013

May 19, 2013

Hi everyone, Packaged with a game, I found a peculiar DLL which has duplicate blocks in the relocation table. I mean that the same pages are relocated twice and this of course breaks the DLL. I'm not sure about what could be a right way to support such (broken) DLLs. A possibility would be to keep track of already relocated pages and skip them if needed. Suggestions are welcome. Regards, Alessandro Pignotti

3 7

wineconsole screen scenarios
by Hugh McMaster May 19, 2013

May 19, 2013

In my effort to improve wineconsole and its calculations of the largest possible window size, three scenarios come into play. 1. wineconsole with --backend=user (or more simply, 'wineconsole app.exe, in which case 'user' is the default). 2. wineconsole with --backend=curses. 3. wineconsole with --backend=curses, but no X server running. Detecting the screen resolution is a simple task with (1) and (2). SystemParametersInfo for (1) and wine's own XRandR for (2) can be used. My concern is with scenario (3). Wine is designed to be used with an X server, but wineconsole can be used in non-X-based environment. While this is possible, it would seem unlikely. Nonetheless, the issue has come up on the wine-devel list before. The question is, should I worry about supporting such a scenario?

5 6

Re: [PATCH] ieframe: Add a IServiceProvider stub to IBindStatusCallback
by Alistair Leslie-Hughes May 18, 2013

May 18, 2013

On 18/05/2013 11:11 PM, Detlef Riekenberg wrote: > -- > By by ... Detlef > > --- > dlls/ieframe/navigate.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 51 insertions(+), 0 deletions(-) Tests to prove the interface exists. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow (resend)
by Marvin May 18, 2013

May 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25614 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: GSoC proposal
by George Stephanos May 17, 2013

May 17, 2013

As we know already from [1], the merge is going to happen according to certain rules. The list at the end of the page signifies which subkeys are going to be *merged* from HKLM\Software\Classes\subkey and HKCU\Software\Classes\subkey and not simply linked to. Now there's a comment on the article that says that list is stored in a key. That lead me into thinking that the list is dynamic and should be determined at runtime using that key. However that key doesn't exist on my Win8 box or the web even. Should I just assume the list is static and build my tests/code according to it? Is there something I'm missing? [1] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… On Wed, May 8, 2013 at 1:26 AM, George Stephanos <gaf.stephanos(a)gmail.com>wrote: > I'm done. Sorry for the font massacre. They're not changing :| > > > On Tue, May 7, 2013 at 6:45 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > >> I'll leave it open till tomorrow (my time.) Thanks, >> --Juan >> >> >> On Tue, May 7, 2013 at 9:44 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> >>> Oh, hang on, I just flipped it so you can modify it. >>> >>> >>> On Tue, May 7, 2013 at 9:43 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >>> >>>> I think you can add more of a timeline in a response. Will that work? >>>> --Juan >>>> >>>> >>>> On Tue, May 7, 2013 at 9:40 AM, George Stephanos < >>>> gaf.stephanos(a)gmail.com> wrote: >>>> >>>>> I had responded already but yes I'm a little bit shallow on the >>>>> timeline details. Alright. >>>>> Could you give me permission to modify the proposal? >>>>> >>>> >>>> >>> >> >

2 2

Re: [PATCH 4/6] gdi32: Use the default character when the glyph is missing.
by Alexandre Julliard May 17, 2013

May 17, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This change is useful for a bitmap font. Because its glyph index 0 isn't the > default glyph in some cases. This doesn't seem to match what GetGlyphIndices does, and we probably don't want to do that in two different places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25605 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25604 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Only display a fixme when software processing is requested in wined3d_device_set_software_vertex_processing.
by Austin English May 17, 2013

May 17, 2013

On Thu, May 16, 2013 at 2:26 PM, Christian Costa <titan.costa(a)gmail.com> wrote: > Also remove fixme in wined3d_device_get_software_vertex_processing since it does what it is supposed to do. > --- > dlls/wined3d/device.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 47da78b..89fc525 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4281,9 +4281,9 @@ void CDECL wined3d_device_set_software_vertex_processing(struct wined3d_device * > > TRACE("device %p, software %#x.\n", device, software); > > - if (!warned) > + if (software && !warned) > { > - FIXME("device %p, software %#x stub!\n", device, software); > + FIXME("Software vertex processing not supported. Fake it and use harware one."); > warned = TRUE; Typo, should be hardware. -- -Austin

2 1

Re: msvcp90: Prefer native version.
by Piotr Caban May 17, 2013

May 17, 2013

On 05/17/13 08:01, Dmitry Timoshkov wrote: > Just like msvcp60,msvcp70,msvcp71,msvcp80,msvcp100,msvcp110 do. > --- > dlls/msvcp90/msvcp90_main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp90_main.c b/dlls/msvcp90/msvcp90_main.c > index 7a7aafe..ce56c14 100644 > --- a/dlls/msvcp90/msvcp90_main.c > +++ b/dlls/msvcp90/msvcp90_main.c > @@ -80,10 +80,13 @@ static void init_cxx_funcs(void) > > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > { > - TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + TRACE("(%p,%u,%p)\n", hinstDLL, fdwReason, lpvReserved); > > switch (fdwReason) > { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ > + > case DLL_PROCESS_ATTACH: > init_cxx_funcs(); > init_lockit(); > msvcp90 has some wine specific exports. This patch breaks other msvcpXX dlls when native msvcp90 is installed.

3 5

GSoC 2013 - Registry Merging Project
by orzhvs May 17, 2013

May 17, 2013

Hi. I'm applying for the Google Summer of Code 2013, this is my proposal for the registry merging project. I'll work on improving Wine's registry in its stability and simulation to solve frequently seen non user-friendly problems, which usually caused by that application or system settings are not stored and fetched correctly. Project & My Understand: I'm most interested in the project "Registry - implement merging between HKEY_CLASSES_ROOT and HKEY_CURRENT_USER\Software\Classes". Its core task is to implement RegOpenUserClassesRoot, which returns a key token of merging view of HKCU & HKLM classes rather than present returning HKCR Classes. The difficulity is that as a view of two independent registry trees, how to treat conflicts and make changes to two seperated entrys when using HKCR as root, and how to achieve the function with no or least effect on other part of registry operation such as RegOpenKeyExX. I have some seed ideas that maybe not mature but I like solving problems initially from a burst port : Scheme 1. Registry operations based on hKey ( handle ) under HKEY_CLASSES_ROOT will be degeneration to full path in text, like "HKEY_CLASSES_ROOT\Subdir1", and try the operation after "HKEY_CLASSES_ROOT" replaced with "HKEY_CURRENT_USER\Software\Classes" and "HKEY_LOCAL_MACHINE\Software\Classes" in order, only the first success operation will be applied. This may satisfy the demand, both for query and modify. For details like the correct order, I'll make it out once get working on it. In this way, the HKCR key subtree does not exist in fact but only exists as a name. Scheme 2. After the base registry is initialized, build the HKCR's subkey trees with a new pulled in object type (say it 'symbol link') that directly point to the correct keys from HKLM or HKCU. Thus operation in HKCR tree are redirected to corresponding branch internally. When operating the HKCR itself, like creating new subkeys direct under HKCR, the operation is redirected to HKCU classes. This scheme seems more fluent but needs some tricks in the server part. What I'll Do : First of all I'll do a lot of tests on pure winows registry to definite my questions and guesses, write one or more test reports on different version of windows, some of which is already being done now. Followed by I will design the algorithms and data structures and make a complete development planation. Then enjoying coding and debuging Wine. I love the procedure, during the longest part of this project, keep writing daily report. Got the plan finished, I will applying improvement. Finally strict tests will be done to show if I achieved the final goal and a conclude paper will be carefully submitted. I'd like not only settle down the main project, but also several ideas to make Wine better, which are found in my daily use of Wine, such as add support for the shell context menu in Wine explorer for many convenient shotcuts of some software like the famous 7zip. I'll do this once time allows. Why Me : I myself is a faithful user of Wine. I know the thought of Wine and know not only basic usage but also a little implement of it. I understand Windows registry both Windows API pretty well from nearly 8 years coding. Have done much test and hooks in windows including RegXXX in advapi32.dll or lower level NtOpenKey in ntdll.dll. Further more, I used to do some kernel debug tests and hacks on registry, like hiding, protecting a subkey from regedit, resolving values from hive file rather than using API. These things are done under interests. I've been learning Windows API and OS theories from books and network like msdn for long. Ofcourse there will be no problem in registry knowledge. It's usual for me to write codes more than 1000 lines a day, for self use or for the competation ACM. I believe that I'm a careful man in codes and other things, I like discovering, guessing and proving. To prove I've developed a not too bad coding style, please refer to my submisions on codeforces http://codeforces.com/submissions/adnim (to view code click numbers under column "#"). And this may be a little evidence denoting that at least I've used git before, https://code.google.com/p/eryapass/ I know what should I do and what should not. I'm sure aware of the legal requirements. All of my tests will be done only in the black-box ways. No reverse work on Windows files is allowed and needed in Wine project, though I'm good at that. All codes will be written creatively and nothing will be copied from existing ones like WRK, RcactOS or something else. I love open source. I benefited much from the open source world and I'd be really happy to contribute to it one day. The last but most important, I'm much willing and I'm looking forward to throwing myself among the crowd of codes this entire summer, making maxium effort to improve Wine. I'd like schedule my personal activities to avoid conflicts with the development, meaning it won't be too busy in my schoolwork. Wine & Me : In my childhood, I've been coding in F-Basic on Subor (a kind of TV-based computer made in China) when friends are playing football in yard, at about 8 years old. When I was 12 years old, i was building some little games to happy classmates, and have learned c and c++ 2 years latter, then x86 asm 2 more years latter. And have done some graduation-designs for college brothers before I got to university. Also I've developed some projects for local companies. I first installed Ubuntu in 2010 and gradually I'm interested in open source projects. I'm 21 years old now, studying software engineering in Shandong University of Science and Technology in China. I'm a really enthusiastic user of Wine, who has been using it from version 1.2 to 1.4, on ubuntu, debian and gentoo. Since the first day I apt-got it I could not help trying all applications I used in Windows to it and making them running stably, during which I have learned much about configuring Wine. Another day I began to emerging that and I was once deep interested in building my customed Wine and Wine based tests. I heard about GSoC last year but missed the time. This year, I decided that I will try my best to contribute, transform my ideas to powerful codes that people will run with satisfaction. Please do not hesitate to contact me. Thanks. Guo Jian

3 9

gdi32: GetGlyphIndices doesn't substitute glyph incorrect
by Aric Stewart May 17, 2013

May 17, 2013

Hi there, I know I am a year late to the party here but I am digging deep into tategaki for a few Japanese programs that are having serious rendering issues and I believe that this patch is incorrect. I am attaching the test patch that proves it to me. Kusanagi-san, we should try to make sure that this does not break what it was that you where trying to fix with your original patch. -aric

2 4

Re: [PATCH 5/5] mshtml: Added whitespace parser tests.
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25599 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] mshtml: Added parsing custom tag name tests.
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25598 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0