May 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] mshtml: Added more parser compatMode tests.
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25597 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] user32/tests: Test that sending WM_CANCELMODE cancels tracking in window's menu bar.
by Dmitry Timoshkov May 17, 2013

May 17, 2013

Ken Thomases <ken(a)codeweavers.com> wrote: > dlls/user32/tests/menu.c | 21 ++++++++++++++++++++- Please add a message test instead, it would much more clearer show what is going on. > + {MSG msg; while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessage(&msg);} Please avoid creating such embedded blocks. -- Dmitry.

2 2

Re: winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Ken Thomases May 16, 2013

May 16, 2013

Hi Kevin, I'm bringing this back to wine-devel. Please CC the list unless you intend to take things private, in which case please say so. On May 10, 2013, at 6:48 PM, Kevin Eaves wrote: > I should have made everything clear, sorry. It was for personal use, so it's pretty nasty, but works great. The only real problem is with user32. Everything else is easy to clean up and get working with Wine properly without any issues. Just wanted to show that. Sure, that's what I figured. > On May 9, 2013, at 9:56 PM, Ken Thomases wrote: > >>> The fullscreen button appears if a main window is resizable. >> >> We may want to narrow this down a bit. For example, the common file dialogs are resizable, but probably shouldn't be full-screen-enabled. Perhaps no owned window should be. > > Only windows in the windows cycle should be fullscreen enabled. If the window can be manually moved to its own space, then it should be able to go fullscreen. No dialogs are enabled. These follow the main window to spaces. If in Cocoa fullscreen, the new window automatically opens fullscreen in its own space. Everything works just like Mac applications with this setting. Ah, I failed to notice before that the use of NSWindowCollectionBehaviorFullScreenPrimary was only in the same code path as NSWindowCollectionBehaviorParticipatesInCycle. Yes, that makes sense. >> From cocoa_window.m.diff: >> >>> +#import <Cocoa/Cocoa.h> >> >> >> Was that actually needed? cocoa_window.h already imports <AppKit/AppKit.h>. >> >> ... >> >>> + if (style & NSResizableWindowMask) >>> + [[self standardWindowButton:NSWindowZoomButton] setEnabled:!self.disabled]; > > These should have not been included in the diff. It's unrelated to Cocoa fullscreen, however, the zoom button is currently bugged. It is not disabled when the window is disabled. To reproduce the problem: launch regedit, open the import window, and click the zoom button on the main window. I sent a patch for it. I'm not seeing that problem happen here. Mind you, I'm currently testing on 10.6. I'll have to run some tests on 10.7+ tomorrow. I find it improbable that removing NSResizableWindowMask from the style doesn't disable the zoom button. That style is the only thing which enables the zoom button to begin with. In other words, in a normal Mac app, one would not need to disable the zoom button separately. >>> - if (captured || fullscreen) >>> + if (captured || (fullscreen && !(normalStyleMask & NSResizableWindowMask))) >> >> You're trying to distinguish between a window that was full-screened at the instigation of the Windows program versus one which has been full-screened by Cocoa, right? Hmm. I think we need a better technique to determine that. I agree that it's not likely the Windows program would make its window full-screen while still allowing it to be resized but it feels wrong to assume that. >> >> Also, I think we can entirely avoid setting the window level for windows that have been Cocoa full-screened. Setting the window level is mostly about relationship to other windows, but a Cocoa full-screen window should be on a space by itself, shouldn't it? >> >>> + else if ([self styleMask] & NSFullScreenWindowMask) >>> + level = NSMainMenuWindowLevel + 2; >> >> I'm not following why Cocoa full-screened windows should be at +2 vs. +1. > > The window levels are automatically adjusted and the menu is in a hover state. We need to prevent the menu from being hidden, and hide the menu if the Windows program goes fullscreen while in Cocoa fullscreen (+1 doesn't cut it). I'm going to have to do some testing to understand this, too. NSMainMenuWindowLevel should be in the same level as the menu (meaning could be above or below due to normal window ordering operations). NSMainMenuWindowLevel + 1 should always be above the menu, regardless. NSMainMenuWindowLevel + 2 should not be necessary. But maybe something weird is going on. Also, if the Windows program changes a window from resizable to non-resizable, then we should probably pull the window out of Cocoa fullscreen. The Windows program _may_ have intended to make the window full-screen but we can't know that. It may simply be changing the window style for some other purpose, and that may make it no longer a candidate for Cocoa full-screen mode. >>> + - (NSSize)window:(NSWindow *)window willUseFullScreenContentSize:(NSSize)proposedSize >>> + { >>> + return NSMakeSize(proposedSize.width, proposedSize.height); >>> + } >> >> Is this actually needed? I assume that's the default behavior when the delegate method is absent. (Also, if it is necessary, it can just return proposedSize without making a new size struct.) > > This little gem will resize ANY window — non-resizable, disabled, a dialog box... Add this and poof!! There is no reason to ever disable Cocoa fullscreen. Mac applications don't so neither should Wine. I disagree. Windows programs that are not expecting their window to resize (because they haven't made them resizable) can misbehave badly if the window does resize. Just because that didn't happen in your testing doesn't mean it won't. As you mentioned in your original email, Cocoa full-screen is roughly akin to window resizing. So, it should be disabled if/when the window is made non-resizable. > I haven't tested this enough with non-resizable windows, but it is possible to resize any window. I don't follow this. It is possible to resize any window even non-resizable ones? To what are you referring? Possible how? Do you mean specifically just with this full-screen patch? > I use this feature to resize a few non-resizable game windows. Maybe add a registry key to allow non-resizable windows to go fullscreen. Perhaps. Cheers, Ken

2 2

Re: [PATCH 1/6] fonts: Add default glyph to Tahoma.
by Alexandre Julliard May 16, 2013

May 16, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > fonts/tahoma.sfd | 94 +++++++++++++++++++++++++++++------------------------- > fonts/tahoma.ttf | Bin 100420 -> 97836 bytes > 2 files changed, 50 insertions(+), 44 deletions(-) We already have .notdef, we shouldn't need a second one. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: configure: try to use -Werror=unknown-warning-option if available (2/2)
by Alexandre Julliard May 16, 2013

May 16, 2013

Austin English <austinenglish(a)gmail.com> writes: > @@ -1773,6 +1773,7 @@ then > fi > > dnl Check for some compiler flags > + WINE_TRY_CFLAGS([-Werror=unknown-warning-option]) > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) I don't think we want to build with that, it should be used only for the configure checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: vbscript: Round half to even in to_int.
by Marvin May 16, 2013

May 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25581 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Participate in GSoC
by Adam Chyła May 16, 2013

May 16, 2013

Hi all, I'm a student who would like to participate in GSoC with task "Tools - Winetest Graphical User Interface". What should I do? Adam Ch.

2 1

Re: WM_IME_REQUEST gets passed into ImmIsUIMessage
by Alexandre Julliard May 15, 2013

May 15, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/imm32/imm.c | 2 ++ > dlls/user32/defwnd.c | 19 +++++++++++++++++++ > dlls/winemac.drv/ime.c | 34 ++++++++++++++++++++++++++++++++++ > dlls/winex11.drv/ime.c | 34 ++++++++++++++++++++++++++++++++++ > 4 files changed, 89 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -M imm32.dll -T ../../.. -p imm32_test.exe.so imm32.c && touch imm32.ok imm32.c:580: Test failed: ImmIsUIMessageA returned 1 for 288 imm32.c:584: Test failed: ImmIsUIMessageA returned 1 for 288 make: *** [imm32.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] wined3d: Use d3d_level_from_gl_info in match_dx10_capable
by Henri Verbeet May 15, 2013

May 15, 2013

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -613,14 +635,7 @@ static BOOL match_apple_nonr500ati(const struct wined3d_gl_info *gl_info, const > static BOOL match_dx10_capable(const struct wined3d_gl_info *gl_info, const char *gl_renderer, > enum wined3d_gl_vendor gl_vendor, enum wined3d_pci_vendor card_vendor, enum wined3d_pci_device device) > { > - /* DX9 cards support 40 single float varyings in hardware, most drivers report 32. ATI misreports > - * 44 varyings. So assume that if we have more than 44 varyings we have a dx10 card. > - * This detection is for the gl_ClipPos varying quirk. If a d3d9 card really supports more than 44 > - * varyings and we subtract one in dx9 shaders its not going to hurt us because the dx9 limit is > - * hardcoded > - * > - * dx10 cards usually have 64 varyings */ > - return gl_info->limits.glsl_varyings > 44; > + return d3d_level_from_gl_info(gl_info) >= 10; > } > I'm not sure d3d_level_from_gl_info() is quite reliable enough for this. For example, Mesa doesn't implement EXT_gpu_shader4, and possibly never will. Using an actual hardware limit seems more reliable.

1 0

Re: [PATCH 5/6] d3d: d3d9ex does not do video memory accounting for D3DPOOL_DEFAULT resources
by Henri Verbeet May 15, 2013

May 15, 2013

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -922,6 +922,8 @@ enum wined3d_display_rotation > #define WINED3DCREATE_DISABLE_DRIVER_MANAGEMENT 0x00000100 > #define WINED3DCREATE_ADAPTERGROUP_DEVICE 0x00000200 > > +#define WINED3DCREATE_NO_VIDMEM_ACCOUNTING 0x10000000 > + I think it makes more sense to make this a wined3d_create() flag, and in invert it, since we also want this for d3d10+. E.g. something along the lines of WINED3D_NO_GPU_VMM.

1 0

Wacom Graphire3 tablet not detected as tablet (MacOSX 10.8)
by Andrey Upadyshev May 14, 2013

May 14, 2013

Hi, I have Wacom Graphire3 tablet and it's working well under Windows, MacOS or MacOS + X (Inkscape). But Wine can't detect it as tablet and disables the wintab support. The actual stylus device is Device 6 [id 8|name pen|type |num_classes 2|use 4], but log says it is not apparently a tablet cursor type device. There is a wintab log: > trace:wintab32:DllMain 0x43d60000, 1, 0x0 > trace:wintab32:DllMain Initialization > trace:wintab32:TABLET_WindowProc Incoming Message 0x81 (0x00000000, > 0x0032f6b0) > trace:wintab32:TABLET_WindowProc Incoming Message 0x83 (0x00000000, > 0x0032f400) > trace:wintab32:TABLET_WindowProc Incoming Message 0x1 (0x00000000, > 0x0032f6b0) > trace:wintab32:TABLET_WindowProc Incoming Message 0x5 (0x00000000, > 0x00000000) > trace:wintab32:TABLET_WindowProc Incoming Message 0x3 (0x00000000, > 0x00000000) > trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x10126 > trace:wintab32:X11DRV_LoadTabletInfo XListInputDevices reports 9 devices > trace:wintab32:X11DRV_LoadTabletInfo Device 0: [id 2|name Virtual core > pointer|type |num_classes 2|use 0] > trace:wintab32:X11DRV_LoadTabletInfo Device 1: [id 3|name Virtual core > keyboard|type |num_classes 1|use 1] > trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 4|name Virtual core > XTEST pointer|type |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 2 [name Virtual core > XTEST pointer|type ]; not apparently a tablet cursor type device. If this > is wrong, please report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 3: [id 5|name Virtual core > XTEST keyboard|type |num_classes 1|use 3] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo No buttons, Non Tablet Device > trace:wintab32:X11DRV_LoadTabletInfo Device 4: [id 6|name xquartz virtual > pointer|type |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 4 [name xquartz > virtual pointer|type ]; not apparently a tablet cursor type device. If > this is wrong, please report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 5: [id 7|name xquartz virtual > keyboard|type |num_classes 1|use 3] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo No buttons, Non Tablet Device > trace:wintab32:X11DRV_LoadTabletInfo Device 6: [id 8|name pen|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 6 [name pen|type ]; > not apparently a tablet cursor type device. If this is wrong, please > report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 7: [id 9|name cursor|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo ButtonInput 0: [class 1|length > 12|num_buttons 3] > trace:wintab32:X11DRV_LoadTabletInfo ValidatorInput 1: [class 2|length > 80|num_axes 5|mode 1|motion_buffer 256] > trace:wintab32:trace_axes Axis 0: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 1: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 2: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 3: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:trace_axes Axis 4: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:X11DRV_LoadTabletInfo Device 8: [id 10|name eraser|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo ButtonInput 0: [class 1|length > 12|num_buttons 3] > trace:wintab32:X11DRV_LoadTabletInfo ValidatorInput 1: [class 2|length > 80|num_axes 5|mode 1|motion_buffer 256] > trace:wintab32:trace_axes Axis 0: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 1: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 2: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 3: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:trace_axes Axis 4: [resolution 1|min_value > -65536|max_value 65536] > warn:wintab32:X11DRV_LoadTabletInfo Did not find a valid stylus, unable to > determine system context parameters. Wintab is disabled. > It would be great if someone can fix this problem. Thank you, Andrey Upadyshev

1 0

Re: [PATCH 3/3] d3dx9_36: Add support for D3DFMT_P8 and conversion to other ARGB formats + tests.
by Alexandre Julliard May 14, 2013

May 14, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -36,6 +36,16 @@ static void la_to_rgba(const struct vec4 *la, struct vec4 *rgba) > rgba->w = la->w; > } > > +static void index_to_rgba(const struct vec4 *index, struct vec4 *rgba, const PALETTEENTRY *palette) > +{ > + ULONG idx = (ULONG)(index->x * 255.0f + 0.5f); > + > + rgba->x = palette[idx].peBlue / 255.0f; > + rgba->y = palette[idx].peGreen / 255.0f; > + rgba->z = palette[idx].peRed / 255.0f; > + rgba->w = palette[idx].peFlags / 255.0f; > +} PALETTEENTRY doesn't seem to be the right type for what you need. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32/tests: Added capture test for child window when parent window is disabled.(try 4)
by Alexandre Julliard May 14, 2013

May 14, 2013

Guo Jian <orzhvs(a)gmail.com> writes: > This is my first patch, could you please have a review? Thank you. Looks OK, but you could probably merge it into one of the existing capture tests, it doesn't really need a brand-new window. Also when sending patches that depend on each other, please number them so that the testbot can make sense of it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (resend).
by Alexandre Julliard May 14, 2013

May 14, 2013

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-streaming sites as well). > > With this patch the SIO_ADDRESS_LIST_CHANGE call gets passed on to > NotifyAddrChange, which effectively fixes a problem where Silverlight > apps can loop forever calling SIO_ADDRESS_LIST_CHANGE (Bug #32328). > Part 2 actually implements the NotifyAddrChange call on Linux, though > this patch is sufficient to resolve the bug since the overlapped IO > event no longer gets triggered. The notification is supposed to be tied to the socket. I don't think that NotifyAddrChange can do the job. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: Disable the zoom button for windows that are disabled.
by Ken Thomases May 14, 2013

May 14, 2013

Hi Kevin, As mentioned in the other thread, I'm not seeing the problem that this is meant to solve on 10.6. I will test 10.7+ tomorrow. Also, I'm pretty sure that setting the style mask after disabling the buttons can reenable them. At least in some versions of the frameworks, we've seen that -setStyleMask: basically resets the standard buttons from scratch. Indeed, in my testing, this patch reenables the close and minimize buttons on a disabled window. Regards, Ken

1 2

[PATCH 1/2] Added test to show EnableWindow cause wrong ReleaseCapture (try 3)
by Guo Jian May 14, 2013

May 14, 2013

Hello everyone, This is my first patch to wine, which has been submitting since the last day. Please help that what is the safe way sending patches that makes sure the patch is not corrupt by my mail client? Is it the most correct way to attach a path with .txt suffix rather than past inline? Or which mail client should I use that may avoid this problem? Thunderbird wraps long lines and join lines terminating with a space, I have to manually correct that, it does slows me down. Thanks. Guo Jian A window will lose capture if it's disabled, but it's children should not. Related to bug 33542. The test is to show that mouse capture of a window is lost when disabling its parent window. It has been tested fine with newtestbot. --- dlls/user32/tests/win.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+)

2 1

Re: user32: Use PostMessage to send WM_DRAWCLIPBOARD
by Alexandre Julliard May 13, 2013

May 13, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/clipboard.c | 4 +-- > dlls/user32/tests/clipboard.c | 78 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 80 insertions(+), 2 deletions(-) We already have tests that show that this is wrong: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:12683: Test failed: set viewer NULL->1: 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12690: Test failed: clear clipbd (viewer=owner=1): 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12695: Test failed: clear clipbd (viewer=1, owner=2): 1: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12700: Test failed: set viewer 1->1: 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12751: Test failed: clear clipbd (no viewer, owner=1): 0: the msg sequence is not complete: expected 0307 - actual 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Pass the state and private data to shader_select
by Henri Verbeet May 13, 2013

May 13, 2013

On 12 May 2013 15:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Disable shaders */ > - device->shader_backend->shader_select(context, WINED3D_SHADER_MODE_NONE, WINED3D_SHADER_MODE_NONE); > + device->shader_backend->shader_select(context, WINED3D_SHADER_MODE_NONE, WINED3D_SHADER_MODE_NONE, > + NULL, device->shader_priv); I think that's a bit questionable. Passing NULL state happens to work for this set of arguments, but I don't think we want that to be part of the interface.

3 3

Re: po: Fix typos in German translation
by Julian Rüger May 13, 2013

May 13, 2013

Hi André, > -msgstr "Datagramme gesendet" > +msgstr "Datenpakete gesendet" In all my university classes, (UDP) Datagrams were translated or referred to as "Datagramme" and more or less strictly distinguished from packets. "Vollzugriff" vs. "voller Zugriff" is a matter of taste, I picked the first because back when I used Windows, that was a common term to read, but that could have just been my firewall or something. I would have preferred for it to be added to Francois' wordlist, but whatever. Best, Julian

2 1

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify (try 2).
by Marvin May 13, 2013

May 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25553 Your paranoid android. === WXPX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === WVISTAX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === W7PROX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === TEST64_W7SP1 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120

1 0

Re: [PATCH 4/5] wined3d: Explicitly pass the state to shader_load_constants
by Henri Verbeet May 13, 2013

May 13, 2013

On 12 May 2013 15:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -806,7 +806,8 @@ struct wined3d_shader_backend_ops > void (*shader_deselect_depth_blt)(void *shader_priv, const struct wined3d_gl_info *gl_info); > void (*shader_update_float_vertex_constants)(struct wined3d_device *device, UINT start, UINT count); > void (*shader_update_float_pixel_constants)(struct wined3d_device *device, UINT start, UINT count); > - void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS); > + void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS, > + const struct wined3d_state *state, void *shader_priv); > void (*shader_load_np2fixup_constants)(void *shader_priv, const struct wined3d_gl_info *gl_info, > const struct wined3d_state *state); > void (*shader_destroy)(struct wined3d_shader *shader); > I think we'll want shader_priv to be the first argument, for consistency with the other calls. I don't think usePS and useVS are needed anymore.

1 0

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.
by Hans Leidekker May 13, 2013

May 13, 2013

On Mon, 2013-05-06 at 19:23 -0600, Erich E. Hoover wrote: > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -210,8 +210,14 @@ DWORD WINAPI AllocateAndGetIpAddrTableFromStack(PMIB_IPADDRTABLE *ppIpAddrTable, > */ > BOOL WINAPI CancelIPChangeNotify(LPOVERLAPPED overlapped) > { > - FIXME("(overlapped %p): stub\n", overlapped); > - return FALSE; > + HANDLE handle; > + > + TRACE("(overlapped %p)\n", overlapped); > + > + if (!overlapped) > + return FALSE; > + handle = (HANDLE) overlapped->u.Pointer; > + return TerminateThread(handle, STATUS_CANCELLED); > } TerminateThread is not the right tool here. If the thread is blocked on the recv call while being terminated it will leak the netlink socket. You'd need a way to synchronize the threads, but an overhead of one thread per caller is rather costly in the first place. This suggests that the server should poll the socket.

3 9

Re: [2/2] server: Remove a not necessary check for 'current' being not NULL.
by Alexandre Julliard May 13, 2013

May 13, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > 'current' is already dereferenced twice before this point. > --- > server/request.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) You can't do that. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [website] Simplified Chinese translation for release 1.5.30
by Qian Hong May 12, 2013

May 12, 2013

2013/5/11 Jactry Zeng <jactry92(a)gmail.com>: > + <li>WinInet 对代理旁路的支持。</li> This translation seems suspect, but I don't have a very good alternative yet. In 'Internet Options' setting of MSIE7, 'Bypass proxy server for local address' is translated to '跳过本地地址的代理服务器' Thanks for the work. -- Regards, Qian Hong - http://www.winehq.org

2 2

IPC between linux processes and wine processes
by Alexandre Bique May 12, 2013

May 12, 2013

Hi, I plan to write a Linux VST bridge to Windows VST. This could improve windows VST support in our native DAW. I wonder what is the best strategy and what do you recommend? - spawn a wine vst host process from the linux vst and then do IPC through unix socket - spawn a wine vst host process from the linux vst and then do IPC through tcp socket - spawn a wine vst host process from the linux vst and then do IPC through shared memory - load the windows vst into the Linux process and directly call its functions (with appropriate calling convention). Thanks a lot! Regards, -- Alexandre Bique

3 4