May 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 26, 2013

Oct. 26, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Re: Web based translation tool
by Michal Čihař June 17, 2013

June 17, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

[PATCH v6 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky June 11, 2013

June 11, 2013

Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 +++++++------ fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 +++++-- fs/cifs/inode.c | 21 +++--- fs/cifs/link.c | 25 ++----- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 ++-- fs/fcntl.c | 5 +- fs/locks.c | 158 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 48 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++- fs/nfs/nfs4xdr.c | 21 +++++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 +++++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 ++++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 35 files changed, 443 insertions(+), 139 deletions(-) -- 1.8.1.5

4 13

Re: ole32: Add a basic OLE client/server test suite. Take 2.
by Dmitry Timoshkov June 5, 2013

June 5, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

2 7

Re: [1/2] DWrite: Implemented functions regarding text alignment. (try 3)
by Nikolay Sivov May 31, 2013

May 31, 2013

On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering <Cookiezzz97(a)gmx.de>wrote: > Implemented functions of text format and text layout regarding text > alignment. > > Try 3: Used proper enum value to set the enum variables. > > > > > + if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER && alignment!=DWRITE_TEXT_ALIGNMENT_LEADING && + alignment!=DWRITE_TEXT_ALIGNMENT_JUSTIFIED && alignment!=DWRITE_TEXT_ALIGNMENT_TRAILING) + return E_INVALIDARG; + This->format.text_align = alignment; This doesn't look great, you'll need a test that shows it really rejects meaningless values, and if it does it would be simpler to compare with greatest enum value.

1 0

Re: [PATCH] slc: Fix return type
by Christian Costa May 31, 2013

May 31, 2013

Le 29/05/2013 12:06, Detlef Riekenberg a écrit : > -- > By by ... Detlef > --- > dlls/slc/slc.c | 31 +++++++++++++++++++++++-------- > include/slpublic.h | 2 +- > 2 files changed, 24 insertions(+), 9 deletions(-) > > diff --git a/dlls/slc/slc.c b/dlls/slc/slc.c > index e7416f1..7fc9b93 100644 > --- a/dlls/slc/slc.c > +++ b/dlls/slc/slc.c > @@ -1,6 +1,7 @@ > /* > * > * Copyright 2008 Alistair Leslie-Hughes > + * Copyright 2010 Detlef Riekenberg > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -28,15 +29,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(slc); > > -DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue) > -{ > - FIXME("(%s) stub\n", debugstr_w(lpszValueName) ); > - > - return SL_E_RIGHT_NOT_GRANTED; > -} > - > /*********************************************************************** > - * DllMain (CLUSAPI.@) > + * DllMain (slc.@) > * > */ > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > @@ -51,3 +45,24 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > } > return TRUE; > } > + > +/*********************************************************************** > + * SLGetWindowsInformationDWORD (slc.@) > + * > + * check the license and return the value for the given name > + * > + * PARAMS > + * name [i] application related value name to check > + * pvalue [o] ptr, where the value for the given name should be saved > + * > + * RETURNS > + * Success: S_OK > + * Failure: A HRESULT error code > + * > + */ > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue) > +{ > + FIXME("(%s, %p) stub\n", debugstr_w(name), pvalue); > + > + return SL_E_RIGHT_NOT_GRANTED; > +} > diff --git a/include/slpublic.h b/include/slpublic.h > index a2c6d42..5553787 100644 > --- a/include/slpublic.h > +++ b/include/slpublic.h > @@ -29,7 +29,7 @@ extern "C" { > #define SLCAPI DECLSPEC_IMPORT > #endif > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue); > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *); > > > #ifdef __cplusplus I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :)

2 2

Re: [PATCH] winmm/tests: Fix test that fails on NT4
by Marvin May 31, 2013

May 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25788 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [1/2] explorer: Initial implementation of desktop launchers.
by Qian Hong May 31, 2013

May 31, 2013

Hello Hans, On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > + hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get user desktop folder\n"); > + return; > + } > + hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get public desktop folder\n"); > + CoTaskMemFree( desktop_folder ); > + return; > + } Does KF_FLAG_CREATE look better here? Other wise every time a new wineprefix created there is an err output. Maybe I'm missing something here, thanks for your work. -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: [PATCH 2/4] d3dxof: Move list type and list nb elements into the parse context.
by Alexandre Julliard May 30, 2013

May 30, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3dxof/d3dxof_private.h | 2 ++ > dlls/d3dxof/parsing.c | 23 ++++++++++------------- > 2 files changed, 12 insertions(+), 13 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so mesh.c && touch mesh.ok mesh.c:2291: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2299: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2323: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2347: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2399: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2403: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2407: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2408: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2409: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2495: Tests skipped: D3DXCreateBox failed make: *** [mesh.ok] Error 9 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] advpack: Handle quoted arguments to rundll exports.
by Alexandre Julliard May 30, 2013

May 30, 2013

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -205,13 +205,24 @@ static HRESULT run_setup_commands_callback(HINF hinf, PCWSTR field, const void * > > /* sequentially returns pointers to parameters in a parameter list > * returns NULL if the parameter is empty, e.g. one,,three */ > -LPWSTR get_parameter(LPWSTR *params, WCHAR separator) > +LPWSTR get_parameter(LPWSTR *params, WCHAR separator, int quoted) Using proper boolean type and constants would be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] DWrite: Implemented functions regarding text alignment. (try 2)
by Alexandre Julliard May 30, 2013

May 30, 2013

Fabian Müntefering <Cookiezzz97(a)gmx.de> writes: > @@ -1023,6 +1034,9 @@ HRESULT create_textformat(const WCHAR *family_name, IDWriteFontCollection *colle > This->format.size = size; > This->format.stretch = stretch; > > + /*Default values.*/ > + This->format.text_align = 0; Please use proper enum values when setting enum variables. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/4] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 3)
by Marvin May 30, 2013

May 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25774 Your paranoid android. === WVISTAX64 (64 bit heap) === No test summary line found === W7PROX64 (64 bit heap) === No test summary line found === TEST64_W7SP1 (64 bit heap) === No test summary line found

1 0

Re: [1/4] kernel32: Add more GlobalReAlloc/LocalReAlloc tests.
by Marvin May 30, 2013

May 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25773 Your paranoid android. === WVISTAX64 (64 bit heap) === No test summary line found === W7PROX64 (64 bit heap) === No test summary line found === TEST64_W7SP1 (64 bit heap) === No test summary line found

1 0

Re: msvcrt: remove hack
by Henri Verbeet May 30, 2013

May 30, 2013

On 30 May 2013 07:23, Austin English <austinenglish(a)gmail.com> wrote: > and no modern gcc/other compiler that I can find cares. > It does if you add -Wunused-parameter, but then you'll get a lot of other warnings as well. IMO the "action = action;" line is pretty pointless and best just removed, though if people are just looking for a different workaround, "(void)action;" is more or less the standard way to do it.

1 0

Re: msvcrt: remove hack
by Marcus Meissner May 30, 2013

May 30, 2013

On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: > This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b > > but clang doesn't like it: > clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers > -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith > -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -o process.o > process.c > process.c:363:10: warning: explicitly assigning a variable of type > 'int' to itself [-Wself-assign] > action = action; /* Remove warning */ > ~~~~~~ ^ ~~~~~~ > 1 warning generated. > > and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus

4 6

Re: dinput: Update existing joystick values after setting the range property
by Austin English May 29, 2013

May 29, 2013

On Sun, Apr 14, 2013 at 2:25 PM, Bassi, Gurmail <Gurmail.Bassi(a)mottmac.com> wrote: > ePSXe polls the joystick immediately after setting the axis range property, and uses the returned values as its 'centered' calibrated values - therefore the existing joystick state values must be remapped to the new range (or else the joystick may not have the full range of motion) > > > This patch has been tested on Ubuntu 12.04.1 LTS x86-64, and the behaviour confirmed to match Microsoft's DirectInput implementation on Windows XP 32-bit (Microsoft's DirectInput seems to update the existing joystick values to the new range prior to polling even if the joystick hasn't been moved) > > > --- > dlls/dinput/joystick.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) Hi Gurmail, This appears to have caused a regression, see http://bugs.winehq.org/show_bug.cgi?id=33496 (normally I'd cc you on the bug, but you don't seem to have a bugzilla account). -- -Austin

1 0

Re: (try 2)macdrv: rework the way we handle cursor position and composition text
by Ken Thomases May 29, 2013

May 29, 2013

On May 29, 2013, at 1:11 PM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 5 --- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 6 +-- > 5 files changed, 29 insertions(+), 77 deletions(-) > > > <0014-macdrv-rework-the-way-we-handle-cursor-position-and-co.txt> Looks good to me. -Ken

1 0

Re: macdrv: rework the way we handle cursor position and composition text
by Ken Thomases May 29, 2013

May 29, 2013

On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 3 -- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 5 +-- > 5 files changed, 29 insertions(+), 74 deletions(-) I know I reviewed this several times, but I failed to notice until now: you didn't remove the definition of IM_SET_CURSOR_POS in the enum and the entry in the table in dbgstr_event(). -Ken

2 1

GSoC 2013 has begun!
by Austin English May 29, 2013

May 29, 2013

Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by Nikolay Sivov Zhan Jianyu, "Improve and add missing feature of vbscript component" mentored by Jacek Caban Welcome to Wine and good luck on your projects! As a reminder, here are the next few big dates: May 27th - June 17: community bonding period. Students/mentors should use this time to iron out details of the project, learn the code base and get to know others on the project. June 17: coding officially begins July 29th - Aug 2nd: mid-term reviews are submitted. Mentors/students, please feel free to contact me or André Hentschel if you have any GSoC administrative/procedural questions. Otherwise use wine-devel or ask your mentor for help with learning the Wine development process/codebase/etc. -- -Austin

1 1

Re: [1/3] DWrite: Added missing JUSTIFIED text alignment mode.
by Nikolay Sivov May 29, 2013

May 29, 2013

Hi, Fabian. You forgot to attach patches 2 and 3.

1 0

re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Maarten Lankhorst May 29, 2013

May 29, 2013

NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

2 1

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.
by gurketsky May 29, 2013

May 29, 2013

Hi, just saw that a bit late. Is there a reason for the rewrite of hr? Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to overwrite the result anyway to D3D_OK on success, so I see no reason to change the hr to D3D_OK in parse_skin_mesh_info. Cheers Rico On 28.05.2013 22:16, Alexandre Julliard wrote: > + if (SUCCEEDED(hr)) > + hr = mesh_data->skin_info->lpVtbl->SetBoneOffsetMatrix(mesh_data->skin_info, index, > + (const D3DMATRIX*)(data + nb_influences * (sizeof(DWORD) + sizeof(FLOAT)))); > + if (FAILED(hr)) > + goto end; > + } > + > + hr = D3D_OK;

2 1

Re: Increment, Decrement, and Assignment Operators
by Alexandre Julliard May 29, 2013

May 29, 2013

Stephen Leibowitz <librestephen(a)gmail.com> writes: > Hello: > > This is my first patch. The changes are minor. If it works out, I may > attempt something more substantial. Doing cosmetic changes like this across the code base is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32: Ask for a newer FreeType version
by Alexandre Julliard May 29, 2013

May 29, 2013

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3686,7 +3686,8 @@ static BOOL init_freetype(void) > WINE_MESSAGE( > "Wine cannot find the FreeType font library. To enable Wine to\n" > "use TrueType fonts please install a version of FreeType greater than\n" > - "or equal to 2.0.5.\n" > + "or equal to 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" > "http://www.freetype.org\n"); > return FALSE; > } > @@ -3749,6 +3750,7 @@ sym_not_found: > "Wine cannot find certain functions that it needs inside the FreeType\n" > "font library. To enable Wine to use TrueType fonts please upgrade\n" > "FreeType to at least version 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" That's not useful. There are probably very few users who still have such an old Freetype, and even if they do, telling them about vertical metrics will only confuse them. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Increment, Decrement, and Assignment Operators
by Dan Kegel May 28, 2013

May 28, 2013

Watch http://source.winehq.org/patches/ for your patch's status (see legend at bottom). It might be rejected since it doesn't actually fix any behavioral problem in Wine. IIRC trivial cleanups in code are frowned upon, especially if they cross many modules. Better to pick some small real problem and fix it. How about http://bugs.winehq.org/show_bug.cgi?id=32922 ?

1 0

Re: gdi32/tests: Do not try to test OS/2 win metrics on non-windows fonts
by Dmitry Timoshkov May 28, 2013

May 28, 2013

Aric Stewart <aric(a)codeweavers.com> wrote: > + ascent = GET_BE_WORD(tt_os2.usWinAscent); > + descent = GET_BE_WORD(tt_os2.usWinDescent); > + cell_height = ascent + descent; > + ok(ntm->ntmCellHeight == cell_height, "%s: ntmCellHeight %u != %u, os2.usWinAscent/os2.usWinDescent %u/%u\n", > + font_name, ntm->ntmCellHeight, cell_height, ascent, descent); > + > + SetLastError(0xdeadbeef); The SetLastError() call should be left at its previous position. -- Dmitry.

1 0

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker May 28, 2013

May 28, 2013

On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > schemes is |= in the called function, but not > initialized before. > > Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so it would be better to fix it in that helper, without touching the parameter on error.

1 0

Re: [PATCH] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Marvin May 28, 2013

May 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25741 Your paranoid android. === WXPPROSP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === W2K3R2SESP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (64 bit dsound) === dsound.c:1433: Test failed: validbits: 0

1 0

Re: [5/5] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 2)
by Alexandre Julliard May 28, 2013

May 28, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This closes bug 14819. > > try 2: > * tests/heap.c was updated to avoid dependency on heap reallocation > strategies. > * Use HeapAlloc instead of LocalAlloc in some places. In those cases, > they want large memory blocks, not pinned memory addresses. They are using LMEM_MOVEABLE though. A few more tests for this flag would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

dxgi, directx 11 and code duplication
by John Yani May 28, 2013

May 28, 2013

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

2 1

dxgi, directx 11 and code duplication
by John Yani May 27, 2013

May 27, 2013

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

1 0

Release plans
by Alexandre Julliard May 27, 2013

May 27, 2013

Folks, Now that the Mac driver is fully merged and all the bugs fixed (right?), it's time to think about the next stable release. I would like to start the code freeze after the next release cycle, so two weeks from now. Hopefully, like last time we can keep the freeze period relatively short, so that it won't impact the Summer of Code projects too much. Note that in general, new test cases can be accepted during code freeze, and it's always a good idea to start a GSoC project by writing tests. On a related note, the test results on test.winehq.org haven't been looking very good lately; in particular, we need to make the full test suite succeed on the new testbot VMs, since the old ones are being phased out. Fixes to make tests succeed on Windows can go in during code freeze, since by definition they don't impact the Wine code, so this would be a good opportunity to try to improve the situation. OTOH the regression status is looking good, I'm very pleased with how we've kept the regression count under control during the 1.5 series. Hopefully we can even fix a few more during code freeze and set a lower baseline for the next development series. Thanks all for your help, and let's make this another great release! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: load winealsa if winepulse is found
by cfsworks＠gmail.com May 27, 2013

May 27, 2013

Wouldn't this cause applications which use winmm for waveout to be diverted to ALSA as well? Maybe both drivers should be loaded side by side, with winepulse handling everything but MIDI.

1 0

Re: [PATCH v23] winepulse: add pulseaudio driver
by Marvin May 27, 2013

May 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25724 Your paranoid android. === WVISTAX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W2K8SE (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W7PROX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === TEST64_W7SP1 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === WVISTAX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 0000000000000000 === W7PROX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000 === TEST64_W7SP1 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000

1 0

Making SetThreadPriorityBoost claim success
by Dan Kegel May 27, 2013

May 27, 2013

http://bugs.winehq.org/show_bug.cgi?id=22280 just got another dup. How awful would it be to make SetThreadPriorityBoost just return success, as in the patch attached to http://bugs.winehq.org/show_bug.cgi?id=22280#c1 http://bugs.winehq.org/attachment.cgi?id=27224&action=diff&context=patch&co… ? We'd have to mark one more test TODO_WINE. Related if catty discussion: http://www.codinghorror.com/blog/2006/08/thread-priorities-are-evil.html

2 1

Re: [PATCH 4/5] d3drm: Avoid LPDIRECT3DRMTEXTURE.
by Christian Costa May 27, 2013

May 27, 2013

Le 27/05/2013 09:22, Henri Verbeet a écrit : > --- > dlls/d3drm/d3drm.c | 20 ++++++++------------ > dlls/d3drm/frame.c | 22 +++++++--------------- > dlls/d3drm/meshbuilder.c | 14 +++++++------- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > include/d3drm.h | 4 ++-- > include/d3drmobj.h | 26 +++++++++++++------------- > 6 files changed, 45 insertions(+), 57 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 8dfa4bb..fe728a8 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -317,24 +317,20 @@ static HRESULT WINAPI IDirect3DRMImpl_CreateUserVisual(IDirect3DRM* iface, D3DRM > return E_NOTIMPL; > } > > -static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM* iface, const char* filename, > - LPDIRECT3DRMTEXTURE* Texture) > +static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM *iface, > + const char *filename, IDirect3DRMTexture **texture) > { > - IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); > - > - FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture); > + FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > > Do you really need to change the way traces are displayed?

2 6

Re: jscript: Added RegExp.toString() implementation.
by Marvin May 27, 2013

May 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25722 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: riched20: Added tests for ITextDocument::Open
by Alexandre Julliard May 27, 2013

May 27, 2013

Jactry Zeng <jactry92(a)gmail.com> writes: > diff --git a/dlls/riched20/tests/test.txt b/dlls/riched20/tests/test.txt > new file mode 100644 > index 0000000..e69de29 If you need an external file you have to create a temp file in the test. You can't rely on running from inside the source tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Spam again ...
by Joerg Schiermeier May 26, 2013

May 26, 2013

Hi maintainer, ---<cite>--- Message: 1 Date: Sun, 26 May 2013 01:07:06 +0000 (UTC) From: xerox_xerox2000(a)yahoo.co.uk To: <wine-devel(a)winehq.org>, <vidar268(a)yahoo.com>, <vladdy(a)utchat.com> Subject: RE: Message-ID: <823277.37895.bm(a)smtp104.mail.ir2.yahoo.com> Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06 ---</cite>--- UCE/Spam again in this list ...! Please remove this user. Thanks a lot. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

d3dx9: Avoid useless computations in D3DXMatrixTransformation2D
by Nozomi Kodama May 26, 2013

May 26, 2013

Hello What happens for this patch? Nozomi

1 1

Re: [PATCH] wininet: do avoid overwriting the buffer (Coverity)
by Marvin May 26, 2013

May 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25714 Your paranoid android. === WXPX64 (32 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA === WXPX64 (64 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0