May 2013 - Wine-Devel - list.winehq.org

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture
by Marvin May 8, 2013

May 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25486 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3dx9_36: Fix typo in ID3DXFileDataImpl_GetName.
by Dmitry Timoshkov May 8, 2013

May 8, 2013

Christian Costa <titan.costa(a)gmail.com> wrote: > - if (!name || !size) > + if (!name && !size) > return E_POINTER; > > dxfile_size = *size; So, what happens if name is not NULL, but size is? -- Dmitry.

2 1

Ask for mentor - Improve Bcrypt
by Kaiyi Zhang May 8, 2013

May 8, 2013

Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of GSOC. However, There are some exams which takes a lot of time, So lack of communication with the wine developers. I know it is late to apply for GSoC, however, I'm still interesting to the cryptography work in Wine even if I'm not accept as an official GSoC2013 student. Cryptography work is difficult, and Wine is difficult, so cryptography in Wine is double difficult for a beginner like me, could I ask for a mentor for the cryptography work even if my proposal is not accepted? To my dear kindly future mentor: I don't know how to thank you, but I'll work hard on contributing to the Wine project as more as I can. Sincerely appreciate. My idea is bcrypt improvement, I think it's very suitable for me, I learned the information security. Cryptography is one of my courses. I once development a Elliptic curve cryptography Demonstration system which makes the ECC Graphical. And i found there is blank in bcrypt, I want to do some improvement in this. I know there it's difficult for me to develop. but i can code some test code firstly. I read the dlls/rsaendh/tests/rsaenh.c: test_hashes(),test_des(),test_rsa() etc. and test the code on ubuntu successfully. Here is my plan: Week 1 - Week 2 - Get the Winedebug and document more adept - Get more information about bcrypt - Bcrypt Wiki: http://en.wikipedia.org/wiki/Bcrypt - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - File of Bcrypt: http://bcrypt.sourceforge.net/ - Read the Document of MSDN about Bcrypt and code some examples - MSDN about Bcrypt: http://msdn.microsoft.com/en-us/library/windows/desktop/aa833130(v=vs.85).a… Week 3 - Week 5 -Read some wine tests code and run some tests like: - the basic encryption dll/crypt32/ - Understand the bcrypt algorithm, there is a lot of code for learning like: - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - https://github.com/rg3/bcrypt - https://code.google.com/p/py-bcrypt/source/browse/bcrypt/bcrypt.c Week 6 - Week 11 - Code the BCrypt. According to the MSDN The Steps of Bcrypt - Open the Algorithm Provider - Get or Set Algorithm Properties - Create or Import a key - Perform Cryptiographic Operations - Close the Algorithm Provider There is a cross platform Bcrypt at http://bcrypt.sourceforge.net. if it is possible we can use it and its license compatible with the wine lgpl license. - add stub functions for Tests functions() and code the Tests functions(). The dlls/rsaenh/tests/rsaenh.c is a good reference. encrypt the pdData and compare with the right value. stub BCryptCreateHash() BCryptHashData() BCryptDuplicateHash() BCryptDuplicateHash BCryptDestroyHash() for test_hashes(). stub BCryptGenerateSymmetricKey() BCryptKeyDerivation() BCryptDestroyKey() for test_key_derivation(). stub BCryptGenRandom() for test_gen_random(). Week 12 - End - There are also some more cryptions need to tests, I can do more improvement these Thank you.

1 0

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)
by Alexandre Julliard May 8, 2013

May 8, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > { > - FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), debugstr_w(lpCaption), > - uType, wLanguageId, f); > - return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); > + FIXME("(%p, %s, %s, %u, 0x%08x, 0x%08x): semi-stub\n", hWnd, debugstr_w(lpText), > + debugstr_w(lpCaption), uType, wLanguageId, f); > + return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); That sort of thing is not useful. If you are changing the function for other reasons you can update the trace, but otherwise it's just adding noise in the change history. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: gdi32: Simplify font->aveWidth sanity-checking to fix possible division by zero. (try 2)
by Christian Costa May 8, 2013

May 8, 2013

Le 08/05/2013 11:45, Sam Edwards a écrit : > After feedback from Dmitry (thanks!), I redid this patch with the > following changes: > > * I misunderstood before what the test did; I initially thought this > was just a workaround to get aveWidth to behave, but as it turns out, > Windows has the same "maximum ratio of 100" limit. I changed the > comment to reflect that; hopefully this stops someone else from making > my mistake. :) > * Negative aveWidth checking is removed. I agree that there should be > a test to put this in, but Windows treats negative aveWidths as > invalid (according to Aric), so it can't be tested on Windows. That's > a much bigger mess than a simple "fix divide by zero" patch is worth. > * The division is done differently, to avoid potential overflow > problems. The result of the comparison is still exactly the same as > before the patch, except zero values are now handled gracefully. > > This supersedes 96111 (which, I forgot to mention before, supersedes > 96053 and 96047). > > Best, > Sam > + if (font->aveWidth && + (font->aveWidth - 1) / 100 >= font->potm->otmTextMetrics.tmHeight) { - if ((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / font->potm->otmTextMetrics.tmHeight > 100) - { Hi Sam, The test in the if is not that long. Shouldn't this fit into a single like as the previous test? Christian

1 0

Re: [2/2] comdlg32: Add a test for nCopies/dmCopies returned by PrintDlg.
by Marvin May 8, 2013

May 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25483 Your paranoid android. === WVISTAX64 (32 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W2K8SE (32 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W7PROX64 (32 bit printdlg) === Timeout === TEST64_W7SP1 (32 bit printdlg) === Timeout === WVISTAX64 (64 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W7PROX64 (64 bit printdlg) === Timeout === TEST64_W7SP1 (64 bit printdlg) === Timeout

1 0

Re: [PATCH] mscms: Use lcms2, when available
by Hans Leidekker May 8, 2013

May 8, 2013

On Tue, 2013-05-07 at 22:45 +0200, Detlef Riekenberg wrote: > lcms2 was released on 8. May 2010 and should be present in important > distributions since a while. > > lcms v1 is on the way to be phased out in the newest distribution > versions. Are there any distributions that have released without v1?

1 0

Re: [1/5] kernel32: Add more remote process tests.
by Marvin May 8, 2013

May 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25479 Your paranoid android. === TEST64_W7SP1 (32 bit loader) === loader.c:1210: Test failed: expected thread exit code 195, got 259 loader.c:1210: Test failed: expected thread exit code 195, got 259 loader.c:1220: Test failed: expected WAIT_ABANDONED, got 0x102 loader.c:1236: Test failed: expected WAIT_OBJECT_0, got 0x102 loader.c:1238: Test failed: expected WAIT_OBJECT_0, got 0x102

2 1

Re: gdi32: Simplify font->aveWidth sanity-checking to remove possible division by zero.
by Dmitry Timoshkov May 7, 2013

May 7, 2013

Sam Edwards <cfsworks(a)gmail.com> wrote: > It makes the most sense to get rid of this sanity check altogether, but > until then, this should be a more robust way of doing it. > + * TODO: This sounds like a workaround for a much deeper bug involving > + * aveWidth's calculation. We should investigate if/why this is needed. > + */ This comment is confusing and wrong. There is a test case for which this check is required. > + if (font->aveWidth < 0 || font->aveWidth > font->potm->otmTextMetrics.tmHeight * 100) A check for an overflow is probably needed. Also a check for negative aveWidth should be a separate patch at best, and needs a test case. -- Dmitry.

1 0

Re: [PATCH 1/8] ole32: Use MSHLFLAGS_TABLEWEAK marshaling in CoRegisterClassObject.
by Alexandre Julliard May 7, 2013

May 7, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/ole32/compobj.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wscript.exe -T ../../.. -p wscript.exe_test.exe.so run.c && touch run.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x555a9468 (thread 0088), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x555a9468). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555a9468 ESP:0033f7d0 EBP:0033f868 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:555d2cac ECX:0033f810 EDX:00000001 ESI:00000000 EDI:0033f828 Stack dump: 0x0033f7d0: 0033f828 00000005 00000000 555c7f30 0x0033f7e0: 0033f814 001407a4 0000000c 0013c414 0x0033f7f0: 0000000c 00000000 00000000 00000000 0x0033f800: 00142020 00000000 00000000 001373b0 0x0033f810: ffffffff 00000000 0033f868 7b85382e 0x0033f820: 00000000 00000001 178fc166 4e24f585 Backtrace: =>0 0x555a9468 Global_CreateObject+0x178() in vbscript (0x0033f868) 1 0x555b6b3c DispatchEx_InvokeEx+0x65b(iface=<couldn't compute location>, id=<couldn't compute location>, lcid=<couldn't compute location>, wFlags=<couldn't compute location>, pdp=<couldn't compute location>, pvarRes=<couldn't compute location>, pei=<couldn't compute location>, pspCaller=<couldn't compute location>) [/home/julliard/wine/wine/dlls/vbscript/vbdisp.c:215] in vbscript (0x0033f958) 2 0x555b899d disp_call+0x9c(ctx=0x1373b0, disp=0x13f368, id=0xaf, dp=0x33fa40, retv=0x33fa80) [/home/julliard/wine/wine/dlls/vbscript/../../include/dispex.h:299] in vbscript (0x0033f9e8) 3 0x555af05c do_icall+0x20b(ctx=<is not available>, res=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:511] in vbscript (0x0033fa68) 4 0x555af1dd interp_icall+0x2c(ctx=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:558] in vbscript (0x0033fa98) 5 0x555aeb42 exec_script+0x191(ctx=<is not available>, func=<is not available>, this_obj=<is not available>, dp=<is not available>, res=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:1918] in vbscript (0x0033fb58) 6 0x555be4a7 exec_global_code+0x46(ctx=0x1373b0, code=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/vbscript.c:83] in vbscript (0x0033fb88) 7 0x555bedab VBScript_SetScriptState+0x17a() in vbscript (0x0033fbe8) 8 0x684fc3dd wWinMain+0x9bc(hInst=<couldn't compute location>, hPrevInst=<couldn't compute location>, cmdline=<couldn't compute location>, cmdshow=<couldn't compute location>) [/home/julliard/wine/wine/programs/wscript/../../include/activscp.h:1013] in wscript (0x0033fd88) 9 0x684fc671 wmain+0xb0(argc=0x5, argv=0x110380) [/home/julliard/wine/wine/dlls/winecrt0/exe_wmain.c:50] in wscript (0x0033fe18) 10 0x684fc5a5 __wine_spec_exe_wentry+0x84(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_wentry.c:36] in wscript (0x0033fe58) 11 0x7b86053c call_process_entry+0xb() in kernel32 (0x0033fe78) 12 0x7b86171b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0033feb8) 13 0x7bc7a800 call_thread_func_wrapper+0xb() in ntdll (0x0033fed8) 14 0x7bc7d70d call_thread_func+0x7c(entry=0x7b8616b0, arg=0x7ffdf000, frame=0x33ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2567] in ntdll (0x0033ffa8) 15 0x7bc7a7de call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 16 0x7bc5004e start_process+0x1d(kernel_start=0x7b8616b0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2691] in ntdll (0x0033ffe8) 17 0x6802947d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 18 0x6802953b wine_switch_to_stack+0x2a(func=0x7bc50030, arg=0x7b8616b0, stack=0x340000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffeb7758) 19 0x7bc55b27 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2747] in ntdll (0xffeb77c8) 20 0x7b867d00 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xffeb86d8) 21 0x7bc561f3 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2956] in ntdll (0xffeb8768) 22 0x680270c2 wine_init+0x2a1(argc=0x6, argv=0xffeb8cb4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xffeb87c8) 23 0x7bf00e7b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffeb8c08) 24 0x681cee46 __libc_start_main+0xe5() in libc.so.6 (0xffeb8c88) 0x555a9468 Global_CreateObject+0x178 in vbscript: movl 0x0(%eax),%edx -- Alexandre Julliard julliard(a)winehq.org

1 0