May 2013 - Wine-Devel - list.winehq.org

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

[PATCH v6 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky June 11, 2013

June 11, 2013

Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 +++++++------ fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 +++++-- fs/cifs/inode.c | 21 +++--- fs/cifs/link.c | 25 ++----- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 ++-- fs/fcntl.c | 5 +- fs/locks.c | 158 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 48 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++- fs/nfs/nfs4xdr.c | 21 +++++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 +++++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 ++++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 35 files changed, 443 insertions(+), 139 deletions(-) -- 1.8.1.5

4 13

Re: ole32: Add a basic OLE client/server test suite. Take 2.
by Dmitry Timoshkov June 5, 2013

June 5, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

2 7

Re: [1/2] DWrite: Implemented functions regarding text alignment. (try 3)
by Nikolay Sivov May 31, 2013

May 31, 2013

On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering <Cookiezzz97(a)gmx.de>wrote: > Implemented functions of text format and text layout regarding text > alignment. > > Try 3: Used proper enum value to set the enum variables. > > > > > + if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER && alignment!=DWRITE_TEXT_ALIGNMENT_LEADING && + alignment!=DWRITE_TEXT_ALIGNMENT_JUSTIFIED && alignment!=DWRITE_TEXT_ALIGNMENT_TRAILING) + return E_INVALIDARG; + This->format.text_align = alignment; This doesn't look great, you'll need a test that shows it really rejects meaningless values, and if it does it would be simpler to compare with greatest enum value.

1 0

Re: [PATCH] slc: Fix return type
by Christian Costa May 31, 2013

May 31, 2013

Le 29/05/2013 12:06, Detlef Riekenberg a écrit : > -- > By by ... Detlef > --- > dlls/slc/slc.c | 31 +++++++++++++++++++++++-------- > include/slpublic.h | 2 +- > 2 files changed, 24 insertions(+), 9 deletions(-) > > diff --git a/dlls/slc/slc.c b/dlls/slc/slc.c > index e7416f1..7fc9b93 100644 > --- a/dlls/slc/slc.c > +++ b/dlls/slc/slc.c > @@ -1,6 +1,7 @@ > /* > * > * Copyright 2008 Alistair Leslie-Hughes > + * Copyright 2010 Detlef Riekenberg > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -28,15 +29,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(slc); > > -DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue) > -{ > - FIXME("(%s) stub\n", debugstr_w(lpszValueName) ); > - > - return SL_E_RIGHT_NOT_GRANTED; > -} > - > /*********************************************************************** > - * DllMain (CLUSAPI.@) > + * DllMain (slc.@) > * > */ > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > @@ -51,3 +45,24 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > } > return TRUE; > } > + > +/*********************************************************************** > + * SLGetWindowsInformationDWORD (slc.@) > + * > + * check the license and return the value for the given name > + * > + * PARAMS > + * name [i] application related value name to check > + * pvalue [o] ptr, where the value for the given name should be saved > + * > + * RETURNS > + * Success: S_OK > + * Failure: A HRESULT error code > + * > + */ > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue) > +{ > + FIXME("(%s, %p) stub\n", debugstr_w(name), pvalue); > + > + return SL_E_RIGHT_NOT_GRANTED; > +} > diff --git a/include/slpublic.h b/include/slpublic.h > index a2c6d42..5553787 100644 > --- a/include/slpublic.h > +++ b/include/slpublic.h > @@ -29,7 +29,7 @@ extern "C" { > #define SLCAPI DECLSPEC_IMPORT > #endif > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue); > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *); > > > #ifdef __cplusplus I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :)

2 2

Re: [PATCH] winmm/tests: Fix test that fails on NT4
by Marvin May 31, 2013

May 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25788 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [1/2] explorer: Initial implementation of desktop launchers.
by Qian Hong May 31, 2013

May 31, 2013

Hello Hans, On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > + hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get user desktop folder\n"); > + return; > + } > + hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get public desktop folder\n"); > + CoTaskMemFree( desktop_folder ); > + return; > + } Does KF_FLAG_CREATE look better here? Other wise every time a new wineprefix created there is an err output. Maybe I'm missing something here, thanks for your work. -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: [PATCH 2/4] d3dxof: Move list type and list nb elements into the parse context.
by Alexandre Julliard May 30, 2013

May 30, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3dxof/d3dxof_private.h | 2 ++ > dlls/d3dxof/parsing.c | 23 ++++++++++------------- > 2 files changed, 12 insertions(+), 13 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so mesh.c && touch mesh.ok mesh.c:2291: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2299: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2323: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2347: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2399: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2403: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2407: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2408: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2409: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2495: Tests skipped: D3DXCreateBox failed make: *** [mesh.ok] Error 9 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] advpack: Handle quoted arguments to rundll exports.
by Alexandre Julliard May 30, 2013

May 30, 2013

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -205,13 +205,24 @@ static HRESULT run_setup_commands_callback(HINF hinf, PCWSTR field, const void * > > /* sequentially returns pointers to parameters in a parameter list > * returns NULL if the parameter is empty, e.g. one,,three */ > -LPWSTR get_parameter(LPWSTR *params, WCHAR separator) > +LPWSTR get_parameter(LPWSTR *params, WCHAR separator, int quoted) Using proper boolean type and constants would be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] DWrite: Implemented functions regarding text alignment. (try 2)
by Alexandre Julliard May 30, 2013

May 30, 2013

Fabian Müntefering <Cookiezzz97(a)gmx.de> writes: > @@ -1023,6 +1034,9 @@ HRESULT create_textformat(const WCHAR *family_name, IDWriteFontCollection *colle > This->format.size = size; > This->format.stretch = stretch; > > + /*Default values.*/ > + This->format.text_align = 0; Please use proper enum values when setting enum variables. -- Alexandre Julliard julliard(a)winehq.org

2 1