June 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 26, 2013

Oct. 26, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Bug 24018 which appears to be a showstopper for running Cygwin on Wine
by Alan W. Irwin July 5, 2013

July 5, 2013

Andrey Turkin has stated at http://bugs.winehq.org/show_bug.cgi?id=24018 that this is really a Cygwin bug. I frankly don't understand the technical details but his current test (an infinite loop with Cygwin fork calls) may need some beefing up to convince the Cygwin developers they have introduced a regression. The reason why I mention a Cygwin regression is the winetricks script mentions bug 24018 and works around it by downloading an old version of the Cygwin installer. I haven't tried that myself yet, but if that workaround still works, then this is evidence that the issue is a Cygwin regression which is an important consideration when reporting this issue to the Cygwin developers. Andrey Turkin was asked at http://bugs.winehq.org/show_bug.cgi?id=24018 to report the issue to Cygwin, but my search of the Cygwin mailing list archive didn't find any post from him and only found one extremely casual (an aside to a completely different thread) mention (http://sourceware.org/ml/cygwin/2013-06/msg00471.html) from a different wine developer of bug 24018 with no response to that mention. I currently have no experience with Cygwin and my only real interest in Cygwin on Wine is it theoretically provides an alternative build platform to my present successful work with the combination of MinGW, MSYS, and Wine as a Windows build platform. But I haven't even been able to get started with Cygwin on Wine because of this showstopping bug. Therefore, I am mentioning the situation here in the hope that some wine developer on this list with some knowledge of Cygwin will take the responsibility of making a proper bug report to the Cygwin mailing list (which according to http://cygwin.com/problems.html is the correct place to report Cygwin bugs) including the evidence that the issue is a Cygwin regression (assuming investigation of older Cygwin versions with Turkin's test supports that conclusion). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

7 26

Re: Wine release 1.6-rc4
by Neumann, A. D. July 2, 2013

July 2, 2013

Hello, I changed my email address. Please send this information to: info.adneumann(a)t-online.de Thank you! D. Neumann Am 28.06.2013 22:02, schrieb Alexandre Julliard: > The Wine development release 1.6-rc4 is now available. > > What's new in this release (see below for details): > - Bug fixes only, we are in code freeze. > > The source is available from the following locations: > > http://prdownloads.sourceforge.net/wine/wine-1.6-rc4.tar.bz2 > http://mirrors.ibiblio.org/wine/source/1.6/wine-1.6-rc4.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/download > > You will find documentation on http://www.winehq.org/documentation > > You can also get the current source directly from the git > repository. Check http://www.winehq.org/git for details. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > ---------------------------------------------------------------- > > Bugs fixed in 1.6-rc4 (total 38): > > 7597 No sound with OSS driver in C&C3 > 11224 Throw In (Blitz Basic game) has a memory access violation > 11675 Flatout 2 demo, Battlefield 2 demo, many others need native d3dx9_36.D3DXCreateEffect* > 12771 Multiple graphic problems in "The Witcher" > 13314 Winevdm displays a window when running Civilization I > 13662 dogfood: xchat-2.6.2 is very slow, while updating the window > 14318 Michisoft Reader Studio v1.5a fails to produce LIT file from HTML > 16325 incorrect font rendering for CJK programs > 16784 Babylon 7: Trial mode expires after installation > 18930 IDA Pro: Failing to allocate an enormous image > 20769 crash when exiting Microsoft Flight Simulator 98 > 20771 the menu bar doesn't work in M. Flight Simulator 98 > 21103 Presentation 14.2 (Neurobehavioral Systems): crashes when displaying video output > 21827 Photoshop 7, Slider disapear > 22291 DC++ hangs on exit > 23504 Subpixel Font rendering wrong for font MS Sans Serif > 23687 err:seh:setup_exception_record stack overflow when start Proteus7 Ares > 23945 Textures are not properly rendered in Deus-Ex:Invisible War > 24230 "Psalmen - Lieder des Lebens" crashes when clicking Next in settings pane > 24796 DIY Kyoto's Holmes fails to start > 25125 Can only print to the default CUPS printer from Visio 5 Professional > 25605 The Settlers 3: Save as bitmap crashes world editor > 26646 Worms Reloaded: sound choppy without hardware sound = emulation > 27658 3dvia plugin installer crashes > 28495 Runes of Magic: sometimes mouse cursor freezes > 29897 Lord Of the Rings Online Slow/Freezes > 29959 Zed: 3D Preview window is blank or doesn't open. > 30578 Disassembly not in fixed-width font in IDA Pro 6.2 demo > 30897 Europa Universalis III demo crashes while 'Loading Map-Sprites...' without native d3dxof > 31729 cl.exe: stack overflow with certain long command lines > 31772 NtQuerySystemInformation doesn't fill ReturnLength properly with SystemProcessInformation > 31812 Silverlight 4.x/5.x windows have repainting problems > 31908 Garena Blackshot does login > 32820 Offline rekening overzicht, orov doesn't work > 33283 Configuration of WM_NAME is delayed for virtual desktop > 33753 Titan Quest : Multiplayer not working > 33865 Regression in a specialized program > 33883 Scirra httpapi.dll error trying to Run a game > > ---------------------------------------------------------------- > > Changes since 1.6-rc3: > > Alexandre Julliard (22): > gdi32: Cache the font smoothing parameters. > kernel32: FormatMessage precision arguments are integers. > comdlg32: Add support for the CF_NOVERTFONTS flag. > clock: Don't offer vertical fonts in the font dialog. > notepad: Don't offer vertical fonts in the font dialog. > winecfg: Don't offer vertical fonts in the font dialog. > wineconsole: Don't offer vertical fonts in the font dialog. > winefile: Don't offer vertical fonts in the font dialog. > wordpad: Don't offer vertical fonts in the font dialog. > make_unicode: Move codepage file output code to a common routine and make default characters configurable. > libwine: Add support for codepage 10001 (Mac Japanese). > libwine: Add support for codepage 10002 (Mac Traditional Chinese). > libwine: Add support for codepage 10003 (Mac Korean). > libwine: Add support for codepage 10008 (Mac Simplified Chinese). > libwine: Add support for codepage 10010 (Mac Romanian). > libwine: Add support for codepage 10017 (Mac Ukrainian). > libwine: Add support for codepage 10021 (Mac Thai). > libwine: Add support for codepage 10082 (Mac Croatian). > krnl386: Create a new console for DOS binaries. > winevdm: Make it a GUI application to avoid a spurious console. > user32: Fetch the window menu again after sending initialization messages. > advapi32: Fix ReportEvent parameter types in the spec file. > > Andrew Eikum (4): > winbase.h: Add GetFileInformationByHandleEx. > oleaut32: Register the typelib's path without WOW64 redirection. > oleaut32: Load referenced typelibs in the same architecture. > oleaut32: Use typelib's pointer size, not system's. > > André Hentschel (15): > oleaut32/tests: Get rid of IS_ANCIENT in vartest. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in vartest. > oleaut32/tests: Don't use autoheader styled define in vartest. > oleaut32/tests: Get rid of IS_ANCIENT in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_DECIMAL in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_CY in vartype. > oleaut32/tests: Don't use autoheader styled defines in vartype. > oleaut32/tests: Don't use autoheader styled defines in varformat. > oleaut32/tests: Get rid of IS_ANCIENT in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_DECIMAL in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_R8 in safearray. > oleaut32/tests: Don't use autoheader styled defines in safearray. > oleaut32/tests: Use BOOL instead of int when appropriate. > > Austin English (1): > winex11.drv: Print the architecture when showing driver problems. > > Bruno Jesus (2): > po: Update Brazilian Portuguese translation. > po: Update Brazilian Portuguese translation. > > Caibin Chen (1): > po: Update Simplified Chinese Translation. > > Christian Costa (1): > d3dxof: Add support for case sensitive legacy type indexColor. > > Dmitry Timoshkov (4): > kernel32/tests: Add a test for VirtualAlloc called on a mapped PE section. > kernel32/tests: Add more VirtualAlloc and VirtualProtect tests. > kernel32: Correct HeapFree .spec parameter type. > ntdll: Correct RtlFreeHeap .spec parameter type. > > Erich Hoover (1): > ws2_32: Fix interface-bound filter to accept locally generated targeted packets. > > Frédéric Delanoy (1): > tools: Update winemaker manpage French translation. > > Hans Leidekker (3): > ws2_32/tests: Avoid races. > dssenh/tests: Fix test failures on 64-bit Vista. > winhttp/tests: Add some tests for WinHttpDetectAutoProxyConfigUrl. > > Huw Davies (1): > comdlg32: Don't call the callback if it's not set. > > Jacek Caban (5): > ole32: Don't call AddConnection for weak references. > ole32/tests: Added tests for external connections stored in ROT. > oleaut32/tests: Added external connections tests for MSHLFLAGS_TABLEWEAK marshaling. > mshtml: Don't declare empty interface for nsCycleCollectionISupports. > secur32: Don't use deprecated gnutls_certificate_credentials. > > Julian Rüger (1): > server: Update German translation of manpage. > > Ken Thomases (2): > winemac: Dispatch key events directly to window to be sure to get key-up events. > winemac: Fix ordering of windows owned by same owner when on inactive desktop space. > > Marcus Meissner (8): > dbghelp: Free root in error case (Coverity). > dbghelp: Free srcpath in stabs handling (Coverity). > gdi32: Close handle in error path (Coverity). > gdi32: Close handle in mfdrv (Coverity). > msvf32: Fixed incorrect sizeof (Coverity). > ole32: LeaveCriticalSection in one exit case (Coverity). > ole32: Fixed bad sizeof()s in composite moniker (Coverity). > winmm: Fix incorrect parameter for test debug (Coverity). > > Matteo Bruni (2): > wined3d: Fix handling of cnd instruction with coissue flag. > d3d9/tests: Improve cnd instruction test. > > Michael Stefaniuc (1): > po: Update the Romanian translation. > > Mykola Zadorozhnyy (1): > po: Update Ukrainian translation. > > Petr Kočandrle (1): > po: Fix some Czech spelling errors. > > Piotr Caban (1): > msvcrt: Added _wcsicmp_l implementation. > > Qian Hong (2): > msctf: Added stub TF_CreateLangBarItemMgr. > include: Added missing declaration for some msctf APIs. > > Roger Koot (1): > po: Updated Dutch translation. > > Stefan Leichter (1): > msvcp100/tests: Fix dynamically loaded functions for platform arm. > > Volkan Gezer (1): > po: Updated Turkish Translation. > > -- > Alexandre Julliard > julliard(a)winehq.org >

2 1

Duplicate UUID in oleaut32:tmarshal test
by Thomas Faber July 2, 2013

July 2, 2013

I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it complained: tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [ Interface 'ITestSecondDisp' ] This doesn't seem like it's intentional. But just giving ITestSecondDisp a new uuid causes the following test failures on Windows: tmarshal.c:1861: Test failed: external_connections = 2 tmarshal.c:1864: Test failed: external_connections = 2 tmarshal.c:192: Test failed: fLastReleaseCloses = 1 I could try to figure this out, but it's probably better if someone familiar with the subject could have a look instead. (also, assuming this is a bug in the test, we might want to add that check to widl, it seems pretty useful ;]) Thanks, Thomas

2 1

Re: [patch] full translation update for 16 rc4
by Frédéric Delanoy July 2, 2013

July 2, 2013

On Sun, Jun 30, 2013 at 6:08 AM, 中川祥 <matyapiro31(a)gmail.com> wrote: > Hi, please resubmit this patch with your full name transliterated in English.

2 1

Re: widl: Do not generate C structure for empty interfaces. (try 2)
by Jacek Caban July 2, 2013

July 2, 2013

Hi Thomas, I tested what midl does in this case and I think the solution should be different. When I tried to compile an empty interface, I got an error saying that '[object] interface must derive from another [object] interface'. That requirement is mostly enough to avoid empty vtbl. I was wondering how IUnknown is handled by midl (since it doesn't derive from any other iface). It seems like it's a simple name-based special case. When I renamed the interface to IUnknown, it compiled fine and generated vtbl the same as current widl (that is an empty struct). That said, if such interfaces are just obscure special case, I would say we shouldn't care. We may easily avoid them (I just sent a patch avoiding it in mshtml). If you want a better solution to avoid such problems in the future, I would suggest adding an error, like midl does. This will, however, require some more changes in Wine. At least MSHTML already has an interface identical to IUnknown (nsISupports), which would cause the error. This should be solvable with some tricks. Thanks, Jacek

2 2

Re: winex11.drv: When skipping unknown attribute also skip it's value.
by Michael Stefaniuc June 30, 2013

June 30, 2013

On 06/30/2013 11:29 PM, Ričardas Barkauskas wrote: > --- > dlls/winex11.drv/opengl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > 0001-winex11.drv-When-skipping-unknown-attribute-also-skip-.txt > > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > index 0f937cb..c7f78c5 100644 > --- a/dlls/winex11.drv/opengl.c > +++ b/dlls/winex11.drv/opengl.c > @@ -921,7 +921,7 @@ static int ConvertAttribWGLtoGLX(const int* iWGLAttr, int* oGLXAttr, struct wgl_ > TRACE("pAttr[%d] = GLX_RGBA_UNSIGNED_FLOAT_TYPE_EXT: %x\n", cur, pop); > break ; > default: > - FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur]); > + FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur++]); Side effects in the debug output functions should be avoided. > break; > } > ++cur; > bye michael

1 0

Re: [patch]update po/ja.po for wine ver.1.6-rc4
by Akihiro Sagawa June 30, 2013

June 30, 2013

Hi Akira, Thank you for your contribution. Regarding Japanese translation, please consider following things. Firstly, those untranslated terms cannot be fully translated into Japanese. This is the reason why I didn't translate 100% message. In po file, please keep untranslated if we don't need to translate the message. Secondly, I don't translate the message before nearly 100% sure about message context. We should learn the conetext and test how the message is shown in the application. In my opinion, untranslated English terms are easy to search web pages. This helps a user who don't familiar to technical words. If we translate to ill-defined message, a user cannot help himself/herself with search engines. Thirdly, these untranslated messages are not so important for average applications... Did you notice these untranslated messages on some applications? Anyway, I continue to commented on this. On Sun, 30 Jun 2013 22:03:21 +0900, Akira Nakagawa wrote: > #: crypt32.rc:83 > msgid "Serialized Signature Serial Number" > -msgstr "" > +msgstr "整序された署名の順番" This translated message doesn't mean "Serial Number". > #: crypt32.rc:84 > msgid "Principal Name" > -msgstr "" > +msgstr "主要名称" "主要名称" looks like Chinese term. Not used in Japan at all. How about プリンシパル名? > #: crypt32.rc:94 > msgid "Policy Mappings" > -msgstr "" > +msgstr "ポリシーの表示" Mappings doesn't mean 表示 (=display?). > #: crypt32.rc:96 > msgid "Cross-Certificate Distribution Points" > -msgstr "" > +msgstr "複数の署名の配布ポイント" Cross-Certificate doesn't mean 複数の署名 (=multiple signatures?). > #: crypt32.rc:98 > msgid "Application Policy Mappings" > -msgstr "" > +msgstr "アプリケーションのポリシーの表示" Mappings doesn't mean 表示. (ditto) Please avoid ～の～の～ form. > #: crypt32.rc:99 > msgid "Application Policy Constraints" > -msgstr "" > +msgstr "アプリケーションのポリシーの制約" ditto. > #: crypt32.rc:107 > msgid "PKCS 7 Signed" > -msgstr "" > +msgstr "署名付きのPKCS 7" PKCS #7 is Cryptographic Message Syntax Standard and updated in RFC 5652. RFC 5652 defines six content types: data, signed-data, enveloped-data, digested-data, encrypted-data, and authenticated-data. So, "PKCS 7 Signed" means the second data type. > #: crypt32.rc:108 > msgid "PKCS 7 Enveloped" > -msgstr "" > +msgstr "保護されたPKCS 7" ditto. PKCS 7 is not enveloped. The data is enveloped by PKCS 7. > #: crypt32.rc:109 > msgid "PKCS 7 Signed Enveloped" > -msgstr "" > +msgstr "保護された署名付きのPKCS 7" ditto. > #: crypt32.rc:110 > msgid "PKCS 7 Digested" > -msgstr "" > +msgstr "ダイジェストのPKCS 7" ditto. > #: crypt32.rc:111 > msgid "PKCS 7 Encrypted" > -msgstr "" > +msgstr "暗号化されたPKCS 7" ditto. > #: crypt32.rc:112 > msgid "Previous CA Certificate Hash" > -msgstr "" > +msgstr "以前のCA 署名のハッシュ" Certificate doesn't mean "署名" (signature). A space character is needed before "CA". > #: crypt32.rc:113 > msgid "Virtual Base CRL Number" > -msgstr "" > +msgstr "仮想CRLナンバー" This message doesn't contain "Base" term. A space character is needed both sides of "CRL". > #: crypt32.rc:114 > msgid "Next CRL Publish" > -msgstr "" > +msgstr "次のCRL 公開" A space character is needed before "CRL". > #: crypt32.rc:119 > msgid "Dummy Signer" > -msgstr "" > +msgstr "ダミーの署名" Signer is a person or an authority. Please don't confuse signer with sign. > #: crypt32.rc:122 > msgid "Enforce Certificate Chain Policy" > -msgstr "" > +msgstr "証明書チェーンのポリシーを適用" Enforce is more powerful word. > #: crypt32.rc:193 > msgid "End Entity" > -msgstr "" > +msgstr "終了値" In this case "End" might not mean closure. This might mean "End user"'s end. > #: cryptdlg.rc:29 > msgid "Policy Qualifier Info" > -msgstr "" > +msgstr "ポリシーの修飾子情報" This message doesn't need space between words. > #: cryptui.rc:298 > msgid "Personal Information Exchange/PKCS #12 (*.pfx; *.p12)" > -msgstr "" > +msgstr "個人情報交換ファイル/PKCS #12 (*.pfx; *.p12)" "個人情報交換ファイル" isn't commonly used term. Where is the source of this term? I searched this term with google, only 9 pages are found. But "Personal Information Exchange" is used over 47,000 pages --- of course, I limited to Japanese pages. Thus I ask you to keep this term untranslated. > #: cryptui.rc:405 > msgid "&DER-encoded X.509 (*.cer)" > -msgstr "&DER符号化された X.509 (*.cer)" > +msgstr "DER符号化された X.509(&D) (*.cer)" I think this style is redundant. > #: cryptui.rc:407 > msgid "Ba&se64-encoded X.509 (*.cer):" > -msgstr "Ba&se64符号化された X.509 (*.cer):" > +msgstr "Base64で符号化された X.509(&S) (*.cer):" ditto. > #: cryptui.rc:409 > msgid "&Cryptographic Message Syntax Standard/PKCS #7 Message (*.p7b)" > -msgstr "&Cryptographic Message Syntax Standard/PKCS #7 メッセージ (*.p7b)" > +msgstr "暗号メッセージ構文/PKCS #7 メッセージ(&C) (*.p7b)" "Standard" term is omitted. > #: cryptui.rc:413 > msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" > -msgstr "" > +msgstr "個人情報交換ファイル(&P)/PKCS #12 (*.pfx)" "個人情報交換ファイル" is not common usage. (ditto) (&P) position doesn't match previous message. > #: cryptui.rc:75 > msgid "Personal Information Exchange (*.pfx; *.p12)" > -msgstr "" > +msgstr "個人情報交換ファイル (*.pfx; *.p12)" ditto. > #: cryptui.rc:94 > msgid "Personal Information Exchange" > -msgstr "" > +msgstr "個人情報変換ファイル" Why not use 交換 for Exchange as in previous message? This message use 変換 for Exchange term. > #: cryptui.rc:158 > msgid "Personal Information Exchange (*.pfx)" > -msgstr "" > +msgstr "個人情報変換ファイル (*.pfx)" ditto. ------------------- Following shell directory names are not translated in Windows Vista Japanese edition. Wine follows Vista's notation. We discussed about this two years ago [1]. [1] http://www.winehq.org/pipermail/wine-devel/2011-January/088390.html So, you don't need translate into Japanese for now. > #: shell32.rc:201 > msgid "My Documents" > -msgstr "" > +msgstr "マイドキュメント" > > #: shell32.rc:202 > msgid "Favorites" > -msgstr "" > +msgstr "お気に入り" > > #: shell32.rc:203 > msgid "StartUp" > -msgstr "" > +msgstr "スタートアップ" > > #: shell32.rc:204 > msgid "Start Menu" > -msgstr "" > +msgstr "スタートメニュー" > > #: shell32.rc:205 > msgid "My Music" > -msgstr "" > +msgstr "マイミュージック" > > #: shell32.rc:206 > msgid "My Videos" > -msgstr "" > +msgstr "マイビデオ" > > #: shell32.rc:207 > msgctxt "directory" > msgid "Desktop" > -msgstr "" > +msgstr "デスクトップ" > > #: shell32.rc:208 > msgid "NetHood" > -msgstr "" > +msgstr "ネットワーク内" > > #: shell32.rc:209 > msgid "Templates" > -msgstr "" > +msgstr "テンプレート" > > #: shell32.rc:210 > msgid "PrintHood" > -msgstr "" > +msgstr "プリンタ内" > > #: shell32.rc:211 winhlp32.rc:45 > msgid "History" > -msgstr "" > +msgstr "ヒストリ" > > #: shell32.rc:212 > msgid "Program Files" > @@ -7959,7 +7962,7 @@ msgstr "Program Files" > > #: shell32.rc:214 > msgid "My Pictures" > -msgstr "" > +msgstr "マイピクチャ" > > #: shell32.rc:215 > msgid "Common Files" > @@ -7967,23 +7970,23 @@ msgstr "Common Files" > > #: shell32.rc:216 shell32.rc:147 shell32.rc:232 > msgid "Documents" > -msgstr "" > +msgstr "ドキュメント" > > #: shell32.rc:217 > msgid "Administrative Tools" > -msgstr "" > +msgstr "管理者用ツール" > > #: shell32.rc:218 > msgid "Music" > -msgstr "" > +msgstr "ミュージック" > > #: shell32.rc:219 > msgid "Pictures" > -msgstr "" > +msgstr "ピクチャ" > > #: shell32.rc:220 > msgid "Videos" > -msgstr "" > +msgstr "ビデオ" > > #: shell32.rc:213 > msgid "Program Files (x86)" > @@ -7991,19 +7994,19 @@ msgstr "Program Files (x86)" > > #: shell32.rc:221 > msgid "Contacts" > -msgstr "" > +msgstr "連絡先" > > #: shell32.rc:222 winefile.rc:110 > msgid "Links" > -msgstr "" > +msgstr "リンク" > > #: shell32.rc:223 > msgid "Slide Shows" > -msgstr "" > +msgstr "スライドショー" > > #: shell32.rc:224 > msgid "Playlists" > -msgstr "" > +msgstr "プレイリスト" > > #: shell32.rc:148 taskmgr.rc:326 > msgid "Status" > @@ -8019,35 +8022,35 @@ msgstr "機種名" > > #: shell32.rc:225 > msgid "Sample Music" > -msgstr "" > +msgstr "サンプルミュージック" > > #: shell32.rc:226 > msgid "Sample Pictures" > -msgstr "" > +msgstr "サンプルピクチャ" > > #: shell32.rc:227 > msgid "Sample Playlists" > -msgstr "" > +msgstr "サンプルプレイリスト" > > #: shell32.rc:228 > msgid "Sample Videos" > -msgstr "" > +msgstr "サンプルビデオ" > > #: shell32.rc:229 > msgid "Saved Games" > -msgstr "" > +msgstr "保存済みのゲーム" > > #: shell32.rc:230 > msgid "Searches" > -msgstr "" > +msgstr "検索" > > #: shell32.rc:231 > msgid "Users" > -msgstr "" > +msgstr "ユーザー" > > #: shell32.rc:233 > msgid "Downloads" > -msgstr "" > +msgstr "ダウンロード" > ------------------- > #: netstat.rc:28 > msgid "Proto" > -msgstr "" > +msgstr "合意" Proto means protocol, but there is no enough space to display it. > #: oleview.rc:138 > msgid "Registry" > -msgstr "" > +msgstr "レジストリ" Oleview has a small issue. When I try this translation before, it can't display well if this message is Japanese. So, please verify that these messages are shown properly in the application. > #: oleview.rc:139 > msgid "Implementation" > -msgstr "" > +msgstr "実装" ditto. > #: oleview.rc:140 > msgid "Activation" > -msgstr "" > +msgstr "発動" ditto. > #: winefile.rc:109 > msgid "Index/Inode" > -msgstr "" > +msgstr "索引・Iノード" Although easily guess it, Iノード is not widely used. iノード might be preferred but more common term is "inode". inode (as Japanese technical term) is used in Wikipedia[1], Linux Japanese Manual (debugfs [2]), WDIC[3]. [1] http://ja.wikipedia.org/wiki/Inode [2] http://linuxjm.sourceforge.jp/html/e2fsprogs/man8/debugfs.8.html [3] http://www.wdic.org/w/TECH/inode Contact me for any questions. Regards, Akihiro Sagawa

1 0

Re: [PATCH] advapi32: RegDeleteKey tests
by Dmitry Timoshkov June 30, 2013

June 30, 2013

George Stephanos <gaf.stephanos(a)gmail.com> wrote: > + res = RegOpenKeyExA( hkey, "subkey1", 0, KEY_READ, &hkeysub1 ); > + ok(res != ERROR_SUCCESS, "test key found in user's classes: %d\n", res); ... > + res = RegOpenKeyExA( hklm, "subkey1", 0, KEY_READ, &hklmsub1 ); > + ok(res != ERROR_SUCCESS, "test key found in hklm: %d\n", res); Testing for res != ERROR_SUCCESS is not very useful, please check for a particular error code. Also please close successfully opened handles. -- Dmitry.

2 1

[website] Wine 1.6-rc4 freigegeben
by André Hentschel June 30, 2013

June 30, 2013

--- news/de/2013062801.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 news/de/2013062801.xml

1 0

Re: msxml3/tests: add additional conformance tests that show incorrect xpath behavior in wine
by Nikolay Sivov June 29, 2013

June 29, 2013

On 6/27/2013 11:46, John Chadwick wrote: > + /* msxml's selectNodes returns a document ordered nodelist, regardless of > + * whether or not the xpath nodelist was document ordered... */ > + ole_check(IXMLDOMNode_selectNodes(rootNode,_bstr_("ancestor-or-self::node()"), &list)); > + todo_expect_list_and_release(list, "D1 E2.D1"); Please use explicit check for return value, like ok(hr == S_OK, "...");, also you probably don't need another macro for list checking, isn't it enough to wrap expect_list_and_release() in todo_wine {} ?

1 0

Need help with a rsaenh bug
by Qian Hong June 28, 2013

June 28, 2013

Hello, I was investigating Bug 33898 [1] hardly and get a partial result, I have a special test case demonstrate the behavior of Aliwangwang [2], however, I failed to expand the special case to a common test case. My attempting is shown in [3]. The hack in [3] works for Aliwangwang, but the test case in [3] doesn't fully pass on Windows as I expected [4]. I'm not sure if there is an APP bug rather than Wine bug here, is it valid to call multiple CryptDecrypt with only one CryptDeriveKey called? If true, is it correct to assume the second CryptDecrypt call should behavior identical as the first one? If there is a Wine bug here, what is the right way to write a common test case for it? Any hints on this bug is great appreciated! Thanks very much! [1] http://bugs.winehq.org/show_bug.cgi?id=33898 [2] http://bugs.winehq.org/attachment.cgi?id=44996 [3] http://bugs.winehq.org/attachment.cgi?id=44997&action=diff [4] https://testbot.winehq.org/JobDetails.pl?Key=26138 -- Regards, Qian Hong - http://www.winehq.org

3 9

Re: ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file.
by Alexandre Julliard June 28, 2013

June 28, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 2770, hopefully it's still > acceptable during code freeze. Is there an application that's fixed by this? According to bug 2770, that app only crashes a little further on (which is of course an improvement, but not worth the risk during code freeze). -- Alexandre Julliard julliard(a)winehq.org

2 1

riched20: ITextDocument implementation
by Tiger Soldier June 28, 2013

June 28, 2013

As bug 17042 [1] reported, the IUnknown object returned by CreateTextServices() does not support ITextDocument. I believe that's the root cause of some apps crash. richole.c has a very limited implementation of ITextDocument for IRichEditOle, which is totally unreusable. I'm trying to implement ITextDocument for both ITextServices and IRichEditOle. ME_Editor type provides most of the editor functionalities, and both of ITextServices and IRichEditOle use it. So I'm going to use it to implement ITextDocument. The proposal is: struct tagReTxtDoc { IUnknown *parentObj; ME_Editor *editor; } ReTxtDoc; ReTxtDoc *CreateReTxtDoc(IUnknown *parentObj, ME_Editor *editor); void DestroyReTxtDoc(ReTxtDoc); ReTxtDoc_addRef/QueryInterface/Release -> delegate to parentObj Other ITextDocument methods: use ME_Editor to implement. This is my first time to develop WINE. Any comments/suggestions? [1] http://bugs.winehq.org/show_bug.cgi?id=17042

3 2

Re: widl: Do not generate C structure for empty interfaces.
by André Hentschel June 27, 2013

June 27, 2013

Hi, The whitespace changes are bad, please don't do that.

3 4

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin June 26, 2013

June 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin June 26, 2013

June 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.
by Henri Verbeet June 26, 2013

June 26, 2013

On 23 June 2013 21:57, Christian Costa <titan.costa(a)gmail.com> wrote: > When D3DTA_CONSTANT is use in a texture stage, the generated shader uses variables that are not defined making thus the compilation to fail. > This patch declare these variables with the value from the related texture stage state D3D_TSS_CONSTANT. > This fixes the text display in Spin Tires demo. This patch has several issues. Even without those, it should probably be deferred anyway.

4 11

Re: server: Update German translation of manpage.
by Alexandre Julliard June 26, 2013

June 26, 2013

Julian Rüger <jr98(a)gmx.net> writes: > I'm unsure about the second line. Is that supposed to be the "last > modified" date of the manpage, the wineserver or what? The English > version says October 2005. In general, it would be the last time there were changes to the program that required a manpage update. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Update Ukrainian translation
by Nikolay Sivov June 26, 2013

June 26, 2013

On 6/26/2013 13:10, Микола wrote: Hi, please resubmit this patch with your full name transliterated in English.

1 0

Re: wined3d: print the architecture when showing driver problems
by Henri Verbeet June 26, 2013

June 26, 2013

On 23 June 2013 07:10, Austin English <austinenglish(a)gmail.com> wrote: > Please consider applying before the release of 1.6. It has no > functional changes, but would really help when diagnosing user > problems. > This is not really a wined3d patch. That said, while I agree that printing the architecture would be useful here, you can probably avoid the #ifdef by using something along the lines of sizeof(void *) == 8 ? "64-bit" : "32-bit", although ideally we'd probably get the actual architecture from somewhere like ntdll.

2 2

Re: widl: Do not generate empty Vtbl structure for empty interfaces.
by Alexandre Julliard June 25, 2013

June 25, 2013

Thomas Faber <thfabba(a)gmx.de> writes: > An alternative solution would be not to generate a vtable structure at all, > and instead add a dummy member to the class directly. That would be in line > with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, > but require a slightly larger change to widl. I'm not sure it makes sense to even define a C structure at all, since there's nothing you can do with it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Czech language for Wine
by Alexandre Julliard June 25, 2013

June 25, 2013

Pavel VlÄek <paaajavlca(a)gmail.com> writes: > @@ -1415,19 +1400,19 @@ > > #: crypt32.rc:74 > msgid "Title" > -msgstr "Titul" > +msgstr "" > > #: crypt32.rc:75 > msgid "Given Name" > -msgstr "Jm©no" > +msgstr "" > > #: crypt32.rc:76 > msgid "Initials" > -msgstr "Inici¡ly" > +msgstr "" > > #: crypt32.rc:77 > msgid "Surname" > -msgstr "Pjmen" > +msgstr "" Why are you removing all these existing translations? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)
by Dmitry Timoshkov June 25, 2013

June 25, 2013

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/ole32/ifs.c > +++ b/dlls/ole32/ifs.c > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC iface,LPVOID pv,DWORD cb) { > IMallocSpy_Release(Malloc32.pSpy); > Malloc32.SpyReleasePending = FALSE; > Malloc32.pSpy = NULL; > + /* cb == 0 case will release it some lines below. */ > + if (cb) LeaveCriticalSection(&IMalloc32_SpyCS); > } > > if (0==cb) { Why not unconditionally release the lock before the '0==cb' check? -- Dmitry.

2 3

Re: d3dx9: Implement adjacency in D3DXCreateSphere
by Rico Schüller June 24, 2013

June 24, 2013

On 20.06.2013 21:25, Nozomi Kodama wrote: > + if (adjacency) > + { > + DWORD *buffer, size; > + ID3DXBuffer *temp; > + > + size = 3 * sphere->lpVtbl->GetNumFaces(sphere) * sizeof(DWORD); > + hr = D3DXCreateBuffer(size, &temp); > + if (hr != D3D_OK) > + return hr; > + > + buffer = (DWORD *)(ID3DXBuffer_GetBufferPointer(temp)); Are the outer parentheses needed? Is the cast needed? > + hr = sphere->lpVtbl->GenerateAdjacency(sphere, -0.000001f, buffer); > + if (hr != D3D_OK) > + return hr; This may leak the temp ID3DXBuffer in the error case. Cheers Rico

2 1

Re: msvcr90/tests: skip tests of function ?_name_internal_method if it is not present
by Marvin June 24, 2013

June 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26093 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: ws2_32: Fix interface-bound filter to accept locally generated targeted packets.
by Jonas Maebe June 24, 2013

June 24, 2013

On 24 Jun 2013, at 04:30, Erich E. Hoover wrote: > <0001-ws2_32-Fix-interface-bound-filter-to-accept-locally-.patch> The added "struct sock_filter ip_memaddr" field doesn't seem to be used. Jonas

2 1

Re: ol32: Make enumx implementation look more like a COM interface.
by Dmitry Timoshkov June 24, 2013

June 24, 2013

This patch should be quite obvious in its intent: it changes vtable type to IUnknown which helps to remove This* to IUnknown* casts in order to avoid obvious problems with vtable pointer placement inside of object implementation. Basically this is just a clean up patch. Is there anything else to clear the pending patch state? -- Dmitry.

2 5

Re: [PATCH]winhttp:session.c fix a bug(return value is null)
by Hans Leidekker June 24, 2013

June 24, 2013

On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote: > diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c > index 660eae5..dfe23d4 100644 > --- a/dlls/winhttp/session.c > +++ b/dlls/winhttp/session.c > @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD flags, LPWSTR *url ) > { > static int fixme_shown; > if (!fixme_shown++) FIXME("discovery via DHCP not supported\n"); > + flags = WINHTTP_AUTO_DETECT_TYPE_DNS_A; > + ret=TRUE; > } > if (flags & WINHTTP_AUTO_DETECT_TYPE_DNS_A) > { We shouldn't perform DNS detection if the app didn't ask for it. Do you have an app that fails because we return an error here?

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime.
by Hans Leidekker June 24, 2013

June 24, 2013

On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote: > +static WCHAR *get_localdatetime(void) > +{ > + static const WCHAR fmtW[] = > + {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u', > + '.','%','0','6','u','+','0','0','0',0}; > + SYSTEM_TIMEOFDAY_INFORMATION ti; > + TIME_FIELDS tf; > + WCHAR *ret; > + > + if (!(ret = heap_alloc( 26 * sizeof(WCHAR) ))) return NULL; > + > + NtQuerySystemInformation( SystemTimeOfDayInformation, &ti, sizeof(ti), NULL ); > + RtlTimeToTimeFields( &ti.liKeBootTime, &tf ); > + sprintfW( ret, fmtW, tf.Year, tf.Month, tf.Day, tf.Hour, tf.Minute, tf.Second, tf.Milliseconds * 1000 ); > + return ret; > +} This will not return local time.

1 0

Re: wbemprox: Implement some properties of Win32_BIOS. (resend 4)
by Hans Leidekker June 24, 2013

June 24, 2013

On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote: > static const struct column col_bios[] = > { > + { prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY}, > { prop_descriptionW, CIM_STRING }, > { prop_manufacturerW, CIM_STRING }, > { prop_releasedateW, CIM_DATETIME }, > @@ -508,6 +511,7 @@ struct record_baseboard > }; > struct record_bios > { > + const struct array *biosversion; > const WCHAR *description; > const WCHAR *manufacturer; > const WCHAR *releasedate; > @@ -695,9 +699,13 @@ static const struct record_baseboard data_baseboard[] = > { > { baseboard_manufacturerW, baseboard_serialnumberW, baseboard_tagW } > }; > +static const struct array data_bios_biosversion = > +{ > + 1, (void*)bios_versionW > +}; This can't work. BIOSVersion is of type CIM_STRING|CIM_FLAG_ARRAY, which translates to a pointer to an array of string pointers.

1 0

Re: po: Update Simplified Chinese translation (resend)
by Qian Hong June 24, 2013

June 24, 2013

Hi Caibin, Welcome to Wine! Thanks for the great work, patch looks perfect to me. It's a bit pity that Julliard just finishing today's patch committing several minutes ago, hopefully this patch would be committed next week, if we have rc4 :) Cheers. On Sat, Jun 22, 2013 at 12:36 AM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > - Used real name in commit message > - Superseded patch 96985 > --- > po/zh_CN.po | 373 > +++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 190 insertions(+), 183 deletions(-) > > > > -- Regards, Qian Hong - http://www.winehq.org

4 4

Patch 96965
by Christian Costa June 23, 2013

June 23, 2013

Hi, This patch http://source.winehq.org/patches/data/96965 is in the pending state. Is there anything wrong or missing. Basically this patch only changes the test to check exactly the returned value to show the difference in behaviour between A and Version of the API. The rest is just to things to make this difference clearer.

1 0

(no subject)
by namit maheshwari June 22, 2013

June 22, 2013

1 0

Accentuate names.
by Tae Wong June 22, 2013

June 22, 2013

There are lots of Czech developers (Macek and Semerad) being unaccentuated plus Caolan and Znidarsic. They need to be accentuated.

1 0

talking about web-based translation again -- transifex
by qing xianhao June 21, 2013

June 21, 2013

hi all, firstly, i didn't use launchpad so much, but i used transifex for a mouths help to translate several opensource projects including the transifex itself. i found it can answer these needs as commented following. Quoted from http://www.winehq.org/pipermail/wine-devel/2011-September/092047.html > Launchpad tracks who translated what string and if we choose the > 'Closed' permissions model only approved translators can update the > translations. So that means we should be able to get patches with > full attribution. transifex has coordinator and translator roles division. coordinator could review the translation[1]. > Launchpad would need to pull updated PO files from Wine regularly. > Ideally that would be automatic and happen daily (both to account > for translations happening outside Launchpad and to take changes in > the resource files into account quickly). transifex has option to pull form outside, and the frequency is about daily[2]. > Conversely Launchpad should submit patches back to Wine. Ideally that > would be automated as much as possible but I'm fuzzy on the details > here (especially on how to preserve attribution). As for the > periodicity, maybe the best would be weekly or just before Alexandre > makes a release. the transifex has command line client[3] to pull the translation changes. if a unix guy got the command line tool, what could he do. ;) Quoted from http://www.winehq.org/pipermail/wine-devel/2012-January/093908.html >trace every Wine commit to a specific person transifex itself is open source project that can be self-hosted[4]. xfce team is hosting their own with it, every the commit was tracked and can view the diff easyly. [4] community edition installation http://help.transifex.com/server/ [3] transifex client http://support.transifex.com/customer/portal/topics/440187-transifex-client… [2] How often are the stats auto-updated http://help.transifex.com/intro/faq.html#how-often-are-the-stats-auto-updat… [1] coordinator review http://help.transifex.com/intro/translating.html#proofreading-translations -- qingxianhao

2 1

Re: user32: Invalidate window after resizing for WM_SYSCOMMAND/SC_SIZE.
by Alexandre Julliard June 21, 2013

June 21, 2013

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/user32/winpos.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) That's only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader
by Henri Verbeet June 21, 2013

June 21, 2013

On 21 June 2013 12:06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This also works for fog_start == fog_end on drivers that don't handle > this situation correctly with fixed function fog. Tested on nvidia, > r300g, r600g. What does this fix?

2 1

Re: [PATCH 2/2] msvcrt: Add some _mbstok tests
by Marvin June 21, 2013

June 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26066 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

2 1

Re: [PATCH] winetest: Add support for wineconsole output
by Fabian Ebner June 20, 2013

June 20, 2013

Am 20.06.2013 17:55, schrieb Bruno Jesus: > On Thu, Jun 20, 2013 at 12:42 PM, Fabian Ebner <f.ebner94(a)gmail.com> wrote: >> Allow winetest to output stuff inside a wineconsole. >> Fixes http://bugs.winehq.org/show_bug.cgi?id=28191 >> --- >> programs/winetest/gui.c | 6 +++--- >> programs/winetest/main.c | 2 +- >> programs/winetest/util.c | 25 +++++++++++++++++++++++++ >> programs/winetest/winetest.h | 1 + >> 4 files changed, 30 insertions(+), 4 deletions(-) >> + //No logfile means printing to stdout Ok, thanks > C++ comments are not allowed AFAIK. > >> + if (!logfile) { The surrounding code uses this style when it is an if or a while, when it's a function it uses new-line {. But there are only two other occurences of {}-braces, should I change them with my patch and use new-line all along? > You should use the coding style of the surrounding code, it looks like > the rest of the file uses the { in the next line, I may be wrong about > this. > > Best wishes, > Bruno

1 0

Re: ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3)
by Alexandre Julliard June 20, 2013

June 20, 2013

Mathis Beer <default_357-line(a)yahoo.de> writes: > As such, this patch changes msync to be called asynchronously. > > This is revision three of this patch. It leaves the original #define > MS_SYNC 0 in place and instead changes NtFlushVirtualMemory to use > MS_ASYNC only if mman.h was found earlier. (It also adds comments) That doesn't make sense, all interesting platforms have mman.h, that doesn't imply they have MS_ASYNC. It may well be that nowadays they all have MS_ASYNC too, so we could use it unconditionally and see if someone reports breakage. This will have to wait until after code freeze though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/4] ddraw: Device2 and Device3 do not have a lighting render state
by Henri Verbeet June 20, 2013

June 20, 2013

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Light state */ > DWORD material; > + DWORD dummy_rs_lighting; > Considering the render state doesn't exist in early ddraw versions, do we really care that its value is preserved? It seems unlikely that anything except our tests would depend on it.

2 3

Re: [website] Added Portuguese translation for call for translators
by Frédéric Delanoy June 20, 2013

June 20, 2013

2013/6/19 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013061601.xml | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 news/pt/2013061601.xml > > diff --git a/news/pt/2013061601.xml b/news/pt/2013061601.xml > new file mode 100644 > index 0000000..86bf5a8 > --- /dev/null > +++ b/news/pt/2013061601.xml > @@ -0,0 +1,9 @@ > +<news> > +<date>16 de Junho de 2013</date> > +<title>Procura-se tradutores!</title> > +<body> Just wondering: does it make sense to translate a call for translators? I mean, if a volunteer can't understand the English from the call, (s)he wouldn't be able to translate correctly anyway. Frédéric

3 2

Re: [PATCH 2/4] ddraw: Send device2_Draw* through device3_Draw*
by Henri Verbeet June 20, 2013

June 20, 2013

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - return IDirect3DDevice7_DrawPrimitive(&device->IDirect3DDevice7_iface, device->primitive_type, > + return IDirect3DDevice3_DrawPrimitive(&device->IDirect3DDevice3_iface, device->primitive_type, > device->vertex_type, device->sysmem_vertex_buffer, device->nb_vertices, device->render_flags); This is not introduced by your patch of course, but I don't think there's much of a point in going through the vtbl here.

2 1

Re: [PATCH 1/4] ddraw: SPECULARENABLE defaults to true in IDirect3DDevice2
by Henri Verbeet June 20, 2013

June 20, 2013

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -4250,7 +4250,12 @@ static HRESULT WINAPI d3d2_CreateDevice(IDirect3D2 *iface, REFCLSID riid, > wined3d_mutex_lock(); > hr = d3d_device_create(ddraw, surface_impl, 2, &device_impl, NULL); > if (SUCCEEDED(hr)) > + { > *device = &device_impl->IDirect3DDevice2_iface; > + hr = IDirect3DDevice2_SetRenderState(*device, D3DRENDERSTATE_SPECULARENABLE, TRUE); > + if (FAILED(hr)) > + ERR("SetRenderState failed\n"); > + } Why not do this together with the other render state setup in d3d_device_init()?

1 0

Re: [PATCH 2/3] d3d9/tests: Reset texture 0 to NULL at the end of texop_test().
by Henri Verbeet June 20, 2013

June 20, 2013

On 19 June 2013 21:59, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > While it doesn't really matter for the test results (it only affects the > alpha component of the following test but that isn't checked anyway) I feel > it's a good idea to properly cleanup and avoid dependencies between > tests. Yeah, though ideally we'd do that by using create_device() from individual tests instead of reusing a single device.

1 0

Re: [Wine] German translation - netstat.exe
by Joerg Schiermeier June 19, 2013

June 19, 2013

On Tuesday, 18 Jun 2013 at 19:35:02 André Hentschel wrote: > when you scroll down a bit on that page, you see everything needed to get rid of false positives. Ah, I didn't scrolled down sooo deep. :( > Oh and fgouget is Fran?ois Gouget Thanks for this hint. I will deal with it in the right manner. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: gdi32: Get the default character index, not its value.
by Alexandre Julliard June 19, 2013

June 19, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/gdi32/freetype.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:1356: Test failed: GetGlyphIndicesW should have returned a 0080 not 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Italian translation (try 3)
by Matteo Bruni June 19, 2013

June 19, 2013

2013/6/17 Fabian Ebner <f.ebner94(a)gmail.com>: > Typo fixed (finally) > --- > po/it.po | 40 ++++++++++++++-------------------------- > 1 file changed, 14 insertions(+), 26 deletions(-) > This one looks good to me, thanks :)

1 0

Re: mlang.dll implementation fix
by Christian Costa June 19, 2013

June 19, 2013

Hi and welcome, Patches should be sent included in the mail. Adding tests is recommended. You can follow status at http://source.winehq.org/patches/. But currently we're in code freeze so you may have to wait Wine 1.6. Christian 2013/6/19 Bartosz <gang65(a)poczta.onet.pl> > My name is Bartosz and I would like to start hacking wine. > At beginning I implemented BreakLine methods (available in mlang.dll): > http://msdn.microsoft.com/en-us/library/aa741037%28v=vs.85%29.aspx > > I prepared patch which is available at: > http://bugs.winehq.org/attachment.cgi?id=44854&action=diff > http://bugs.winehq.org/show_bug.cgi?id=32126 > > Could you please take a look at these methods and push it into git repo? > > Should I write tests for that? > > Thanks in advance > Bartosz > > >

2 1

Re: oledb32: Add more database tests
by Marvin June 19, 2013

June 19, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26031 Your paranoid android. === WXPX64 (64 bit database) === database.c:166: Test failed: got L"Provider=SQLOLEDB.1;Data Source=dummy" === WVISTAX64 (64 bit database) === database.c:166: Test failed: got L"Provider=SQLOLEDB.1;Data Source=dummy" === W7PROX64 (64 bit database) === database.c:166: Test failed: got L"Provider=SQLOLEDB.1;Data Source=dummy" === TEST64_W7SP1 (64 bit database) === database.c:166: Test failed: got L"Provider=SQLOLEDB.1;Data Source=dummy"

1 0

Using of mac driver completely breaks tablets support?
by Andrey Upadyshev June 18, 2013

June 18, 2013

Hi All! I've installed a Wine 1.5.31 instead of 1.4.smthng and found that tablets support is broken. Some research gives me that wintab32 DLL fails to init because winemac driver doesn't implement tablet related functions (LoadTabletInfo etc) unlike x11 driver. I'm a Wine newcomer so probably I get something wrong about it... How can I switch back to x11 driver? BR, Andrey Upadyshev

4 4

Re: [bugzilla] Add descriptions for additional resolutions (try 2)
by Alexandre Julliard June 18, 2013

June 18, 2013

André Hentschel <nerv(a)dawncrow.de> writes: > + <dd> > + The problem is not a [% terms.bug %] in Wine, > + but in some upstream software Wine depends on or broken > + packages in distributions. > + Note: Most other bug trackers call this "NOTOURBUG". We should probably rename it. UPSTREAM is not a good name for the way we are using it. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: Alexandre Julliard : winefile: Avoid abbreviations in column names.
by Bruno Jesus June 18, 2013

June 18, 2013

On Tue, Jun 18, 2013 at 4:42 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: f07ff7f9819b32437624a320fe3029dd795b7a61 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=f07ff7f9819b32437624a320f… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Jun 18 11:32:45 2013 +0200 > > winefile: Avoid abbreviations in column names. Why not remove the "Date" word as they are always dates? Leave only "Creation", "Modification" and "Access". It will help to keep the column headers short. Are they used in other places? Best wishes, Bruno

2 1

Re: po: Update Spanish translation
by Bruno Jesus June 18, 2013

June 18, 2013

On Mon, Jun 17, 2013 at 6:05 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > I recently started to learn spanish, so i did this easy fixes with best knowledge, though without guaranty > --- > po/es.po | 60 ++++++++++++++++++------------------------------------------ > 1 file changed, 18 insertions(+), 42 deletions(-) > #: joy.rc:64 > -#, fuzzy > -#| msgid "Available formats" > msgid "Available Effects" > -msgstr "Formatos disponibles" > +msgstr "Formatos efectos" "Efectos disponibles" makes more sense than "Formatos efectos", I guess this was a typo. #: netstat.rc:33 msgid "Sent" -msgstr "" +msgstr "Envió" "Envió" is present tense, the past tense would be "Enviado". Best wishes, Bruno

3 2

[Wine] German translation - netstat.exe
by Joerg Schiermeier June 18, 2013

June 18, 2013

Hi list, in wines call for translators is listed one 'spelling error' in the German translation which isn't one. <http://fgouget.free.fr/wine-po/> The translation is correct: <http://fgouget.free.fr/wine-po/de.spell.html> ---<cite>--- [Proto] (unchanged) 10453 -> Porto, Proton, Photo, Protest, Protzen ---</cite>--- is correct translated to 'Proto'. 'Proto' is used as an abbreviation for protocol. This appears in 'netstat.exe' (src/wine/programs/netstat). I checked this in an 'Windows 7' installation running the original command. Who is responsible for the list in <http://fgouget.free.fr/wine-po/>? You may please take this one faulty error away. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

Re: [PATCH 1/2] wined3d: Pass fogstart==fogend to GL in fog table mode (try 3)
by Henri Verbeet June 18, 2013

June 18, 2013

On 18 June 2013 16:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index e14d7ab..ad9be6a 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -7107,7 +7109,7 @@ static void glsl_fragment_pipe_fog(struct wined3d_context *context, > new_source = FOGSOURCE_FFP; > } > > - if (new_source != context->fog_source) > + if (new_source != context->fog_source || fogstart == fogend) > { > context->fog_source = new_source; > state_fogstartend(context, state, STATE_RENDER(WINED3D_RS_FOGSTART)); You shouldn't need this.

2 3

Re: [PATCH 2/5] wined3d: Handle fog_start==fog_end with table fog(try 2)
by Henri Verbeet June 18, 2013

June 18, 2013

On 17 June 2013 22:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > correctly with fixed function fog. Tested as usual on Geforce9 (OSX, > Linux), Geforce7 (Linux), r300g, r600g, i965 (OSX), r200. Which of those is affected by the quirk? I think all of those except r200 should be able to do GLSL, but you say r200 is the only one that doesn't pass the tests. You may be able to convince me that this is a good idea, but so far I don't think it's worth all the extra code. > + if (isnan(fogstart) || isinf(fogstart) || isinf(-fogstart)) You should only need one isinf() here, it's not supposed to care about the sign. > #define WINED3D_ADAPTER_CAP_XYZRHW 0x00000001 > #define WINED3D_ADAPTER_CAP_VS_CLIPPING 0x00000002 > +#define WINED3D_ADAPTER_CAP_BROKEN_FOG 0x00000008 Is this intentional?

2 4

Re: comctl32: Use default GUI font instead of System as a fallback in the tab control.
by Alexandre Julliard June 18, 2013

June 18, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/comctl32/tab.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) It breaks the tests here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so tab.c && touch tab.ok tab.c:625: Test failed: with icon, set size > icon: Expected [57,30] got [54,30] tab.c:626: Test failed: with icon, set size < icon: Expected [57,20] got [54,20] tab.c:627: Test failed: with icon, min size: Expected [57,1] got [54,1] tab.c:625: Test failed: with icon, set size > icon: Expected [60,30] got [54,30] tab.c:626: Test failed: with icon, set size < icon: Expected [60,20] got [54,20] tab.c:627: Test failed: with icon, min size: Expected [60,1] got [54,1] tab.c:625: Test failed: with icon, set size > icon: Expected [63,30] got [56,30] tab.c:626: Test failed: with icon, set size < icon: Expected [63,20] got [56,20] tab.c:627: Test failed: with icon, min size: Expected [63,1] got [56,1] tab.c:625: Test failed: with icon, set size > icon: Expected [66,30] got [59,30] tab.c:626: Test failed: with icon, set size < icon: Expected [66,20] got [59,20] tab.c:627: Test failed: with icon, min size: Expected [66,1] got [59,1] etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (retry) gdi32: load cached vertical fonts after non-vertical font
by Alexandre Julliard June 18, 2013

June 18, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > { > - FontSubst *subst = HeapAlloc(GetProcessHeap(), 0, sizeof(*subst)); > - subst->from.name = strdupW(english_family); > - subst->from.charset = -1; > - subst->to.name = strdupW(family_name); > - subst->to.charset = -1; > - add_font_subst(&font_subst_list, subst, 0); > + if (!array_size) > + { > + array_size = 5; > + vertical_fonts = HeapAlloc(GetProcessHeap(), 0, array_size * sizeof(WCHAR*)); > + } > + if (vertical_count+1 >= array_size) > + { > + array_size *= 2; > + vertical_fonts = HeapReAlloc(GetProcessHeap(), 0, vertical_fonts, array_size * sizeof(WCHAR*)); > + } > + vertical_fonts[vertical_count] = strdupW(buffer); > + vertical_count++; That seems overly complicated. We already put the fonts in a list, it shouldn't be hard to reorder it, or use a temp list for vertical fonts, or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Consolidate d3d_info BOOLs into a flags field
by Henri Verbeet June 18, 2013

June 18, 2013

We probably want this regardless of the next patch, but I'd prefer for this kind of thing to go in after the release.

1 0

Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.
by Daniel Jeliński June 18, 2013

June 18, 2013

Hi Dmitry, After this patch got applied, the code looks like this: ( http://source.winehq.org/git/wine.git/blob/cc086f09ae46c77e6eb4a817ae567294… ) 1914 if (!GetObjectW((infoPtr->hFont) ? 1915 infoPtr->hFont : GetStockObject(DEFAULT_GUI_FONT), 1916 sizeof(LOGFONTW),&logfont)) 1917 GetStockObject(DEFAULT_GUI_FONT); I'm quite sure you didn't mean to ignore return value of GetStockObject and leave logfont uninitialized here. Regards, Daniel (sorry for being late to the party, I'm not subscribing wine-patches, and kind of assumed this patch wouldn't get past AJ)

3 2

Re: Web based translation tool
by Michal Čihař June 17, 2013

June 17, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Re: po: Update Italian translation (try 2)
by Matteo Bruni June 17, 2013

June 17, 2013

2013/6/17 Fabian Ebner <f.ebner94(a)gmail.com>: > Fixed a typo and a sentence, thanks to Matteo > --- > po/it.po | 40 ++++++++++++++-------------------------- > 1 file changed, 14 insertions(+), 26 deletions(-) #: jscript.rc:39 msgid "'return' statement outside of function" -msgstr "" +msgstr "Istruzione 'return' fouri della funzione" Sorry, but this is worse...

2 1

Re: ole32: Do not fail if partial blocks are read
by Bruno Jesus June 17, 2013

June 17, 2013

On Mon, Jun 17, 2013 at 1:28 PM, Aric Stewart <aric(a)codeweavers.com> wrote: > > fixes bug 25346 Actually this patch fixes bug 33821. Bug 25346 is older than the regression and was only affected by it. > --- > dlls/ole32/storage32.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Best wishes, Bruno

1 0

Re: Update Italian translation
by Matteo Bruni June 17, 2013

June 17, 2013

2013/6/16 Fabian Ebner <f.ebner94(a)gmail.com>: > --- > po/it.po | 40 ++++++++++++++-------------------------- > 1 file changed, 14 insertions(+), 26 deletions(-) #: joy.rc:42 msgid "" "After disabling or enabling a device, the connected joysticks won't be " "updated here until you restart this applet." msgstr "" +"Dopo disattivare o attivare un dispositivo, i joystick connessi non saranno " +"attualizzati qui, fino al riavvio dell'applet." That sounds like broken Italian (or a word-by-word translation), maybe something like "Dopo aver disattivato o attivato un dispositivo, i joystick connessi non saranno aggiornati fino al riavvio dell'applet."? The original English message has probably some room for improvement too. #: jscript.rc:39 msgid "'return' statement outside of function" -msgstr "" +msgstr "Istruzione 'return' fouri dalla funzione" Typo.

1 0

Re: [PATCH] gdi32: do not overwrite variables (Coverity) (resubmit)
by Alexandre Julliard June 17, 2013

June 17, 2013

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > CID 743138,743137,743136 > wrote a DWORD (32bit) into a SHORT (16bit) entity. > > Not sure what is wrong with this one... it is a pretty clear bug to me. It's a bug, but it can be fixed in a better way. That helper function is badly designed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Wine] Call for Translators
by Frédéric Delanoy June 16, 2013

June 16, 2013

On Sun, Jun 16, 2013 at 2:02 PM, Martin Gregorie <martin(a)gregorie.org> wrote: > On Sun, 2013-06-16 at 08:52 +0200, Francois Gouget wrote: >> On Sun, 16 Jun 2013, Yaron Shahrabani wrote: >> >> > Hey Francois, sorry for trolling but I guess this is the time to revisit >> > our stand regarding web translation platform (because I suspect it might be >> > the cause for the lack of participation). >> > >> > What do you guys think? >> >> Do you mean the stance on making sure every contribution is properly >> attributed to its author? I don't think that's negotiable. >> > As a native English speaker I'm not really affected by WINE's language > support. > > My main gripe with WINE is the evident lack of regression testing. > > Martin Please don't hijack threads. Feel free to open a new thread on this subject on wine-devel. Frédéric

1 0

Call for Translators
by Francois Gouget June 16, 2013

June 16, 2013

With the advent of PO files, Wine went from 12 good translations in the pre-1.4 days to 20 now. What's even more encouraging is that there are an extra 6 translations that are already half done. So can we reach 26 translations in time for Wine 1.6? More? So I'm calling on all translators of good will to review, refresh, complete or even start new Wine translations. You will find instructions to get started there: http://wiki.winehq.org/Translating And just as for Wine 1.4 you can track the translations status here: http://fgouget.free.fr/wine-po/ This site also collects reports about potential translation issues: * Mismatched printf format specifiers. (Note that these can cause Wine crashes!) * Mismatched trailing ellipsis. * Other mismatched trailing punctuation like full stop, question mark, space, etc. * Mismatched line feeds, trailing or not. * Spaces followed by line feeds. * Untranslated strings. Obviously some of these result in false positives. For instance 'Document' is written exactly the same in English and in French so to the script it will look like it was not translated. If you send me the corresponding error lines I'll make sure they are ignored by putting them in an 'ignore' file. This way the next translator looking things over won't have to skip over all these false positives. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Theory is where you know everything but nothing works. Practice is where everything works but nobody knows why. Sometimes they go hand in hand: nothing works and nobody knows why.

3 4

Re: [bugzilla] Add descriptions for additional resolutions
by Henri Verbeet June 16, 2013

June 16, 2013

On 16 June 2013 01:26, André Hentschel <nerv(a)dawncrow.de> wrote: > + <dt> > + [% display_value("resolution", "UPSTREAM") FILTER html %] > + </dt> > + <dd> > + The problem is not a [% terms.bug %] in Wine, > + but in some upstream software Wine depends on. > + </dd> I don't care that much, but note that this isn't strictly limited to upstream, and also applies to e.g. broken packages. Also mostly fwiw, most other bug trackers I'm aware of call this NOTOURBUG.

1 0

Re: [PATCH 1/4] wined3d: Handle fog_start == fog_end with table fog
by Henri Verbeet June 16, 2013

June 16, 2013

On 14 June 2013 22:34, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + { > + float increase = eps; > + volatile float fogend2 = fogend; > + do > + { > + fogend2 += increase; > + increase *= 2.0f; > + } > + while (fogstart == fogend2); > + fogend = fogend2; > + } Why is this needed? When end == start I'd expect (end - c) / (end - start) to evaluate to +/-INF, and then get clamped to [0, 1], which is pretty much what you'd want. In my (very limited) testing, that's also what actually happens with at least the GLSL backend.

2 3

Call for help with the new WineTestBot
by Francois Gouget June 16, 2013

June 16, 2013

So while the translators are busy updating Wine's translations, what better time than a freeze for developers to fix Wine's conformance tests, particularly on the new WineTestBot: http://newtestbot.winehq.org It does not have as many VMs as the old one but it does have some interesting new configurations: * Two Windows 8 VMs: 32 and 64 bits. These have a lot of failures. * A Windows 7 VM with IE 10 (and one with IE 9 for comparison). * A Vista VM configured for Arabic, a right-to-left language. There's also a Japanese Windows 7 VM. * Two VMs with no sound card (the 64-bit Vista and Windows 2008 ones). These new configurations have uncovered quite a few test failures. But the more traditional configurations have some test failures too which is annoying and warrants investigation to figure out what's wrong: otherwise there will be trouble when patches have to go through the new WineTestBot. So I'm hoping some kind souls (or bored developers) will take it onto themselves to chime in and fix some of these test failures, or figure out what is causing them. Here are some known issues: * Bug 24631 - listview NM_HOVER tests sometimes fail http://bugs.winehq.org/show_bug.cgi?id=24631 * Bug 33718 - comctl32:propsheet Add button test failure http://bugs.winehq.org/show_bug.cgi?id=33718 * Bug 33719 - comctl32:propsheet custom window proc test failure http://bugs.winehq.org/show_bug.cgi?id=33719 You can also find test results from the new WineTestBot on the WineTest site: look for tags starting with 'newtb-'. http://test.winehq.org/data/ And for more information on the VMs configuration and some other known test failures go to this Wiki page: http://wiki.winehq.org/WineTestBotVMs Note that the VMs are missing some Windows dlls (atl100, localspl, msvcp100, qmgr). Information on the best way to get those is welcome. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

1 0

Re: [PATCH 3/3] wined3d: Handle pre-transformed vertices in the GLSL vertex pipe.
by Stefan Dösinger June 15, 2013

June 15, 2013

Am 14.06.2013 um 09:07 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > + shader_addline(buffer, "if (gl_Vertex.w != 0.0) gl_Position /= gl_Vertex.w;\n"); I think you have to disable the rhw divide in drawStridedSlow in case the application falls back to it despite this patch, e.g. because of specular fog or float16 emulation.

1 0

Re: gdiplus: fix a clipping regression in GdipDrawString (try 3)
by Dmitry Timoshkov June 14, 2013

June 14, 2013

Rafał Mużyło <galtgendo(a)gmail.com> wrote: > Going on an assumption, that 0 is a magic value (standing for 'point'), > compare against it. Fixes 6ab04040e52465e77558a067309e8a54bdc0f32c regression, > so would be nice if this got into wine 1.6. It would be nice to see some test cases first. -- Dmitry.

1 0

Fwd: [GSoC Mentors Announce] GSoC 2013: Mentor Summit Travel and Details
by Austin English June 14, 2013

June 14, 2013

FYI for GSoC mentors. It's a ways away, but have the date in mind if you'd like to attend. Remember we have two slots, so if there are more than 2 people, we'll give preference to people that haven't gone before. -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Thu, Jun 13, 2013 at 11:23 AM Subject: [GSoC Mentors Announce] GSoC 2013: Mentor Summit Travel and Details To: gsoc-mentors-announce <gsoc-mentors-announce(a)googlegroups.com> Hi everyone, The Google Summer of Code Mentor Summit is approaching! When: 19-20 October, 2013 Where: Google Headquarters, Mountain View, California Some brief background: The Google Summer of Code Mentor Summit is a two-day "unconference" [0] that brings together two mentors (or org admins) from each of the mentoring organizations that has participated in GSoC that year. Google pays for a two-night hotel stay, transportation costs, conference facilities, and food for the weekend, and the attendees make the agenda. We've consistently heard from mentors over the years that the summit was one of the best conferences of the year for them. The opportunity to meet face-to-face with other FOSS community members is a valuable experience, as is the time spent discussing ideas in a casual forum where everyone's voice can be heard. I'd encourage your organization to send delegates to the summit even if you don't quite understand of the utility of it now - I feel confident you won't be disappointed with the results. Attendees stay at the Wild Palms hotel [1] while they're in town and we serve a traditional dinner of thai food on Friday night and have a pool party on Saturday night. Here's how to proceed with booking and attending: 1) Your organization will need to decide on two delegates [2] to send to the event. Any people who want to attend above and beyond the two from your org will need to list themselves on the Waiting List [3] and wait for word from me about extra space as we get closer to the event. NB: The wiki requires a login when visiting for the first time. The username is "mentor" and the password is "yourock." I highly recommend creating your own account with a unique password once you have logged in for the first time. 2) Once your organization has decided on the two delegates it would like to send to this year's event, those individuals can feel free to book their hotel rooms at the Wild Palms [4] now. Please note that if the Wild Palms fills up you will need to make your reservation with the Domain Hotel instead [5]. If you really want to stay at the Wild Palms, make sure to book early! We'll have shuttles running between the hotels and to campus for the whole weekend. NB: The hotel registration deadline is 6 September. If you really want to stay at the Wild Palms, I'd recommend you book early. :-) 3) Please fill out the Mentor Summit Preparation form [6] as soon as you have confirmed your hotel room. 4) We include the reimbursement for travel to the mentor summit and the mentor stipends in one PO to your organization. Please see the payment info page [7] for more detail on this. These POs will be issued to your org soon after it has made the payment request. 5) Flights should be purchased once you have a confirmed PO. All orgs pay for plane tickets ahead of time and then request reimbursement via invoice against the PO once you have receipts for the flights. 6) Please check out the wiki [8] and fill in your name if you're attending. Look around the rest of the site - it has lots of useful information for you about the event and what to expect. 7) In the unlikely event that your organization does not plan to attend the mentor summit at all, please fill out this form [9] to let me know. Please only fill this out if you are not sending *any* delegates to the summit. 8) We are doing session scheduling for this year's summit via Google Moderator. Please fill in your ideas for sessions on the webpage [10] by 27 September and vote for your favorite ideas! You can read more about how we're running session scheduling this year on the wiki [11]. 9) Please remember that any organization that misses two or more evaluation deadlines may not attend the summit. If you book travel and then get uninvited from the summit after the either the midterm or the final evaluations you will not be reimbursed for travel costs and your hotel stays will be cancelled. So don't miss those evaluations or you jeopardize missing the event! [0] - http://en.wikipedia.org/wiki/Unconference [1] - http://www.jdvhotels.com/hotels/siliconvalley/wild_palms [2] - A "delegate" is defined as either a mentor or org admin who participated in this year's GSoC program. We're sorry, but we can't accomodate other people from your organization who did not mentor or administer this year. Also, we will not accept any mentors who miss an evaluation deadline in this year's program. Please contact me if you have questions about if a person from your organization is on this list. [3] - https://docs.google.com/a/google.com/forms/d/1bfuIJ_U76rznjfqBYdRKfFlfmvhqr… [4] - https://www.jdvhotels.com/book/reservations/wld?start_date=2013-10-14&end_d… [5] - https://www.jdvhotels.com/book/reservations/dom?start_date=2013-10-18&end_d… [6] - http://goo.gl/oyM2y [7] - http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20… [8] - https://gsoc-wiki.osuosl.org/index.php/2013 [9] - http://goo.gl/OTxuo [10] - http://goo.gl/EH0ZH [11] - https://gsoc-wiki.osuosl.org/index.php/Proposed_Session_Topics_2013 As always, please contact me directly with any questions or concerns you may have about any of these instructions. Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors Announce List" group. To unsubscribe from this group and stop receiving emails from it, send an email to gsoc-mentors-announce+unsubscribe(a)googlegroups.com. Visit this group at http://groups.google.com/group/gsoc-mentors-announce. For more options, visit https://groups.google.com/groups/opt_out. -- -Austin

2 1

Re: oledb32: Add IErrorInfo Support
by Nikolay Sivov June 14, 2013

June 14, 2013

On 6/14/2013 14:12, Alistair Leslie-Hughes wrote: > +typedef struct ErrorInfoImpl > +{ > + IErrorInfo IErrorInfo_iface; > + LONG ref; > + > + GUID m_Guid; > + WCHAR *source; > + WCHAR *description; > + WCHAR *help_file; > + DWORD m_dwHelpContext; > +} ErrorInfoImpl; Please use consistent naming, for example avoid prefixed names. Also it would be cleaner to use BSTR here, but it will work either way. > + TRACE("(%p)->(pBstrSource=%p)\n",This,pBstrSource); No need for parameter names in traces.

1 0

Re: ole32: Postpone removing a being destroyed apartment from the global list.
by Alexandre Julliard June 13, 2013

June 13, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > StdMarshalImpl_ReleaseMarshalData called from apartment_release() needs to > access apartment data, but fails because an apartment has already been removed > from the global list. That leads to lost connections and memory leaks. But now you can have someone find a half-destroyed apartment in the list... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [cmd, try2] move filename . deletes file
by Alexandre Julliard June 13, 2013

June 13, 2013

Jason Edmeades <jason(a)edmeades.me.uk> writes: > move is not tollerent of the source and destination being the same > and happily removes the destination (after prompting) ready to > move the file, only to appear shocked that the file is no longer > there... > > This was sent originally where I compared filenames, and was given > feedback to use a better system of equality. This now uses something > the MSDN implies is the best way to tell for equivalent destinations This should be done in MoveFile, and cmd should use that instead of duplicating the checks. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: oleaut32: Add DECIMAL tests
by Marvin June 13, 2013

June 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25961 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WXPPROSP2 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WXPX64 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W2K3R2SESP2 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WVISTAX64 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W2K8SE (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W7PROX64 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === TEST64_W7SP1 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WXPX64 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WVISTAX64 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W7PROX64 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === TEST64_W7SP1 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000

1 0

Re: oleaut32:
by Marvin June 13, 2013

June 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25960 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WXPPROSP2 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WXPX64 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W2K3R2SESP2 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WVISTAX64 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W2K8SE (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W7PROX64 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === TEST64_W7SP1 (32 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WXPX64 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === WVISTAX64 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === W7PROX64 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000 === TEST64_W7SP1 (64 bit vartype) === vartype.c:4339: Test failed: expected (0,0,-1,(ffffff84 ffffffff)), got (0,0,-1,(ffffffff ffffff84)) hres 0x00000000

1 0

Re: gdiplus: fix a clipping regression in GdipDrawString (try 2)
by Vincent Povirk June 12, 2013

June 12, 2013

What if rect.Width is 0.25? Shouldn't we still clip then?

1 0

Possible wine bug concerning the case of the DbgHelp.h header filename
by Alan W. Irwin June 12, 2013

June 12, 2013

I successfully built the ultra-fast ninja build tool on Wine using the MinGW g++ compiler. To achieve that success I had to deal with a small number of issues including one wine/ninja header name inconsistency which is that DbgHelp.h (#included by the ninja code) has a lower-case name (dbghelp.h) on wine, and the MinGW suite of compilers is sensitive to the case of header file names. I worked around this issue with the following symlink /home/wine/wine_build/install-git/include/wine/windows/DbgHelp.h -> dbghelp.h where /home/wine/wine_build/install-git is my install prefix for my wine-git build. Is Wine following the correct Windows naming convention for this header? For what it is worth, I did a google search for <windows dbghelp.h> and most of the hits were for DbgHelp.h rather than dbghelp.h so I can understand why the ninja developers used #include<DbgHelp.h> rather than the lower-case version of that name. If the wine developers here decide this is definitely a wine issue, I am willing to write up the bug report on your bugtracker so this issue doesn't get lost. A search there for <header case filename> did not turn up anything relevant. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

4 4

Wine's Tahoma...
by Aric Stewart June 12, 2013

June 12, 2013

Hi, So working on Arabic font issues I have started really looking at wine's Tahoma font. Windows Tahoma covers glyphs in quite a few ranges, Latin, Cyrillic, Hebrew, Arabic, Thai to name a few. Wine's Tahoma has bit a fraction of this coverage. Looking to improve our Arabic support, I found that our Tahoma heavily uses glyphs from DejaVu fonts already, which are public domain. I was wondering if we wanted to take the leap and just replace our Tahoma completely with DejaVu Sans? We can generate a fontforge sfd file for the file and adjust the family names as required. We would retain the copyrights so that we honer the source. But it would give us the glyphs we need to have a fully functional Tahoma. What is the thought on this? If there is strong opposition then I have a patch to include Arabic in our font, but it really seems like many users in other scripts would benefit greatly from having a more fully fleshed out tahoma. -aric

2 1

Re: [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests.
by Matteo Bruni June 12, 2013

June 12, 2013

2013/6/11 Christian Costa <titan.costa(a)gmail.com>: > Fixes bug 22682. > --- > dlls/d3dx9_36/d3dx9_36.spec | 2 +- > dlls/d3dx9_36/shader.c | 50 ++++++++++++++++++++++++++++++++++++++ > dlls/d3dx9_36/tests/shader.c | 55 ++++++++++++++++++++++++++++++++++++++++++ > include/d3dx9shader.h | 1 + > 4 files changed, 107 insertions(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/d3dx9_36.spec b/dlls/d3dx9_36/d3dx9_36.spec > index f2c229a..0f1387e 100644 > --- a/dlls/d3dx9_36/d3dx9_36.spec > +++ b/dlls/d3dx9_36/d3dx9_36.spec > @@ -159,7 +159,7 @@ > @ stdcall D3DXGetPixelShaderProfile(ptr) > @ stdcall D3DXGetShaderConstantTable(ptr ptr) > @ stdcall D3DXGetShaderConstantTableEx(ptr long ptr) > -@ stub D3DXGetShaderInputSemantics(ptr ptr ptr) > +@ stdcall D3DXGetShaderInputSemantics(ptr ptr ptr) > @ stub D3DXGetShaderOutputSemantics(ptr ptr ptr) > @ stdcall D3DXGetShaderSamplers(ptr ptr ptr) > @ stdcall D3DXGetShaderSize(ptr) > diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c > index 75bc9b5..3b71b4b 100644 > --- a/dlls/d3dx9_36/shader.c > +++ b/dlls/d3dx9_36/shader.c > @@ -1,6 +1,7 @@ > /* > * Copyright 2008 Luis Busquets > * Copyright 2009 Matteo Bruni > + * Copyright 2010, 2013 Christian Costa > * Copyright 2011 Travis Athougies > * > * This library is free software; you can redistribute it and/or > @@ -1778,3 +1779,52 @@ HRESULT WINAPI D3DXGetShaderSamplers(const DWORD *byte_code, const char **sample > > return D3D_OK; > } > + > +HRESULT WINAPI D3DXGetShaderInputSemantics(const DWORD *byte_code, D3DXSEMANTIC *semantics, UINT *count) > +{ > + const DWORD *ptr = byte_code; > + UINT i = 0; > + > + TRACE("byte_code = %p, semantics = %p, count = %p\n", byte_code, semantics, count); > + > + if (!byte_code) > + return D3DERR_INVALIDCALL; > + > + TRACE("Shader version: %#x\n", *ptr); > + > + /* Look for the END token, skipping the VERSION token */ > + while (*++ptr != D3DSIO_END) I think you should be a bit more careful in skipping non-opcode DWORDs, otherwise you could e.g. potentially match with constants from DEF instructions - very unlikely to happen in practice, sure, but since it can be easily avoided, why not? Take a look at shader_skip_opcode() from wined3d/shader_sm1.c. You can probably get away without having to write a table with the parameters count for each SM1 opcode by just skipping DWORDs with the most significant bit set (see shader_skip_unrecognized() from the same file). Of course you still have to special case DEF but that should be it. > + { > + /* Skip comments */ > + if ((*ptr & D3DSI_OPCODE_MASK) == D3DSIO_COMMENT) > + { > + ptr += ((*ptr & D3DSI_COMMENTSIZE_MASK) >> D3DSI_COMMENTSIZE_SHIFT); > + } > + else if ((*ptr & D3DSI_OPCODE_MASK) == D3DSIO_DCL) > + { > + DWORD param1 = *++ptr; > + DWORD param2 = *++ptr; > + DWORD usage = param1 & 0x1f; > + DWORD usage_index = (param1 >> 16) & 0xf; > + DWORD reg_type = (((param2 >> 11) & 0x3) << 3) | ((param2 >> 28) & 0x7); > + > + TRACE("D3DSIO_DCL param1: %#x, param2: %#x, usage: %u, usage_index: %u, reg_type: %u\n", > + param1, param2, usage, usage_index, reg_type); > + > + if (reg_type == D3DSPR_INPUT) > + { > + if (semantics) > + { > + semantics[i].Usage = usage; > + semantics[i].UsageIndex = usage_index; > + } > + i++; > + } > + } > + } > + > + if (count) > + *count = i; > + > + return D3D_OK; > +} Have you tried to implement D3DXGetShaderOutputSemantics too? I suspect most of the code will be pretty much the same, in that case you could move the common code to a helper function and use it from both. You don't necessarily need to do this right now, just mentioning a potential follow-up. > diff --git a/dlls/d3dx9_36/tests/shader.c b/dlls/d3dx9_36/tests/shader.c > index f7be174..471cd8c 100644 > --- a/dlls/d3dx9_36/tests/shader.c > +++ b/dlls/d3dx9_36/tests/shader.c > @@ -1,5 +1,6 @@ > /* > * Copyright 2008 Luis Busquets > + * Copyright 2010, 2013 Christian Costa > * Copyright 2011 Travis Athougies > * > * This library is free software; you can redistribute it and/or > @@ -271,6 +272,22 @@ static const D3DXCONSTANT_DESC ctab_samplers_expected[] = { > {"sampler2", D3DXRS_SAMPLER, 3, 1, D3DXPC_OBJECT, D3DXPT_SAMPLER3D, 1, 1, 1, 0, 4, NULL}, > {"notsampler", D3DXRS_FLOAT4, 2, 1, D3DXPC_VECTOR, D3DXPT_FLOAT, 1, 4, 1, 0, 16, NULL}}; > > +static const DWORD semantics_vs11[] = { > + 0xfffe0101, /* vs_1_1 */ > + 0x0000001f, 0x80000000, 0x900f0000, /* dcl_position0 v0 (input) */ > + 0x0000001f, 0x80000005, 0x900f0001, /* dcl_texcoord0 v1 (input) */ > + 0x0000001f, 0x80010005, 0x900f0002, /* dcl_texcoord1 v2 (input) */ > + 0x0000001f, 0x8000000a, 0xe00f0000, /* dcl_color0 oD0 (output) */ > + 0x0000ffff}; /* END */ > + > +static const DWORD semantics_vs30[] = { > + 0xfffe0300, /* vs_3_0 */ > + 0x0000001f, 0x80000000, 0x900f0000, /* dcl_position0 v0 (input) */ > + 0x0000001f, 0x80000005, 0x900f0001, /* dcl_texcoord0 v1 (input) */ > + 0x0000001f, 0x80010005, 0x900f0002, /* dcl_texcoord1 v2 (input) */ > + 0x0000001f, 0x8000000a, 0xe00f0000, /* dcl_color0 o0 (output) */ > + 0x0000ffff}; /* END */ > + > static void test_get_shader_size(void) > { > UINT shader_size, expected; > @@ -1900,6 +1917,43 @@ static void test_get_shader_constant_variables(void) > ok(count == 0, "Release failed, got %u, expected %u\n", count, 0); > } > > +static void test_get_shader_semantics(void) > +{ > + HRESULT ret; > + D3DXSEMANTIC semantics[MAXD3DDECLLENGTH]; > + UINT count; > + > + /* Check parameters */ > + ret = D3DXGetShaderInputSemantics(NULL, semantics, &count); > + ok(ret == D3DERR_INVALIDCALL, "Returned %#x, expected %#x\n", ret, D3DERR_INVALIDCALL); > + ret = D3DXGetShaderInputSemantics(semantics_vs11, semantics, NULL); > + ok(ret == D3D_OK, "Failed with %#xn", ret); > + count = 0xdeadbeef; > + ret = D3DXGetShaderInputSemantics(semantics_vs11, NULL, &count); > + ok(ret == D3D_OK, "Failed with %#xn", ret); > + ok(count == 3, "Got %u, expected 1\n", count); > + > + ret = D3DXGetShaderInputSemantics(semantics_vs11, semantics, &count); > + ok(ret == D3D_OK, "Failed with %#xn", ret); > + ok(count == 3, "Got %u, expected 1\n", count); > + ok(semantics[0].Usage == D3DDECLUSAGE_POSITION, "Got %u, expected %u\n", semantics[0].Usage, D3DDECLUSAGE_POSITION); > + ok(semantics[0].UsageIndex == 0, "Got %u, expected 0\n", semantics[0].UsageIndex); > + ok(semantics[1].Usage == D3DDECLUSAGE_TEXCOORD, "Got %u, expected %u\n", semantics[1].Usage, D3DDECLUSAGE_TEXCOORD); > + ok(semantics[1].UsageIndex == 0, "Got %u, expected 0\n", semantics[0].UsageIndex); > + ok(semantics[2].Usage == D3DDECLUSAGE_TEXCOORD, "Got %u, expected %u\n", semantics[2].Usage, D3DDECLUSAGE_TEXCOORD); > + ok(semantics[2].UsageIndex == 1, "Got %u, expected 1\n", semantics[0].UsageIndex); > + > + ret = D3DXGetShaderInputSemantics(semantics_vs30, semantics, &count); > + ok(ret == D3D_OK, "Failed with %#xn", ret); > + ok(count == 3, "Got %u, expected 1\n", count); > + ok(semantics[0].Usage == D3DDECLUSAGE_POSITION, "Got %u, expected %u\n", semantics[0].Usage, D3DDECLUSAGE_POSITION); > + ok(semantics[0].UsageIndex == 0, "Got %u, expected 0\n", semantics[0].UsageIndex); > + ok(semantics[1].Usage == D3DDECLUSAGE_TEXCOORD, "Got %u, expected %u\n", semantics[1].Usage, D3DDECLUSAGE_TEXCOORD); > + ok(semantics[1].UsageIndex == 0, "Got %u, expected 0\n", semantics[0].UsageIndex); > + ok(semantics[2].Usage == D3DDECLUSAGE_TEXCOORD, "Got %u, expected %u\n", semantics[2].Usage, D3DDECLUSAGE_TEXCOORD); > + ok(semantics[2].UsageIndex == 1, "Got %u, expected 1\n", semantics[0].UsageIndex); > +} > + > START_TEST(shader) > { > test_get_shader_size(); > @@ -1911,4 +1965,5 @@ START_TEST(shader) > test_get_sampler_index(); > test_get_shader_samplers(); > test_get_shader_constant_variables(); > + test_get_shader_semantics(); > } > diff --git a/include/d3dx9shader.h b/include/d3dx9shader.h > index 0b30519..f5ba1c4 100644 > --- a/include/d3dx9shader.h > +++ b/include/d3dx9shader.h > @@ -269,6 +269,7 @@ DWORD WINAPI D3DXGetShaderVersion(const DWORD *byte_code); > const char * WINAPI D3DXGetVertexShaderProfile(struct IDirect3DDevice9 *device); > HRESULT WINAPI D3DXFindShaderComment(CONST DWORD* byte_code, DWORD fourcc, LPCVOID* data, UINT* size); > HRESULT WINAPI D3DXGetShaderSamplers(CONST DWORD *byte_code, LPCSTR *samplers, UINT *count); > +HRESULT WINAPI D3DXGetShaderInputSemantics(const DWORD *byte_code, D3DXSEMANTIC *semantics, UINT *count); > > HRESULT WINAPI D3DXAssembleShaderFromFileA(const char *filename, const D3DXMACRO *defines, > ID3DXInclude *include, DWORD flags, ID3DXBuffer **shader, ID3DXBuffer **error_messages); > > >

3 4

Re: [PATCH] d3dx9_36: Set compilation_errors to NULL when no error encountered + tests.
by Rico Schüller June 12, 2013

June 12, 2013

On 11.06.2013 22:08, Christian Costa wrote: > Fixes bug 26598. > --- > dlls/d3dx9_36/effect.c | 4 ++++ > dlls/d3dx9_36/tests/effect.c | 17 +++++++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index 1924c07..bab4560 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -5792,6 +5792,10 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s > > *effect = &object->ID3DXEffect_iface; > > + /* Must be set to NULL if no compilation error */ > + if (compilation_errors) > + *compilation_errors = NULL; > + No, this is wrong! Your test case doesn't cover all cases. Cheers Rico

2 2

Re: wininet/tests: Avoid proxy test failures on old wininet.
by Marvin June 12, 2013

June 12, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25946 Your paranoid android. === WXPX64 (32 bit http) === http.c:4459: Test failed: 4630: expected status 100 got 10 http.c:4459: Test failed: 4674: expected status 100 got 40 http.c:4432: Test failed: ar->dwResult = 0, expected 1 http.c:4459: Test failed: 4683: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA

1 0

Re: [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests.
by Rico Schüller June 12, 2013

June 12, 2013

On 11.06.2013 22:08, Christian Costa wrote: > + TRACE("byte_code = %p, semantics = %p, count = %p\n", byte_code, semantics, count); The rest of the file seems to use the trace without the "=". > + ok(ret == D3D_OK, "Failed with %#xn", ret); > + ok(count == 3, "Got %u, expected 1\n", count); Should be "\n" and "expected 3". Both several times. As the return value for semantics is in both tests the same, it might be useful to initialize the semantics first to check that the values are really set in both cases. What does D3DXGetShaderInputSemantics(semantics_vs11, NULL, NULL); and D3DXGetShaderInputSemantics(NULL, NULL, NULL); return? Well both are corner cases without much meaning. You may check for the semantics where the count is NULL like D3DXGetShaderInputSemantics(semantics_vs11, semantics, NULL); Cheers Rico

2 1

Re: comdlg32: Store client GUID with SetClientGuid()
by Marvin June 12, 2013

June 12, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25944 Your paranoid android. === TEST64_W7SP1 (32 bit itemdlg) === itemdlg: unhandled exception c0000005 at 75AF1AC3

1 0

[PATCH v6 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky June 11, 2013

June 11, 2013

Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 +++++++------ fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 +++++-- fs/cifs/inode.c | 21 +++--- fs/cifs/link.c | 25 ++----- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 ++-- fs/fcntl.c | 5 +- fs/locks.c | 158 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 48 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++- fs/nfs/nfs4xdr.c | 21 +++++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 +++++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 ++++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 35 files changed, 443 insertions(+), 139 deletions(-) -- 1.8.1.5

4 13

Patch 96712
by Christian Costa June 11, 2013

June 11, 2013

Hi, Is there something wrong with this patch? The only feedback I got is a typo (fixed). http://source.winehq.org/patches/data/96712 Thanks

1 0

Re: [PATCH 1/1] wined3d: Introduce a helper function for printing floats in GLSL shaders.
by Stefan Dösinger June 11, 2013

June 11, 2013

Am 11.06.2013 um 09:27 schrieb Henri Verbeet: > We always want to use '.' as decimal separator in GLSL, instead of the locale > specific one. Reported on IRC. I think this should be added as a code comment above shader_glsl_ftoa, I don't think the reason why we need our own conversion function is obvious. The ARB shader backend will need this as well, but I can take care of this. What external software triggers this behavior? > case WINED3D_DATA_FLOAT: > - sprintf(register_name, "%.8e", *(const float *)reg->immconst_data); > + shader_glsl_ftoa(*(const float *)reg->immconst_data, register_name); > break; shader_glsl_ftoa doesn't handle inf or nan. I assume that's intentional because they would only trigger a parser error.

2 1

Re: ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32
by Dmitry Timoshkov June 10, 2013

June 10, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > diff --git a/include/delayloadhandler.h b/include/delayloadhandler.h > new file mode 100644 > index 0000000..e48e415 > --- /dev/null > +++ b/include/delayloadhandler.h I don't see such file in PSDK 7.1, where does it come from? > diff --git a/include/winnt.h b/include/winnt.h > index 171141e..393f5a7 100644 > --- a/include/winnt.h > +++ b/include/winnt.h > @@ -3052,6 +3052,28 @@ typedef struct _IMAGE_RELOCATION > > #define IMAGE_SIZEOF_RELOCATION 10 > > +typedef struct _IMAGE_DELAYLOAD_DESCRIPTOR > +{ > + union > + { > + DWORD AllAttributes; > + struct > + { > + DWORD RvaBased:1; > + DWORD ReservedAttributes:31; > + }; > + } Attributes; > + > + DWORD DllNameRVA; > + DWORD ModuleHandleRVA; > + DWORD ImportAddressTableRVA; > + DWORD ImportNameTableRVA; > + DWORD BoundImportAddressTableRVA; > + DWORD UnloadInformationTableRVA; > + DWORD TimeDateStamp; > +} IMAGE_DELAYLOAD_DESCRIPTOR, *PIMAGE_DELAYLOAD_DESCRIPTOR; > +typedef const IMAGE_DELAYLOAD_DESCRIPTOR *PCIMAGE_DELAYLOAD_DESCRIPTOR; Same question here about IMAGE_DELAYLOAD_DESCRIPTOR. Besides, the structure contains namesless structure which is not compatible with some compilers and needs to be fixed. -- Dmitry.

3 2

Main sources of Wine complexity
by Ivan June 10, 2013

June 10, 2013

(short summary: why is emulation of Windows environment so difficult). First of all, my apologies if this is an off-topic question for this list but I hope it will be useful for others in the similar situation. I need to port fairly large WinAPI-heavy application to Linux. After some googling it becomes clear that there's nothing except for Wine/Winelib which is *huge*. However for at least most basic WinAPI functions it looks fairly easy to just re-implement it via Boost/STL/libc/Linux syscalls. Why there's nothing small like this already? Why only Wine with like 3 millions LoC and run-time dependencies? Is the approach described above make some sense for at least most common functionality (threading, IPC, file operations) w/o things like UI, graphics and registry. For instance, we need to either re-implement around 200 WinAPI functions (mostly events, mutexes, semaphore, sockets, file and folder operations) or to rewrite the entire thing from scratch. Using Winelib directly is not an option due to the nature of the app. Any help/advices are greatly appreciated. Thank you.

3 2

re: Main sources of Wine complexity
by Dan Kegel June 10, 2013

June 10, 2013

>I need to port fairly large WinAPI-heavy application to Linux. After some >googling it becomes clear that there's nothing except for Wine/Winelib >which is *huge*. However for at least most basic WinAPI functions it looks >fairly easy to just re-implement it via Boost/STL/libc/Linux syscalls. Why >there's nothing small like this already? >... we need to either re-implement around >200 WinAPI functions (mostly events, mutexes, semaphore, sockets, file and >folder operations) or to rewrite the entire thing from scratch. Using >Winelib directly is not an option due to the nature of the app. I think there have been several such compatibility layers. http://chiharu.haun.org/peace/ for instance. Wine's the only one that has really tried tor run everything. Why can't you just bundle wine? - Dan

1 0

Re: [PATCH 1/1] wined3d: Explicitly use the C locale for generating shaders.
by Alexandre Julliard June 10, 2013

June 10, 2013

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Specifically, we always want to use '.' as decimal separator. Reported on IRC. That's not very portable: x86_64-w64-mingw32-gcc -c -I../../../wine/dlls/wined3d -I. -I../../../wine/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -Wno-format -g -O2 -o glsl_shader.o ../../../wine/dlls/wined3d/glsl_shader.c ../../../wine/dlls/wined3d/glsl_shader.c:92:5: error: unknown type name ‘locale_t’ ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_pshader’: ../../../wine/dlls/wined3d/glsl_shader.c:4695:5: warning: implicit declaration of function ‘uselocale’ [-Wimplicit-function-declaration] ../../../wine/dlls/wined3d/glsl_shader.c:4697:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c:4697:15: note: each undeclared identifier is reported only once for each function it appears in ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_vshader’: ../../../wine/dlls/wined3d/glsl_shader.c:4771:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_geometry_shader’: ../../../wine/dlls/wined3d/glsl_shader.c:4811:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_find_ffp_vertex_shader’: ../../../wine/dlls/wined3d/glsl_shader.c:5662:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_find_ffp_fragment_shader’: ../../../wine/dlls/wined3d/glsl_shader.c:5685:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_alloc’: ../../../wine/dlls/wined3d/glsl_shader.c:6355:5: warning: implicit declaration of function ‘newlocale’ [-Wimplicit-function-declaration] ../../../wine/dlls/wined3d/glsl_shader.c:6355:36: error: ‘LC_ALL_MASK’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c:6410:9: warning: implicit declaration of function ‘freelocale’ [-Wimplicit-function-declaration] make: *** [glsl_shader.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] ole32: fixed 3 handle leaks (Coverity)
by Dmitry Timoshkov June 10, 2013

June 10, 2013

Marcus Meissner <marcus(a)jet.franken.de> wrote: > 1030106 Resource leak > 1030105 Resource leak > 1030104 Resource leak These cases are of the kind 'freeing resources at process exit is not useful'. -- Dmitry.

2 4

Re: [PATCH 2/2] d3dxof: Handle float in binary mode and remove code that becomes useless.
by Alexandre Julliard June 7, 2013

June 7, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3dxof/parsing.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so mesh.c && touch mesh.ok mesh.c:2291: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2299: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2323: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2347: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2399: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2403: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2407: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2408: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2409: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2495: Tests skipped: D3DXCreateBox failed make: *** [mesh.ok] Error 9 -- Alexandre Julliard julliard(a)winehq.org

1 0

joy.cpl icon
by Joel Holdsworth June 7, 2013

June 7, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 For some reason, since I send in my icon for joy.cpl, it doesn't appear in the control panel - still only the wine glass fallback icon. Does anyone know why this is? I guess it will be a one line fix. Unfortunately I don't have time do this myself, but if someone has time, I think it would be worth resolving before the release. Best Regards Joel Holdsworth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRsFMgAAoJEIsWlGmq62Igf70H/jE97ibCOk2j2BMizaGkGzyW nAGQD0R9E3GXfdnGaUxzn21OPq3cu3/FapiTw1eN5Ns7Ec4b1cBLJ+ana1ElLIrO bz+yYGedqD0bYZq0D80MPE7t9S6jGy7939XGvkNLSMcZVOaBy8E2iroVnAILMNSB w1zbPhDXQGjHjRyBuYHZMhXTPhDz73s8+6JS7lZvCTaMmnF/dzZ6tW7DyTUIBdwx u3zUXn/j4nTNuNw3xGtK5wSYUZdNWxEx8RvQ1JrfuR9CWwLILTfFLB9d7OnSH/Rg 0sxBkjpSkOck25NN9gdQwdud0ERda1JurongrxUSHDXBBxghJ9BIk/gd+ZpP4cQ= =Hnk+ -----END PGP SIGNATURE-----

2 2

Re: wined3d: Add Mobility Radeon HD 4200
by Rico Schüller June 6, 2013

June 6, 2013

On 30.05.2013 23:51, Kyle Luna wrote: > + {HW_VENDOR_AMD, CARD_AMD_RADEON_HD4200M, "ATI Mobility Radeon HD 4200", DRIVER_AMD_R600, 256 }, I think there are versions available which have only 128MB of graphics memory, see: http://de.wikipedia.org/wiki/ATI-Radeon-HD-4000-Serie (de) http://www.notebookcheck.com/ATI-Radeon-HD-4200.20492.0.html (de) I couldn't find this information on the English pages. I'm not sure how much we care about this. Cheers Rico

2 1

Re: user32: Fix icon extraction from non-native PE executables.
by Alexandre Julliard June 6, 2013

June 6, 2013

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/user32/exticon.c | 202 ++++++++++++++++++++++++++++++++----------------- > 1 file changed, 133 insertions(+), 69 deletions(-) > > diff --git a/dlls/user32/exticon.c b/dlls/user32/exticon.c > index 5b9d681..e6e97d5 100644 > --- a/dlls/user32/exticon.c > +++ b/dlls/user32/exticon.c > @@ -251,6 +251,127 @@ static BYTE * ICO_GetIconDirectory( LPBYTE peimage, LPicoICONDIR* lplpiID, ULONG > return 0; > } > > +/* caller must make sure we have a PE image */ > +static BOOL get_nt_header( const BYTE *image, const IMAGE_NT_HEADERS32 **nt32, const IMAGE_NT_HEADERS64 **nt64 ) > +{ > + const IMAGE_DOS_HEADER *dos = (const IMAGE_DOS_HEADER *)image; > + const IMAGE_NT_HEADERS *nt = (const IMAGE_NT_HEADERS *)(image + dos->e_lfanew); > + > + if (nt->OptionalHeader.Magic == IMAGE_NT_OPTIONAL_HDR32_MAGIC) > + { > + *nt32 = (const IMAGE_NT_HEADERS32 *)nt; > + *nt64 = NULL; > + return TRUE; > + } > + else if (nt->OptionalHeader.Magic == IMAGE_NT_OPTIONAL_HDR64_MAGIC) > + { > + *nt64 = (const IMAGE_NT_HEADERS64 *)nt; > + *nt32 = NULL; > + return TRUE; > + } > + return FALSE; > +} > + > +static const IMAGE_SECTION_HEADER *get_next_section_header( const BYTE *image, WORD *index ) > +{ > + const IMAGE_NT_HEADERS32 *hdr32; > + const IMAGE_NT_HEADERS64 *hdr64; > + const IMAGE_SECTION_HEADER *section = NULL; > + > + if (!get_nt_header( image, &hdr32, &hdr64 )) return NULL; > + if (hdr32) > + { > + if (*index >= hdr32->FileHeader.NumberOfSections) return NULL; > + section = (const IMAGE_SECTION_HEADER *)((char *)hdr32 + sizeof(DWORD) + > + sizeof(IMAGE_FILE_HEADER) + hdr32->FileHeader.SizeOfOptionalHeader + > + *index * sizeof(IMAGE_SECTION_HEADER)); > + } > + else > + { > + if (*index >= hdr64->FileHeader.NumberOfSections) return NULL; > + section = (const IMAGE_SECTION_HEADER *)((char *)hdr64 + sizeof(DWORD) + > + sizeof(IMAGE_FILE_HEADER) + hdr64->FileHeader.SizeOfOptionalHeader + > + *index * sizeof(IMAGE_SECTION_HEADER)); > + } > + if (section) (*index)++; > + return section; > +} You probably want to use RtlImageDirectoryEntryToData and friends instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Disable Ctrl-C interrupt
by Jason Edmeades June 6, 2013

June 6, 2013

Hi Hugh, Thanks for looking at this issue with wine's cmd I do not think this patch is enough - From memory (I once tried something similar) the problem with resolving it the way you have is you then lose the ability of breaking out of a batch program. I think the right solution needs an actual handler which resets back to the command prompt mode, optionally asking something like whether you want to end the program or not (with a no continuing from where it left off, with consideration around for loops etc!). I would suggest it's better to allow control c for now rather than get into situations you cannot terminate Jason

2 1

Re: oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types
by Nikolay Sivov June 6, 2013

June 6, 2013

On Thu, Jun 6, 2013 at 9:55 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > Corrects a spelling mistake too and > > Changelog: > oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types > > > Best Regards > Alistair Leslie-Hughes > > > > - { extemdedW, DBPROP_INIT_PROVIDERSTRING, DBPROPOPTIONS_REQUIRED, VT_BSTR }, + { extemdedW, DBPROP_INIT_PROVIDERSTRING, DBPROPOPTIONS_OPTIONAL, VT_BSTR }, { gen_timeout, DBPROP_INIT_GENERALTIMEOUT, DBPROPOPTIONS_OPTIONAL, VT_I4 }, - { initcatW, DBPROP_CATALOGLOCATION, DBPROPOPTIONS_OPTIONAL, VT_BSTR }, + { initcatW, DBPROP_CATALOGLOCATION, DBPROPOPTIONS_OPTIONAL, VT_I4 }, How it's an integer? Catalog location is a path basically. Regarding provider string, could you please add a test for this flag?

1 0

Re: [PATCH 2/3] oleaut32/tests: Add save/load tests for created typelibs
by Marvin June 5, 2013

June 5, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25849 Your paranoid android. === WXPX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === WVISTAX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === W7PROX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === TEST64_W7SP1 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8

1 0

Re: ole32: Add a basic OLE client/server test suite. Take 2.
by Dmitry Timoshkov June 5, 2013

June 5, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

2 7

Re: [PATCH 3/5] wined3d: Pass a wined3d_resource_desc structure to wined3d_texture_create_cube().
by Stefan Dösinger June 5, 2013

June 5, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-06-05 11:06, schrieb Henri Verbeet: > + desc.width = edge_length; + desc.height = edge_length; + > desc.depth = 1; Wouldn't it make sense to either set desc.height = 1 or desc.depth = edge_length? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRrwNtAAoJEN0/YqbEcdMwLkoP/jN3ooH3ur4ZLMgSc96VT+WR b+EcwCmK1yigPrY04UPiHmSVSS/g9bgR/BsVoQB9d6Fa2UfFeDEGGgOYdVOE6/9P guRWs6RAMTv4AfuDCjmRC3h2fO0nigg3sLkmvqG5qZF8hmGbItijB5zREWHys3Bk kedPMQaWXWuq9wwHa7ZM1B3wcMiZsxqfcyitFa1FsB7LvbLHIYuMzNQrViObGvT5 75J1Ux/WmFu9ZKTvWjIyFzhWg9oqeHPpB1lXgj4w3ONkOa0Rw27EUsxHRTlGiYm+ 4qGyvclsE1Ep2A2NK/kCUU1SuxeSP/bW38P9Lc8J/xNb8Si8zNu2VApTYjOIOk9q 3wHKgU0MuRRnw5ophMM9xNhIT/lt+0FilNZYosvEul+A0tAhncthCege0ZBRIeSf ZKlRGrInBMSy59BJwxVvPxaF702M0xHdkpKEMnML1NYCRg9+gbm862y/KRczvBxL kRWs6AIBr0247voTHvhRBJTtEanCeKP+qGLoatNVimPFaEDnSj9xxHIA+4XaThPW 2A+WjSPc7ni0Z8IKGQB9hOku0ZKvX2BJIAXiFm1KQW23psqUHF5CTR3w48yG7Dmh pm8SETIud6SwakKTW5ikp5ObjLYdM1Z8M8hNIkU64O8k7+aSX3hAqKW2shC6d/xm REcwzCU6NhmbDWgC5epH =tH28 -----END PGP SIGNATURE-----

2 1

Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.
by Rico Schüller June 5, 2013

June 5, 2013

On 05.06.2013 08:48, Christian Costa wrote: > bone = &This->bones[bone_num]; > + /* Decrement refcounts of vertices previously influenced */ > + for (i = 0; i < bone->num_influences; i++) > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > bone->num_influences = num_influences; > HeapFree(GetProcessHeap(), 0, bone->vertices); > HeapFree(GetProcessHeap(), 0, bone->weights); > bone->vertices = new_vertices; > bone->weights = new_weights; > + /* Increment refcounts of vertices newly influenced */ > + for (i = 0; i < bone->num_influences; i++) > + { > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > + } Please have a look at the code style (brackets {} at the for loops?). It should be a bit more consistent. Also I think an increment (as said in the comment) is something like "This->vertices_refcounts[bone->vertices[i]]++;". Maybe you could add a test to verify if the comment or the code is correct? Cheers Rico

2 1

Re: [PATCH 1/2] server: Don't create new handle when DUP_HANDLE_CLOSE_SOURCE is used if possible (try2)
by Alexandre Julliard June 5, 2013

June 5, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -890,6 +890,7 @@ struct rawinput_device > obj_handle_t handle; /* duplicated handle in dst process */ > int self; /* is the source the current process? */ > int closed; /* whether the source handle has been closed */ > + int reused; /* whether the source handle has been reused */ I don't think you need an extra flag, there's nothing the client has to do differently in that case (the warning is mostly cosmetic anyway). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: api-ms-win-core-localregistry-l1-1-0: add stub dll
by Charles Davis June 4, 2013

June 4, 2013

On Jun 4, 2013, at 12:15 PM, Austin English wrote: > diff --git a/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > new file mode 100644 > index 0000000..cc15d4e > --- /dev/null > +++ b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > @@ -0,0 +1,40 @@ > +@ stub RegCloseKey Why don't you just forward them to their implementations in advapi32? Is there something oddly different about these functions that I don't know about? Chip

2 1

Re: bugzilla: Change no bugs found message
by Christian Costa June 4, 2013

June 4, 2013

Hi, Minor but shouldn't it be "bug" instead "bugs"? Christian

2 2

Re: [PATCH 1/8] winemac: Don't unminimize a window on first activation during start-up.
by Dmitry Timoshkov June 4, 2013

June 4, 2013

Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/cocoa_app.h | 2 ++ > dlls/winemac.drv/cocoa_app.m | 3 ++- > 2 files changed, 4 insertions(+), 1 deletions(-) I wonder, do you actually run 'make test' in dlls/user32/tests with your changes? My guess is that you don't. -- Dmitry.

2 1

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker June 4, 2013

June 4, 2013

On Tue, 2013-06-04 at 10:16 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > After suggestion by Hans, do it in the helper ... especially > as the other external callers do not initialize schemes either. I also said that you shouldn't touch the parameter on error :) The other callers pass a pointer to a user variable and the attached test confirms that native doesn't touch it.

1 0

testbot and NT4
by Ann and Jason Edmeades June 4, 2013

June 4, 2013

Hiya, Its been a while since I did some cmd work and noticed there were some new bugs so am doing some fiddling. The real pain for me was always keeping the tests passing on nt4, so I noted with relief/surprise that the testbot doesnt have an NT4 VM anymore. Is it correct that there is no longer a requirement for tests to pass on NT4 for submission (if it's required, I really need a nt4 testbot!) If not, is there any objection to removing the numerous hacks in the test suite so they run on NT4? Thanks, Jason

6 6

Re: [PATCH] mscms: Use lcms2, when available [try 2]
by Hans Leidekker June 4, 2013

June 4, 2013

On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote: > try2: > import the unchanged icc34.h from the lcms (v1) dev. package. > (Do we need to add a Wine LGPL licence header for icc34.h?) > > The plan is to remove this include, when changing Wine > to use the new getter/setter functions of lcms2 > (After the release of Wine-1.6) My plan was to switch to lcms2 soon *after* the release of Wine 1.6. I studied the API some more and my conclusion is that while it doesn't have all we need (specifically cmsReadRawTag and cmsWriteRawTag don't do what we want), we can avoid importing the icc34.h header. I'm not in favor of adding temporary workarounds. If distributions want to drop support for lcms1 in 1.6 I'd suggest that they backport the patches.

3 4

Re: Add tests for ntdll event functions
by Marvin June 3, 2013

June 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25813 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Add tests for ntdll event functions
by Andrew Cook June 3, 2013

June 3, 2013

While implemeting NtQueryEvent i stumbled across an odd permissions issue, which is really what this patch tests if ((event = create_event( root, &name, req->attributes, req->manual_reset, req->initial_state, sd ))) { if (get_error() == STATUS_OBJECT_NAME_EXISTS) reply->handle = alloc_handle( current->process, event, req->access, req->attributes ); else reply->handle = alloc_handle_no_access_check( current->process, event, req->access, req->attributes ); release_object( event ); } when creating an event, the handle is allocated with alloc_handle_no_access_check, which does not call event_map_access this causes event_op and event_query to fail, as the handle only has GENERIC_ALL, not the actual event permissions, which does not match windows behaviour (or at least windows 7 anyway), On 04/06/13 11:13, Andrew Cook wrote: > --- > dlls/ntdll/tests/Makefile.in | 1 + > dlls/ntdll/tests/event.c | 69 > ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 70 insertions(+) > create mode 100644 dlls/ntdll/tests/event.c > > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index 10d6674..a44b880 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -7,6 +7,7 @@ C_SRCS = \ > directory.c \ > env.c \ > error.c \ > + event.c \ > exception.c \ > file.c \ > generated.c \ > diff --git a/dlls/ntdll/tests/event.c b/dlls/ntdll/tests/event.c > new file mode 100644 > index 0000000..f29abc3 > --- /dev/null > +++ b/dlls/ntdll/tests/event.c > @@ -0,0 +1,69 @@ > +/* > + * Unit test suite for event functions > + * > + * Copyright 2005 Robert Shearman > + * Copyright 2005 Vitaliy Margolen > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > 02110-1301, USA > + */ > + > +#include "ntdll_test.h" > +#include "winternl.h" > +#include "winnt.h" > + > +static NTSTATUS (WINAPI *pNtCreateEvent) ( PHANDLE, ACCESS_MASK, const > POBJECT_ATTRIBUTES, BOOLEAN, BOOLEAN); > +static NTSTATUS (WINAPI *pNtPulseEvent) ( HANDLE, PULONG ); > +static NTSTATUS (WINAPI *pNtQueryEvent) ( HANDLE, > EVENT_INFORMATION_CLASS, PVOID, ULONG, PULONG ); > +static NTSTATUS (WINAPI *pNtClose) ( HANDLE ); > +static VOID (WINAPI *pRtlInitUnicodeString)( PUNICODE_STRING, > LPCWSTR ); > + > +START_TEST(event) > +{ > + HANDLE Event; > + NTSTATUS status; > + UNICODE_STRING str; > + OBJECT_ATTRIBUTES attr; > + EVENT_BASIC_INFORMATION info; > + HMODULE hntdll = GetModuleHandleA("ntdll.dll"); > + HMODULE hkernel32 = GetModuleHandleA("kernel32.dll"); > + static const WCHAR eventName[] = > {'\\','B','a','s','e','N','a','m','e','d','O','b','j','e','c','t','s','\\','t','e','s','t','E','v','e','n','t',0}; > + > + if (!hntdll) > + { > + skip("not running on NT, skipping test\n"); > + return; > + } > + > + pNtCreateEvent = (void *)GetProcAddress(hntdll, "NtCreateEvent"); > + pNtQueryEvent = (void *)GetProcAddress(hntdll, "NtQueryEvent"); > + pNtPulseEvent = (void *)GetProcAddress(hntdll, "NtPulseEvent"); > + pNtClose = (void *)GetProcAddress(hntdll, "NtClose"); > + pRtlInitUnicodeString = (void *)GetProcAddress(hntdll, > "RtlInitUnicodeString"); > + > + pRtlInitUnicodeString(&str, eventName); > + InitializeObjectAttributes(&attr, &str, 0, 0, NULL); > + > + status = pNtCreateEvent(&Event, GENERIC_ALL, &attr, 0, 0); > + ok( status == STATUS_SUCCESS, "NtCreateEvent failed %08x\n", status ); > + > + status = pNtPulseEvent(Event, 0); > + todo_wine ok( status == STATUS_SUCCESS, "NtPulseEvent failed > %08x\n", status ); > + > + status = pNtQueryEvent(Event, EventBasicInformation, &info, > sizeof(info), NULL); > + todo_wine ok( status == STATUS_SUCCESS, "NtQueryEvent failed > %08x\n", status ); > + > + status = pNtClose(Event); > + ok( status == STATUS_SUCCESS, "NtClose failed %08x\n", status ); > +}

1 0

Re: How to stop gecko and mono popups while git bisecting?
by Dan Kegel June 3, 2013

June 3, 2013

Or run https://winezeug.googlecode.com/svn/trunk/install-addons.sh

1 0

How to stop gecko and mono popups while git bisecting?
by Alan W. Irwin June 3, 2013

June 3, 2013

I just finished a git bisect to establish the cause of the git regression given by http://bugs.winehq.org/show_bug.cgi?id=33715. My detailed report concerning the result of the bisect appears there, but I have an additional question concerning the git bisect process itself. I pretty much follow the recommendations in http://wiki.winehq.org/RegressionTesting, but I like to completely remove my WINEPREFIX directory as the first step in my bisect test script to eliminate the possibility that some unclean cached result there is causing issues. But after a particular version of wine is built, that test script goes on to test it using wineconsole which has to populate WINEPREFIX itself (which is fine) since I removed it for a reason, but that step is accompanied by some popups concerning what I want to do about downloading mono (not available on Debian testing) and gecko (available on Debian testing, but I haven't figured out how to make the ./configure step of the wine build recognize that). I don't mind the popups, but I do mind having to answer the questions posed by them (say through the night) as the automated git bisect proceeds. For the case where wineconsole populates the WINEPREFIX directory for the first time, is there a way to configure wine or run wineconsole so those popups that require me answering a question can be eliminated? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

2 2

Re: dinput: Remove error-prone new joystick code
by Alexandre Julliard June 3, 2013

June 3, 2013

"Bassi, Gurmail" <Gurmail.Bassi(a)mottmac.com> writes: > The joystick code I submitted in Wine patch 95617 seems to be causing problems to some users with both hardware (Wacom Cintiq) and software (Lord of the Rings Online) - see Wine bugs 33496 & 33593 > > This patch removes the offending code, until the cause can be fully investigated and a new patch issued if necessary Please fix the code instead of removing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] kernet32: Add DuplicateHandle tests with DUPLICATE_CLOSE_SOURCE flag
by Alexandre Julliard June 3, 2013

June 3, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/kernel32/tests/process.c | 83 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) You should probably add some tests that first close lower-numbered handles, to see if it may not be simply allocating the first free one instead. -- Alexandre Julliard julliard(a)winehq.org

1 0