June 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 27, 2013

Oct. 27, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Bug 24018 which appears to be a showstopper for running Cygwin on Wine
by Alan W. Irwin July 5, 2013

July 5, 2013

Andrey Turkin has stated at http://bugs.winehq.org/show_bug.cgi?id=24018 that this is really a Cygwin bug. I frankly don't understand the technical details but his current test (an infinite loop with Cygwin fork calls) may need some beefing up to convince the Cygwin developers they have introduced a regression. The reason why I mention a Cygwin regression is the winetricks script mentions bug 24018 and works around it by downloading an old version of the Cygwin installer. I haven't tried that myself yet, but if that workaround still works, then this is evidence that the issue is a Cygwin regression which is an important consideration when reporting this issue to the Cygwin developers. Andrey Turkin was asked at http://bugs.winehq.org/show_bug.cgi?id=24018 to report the issue to Cygwin, but my search of the Cygwin mailing list archive didn't find any post from him and only found one extremely casual (an aside to a completely different thread) mention (http://sourceware.org/ml/cygwin/2013-06/msg00471.html) from a different wine developer of bug 24018 with no response to that mention. I currently have no experience with Cygwin and my only real interest in Cygwin on Wine is it theoretically provides an alternative build platform to my present successful work with the combination of MinGW, MSYS, and Wine as a Windows build platform. But I haven't even been able to get started with Cygwin on Wine because of this showstopping bug. Therefore, I am mentioning the situation here in the hope that some wine developer on this list with some knowledge of Cygwin will take the responsibility of making a proper bug report to the Cygwin mailing list (which according to http://cygwin.com/problems.html is the correct place to report Cygwin bugs) including the evidence that the issue is a Cygwin regression (assuming investigation of older Cygwin versions with Turkin's test supports that conclusion). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

7 26

Re: Wine release 1.6-rc4
by Neumann, A. D. July 2, 2013

July 2, 2013

Hello, I changed my email address. Please send this information to: info.adneumann(a)t-online.de Thank you! D. Neumann Am 28.06.2013 22:02, schrieb Alexandre Julliard: > The Wine development release 1.6-rc4 is now available. > > What's new in this release (see below for details): > - Bug fixes only, we are in code freeze. > > The source is available from the following locations: > > http://prdownloads.sourceforge.net/wine/wine-1.6-rc4.tar.bz2 > http://mirrors.ibiblio.org/wine/source/1.6/wine-1.6-rc4.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/download > > You will find documentation on http://www.winehq.org/documentation > > You can also get the current source directly from the git > repository. Check http://www.winehq.org/git for details. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > ---------------------------------------------------------------- > > Bugs fixed in 1.6-rc4 (total 38): > > 7597 No sound with OSS driver in C&C3 > 11224 Throw In (Blitz Basic game) has a memory access violation > 11675 Flatout 2 demo, Battlefield 2 demo, many others need native d3dx9_36.D3DXCreateEffect* > 12771 Multiple graphic problems in "The Witcher" > 13314 Winevdm displays a window when running Civilization I > 13662 dogfood: xchat-2.6.2 is very slow, while updating the window > 14318 Michisoft Reader Studio v1.5a fails to produce LIT file from HTML > 16325 incorrect font rendering for CJK programs > 16784 Babylon 7: Trial mode expires after installation > 18930 IDA Pro: Failing to allocate an enormous image > 20769 crash when exiting Microsoft Flight Simulator 98 > 20771 the menu bar doesn't work in M. Flight Simulator 98 > 21103 Presentation 14.2 (Neurobehavioral Systems): crashes when displaying video output > 21827 Photoshop 7, Slider disapear > 22291 DC++ hangs on exit > 23504 Subpixel Font rendering wrong for font MS Sans Serif > 23687 err:seh:setup_exception_record stack overflow when start Proteus7 Ares > 23945 Textures are not properly rendered in Deus-Ex:Invisible War > 24230 "Psalmen - Lieder des Lebens" crashes when clicking Next in settings pane > 24796 DIY Kyoto's Holmes fails to start > 25125 Can only print to the default CUPS printer from Visio 5 Professional > 25605 The Settlers 3: Save as bitmap crashes world editor > 26646 Worms Reloaded: sound choppy without hardware sound = emulation > 27658 3dvia plugin installer crashes > 28495 Runes of Magic: sometimes mouse cursor freezes > 29897 Lord Of the Rings Online Slow/Freezes > 29959 Zed: 3D Preview window is blank or doesn't open. > 30578 Disassembly not in fixed-width font in IDA Pro 6.2 demo > 30897 Europa Universalis III demo crashes while 'Loading Map-Sprites...' without native d3dxof > 31729 cl.exe: stack overflow with certain long command lines > 31772 NtQuerySystemInformation doesn't fill ReturnLength properly with SystemProcessInformation > 31812 Silverlight 4.x/5.x windows have repainting problems > 31908 Garena Blackshot does login > 32820 Offline rekening overzicht, orov doesn't work > 33283 Configuration of WM_NAME is delayed for virtual desktop > 33753 Titan Quest : Multiplayer not working > 33865 Regression in a specialized program > 33883 Scirra httpapi.dll error trying to Run a game > > ---------------------------------------------------------------- > > Changes since 1.6-rc3: > > Alexandre Julliard (22): > gdi32: Cache the font smoothing parameters. > kernel32: FormatMessage precision arguments are integers. > comdlg32: Add support for the CF_NOVERTFONTS flag. > clock: Don't offer vertical fonts in the font dialog. > notepad: Don't offer vertical fonts in the font dialog. > winecfg: Don't offer vertical fonts in the font dialog. > wineconsole: Don't offer vertical fonts in the font dialog. > winefile: Don't offer vertical fonts in the font dialog. > wordpad: Don't offer vertical fonts in the font dialog. > make_unicode: Move codepage file output code to a common routine and make default characters configurable. > libwine: Add support for codepage 10001 (Mac Japanese). > libwine: Add support for codepage 10002 (Mac Traditional Chinese). > libwine: Add support for codepage 10003 (Mac Korean). > libwine: Add support for codepage 10008 (Mac Simplified Chinese). > libwine: Add support for codepage 10010 (Mac Romanian). > libwine: Add support for codepage 10017 (Mac Ukrainian). > libwine: Add support for codepage 10021 (Mac Thai). > libwine: Add support for codepage 10082 (Mac Croatian). > krnl386: Create a new console for DOS binaries. > winevdm: Make it a GUI application to avoid a spurious console. > user32: Fetch the window menu again after sending initialization messages. > advapi32: Fix ReportEvent parameter types in the spec file. > > Andrew Eikum (4): > winbase.h: Add GetFileInformationByHandleEx. > oleaut32: Register the typelib's path without WOW64 redirection. > oleaut32: Load referenced typelibs in the same architecture. > oleaut32: Use typelib's pointer size, not system's. > > André Hentschel (15): > oleaut32/tests: Get rid of IS_ANCIENT in vartest. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in vartest. > oleaut32/tests: Don't use autoheader styled define in vartest. > oleaut32/tests: Get rid of IS_ANCIENT in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_DECIMAL in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_CY in vartype. > oleaut32/tests: Don't use autoheader styled defines in vartype. > oleaut32/tests: Don't use autoheader styled defines in varformat. > oleaut32/tests: Get rid of IS_ANCIENT in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_DECIMAL in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_R8 in safearray. > oleaut32/tests: Don't use autoheader styled defines in safearray. > oleaut32/tests: Use BOOL instead of int when appropriate. > > Austin English (1): > winex11.drv: Print the architecture when showing driver problems. > > Bruno Jesus (2): > po: Update Brazilian Portuguese translation. > po: Update Brazilian Portuguese translation. > > Caibin Chen (1): > po: Update Simplified Chinese Translation. > > Christian Costa (1): > d3dxof: Add support for case sensitive legacy type indexColor. > > Dmitry Timoshkov (4): > kernel32/tests: Add a test for VirtualAlloc called on a mapped PE section. > kernel32/tests: Add more VirtualAlloc and VirtualProtect tests. > kernel32: Correct HeapFree .spec parameter type. > ntdll: Correct RtlFreeHeap .spec parameter type. > > Erich Hoover (1): > ws2_32: Fix interface-bound filter to accept locally generated targeted packets. > > Frédéric Delanoy (1): > tools: Update winemaker manpage French translation. > > Hans Leidekker (3): > ws2_32/tests: Avoid races. > dssenh/tests: Fix test failures on 64-bit Vista. > winhttp/tests: Add some tests for WinHttpDetectAutoProxyConfigUrl. > > Huw Davies (1): > comdlg32: Don't call the callback if it's not set. > > Jacek Caban (5): > ole32: Don't call AddConnection for weak references. > ole32/tests: Added tests for external connections stored in ROT. > oleaut32/tests: Added external connections tests for MSHLFLAGS_TABLEWEAK marshaling. > mshtml: Don't declare empty interface for nsCycleCollectionISupports. > secur32: Don't use deprecated gnutls_certificate_credentials. > > Julian Rüger (1): > server: Update German translation of manpage. > > Ken Thomases (2): > winemac: Dispatch key events directly to window to be sure to get key-up events. > winemac: Fix ordering of windows owned by same owner when on inactive desktop space. > > Marcus Meissner (8): > dbghelp: Free root in error case (Coverity). > dbghelp: Free srcpath in stabs handling (Coverity). > gdi32: Close handle in error path (Coverity). > gdi32: Close handle in mfdrv (Coverity). > msvf32: Fixed incorrect sizeof (Coverity). > ole32: LeaveCriticalSection in one exit case (Coverity). > ole32: Fixed bad sizeof()s in composite moniker (Coverity). > winmm: Fix incorrect parameter for test debug (Coverity). > > Matteo Bruni (2): > wined3d: Fix handling of cnd instruction with coissue flag. > d3d9/tests: Improve cnd instruction test. > > Michael Stefaniuc (1): > po: Update the Romanian translation. > > Mykola Zadorozhnyy (1): > po: Update Ukrainian translation. > > Petr Kočandrle (1): > po: Fix some Czech spelling errors. > > Piotr Caban (1): > msvcrt: Added _wcsicmp_l implementation. > > Qian Hong (2): > msctf: Added stub TF_CreateLangBarItemMgr. > include: Added missing declaration for some msctf APIs. > > Roger Koot (1): > po: Updated Dutch translation. > > Stefan Leichter (1): > msvcp100/tests: Fix dynamically loaded functions for platform arm. > > Volkan Gezer (1): > po: Updated Turkish Translation. > > -- > Alexandre Julliard > julliard(a)winehq.org >

2 1

Duplicate UUID in oleaut32:tmarshal test
by Thomas Faber July 2, 2013

July 2, 2013

I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it complained: tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [ Interface 'ITestSecondDisp' ] This doesn't seem like it's intentional. But just giving ITestSecondDisp a new uuid causes the following test failures on Windows: tmarshal.c:1861: Test failed: external_connections = 2 tmarshal.c:1864: Test failed: external_connections = 2 tmarshal.c:192: Test failed: fLastReleaseCloses = 1 I could try to figure this out, but it's probably better if someone familiar with the subject could have a look instead. (also, assuming this is a bug in the test, we might want to add that check to widl, it seems pretty useful ;]) Thanks, Thomas

2 1

Re: [patch] full translation update for 16 rc4
by Frédéric Delanoy July 2, 2013

July 2, 2013

On Sun, Jun 30, 2013 at 6:08 AM, 中川祥 <matyapiro31(a)gmail.com> wrote: > Hi, please resubmit this patch with your full name transliterated in English.

2 1

Re: widl: Do not generate C structure for empty interfaces. (try 2)
by Jacek Caban July 2, 2013

July 2, 2013

Hi Thomas, I tested what midl does in this case and I think the solution should be different. When I tried to compile an empty interface, I got an error saying that '[object] interface must derive from another [object] interface'. That requirement is mostly enough to avoid empty vtbl. I was wondering how IUnknown is handled by midl (since it doesn't derive from any other iface). It seems like it's a simple name-based special case. When I renamed the interface to IUnknown, it compiled fine and generated vtbl the same as current widl (that is an empty struct). That said, if such interfaces are just obscure special case, I would say we shouldn't care. We may easily avoid them (I just sent a patch avoiding it in mshtml). If you want a better solution to avoid such problems in the future, I would suggest adding an error, like midl does. This will, however, require some more changes in Wine. At least MSHTML already has an interface identical to IUnknown (nsISupports), which would cause the error. This should be solvable with some tricks. Thanks, Jacek

2 2

Re: winex11.drv: When skipping unknown attribute also skip it's value.
by Michael Stefaniuc June 30, 2013

June 30, 2013

On 06/30/2013 11:29 PM, Ričardas Barkauskas wrote: > --- > dlls/winex11.drv/opengl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > 0001-winex11.drv-When-skipping-unknown-attribute-also-skip-.txt > > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > index 0f937cb..c7f78c5 100644 > --- a/dlls/winex11.drv/opengl.c > +++ b/dlls/winex11.drv/opengl.c > @@ -921,7 +921,7 @@ static int ConvertAttribWGLtoGLX(const int* iWGLAttr, int* oGLXAttr, struct wgl_ > TRACE("pAttr[%d] = GLX_RGBA_UNSIGNED_FLOAT_TYPE_EXT: %x\n", cur, pop); > break ; > default: > - FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur]); > + FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur++]); Side effects in the debug output functions should be avoided. > break; > } > ++cur; > bye michael

1 0

Re: [patch]update po/ja.po for wine ver.1.6-rc4
by Akihiro Sagawa June 30, 2013

June 30, 2013

Hi Akira, Thank you for your contribution. Regarding Japanese translation, please consider following things. Firstly, those untranslated terms cannot be fully translated into Japanese. This is the reason why I didn't translate 100% message. In po file, please keep untranslated if we don't need to translate the message. Secondly, I don't translate the message before nearly 100% sure about message context. We should learn the conetext and test how the message is shown in the application. In my opinion, untranslated English terms are easy to search web pages. This helps a user who don't familiar to technical words. If we translate to ill-defined message, a user cannot help himself/herself with search engines. Thirdly, these untranslated messages are not so important for average applications... Did you notice these untranslated messages on some applications? Anyway, I continue to commented on this. On Sun, 30 Jun 2013 22:03:21 +0900, Akira Nakagawa wrote: > #: crypt32.rc:83 > msgid "Serialized Signature Serial Number" > -msgstr "" > +msgstr "整序された署名の順番" This translated message doesn't mean "Serial Number". > #: crypt32.rc:84 > msgid "Principal Name" > -msgstr "" > +msgstr "主要名称" "主要名称" looks like Chinese term. Not used in Japan at all. How about プリンシパル名? > #: crypt32.rc:94 > msgid "Policy Mappings" > -msgstr "" > +msgstr "ポリシーの表示" Mappings doesn't mean 表示 (=display?). > #: crypt32.rc:96 > msgid "Cross-Certificate Distribution Points" > -msgstr "" > +msgstr "複数の署名の配布ポイント" Cross-Certificate doesn't mean 複数の署名 (=multiple signatures?). > #: crypt32.rc:98 > msgid "Application Policy Mappings" > -msgstr "" > +msgstr "アプリケーションのポリシーの表示" Mappings doesn't mean 表示. (ditto) Please avoid ～の～の～ form. > #: crypt32.rc:99 > msgid "Application Policy Constraints" > -msgstr "" > +msgstr "アプリケーションのポリシーの制約" ditto. > #: crypt32.rc:107 > msgid "PKCS 7 Signed" > -msgstr "" > +msgstr "署名付きのPKCS 7" PKCS #7 is Cryptographic Message Syntax Standard and updated in RFC 5652. RFC 5652 defines six content types: data, signed-data, enveloped-data, digested-data, encrypted-data, and authenticated-data. So, "PKCS 7 Signed" means the second data type. > #: crypt32.rc:108 > msgid "PKCS 7 Enveloped" > -msgstr "" > +msgstr "保護されたPKCS 7" ditto. PKCS 7 is not enveloped. The data is enveloped by PKCS 7. > #: crypt32.rc:109 > msgid "PKCS 7 Signed Enveloped" > -msgstr "" > +msgstr "保護された署名付きのPKCS 7" ditto. > #: crypt32.rc:110 > msgid "PKCS 7 Digested" > -msgstr "" > +msgstr "ダイジェストのPKCS 7" ditto. > #: crypt32.rc:111 > msgid "PKCS 7 Encrypted" > -msgstr "" > +msgstr "暗号化されたPKCS 7" ditto. > #: crypt32.rc:112 > msgid "Previous CA Certificate Hash" > -msgstr "" > +msgstr "以前のCA 署名のハッシュ" Certificate doesn't mean "署名" (signature). A space character is needed before "CA". > #: crypt32.rc:113 > msgid "Virtual Base CRL Number" > -msgstr "" > +msgstr "仮想CRLナンバー" This message doesn't contain "Base" term. A space character is needed both sides of "CRL". > #: crypt32.rc:114 > msgid "Next CRL Publish" > -msgstr "" > +msgstr "次のCRL 公開" A space character is needed before "CRL". > #: crypt32.rc:119 > msgid "Dummy Signer" > -msgstr "" > +msgstr "ダミーの署名" Signer is a person or an authority. Please don't confuse signer with sign. > #: crypt32.rc:122 > msgid "Enforce Certificate Chain Policy" > -msgstr "" > +msgstr "証明書チェーンのポリシーを適用" Enforce is more powerful word. > #: crypt32.rc:193 > msgid "End Entity" > -msgstr "" > +msgstr "終了値" In this case "End" might not mean closure. This might mean "End user"'s end. > #: cryptdlg.rc:29 > msgid "Policy Qualifier Info" > -msgstr "" > +msgstr "ポリシーの修飾子情報" This message doesn't need space between words. > #: cryptui.rc:298 > msgid "Personal Information Exchange/PKCS #12 (*.pfx; *.p12)" > -msgstr "" > +msgstr "個人情報交換ファイル/PKCS #12 (*.pfx; *.p12)" "個人情報交換ファイル" isn't commonly used term. Where is the source of this term? I searched this term with google, only 9 pages are found. But "Personal Information Exchange" is used over 47,000 pages --- of course, I limited to Japanese pages. Thus I ask you to keep this term untranslated. > #: cryptui.rc:405 > msgid "&DER-encoded X.509 (*.cer)" > -msgstr "&DER符号化された X.509 (*.cer)" > +msgstr "DER符号化された X.509(&D) (*.cer)" I think this style is redundant. > #: cryptui.rc:407 > msgid "Ba&se64-encoded X.509 (*.cer):" > -msgstr "Ba&se64符号化された X.509 (*.cer):" > +msgstr "Base64で符号化された X.509(&S) (*.cer):" ditto. > #: cryptui.rc:409 > msgid "&Cryptographic Message Syntax Standard/PKCS #7 Message (*.p7b)" > -msgstr "&Cryptographic Message Syntax Standard/PKCS #7 メッセージ (*.p7b)" > +msgstr "暗号メッセージ構文/PKCS #7 メッセージ(&C) (*.p7b)" "Standard" term is omitted. > #: cryptui.rc:413 > msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" > -msgstr "" > +msgstr "個人情報交換ファイル(&P)/PKCS #12 (*.pfx)" "個人情報交換ファイル" is not common usage. (ditto) (&P) position doesn't match previous message. > #: cryptui.rc:75 > msgid "Personal Information Exchange (*.pfx; *.p12)" > -msgstr "" > +msgstr "個人情報交換ファイル (*.pfx; *.p12)" ditto. > #: cryptui.rc:94 > msgid "Personal Information Exchange" > -msgstr "" > +msgstr "個人情報変換ファイル" Why not use 交換 for Exchange as in previous message? This message use 変換 for Exchange term. > #: cryptui.rc:158 > msgid "Personal Information Exchange (*.pfx)" > -msgstr "" > +msgstr "個人情報変換ファイル (*.pfx)" ditto. ------------------- Following shell directory names are not translated in Windows Vista Japanese edition. Wine follows Vista's notation. We discussed about this two years ago [1]. [1] http://www.winehq.org/pipermail/wine-devel/2011-January/088390.html So, you don't need translate into Japanese for now. > #: shell32.rc:201 > msgid "My Documents" > -msgstr "" > +msgstr "マイドキュメント" > > #: shell32.rc:202 > msgid "Favorites" > -msgstr "" > +msgstr "お気に入り" > > #: shell32.rc:203 > msgid "StartUp" > -msgstr "" > +msgstr "スタートアップ" > > #: shell32.rc:204 > msgid "Start Menu" > -msgstr "" > +msgstr "スタートメニュー" > > #: shell32.rc:205 > msgid "My Music" > -msgstr "" > +msgstr "マイミュージック" > > #: shell32.rc:206 > msgid "My Videos" > -msgstr "" > +msgstr "マイビデオ" > > #: shell32.rc:207 > msgctxt "directory" > msgid "Desktop" > -msgstr "" > +msgstr "デスクトップ" > > #: shell32.rc:208 > msgid "NetHood" > -msgstr "" > +msgstr "ネットワーク内" > > #: shell32.rc:209 > msgid "Templates" > -msgstr "" > +msgstr "テンプレート" > > #: shell32.rc:210 > msgid "PrintHood" > -msgstr "" > +msgstr "プリンタ内" > > #: shell32.rc:211 winhlp32.rc:45 > msgid "History" > -msgstr "" > +msgstr "ヒストリ" > > #: shell32.rc:212 > msgid "Program Files" > @@ -7959,7 +7962,7 @@ msgstr "Program Files" > > #: shell32.rc:214 > msgid "My Pictures" > -msgstr "" > +msgstr "マイピクチャ" > > #: shell32.rc:215 > msgid "Common Files" > @@ -7967,23 +7970,23 @@ msgstr "Common Files" > > #: shell32.rc:216 shell32.rc:147 shell32.rc:232 > msgid "Documents" > -msgstr "" > +msgstr "ドキュメント" > > #: shell32.rc:217 > msgid "Administrative Tools" > -msgstr "" > +msgstr "管理者用ツール" > > #: shell32.rc:218 > msgid "Music" > -msgstr "" > +msgstr "ミュージック" > > #: shell32.rc:219 > msgid "Pictures" > -msgstr "" > +msgstr "ピクチャ" > > #: shell32.rc:220 > msgid "Videos" > -msgstr "" > +msgstr "ビデオ" > > #: shell32.rc:213 > msgid "Program Files (x86)" > @@ -7991,19 +7994,19 @@ msgstr "Program Files (x86)" > > #: shell32.rc:221 > msgid "Contacts" > -msgstr "" > +msgstr "連絡先" > > #: shell32.rc:222 winefile.rc:110 > msgid "Links" > -msgstr "" > +msgstr "リンク" > > #: shell32.rc:223 > msgid "Slide Shows" > -msgstr "" > +msgstr "スライドショー" > > #: shell32.rc:224 > msgid "Playlists" > -msgstr "" > +msgstr "プレイリスト" > > #: shell32.rc:148 taskmgr.rc:326 > msgid "Status" > @@ -8019,35 +8022,35 @@ msgstr "機種名" > > #: shell32.rc:225 > msgid "Sample Music" > -msgstr "" > +msgstr "サンプルミュージック" > > #: shell32.rc:226 > msgid "Sample Pictures" > -msgstr "" > +msgstr "サンプルピクチャ" > > #: shell32.rc:227 > msgid "Sample Playlists" > -msgstr "" > +msgstr "サンプルプレイリスト" > > #: shell32.rc:228 > msgid "Sample Videos" > -msgstr "" > +msgstr "サンプルビデオ" > > #: shell32.rc:229 > msgid "Saved Games" > -msgstr "" > +msgstr "保存済みのゲーム" > > #: shell32.rc:230 > msgid "Searches" > -msgstr "" > +msgstr "検索" > > #: shell32.rc:231 > msgid "Users" > -msgstr "" > +msgstr "ユーザー" > > #: shell32.rc:233 > msgid "Downloads" > -msgstr "" > +msgstr "ダウンロード" > ------------------- > #: netstat.rc:28 > msgid "Proto" > -msgstr "" > +msgstr "合意" Proto means protocol, but there is no enough space to display it. > #: oleview.rc:138 > msgid "Registry" > -msgstr "" > +msgstr "レジストリ" Oleview has a small issue. When I try this translation before, it can't display well if this message is Japanese. So, please verify that these messages are shown properly in the application. > #: oleview.rc:139 > msgid "Implementation" > -msgstr "" > +msgstr "実装" ditto. > #: oleview.rc:140 > msgid "Activation" > -msgstr "" > +msgstr "発動" ditto. > #: winefile.rc:109 > msgid "Index/Inode" > -msgstr "" > +msgstr "索引・Iノード" Although easily guess it, Iノード is not widely used. iノード might be preferred but more common term is "inode". inode (as Japanese technical term) is used in Wikipedia[1], Linux Japanese Manual (debugfs [2]), WDIC[3]. [1] http://ja.wikipedia.org/wiki/Inode [2] http://linuxjm.sourceforge.jp/html/e2fsprogs/man8/debugfs.8.html [3] http://www.wdic.org/w/TECH/inode Contact me for any questions. Regards, Akihiro Sagawa

1 0

Re: [PATCH] advapi32: RegDeleteKey tests
by Dmitry Timoshkov June 30, 2013

June 30, 2013

George Stephanos <gaf.stephanos(a)gmail.com> wrote: > + res = RegOpenKeyExA( hkey, "subkey1", 0, KEY_READ, &hkeysub1 ); > + ok(res != ERROR_SUCCESS, "test key found in user's classes: %d\n", res); ... > + res = RegOpenKeyExA( hklm, "subkey1", 0, KEY_READ, &hklmsub1 ); > + ok(res != ERROR_SUCCESS, "test key found in hklm: %d\n", res); Testing for res != ERROR_SUCCESS is not very useful, please check for a particular error code. Also please close successfully opened handles. -- Dmitry.

2 1

[website] Wine 1.6-rc4 freigegeben
by André Hentschel June 30, 2013

June 30, 2013

--- news/de/2013062801.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 news/de/2013062801.xml

1 0

Re: msxml3/tests: add additional conformance tests that show incorrect xpath behavior in wine
by Nikolay Sivov June 29, 2013

June 29, 2013

On 6/27/2013 11:46, John Chadwick wrote: > + /* msxml's selectNodes returns a document ordered nodelist, regardless of > + * whether or not the xpath nodelist was document ordered... */ > + ole_check(IXMLDOMNode_selectNodes(rootNode,_bstr_("ancestor-or-self::node()"), &list)); > + todo_expect_list_and_release(list, "D1 E2.D1"); Please use explicit check for return value, like ok(hr == S_OK, "...");, also you probably don't need another macro for list checking, isn't it enough to wrap expect_list_and_release() in todo_wine {} ?

1 0

Need help with a rsaenh bug
by Qian Hong June 28, 2013

June 28, 2013

Hello, I was investigating Bug 33898 [1] hardly and get a partial result, I have a special test case demonstrate the behavior of Aliwangwang [2], however, I failed to expand the special case to a common test case. My attempting is shown in [3]. The hack in [3] works for Aliwangwang, but the test case in [3] doesn't fully pass on Windows as I expected [4]. I'm not sure if there is an APP bug rather than Wine bug here, is it valid to call multiple CryptDecrypt with only one CryptDeriveKey called? If true, is it correct to assume the second CryptDecrypt call should behavior identical as the first one? If there is a Wine bug here, what is the right way to write a common test case for it? Any hints on this bug is great appreciated! Thanks very much! [1] http://bugs.winehq.org/show_bug.cgi?id=33898 [2] http://bugs.winehq.org/attachment.cgi?id=44996 [3] http://bugs.winehq.org/attachment.cgi?id=44997&action=diff [4] https://testbot.winehq.org/JobDetails.pl?Key=26138 -- Regards, Qian Hong - http://www.winehq.org

3 9

Re: ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file.
by Alexandre Julliard June 28, 2013

June 28, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 2770, hopefully it's still > acceptable during code freeze. Is there an application that's fixed by this? According to bug 2770, that app only crashes a little further on (which is of course an improvement, but not worth the risk during code freeze). -- Alexandre Julliard julliard(a)winehq.org

2 1

riched20: ITextDocument implementation
by Tiger Soldier June 28, 2013

June 28, 2013

As bug 17042 [1] reported, the IUnknown object returned by CreateTextServices() does not support ITextDocument. I believe that's the root cause of some apps crash. richole.c has a very limited implementation of ITextDocument for IRichEditOle, which is totally unreusable. I'm trying to implement ITextDocument for both ITextServices and IRichEditOle. ME_Editor type provides most of the editor functionalities, and both of ITextServices and IRichEditOle use it. So I'm going to use it to implement ITextDocument. The proposal is: struct tagReTxtDoc { IUnknown *parentObj; ME_Editor *editor; } ReTxtDoc; ReTxtDoc *CreateReTxtDoc(IUnknown *parentObj, ME_Editor *editor); void DestroyReTxtDoc(ReTxtDoc); ReTxtDoc_addRef/QueryInterface/Release -> delegate to parentObj Other ITextDocument methods: use ME_Editor to implement. This is my first time to develop WINE. Any comments/suggestions? [1] http://bugs.winehq.org/show_bug.cgi?id=17042

3 2

Re: widl: Do not generate C structure for empty interfaces.
by André Hentschel June 27, 2013

June 27, 2013

Hi, The whitespace changes are bad, please don't do that.

3 4

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin June 27, 2013

June 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0