June 2013 - Wine-Devel - list.winehq.org

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin June 27, 2013

June 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.
by Henri Verbeet June 26, 2013

June 26, 2013

On 23 June 2013 21:57, Christian Costa <titan.costa(a)gmail.com> wrote: > When D3DTA_CONSTANT is use in a texture stage, the generated shader uses variables that are not defined making thus the compilation to fail. > This patch declare these variables with the value from the related texture stage state D3D_TSS_CONSTANT. > This fixes the text display in Spin Tires demo. This patch has several issues. Even without those, it should probably be deferred anyway.

4 11

Re: server: Update German translation of manpage.
by Alexandre Julliard June 26, 2013

June 26, 2013

Julian Rüger <jr98(a)gmx.net> writes: > I'm unsure about the second line. Is that supposed to be the "last > modified" date of the manpage, the wineserver or what? The English > version says October 2005. In general, it would be the last time there were changes to the program that required a manpage update. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Update Ukrainian translation
by Nikolay Sivov June 26, 2013

June 26, 2013

On 6/26/2013 13:10, Микола wrote: Hi, please resubmit this patch with your full name transliterated in English.

1 0

Re: wined3d: print the architecture when showing driver problems
by Henri Verbeet June 26, 2013

June 26, 2013

On 23 June 2013 07:10, Austin English <austinenglish(a)gmail.com> wrote: > Please consider applying before the release of 1.6. It has no > functional changes, but would really help when diagnosing user > problems. > This is not really a wined3d patch. That said, while I agree that printing the architecture would be useful here, you can probably avoid the #ifdef by using something along the lines of sizeof(void *) == 8 ? "64-bit" : "32-bit", although ideally we'd probably get the actual architecture from somewhere like ntdll.

2 2

Re: widl: Do not generate empty Vtbl structure for empty interfaces.
by Alexandre Julliard June 25, 2013

June 25, 2013

Thomas Faber <thfabba(a)gmx.de> writes: > An alternative solution would be not to generate a vtable structure at all, > and instead add a dummy member to the class directly. That would be in line > with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, > but require a slightly larger change to widl. I'm not sure it makes sense to even define a C structure at all, since there's nothing you can do with it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Czech language for Wine
by Alexandre Julliard June 25, 2013

June 25, 2013

Pavel VlÄek <paaajavlca(a)gmail.com> writes: > @@ -1415,19 +1400,19 @@ > > #: crypt32.rc:74 > msgid "Title" > -msgstr "Titul" > +msgstr "" > > #: crypt32.rc:75 > msgid "Given Name" > -msgstr "Jm©no" > +msgstr "" > > #: crypt32.rc:76 > msgid "Initials" > -msgstr "Inici¡ly" > +msgstr "" > > #: crypt32.rc:77 > msgid "Surname" > -msgstr "Pjmen" > +msgstr "" Why are you removing all these existing translations? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)
by Dmitry Timoshkov June 25, 2013

June 25, 2013

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/ole32/ifs.c > +++ b/dlls/ole32/ifs.c > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC iface,LPVOID pv,DWORD cb) { > IMallocSpy_Release(Malloc32.pSpy); > Malloc32.SpyReleasePending = FALSE; > Malloc32.pSpy = NULL; > + /* cb == 0 case will release it some lines below. */ > + if (cb) LeaveCriticalSection(&IMalloc32_SpyCS); > } > > if (0==cb) { Why not unconditionally release the lock before the '0==cb' check? -- Dmitry.

2 3

Re: d3dx9: Implement adjacency in D3DXCreateSphere
by Rico Schüller June 25, 2013

June 25, 2013

On 20.06.2013 21:25, Nozomi Kodama wrote: > + if (adjacency) > + { > + DWORD *buffer, size; > + ID3DXBuffer *temp; > + > + size = 3 * sphere->lpVtbl->GetNumFaces(sphere) * sizeof(DWORD); > + hr = D3DXCreateBuffer(size, &temp); > + if (hr != D3D_OK) > + return hr; > + > + buffer = (DWORD *)(ID3DXBuffer_GetBufferPointer(temp)); Are the outer parentheses needed? Is the cast needed? > + hr = sphere->lpVtbl->GenerateAdjacency(sphere, -0.000001f, buffer); > + if (hr != D3D_OK) > + return hr; This may leak the temp ID3DXBuffer in the error case. Cheers Rico

2 1

Re: msvcr90/tests: skip tests of function ?_name_internal_method if it is not present
by Marvin June 24, 2013

June 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26093 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: ws2_32: Fix interface-bound filter to accept locally generated targeted packets.
by Jonas Maebe June 24, 2013

June 24, 2013

On 24 Jun 2013, at 04:30, Erich E. Hoover wrote: > <0001-ws2_32-Fix-interface-bound-filter-to-accept-locally-.patch> The added "struct sock_filter ip_memaddr" field doesn't seem to be used. Jonas

2 1

Re: ol32: Make enumx implementation look more like a COM interface.
by Dmitry Timoshkov June 24, 2013

June 24, 2013

This patch should be quite obvious in its intent: it changes vtable type to IUnknown which helps to remove This* to IUnknown* casts in order to avoid obvious problems with vtable pointer placement inside of object implementation. Basically this is just a clean up patch. Is there anything else to clear the pending patch state? -- Dmitry.

2 5

Re: [PATCH]winhttp:session.c fix a bug(return value is null)
by Hans Leidekker June 24, 2013

June 24, 2013

On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote: > diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c > index 660eae5..dfe23d4 100644 > --- a/dlls/winhttp/session.c > +++ b/dlls/winhttp/session.c > @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD flags, LPWSTR *url ) > { > static int fixme_shown; > if (!fixme_shown++) FIXME("discovery via DHCP not supported\n"); > + flags = WINHTTP_AUTO_DETECT_TYPE_DNS_A; > + ret=TRUE; > } > if (flags & WINHTTP_AUTO_DETECT_TYPE_DNS_A) > { We shouldn't perform DNS detection if the app didn't ask for it. Do you have an app that fails because we return an error here?

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime.
by Hans Leidekker June 24, 2013

June 24, 2013

On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote: > +static WCHAR *get_localdatetime(void) > +{ > + static const WCHAR fmtW[] = > + {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u', > + '.','%','0','6','u','+','0','0','0',0}; > + SYSTEM_TIMEOFDAY_INFORMATION ti; > + TIME_FIELDS tf; > + WCHAR *ret; > + > + if (!(ret = heap_alloc( 26 * sizeof(WCHAR) ))) return NULL; > + > + NtQuerySystemInformation( SystemTimeOfDayInformation, &ti, sizeof(ti), NULL ); > + RtlTimeToTimeFields( &ti.liKeBootTime, &tf ); > + sprintfW( ret, fmtW, tf.Year, tf.Month, tf.Day, tf.Hour, tf.Minute, tf.Second, tf.Milliseconds * 1000 ); > + return ret; > +} This will not return local time.

1 0

Re: wbemprox: Implement some properties of Win32_BIOS. (resend 4)
by Hans Leidekker June 24, 2013

June 24, 2013

On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote: > static const struct column col_bios[] = > { > + { prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY}, > { prop_descriptionW, CIM_STRING }, > { prop_manufacturerW, CIM_STRING }, > { prop_releasedateW, CIM_DATETIME }, > @@ -508,6 +511,7 @@ struct record_baseboard > }; > struct record_bios > { > + const struct array *biosversion; > const WCHAR *description; > const WCHAR *manufacturer; > const WCHAR *releasedate; > @@ -695,9 +699,13 @@ static const struct record_baseboard data_baseboard[] = > { > { baseboard_manufacturerW, baseboard_serialnumberW, baseboard_tagW } > }; > +static const struct array data_bios_biosversion = > +{ > + 1, (void*)bios_versionW > +}; This can't work. BIOSVersion is of type CIM_STRING|CIM_FLAG_ARRAY, which translates to a pointer to an array of string pointers.

1 0

Re: po: Update Simplified Chinese translation (resend)
by Qian Hong June 24, 2013

June 24, 2013

Hi Caibin, Welcome to Wine! Thanks for the great work, patch looks perfect to me. It's a bit pity that Julliard just finishing today's patch committing several minutes ago, hopefully this patch would be committed next week, if we have rc4 :) Cheers. On Sat, Jun 22, 2013 at 12:36 AM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > - Used real name in commit message > - Superseded patch 96985 > --- > po/zh_CN.po | 373 > +++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 190 insertions(+), 183 deletions(-) > > > > -- Regards, Qian Hong - http://www.winehq.org

4 4

Patch 96965
by Christian Costa June 23, 2013

June 23, 2013

Hi, This patch http://source.winehq.org/patches/data/96965 is in the pending state. Is there anything wrong or missing. Basically this patch only changes the test to check exactly the returned value to show the difference in behaviour between A and Version of the API. The rest is just to things to make this difference clearer.

1 0

(no subject)
by namit maheshwari June 23, 2013

June 23, 2013

1 0

Accentuate names.
by Tae Wong June 22, 2013

June 22, 2013

There are lots of Czech developers (Macek and Semerad) being unaccentuated plus Caolan and Znidarsic. They need to be accentuated.

1 0

talking about web-based translation again -- transifex
by qing xianhao June 21, 2013

June 21, 2013

hi all, firstly, i didn't use launchpad so much, but i used transifex for a mouths help to translate several opensource projects including the transifex itself. i found it can answer these needs as commented following. Quoted from http://www.winehq.org/pipermail/wine-devel/2011-September/092047.html > Launchpad tracks who translated what string and if we choose the > 'Closed' permissions model only approved translators can update the > translations. So that means we should be able to get patches with > full attribution. transifex has coordinator and translator roles division. coordinator could review the translation[1]. > Launchpad would need to pull updated PO files from Wine regularly. > Ideally that would be automatic and happen daily (both to account > for translations happening outside Launchpad and to take changes in > the resource files into account quickly). transifex has option to pull form outside, and the frequency is about daily[2]. > Conversely Launchpad should submit patches back to Wine. Ideally that > would be automated as much as possible but I'm fuzzy on the details > here (especially on how to preserve attribution). As for the > periodicity, maybe the best would be weekly or just before Alexandre > makes a release. the transifex has command line client[3] to pull the translation changes. if a unix guy got the command line tool, what could he do. ;) Quoted from http://www.winehq.org/pipermail/wine-devel/2012-January/093908.html >trace every Wine commit to a specific person transifex itself is open source project that can be self-hosted[4]. xfce team is hosting their own with it, every the commit was tracked and can view the diff easyly. [4] community edition installation http://help.transifex.com/server/ [3] transifex client http://support.transifex.com/customer/portal/topics/440187-transifex-client… [2] How often are the stats auto-updated http://help.transifex.com/intro/faq.html#how-often-are-the-stats-auto-updat… [1] coordinator review http://help.transifex.com/intro/translating.html#proofreading-translations -- qingxianhao

2 1

Re: user32: Invalidate window after resizing for WM_SYSCOMMAND/SC_SIZE.
by Alexandre Julliard June 21, 2013

June 21, 2013

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/user32/winpos.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) That's only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader
by Henri Verbeet June 21, 2013

June 21, 2013

On 21 June 2013 12:06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This also works for fog_start == fog_end on drivers that don't handle > this situation correctly with fixed function fog. Tested on nvidia, > r300g, r600g. What does this fix?

2 1

Re: [PATCH 2/2] msvcrt: Add some _mbstok tests
by Marvin June 21, 2013

June 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26066 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

2 1

Re: [PATCH] winetest: Add support for wineconsole output
by Fabian Ebner June 20, 2013

June 20, 2013

Am 20.06.2013 17:55, schrieb Bruno Jesus: > On Thu, Jun 20, 2013 at 12:42 PM, Fabian Ebner <f.ebner94(a)gmail.com> wrote: >> Allow winetest to output stuff inside a wineconsole. >> Fixes http://bugs.winehq.org/show_bug.cgi?id=28191 >> --- >> programs/winetest/gui.c | 6 +++--- >> programs/winetest/main.c | 2 +- >> programs/winetest/util.c | 25 +++++++++++++++++++++++++ >> programs/winetest/winetest.h | 1 + >> 4 files changed, 30 insertions(+), 4 deletions(-) >> + //No logfile means printing to stdout Ok, thanks > C++ comments are not allowed AFAIK. > >> + if (!logfile) { The surrounding code uses this style when it is an if or a while, when it's a function it uses new-line {. But there are only two other occurences of {}-braces, should I change them with my patch and use new-line all along? > You should use the coding style of the surrounding code, it looks like > the rest of the file uses the { in the next line, I may be wrong about > this. > > Best wishes, > Bruno

1 0

Re: ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3)
by Alexandre Julliard June 20, 2013

June 20, 2013

Mathis Beer <default_357-line(a)yahoo.de> writes: > As such, this patch changes msync to be called asynchronously. > > This is revision three of this patch. It leaves the original #define > MS_SYNC 0 in place and instead changes NtFlushVirtualMemory to use > MS_ASYNC only if mman.h was found earlier. (It also adds comments) That doesn't make sense, all interesting platforms have mman.h, that doesn't imply they have MS_ASYNC. It may well be that nowadays they all have MS_ASYNC too, so we could use it unconditionally and see if someone reports breakage. This will have to wait until after code freeze though. -- Alexandre Julliard julliard(a)winehq.org

1 0