June 2013 - Wine-Devel - list.winehq.org

Re: widl: Do not generate empty Vtbl structure for empty interfaces.
by Alexandre Julliard June 25, 2013

June 25, 2013

Thomas Faber <thfabba(a)gmx.de> writes: > An alternative solution would be not to generate a vtable structure at all, > and instead add a dummy member to the class directly. That would be in line > with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, > but require a slightly larger change to widl. I'm not sure it makes sense to even define a C structure at all, since there's nothing you can do with it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Czech language for Wine
by Alexandre Julliard June 25, 2013

June 25, 2013

Pavel VlÄek <paaajavlca(a)gmail.com> writes: > @@ -1415,19 +1400,19 @@ > > #: crypt32.rc:74 > msgid "Title" > -msgstr "Titul" > +msgstr "" > > #: crypt32.rc:75 > msgid "Given Name" > -msgstr "Jm©no" > +msgstr "" > > #: crypt32.rc:76 > msgid "Initials" > -msgstr "Inici¡ly" > +msgstr "" > > #: crypt32.rc:77 > msgid "Surname" > -msgstr "Pjmen" > +msgstr "" Why are you removing all these existing translations? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)
by Dmitry Timoshkov June 25, 2013

June 25, 2013

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/ole32/ifs.c > +++ b/dlls/ole32/ifs.c > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC iface,LPVOID pv,DWORD cb) { > IMallocSpy_Release(Malloc32.pSpy); > Malloc32.SpyReleasePending = FALSE; > Malloc32.pSpy = NULL; > + /* cb == 0 case will release it some lines below. */ > + if (cb) LeaveCriticalSection(&IMalloc32_SpyCS); > } > > if (0==cb) { Why not unconditionally release the lock before the '0==cb' check? -- Dmitry.

2 3

Re: d3dx9: Implement adjacency in D3DXCreateSphere
by Rico Schüller June 24, 2013

June 24, 2013

On 20.06.2013 21:25, Nozomi Kodama wrote: > + if (adjacency) > + { > + DWORD *buffer, size; > + ID3DXBuffer *temp; > + > + size = 3 * sphere->lpVtbl->GetNumFaces(sphere) * sizeof(DWORD); > + hr = D3DXCreateBuffer(size, &temp); > + if (hr != D3D_OK) > + return hr; > + > + buffer = (DWORD *)(ID3DXBuffer_GetBufferPointer(temp)); Are the outer parentheses needed? Is the cast needed? > + hr = sphere->lpVtbl->GenerateAdjacency(sphere, -0.000001f, buffer); > + if (hr != D3D_OK) > + return hr; This may leak the temp ID3DXBuffer in the error case. Cheers Rico

2 1

Re: msvcr90/tests: skip tests of function ?_name_internal_method if it is not present
by Marvin June 24, 2013

June 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26093 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: ws2_32: Fix interface-bound filter to accept locally generated targeted packets.
by Jonas Maebe June 24, 2013

June 24, 2013

On 24 Jun 2013, at 04:30, Erich E. Hoover wrote: > <0001-ws2_32-Fix-interface-bound-filter-to-accept-locally-.patch> The added "struct sock_filter ip_memaddr" field doesn't seem to be used. Jonas

2 1

Re: ol32: Make enumx implementation look more like a COM interface.
by Dmitry Timoshkov June 24, 2013

June 24, 2013

This patch should be quite obvious in its intent: it changes vtable type to IUnknown which helps to remove This* to IUnknown* casts in order to avoid obvious problems with vtable pointer placement inside of object implementation. Basically this is just a clean up patch. Is there anything else to clear the pending patch state? -- Dmitry.

2 5

Re: [PATCH]winhttp:session.c fix a bug(return value is null)
by Hans Leidekker June 24, 2013

June 24, 2013

On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote: > diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c > index 660eae5..dfe23d4 100644 > --- a/dlls/winhttp/session.c > +++ b/dlls/winhttp/session.c > @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD flags, LPWSTR *url ) > { > static int fixme_shown; > if (!fixme_shown++) FIXME("discovery via DHCP not supported\n"); > + flags = WINHTTP_AUTO_DETECT_TYPE_DNS_A; > + ret=TRUE; > } > if (flags & WINHTTP_AUTO_DETECT_TYPE_DNS_A) > { We shouldn't perform DNS detection if the app didn't ask for it. Do you have an app that fails because we return an error here?

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime.
by Hans Leidekker June 24, 2013

June 24, 2013

On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote: > +static WCHAR *get_localdatetime(void) > +{ > + static const WCHAR fmtW[] = > + {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u', > + '.','%','0','6','u','+','0','0','0',0}; > + SYSTEM_TIMEOFDAY_INFORMATION ti; > + TIME_FIELDS tf; > + WCHAR *ret; > + > + if (!(ret = heap_alloc( 26 * sizeof(WCHAR) ))) return NULL; > + > + NtQuerySystemInformation( SystemTimeOfDayInformation, &ti, sizeof(ti), NULL ); > + RtlTimeToTimeFields( &ti.liKeBootTime, &tf ); > + sprintfW( ret, fmtW, tf.Year, tf.Month, tf.Day, tf.Hour, tf.Minute, tf.Second, tf.Milliseconds * 1000 ); > + return ret; > +} This will not return local time.

1 0

Re: wbemprox: Implement some properties of Win32_BIOS. (resend 4)
by Hans Leidekker June 24, 2013

June 24, 2013

On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote: > static const struct column col_bios[] = > { > + { prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY}, > { prop_descriptionW, CIM_STRING }, > { prop_manufacturerW, CIM_STRING }, > { prop_releasedateW, CIM_DATETIME }, > @@ -508,6 +511,7 @@ struct record_baseboard > }; > struct record_bios > { > + const struct array *biosversion; > const WCHAR *description; > const WCHAR *manufacturer; > const WCHAR *releasedate; > @@ -695,9 +699,13 @@ static const struct record_baseboard data_baseboard[] = > { > { baseboard_manufacturerW, baseboard_serialnumberW, baseboard_tagW } > }; > +static const struct array data_bios_biosversion = > +{ > + 1, (void*)bios_versionW > +}; This can't work. BIOSVersion is of type CIM_STRING|CIM_FLAG_ARRAY, which translates to a pointer to an array of string pointers.

1 0