July 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 26, 2013

Oct. 26, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Possibility of adding a new patch status
by Hugh McMaster Aug. 14, 2013

Aug. 14, 2013

Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked at yet, there's still hope...". This is ideal for new patches submitted within that 24-hour commit cycle. But I'm finding it difficult to follow patches that remain with a status of 'New' for longer than the 24-hour patch cycle. Obviously, on the weekend, patches are held over till Monday, so a longer lead-time is expected. During weekdays, however, it is unclear what is happening with some patches. This, ultimately, raises the question of timeliness. Has the patch been looked at? If it has, the status often describes what action was taken - committed, rejected, superseded, etc. This is fine, but some patches remain with a status of 'New'. Experience has told me that patches remaining with a status of 'New' are incorrect in some way. But this is not always the case. If the patch is incorrect, but close to being accepted, the patch's status should reflect this, by changing to something like "Revision needed". Of course, the "Rejected" status is also appropriate, depending on the severity of coding error. Also, there are likely to be many times when the maintainer has not had time to evaluate some patches. This means the patch is not new (i.e. recently submitted), but is awaiting review. Once again, I believe the patch status should reflect this situation. The status could be "Not yet reviewed". In summary, the 'New' status should be reserved for patches that are actually new. Just some thoughts.

3 7

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.
by Matteo Bruni Aug. 2, 2013

Aug. 2, 2013

2013/7/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/tests/shader.c | 308 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 308 insertions(+) > This is okay, but as a followup can you add some tests with mixed-type structs? Something like: struct { float f; int i; bool b; }; If you have already written tests of this kind, I'd like to know what does the compiler do in this case :)

2 6

Re: po: Add English (Canada) resource [Take 2]
by Ken Sharp Aug. 2, 2013

Aug. 2, 2013

Please disregard this patch. I missed a couple of words and with those corrected en_CA.po becomes identical to en.po (except that "serialisation" is fuzzy) and Wine defaults to that anyway for Canadian English. Will re-submit if there are any changes (just noticed -able/-eable). Will keep an eye on the English translations. On 30/07/13 22:37, Ken Sharp wrote: > - Re-based to latest git > - Removed all the fuzzies thanks to http://www.etymonline.com/index.php > > Turns out all the -ise/-ize words used in Wine are of Latin origin anyway. > > > -------- Original Message -------- > Subject: po: Add English (Canada) resource > Date: Mon, 22 Jul 2013 19:28:51 +0100 > From: Ken Sharp <kennybobs(a)o2.co.uk> > To: wine-patches(a)winehq.org > > Canadian English follows some British/French rules but not others. > > I have left some of the -ise/-ize words fuzzy because: > > "the etymological convention that verbs derived from Greek roots are > spelled with -ize and those from Latin with -ise is preserved in that > practice." > http://en.wikipedia.org/wiki/Canadian_english#Spelling_and_dictionaries > > I tried looking for the origins of the words and I couldn't get any. The > non-fuzzies are correct. > > With British, US and Canadian I believe all the English variations (used > in Wine) are covered, except Philippines (follows US rules). > > >

1 1

gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.
by Alexei Svitkine Aug. 1, 2013

Aug. 1, 2013

Don't let the gdi32 driver allocate memory in the dplayx region. Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095 The issue is that the dplayx code in wine needs to allocate some memory at a static address (0x50000000) and loading the Mac native gdi driver ends up using that part of the address space. This patch fixes that by reserving that part of memory while the display driver is initialized and releasing it after. --- dlls/gdi32/driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+)

2 5

Re: [PATCH 11/11] appelp: Add tests.
by Marvin July 31, 2013

July 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26546 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)
by Alexandre Julliard July 31, 2013

July 31, 2013

Caibin Chen <tigersoldi(a)gmail.com> writes: > Thanks Jacek for reviewing. This time I send all the changes I have in > 4 patches to make it clear that ReTxtDoc is reused between txtsrv.c > and richole.c > - Suppressed Patch 97331 > - Change log from try 2: > - follow COM naming convention > - move ReTxtDoc definition to header, removed > ReTxtDoc_get_ITextDocument() function > - remove COM aggregation test for ITextDocument, only test > ITextService supports querying for the interface. > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 10 ++ > dlls/riched20/txtdoc.c | 270 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 51 ++++++++ > dlls/riched20/txtsrv.c | 6 + Please avoid adding too many source files. In particular, if you have to add new headers and define objects there, it's a sign that things should be grouped in the same file. That's even more true for ITextDocument that already exists. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader.
by Stefan Dösinger July 31, 2013

July 31, 2013

Hi, Am 31.07.2013 um 09:10 schrieb Christian Costa <titan.costa(a)gmail.com>: > + if (!(strstr(line_out, "warning X3206:") && strstr(line_out, "implicit truncation of vector type"))) > + line_out += line_size; msvc localizes compiler errors and warnings. Are you sure d3dcompiler.dll doesn't do that? Wrt the parsing code, wouldn't it be nicer to use strtok_r to split the buffer into separate lines? I am not sure that parsing the errors and warnings like that is a good thing, but I don't know d3dx9 and d3dcompiler well enough to give a final judgement on that.

2 2

Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()
by Austin English July 31, 2013

July 31, 2013

On Tue, Jul 30, 2013 at 5:13 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > > You forgot the patch. -- -Austin

3 2

d3dx9: Replace M_PI by its D3DX equivalent
by Nozomi Kodama July 31, 2013

July 31, 2013

What is the problem with patch: http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX (moreover it is deprecated in C99) Nozomi

2 1

Re: kernel32: Fix parameters checking for GetVolumePathName()
by Alexandre Julliard July 31, 2013

July 31, 2013

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -1813,6 +1821,8 @@ BOOL WINAPI GetVolumePathNameW(LPCWSTR filename, LPWSTR volumepathname, DWORD bu > volumepathname[3] = 0; > return TRUE; > } > + > + SetLastError(ERROR_FILENAME_EXCED_RANGE); > return FALSE; This doesn't really make sense as a general error. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3dx9: Replace M_PI by its D3DX equivalent
by Nozomi Kodama July 31, 2013

July 31, 2013

Hello What is the problem with patch http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX. Nozomi

1 0

Re: msxml3: Unescape '&' back to '&' in attribute value
by Marvin July 31, 2013

July 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26523 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPPROSP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K8SE (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & )

1 0

Re: kernel32/tests: Improve GetVolumePathNameA tests
by Bruno Jesus July 30, 2013

July 30, 2013

Please ignore this patch, I understand that as is it will not be commited. On Tue, Jul 30, 2013 at 3:30 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Erich Hoover contacted me about a patch he sent months ago related to > GetVolumePathNameA. He developed a better test infrastructure using a > for loop instead of multiple repetitions of test lines. This patch > will make it easier for him to rebase and send his tests and function > implementation later. > > I used the same approach from [1] by decomposing the "todo_wine" in > winetest_start_todo("wine") and winetest_end_todo("wine"). > > http://source.winehq.org/source/programs/cmd/tests/batch.c#L292 -- universe* god::bigbang (void); //and then it all began...

1 0

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.
by Nikolay Sivov July 30, 2013

July 30, 2013

On 7/9/2013 16:50, Qian Hong wrote: > Fixed a crash in MS Office 2010 Chinese version. > Thanks Jiang Yike for the helps on testing :) > > --- > dlls/imm32/imm.c | 6 ++++++ > dlls/imm32/tests/imm32.c | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > > > > > + if (IsBadReadPtr(internal, sizeof(HIMCC))) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + Do you really need this for Office 2010 or null check is enough? If it's passing 0 handle here that's what you should check imho. If HIMCC is really a handle and not a struct pointer like in wine, that's not how a handle validity check will look like.

2 4

Call for Windows tests
by Bruno Jesus July 30, 2013

July 30, 2013

Hi, I'm looking for help to test WSAEnumProtocols, I need to collect more information about the values returned from different versions of windows, especially 7 and 8. If you can help please download the file below, unzip, run the .bat and send me back the result.txt file (sources included). http://influenza.blog.br/wsa.zip There is no need to answer to the list. Virustotal.com scan: http://bit.ly/1catW4a Thanks in advance, Bruno

1 0

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.
by Vincent Povirk July 30, 2013

July 30, 2013

There's a TIFF_VERSION define that seems to have been renamed to TIFF_VERSION_CLASSIC in 4.0. It doesn't make sense to do the check at runtime, given we're only going to link to one of the versions.

3 7

Re: [1/2] msxml3: Implement IMXAttributes_removeAttributes()
by Jacek Caban July 30, 2013

July 30, 2013

Hi Nikolay, On 07/30/13 12:42, Nikolay Sivov wrote: > + dst = &This->attr[index]; > + src = &This->attr[index+1]; > + > + memmove(dst, src, This->length-index-1); *sizeof(*dst) Cheers, Jacek

1 0

Re: [2/2] wininet: Handle NULL input string in str_to_buffer.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26482 Your paranoid android. === WXPX64 (64 bit http) === http.c:4661: Test failed: 4832: expected status 100 got 10 http.c:4661: Test failed: 4876: expected status 100 got 40 http.c:4634: Test failed: ar->dwResult = 0, expected 1 http.c:4661: Test failed: 4885: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

Re: [1/2] wininet: Ignore INTERNET_FLAG_NO_CACHE_WRITE only for GET requests.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26481 Your paranoid android. === WXPX64 (32 bit http) === http.c:4588: Test failed: 4759: expected status 100 got 10 http.c:4588: Test failed: 4803: expected status 100 got 40 http.c:4561: Test failed: ar->dwResult = 0, expected 1 http.c:4588: Test failed: 4812: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA

1 0

Re: [2/2] iphlpapi: Add partial support for the module classes in GetExtendedTcpTable and GetExtendedUdpTable.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26480 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === W7PROX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 77E03915 === WVISTAX64 (64 bit iphlpapi) === Timeout === W7PROX64 (64 bit iphlpapi) === No test summary line found

1 0

Re: [1/2] iphlpapi: Add support for the listener and connection classes in GetExtendedTcpTable.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26479 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === WVISTAX64 (64 bit iphlpapi) === Timeout

1 0

Re: riched20: ITextDocument stubs for ITextServices (retry)
by Caibin Chen July 30, 2013

July 30, 2013

Anybody reviewing this patch? It's almost all stubs, so although it's long, it shouldn't be hard to review 2013/7/15 Caibin Chen <tigersoldi(a)gmail.com>: > (Retry with real name in mail. The name in the patch is already my real name) > > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 16 ++- > dlls/riched20/txtdoc.c | 282 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 46 +++++++ > dlls/riched20/txtsrv.c | 6 + > 5 files changed, 350 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/txtdoc.c > create mode 100644 dlls/riched20/txtdoc.h

2 4

[PATCH 1/2] ntdll: Implement NtQuerySystemInformation class 0x37
by Chris Moeller July 29, 2013

July 29, 2013

2 1

GetNumaHighestNodeNumber tests
by Chris Moeller July 29, 2013

July 29, 2013

Here is a basic stand-alone test program, which I should probably learn how to implement into the standard testing array. On my test Windows 7 system with a single processor (4 cores), it outputs the following: Testing NtQuerySystemInformationSystemNumaHighestNodeNumber = 0x37, ...): ... with invalid size returned c0000004 ... with valid size returned 0, HighestNodeNumber = 0, ResultLength = 4 Testing GetNumaHighestNodeNumber: ... returned 1, HighestNodeNumber = 0

1 0

[PATCH 2/2] kernel32: Implement GetNumaHighestNodeNumber
by Chris Moeller July 29, 2013

July 29, 2013

1 0

[PATCH 0/2] Implement basic GetNumaHighestNodeNumber
by Chris Moeller July 29, 2013

July 29, 2013

This patch against HEAD does the following in two parts: Part 1) Implements NtQuerySystemInformation class 0x37, which I have given the name SystemNumaHighestNodeNumber, since that appears to be all it does. It currently is limited to simulating a single node system, and returns the correct error status if queried with too small a return buffer. Part 2) Implements GetNumaHighestNodeNumber based on the above interface, and behaves just like a Windows 7 32-bit kernel32.dll does in case of errors in that function.

1 0

kernel32: Correct log on / logon (noun / verb)
by Ken Sharp July 29, 2013

July 29, 2013

Evening Winos, Attached is a patch to correct some winerr messages. Specifically change a noun to a verb, and update the .po files with it. Firstly, could you take a look and point out any obvious errors I may have made? I have marked some of the translations fuzzy because it's not clear if the original translator realised that this should have been the verb and not the noun. A quick look through the translations on Wikipedia suggests that most languages do use different terms for the noun and the verb. https://cs.wikipedia.org/wiki/Login https://de.wikipedia.org/wiki/Login_(Informationstechnik) https://es.wikipedia.org/wiki/Login and so on. Some of these listings seem to use completely different words to the current translation in Wine so I wouldn't dare make a guess. Secondly, what do people think about the use of "Can't" as opposed to "Cannot"? I have not made the change in the patch but I'm wondering if people think that this should be done. Can't is informal and as my old English teacher would say, "Can't is not a word!" It is, but being pedantic "cannot" is probably the better choice. I assume Windows uses "can't" seen as it listed in winerror.mc. Thanks all! Ken

2 1

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Matteo Bruni July 29, 2013

July 29, 2013

2013/7/30 Chris Moeller <kode54(a)gmail.com>: > > On Jul 29, 2013, at 11:22 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > >> 2013/7/29 Chris Moeller <kode54(a)gmail.com>: >>> without looking very deeply into the CRT source code. >> >> You're talking about MS source code, right? That makes you tainted for >> contributing to Wine at >> the very least for C runtime-related code :( >> If you haven't looked into any other source code, this patch might be >> okay (barring other issues, I haven't read the patch at all). At least >> http://wiki.winehq.org/DeveloperFaq#head-fed5011434f62ae1a88baebfb8193a37ea… >> seems to suggest so. > > I did not look at any CRT source code to determine how to implement the functionality of this patch. I only looked at CRT source code to determine why the CRT was crashing in the first place. The HighestNode function popping a warning in my wine logs should have been hint enough to discover that function was stubbed. > > I actually determined how these functions worked by testing their behavior against a working system, and also with the aid of another developer, who pointed out a handy Win32 function for retrieving a suitable value for the free memory check. That's probably fine, although as a general rule you should stay as far as possible from Microsoft's source code. Cheers, Matteo.

1 0

[1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Chris Moeller July 29, 2013

July 29, 2013

Main changes from HEAD: 1) Implements GetNumaHighestNodeNumber which simulates a typical single node system. 2) Implements GetNumaNodeProcessorMask which returns the global processor affinity mask for node 0, otherwise returns an error. 3) Implements GetNumaAvailableMemoryNode which returns available physical memory for node 0, otherwise returns an error. This much of the behavior was observed based on a single processor (4 cores) Windows 7 system. These functions are utilized by the synchronization and threading primitives incorporated in the MSVC 2012 and newer C and C++ runtime libraries. concrt.h/Concurrency::critical_section, which is used by both std::mutex and std::thread, will throw an exception the moment the object is locked if GetNumaHighestNodeNumber fails, and there are at least a few examples of software which don't bother to catch this exception and thus crash, such as the alpha version of Cube World, and certain versions of the foo_wave_seekbar component for the foobar2000 audio player. The associated scheduling code appears to make use of GetNumaNodeProcessorMask as well to control how many threads are allowed to spin up at once, or so I guess without looking very deeply into the CRT source code.

3 2

Re: [PATCH] Ignore MotionNotify when XI2 is handling mouse motion
by Alexandre Julliard July 29, 2013

July 29, 2013

Josef Schimke <sgtcapslock(a)lavabit.com> writes: > Hello, > > When XInput2 takes over the mouse, regular MotionNotify events continue to be > handled alongside it. This causes the cursor to erratically skip around when > the slower method (X11 input) tries to reposition the cursor while XInput2 is > already handling future events. We want to process MotionNotify to resync the cursor position, XInput events are not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

How to get involved in Windows Store API implement?
by 中川祥 July 29, 2013

July 29, 2013

I do not know much about the store apps development. What is Windows.winmd? Do I need disassemble it and create wine version ?If I need C++,I wouldn't do. Is there any planning to support them?

2 1

NtCreateFile fails
by Mislav Blazevic July 29, 2013

July 29, 2013

First of all, pardon my ignorance, I am new to wine and winapi. I am trying to implement apphelp.dll and I ran into issues with NtCreateFile: It always returns 0xc0000103, STATUS_NOT_A_DIRECTORY, and I am not sure what that means. Here is code: /* This function is not in API, but written for internal use */ HANDLE WINAPI SdbOpenFile( LPCWSTR path, PATH_TYPE type ) { /* SNIP */ if (type == DOS_PATH) if (!RtlDosPathNameToNtPathName_U(path, &str, NULL, NULL)) return NULL; InitializeObjectAttributes(&attr, &str, OBJ_CASE_INSENSITIVE, NULL, NULL); status = NtCreateFile(&file, GENERIC_READ | SYNCHRONIZE | FILE_READ_ATTRIBUTES, &attr, &io, NULL, FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, FILE_OPEN, FILE_DIRECTORY_FILE, NULL, 0); /* SNIP */ return file; } Function is called like this: WCHAR szFileName[1024] = {0}; ExpandEnvironmentStringsW(L"%SystemRoot%\\sample.sdb", szFileName, 1024); // for testing purposes SdbOpenFile(szFileName, DOS_PATH); Compiled with winegcc. I am sure that C:\windows\sample.sdb exists. What am I doing wrong?

3 2

Re: [PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.
by Matteo Bruni July 28, 2013

July 28, 2013

2013/7/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/shader.c | 79 > ++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 77 insertions(+), 2 deletions(-) > So there was actually a logic (an insane one, but yeah...). Have you found any game actually using this? Annoying question: have you checked if it's the same with newer d3dx9 dlls (e.g. d3dx9_43)? It still looks to me like buggy behavior and it might be that MS fixed that in later d3dx9 versions. This is not blocking the patch of course.

2 1

Windows 7 64-bit?
by Ken Sharp July 26, 2013

July 26, 2013

I have to ask: Do we really think that this user is running Wine 1.0.1 on Windows 7 64-bit? http://appdb.winehq.org/objectManager.php?sClass=version&iId=28587&iTesting…

3 4

Need help with debugging a directx9 game crashing
by Qian Hong July 25, 2013

July 25, 2013

Hello, I was debugging on a popular game [1] [2] (9 GB), it crashes on start. +relay,+seh,+tid log show that there are some calls to wined3d.wined3d_mutex_lock / wined3d.wined3d_buffer_map / wined3d.wined3d_mutex_unlock before crashing, so I turn on +d3d9 trace to get a new log in details. To my surprise, the game doesn't crash anymore with +d3d9 trace! After a serials of bisect, I found d3d9_AddRef is the key function call related to the crashing. If I remove the TRACE statement in line 71, the game will crash with +d3d9 as well; if I upgrade the TRACE in 71 to FIXME, the game will not crash even without +d3d9. 66 static ULONG WINAPI d3d9_AddRef(IDirect3D9Ex *iface) 67 { 68 struct d3d9 *d3d9 = impl_from_IDirect3D9Ex(iface); 69 ULONG refcount = InterlockedIncrement(&d3d9->refcount); 70 71 TRACE("%p increasing refcount to %u.\n", iface, refcount); 72 73 return refcount; 74 } Further tests show that the simplest hack to avoid crashing is replacing line 71 to: FIXME("anything %x\n", 0xdeadbeef); I have no idea what the real fix is, any suggestion what is the next step to debug? Thanks in advance! Environment: Wine 1.6-rc5 Ubuntu 12.04.2 LTS gcc 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) The installer ship with native d3dx9_40.dll Backtrace on crash: Wine-dbg>c Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0x0649e6e9). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:0649e6e9 ESP:0033cc60 EBP:00000000 EFLAGS:00210206( R- -- I - -P- ) EAX:00000001 EBX:19b871e0 ECX:00000000 EDX:00000000 ESI:23f420b0 EDI:23f4f20c Stack dump: 0x0033cc60: 80004005 19c0e0c0 00000000 19b871e0 0x0033cc70: 00000000 23f420b0 23f4f1f0 19b871e0 0x0033cc80: 00000018 00000040 0000001c 00000000 0x0033cc90: 0a9101df 00000020 00000034 7bc34159 0x0033cca0: 00110064 ffffffff 0033ccd8 7bc34d2d 0x0033ccb0: 00000000 0000000c 00000010 00000001 Backtrace: =>0 0x0649e6e9 in kg3dengine (+0x16e6e9) (0x00000000) 0x0649e6e9: movl 0x0(%eax),%ecx [1] http://jx3.xoyo.com/download [2] http://jx3.client.cdn.kingsoft.com/JXOnline3-v3.0.4.4980/JXOnline3-v3.0.4.4… -- Regards, Qian Hong - http://www.winehq.org

4 11

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.
by Vincent Povirk July 25, 2013

July 25, 2013

I have no opinion on this sort of work-around (it should work afaict, and I haven't found any other places where we currently use toff_t), but did you file a bug with whatever distro has such broken headers?

3 3

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 3)
by Ken Thomases July 25, 2013

July 25, 2013

On Jul 25, 2013, at 10:49 AM, Charles Davis wrote: > Try 3: Don't advertise WGL_EXT_swap_control if vsync is disabled. Looks good. Thanks, Ken

1 0

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)
by Ken Thomases July 25, 2013

July 25, 2013

On Jul 24, 2013, at 9:34 PM, Charles Davis wrote: > Try 2: Don't duplicate a constant string; we might need to add more legacy > extensions. (Hopefully not. ;) Thanks for making that change. Looks good to me. Cheers, Ken

1 2

Re: [PATCH 1/6] scrrun: Store reference count inside IFileSystem3 object
by Nikolay Sivov July 25, 2013

July 25, 2013

On 7/25/2013 16:35, Piotr Caban wrote: > --- > dlls/scrrun/filesystem.c | 163 > +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 123 insertions(+), 40 deletions(-) Why do you need this?

2 1

What to do when an application misuses an API ...
by Michael Casadevall July 24, 2013

July 24, 2013

Hey all, I've been working on trying to get Sid Meier's Civilization V (Civ5) up to a point where it works relatively flawlessly on WINE. The largest issue is that installing the latest expansion pack has completely hosed the game under WINE unless some rather ugly workarounds have been taken. Specifically, the main issue is that Civ5 loads its data files in the order returned by Find{First,Next}File(), and breaks spectacularly if that order is disrupted. I documented my findings here: http://bugs.winehq.org/show_bug.cgi?id=34122 As I sat to look at a possible patch, I'm not sure what I can actually do. Its clearly stated on the MSDN page that the order returned is dependent on the underlying filesystem, and Googling suggests that while NTFS seems to always return in a roughly alphabetical order, FAT32 will return by creation date, and with network drives all bets are off. I was even able to reproduce similar bugs in Civ5 by launching it from a network drive (which I had already tested in advance to make sure it returned an odd file order). FindFirstFile essentially calls down to NtQueryDirectoryFile, which in turn either calls a system specific syscall or readdir to get a list of files in a directory. My first thought is to extend the underlying read_directory_* functions in ntdll/directory.c so that they return an alphabetized list (essentially taking the results from getdents/getdirentries/readdir, sort them, then returning in the sort order whichever entry is next in line). This would produce a behavior similar (but not identical) to what is seen when operating under an NTFS filesystem. This approach seems wrong to me, and is further compounded by the fact this is a bug in an application, and not in WINE specifically; Under the correct circumstances, Windows will return a "non-sorted" list of files and in those cases Civilization V breaks. The flipside is that in the most common case, it works correctly, and furthermore, given how easy it is to assume that Find*File does return a sorted list, I won't be surprised if this issue has cropped up elsewhere (figuring out the underlying cause was exceedingly annoying). Any insight in to what the most correct course of action would be most appreciated I'm perfectly willing to put the legwork in fixing this bug, but I want to make sure I'm fixing it in a way that will be accepted :-). Regards, Michael

3 3

Re: [PATCH] winemac.drv: Also return the number of pixel formats if the caller didn't supply a PIXELFORMATDESCRIPTOR.
by Ken Thomases July 24, 2013

July 24, 2013

On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > This is akin to what glxdrv already does, and apparently what Windows > does. It allows the GLView sample from the OpenGL SuperBible to > correctly enumerate pixel formats with the Mac driver. > --- > dlls/winemac.drv/opengl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/winemac.drv/opengl.c b/dlls/winemac.drv/opengl.c > index 0922371..fb294d1 100644 > --- a/dlls/winemac.drv/opengl.c > +++ b/dlls/winemac.drv/opengl.c > @@ -3281,7 +3281,7 @@ int macdrv_wglDescribePixelFormat(HDC hdc, int fmt, UINT size, PIXELFORMATDESCRI > > TRACE("hdc %p fmt %d size %u descr %p\n", hdc, fmt, size, descr); > > - if (fmt <= 0 || fmt > ret) return ret; > + if (fmt <= 0 || fmt > ret || !descr) return ret; > if (size < sizeof(*descr)) return 0; > > pf = &pixel_formats[fmt - 1]; > -- > 1.7.5.4 Looks good to me. Thanks! -Ken

1 0

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string.
by Ken Thomases July 24, 2013

July 24, 2013

Hi, On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > @@ -1226,8 +1227,10 @@ static BOOL init_gl_info(void) > gl_info.glVersion = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > strcpy(gl_info.glVersion, str); > str = (const char*)opengl_funcs.gl.p_glGetString(GL_EXTENSIONS); > - gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > + gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + > + sizeof(" WGL_EXT_extensions_string WGL_EXT_swap_control")); > strcpy(gl_info.glExtensions, str); > + strcat(gl_info.glExtensions, " WGL_EXT_extensions_string WGL_EXT_swap_control"); As a minor nitpick, I would prefer to avoid that duplicated string literal. Otherwise, looks good to me. Cheers, Ken

1 0

Re: [PATCH 4/5] scrrun: Add IFileSystem3::GetTempName implementation
by Alexandre Julliard July 24, 2013

July 24, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -174,6 +174,7 @@ BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls( hinst ); > scrrun_instance = hinst; > + srand(GetTickCount()); You don't want to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update English (US) resource
by Francois Gouget July 24, 2013

July 24, 2013

On Mon, 22 Jul 2013, Ken Sharp wrote: > Logon/Log on as with the British/neutral patch. > > msgid "Can't logon with inter-domain trust account.\n" > -msgstr "Can't logon with inter-domain trust account.\n" > +msgstr "Can't log on with inter-domain trust account.\n" [...] I think these fixes should really be applied to the source winerror.mc file instead. If I remember correctly en_US.po is just a dummy translation where msgid and msgstr strings should be identical (there might (with maybe one or two exceptions for things like um -> µm). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [PATCH 1/3] msvcrt: Fix _mktemp implementation
by Marvin July 24, 2013

July 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26413 Your paranoid android. === W2KPROSP4 (32 bit file) === file: unhandled exception c0000005 at 7801B5A7 === WXPPROSP2 (32 bit file) === file: unhandled exception c0000005 at 77C2F1C3 === W2K3R2SESP2 (32 bit file) === file: unhandled exception c0000005 at 77BC00A3 === WXPX64 (64 bit file) === Timeout

1 0

Re: [PATCH 1/3] d3dx9: Fix initialization of D3DXPC_OBJECTs.
by Rico Schüller July 23, 2013

July 23, 2013

On 23.07.2013 11:46, Rico Schüller wrote: > --- > dlls/d3dx9_36/effect.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > > These may not apply correctly. Sorry for the noise. I'll resend a new version. Cheers Rico

1 0

Re: [docs] "sgml" is not a valid output format
by Francois Gouget July 23, 2013

July 23, 2013

On Tue, 23 Jul 2013, Frédéric Delanoy wrote: [...] > -ALLFORMATS = html pdf sgml ps txt > +ALLFORMATS = html pdf ps txt 'make sgml' can be used to generate the translated SGML source files for our many documentation translations. So I don't think this patch should be applied. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

1 0

Re: [docs] "sgml" is not a valid output format
by Frédéric Delanoy July 23, 2013

July 23, 2013

On Tue, Jul 23, 2013 at 5:26 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > Make.rules.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Make.rules.in b/Make.rules.in > index fda8e81..d326247 100644 > --- a/Make.rules.in > +++ b/Make.rules.in > @@ -100,7 +100,7 @@ dummy: > > # Manual Dependencies > > -ALLFORMATS = html pdf sgml ps txt > +ALLFORMATS = html pdf ps txt Please discard this patch ; it seems to be used in the translated guides to generate sgml from english version+po file

1 0

Re: [1/5] oledb32: Stub for IRowPosition
by Marvin July 23, 2013

July 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26406 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 1/2] wined3d: Implement special fog behavior for orthogonal projection matrices.
by Henri Verbeet July 23, 2013

July 23, 2013

On 22 July 2013 20:24, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -3614,10 +3614,19 @@ void wined3d_ffp_get_vs_settings(const struct wined3d_state *state, const struct > & WINED3D_FFP_LIGHT_TYPE_MASK) << WINED3D_FFP_LIGHT_TYPE_SHIFT(i); > } > > + settings->ortho_fog = 0; > if (!state->render_states[WINED3D_RS_FOGENABLE]) > settings->fog_mode = WINED3D_FFP_VS_FOG_OFF; > else if (state->render_states[WINED3D_RS_FOGTABLEMODE] != WINED3D_FOG_NONE) > + { > settings->fog_mode = WINED3D_FFP_VS_FOG_DEPTH; > + > + if (state->transforms[WINED3D_TS_PROJECTION].u.m[0][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[1][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[2][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[3][3] == 1.0f) > + settings->ortho_fog = 1; > + } I'm going to guess "No, because the projection matrix is ignored.", but does this "feature" apply to transformed vertices as well?

1 0

Re: [PATCH 2/2] include/ddk: add usbioctl.h
by Nikolay Sivov July 22, 2013

July 22, 2013

On 7/22/2013 22:38, Damjan Jovanovic wrote: > Changelog: > * add usbioctl.h > > Damjan Jovanovic Hi, Damjan. You forgot patches.

3 2

Re: appwiz: Correct Wine Mono installer messages
by Alexandre Julliard July 22, 2013

July 22, 2013

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Where the correction is obvious I have done so, but where a full > translation is needed I have simply removed the incorrect one. This > will mark that line as untranslated and hopefully someone will see > that. It will also default to English with the correct message until > translated. That's what fuzzy is for, there's no reason to remove them. -- Alexandre Julliard julliard(a)winehq.org

3 3

Wine 1.6 list of deferred patches
by Bruno Jesus July 22, 2013

July 22, 2013

This is the list of (hopefully) all deferred patches for wine 1.6, all authors are in bcc. I hope it's useful for developers. 97187 Deferred Dmitry Timoshkov [3/3] kernel32: GetShortPathName for a non-existent short file name should fail. 97131 Deferred Rosen Diankov [ole32] Bugfix for implicit MTA apartment initialization 97130 Deferred Rosen Diankov [oleaut32] Bugfix patches for marshaling VT_UNKNOWN in SAFEARRAYS 97124 Deferred Maarten Lankhorst [RFC PATCH] loader: allow overriding pthread_create correctly on linux 97119 Deferred Fabian Ebner [PATCH] dinput: Check the message queue in GetDeviceState * 97085 Deferred Dmitry Timoshkov ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file. 96974 Deferred Stefan Dösinger [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader 96961 Deferred Mathis Beer ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3.5, alternate version) 96925 Deferred Hans Leidekker server: The token user SID must be present in the default DACL. 96899 Deferred Stefan Dösinger [PATCH 1/5] wined3d: Consolidate d3d_info BOOLs into a flags field 96855 Deferred Alistair Leslie-Hughes oledb32: Add IErrorInfo Support OK 96854 Deferred Alistair Leslie-Hughes msdaps: Add support for ISourcesRowset (try 2) 96831 Deferred Christian Costa [PATCH] d3dxof: Remove LP stuff and rename variables for IDirectXFile methods. 96819 Deferred Nikolay Sivov comctl32: Properly handle repainting for HDF_OWNERDRAW items 96797 Deferred André Hentschel ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32 (try 2) 96793 Deferred Christian Costa [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests. 96791 Deferred morphiend msvcrt: add support for _chsize_s 96765 Deferred Christian Costa [PATCH 2/4] d3dxof: Handle float in binary mode and remove code that becomes useless. * this patch was already commited.

1 0

Re: [PATCH 3/4] d3dx9: Improve ID3DXConstantTable::Set*().
by Alexandre Julliard July 22, 2013

July 22, 2013

Rico Schüller <kgbricola(a)web.de> writes: > +static UINT set(struct ID3DXConstantTableImpl *table, IDirect3DDevice9 *device, struct ctab_constant *constant, > + const void **indata, D3DXPARAMETER_TYPE intype, UINT *size, UINT incol, D3DXPARAMETER_CLASS inclass, UINT index, > + BOOL is_pointer) > +{ > + DWORD (*get_index)(const void **indata, UINT index) = NULL; > + D3DXCONSTANT_DESC *desc = &constant->desc; > + UINT l, i, regcount = 1, regsize = 1, cin = 1, rin = 1, ret, last = 0; > + DWORD tmp; > + > + if (is_pointer) get_index = &get_index_pointer; > + else get_index = &get_index_array; It would be cleaner and easier to follow to have a simple helper with a is_pointer flag, rather than using function pointers with such trivial functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 2)
by Nikolay Sivov July 21, 2013

July 21, 2013

On 7/20/2013 23:37, John Chadwick wrote: > This patch changes the create_selection interface to accept a wide string > instead of an xmlChar string. This is a transitional change, which will be > needed as libxml2's XPath parser is phased out. > > The last submission had a memory leak (sorry, I isolated this change > from some other changes and accidentally axed a heap_free in the > process.) Looks ok, I didn't try tests, but I hope you did.. One thing though: > +static inline WCHAR *heap_strcatW(WCHAR *a, const WCHAR *b) > +{ > + int len = strlenW(a) + strlenW(b); > + WCHAR *c = heap_realloc(a, (len + 1) * sizeof(WCHAR)); > + WCHAR *ptr = c; > + > + while(*ptr) > + ptr++; > + while(*b) > + *(ptr++) = *(b++); > + c[len] = 0; > + > + return c; > +} > + I'm assuming you didn't use strcatW() to avoid one more strlenW()? Even if you don't want to use it for some reason, you don't need first loop cause you already know 'a' length, and second loop is just strcpyW(). Also I suggest to use 'dst', 'src' names for parameters.

1 0

Coverity Status
by Marcus Meissner July 20, 2013

July 20, 2013

Hi, For Wine 1.6 we have the following Coverity stats: - 3,648,322 Lines of Code scanned - Defect Density 0.51 - 8321 total defects - 1852 outstanding (unresolved) defects - 1964 dismissed defects - 4505 fixed defects git shortlog wine-1.4..wine-1.6|grep -i Coverity|wc -l 225 Thanks to AmineKhaldi uploading the builds and everyone reviewing and fixing coverity issues :) Ciao, Marcus

1 0

Another major milestone
by Jeremy White July 19, 2013

July 19, 2013

Alright folks, I have to confess that the 1.6 release came and I didn't immediately get up and dance. In fact, a new Wine release was almost...boring. I think we have to consider that a major milestone in of itself. New, useful releases are just a matter of course for us now. Woohoo! Now I'm dancing <grin>. Cheers, Jeremy

8 9

Re: [docs] winelib: Use proper entity escaping for '&','<' and '>'
by Julian Rüger July 19, 2013

July 19, 2013

Hi Frédéric, > - $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $< | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ > + $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $lt; | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ looks like you forgot the "&". Best, Julian

2 1

Re: [2/2] gdiplus: Store graphics clipping region in device coordinates.
by Vincent Povirk July 19, 2013

July 19, 2013

I'm curious what happens if the world transform has some rotation. It seems like transform_rectf would break in that case.

2 2

Re: [1/2] windowscodecs: Add a test for global GIF palette exposed by recent Windows versions.
by Vincent Povirk July 19, 2013

July 19, 2013

The series looks good to me.

1 0

Re: [1/4] wincodecs: Added IWICBitmapClipper stub
by Vincent Povirk July 19, 2013

July 19, 2013

This series looks good to me.

1 0

Re: riched20: Add tests for ITextRange interface.
by Nikolay Sivov July 18, 2013

July 18, 2013

On 7/18/2013 20:28, Caibin Chen wrote: > Add tests for start and end point, setting and getting text. > --- > dlls/riched20/tests/Makefile.in | 3 +- > dlls/riched20/tests/txtrng.c | 343 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 345 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/tests/txtrng.c You could just use existing file, richole.c fits I think.

2 7

Re: Patches I maintain
by Rico Schüller July 18, 2013

July 18, 2013

Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You may have a look here: http://wiki.winehq.org/SubmittingPatches On 18.07.2013 01:23, Roland Haeder wrote: > +HRESULT D3DXCreatePolygon(LPDIRECT3DDEVICE9 device, float length, UINT sides, LPD3DXMESH *mesh, LPD3DXBUFFER adjacency) Well this looks a little bit wrong. You may have a look here http://msdn.microsoft.com/en-us/library/windows/desktop/bb172785%28v=vs.85%… . Don't copy and paste it. A patch which by accident works, is not something which should be applied at all. There are several issues alone in that line. Cheers Rico

2 1

Re: winedev: Add doc for winedbg symbol_picker option
by Frédéric Delanoy July 17, 2013

July 17, 2013

On Thu, Jul 18, 2013 at 12:48 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > en/winedev-debugger.sgml | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > Please discard this. It has been committed a long time ago. Sorry (again) for the noise. Frédéric

1 0

Manpage patch, please review
by Julian Rüger July 17, 2013

July 17, 2013

Hi all! While working on the translation of the (main) manpage, I noticed a few issues in the English version and started working on a patch. That was quite some time ago, I had little spare time lately and didn't get around to finish and send it in. So I figured I just take what I have now and ask you guys for comments. I appreciate any remarks or suggestions. Thanks, Julian Notes: I had a change similar to Frédéric's, mentioning wine can run 64-bit programs now. He was quicker and I like his wording better. I had something like "[...]or Win64 executable (if your version of wine was compiled with 64-bit support)." I guess that would be more confusing to people using their distro's wine packages and people compiling their own wine know that anyway. Do you agree or do you think it's better to be more specific? CUI -> CLI: According to Google and Wikipedia, CLI is more common. -.BR @bindir@/wineserver , +.IR @bindir@/wineserver , and following, similar changes: This is the way it is formatted in the wineserver manpage. I noticed there is no uniform style across our manpages, so we should have a guideline. Should paths be bold or italic/underlined?

2 4

Re: ieframe: Use SHANDLE_PTR in IWebBrowserApp::get_HWND.
by Marvin July 16, 2013

July 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26282 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 004033D1

2 1

Re: loader: Indicate wine can run 64-bit apps in manpage
by Frédéric Delanoy July 16, 2013

July 16, 2013

On Tue, Jul 16, 2013 at 4:57 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > loader/wine.man.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Please ignore this patch: I accidentally resent it. Sorry about the noise. Frédéric

1 0

Re: po: Update Turkish translation (second try)
by Francois Gouget July 16, 2013

July 16, 2013

-<<<<<<< HEAD -"PO-Revision-Date: 2013-07-13 04:49+0200\n" -======= -"PO-Revision-Date: 2013-07-04 00:10+0200\n" ->>>>>>> 598685e6c5992355de35b4345e91eb4e50b9f07e +"PO-Revision-Date: 2013-07-13 05:00+0200\n" [...] -#: attrib.rc:27 cmd.rc:322 +#: attrib.rc:27 cmd.rc:325 These look wrong: there is currently no conflict in the checked-in PO file and there should not be any line-number changes in the patch. So it won't apply to the current Git repository. Something must have happened when you rebased or generated the diff. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

1 0

Re: [PATCH 1/3] user32/tests: Sleep enough time to make sure all input message have been processed.
by Qian Hong July 16, 2013

July 16, 2013

Hello, This patch is marked as pending, is there anything I can improve? Did the test results in [1] and [2] help? Thanks for any feedback! [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 On Wed, Jul 3, 2013 at 2:45 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hello, > > Current menu test code may hide some failure tests [1], with the attached > patch, all failure tests could be detected [2]. > > > [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 > [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 > > > --- > dlls/user32/tests/menu.c | 1 + > 1 file changed, 1 insertion(+) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

2 6

Re: ntdll: Tests for RtlHashUnicodeString()
by Dmitry Timoshkov July 16, 2013

July 16, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +#include "ddk/wdm.h" Please don't do that, this breaks compilation with PSDK headers. If you need some specific definitions, types or API prototypes - replicate them in the test itself. -- Dmitry.

2 2

Re: riched20: ITextDocument stubs for ITextServices
by Frédéric Delanoy July 15, 2013

July 15, 2013

On Sun, Jul 14, 2013 at 3:50 AM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > You have to use your real name when submitting patches to wine-patches. Frédéric

1 0

How to configure C++ implements in wine?
by 中川祥 July 15, 2013

July 15, 2013

I'm working at User Access Logging API<http://msdn.microsoft.com/en-us/library/windows/desktop/hh437524(v=vs.85).a…> for Windows8. It need C++ style coding. How can I solve it?

2 1

Re: [docs 2/3] winedev: Use hyphen in bitness
by Frédéric Delanoy July 14, 2013

July 14, 2013

On Sun, Jul 14, 2013 at 7:41 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > en/winedev-architecture.sgml | 56 ++++++++++++++++++++++---------------------- > en/winedev-debugger.sgml | 10 ++++---- > en/winedev-kernel.sgml | 24 +++++++++---------- > en/winedev-multimedia.sgml | 36 ++++++++++++++-------------- > 4 files changed, 63 insertions(+), 63 deletions(-) > - (an int is 16 bit in 16-bit and 32 bits in 32-bit, pointers > + (an int is 16-bit in 16-bit and 32-bits in 32-bit, pointers This part sounds a bit weird... also, one is in plural with the other is in singular form. Probably would benefit from a sentence reorganization. Frédéric

1 0

Re: po: Tweak the French 'broadcast' and 'unicast' translations.
by Frédéric Delanoy July 13, 2013

July 13, 2013

On Fri, Jul 12, 2013 at 4:33 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > Surprisingly enough (for me) the existing translations match the term > used in Microsoft's Terminology file: > "broadcast address" -> "adresse de diffusion" > "broadcast" -> "diffusion" > "multicast" -> "multidiffusion" > "unicast" -> "monodiffusion" > > https://www.microsoft.com/Language/en-US/Terminology.aspx > > But I still don't think they're good translations. I find 'diffusion' > way too general and vague. Reading it I would certainly not make the > link with broadcast, even in the domain of networking. Similarly I don't > think 'monodiffusion' would be readily understood. > > So I'm more enclined to follow Wikipedia which uses the untranslated > terms as the title of their French articles: Well they're just untranslated... you said it The "grand dictionnaire terminologique" (http://gdt.oqlf.gouv.qc.ca/Resultat.aspx) gives broadcast -> diffusion (générale) multicast -> multidiffusion / diffusion groupée (beurk) monocast -> envoi individuel http://glossaire.traduc.org/ (used for manpages/howtos) gives broadcast -> diffusion multicast -> multidiffusion unicast -> unicast BTW to broadcast = diffuser I may agree with unicast but the "diffusion" and "multidiffusion" seem OK to me

3 4

Re: po: update Simplified Chinese translation
by Francois Gouget July 12, 2013

July 12, 2013

I'll take this opportunity to note that Microsoft's Simplified Chinese Style Guide says: | Colon | * Software localization: Use English colon (:) in Software | localization. A single byte space should be left between the | English colon and the subsequent characters (Chinese full-width | punctuation marks are excluded). For documentation they say to use a double byte colon. So it seems like our PO files should actually be using single-byte colons everywhere. Does this make sense? http://download.microsoft.com/download/4/c/a/4ca95933-3496-4793-9d77-a89b60… As an additional not, I don't think this is grounds for rejecting this patch given that it is consistent with existing translations. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: po: Some Franch translation tweaks.
by Frédéric Delanoy July 12, 2013

July 12, 2013

On Fri, Jul 12, 2013 at 1:16 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > po/fr.po | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) There's a typo in the commit message (you probably spotted it already). > msgstr "" > "PAUSE affiche un message à l'écran demandant à l'utilisateur d'appuyer sur " > -"une touche.\n" > +"une\n" > +"touche.\n" This is probably not needed > msgid "Drive Mapping" > -msgstr "Assignation de lecteur" >+msgstr "Dossier cible" Are you sure about this one? Maybe the original should be changed as well in this case... Frédéric

2 1

Re: po: Fix the French DEL, ERASE, RD and RMDIR usage messages.
by Frédéric Delanoy July 12, 2013

July 12, 2013

On Fri, Jul 12, 2013 at 12:34 PM, Francois Gouget <fgouget(a)free.fr> wrote: > msgid "DEL <filename> deletes a file or set of files.\n" > -msgstr "DEL <fichiers> efface un fichier ou un groupe de fichiers.\n" > +msgstr "DEL <fichier> efface un fichier ou un groupe de fichiers.\n" "fichiers" indicate it can be any number of files, replacing by the singular form doesn't (one may think only one file is deletable per command) If you absolutely want the same singular ou plural form, the English msgid it what should be changed instead IMO Same remark for your ERASE diff hunk. Regards, Frédéric

1 0

Re: po: Fix some typography and linefeed issues in the Turkish translation.
by Francois Gouget July 12, 2013

July 12, 2013

On Thu, 11 Jul 2013, Volkan Gezer wrote: [...] > Thank you for modifications. I think the only problem is: > > #: cryptui.rc:38 > msgid " to " > -msgstr " bitişi: " > +msgstr " bitişi " > > which we should keep ":" for a meaningful sentence structure. Hasan > should also correct me if I am wrong. Ok. That seems a bit strange but probably less strange than the way the code builds this string :-( It seems it does it does it this way to put parts of it in bold. I've added an exception for it and I'm resending the rest of the patch. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 1

Re: po: update Simplified Chinese translation
by Qian Hong July 12, 2013

July 12, 2013

#: winerror.mc:3016 -#, fuzzy msgid "Unknown interface.\n" -msgstr "不明来源。\n" +msgstr "未知界面。\n" Please keep persistent for the translation of 'interface'. Here 'Unknown interface.' is used with RPC_S_UNKNOWN_IF, should be translate to '接口' as well as other place. #: winecfg.rc:260 msgid "Voice output device:" -msgstr "" +msgstr "语言输出设备：" #: winecfg.rc:261 msgid "Input device:" @@ -12313,7 +12281,7 @@ msgstr "输入设备：" #: winecfg.rc:262 msgid "Voice input device:" -msgstr "" +msgstr "语音输入设备：" Please keep persistent for the translation of 'voice', it seems like a typo here, one translated to 语言 while the other translated to '语音'. #: winerror.mc:186 msgid "Sharing violation.\n" -msgstr "" +msgstr "非法共享。\n" #: winerror.mc:191 -#, fuzzy msgid "Lock violation.\n" -msgstr "位置。\n" +msgstr "非法锁定。\n" #: winerror.mc:696 -#, fuzzy msgid "Cancel violation.\n" -msgstr "信息。\n" +msgstr "非法取消。\n" The above three reference to: ERROR_SHARING_VIOLATION （共享冲突？） ERROR_LOCK_VIOLATION （锁冲突？） ERROR_CANCEL_VIOLATION （？） http://support.microsoft.com/kb/316609/en-us http://support.microsoft.com/kb/2698155/en-us http://support.microsoft.com/kb/155011/en-us I'm not sure your translation is correct, they are tricky to translate, for ERROR_CANCEL_VIOLATION, even the original English version is hard to understand :( maybe keep the English version is not a bad idea if there is no better alternative so far. Thanks for the work! On Fri, Jul 12, 2013 at 8:09 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > > > > -- Regards, Qian Hong - http://www.winehq.org

2 1

po: update Simplified Chinese translation
by Jactry Zeng July 12, 2013

July 12, 2013

1 0

Re: ole32: Tests for CLSIDFromProgID() and ProgIDFromCLSID() regarding activation context
by Marvin July 12, 2013

July 12, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26261 Your paranoid android. === W2KPROSP4 (32 bit compobj) === compobj: unhandled exception c0000005 at 00000000

1 0

Re: cmd: Fix a usage message: the % must be doubled for FOR variables. (resend)
by Alexandre Julliard July 12, 2013

July 12, 2013

Francois Gouget <fgouget(a)free.fr> writes: > The usage message was in fact documenting an old Wine bug. > --- > > The attempt did not apply, probably because I had other changes in my > tree. Hopefully this one will work. > > > I'm reluctant to change messages at this stage as it's going to cause > fuzzying of the translations, but given that this message is plain wrong > I think it's warranted. I'd suggest to simply remove the sentence, and remove it in translations too so that we don't need to invalidate all of them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime. (try 2)
by Bruno Jesus July 12, 2013

July 12, 2013

On Thu, Jul 11, 2013 at 11:19 AM, Sylvain Petreolle <spetreolle(a)yahoo.fr> wrote: > --- > dlls/wbemprox/builtin.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c > index 9e2369a..5b7674e 100644 > --- a/dlls/wbemprox/builtin.c > +++ b/dlls/wbemprox/builtin.c > @@ -1774,6 +1778,31 @@ static WCHAR *get_lastbootuptime(void) > + > + GetLocalTime(&st); > + Status = GetTimeZoneInformation(&tzi); > + > + if(Status == TIME_ZONE_ID_INVALID) return NULL; Aren't you leaking ret here? Maybe you could swap this check with the memory allocation. > + sprintfW( ret, fmtW, st.wYear, st.wMonth, st.wDay, st.wHour, st.wMinute, st.wSecond, st.wMilliseconds * 1000, -Bias); Is it ok for the + sign to the fixed in the format? Best wishes, Bruno

2 1

Re: po: Czech - corrected omission of some newline marks
by Alexandre Julliard July 11, 2013

July 11, 2013

Pavel Borecki <pavel.borecki(a)gmail.com> writes: > @@ -3060,7 +3122,7 @@ > > #: hhctrl.rc:62 winhlp32.rc:31 > msgid "&Print..." > -msgstr "&Tisknout..." > +msgstr "&Tisknout" Please keep the three dots, that's apparently the standard. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: Standardize and simplify two error messages.
by Andrew Eikum July 10, 2013

July 10, 2013

On Wed, Jul 10, 2013 at 10:42:05AM +0200, Francois Gouget wrote: > We don't have a MIDI Mapper configuration applet so don't tell the user to use it. > --- > > Or if we do, how does one get to it? I did not find anything in > winecfg.exe, nor in control.exe (the Control Panel). > > -MIDIERR_NODEVICE, "The current MIDI Mapper setup refers to a MIDI device that is not installed on the system. Use MIDI Mapper to edit the setup." I think it's meant to refer to the "MIDI Mapper" device, which is configurable through the registry: http://wiki.winehq.org/MIDI I think your change is clearly an improvement. Andrew

1 0

Should we translate the prompt
by Jactry Zeng July 10, 2013

July 10, 2013

Hi everybody, In po file there were some prompts as this: #: xcopy.rc:35 msgid "%1? (Yes|No)\n" I am not sure that should I translate them in po file for Simplified Chinese. But they have been translated in po file for French and Traditional Chinese. As prompts in command line, I don't think translating them into another language is good. It may make the users don't know what should them type into. When I discuss this with Qian Hong, he give a better idea. We may can just make the origin text more apropos, just like: msgid "%1? (Y)es|(N)o\n" So that we can translate it into Simplified Chinese: msgid "%1？是(Y)|否(N)\n" Thanks for any comment. -- Regards, Jactry Zeng

3 3

Re: readme: Update German translation
by Joerg Schiermeier July 9, 2013

July 9, 2013

> Hi ... list, Hi Julian > I think "liesmich" is more common than "lesmich", although both sound > awkward. Do we need/want to translate that? Yes really. 'Liesmich' is a direct translation of 'readme'. Eventually this older translation was a simply typo? So please change this! Thanks. > Best, > Julian -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: readme: Update German translation
by Julian Rüger July 9, 2013

July 9, 2013

Am Dienstag, den 09.07.2013, 00:46 +0200 schrieb André Hentschel: > --- > documentation/README.de | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > Hi André and list, patch looks good to me. One minor remark: > + wine notepad.exe lesmich.txt (Programmaufruf mit Parametern) I think "liesmich" is more common than "lesmich", although both sound awkward. Do we need/want to translate that? Best, Julian PS: I have some more manpage-patches in the works, but my spare time has been a little scarce lately. Do you think 1.6 will be released Friday?

3 2

Re: po: Arabic full translated wine. (try2)
by Yaron Shahrabani July 8, 2013

July 8, 2013

Non critical changes but take a look if you like: #: comdlg32.rc:186 comdlg32.rc:141 -#, fuzzy msgid "Save As" msgstr "احفظ &ك‍..." Redundant Elipsis. #: comdlg32.rc:202 -#, fuzzy msgid "S&election" -msgstr "اختر ال&كل\tCtrl+A" +msgstr "الاختيار" #: comdlg32.rc:203 -#, fuzzy msgid "&Pages" -msgstr "صفحة &p" +msgstr "صفحات" #: comdlg32.rc:206 comdlg32.rc:228 -#, fuzzy msgid "&Setup" -msgstr "إعداد الصفحة" +msgstr "إعداد" No accelerator (&) sign. #: comdlg32.rc:207 msgid "&From:" -msgstr "" +msgstr "&من" #: comdlg32.rc:208 msgid "&To:" -msgstr "" +msgstr "&إلى" No semicolon at the end. #: comdlg32.rc:211 -#, fuzzy msgid "Print to Fi&le" -msgstr "ملفات النصوص (*.txt)" +msgstr "اطبع إلى ملف" #: comdlg32.rc:268 msgid "Scr&ipt:" -msgstr "" +msgstr "ترميز" No accelerator sign. #: comdlg32.rc:281 comdlg32.rc:304 msgid "Color | Sol&id" -msgstr "" +msgstr "اللون | &جامد" No need to add اللون |‏ before the &جامد part. There might be more. Anyways great job! Kind regards, Yaron Shahrabani <Hebrew translator> On Sun, Jun 30, 2013 at 6:27 AM, مصعب الزعبي <moceap(a)hotmail.com> wrote: > --- > > po/ar.po > > > > > >

2 1

Re: [PATCH] gdiplus: fixing identical sub-expressions
by Vincent Povirk July 7, 2013

July 7, 2013

I'm not sure we should change this during code freeze.

1 0

Bug 24018 which appears to be a showstopper for running Cygwin on Wine
by Alan W. Irwin July 5, 2013

July 5, 2013

Andrey Turkin has stated at http://bugs.winehq.org/show_bug.cgi?id=24018 that this is really a Cygwin bug. I frankly don't understand the technical details but his current test (an infinite loop with Cygwin fork calls) may need some beefing up to convince the Cygwin developers they have introduced a regression. The reason why I mention a Cygwin regression is the winetricks script mentions bug 24018 and works around it by downloading an old version of the Cygwin installer. I haven't tried that myself yet, but if that workaround still works, then this is evidence that the issue is a Cygwin regression which is an important consideration when reporting this issue to the Cygwin developers. Andrey Turkin was asked at http://bugs.winehq.org/show_bug.cgi?id=24018 to report the issue to Cygwin, but my search of the Cygwin mailing list archive didn't find any post from him and only found one extremely casual (an aside to a completely different thread) mention (http://sourceware.org/ml/cygwin/2013-06/msg00471.html) from a different wine developer of bug 24018 with no response to that mention. I currently have no experience with Cygwin and my only real interest in Cygwin on Wine is it theoretically provides an alternative build platform to my present successful work with the combination of MinGW, MSYS, and Wine as a Windows build platform. But I haven't even been able to get started with Cygwin on Wine because of this showstopping bug. Therefore, I am mentioning the situation here in the hope that some wine developer on this list with some knowledge of Cygwin will take the responsibility of making a proper bug report to the Cygwin mailing list (which according to http://cygwin.com/problems.html is the correct place to report Cygwin bugs) including the evidence that the issue is a Cygwin regression (assuming investigation of older Cygwin versions with Turkin's test supports that conclusion). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

7 26

Re: po: Update Simplified Chinese translation. (newer)
by Qian Hong July 5, 2013

July 5, 2013

Hi Andrew, While discussing the translation of 'Voice output device' and 'Voice input device' in winecfg, Jactry and I have no idea what does 'voice' mean here. Voice could be translated to both '声音‘ and '语音' in Chinese, the former means all kinds of sound, the latter means human voice only, which one is more accurate? I know you've subscribed wine-devel, I CC'ed you because you are the original contributor to the 'voice input device' related code. Thanks a lot! On Fri, Jul 5, 2013 at 9:53 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > Please ignore the first patch, I modify some in this one. > Thanks advice from Qian Hong. > > > -- Regards, Qian Hong - http://www.winehq.org

3 3

Re: [PATCH] windowscodecs/tests: Fix a test failure [newwtb and other]
by Dmitry Timoshkov July 5, 2013

July 5, 2013

Detlef Riekenberg <wine.dev(a)web.de> wrote: > - /* global palette */ > + /* global palette. This succeed since win7sp1 with platform update / win8 */ This comment is not helpful. > hr = IWICBitmapDecoder_CopyPalette(decoder, palette); > - ok(hr == WINCODEC_ERR_FRAMEMISSING, > - "expected WINCODEC_ERR_FRAMEMISSING, got %#x\n", hr); > + ok((hr == S_OK) || (hr == WINCODEC_ERR_FRAMEMISSING), > + "expected S_OK or WINCODEC_ERR_FRAMEMISSING, got %#x\n", hr); One of test results should be marked as broken, and in the S_OK case the resulting palette should be tested and released. I'd guess that newer version should be taken as a model to follow, and Wine implementation should be fixed appropriately. -- Dmitry.

1 0

po: Revert Japanese shell path name updates.
by Akihiro Sagawa July 4, 2013

July 4, 2013

Could you revert recent Japanese translation updates[1] or commit attached patch? As I mention in the last mail[2], patch 91758[3] has some issues, especially when retrieving shell path names. Although path names are not localized in Japanese Windows Vista (and its successors), they are (mistakenly?) included in the last commit. To prove this, I submitted a job to winetestbot [4]. However, new winetestbot seems to be stuck. Alternatively, I attach my Japanese Windows 7 result. The line which begins shellpath.c:443 is my additional output. You can see that all path names are not translated. [1] http://source.winehq.org/git/wine.git/commit/0fb9de61a5026ac6cf16bc3385c382… [2] http://www.winehq.org/pipermail/wine-devel/2013-June/100377.html [3] http://source.winehq.org/patches/data/97158 [4] https://newtestbot.winehq.org/JobDetails.pl?Key=1432 --- po/ja.po | 63 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 31 insertions(+), 32 deletions(-)

3 3

RFC: Three dots or Unicode ellipsis character
by Francois Gouget July 4, 2013

July 4, 2013

Wine uses three dots (...) rather than the Unicode ellipsis character (…) except in the Czech and Taiwanese translations that use the Unicode ellipsis character. I think we should be consistent but the question is which to use. I looked at the Windows interface guidelines and they don't have anything to say on this. http://msdn.microsoft.com/en-us/library/windows/desktop/aa974176.aspx#punct… http://msdn.microsoft.com/en-us/library/windows/desktop/aa511453.aspx#ellip… Looking at what other platforms do, the Apple interface guidelines recommend using the Unicode ellipsis character saying assistive technologies need it. The GNOME and KDE guidelines don't have an official position but seem to use the Unicode character anyway: http://simos.info/blog/archives/17 So should we go with the flow and switch to using ellipsis characters or should we stick with three dots? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

3 3

Possible help or direction to build Win to Linux pass through device - resent
by Pavel Pisa July 4, 2013

July 4, 2013

Hello all Wine developers, [the second attempt to send, is the list subscribers only?] the firs I would like to express my respect to the work done. Now to one of our application, we maintain open-source chromatographic software CHROMuLAN https://sourceforge.net/projects/chromulan/ Unfortunately, it is written in Delphi (version 6 used) and we have not resources to port it to run native on Linux even that Linux is for last 18 years our main development platform for embedded hardware design and development. Our long term is to port application to Lazarus/FPC or even rewrite in in Qt but that is not option now. Fortunately, the CHROMuLAN application runs quite well under latest Wine version. But we have problem with access to the data acquisition hardware. The devices are connected to computer through special protocol (uLAN) RS-485 network. We have drivers for Linux (the firs platform), Windows (even 64-bit tested) and other targets. All for PCI, RS-232/485 converters and PCI RS-485 addon cards. Whole stack even runs under ReactOS in QEMU now. But Wine is more pleasant solution when someone uses Linux as his/her main desktop system. https://sourceforge.net/projects/ulan/ Problem is that I loke to provide driver API to the Wine application. The real windows driver is KMD/WMD "ul_wdm.sys" which is registered as "\\\\.\\UL_DRV" by IoCreateDevice and IoCreateSymbolicLink. Driver provides some context per each open and then read, write and iocts are used. We have exactly the same drive for Linux (x86, 64-bit, MIPS, ARM, PowerPC) with same functionality but Linux IOCTLs numbers are built different way and there are some slight differences caused by differences in Win API IOCTLs processing and Windows does not support poll equivalent for devices too. I have studied Wine and wineserver more times and have not found how to achieve provision of the Linux driver to the Wine application. Or more or less found that there would be problem because wineserver seems to deliver only IOCTLs events. But I was not sure so I have finally proven that by trial. I have written DLL/SYS as a driver supporting all required IRP_MJ_xxx and IOCTLs in the style of KMD/WMD driver and implemented functions as calling to the Linux "/dev/ulan" operation equivalents. But it really does not work. Only IOCTLs are delivered to the ul_drv.sys and even that fails because open context is not setup. Pointer irpStack->FileObject is filled with 0x66666666. You can find my attempt at http://cmp.felk.cvut.cz/~pisa/ulan/wine/ Now to the questions, Is there some mechanism in Wine which I could use? Is there chance to do that as little intrusive (i.e. DLL) that it can be acceptable for Wine mainline? It seems that serial port device somehow solves similar problem but is seems to be hardwired to wineserv. As for my case, it is possible that read and write to the open /dev/ulan file are done directly from context of application if it receives Linux filehandle into wine/dlls/ntdll/file.c . If the new FD_TYPE_ (FD_TYPE_SERIAL) is defined then all processing can be done in Linux native NTDLL. Even IOCTLs translation because they are really straightforward (like wine-git/dlls/ntdll/serial.c does in COMM_DeviceIoControl). But such solution seems intrusive to me. On the other hand the structure struct object_ops in wine/wine/server/object.h seems to provide all operations. Can I use some registration in the server to solve access? I am missing something? Is there some suggestion which approach to take? Some reasonable simple solution is preferred because if projects takes too much time it would even more postpone possibility to start real application porting. Thanks for each possible advice, Pavel -- Pavel Pisa e-mail: pisa(a)cmp.felk.cvut.cz www: http://cmp.felk.cvut.cz/~pisa university: http://dce.fel.cvut.cz/ company: http://www.pikron.com/

3 5

Re: kernel/tests: Test behaviour of TPIDRURW register with threads on ARMv7
by Dmitry Timoshkov July 3, 2013

July 3, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > +#if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__) || defined(__ARM_ARCH_7R__) > +static inline void set_tpidrurw(DWORD tpidrurw) > +{ > + __asm__ volatile ("mcr p15, 0, %0, c13, c0, 2" : : "r" (tpidrurw)); > +} > + > +static inline DWORD get_tpidrurw(void) > +{ > + DWORD tpidrurw = 0; > + __asm__ volatile ("mrc p15, 0, %0, c13, c0, 2" : "=r" (tpidrurw)); > + return tpidrurw; > +} This code is gcc specific and for instance won't compile with PSDK compiler. It either needs to be protected or replaced with hex/binary form. -- Dmitry.

1 0

Re: msxml3/tests: Add additional conformance tests to the xpath tests (try 2)
by Alexandre Julliard July 3, 2013

July 3, 2013

John Chadwick <johnwchadwick(a)gmail.com> writes: > This patch adds additional xpath tests to the msxml3 tests. Following > Nikolay Sivov's advice, these provide a wide range of new tests, two > of which currently fail in Wine (for reasons previously described.) > These are now marked 'todo' in a much cleaner way. It doesn't work here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok domdoc.c:4468: Test succeeded inside todo block: query=ancestor-or-self::node(), invalid node list: D1 E2.D1, expected D1 E2.D1 domdoc.c:4468: Test succeeded inside todo block: query=(//a[1])[last()], invalid node list: E1.E4.E2.D1, expected E1.E4.E2.D1 make: *** [domdoc.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: Re: RFC: Three dots or Unicode ellipsis character
by Michael Stefaniuc July 3, 2013

July 3, 2013

-------- Original Message -------- Subject: Re: RFC: Three dots or Unicode ellipsis character Date: Wed, 03 Jul 2013 19:32:15 +0200 From: Michael Stefaniuc <mstefani(a)redhat.com> To: Francois Gouget <fgouget(a)free.fr> On 07/03/2013 04:45 PM, Francois Gouget wrote: > > Wine uses three dots (...) rather than the Unicode ellipsis character > (…) except in the Czech and Taiwanese translations that use the Unicode > ellipsis character. > > I think we should be consistent but the question is which to use. > > > I looked at the Windows interface guidelines and they don't have > anything to say on this. > > http://msdn.microsoft.com/en-us/library/windows/desktop/aa974176.aspx#punct… > http://msdn.microsoft.com/en-us/library/windows/desktop/aa511453.aspx#ellip… > > Looking at what other platforms do, the Apple interface guidelines > recommend using the Unicode ellipsis character saying assistive > technologies need it. The GNOME and KDE guidelines don't have an > official position but seem to use the Unicode character anyway: > > http://simos.info/blog/archives/17 > > > So should we go with the flow and switch to using ellipsis characters or > should we stick with three dots? How will the substitution work in the W2A case? bye michael

1 0

Windows RT Applications finally can run in Wine/ARM with upcoming Linux releases
by André Hentschel July 3, 2013

July 3, 2013

Hi, Wanted to let you know that the patch that allows that just got committed in Linus tree: [1] This means that Kernel 3.11 will have everything to run applications ported to Windows RT. A good list of such applications and libraries can be found at [2]. See [3] & [4] for more information on the Wine side. [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a… [2] http://forum.xda-developers.com/showthread.php?p=36534446 [3] http://bugs.winehq.org/show_bug.cgi?id=31322 [4] http://bugs.winehq.org/show_bug.cgi?id=31308

1 0

Re: gdiplus: Added support for UTF16 encoded strings in load_ttf_name_id
by Alexandre Julliard July 3, 2013

July 3, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > This patch fixes bug 33880. It's reported as regression but I think > that it stopped working because of game update. I would guess that it's because gdi32 is properly loading localized names now. Gdiplus should most likely replicate that method. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet/tests: Statically initialize and name the notification_cs critical section.
by Marvin July 3, 2013

July 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26207 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [wbemprox] Patches for adding currentclockspeed in record_processor
by Hans Leidekker July 3, 2013

July 3, 2013

On Mon, 2013-07-01 at 08:56 +0900, Rosen Diankov wrote: > diff -ru wine-1.6-rc3-old/dlls/wbemprox/builtin.c wine-1.6-rc3/dlls/wbemprox/builtin.c > --- wine-1.6-rc3-old/dlls/wbemprox/builtin.c 2013-06-22 03:24:01.000000000 +0900 > +++ wine-1.6-rc3/dlls/wbemprox/builtin.c 2013-06-27 23:04:20.170154454 +0900 Please use git to generate patches. > @@ -168,6 +168,8 @@ > {'M','a','n','u','f','a','c','t','u','r','e','r',0}; > static const WCHAR prop_maxclockspeedW[] = > {'M','a','x','C','l','o','c','k','S','p','e','e','d',0}; > +static const WCHAR prop_currentclockspeedW[] = > + {'C','u','r','r','e','n','t','C','l','o','c','k','S','p','e','e','d',0}; Please keep properties sorted here and below. > static const WCHAR prop_memberW[] = > {'M','e','m','b','e','r',0}; > static const WCHAR prop_methodW[] = > @@ -381,6 +383,7 @@ > { prop_familyW, CIM_UINT16, VT_I4 }, > { prop_manufacturerW, CIM_STRING|COL_FLAG_DYNAMIC }, > { prop_maxclockspeedW, CIM_UINT32, VT_I4 }, > + { prop_currentclockspeedW, CIM_UINT32, VT_I4 }, > { prop_nameW, CIM_STRING|COL_FLAG_DYNAMIC }, > { prop_numcoresW, CIM_UINT32, VT_I4 }, > { prop_numlogicalprocessorsW, CIM_UINT32, VT_I4 }, > @@ -633,6 +636,7 @@ > UINT16 family; > const WCHAR *manufacturer; > UINT32 maxclockspeed; > + UINT32 currentclockspeed; > const WCHAR *name; > UINT32 num_cores; > UINT32 num_logical_processors; > @@ -1690,7 +1694,33 @@ > regs_to_str( regs, 16, name + 32 ); > } > } > -static UINT get_processor_maxclockspeed( void ) > +static void get_processor_clockspeeds( UINT* maxclockspeed, UINT* currentclockspeed ) > +{ > + PROCESSOR_POWER_INFORMATION *info; > + UINT size = get_processor_count() * sizeof(PROCESSOR_POWER_INFORMATION); > + NTSTATUS status; > + > + if ((info = heap_alloc( size ))) > + { > + status = NtPowerInformation( ProcessorInformation, NULL, 0, info, size ); > + if (!status) > + { > + *maxclockspeed = info[0].MaxMhz; > + *currentclockspeed = info[0].CurrentMhz; > + } > + heap_free( info ); > + } > + if( !!maxclockspeed ) > + { > + *maxclockspeed = 1000; > + } > + if( !!currentclockspeed ) > + { > + *currentclockspeed = 1000; > + } > +} You probably didn't mean to query the clock speeds and then overwrite them with static values. NULL checks are not needed in helpers like this. > +/*static UINT get_processor_maxclockspeed( void ) > { > PROCESSOR_POWER_INFORMATION *info; > UINT ret = 1000, size = get_processor_count() * sizeof(PROCESSOR_POWER_INFORMATION); > @@ -1703,7 +1733,8 @@ > heap_free( info ); > } > return ret; > -} > +}*/ Don't comment out code. Remove it. > static const WCHAR *get_osarchitecture(void) > { > SYSTEM_INFO info; > @@ -1717,7 +1748,7 @@ > static const WCHAR fmtW[] = {'C','P','U','%','u',0}; > WCHAR device_id[14], processor_id[17], manufacturer[13], name[49] = {0}; > struct record_processor *rec; > - UINT i, offset = 0, maxclockspeed, num_cores, num_logical_processors, count = get_processor_count(); > + UINT i, offset = 0, maxclockspeed = 0, currentclockspeed = 0, num_cores, num_logical_processors, count = get_processor_count(); > enum fill_status status = FILL_STATUS_UNFILTERED; > > if (!resize_table( table, count, sizeof(*rec) )) return FILL_STATUS_FAILED; > @@ -1726,7 +1757,7 @@ > get_processor_manufacturer( manufacturer ); > get_processor_name( name ); > > - maxclockspeed = get_processor_maxclockspeed(); > + get_processor_clockspeeds(&maxclockspeed, &currentclockspeed); > num_logical_processors = get_logical_processor_count( &num_cores ) / count; > num_cores /= count; You're not using currentclockspeed.

2 4

Re: [docs] winedev: Update backtrace and relay examples
by Frédéric Delanoy July 2, 2013

July 2, 2013

On Tue, Jul 2, 2013 at 11:39 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > en/winedev-debugger.sgml | 269 ++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 222 insertions(+), 47 deletions(-) > > diff --git a/en/winedev-debugger.sgml b/en/winedev-debugger.sgml > index b877063..31046c0 100644 > --- a/en/winedev-debugger.sgml > +++ b/en/winedev-debugger.sgml > @@ -280,31 +280,208 @@ winedbg hl.exe -windowed > These usually show up like this: > </para> > <screen> > -|Unexpected Windows program segfault - opcode = 8b > -|Segmentation fault in Windows program 1b7:c41. > -|Loading symbols from ELF file /root/wine/wine... > -|....more Loading symbols from ... > -|In 16 bit mode. > ... Maybe you can leave the 16 bit stuff there and have the 32 bit as an addition, not a replacement? Frédéric

2 1

Mayhem analysis of Wine
by André Hentschel July 2, 2013

July 2, 2013

Hi, wanted to let you know that i've seen "Reporting 1.2K crashes" [1] and searched for Wine results [2] and it seems we raised no issues with that "testsuite". Though it's not designed to test Wine, i felt happy not to see Wine on a list of faulty applications ;) [1] http://lists.debian.org/debian-devel/2013/06/msg00720.html [2] http://forallsecure.com/programs/search?search=wine

1 0

Re: [PATCH 3/3] user32: Deactivate popup menu if accelerator key not found when tracking top level menu.
by Qian Hong July 2, 2013

July 2, 2013

Update: The commit message is a bit misleading, should be 'user32: Deactivate menu if accelerator key not found when tracking top level menu.', removed the word 'popup'. Sorry for the trouble. On Wed, Jul 3, 2013 at 2:45 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > --- > dlls/user32/menu.c | 6 +++++- > dlls/user32/tests/menu.c | 6 +++--- > 2 files changed, 8 insertions(+), 4 deletions(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 2/3] user32/tests: Added tests for non-existent accelerator key.
by Qian Hong July 2, 2013

July 2, 2013

Hello, On Wed, Jul 3, 2013 at 2:41 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Current menu test code may hide some failure tests [1], with the attached > patch, all failure tests could be detected [2]. > > > [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 > [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 Please ignore the above comments, they should be in [Patch 1/3], sorry for the mistake. They attached patch itself is OK. Thanks. -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: Wine release 1.6-rc4
by Neumann, A. D. July 2, 2013

July 2, 2013

Hello, I changed my email address. Please send this information to: info.adneumann(a)t-online.de Thank you! D. Neumann Am 28.06.2013 22:02, schrieb Alexandre Julliard: > The Wine development release 1.6-rc4 is now available. > > What's new in this release (see below for details): > - Bug fixes only, we are in code freeze. > > The source is available from the following locations: > > http://prdownloads.sourceforge.net/wine/wine-1.6-rc4.tar.bz2 > http://mirrors.ibiblio.org/wine/source/1.6/wine-1.6-rc4.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/download > > You will find documentation on http://www.winehq.org/documentation > > You can also get the current source directly from the git > repository. Check http://www.winehq.org/git for details. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > ---------------------------------------------------------------- > > Bugs fixed in 1.6-rc4 (total 38): > > 7597 No sound with OSS driver in C&C3 > 11224 Throw In (Blitz Basic game) has a memory access violation > 11675 Flatout 2 demo, Battlefield 2 demo, many others need native d3dx9_36.D3DXCreateEffect* > 12771 Multiple graphic problems in "The Witcher" > 13314 Winevdm displays a window when running Civilization I > 13662 dogfood: xchat-2.6.2 is very slow, while updating the window > 14318 Michisoft Reader Studio v1.5a fails to produce LIT file from HTML > 16325 incorrect font rendering for CJK programs > 16784 Babylon 7: Trial mode expires after installation > 18930 IDA Pro: Failing to allocate an enormous image > 20769 crash when exiting Microsoft Flight Simulator 98 > 20771 the menu bar doesn't work in M. Flight Simulator 98 > 21103 Presentation 14.2 (Neurobehavioral Systems): crashes when displaying video output > 21827 Photoshop 7, Slider disapear > 22291 DC++ hangs on exit > 23504 Subpixel Font rendering wrong for font MS Sans Serif > 23687 err:seh:setup_exception_record stack overflow when start Proteus7 Ares > 23945 Textures are not properly rendered in Deus-Ex:Invisible War > 24230 "Psalmen - Lieder des Lebens" crashes when clicking Next in settings pane > 24796 DIY Kyoto's Holmes fails to start > 25125 Can only print to the default CUPS printer from Visio 5 Professional > 25605 The Settlers 3: Save as bitmap crashes world editor > 26646 Worms Reloaded: sound choppy without hardware sound = emulation > 27658 3dvia plugin installer crashes > 28495 Runes of Magic: sometimes mouse cursor freezes > 29897 Lord Of the Rings Online Slow/Freezes > 29959 Zed: 3D Preview window is blank or doesn't open. > 30578 Disassembly not in fixed-width font in IDA Pro 6.2 demo > 30897 Europa Universalis III demo crashes while 'Loading Map-Sprites...' without native d3dxof > 31729 cl.exe: stack overflow with certain long command lines > 31772 NtQuerySystemInformation doesn't fill ReturnLength properly with SystemProcessInformation > 31812 Silverlight 4.x/5.x windows have repainting problems > 31908 Garena Blackshot does login > 32820 Offline rekening overzicht, orov doesn't work > 33283 Configuration of WM_NAME is delayed for virtual desktop > 33753 Titan Quest : Multiplayer not working > 33865 Regression in a specialized program > 33883 Scirra httpapi.dll error trying to Run a game > > ---------------------------------------------------------------- > > Changes since 1.6-rc3: > > Alexandre Julliard (22): > gdi32: Cache the font smoothing parameters. > kernel32: FormatMessage precision arguments are integers. > comdlg32: Add support for the CF_NOVERTFONTS flag. > clock: Don't offer vertical fonts in the font dialog. > notepad: Don't offer vertical fonts in the font dialog. > winecfg: Don't offer vertical fonts in the font dialog. > wineconsole: Don't offer vertical fonts in the font dialog. > winefile: Don't offer vertical fonts in the font dialog. > wordpad: Don't offer vertical fonts in the font dialog. > make_unicode: Move codepage file output code to a common routine and make default characters configurable. > libwine: Add support for codepage 10001 (Mac Japanese). > libwine: Add support for codepage 10002 (Mac Traditional Chinese). > libwine: Add support for codepage 10003 (Mac Korean). > libwine: Add support for codepage 10008 (Mac Simplified Chinese). > libwine: Add support for codepage 10010 (Mac Romanian). > libwine: Add support for codepage 10017 (Mac Ukrainian). > libwine: Add support for codepage 10021 (Mac Thai). > libwine: Add support for codepage 10082 (Mac Croatian). > krnl386: Create a new console for DOS binaries. > winevdm: Make it a GUI application to avoid a spurious console. > user32: Fetch the window menu again after sending initialization messages. > advapi32: Fix ReportEvent parameter types in the spec file. > > Andrew Eikum (4): > winbase.h: Add GetFileInformationByHandleEx. > oleaut32: Register the typelib's path without WOW64 redirection. > oleaut32: Load referenced typelibs in the same architecture. > oleaut32: Use typelib's pointer size, not system's. > > André Hentschel (15): > oleaut32/tests: Get rid of IS_ANCIENT in vartest. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in vartest. > oleaut32/tests: Don't use autoheader styled define in vartest. > oleaut32/tests: Get rid of IS_ANCIENT in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_DECIMAL in vartype. > oleaut32/tests: Get rid of HAVE_OLEAUT32_CY in vartype. > oleaut32/tests: Don't use autoheader styled defines in vartype. > oleaut32/tests: Don't use autoheader styled defines in varformat. > oleaut32/tests: Get rid of IS_ANCIENT in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_RECORD in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_DECIMAL in safearray. > oleaut32/tests: Get rid of HAVE_OLEAUT32_R8 in safearray. > oleaut32/tests: Don't use autoheader styled defines in safearray. > oleaut32/tests: Use BOOL instead of int when appropriate. > > Austin English (1): > winex11.drv: Print the architecture when showing driver problems. > > Bruno Jesus (2): > po: Update Brazilian Portuguese translation. > po: Update Brazilian Portuguese translation. > > Caibin Chen (1): > po: Update Simplified Chinese Translation. > > Christian Costa (1): > d3dxof: Add support for case sensitive legacy type indexColor. > > Dmitry Timoshkov (4): > kernel32/tests: Add a test for VirtualAlloc called on a mapped PE section. > kernel32/tests: Add more VirtualAlloc and VirtualProtect tests. > kernel32: Correct HeapFree .spec parameter type. > ntdll: Correct RtlFreeHeap .spec parameter type. > > Erich Hoover (1): > ws2_32: Fix interface-bound filter to accept locally generated targeted packets. > > Frédéric Delanoy (1): > tools: Update winemaker manpage French translation. > > Hans Leidekker (3): > ws2_32/tests: Avoid races. > dssenh/tests: Fix test failures on 64-bit Vista. > winhttp/tests: Add some tests for WinHttpDetectAutoProxyConfigUrl. > > Huw Davies (1): > comdlg32: Don't call the callback if it's not set. > > Jacek Caban (5): > ole32: Don't call AddConnection for weak references. > ole32/tests: Added tests for external connections stored in ROT. > oleaut32/tests: Added external connections tests for MSHLFLAGS_TABLEWEAK marshaling. > mshtml: Don't declare empty interface for nsCycleCollectionISupports. > secur32: Don't use deprecated gnutls_certificate_credentials. > > Julian Rüger (1): > server: Update German translation of manpage. > > Ken Thomases (2): > winemac: Dispatch key events directly to window to be sure to get key-up events. > winemac: Fix ordering of windows owned by same owner when on inactive desktop space. > > Marcus Meissner (8): > dbghelp: Free root in error case (Coverity). > dbghelp: Free srcpath in stabs handling (Coverity). > gdi32: Close handle in error path (Coverity). > gdi32: Close handle in mfdrv (Coverity). > msvf32: Fixed incorrect sizeof (Coverity). > ole32: LeaveCriticalSection in one exit case (Coverity). > ole32: Fixed bad sizeof()s in composite moniker (Coverity). > winmm: Fix incorrect parameter for test debug (Coverity). > > Matteo Bruni (2): > wined3d: Fix handling of cnd instruction with coissue flag. > d3d9/tests: Improve cnd instruction test. > > Michael Stefaniuc (1): > po: Update the Romanian translation. > > Mykola Zadorozhnyy (1): > po: Update Ukrainian translation. > > Petr Kočandrle (1): > po: Fix some Czech spelling errors. > > Piotr Caban (1): > msvcrt: Added _wcsicmp_l implementation. > > Qian Hong (2): > msctf: Added stub TF_CreateLangBarItemMgr. > include: Added missing declaration for some msctf APIs. > > Roger Koot (1): > po: Updated Dutch translation. > > Stefan Leichter (1): > msvcp100/tests: Fix dynamically loaded functions for platform arm. > > Volkan Gezer (1): > po: Updated Turkish Translation. > > -- > Alexandre Julliard > julliard(a)winehq.org >

2 1

Mac OS X releases
by Wolf Kappesser July 2, 2013

July 2, 2013

Hello, my name is Wolf I am from germany and use OSX 10.8 to develop my apps, play games etc. I have read that there is no one, who compile the OSX version of WINE. I would do this. I have tried the osxwinebuilder script from http://code.google.com/p/osxwinebuilder and it did the job. I have download the old 1.5.30 wine for Mac and it has some additional features. They doesn't exist in the pure osxwinebuilder build. Where I can get them? I would give the OSX wine to the community, what I need to to? I have read that I should post to this list to get additional advices. Greets Wolf

2 1

Duplicate UUID in oleaut32:tmarshal test
by Thomas Faber July 2, 2013

July 2, 2013

I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it complained: tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [ Interface 'ITestSecondDisp' ] This doesn't seem like it's intentional. But just giving ITestSecondDisp a new uuid causes the following test failures on Windows: tmarshal.c:1861: Test failed: external_connections = 2 tmarshal.c:1864: Test failed: external_connections = 2 tmarshal.c:192: Test failed: fLastReleaseCloses = 1 I could try to figure this out, but it's probably better if someone familiar with the subject could have a look instead. (also, assuming this is a bug in the test, we might want to add that check to widl, it seems pretty useful ;]) Thanks, Thomas

2 1

Re: msxml3/tests: add additional conformance tests that show incorrect xpath behavior in wine
by Nikolay Sivov July 2, 2013

July 2, 2013

On 6/29/2013 20:26, John Chadwick wrote: > On Sat, Jun 29, 2013 at 4:48 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: >> On 6/27/2013 11:46, John Chadwick wrote: >> >>> + /* msxml's selectNodes returns a document ordered nodelist, >>> regardless of >>> + * whether or not the xpath nodelist was document ordered... */ >>> + >>> ole_check(IXMLDOMNode_selectNodes(rootNode,_bstr_("ancestor-or-self::node()"), >>> &list)); >>> + todo_expect_list_and_release(list, "D1 E2.D1"); >> Please use explicit check for return value, like ok(hr == S_OK, "...");, > Which return value am I missing? FWIW, I'm doing what the other tests > are doing, as far as I can tell. What I mean is that use of macros like ole_check() is discouraged, it's better to have explicit check for return value. > >> also you probably don't need another macro for list checking, >> isn't it enough to wrap expect_list_and_release() in todo_wine {} ? > Could it be that simple? I tried to do >> todo_wine expect_list_and_release(list, "D1 E2.D1"); > But it fails before the actual test occurs, because another test > inside the macro succeeds, apparently. Are you saying if I wrap the > expect_list_and_release macro call in a scope, it will work? I will > try. Yes, I see what you mean. In order to improve situation I'd suggest to move to using table of test queries and results. This way you have less code and no duplication, todo flag should just be stored in test data. We already have some tests done this way, it's much easier to maintain. > > I figured creating a new macro would be a better solution than > duplicating the code separately in two locations, but if it'd be > better to just not use the macro, then that's simple enough to fix. >

1 0

Re: [patch] full translation update for 16 rc4
by Frédéric Delanoy July 2, 2013

July 2, 2013

On Sun, Jun 30, 2013 at 6:08 AM, 中川祥 <matyapiro31(a)gmail.com> wrote: > Hi, please resubmit this patch with your full name transliterated in English.

2 1

Re: widl: Do not generate C structure for empty interfaces. (try 2)
by Jacek Caban July 2, 2013

July 2, 2013

Hi Thomas, I tested what midl does in this case and I think the solution should be different. When I tried to compile an empty interface, I got an error saying that '[object] interface must derive from another [object] interface'. That requirement is mostly enough to avoid empty vtbl. I was wondering how IUnknown is handled by midl (since it doesn't derive from any other iface). It seems like it's a simple name-based special case. When I renamed the interface to IUnknown, it compiled fine and generated vtbl the same as current widl (that is an empty struct). That said, if such interfaces are just obscure special case, I would say we shouldn't care. We may easily avoid them (I just sent a patch avoiding it in mshtml). If you want a better solution to avoid such problems in the future, I would suggest adding an error, like midl does. This will, however, require some more changes in Wine. At least MSHTML already has an interface identical to IUnknown (nsISupports), which would cause the error. This should be solvable with some tricks. Thanks, Jacek

2 2

Patch 96895
by Fabian Ebner July 2, 2013

July 2, 2013

Is something wrong with this patch? It's just a translation update and Matteo Bruni said it looks good to him: http://www.winehq.org/pipermail/wine-devel/2013-June/100264.html ~Fabian

1 0

Re: Fix to support input of characters with diacritic symbols using AltGr
by Ken Thomases July 1, 2013

July 1, 2013

On Jul 1, 2013, at 3:29 PM, Юрий Воротилов wrote: > Fix to support input of characters with diacritic symbols using AltGr (e.g. Latvian - AltGr+a=ā). > Tested on Ubuntu 12.04 and Centos 6. > I also have a bug opened in Crossover tracker: > http://www.codeweavers.com/support/tickets/browse/?ticket_id=935141 > > --- > dlls/winex11.drv/keyboard.c | 45 +++++++++++++++++++++++++------------------ > include/winuser.h | 1 + > server/queue.c | 5 ++++- > 3 files changed, 31 insertions(+), 20 deletions(-) > <0001-Support-input-of-characters-with-diacritic-symbols-usi.txt> I don't believe this is the correct approach. You don't want to be modifying the server and you can't arbitrarily add a new KEYEVENTF_* value. You can't assume that applications won't leave junk in the non-standard bits of the flags when they call SendInput() or keybd_event(). This needs to be implemented entirely within the X11 driver. It needs to properly translate your X11 keyboard layout into Win32 behavior. If the problem is that AltGr is mapping to VK_MENU, and thus causing key events to generate WM_SYSKEYDOWN/UP and not go through translation, then you need to make AltGr not map to VK_MENU. Although you really need to test that on Windows. My understanding is that AltGr appears to Windows apps as Alt+Control. In any case, I know that, on Mac OS X, the Option key is used similarly to AltGr. It accesses additional characters from the keyboard layout. This works when Option is configured in the X keymap to generate XK_Mode_switch. It requires no changes to Wine. So perhaps the right approach is to make XK_ISO_Level3_Shift and XK_ISO_Group_Shift behave the same way as XK_Mode_switch. (You could also just change your X keymap to actually map the key to XK_Mode_switch.) -Ken

1 1

[PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky July 1, 2013

July 1, 2013

Main changes from v6: 1) Fix LOCK_DELETE mandatory lock detection for O_DENYDELETE opens. 2) Add ESHAREDENIED error code definition for alpha, mips, parisc and sparc arches. 3) Remove code changes in do_last function if sharelocks are disabled. Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanism, but that approach is non-atomic. This patchset builds new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. The patchset introduces 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag can't be implemented for NFS due to the protocol restrictions). The patchset avoids data races problem on newely created files: open with O_CREAT can return new -ESHAREDENIED error code for a successfully created file if this files was locked with a sharelock by another task. Also, it turns off flock/LOCK_MAND capability for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 and #2 patches add flags to fcntl and implements VFS part. The patches #3 and #4 are related to CIFS-specific changes, #5 and #6 describe NFS and NFSD parts, #7 turns off flock/LOCK_MAND for mounts with 'sharelock' option. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND --- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts arch/alpha/include/uapi/asm/errno.h | 2 + arch/mips/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/errno.h | 2 + arch/sparc/include/uapi/asm/errno.h | 2 + fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 +++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 ++++++----- fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 ++++-- fs/cifs/inode.c | 21 ++--- fs/cifs/link.c | 25 ++---- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 +-- fs/fcntl.c | 5 +- fs/locks.c | 160 ++++++++++++++++++++++++++++++++--- fs/namei.c | 56 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 +- fs/nfs/nfs4xdr.c | 21 ++++- fs/nfs/super.c | 6 +- fs/nfsd/nfs4state.c | 46 +++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 +++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 39 files changed, 464 insertions(+), 135 deletions(-) -- 1.8.1.5

1 7

Re: po: Update Czech translation - 2nd attempt
by Nikolay Sivov June 30, 2013

June 30, 2013

On 6/28/2013 18:21, Pavel Borecki wrote: Hi, Pavel. Looks like you're using poedit or something with similar habit of touching lines location headers: --- > -#: appwiz.rc:66 appwiz.rc:42 cryptui.rc:343 msacm32.rc:37 winecfg.rc:191 > -#: winecfg.rc:228 wordpad.rc:245 > +#: appwiz.rc:66 > +#: appwiz.rc:42 > +#: cryptui.rc:343 > +#: msacm32.rc:37 > +#: winecfg.rc:191 > +#: winecfg.rc:228 > +#: wordpad.rc:245 > msgid "&Remove" > msgstr "Odeb&rat" --- This adds a lot of diff lines that you don't really want.

1 0

Re: [PATCH] advapi32: RegDeleteKey tests for merged view of HKCR
by wine.dev＠web.de June 30, 2013

June 30, 2013

Hi George. > [PATCH] advapi32: RegDeleteKey tests for merged view of HKCR > http://newtestbot.winehq.org/JobDetails.pl?Key=1403 > --- > dlls/advapi32/tests/registry.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) I can't test atm, but it looks good while reading. Please add a [try 2] to the subject and send it to wine-patches. -- Detlef

1 0

Re: [RFC PATCH] loader: allow overriding pthread_create correctly on linux
by Austin English June 30, 2013

June 30, 2013

On Fri, Jun 28, 2013 at 3:53 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > This should be enough to fix bug #30557 in the most thorough possible way. > Only tested on ubuntu precise 32-bits atm, but I believe it should work on 64-bits too. > > TODO: pthread_create_2_0 is not handled correctly right now, so it will fail on ancient glibc's < 2.2. > But because NPTL requires a slightly newer glibc than that I do not believe it will be a real issue. > > Comments welcome :-) > --- > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 01a8026..e9775c3 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -33,6 +33,7 @@ > #ifdef HAVE_SYS_SYSCALL_H > #include <sys/syscall.h> > #endif > +#include <errno.h> > > #define NONAMELESSUNION > #include "ntstatus.h" > @@ -58,6 +59,7 @@ struct startup_info > TEB *teb; > PRTL_THREAD_START_ROUTINE entry_point; > void *entry_arg; > + BOOL native_thread; > }; > > static PEB *peb; > @@ -186,6 +188,20 @@ done: > return status; > } > > +#ifdef __linux__ > +extern typeof(pthread_create) *__glob_pthread_create, *call_pthread_create; > +static typeof(pthread_create) __hook_pthread_create; > + > +static void thread_wrap_init(void) > +{ > + call_pthread_create = __hook_pthread_create; > +} > + > +#else > +#define __glob_pthread_create pthread_create > +#define thread_wrap_init() > +#endif > + > /*********************************************************************** > * thread_init > * > @@ -204,6 +220,7 @@ HANDLE thread_init(void) > struct ntdll_thread_data *thread_data; > static struct debug_info debug_info; /* debug info for initial thread */ > > + thread_wrap_init(); > virtual_init(); > > /* reserve space for shared user data */ > @@ -327,11 +344,7 @@ void terminate_thread( int status ) > pthread_exit( UIntToPtr(status) ); > } > > - > -/*********************************************************************** > - * exit_thread > - */ > -void exit_thread( int status ) > +static void exit_thread_common( int status ) > { > static void *prev_teb; > TEB *teb; > @@ -377,9 +390,60 @@ void exit_thread( int status ) > close( ntdll_get_thread_data()->wait_fd[1] ); > close( ntdll_get_thread_data()->reply_fd ); > close( ntdll_get_thread_data()->request_fd ); > +} > + > +void exit_thread( int status ) > +{ > + exit_thread_common(status); > pthread_exit( UIntToPtr(status) ); > } > > +#ifdef __linux__ > + > +struct unix_arg { > + void *(*start)(void *); > + void *arg; > +}; > + > +/* dummy used for comparison */ > +static DWORD native_unix_start; > + > +static void call_native_cleanup(void *arg) > +{ > + RtlFreeThreadActivationContextStack(); > + exit_thread_common(0); > +} > + > +static int > +__hook_pthread_create(pthread_t *thread, const pthread_attr_t *attr, > + void *(*start_routine) (void *), void *parm) > +{ > + NTSTATUS ret; > + struct unix_arg arg; > + arg.start = start_routine; > + arg.arg = parm; > + > + TRACE("Overriding thread creation!\n"); > + if (attr) > + FIXME("thread attributes ignored!\n"); > + > + ret = RtlCreateUserThread( NtCurrentProcess(), NULL, FALSE, NULL, 0, 0, (void*)&native_unix_start, &arg, NULL, (void*)thread ); > + if (ret != STATUS_SUCCESS) > + FIXME("ret: %08x\n", ret); > + switch (ret) { > + case STATUS_SUCCESS: > + return 0; > + case STATUS_NO_MEMORY: > + return ENOMEM; > + case STATUS_TOO_MANY_OPENED_FILES: > + return EMFILE; > + default: > + ERR("Unhandled ntstatus %08x\n", ret); > + return ENOMEM; > + } > +} > + > +#endif > > /*********************************************************************** > * start_thread > @@ -412,9 +476,18 @@ static void start_thread( struct startup_info *info ) > if (TRACE_ON(relay)) > DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", GetCurrentThreadId(), func, arg ); > > - call_thread_entry_point( (LPTHREAD_START_ROUTINE)func, arg ); > -} > +#ifdef __linux__ > + if (info->native_thread) { > + void *(*start)(void*) = (void*)func; > > + FIXME("Started native thread %08x\n", GetCurrentThreadId()); > + pthread_cleanup_push(call_native_cleanup, NULL); > + pthread_exit(start(arg)); > + pthread_cleanup_pop(1); > + } else > +#endif > + call_thread_entry_point( (LPTHREAD_START_ROUTINE)func, arg ); > +} > > /*********************************************************************** > * RtlCreateUserThread (NTDLL.@) > @@ -497,8 +570,18 @@ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR * > > info = (struct startup_info *)(teb + 1); > info->teb = teb; > - info->entry_point = start; > - info->entry_arg = param; > +#ifdef __linux__ > + info->native_thread = (void*)start == (void*)&native_unix_start; > + if (info->native_thread) { > + struct unix_arg *arg = param; > + info->entry_point = (void*)arg->start; > + info->entry_arg = arg->arg; > + } else > +#endif > + { > + info->entry_point = start; > + info->entry_arg = param; > + } > > thread_data = (struct ntdll_thread_data *)teb->SpareBytes1; > thread_data->request_fd = request_pipe[1]; > @@ -513,7 +596,7 @@ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR * > (char *)teb->Tib.StackBase - (char *)teb->DeallocationStack ); > pthread_attr_setscope( &attr, PTHREAD_SCOPE_SYSTEM ); /* force creating a kernel thread */ > interlocked_xchg_add( &nb_threads, 1 ); > - if (pthread_create( &pthread_id, &attr, (void * (*)(void *))start_thread, info )) > + if (__glob_pthread_create( &pthread_id, &attr, (void * (*)(void *))start_thread, info )) > { > interlocked_xchg_add( &nb_threads, -1 ); > pthread_attr_destroy( &attr ); > @@ -523,6 +606,11 @@ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR * > pthread_attr_destroy( &attr ); > pthread_sigmask( SIG_SETMASK, &sigset, NULL ); > > +#ifdef __linux__ > + if (native_thread && id) > + *(pthread_t*)id = pthread_id; > + else > +#endif > if (id) id->UniqueThread = ULongToHandle(tid); > if (handle_ptr) *handle_ptr = handle; > else NtClose( handle ); > diff --git a/dlls/winegstreamer/glibthread.c b/dlls/winegstreamer/glibthread.c > index 25eceb8..7417941 100644 > --- a/dlls/winegstreamer/glibthread.c > +++ b/dlls/winegstreamer/glibthread.c > @@ -43,6 +43,7 @@ > #include <stdlib.h> > #include <stdio.h> > > +#if 0 > #include "windef.h" > #include "winbase.h" > #include "winnls.h" > @@ -388,3 +389,15 @@ void g_thread_impl_init (void) > g_thread_self_tls = TlsAlloc (); > g_thread_init(&g_thread_functions_for_glib_use_default); > } > + > +#else > + > +void g_thread_impl_init (void) > +{ > + static gboolean beenhere = FALSE; > + > + if (!beenhere++) > + g_thread_init(NULL); > +} > + > +#endif > diff --git a/libs/wine/loader.c b/libs/wine/loader.c > index 094e5e1..69f4a38 100644 > --- a/libs/wine/loader.c > +++ b/libs/wine/loader.c > @@ -69,6 +69,11 @@ char **__wine_main_argv = NULL; > WCHAR **__wine_main_wargv = NULL; > char **__wine_main_environ = NULL; > > +#ifdef __linux__ > +#include <pthread.h> > +typeof(pthread_create) *call_pthread_create, *__glob_pthread_create; > +#endif > + > struct dll_path_context > { > unsigned int index; /* current index in the dll path list */ > diff --git a/libs/wine/wine.map b/libs/wine/wine.map > index 2159fac..694869a 100644 > --- a/libs/wine/wine.map > +++ b/libs/wine/wine.map > @@ -117,6 +117,8 @@ WINE_1.0 > wine_utf8_mbstowcs; > wine_utf8_wcstombs; > wine_wctype_table; > + __glob_pthread_create; > + call_pthread_create; > > local: *; > }; > diff --git a/loader/main.c b/loader/main.c > index ac67290..14b2428 100644 > --- a/loader/main.c > +++ b/loader/main.c > @@ -202,6 +202,27 @@ static int pre_exec(void) > > #endif > > +#ifdef __linux__ > + > +extern typeof(pthread_create) *call_pthread_create, *__glob_pthread_create; > + > +int pthread_create(pthread_t *thread, const pthread_attr_t *attr, > + void *(*start_routine) (void *), void *arg) > +{ > + return call_pthread_create(thread, attr, start_routine, arg); > +} > + > +static void init_thread_hook(void) { > + call_pthread_create = __glob_pthread_create = dlvsym(RTLD_NEXT, "pthread_create", "GLIBC_2.2"); > + if (!__glob_pthread_create) > + call_pthread_create = __glob_pthread_create = dlvsym(RTLD_NEXT, "pthread_create", "GLIBC_2.1"); > +} > + > +#else > + > +#define init_thread_hook() > + > +#endif > > /********************************************************************** > * main > @@ -211,6 +232,8 @@ int main( int argc, char *argv[] ) > char error[1024]; > int i; > > + init_thread_hook(); > + > if (!getenv( "WINELOADERNOEXEC" )) /* first time around */ > { > static char noexec[] = "WINELOADERNOEXEC=1"; Fails to compile here (as mentioned on bug 30557): gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -o thread.o thread.c thread.c: In function ‘RtlCreateUserThread’: thread.c:610:9: error: ‘native_thread’ undeclared (first use in this function) thread.c:610:9: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [thread.o] Error 1 make[1]: Leaving directory `/home/austin/wine-git/dlls/ntdll' make: *** [dlls/ntdll] Error 2 I tried Ruslan's fixed patch, which failed as well: gcc -m32 -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -fno-builtin -o main.o main.c gcc -m32 -o wine -Wl,--export-dynamic -Wl,--section-start,.interp=0x7bf00400 main.o -L../libs/wine -lwine ../libs/port/libwine_port.a -lpthread -Wl,--rpath,\$ORIGIN/../libs/wine /usr/bin/ld: main.o: undefined reference to symbol 'dlvsym@@GLIBC_2.1' /usr/bin/ld: note: 'dlvsym@@GLIBC_2.1' is defined in DSO /lib/libdl.so.2 so try adding it to the linker command line /lib/libdl.so.2: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status make[1]: *** [wine] Error 1 make[1]: Leaving directory `/home/austin/wine-git/loader' make: *** [loader] Error 2 this is 32-bit wine on fedora 64 (against 1.6-rc4). -- -Austin

1 0