July 2013 - Wine-Devel - list.winehq.org

Re: ieframe: Use SHANDLE_PTR in IWebBrowserApp::get_HWND.
by Marvin July 16, 2013

July 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26282 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 004033D1

2 1

Re: loader: Indicate wine can run 64-bit apps in manpage
by Frédéric Delanoy July 16, 2013

July 16, 2013

On Tue, Jul 16, 2013 at 4:57 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > loader/wine.man.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Please ignore this patch: I accidentally resent it. Sorry about the noise. Frédéric

1 0

Re: po: Update Turkish translation (second try)
by Francois Gouget July 16, 2013

July 16, 2013

-<<<<<<< HEAD -"PO-Revision-Date: 2013-07-13 04:49+0200\n" -======= -"PO-Revision-Date: 2013-07-04 00:10+0200\n" ->>>>>>> 598685e6c5992355de35b4345e91eb4e50b9f07e +"PO-Revision-Date: 2013-07-13 05:00+0200\n" [...] -#: attrib.rc:27 cmd.rc:322 +#: attrib.rc:27 cmd.rc:325 These look wrong: there is currently no conflict in the checked-in PO file and there should not be any line-number changes in the patch. So it won't apply to the current Git repository. Something must have happened when you rebased or generated the diff. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

1 0

Re: [PATCH 1/3] user32/tests: Sleep enough time to make sure all input message have been processed.
by Qian Hong July 16, 2013

July 16, 2013

Hello, This patch is marked as pending, is there anything I can improve? Did the test results in [1] and [2] help? Thanks for any feedback! [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 On Wed, Jul 3, 2013 at 2:45 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hello, > > Current menu test code may hide some failure tests [1], with the attached > patch, all failure tests could be detected [2]. > > > [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 > [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 > > > --- > dlls/user32/tests/menu.c | 1 + > 1 file changed, 1 insertion(+) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

2 6

Re: ntdll: Tests for RtlHashUnicodeString()
by Dmitry Timoshkov July 16, 2013

July 16, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +#include "ddk/wdm.h" Please don't do that, this breaks compilation with PSDK headers. If you need some specific definitions, types or API prototypes - replicate them in the test itself. -- Dmitry.

2 2

Re: riched20: ITextDocument stubs for ITextServices
by Frédéric Delanoy July 15, 2013

July 15, 2013

On Sun, Jul 14, 2013 at 3:50 AM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > You have to use your real name when submitting patches to wine-patches. Frédéric

1 0

How to configure C++ implements in wine?
by 中川祥 July 15, 2013

July 15, 2013

I'm working at User Access Logging API<http://msdn.microsoft.com/en-us/library/windows/desktop/hh437524(v=vs.85).a…> for Windows8. It need C++ style coding. How can I solve it?

2 1

Re: [docs 2/3] winedev: Use hyphen in bitness
by Frédéric Delanoy July 14, 2013

July 14, 2013

On Sun, Jul 14, 2013 at 7:41 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > en/winedev-architecture.sgml | 56 ++++++++++++++++++++++---------------------- > en/winedev-debugger.sgml | 10 ++++---- > en/winedev-kernel.sgml | 24 +++++++++---------- > en/winedev-multimedia.sgml | 36 ++++++++++++++-------------- > 4 files changed, 63 insertions(+), 63 deletions(-) > - (an int is 16 bit in 16-bit and 32 bits in 32-bit, pointers > + (an int is 16-bit in 16-bit and 32-bits in 32-bit, pointers This part sounds a bit weird... also, one is in plural with the other is in singular form. Probably would benefit from a sentence reorganization. Frédéric

1 0

Re: po: Tweak the French 'broadcast' and 'unicast' translations.
by Frédéric Delanoy July 13, 2013

July 13, 2013

On Fri, Jul 12, 2013 at 4:33 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > Surprisingly enough (for me) the existing translations match the term > used in Microsoft's Terminology file: > "broadcast address" -> "adresse de diffusion" > "broadcast" -> "diffusion" > "multicast" -> "multidiffusion" > "unicast" -> "monodiffusion" > > https://www.microsoft.com/Language/en-US/Terminology.aspx > > But I still don't think they're good translations. I find 'diffusion' > way too general and vague. Reading it I would certainly not make the > link with broadcast, even in the domain of networking. Similarly I don't > think 'monodiffusion' would be readily understood. > > So I'm more enclined to follow Wikipedia which uses the untranslated > terms as the title of their French articles: Well they're just untranslated... you said it The "grand dictionnaire terminologique" (http://gdt.oqlf.gouv.qc.ca/Resultat.aspx) gives broadcast -> diffusion (générale) multicast -> multidiffusion / diffusion groupée (beurk) monocast -> envoi individuel http://glossaire.traduc.org/ (used for manpages/howtos) gives broadcast -> diffusion multicast -> multidiffusion unicast -> unicast BTW to broadcast = diffuser I may agree with unicast but the "diffusion" and "multidiffusion" seem OK to me

3 4

Re: po: update Simplified Chinese translation
by Francois Gouget July 12, 2013

July 12, 2013

I'll take this opportunity to note that Microsoft's Simplified Chinese Style Guide says: | Colon | * Software localization: Use English colon (:) in Software | localization. A single byte space should be left between the | English colon and the subsequent characters (Chinese full-width | punctuation marks are excluded). For documentation they say to use a double byte colon. So it seems like our PO files should actually be using single-byte colons everywhere. Does this make sense? http://download.microsoft.com/download/4/c/a/4ca95933-3496-4793-9d77-a89b60… As an additional not, I don't think this is grounds for rejecting this patch given that it is consistent with existing translations. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: po: Some Franch translation tweaks.
by Frédéric Delanoy July 12, 2013

July 12, 2013

On Fri, Jul 12, 2013 at 1:16 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > po/fr.po | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) There's a typo in the commit message (you probably spotted it already). > msgstr "" > "PAUSE affiche un message à l'écran demandant à l'utilisateur d'appuyer sur " > -"une touche.\n" > +"une\n" > +"touche.\n" This is probably not needed > msgid "Drive Mapping" > -msgstr "Assignation de lecteur" >+msgstr "Dossier cible" Are you sure about this one? Maybe the original should be changed as well in this case... Frédéric

2 1

Re: po: Fix the French DEL, ERASE, RD and RMDIR usage messages.
by Frédéric Delanoy July 12, 2013

July 12, 2013

On Fri, Jul 12, 2013 at 12:34 PM, Francois Gouget <fgouget(a)free.fr> wrote: > msgid "DEL <filename> deletes a file or set of files.\n" > -msgstr "DEL <fichiers> efface un fichier ou un groupe de fichiers.\n" > +msgstr "DEL <fichier> efface un fichier ou un groupe de fichiers.\n" "fichiers" indicate it can be any number of files, replacing by the singular form doesn't (one may think only one file is deletable per command) If you absolutely want the same singular ou plural form, the English msgid it what should be changed instead IMO Same remark for your ERASE diff hunk. Regards, Frédéric

1 0

Re: po: Fix some typography and linefeed issues in the Turkish translation.
by Francois Gouget July 12, 2013

July 12, 2013

On Thu, 11 Jul 2013, Volkan Gezer wrote: [...] > Thank you for modifications. I think the only problem is: > > #: cryptui.rc:38 > msgid " to " > -msgstr " bitişi: " > +msgstr " bitişi " > > which we should keep ":" for a meaningful sentence structure. Hasan > should also correct me if I am wrong. Ok. That seems a bit strange but probably less strange than the way the code builds this string :-( It seems it does it does it this way to put parts of it in bold. I've added an exception for it and I'm resending the rest of the patch. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 1

Re: po: update Simplified Chinese translation
by Qian Hong July 12, 2013

July 12, 2013

#: winerror.mc:3016 -#, fuzzy msgid "Unknown interface.\n" -msgstr "不明来源。\n" +msgstr "未知界面。\n" Please keep persistent for the translation of 'interface'. Here 'Unknown interface.' is used with RPC_S_UNKNOWN_IF, should be translate to '接口' as well as other place. #: winecfg.rc:260 msgid "Voice output device:" -msgstr "" +msgstr "语言输出设备：" #: winecfg.rc:261 msgid "Input device:" @@ -12313,7 +12281,7 @@ msgstr "输入设备：" #: winecfg.rc:262 msgid "Voice input device:" -msgstr "" +msgstr "语音输入设备：" Please keep persistent for the translation of 'voice', it seems like a typo here, one translated to 语言 while the other translated to '语音'. #: winerror.mc:186 msgid "Sharing violation.\n" -msgstr "" +msgstr "非法共享。\n" #: winerror.mc:191 -#, fuzzy msgid "Lock violation.\n" -msgstr "位置。\n" +msgstr "非法锁定。\n" #: winerror.mc:696 -#, fuzzy msgid "Cancel violation.\n" -msgstr "信息。\n" +msgstr "非法取消。\n" The above three reference to: ERROR_SHARING_VIOLATION （共享冲突？） ERROR_LOCK_VIOLATION （锁冲突？） ERROR_CANCEL_VIOLATION （？） http://support.microsoft.com/kb/316609/en-us http://support.microsoft.com/kb/2698155/en-us http://support.microsoft.com/kb/155011/en-us I'm not sure your translation is correct, they are tricky to translate, for ERROR_CANCEL_VIOLATION, even the original English version is hard to understand :( maybe keep the English version is not a bad idea if there is no better alternative so far. Thanks for the work! On Fri, Jul 12, 2013 at 8:09 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > > > > -- Regards, Qian Hong - http://www.winehq.org

2 1

po: update Simplified Chinese translation
by Jactry Zeng July 12, 2013

July 12, 2013

1 0

Re: ole32: Tests for CLSIDFromProgID() and ProgIDFromCLSID() regarding activation context
by Marvin July 12, 2013

July 12, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26261 Your paranoid android. === W2KPROSP4 (32 bit compobj) === compobj: unhandled exception c0000005 at 00000000

1 0

Re: cmd: Fix a usage message: the % must be doubled for FOR variables. (resend)
by Alexandre Julliard July 12, 2013

July 12, 2013

Francois Gouget <fgouget(a)free.fr> writes: > The usage message was in fact documenting an old Wine bug. > --- > > The attempt did not apply, probably because I had other changes in my > tree. Hopefully this one will work. > > > I'm reluctant to change messages at this stage as it's going to cause > fuzzying of the translations, but given that this message is plain wrong > I think it's warranted. I'd suggest to simply remove the sentence, and remove it in translations too so that we don't need to invalidate all of them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime. (try 2)
by Bruno Jesus July 12, 2013

July 12, 2013

On Thu, Jul 11, 2013 at 11:19 AM, Sylvain Petreolle <spetreolle(a)yahoo.fr> wrote: > --- > dlls/wbemprox/builtin.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c > index 9e2369a..5b7674e 100644 > --- a/dlls/wbemprox/builtin.c > +++ b/dlls/wbemprox/builtin.c > @@ -1774,6 +1778,31 @@ static WCHAR *get_lastbootuptime(void) > + > + GetLocalTime(&st); > + Status = GetTimeZoneInformation(&tzi); > + > + if(Status == TIME_ZONE_ID_INVALID) return NULL; Aren't you leaking ret here? Maybe you could swap this check with the memory allocation. > + sprintfW( ret, fmtW, st.wYear, st.wMonth, st.wDay, st.wHour, st.wMinute, st.wSecond, st.wMilliseconds * 1000, -Bias); Is it ok for the + sign to the fixed in the format? Best wishes, Bruno

2 1

Re: po: Czech - corrected omission of some newline marks
by Alexandre Julliard July 11, 2013

July 11, 2013

Pavel Borecki <pavel.borecki(a)gmail.com> writes: > @@ -3060,7 +3122,7 @@ > > #: hhctrl.rc:62 winhlp32.rc:31 > msgid "&Print..." > -msgstr "&Tisknout..." > +msgstr "&Tisknout" Please keep the three dots, that's apparently the standard. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: Standardize and simplify two error messages.
by Andrew Eikum July 10, 2013

July 10, 2013

On Wed, Jul 10, 2013 at 10:42:05AM +0200, Francois Gouget wrote: > We don't have a MIDI Mapper configuration applet so don't tell the user to use it. > --- > > Or if we do, how does one get to it? I did not find anything in > winecfg.exe, nor in control.exe (the Control Panel). > > -MIDIERR_NODEVICE, "The current MIDI Mapper setup refers to a MIDI device that is not installed on the system. Use MIDI Mapper to edit the setup." I think it's meant to refer to the "MIDI Mapper" device, which is configurable through the registry: http://wiki.winehq.org/MIDI I think your change is clearly an improvement. Andrew

1 0

Should we translate the prompt
by Jactry Zeng July 10, 2013

July 10, 2013

Hi everybody, In po file there were some prompts as this: #: xcopy.rc:35 msgid "%1? (Yes|No)\n" I am not sure that should I translate them in po file for Simplified Chinese. But they have been translated in po file for French and Traditional Chinese. As prompts in command line, I don't think translating them into another language is good. It may make the users don't know what should them type into. When I discuss this with Qian Hong, he give a better idea. We may can just make the origin text more apropos, just like: msgid "%1? (Y)es|(N)o\n" So that we can translate it into Simplified Chinese: msgid "%1？是(Y)|否(N)\n" Thanks for any comment. -- Regards, Jactry Zeng

3 3

Re: readme: Update German translation
by Joerg Schiermeier July 9, 2013

July 9, 2013

> Hi ... list, Hi Julian > I think "liesmich" is more common than "lesmich", although both sound > awkward. Do we need/want to translate that? Yes really. 'Liesmich' is a direct translation of 'readme'. Eventually this older translation was a simply typo? So please change this! Thanks. > Best, > Julian -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: readme: Update German translation
by Julian Rüger July 9, 2013

July 9, 2013

Am Dienstag, den 09.07.2013, 00:46 +0200 schrieb André Hentschel: > --- > documentation/README.de | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > Hi André and list, patch looks good to me. One minor remark: > + wine notepad.exe lesmich.txt (Programmaufruf mit Parametern) I think "liesmich" is more common than "lesmich", although both sound awkward. Do we need/want to translate that? Best, Julian PS: I have some more manpage-patches in the works, but my spare time has been a little scarce lately. Do you think 1.6 will be released Friday?

3 2

Re: po: Arabic full translated wine. (try2)
by Yaron Shahrabani July 8, 2013

July 8, 2013

Non critical changes but take a look if you like: #: comdlg32.rc:186 comdlg32.rc:141 -#, fuzzy msgid "Save As" msgstr "احفظ &ك‍..." Redundant Elipsis. #: comdlg32.rc:202 -#, fuzzy msgid "S&election" -msgstr "اختر ال&كل\tCtrl+A" +msgstr "الاختيار" #: comdlg32.rc:203 -#, fuzzy msgid "&Pages" -msgstr "صفحة &p" +msgstr "صفحات" #: comdlg32.rc:206 comdlg32.rc:228 -#, fuzzy msgid "&Setup" -msgstr "إعداد الصفحة" +msgstr "إعداد" No accelerator (&) sign. #: comdlg32.rc:207 msgid "&From:" -msgstr "" +msgstr "&من" #: comdlg32.rc:208 msgid "&To:" -msgstr "" +msgstr "&إلى" No semicolon at the end. #: comdlg32.rc:211 -#, fuzzy msgid "Print to Fi&le" -msgstr "ملفات النصوص (*.txt)" +msgstr "اطبع إلى ملف" #: comdlg32.rc:268 msgid "Scr&ipt:" -msgstr "" +msgstr "ترميز" No accelerator sign. #: comdlg32.rc:281 comdlg32.rc:304 msgid "Color | Sol&id" -msgstr "" +msgstr "اللون | &جامد" No need to add اللون |‏ before the &جامد part. There might be more. Anyways great job! Kind regards, Yaron Shahrabani <Hebrew translator> On Sun, Jun 30, 2013 at 6:27 AM, مصعب الزعبي <moceap(a)hotmail.com> wrote: > --- > > po/ar.po > > > > > >

2 1

Re: [PATCH] gdiplus: fixing identical sub-expressions
by Vincent Povirk July 7, 2013

July 7, 2013

I'm not sure we should change this during code freeze.

1 0