July 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 27, 2013

Oct. 27, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Possibility of adding a new patch status
by Hugh McMaster Aug. 14, 2013

Aug. 14, 2013

Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked at yet, there's still hope...". This is ideal for new patches submitted within that 24-hour commit cycle. But I'm finding it difficult to follow patches that remain with a status of 'New' for longer than the 24-hour patch cycle. Obviously, on the weekend, patches are held over till Monday, so a longer lead-time is expected. During weekdays, however, it is unclear what is happening with some patches. This, ultimately, raises the question of timeliness. Has the patch been looked at? If it has, the status often describes what action was taken - committed, rejected, superseded, etc. This is fine, but some patches remain with a status of 'New'. Experience has told me that patches remaining with a status of 'New' are incorrect in some way. But this is not always the case. If the patch is incorrect, but close to being accepted, the patch's status should reflect this, by changing to something like "Revision needed". Of course, the "Rejected" status is also appropriate, depending on the severity of coding error. Also, there are likely to be many times when the maintainer has not had time to evaluate some patches. This means the patch is not new (i.e. recently submitted), but is awaiting review. Once again, I believe the patch status should reflect this situation. The status could be "Not yet reviewed". In summary, the 'New' status should be reserved for patches that are actually new. Just some thoughts.

3 7

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.
by Matteo Bruni Aug. 2, 2013

Aug. 2, 2013

2013/7/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/tests/shader.c | 308 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 308 insertions(+) > This is okay, but as a followup can you add some tests with mixed-type structs? Something like: struct { float f; int i; bool b; }; If you have already written tests of this kind, I'd like to know what does the compiler do in this case :)

2 6

Re: po: Add English (Canada) resource [Take 2]
by Ken Sharp Aug. 2, 2013

Aug. 2, 2013

Please disregard this patch. I missed a couple of words and with those corrected en_CA.po becomes identical to en.po (except that "serialisation" is fuzzy) and Wine defaults to that anyway for Canadian English. Will re-submit if there are any changes (just noticed -able/-eable). Will keep an eye on the English translations. On 30/07/13 22:37, Ken Sharp wrote: > - Re-based to latest git > - Removed all the fuzzies thanks to http://www.etymonline.com/index.php > > Turns out all the -ise/-ize words used in Wine are of Latin origin anyway. > > > -------- Original Message -------- > Subject: po: Add English (Canada) resource > Date: Mon, 22 Jul 2013 19:28:51 +0100 > From: Ken Sharp <kennybobs(a)o2.co.uk> > To: wine-patches(a)winehq.org > > Canadian English follows some British/French rules but not others. > > I have left some of the -ise/-ize words fuzzy because: > > "the etymological convention that verbs derived from Greek roots are > spelled with -ize and those from Latin with -ise is preserved in that > practice." > http://en.wikipedia.org/wiki/Canadian_english#Spelling_and_dictionaries > > I tried looking for the origins of the words and I couldn't get any. The > non-fuzzies are correct. > > With British, US and Canadian I believe all the English variations (used > in Wine) are covered, except Philippines (follows US rules). > > >

1 1

gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.
by Alexei Svitkine Aug. 1, 2013

Aug. 1, 2013

Don't let the gdi32 driver allocate memory in the dplayx region. Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095 The issue is that the dplayx code in wine needs to allocate some memory at a static address (0x50000000) and loading the Mac native gdi driver ends up using that part of the address space. This patch fixes that by reserving that part of memory while the display driver is initialized and releasing it after. --- dlls/gdi32/driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+)

2 5

Re: [PATCH 11/11] appelp: Add tests.
by Marvin July 31, 2013

July 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26546 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)
by Alexandre Julliard July 31, 2013

July 31, 2013

Caibin Chen <tigersoldi(a)gmail.com> writes: > Thanks Jacek for reviewing. This time I send all the changes I have in > 4 patches to make it clear that ReTxtDoc is reused between txtsrv.c > and richole.c > - Suppressed Patch 97331 > - Change log from try 2: > - follow COM naming convention > - move ReTxtDoc definition to header, removed > ReTxtDoc_get_ITextDocument() function > - remove COM aggregation test for ITextDocument, only test > ITextService supports querying for the interface. > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 10 ++ > dlls/riched20/txtdoc.c | 270 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 51 ++++++++ > dlls/riched20/txtsrv.c | 6 + Please avoid adding too many source files. In particular, if you have to add new headers and define objects there, it's a sign that things should be grouped in the same file. That's even more true for ITextDocument that already exists. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader.
by Stefan Dösinger July 31, 2013

July 31, 2013

Hi, Am 31.07.2013 um 09:10 schrieb Christian Costa <titan.costa(a)gmail.com>: > + if (!(strstr(line_out, "warning X3206:") && strstr(line_out, "implicit truncation of vector type"))) > + line_out += line_size; msvc localizes compiler errors and warnings. Are you sure d3dcompiler.dll doesn't do that? Wrt the parsing code, wouldn't it be nicer to use strtok_r to split the buffer into separate lines? I am not sure that parsing the errors and warnings like that is a good thing, but I don't know d3dx9 and d3dcompiler well enough to give a final judgement on that.

2 2

Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()
by Austin English July 31, 2013

July 31, 2013

On Tue, Jul 30, 2013 at 5:13 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > > You forgot the patch. -- -Austin

3 2

d3dx9: Replace M_PI by its D3DX equivalent
by Nozomi Kodama July 31, 2013

July 31, 2013

What is the problem with patch: http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX (moreover it is deprecated in C99) Nozomi

2 1

Re: kernel32: Fix parameters checking for GetVolumePathName()
by Alexandre Julliard July 31, 2013

July 31, 2013

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -1813,6 +1821,8 @@ BOOL WINAPI GetVolumePathNameW(LPCWSTR filename, LPWSTR volumepathname, DWORD bu > volumepathname[3] = 0; > return TRUE; > } > + > + SetLastError(ERROR_FILENAME_EXCED_RANGE); > return FALSE; This doesn't really make sense as a general error. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3dx9: Replace M_PI by its D3DX equivalent
by Nozomi Kodama July 31, 2013

July 31, 2013

Hello What is the problem with patch http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX. Nozomi

1 0

Re: msxml3: Unescape '&' back to '&' in attribute value
by Marvin July 31, 2013

July 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26523 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPPROSP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K8SE (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & )

1 0

Re: kernel32/tests: Improve GetVolumePathNameA tests
by Bruno Jesus July 30, 2013

July 30, 2013

Please ignore this patch, I understand that as is it will not be commited. On Tue, Jul 30, 2013 at 3:30 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Erich Hoover contacted me about a patch he sent months ago related to > GetVolumePathNameA. He developed a better test infrastructure using a > for loop instead of multiple repetitions of test lines. This patch > will make it easier for him to rebase and send his tests and function > implementation later. > > I used the same approach from [1] by decomposing the "todo_wine" in > winetest_start_todo("wine") and winetest_end_todo("wine"). > > http://source.winehq.org/source/programs/cmd/tests/batch.c#L292 -- universe* god::bigbang (void); //and then it all began...

1 0

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.
by Nikolay Sivov July 30, 2013

July 30, 2013

On 7/9/2013 16:50, Qian Hong wrote: > Fixed a crash in MS Office 2010 Chinese version. > Thanks Jiang Yike for the helps on testing :) > > --- > dlls/imm32/imm.c | 6 ++++++ > dlls/imm32/tests/imm32.c | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > > > > > + if (IsBadReadPtr(internal, sizeof(HIMCC))) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + Do you really need this for Office 2010 or null check is enough? If it's passing 0 handle here that's what you should check imho. If HIMCC is really a handle and not a struct pointer like in wine, that's not how a handle validity check will look like.

2 4

Call for Windows tests
by Bruno Jesus July 30, 2013

July 30, 2013

Hi, I'm looking for help to test WSAEnumProtocols, I need to collect more information about the values returned from different versions of windows, especially 7 and 8. If you can help please download the file below, unzip, run the .bat and send me back the result.txt file (sources included). http://influenza.blog.br/wsa.zip There is no need to answer to the list. Virustotal.com scan: http://bit.ly/1catW4a Thanks in advance, Bruno

1 0

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.
by Vincent Povirk July 30, 2013

July 30, 2013

There's a TIFF_VERSION define that seems to have been renamed to TIFF_VERSION_CLASSIC in 4.0. It doesn't make sense to do the check at runtime, given we're only going to link to one of the versions.

3 7

Re: [1/2] msxml3: Implement IMXAttributes_removeAttributes()
by Jacek Caban July 30, 2013

July 30, 2013

Hi Nikolay, On 07/30/13 12:42, Nikolay Sivov wrote: > + dst = &This->attr[index]; > + src = &This->attr[index+1]; > + > + memmove(dst, src, This->length-index-1); *sizeof(*dst) Cheers, Jacek

1 0

Re: [2/2] wininet: Handle NULL input string in str_to_buffer.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26482 Your paranoid android. === WXPX64 (64 bit http) === http.c:4661: Test failed: 4832: expected status 100 got 10 http.c:4661: Test failed: 4876: expected status 100 got 40 http.c:4634: Test failed: ar->dwResult = 0, expected 1 http.c:4661: Test failed: 4885: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

Re: [1/2] wininet: Ignore INTERNET_FLAG_NO_CACHE_WRITE only for GET requests.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26481 Your paranoid android. === WXPX64 (32 bit http) === http.c:4588: Test failed: 4759: expected status 100 got 10 http.c:4588: Test failed: 4803: expected status 100 got 40 http.c:4561: Test failed: ar->dwResult = 0, expected 1 http.c:4588: Test failed: 4812: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA

1 0

Re: [2/2] iphlpapi: Add partial support for the module classes in GetExtendedTcpTable and GetExtendedUdpTable.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26480 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === W7PROX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 77E03915 === WVISTAX64 (64 bit iphlpapi) === Timeout === W7PROX64 (64 bit iphlpapi) === No test summary line found

1 0

Re: [1/2] iphlpapi: Add support for the listener and connection classes in GetExtendedTcpTable.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26479 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === WVISTAX64 (64 bit iphlpapi) === Timeout

1 0

Re: riched20: ITextDocument stubs for ITextServices (retry)
by Caibin Chen July 30, 2013

July 30, 2013

Anybody reviewing this patch? It's almost all stubs, so although it's long, it shouldn't be hard to review 2013/7/15 Caibin Chen <tigersoldi(a)gmail.com>: > (Retry with real name in mail. The name in the patch is already my real name) > > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 16 ++- > dlls/riched20/txtdoc.c | 282 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 46 +++++++ > dlls/riched20/txtsrv.c | 6 + > 5 files changed, 350 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/txtdoc.c > create mode 100644 dlls/riched20/txtdoc.h

2 4

[PATCH 1/2] ntdll: Implement NtQuerySystemInformation class 0x37
by Chris Moeller July 30, 2013

July 30, 2013

2 1

GetNumaHighestNodeNumber tests
by Chris Moeller July 29, 2013

July 29, 2013

Here is a basic stand-alone test program, which I should probably learn how to implement into the standard testing array. On my test Windows 7 system with a single processor (4 cores), it outputs the following: Testing NtQuerySystemInformationSystemNumaHighestNodeNumber = 0x37, ...): ... with invalid size returned c0000004 ... with valid size returned 0, HighestNodeNumber = 0, ResultLength = 4 Testing GetNumaHighestNodeNumber: ... returned 1, HighestNodeNumber = 0

1 0

[PATCH 2/2] kernel32: Implement GetNumaHighestNodeNumber
by Chris Moeller July 29, 2013

July 29, 2013

1 0

[PATCH 0/2] Implement basic GetNumaHighestNodeNumber
by Chris Moeller July 29, 2013

July 29, 2013

This patch against HEAD does the following in two parts: Part 1) Implements NtQuerySystemInformation class 0x37, which I have given the name SystemNumaHighestNodeNumber, since that appears to be all it does. It currently is limited to simulating a single node system, and returns the correct error status if queried with too small a return buffer. Part 2) Implements GetNumaHighestNodeNumber based on the above interface, and behaves just like a Windows 7 32-bit kernel32.dll does in case of errors in that function.

1 0

kernel32: Correct log on / logon (noun / verb)
by Ken Sharp July 29, 2013

July 29, 2013

Evening Winos, Attached is a patch to correct some winerr messages. Specifically change a noun to a verb, and update the .po files with it. Firstly, could you take a look and point out any obvious errors I may have made? I have marked some of the translations fuzzy because it's not clear if the original translator realised that this should have been the verb and not the noun. A quick look through the translations on Wikipedia suggests that most languages do use different terms for the noun and the verb. https://cs.wikipedia.org/wiki/Login https://de.wikipedia.org/wiki/Login_(Informationstechnik) https://es.wikipedia.org/wiki/Login and so on. Some of these listings seem to use completely different words to the current translation in Wine so I wouldn't dare make a guess. Secondly, what do people think about the use of "Can't" as opposed to "Cannot"? I have not made the change in the patch but I'm wondering if people think that this should be done. Can't is informal and as my old English teacher would say, "Can't is not a word!" It is, but being pedantic "cannot" is probably the better choice. I assume Windows uses "can't" seen as it listed in winerror.mc. Thanks all! Ken

2 1

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Matteo Bruni July 29, 2013

July 29, 2013

2013/7/30 Chris Moeller <kode54(a)gmail.com>: > > On Jul 29, 2013, at 11:22 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > >> 2013/7/29 Chris Moeller <kode54(a)gmail.com>: >>> without looking very deeply into the CRT source code. >> >> You're talking about MS source code, right? That makes you tainted for >> contributing to Wine at >> the very least for C runtime-related code :( >> If you haven't looked into any other source code, this patch might be >> okay (barring other issues, I haven't read the patch at all). At least >> http://wiki.winehq.org/DeveloperFaq#head-fed5011434f62ae1a88baebfb8193a37ea… >> seems to suggest so. > > I did not look at any CRT source code to determine how to implement the functionality of this patch. I only looked at CRT source code to determine why the CRT was crashing in the first place. The HighestNode function popping a warning in my wine logs should have been hint enough to discover that function was stubbed. > > I actually determined how these functions worked by testing their behavior against a working system, and also with the aid of another developer, who pointed out a handy Win32 function for retrieving a suitable value for the free memory check. That's probably fine, although as a general rule you should stay as far as possible from Microsoft's source code. Cheers, Matteo.

1 0

[1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Chris Moeller July 29, 2013

July 29, 2013

Main changes from HEAD: 1) Implements GetNumaHighestNodeNumber which simulates a typical single node system. 2) Implements GetNumaNodeProcessorMask which returns the global processor affinity mask for node 0, otherwise returns an error. 3) Implements GetNumaAvailableMemoryNode which returns available physical memory for node 0, otherwise returns an error. This much of the behavior was observed based on a single processor (4 cores) Windows 7 system. These functions are utilized by the synchronization and threading primitives incorporated in the MSVC 2012 and newer C and C++ runtime libraries. concrt.h/Concurrency::critical_section, which is used by both std::mutex and std::thread, will throw an exception the moment the object is locked if GetNumaHighestNodeNumber fails, and there are at least a few examples of software which don't bother to catch this exception and thus crash, such as the alpha version of Cube World, and certain versions of the foo_wave_seekbar component for the foobar2000 audio player. The associated scheduling code appears to make use of GetNumaNodeProcessorMask as well to control how many threads are allowed to spin up at once, or so I guess without looking very deeply into the CRT source code.

3 2

Re: [PATCH] Ignore MotionNotify when XI2 is handling mouse motion
by Alexandre Julliard July 29, 2013

July 29, 2013

Josef Schimke <sgtcapslock(a)lavabit.com> writes: > Hello, > > When XInput2 takes over the mouse, regular MotionNotify events continue to be > handled alongside it. This causes the cursor to erratically skip around when > the slower method (X11 input) tries to reposition the cursor while XInput2 is > already handling future events. We want to process MotionNotify to resync the cursor position, XInput events are not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

How to get involved in Windows Store API implement?
by 中川祥 July 29, 2013

July 29, 2013

I do not know much about the store apps development. What is Windows.winmd? Do I need disassemble it and create wine version ?If I need C++,I wouldn't do. Is there any planning to support them?

2 1

NtCreateFile fails
by Mislav Blazevic July 29, 2013

July 29, 2013

First of all, pardon my ignorance, I am new to wine and winapi. I am trying to implement apphelp.dll and I ran into issues with NtCreateFile: It always returns 0xc0000103, STATUS_NOT_A_DIRECTORY, and I am not sure what that means. Here is code: /* This function is not in API, but written for internal use */ HANDLE WINAPI SdbOpenFile( LPCWSTR path, PATH_TYPE type ) { /* SNIP */ if (type == DOS_PATH) if (!RtlDosPathNameToNtPathName_U(path, &str, NULL, NULL)) return NULL; InitializeObjectAttributes(&attr, &str, OBJ_CASE_INSENSITIVE, NULL, NULL); status = NtCreateFile(&file, GENERIC_READ | SYNCHRONIZE | FILE_READ_ATTRIBUTES, &attr, &io, NULL, FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, FILE_OPEN, FILE_DIRECTORY_FILE, NULL, 0); /* SNIP */ return file; } Function is called like this: WCHAR szFileName[1024] = {0}; ExpandEnvironmentStringsW(L"%SystemRoot%\\sample.sdb", szFileName, 1024); // for testing purposes SdbOpenFile(szFileName, DOS_PATH); Compiled with winegcc. I am sure that C:\windows\sample.sdb exists. What am I doing wrong?

3 2

Re: [PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.
by Matteo Bruni July 28, 2013

July 28, 2013

2013/7/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/shader.c | 79 > ++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 77 insertions(+), 2 deletions(-) > So there was actually a logic (an insane one, but yeah...). Have you found any game actually using this? Annoying question: have you checked if it's the same with newer d3dx9 dlls (e.g. d3dx9_43)? It still looks to me like buggy behavior and it might be that MS fixed that in later d3dx9 versions. This is not blocking the patch of course.

2 1

Windows 7 64-bit?
by Ken Sharp July 27, 2013

July 27, 2013

I have to ask: Do we really think that this user is running Wine 1.0.1 on Windows 7 64-bit? http://appdb.winehq.org/objectManager.php?sClass=version&iId=28587&iTesting…

3 4

Need help with debugging a directx9 game crashing
by Qian Hong July 25, 2013

July 25, 2013

Hello, I was debugging on a popular game [1] [2] (9 GB), it crashes on start. +relay,+seh,+tid log show that there are some calls to wined3d.wined3d_mutex_lock / wined3d.wined3d_buffer_map / wined3d.wined3d_mutex_unlock before crashing, so I turn on +d3d9 trace to get a new log in details. To my surprise, the game doesn't crash anymore with +d3d9 trace! After a serials of bisect, I found d3d9_AddRef is the key function call related to the crashing. If I remove the TRACE statement in line 71, the game will crash with +d3d9 as well; if I upgrade the TRACE in 71 to FIXME, the game will not crash even without +d3d9. 66 static ULONG WINAPI d3d9_AddRef(IDirect3D9Ex *iface) 67 { 68 struct d3d9 *d3d9 = impl_from_IDirect3D9Ex(iface); 69 ULONG refcount = InterlockedIncrement(&d3d9->refcount); 70 71 TRACE("%p increasing refcount to %u.\n", iface, refcount); 72 73 return refcount; 74 } Further tests show that the simplest hack to avoid crashing is replacing line 71 to: FIXME("anything %x\n", 0xdeadbeef); I have no idea what the real fix is, any suggestion what is the next step to debug? Thanks in advance! Environment: Wine 1.6-rc5 Ubuntu 12.04.2 LTS gcc 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) The installer ship with native d3dx9_40.dll Backtrace on crash: Wine-dbg>c Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0x0649e6e9). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:0649e6e9 ESP:0033cc60 EBP:00000000 EFLAGS:00210206( R- -- I - -P- ) EAX:00000001 EBX:19b871e0 ECX:00000000 EDX:00000000 ESI:23f420b0 EDI:23f4f20c Stack dump: 0x0033cc60: 80004005 19c0e0c0 00000000 19b871e0 0x0033cc70: 00000000 23f420b0 23f4f1f0 19b871e0 0x0033cc80: 00000018 00000040 0000001c 00000000 0x0033cc90: 0a9101df 00000020 00000034 7bc34159 0x0033cca0: 00110064 ffffffff 0033ccd8 7bc34d2d 0x0033ccb0: 00000000 0000000c 00000010 00000001 Backtrace: =>0 0x0649e6e9 in kg3dengine (+0x16e6e9) (0x00000000) 0x0649e6e9: movl 0x0(%eax),%ecx [1] http://jx3.xoyo.com/download [2] http://jx3.client.cdn.kingsoft.com/JXOnline3-v3.0.4.4980/JXOnline3-v3.0.4.4… -- Regards, Qian Hong - http://www.winehq.org

4 11

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.
by Vincent Povirk July 25, 2013

July 25, 2013

I have no opinion on this sort of work-around (it should work afaict, and I haven't found any other places where we currently use toff_t), but did you file a bug with whatever distro has such broken headers?

3 3

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 3)
by Ken Thomases July 25, 2013

July 25, 2013

On Jul 25, 2013, at 10:49 AM, Charles Davis wrote: > Try 3: Don't advertise WGL_EXT_swap_control if vsync is disabled. Looks good. Thanks, Ken

1 0

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)
by Ken Thomases July 25, 2013

July 25, 2013

On Jul 24, 2013, at 9:34 PM, Charles Davis wrote: > Try 2: Don't duplicate a constant string; we might need to add more legacy > extensions. (Hopefully not. ;) Thanks for making that change. Looks good to me. Cheers, Ken

1 2

Re: [PATCH 1/6] scrrun: Store reference count inside IFileSystem3 object
by Nikolay Sivov July 25, 2013

July 25, 2013

On 7/25/2013 16:35, Piotr Caban wrote: > --- > dlls/scrrun/filesystem.c | 163 > +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 123 insertions(+), 40 deletions(-) Why do you need this?

2 1

What to do when an application misuses an API ...
by Michael Casadevall July 25, 2013

July 25, 2013

Hey all, I've been working on trying to get Sid Meier's Civilization V (Civ5) up to a point where it works relatively flawlessly on WINE. The largest issue is that installing the latest expansion pack has completely hosed the game under WINE unless some rather ugly workarounds have been taken. Specifically, the main issue is that Civ5 loads its data files in the order returned by Find{First,Next}File(), and breaks spectacularly if that order is disrupted. I documented my findings here: http://bugs.winehq.org/show_bug.cgi?id=34122 As I sat to look at a possible patch, I'm not sure what I can actually do. Its clearly stated on the MSDN page that the order returned is dependent on the underlying filesystem, and Googling suggests that while NTFS seems to always return in a roughly alphabetical order, FAT32 will return by creation date, and with network drives all bets are off. I was even able to reproduce similar bugs in Civ5 by launching it from a network drive (which I had already tested in advance to make sure it returned an odd file order). FindFirstFile essentially calls down to NtQueryDirectoryFile, which in turn either calls a system specific syscall or readdir to get a list of files in a directory. My first thought is to extend the underlying read_directory_* functions in ntdll/directory.c so that they return an alphabetized list (essentially taking the results from getdents/getdirentries/readdir, sort them, then returning in the sort order whichever entry is next in line). This would produce a behavior similar (but not identical) to what is seen when operating under an NTFS filesystem. This approach seems wrong to me, and is further compounded by the fact this is a bug in an application, and not in WINE specifically; Under the correct circumstances, Windows will return a "non-sorted" list of files and in those cases Civilization V breaks. The flipside is that in the most common case, it works correctly, and furthermore, given how easy it is to assume that Find*File does return a sorted list, I won't be surprised if this issue has cropped up elsewhere (figuring out the underlying cause was exceedingly annoying). Any insight in to what the most correct course of action would be most appreciated I'm perfectly willing to put the legwork in fixing this bug, but I want to make sure I'm fixing it in a way that will be accepted :-). Regards, Michael

3 3