July 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] winemac.drv: Also return the number of pixel formats if the caller didn't supply a PIXELFORMATDESCRIPTOR.
by Ken Thomases July 24, 2013

July 24, 2013

On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > This is akin to what glxdrv already does, and apparently what Windows > does. It allows the GLView sample from the OpenGL SuperBible to > correctly enumerate pixel formats with the Mac driver. > --- > dlls/winemac.drv/opengl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/winemac.drv/opengl.c b/dlls/winemac.drv/opengl.c > index 0922371..fb294d1 100644 > --- a/dlls/winemac.drv/opengl.c > +++ b/dlls/winemac.drv/opengl.c > @@ -3281,7 +3281,7 @@ int macdrv_wglDescribePixelFormat(HDC hdc, int fmt, UINT size, PIXELFORMATDESCRI > > TRACE("hdc %p fmt %d size %u descr %p\n", hdc, fmt, size, descr); > > - if (fmt <= 0 || fmt > ret) return ret; > + if (fmt <= 0 || fmt > ret || !descr) return ret; > if (size < sizeof(*descr)) return 0; > > pf = &pixel_formats[fmt - 1]; > -- > 1.7.5.4 Looks good to me. Thanks! -Ken

1 0

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string.
by Ken Thomases July 24, 2013

July 24, 2013

Hi, On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > @@ -1226,8 +1227,10 @@ static BOOL init_gl_info(void) > gl_info.glVersion = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > strcpy(gl_info.glVersion, str); > str = (const char*)opengl_funcs.gl.p_glGetString(GL_EXTENSIONS); > - gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > + gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + > + sizeof(" WGL_EXT_extensions_string WGL_EXT_swap_control")); > strcpy(gl_info.glExtensions, str); > + strcat(gl_info.glExtensions, " WGL_EXT_extensions_string WGL_EXT_swap_control"); As a minor nitpick, I would prefer to avoid that duplicated string literal. Otherwise, looks good to me. Cheers, Ken

1 0

Re: [PATCH 4/5] scrrun: Add IFileSystem3::GetTempName implementation
by Alexandre Julliard July 24, 2013

July 24, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -174,6 +174,7 @@ BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls( hinst ); > scrrun_instance = hinst; > + srand(GetTickCount()); You don't want to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update English (US) resource
by Francois Gouget July 24, 2013

July 24, 2013

On Mon, 22 Jul 2013, Ken Sharp wrote: > Logon/Log on as with the British/neutral patch. > > msgid "Can't logon with inter-domain trust account.\n" > -msgstr "Can't logon with inter-domain trust account.\n" > +msgstr "Can't log on with inter-domain trust account.\n" [...] I think these fixes should really be applied to the source winerror.mc file instead. If I remember correctly en_US.po is just a dummy translation where msgid and msgstr strings should be identical (there might (with maybe one or two exceptions for things like um -> µm). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [PATCH 1/3] msvcrt: Fix _mktemp implementation
by Marvin July 24, 2013

July 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26413 Your paranoid android. === W2KPROSP4 (32 bit file) === file: unhandled exception c0000005 at 7801B5A7 === WXPPROSP2 (32 bit file) === file: unhandled exception c0000005 at 77C2F1C3 === W2K3R2SESP2 (32 bit file) === file: unhandled exception c0000005 at 77BC00A3 === WXPX64 (64 bit file) === Timeout

1 0

Re: [PATCH 1/3] d3dx9: Fix initialization of D3DXPC_OBJECTs.
by Rico Schüller July 23, 2013

July 23, 2013

On 23.07.2013 11:46, Rico Schüller wrote: > --- > dlls/d3dx9_36/effect.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > > These may not apply correctly. Sorry for the noise. I'll resend a new version. Cheers Rico

1 0

Re: [docs] "sgml" is not a valid output format
by Francois Gouget July 23, 2013

July 23, 2013

On Tue, 23 Jul 2013, Frédéric Delanoy wrote: [...] > -ALLFORMATS = html pdf sgml ps txt > +ALLFORMATS = html pdf ps txt 'make sgml' can be used to generate the translated SGML source files for our many documentation translations. So I don't think this patch should be applied. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

1 0

Re: [docs] "sgml" is not a valid output format
by Frédéric Delanoy July 23, 2013

July 23, 2013

On Tue, Jul 23, 2013 at 5:26 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > Make.rules.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Make.rules.in b/Make.rules.in > index fda8e81..d326247 100644 > --- a/Make.rules.in > +++ b/Make.rules.in > @@ -100,7 +100,7 @@ dummy: > > # Manual Dependencies > > -ALLFORMATS = html pdf sgml ps txt > +ALLFORMATS = html pdf ps txt Please discard this patch ; it seems to be used in the translated guides to generate sgml from english version+po file

1 0

Re: [1/5] oledb32: Stub for IRowPosition
by Marvin July 23, 2013

July 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26406 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 1/2] wined3d: Implement special fog behavior for orthogonal projection matrices.
by Henri Verbeet July 23, 2013

July 23, 2013

On 22 July 2013 20:24, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -3614,10 +3614,19 @@ void wined3d_ffp_get_vs_settings(const struct wined3d_state *state, const struct > & WINED3D_FFP_LIGHT_TYPE_MASK) << WINED3D_FFP_LIGHT_TYPE_SHIFT(i); > } > > + settings->ortho_fog = 0; > if (!state->render_states[WINED3D_RS_FOGENABLE]) > settings->fog_mode = WINED3D_FFP_VS_FOG_OFF; > else if (state->render_states[WINED3D_RS_FOGTABLEMODE] != WINED3D_FOG_NONE) > + { > settings->fog_mode = WINED3D_FFP_VS_FOG_DEPTH; > + > + if (state->transforms[WINED3D_TS_PROJECTION].u.m[0][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[1][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[2][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[3][3] == 1.0f) > + settings->ortho_fog = 1; > + } I'm going to guess "No, because the projection matrix is ignored.", but does this "feature" apply to transformed vertices as well?

1 0

Re: [PATCH 2/2] include/ddk: add usbioctl.h
by Nikolay Sivov July 22, 2013

July 22, 2013

On 7/22/2013 22:38, Damjan Jovanovic wrote: > Changelog: > * add usbioctl.h > > Damjan Jovanovic Hi, Damjan. You forgot patches.

3 2

Re: appwiz: Correct Wine Mono installer messages
by Alexandre Julliard July 22, 2013

July 22, 2013

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Where the correction is obvious I have done so, but where a full > translation is needed I have simply removed the incorrect one. This > will mark that line as untranslated and hopefully someone will see > that. It will also default to English with the correct message until > translated. That's what fuzzy is for, there's no reason to remove them. -- Alexandre Julliard julliard(a)winehq.org

3 3

Wine 1.6 list of deferred patches
by Bruno Jesus July 22, 2013

July 22, 2013

This is the list of (hopefully) all deferred patches for wine 1.6, all authors are in bcc. I hope it's useful for developers. 97187 Deferred Dmitry Timoshkov [3/3] kernel32: GetShortPathName for a non-existent short file name should fail. 97131 Deferred Rosen Diankov [ole32] Bugfix for implicit MTA apartment initialization 97130 Deferred Rosen Diankov [oleaut32] Bugfix patches for marshaling VT_UNKNOWN in SAFEARRAYS 97124 Deferred Maarten Lankhorst [RFC PATCH] loader: allow overriding pthread_create correctly on linux 97119 Deferred Fabian Ebner [PATCH] dinput: Check the message queue in GetDeviceState * 97085 Deferred Dmitry Timoshkov ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file. 96974 Deferred Stefan Dösinger [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader 96961 Deferred Mathis Beer ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3.5, alternate version) 96925 Deferred Hans Leidekker server: The token user SID must be present in the default DACL. 96899 Deferred Stefan Dösinger [PATCH 1/5] wined3d: Consolidate d3d_info BOOLs into a flags field 96855 Deferred Alistair Leslie-Hughes oledb32: Add IErrorInfo Support OK 96854 Deferred Alistair Leslie-Hughes msdaps: Add support for ISourcesRowset (try 2) 96831 Deferred Christian Costa [PATCH] d3dxof: Remove LP stuff and rename variables for IDirectXFile methods. 96819 Deferred Nikolay Sivov comctl32: Properly handle repainting for HDF_OWNERDRAW items 96797 Deferred André Hentschel ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32 (try 2) 96793 Deferred Christian Costa [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests. 96791 Deferred morphiend msvcrt: add support for _chsize_s 96765 Deferred Christian Costa [PATCH 2/4] d3dxof: Handle float in binary mode and remove code that becomes useless. * this patch was already commited.

1 0

Re: [PATCH 3/4] d3dx9: Improve ID3DXConstantTable::Set*().
by Alexandre Julliard July 22, 2013

July 22, 2013

Rico Schüller <kgbricola(a)web.de> writes: > +static UINT set(struct ID3DXConstantTableImpl *table, IDirect3DDevice9 *device, struct ctab_constant *constant, > + const void **indata, D3DXPARAMETER_TYPE intype, UINT *size, UINT incol, D3DXPARAMETER_CLASS inclass, UINT index, > + BOOL is_pointer) > +{ > + DWORD (*get_index)(const void **indata, UINT index) = NULL; > + D3DXCONSTANT_DESC *desc = &constant->desc; > + UINT l, i, regcount = 1, regsize = 1, cin = 1, rin = 1, ret, last = 0; > + DWORD tmp; > + > + if (is_pointer) get_index = &get_index_pointer; > + else get_index = &get_index_array; It would be cleaner and easier to follow to have a simple helper with a is_pointer flag, rather than using function pointers with such trivial functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 2)
by Nikolay Sivov July 21, 2013

July 21, 2013

On 7/20/2013 23:37, John Chadwick wrote: > This patch changes the create_selection interface to accept a wide string > instead of an xmlChar string. This is a transitional change, which will be > needed as libxml2's XPath parser is phased out. > > The last submission had a memory leak (sorry, I isolated this change > from some other changes and accidentally axed a heap_free in the > process.) Looks ok, I didn't try tests, but I hope you did.. One thing though: > +static inline WCHAR *heap_strcatW(WCHAR *a, const WCHAR *b) > +{ > + int len = strlenW(a) + strlenW(b); > + WCHAR *c = heap_realloc(a, (len + 1) * sizeof(WCHAR)); > + WCHAR *ptr = c; > + > + while(*ptr) > + ptr++; > + while(*b) > + *(ptr++) = *(b++); > + c[len] = 0; > + > + return c; > +} > + I'm assuming you didn't use strcatW() to avoid one more strlenW()? Even if you don't want to use it for some reason, you don't need first loop cause you already know 'a' length, and second loop is just strcpyW(). Also I suggest to use 'dst', 'src' names for parameters.

1 0

Coverity Status
by Marcus Meissner July 20, 2013

July 20, 2013

Hi, For Wine 1.6 we have the following Coverity stats: - 3,648,322 Lines of Code scanned - Defect Density 0.51 - 8321 total defects - 1852 outstanding (unresolved) defects - 1964 dismissed defects - 4505 fixed defects git shortlog wine-1.4..wine-1.6|grep -i Coverity|wc -l 225 Thanks to AmineKhaldi uploading the builds and everyone reviewing and fixing coverity issues :) Ciao, Marcus

1 0

Another major milestone
by Jeremy White July 19, 2013

July 19, 2013

Alright folks, I have to confess that the 1.6 release came and I didn't immediately get up and dance. In fact, a new Wine release was almost...boring. I think we have to consider that a major milestone in of itself. New, useful releases are just a matter of course for us now. Woohoo! Now I'm dancing <grin>. Cheers, Jeremy

8 9

Re: [docs] winelib: Use proper entity escaping for '&','<' and '>'
by Julian Rüger July 19, 2013

July 19, 2013

Hi Frédéric, > - $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $< | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ > + $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $lt; | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ looks like you forgot the "&". Best, Julian

2 1

Re: [2/2] gdiplus: Store graphics clipping region in device coordinates.
by Vincent Povirk July 19, 2013

July 19, 2013

I'm curious what happens if the world transform has some rotation. It seems like transform_rectf would break in that case.

2 2

Re: [1/2] windowscodecs: Add a test for global GIF palette exposed by recent Windows versions.
by Vincent Povirk July 19, 2013

July 19, 2013

The series looks good to me.

1 0

Re: [1/4] wincodecs: Added IWICBitmapClipper stub
by Vincent Povirk July 19, 2013

July 19, 2013

This series looks good to me.

1 0

Re: riched20: Add tests for ITextRange interface.
by Nikolay Sivov July 19, 2013

July 19, 2013

On 7/18/2013 20:28, Caibin Chen wrote: > Add tests for start and end point, setting and getting text. > --- > dlls/riched20/tests/Makefile.in | 3 +- > dlls/riched20/tests/txtrng.c | 343 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 345 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/tests/txtrng.c You could just use existing file, richole.c fits I think.

2 7

Re: Patches I maintain
by Rico Schüller July 18, 2013

July 18, 2013

Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You may have a look here: http://wiki.winehq.org/SubmittingPatches On 18.07.2013 01:23, Roland Haeder wrote: > +HRESULT D3DXCreatePolygon(LPDIRECT3DDEVICE9 device, float length, UINT sides, LPD3DXMESH *mesh, LPD3DXBUFFER adjacency) Well this looks a little bit wrong. You may have a look here http://msdn.microsoft.com/en-us/library/windows/desktop/bb172785%28v=vs.85%… . Don't copy and paste it. A patch which by accident works, is not something which should be applied at all. There are several issues alone in that line. Cheers Rico

2 1

Re: winedev: Add doc for winedbg symbol_picker option
by Frédéric Delanoy July 17, 2013

July 17, 2013

On Thu, Jul 18, 2013 at 12:48 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > en/winedev-debugger.sgml | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > Please discard this. It has been committed a long time ago. Sorry (again) for the noise. Frédéric

1 0

Manpage patch, please review
by Julian Rüger July 17, 2013

July 17, 2013

Hi all! While working on the translation of the (main) manpage, I noticed a few issues in the English version and started working on a patch. That was quite some time ago, I had little spare time lately and didn't get around to finish and send it in. So I figured I just take what I have now and ask you guys for comments. I appreciate any remarks or suggestions. Thanks, Julian Notes: I had a change similar to Frédéric's, mentioning wine can run 64-bit programs now. He was quicker and I like his wording better. I had something like "[...]or Win64 executable (if your version of wine was compiled with 64-bit support)." I guess that would be more confusing to people using their distro's wine packages and people compiling their own wine know that anyway. Do you agree or do you think it's better to be more specific? CUI -> CLI: According to Google and Wikipedia, CLI is more common. -.BR @bindir@/wineserver , +.IR @bindir@/wineserver , and following, similar changes: This is the way it is formatted in the wineserver manpage. I noticed there is no uniform style across our manpages, so we should have a guideline. Should paths be bold or italic/underlined?

2 4

Re: ieframe: Use SHANDLE_PTR in IWebBrowserApp::get_HWND.
by Marvin July 16, 2013

July 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26282 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 004033D1

2 1

Re: loader: Indicate wine can run 64-bit apps in manpage
by Frédéric Delanoy July 16, 2013

July 16, 2013

On Tue, Jul 16, 2013 at 4:57 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > loader/wine.man.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Please ignore this patch: I accidentally resent it. Sorry about the noise. Frédéric

1 0

Re: po: Update Turkish translation (second try)
by Francois Gouget July 16, 2013

July 16, 2013

-<<<<<<< HEAD -"PO-Revision-Date: 2013-07-13 04:49+0200\n" -======= -"PO-Revision-Date: 2013-07-04 00:10+0200\n" ->>>>>>> 598685e6c5992355de35b4345e91eb4e50b9f07e +"PO-Revision-Date: 2013-07-13 05:00+0200\n" [...] -#: attrib.rc:27 cmd.rc:322 +#: attrib.rc:27 cmd.rc:325 These look wrong: there is currently no conflict in the checked-in PO file and there should not be any line-number changes in the patch. So it won't apply to the current Git repository. Something must have happened when you rebased or generated the diff. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

1 0

Re: [PATCH 1/3] user32/tests: Sleep enough time to make sure all input message have been processed.
by Qian Hong July 16, 2013

July 16, 2013

Hello, This patch is marked as pending, is there anything I can improve? Did the test results in [1] and [2] help? Thanks for any feedback! [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 On Wed, Jul 3, 2013 at 2:45 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hello, > > Current menu test code may hide some failure tests [1], with the attached > patch, all failure tests could be detected [2]. > > > [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 > [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 > > > --- > dlls/user32/tests/menu.c | 1 + > 1 file changed, 1 insertion(+) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

2 6

Re: ntdll: Tests for RtlHashUnicodeString()
by Dmitry Timoshkov July 16, 2013

July 16, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +#include "ddk/wdm.h" Please don't do that, this breaks compilation with PSDK headers. If you need some specific definitions, types or API prototypes - replicate them in the test itself. -- Dmitry.

2 2

Re: riched20: ITextDocument stubs for ITextServices
by Frédéric Delanoy July 15, 2013

July 15, 2013

On Sun, Jul 14, 2013 at 3:50 AM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > You have to use your real name when submitting patches to wine-patches. Frédéric

1 0

How to configure C++ implements in wine?
by 中川祥 July 15, 2013

July 15, 2013

I'm working at User Access Logging API<http://msdn.microsoft.com/en-us/library/windows/desktop/hh437524(v=vs.85).a…> for Windows8. It need C++ style coding. How can I solve it?

2 1

Re: [docs 2/3] winedev: Use hyphen in bitness
by Frédéric Delanoy July 14, 2013

July 14, 2013

On Sun, Jul 14, 2013 at 7:41 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > en/winedev-architecture.sgml | 56 ++++++++++++++++++++++---------------------- > en/winedev-debugger.sgml | 10 ++++---- > en/winedev-kernel.sgml | 24 +++++++++---------- > en/winedev-multimedia.sgml | 36 ++++++++++++++-------------- > 4 files changed, 63 insertions(+), 63 deletions(-) > - (an int is 16 bit in 16-bit and 32 bits in 32-bit, pointers > + (an int is 16-bit in 16-bit and 32-bits in 32-bit, pointers This part sounds a bit weird... also, one is in plural with the other is in singular form. Probably would benefit from a sentence reorganization. Frédéric

1 0

Re: po: Tweak the French 'broadcast' and 'unicast' translations.
by Frédéric Delanoy July 13, 2013

July 13, 2013

On Fri, Jul 12, 2013 at 4:33 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > Surprisingly enough (for me) the existing translations match the term > used in Microsoft's Terminology file: > "broadcast address" -> "adresse de diffusion" > "broadcast" -> "diffusion" > "multicast" -> "multidiffusion" > "unicast" -> "monodiffusion" > > https://www.microsoft.com/Language/en-US/Terminology.aspx > > But I still don't think they're good translations. I find 'diffusion' > way too general and vague. Reading it I would certainly not make the > link with broadcast, even in the domain of networking. Similarly I don't > think 'monodiffusion' would be readily understood. > > So I'm more enclined to follow Wikipedia which uses the untranslated > terms as the title of their French articles: Well they're just untranslated... you said it The "grand dictionnaire terminologique" (http://gdt.oqlf.gouv.qc.ca/Resultat.aspx) gives broadcast -> diffusion (générale) multicast -> multidiffusion / diffusion groupée (beurk) monocast -> envoi individuel http://glossaire.traduc.org/ (used for manpages/howtos) gives broadcast -> diffusion multicast -> multidiffusion unicast -> unicast BTW to broadcast = diffuser I may agree with unicast but the "diffusion" and "multidiffusion" seem OK to me

3 4

Re: po: update Simplified Chinese translation
by Francois Gouget July 12, 2013

July 12, 2013

I'll take this opportunity to note that Microsoft's Simplified Chinese Style Guide says: | Colon | * Software localization: Use English colon (:) in Software | localization. A single byte space should be left between the | English colon and the subsequent characters (Chinese full-width | punctuation marks are excluded). For documentation they say to use a double byte colon. So it seems like our PO files should actually be using single-byte colons everywhere. Does this make sense? http://download.microsoft.com/download/4/c/a/4ca95933-3496-4793-9d77-a89b60… As an additional not, I don't think this is grounds for rejecting this patch given that it is consistent with existing translations. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: po: Some Franch translation tweaks.
by Frédéric Delanoy July 12, 2013

July 12, 2013

On Fri, Jul 12, 2013 at 1:16 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > po/fr.po | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) There's a typo in the commit message (you probably spotted it already). > msgstr "" > "PAUSE affiche un message à l'écran demandant à l'utilisateur d'appuyer sur " > -"une touche.\n" > +"une\n" > +"touche.\n" This is probably not needed > msgid "Drive Mapping" > -msgstr "Assignation de lecteur" >+msgstr "Dossier cible" Are you sure about this one? Maybe the original should be changed as well in this case... Frédéric

2 1

Re: po: Fix the French DEL, ERASE, RD and RMDIR usage messages.
by Frédéric Delanoy July 12, 2013

July 12, 2013

On Fri, Jul 12, 2013 at 12:34 PM, Francois Gouget <fgouget(a)free.fr> wrote: > msgid "DEL <filename> deletes a file or set of files.\n" > -msgstr "DEL <fichiers> efface un fichier ou un groupe de fichiers.\n" > +msgstr "DEL <fichier> efface un fichier ou un groupe de fichiers.\n" "fichiers" indicate it can be any number of files, replacing by the singular form doesn't (one may think only one file is deletable per command) If you absolutely want the same singular ou plural form, the English msgid it what should be changed instead IMO Same remark for your ERASE diff hunk. Regards, Frédéric

1 0

Re: po: Fix some typography and linefeed issues in the Turkish translation.
by Francois Gouget July 12, 2013

July 12, 2013

On Thu, 11 Jul 2013, Volkan Gezer wrote: [...] > Thank you for modifications. I think the only problem is: > > #: cryptui.rc:38 > msgid " to " > -msgstr " bitişi: " > +msgstr " bitişi " > > which we should keep ":" for a meaningful sentence structure. Hasan > should also correct me if I am wrong. Ok. That seems a bit strange but probably less strange than the way the code builds this string :-( It seems it does it does it this way to put parts of it in bold. I've added an exception for it and I'm resending the rest of the patch. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 1

Re: po: update Simplified Chinese translation
by Qian Hong July 12, 2013

July 12, 2013

#: winerror.mc:3016 -#, fuzzy msgid "Unknown interface.\n" -msgstr "不明来源。\n" +msgstr "未知界面。\n" Please keep persistent for the translation of 'interface'. Here 'Unknown interface.' is used with RPC_S_UNKNOWN_IF, should be translate to '接口' as well as other place. #: winecfg.rc:260 msgid "Voice output device:" -msgstr "" +msgstr "语言输出设备：" #: winecfg.rc:261 msgid "Input device:" @@ -12313,7 +12281,7 @@ msgstr "输入设备：" #: winecfg.rc:262 msgid "Voice input device:" -msgstr "" +msgstr "语音输入设备：" Please keep persistent for the translation of 'voice', it seems like a typo here, one translated to 语言 while the other translated to '语音'. #: winerror.mc:186 msgid "Sharing violation.\n" -msgstr "" +msgstr "非法共享。\n" #: winerror.mc:191 -#, fuzzy msgid "Lock violation.\n" -msgstr "位置。\n" +msgstr "非法锁定。\n" #: winerror.mc:696 -#, fuzzy msgid "Cancel violation.\n" -msgstr "信息。\n" +msgstr "非法取消。\n" The above three reference to: ERROR_SHARING_VIOLATION （共享冲突？） ERROR_LOCK_VIOLATION （锁冲突？） ERROR_CANCEL_VIOLATION （？） http://support.microsoft.com/kb/316609/en-us http://support.microsoft.com/kb/2698155/en-us http://support.microsoft.com/kb/155011/en-us I'm not sure your translation is correct, they are tricky to translate, for ERROR_CANCEL_VIOLATION, even the original English version is hard to understand :( maybe keep the English version is not a bad idea if there is no better alternative so far. Thanks for the work! On Fri, Jul 12, 2013 at 8:09 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > > > > -- Regards, Qian Hong - http://www.winehq.org

2 1

po: update Simplified Chinese translation
by Jactry Zeng July 12, 2013

July 12, 2013

1 0

Re: ole32: Tests for CLSIDFromProgID() and ProgIDFromCLSID() regarding activation context
by Marvin July 12, 2013

July 12, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26261 Your paranoid android. === W2KPROSP4 (32 bit compobj) === compobj: unhandled exception c0000005 at 00000000

1 0

Re: cmd: Fix a usage message: the % must be doubled for FOR variables. (resend)
by Alexandre Julliard July 12, 2013

July 12, 2013

Francois Gouget <fgouget(a)free.fr> writes: > The usage message was in fact documenting an old Wine bug. > --- > > The attempt did not apply, probably because I had other changes in my > tree. Hopefully this one will work. > > > I'm reluctant to change messages at this stage as it's going to cause > fuzzying of the translations, but given that this message is plain wrong > I think it's warranted. I'd suggest to simply remove the sentence, and remove it in translations too so that we don't need to invalidate all of them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime. (try 2)
by Bruno Jesus July 12, 2013

July 12, 2013

On Thu, Jul 11, 2013 at 11:19 AM, Sylvain Petreolle <spetreolle(a)yahoo.fr> wrote: > --- > dlls/wbemprox/builtin.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c > index 9e2369a..5b7674e 100644 > --- a/dlls/wbemprox/builtin.c > +++ b/dlls/wbemprox/builtin.c > @@ -1774,6 +1778,31 @@ static WCHAR *get_lastbootuptime(void) > + > + GetLocalTime(&st); > + Status = GetTimeZoneInformation(&tzi); > + > + if(Status == TIME_ZONE_ID_INVALID) return NULL; Aren't you leaking ret here? Maybe you could swap this check with the memory allocation. > + sprintfW( ret, fmtW, st.wYear, st.wMonth, st.wDay, st.wHour, st.wMinute, st.wSecond, st.wMilliseconds * 1000, -Bias); Is it ok for the + sign to the fixed in the format? Best wishes, Bruno

2 1

Re: po: Czech - corrected omission of some newline marks
by Alexandre Julliard July 11, 2013

July 11, 2013

Pavel Borecki <pavel.borecki(a)gmail.com> writes: > @@ -3060,7 +3122,7 @@ > > #: hhctrl.rc:62 winhlp32.rc:31 > msgid "&Print..." > -msgstr "&Tisknout..." > +msgstr "&Tisknout" Please keep the three dots, that's apparently the standard. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: Standardize and simplify two error messages.
by Andrew Eikum July 10, 2013

July 10, 2013

On Wed, Jul 10, 2013 at 10:42:05AM +0200, Francois Gouget wrote: > We don't have a MIDI Mapper configuration applet so don't tell the user to use it. > --- > > Or if we do, how does one get to it? I did not find anything in > winecfg.exe, nor in control.exe (the Control Panel). > > -MIDIERR_NODEVICE, "The current MIDI Mapper setup refers to a MIDI device that is not installed on the system. Use MIDI Mapper to edit the setup." I think it's meant to refer to the "MIDI Mapper" device, which is configurable through the registry: http://wiki.winehq.org/MIDI I think your change is clearly an improvement. Andrew

1 0

Should we translate the prompt
by Jactry Zeng July 10, 2013

July 10, 2013

Hi everybody, In po file there were some prompts as this: #: xcopy.rc:35 msgid "%1? (Yes|No)\n" I am not sure that should I translate them in po file for Simplified Chinese. But they have been translated in po file for French and Traditional Chinese. As prompts in command line, I don't think translating them into another language is good. It may make the users don't know what should them type into. When I discuss this with Qian Hong, he give a better idea. We may can just make the origin text more apropos, just like: msgid "%1? (Y)es|(N)o\n" So that we can translate it into Simplified Chinese: msgid "%1？是(Y)|否(N)\n" Thanks for any comment. -- Regards, Jactry Zeng

3 3

Re: readme: Update German translation
by Joerg Schiermeier July 9, 2013

July 9, 2013

> Hi ... list, Hi Julian > I think "liesmich" is more common than "lesmich", although both sound > awkward. Do we need/want to translate that? Yes really. 'Liesmich' is a direct translation of 'readme'. Eventually this older translation was a simply typo? So please change this! Thanks. > Best, > Julian -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: readme: Update German translation
by Julian Rüger July 9, 2013

July 9, 2013

Am Dienstag, den 09.07.2013, 00:46 +0200 schrieb André Hentschel: > --- > documentation/README.de | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > Hi André and list, patch looks good to me. One minor remark: > + wine notepad.exe lesmich.txt (Programmaufruf mit Parametern) I think "liesmich" is more common than "lesmich", although both sound awkward. Do we need/want to translate that? Best, Julian PS: I have some more manpage-patches in the works, but my spare time has been a little scarce lately. Do you think 1.6 will be released Friday?

3 2

Re: po: Arabic full translated wine. (try2)
by Yaron Shahrabani July 8, 2013

July 8, 2013

Non critical changes but take a look if you like: #: comdlg32.rc:186 comdlg32.rc:141 -#, fuzzy msgid "Save As" msgstr "احفظ &ك‍..." Redundant Elipsis. #: comdlg32.rc:202 -#, fuzzy msgid "S&election" -msgstr "اختر ال&كل\tCtrl+A" +msgstr "الاختيار" #: comdlg32.rc:203 -#, fuzzy msgid "&Pages" -msgstr "صفحة &p" +msgstr "صفحات" #: comdlg32.rc:206 comdlg32.rc:228 -#, fuzzy msgid "&Setup" -msgstr "إعداد الصفحة" +msgstr "إعداد" No accelerator (&) sign. #: comdlg32.rc:207 msgid "&From:" -msgstr "" +msgstr "&من" #: comdlg32.rc:208 msgid "&To:" -msgstr "" +msgstr "&إلى" No semicolon at the end. #: comdlg32.rc:211 -#, fuzzy msgid "Print to Fi&le" -msgstr "ملفات النصوص (*.txt)" +msgstr "اطبع إلى ملف" #: comdlg32.rc:268 msgid "Scr&ipt:" -msgstr "" +msgstr "ترميز" No accelerator sign. #: comdlg32.rc:281 comdlg32.rc:304 msgid "Color | Sol&id" -msgstr "" +msgstr "اللون | &جامد" No need to add اللون |‏ before the &جامد part. There might be more. Anyways great job! Kind regards, Yaron Shahrabani <Hebrew translator> On Sun, Jun 30, 2013 at 6:27 AM, مصعب الزعبي <moceap(a)hotmail.com> wrote: > --- > > po/ar.po > > > > > >

2 1

Re: [PATCH] gdiplus: fixing identical sub-expressions
by Vincent Povirk July 7, 2013

July 7, 2013

I'm not sure we should change this during code freeze.

1 0