July 2013 - Wine-Devel - list.winehq.org

Re: [1/2] iphlpapi: Add support for the listener and connection classes in GetExtendedTcpTable.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26479 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === WVISTAX64 (64 bit iphlpapi) === Timeout

1 0

Re: riched20: ITextDocument stubs for ITextServices (retry)
by Caibin Chen July 30, 2013

July 30, 2013

Anybody reviewing this patch? It's almost all stubs, so although it's long, it shouldn't be hard to review 2013/7/15 Caibin Chen <tigersoldi(a)gmail.com>: > (Retry with real name in mail. The name in the patch is already my real name) > > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 16 ++- > dlls/riched20/txtdoc.c | 282 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 46 +++++++ > dlls/riched20/txtsrv.c | 6 + > 5 files changed, 350 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/txtdoc.c > create mode 100644 dlls/riched20/txtdoc.h

2 4

[PATCH 1/2] ntdll: Implement NtQuerySystemInformation class 0x37
by Chris Moeller July 29, 2013

July 29, 2013

2 1

GetNumaHighestNodeNumber tests
by Chris Moeller July 29, 2013

July 29, 2013

Here is a basic stand-alone test program, which I should probably learn how to implement into the standard testing array. On my test Windows 7 system with a single processor (4 cores), it outputs the following: Testing NtQuerySystemInformationSystemNumaHighestNodeNumber = 0x37, ...): ... with invalid size returned c0000004 ... with valid size returned 0, HighestNodeNumber = 0, ResultLength = 4 Testing GetNumaHighestNodeNumber: ... returned 1, HighestNodeNumber = 0

1 0

[PATCH 2/2] kernel32: Implement GetNumaHighestNodeNumber
by Chris Moeller July 29, 2013

July 29, 2013

1 0

[PATCH 0/2] Implement basic GetNumaHighestNodeNumber
by Chris Moeller July 29, 2013

July 29, 2013

This patch against HEAD does the following in two parts: Part 1) Implements NtQuerySystemInformation class 0x37, which I have given the name SystemNumaHighestNodeNumber, since that appears to be all it does. It currently is limited to simulating a single node system, and returns the correct error status if queried with too small a return buffer. Part 2) Implements GetNumaHighestNodeNumber based on the above interface, and behaves just like a Windows 7 32-bit kernel32.dll does in case of errors in that function.

1 0

kernel32: Correct log on / logon (noun / verb)
by Ken Sharp July 29, 2013

July 29, 2013

Evening Winos, Attached is a patch to correct some winerr messages. Specifically change a noun to a verb, and update the .po files with it. Firstly, could you take a look and point out any obvious errors I may have made? I have marked some of the translations fuzzy because it's not clear if the original translator realised that this should have been the verb and not the noun. A quick look through the translations on Wikipedia suggests that most languages do use different terms for the noun and the verb. https://cs.wikipedia.org/wiki/Login https://de.wikipedia.org/wiki/Login_(Informationstechnik) https://es.wikipedia.org/wiki/Login and so on. Some of these listings seem to use completely different words to the current translation in Wine so I wouldn't dare make a guess. Secondly, what do people think about the use of "Can't" as opposed to "Cannot"? I have not made the change in the patch but I'm wondering if people think that this should be done. Can't is informal and as my old English teacher would say, "Can't is not a word!" It is, but being pedantic "cannot" is probably the better choice. I assume Windows uses "can't" seen as it listed in winerror.mc. Thanks all! Ken

2 1

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Matteo Bruni July 29, 2013

July 29, 2013

2013/7/30 Chris Moeller <kode54(a)gmail.com>: > > On Jul 29, 2013, at 11:22 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > >> 2013/7/29 Chris Moeller <kode54(a)gmail.com>: >>> without looking very deeply into the CRT source code. >> >> You're talking about MS source code, right? That makes you tainted for >> contributing to Wine at >> the very least for C runtime-related code :( >> If you haven't looked into any other source code, this patch might be >> okay (barring other issues, I haven't read the patch at all). At least >> http://wiki.winehq.org/DeveloperFaq#head-fed5011434f62ae1a88baebfb8193a37ea… >> seems to suggest so. > > I did not look at any CRT source code to determine how to implement the functionality of this patch. I only looked at CRT source code to determine why the CRT was crashing in the first place. The HighestNode function popping a warning in my wine logs should have been hint enough to discover that function was stubbed. > > I actually determined how these functions worked by testing their behavior against a working system, and also with the aid of another developer, who pointed out a handy Win32 function for retrieving a suitable value for the free memory check. That's probably fine, although as a general rule you should stay as far as possible from Microsoft's source code. Cheers, Matteo.

1 0

[1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Chris Moeller July 29, 2013

July 29, 2013

Main changes from HEAD: 1) Implements GetNumaHighestNodeNumber which simulates a typical single node system. 2) Implements GetNumaNodeProcessorMask which returns the global processor affinity mask for node 0, otherwise returns an error. 3) Implements GetNumaAvailableMemoryNode which returns available physical memory for node 0, otherwise returns an error. This much of the behavior was observed based on a single processor (4 cores) Windows 7 system. These functions are utilized by the synchronization and threading primitives incorporated in the MSVC 2012 and newer C and C++ runtime libraries. concrt.h/Concurrency::critical_section, which is used by both std::mutex and std::thread, will throw an exception the moment the object is locked if GetNumaHighestNodeNumber fails, and there are at least a few examples of software which don't bother to catch this exception and thus crash, such as the alpha version of Cube World, and certain versions of the foo_wave_seekbar component for the foobar2000 audio player. The associated scheduling code appears to make use of GetNumaNodeProcessorMask as well to control how many threads are allowed to spin up at once, or so I guess without looking very deeply into the CRT source code.

3 2

Re: [PATCH] Ignore MotionNotify when XI2 is handling mouse motion
by Alexandre Julliard July 29, 2013

July 29, 2013

Josef Schimke <sgtcapslock(a)lavabit.com> writes: > Hello, > > When XInput2 takes over the mouse, regular MotionNotify events continue to be > handled alongside it. This causes the cursor to erratically skip around when > the slower method (X11 input) tries to reposition the cursor while XInput2 is > already handling future events. We want to process MotionNotify to resync the cursor position, XInput events are not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0