August 2013 - Wine-Devel - list.winehq.org

Re: riched20: Use \ulnone instead of \ul0 for no underline.
by Huw Davies Aug. 20, 2013

Aug. 20, 2013

On Mon, Aug 19, 2013 at 05:38:13PM -0500, Vincent Povirk wrote: > Testing on Windows (by saving rtf documents with wordpad and viewing > them with notepad) shows that it uses \ulnone instead of \ul0 to end > underline. Wine and Windows are both able to read either one. I think these are symonyms and indeed Windows seems to use \ulnone, so this looks good to me. Huw.

1 0

Re: Could you update/rerun that report on bugs without AppDB links?
by Dan Kegel Aug. 19, 2013

Aug. 19, 2013

I don't seem to have saved the (crappy) script. There is something similar at https://code.google.com/p/winezeug/source/browse/#svn%2Ftrunk%2Fappdb-mashup and it wouldn't be too hard to whip something up again for somebody who is motivated. Please do throttle the scraping script to avoid overloading the databases if you try. On Sun, Aug 18, 2013 at 12:11 PM, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: > Dan, > > I don't know if you've been following the "PLEASE add bug links!" thread on wine-devel, so I figured I'd just contact you directly. Do you remember that report on unlinked bugs you ran about 5 years ago? http://kegel.com/wine/unlinked.html > > Could you update/run it again against current bugzilla? If we post a link to the results on the forum, we could ask users to help clear the backlog. > > -- > Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: [website] Added templates/zh-cn/cvs.template translation
by Hin-Tak Leung Aug. 19, 2013

Aug. 19, 2013

------------------------------ On Sat, Aug 17, 2013 09:02 BST Frédéric Delanoy wrote: >On Sat, Aug 17, 2013 at 5:57 AM, xulixin <xulixin1990(a)gmail.com> wrote: >> Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other >> format? > >Not sure, most people (at least non-Chinese) use firstname lastname >convention, but I guess you should use the same convention as other >Chinese-speaking committers. > >Here's a list I extracted from AUTHORS file that *look* Chinese to me >(don't know if they're really Chinese, or Korean, or from another >Asian country): >Chae Jong Bin >Cheer Xiao >Chia-I Wu >Hwang YunSong (황윤성) >Jau-Horng Chen >Jay Yang >Qian Hong >Qingchuan Wang >Qingdoa Daoo >Shi Quan He >Wei-Lun Chao >Weisheng Li >Xiang Li >XueFeng Chang >Yong Chi >Yuxi Zhang >Zhangrong Huang >Zhan Jianyu > >Hope this helps, > >Frédéric Delanoy Many had replied but few had touched the _main_ issue: it is a matter of policy that patches of an anonymous origin to Wine are categorically rejected. The Linux kernel also has a similar policy. This policy is due to past threats of copyright/intellectual-property infringements and possible cause of contamination from people who may have privileged access to proprietary technology. So a "real name" is needed for any patches. As already discussed, "xulixin" is a real name - as it appears on official documents, passports, etc. Although for the benefit of Western custom, "Xu Li-Xin", or "Xu Lixin", or "Lixin Xu" or "Li-Xin Xu" might make it more obvious, and make some people happier. Ultimately it is Alexandre's call, what is considered a real name. Anyway, the git command to set a default user name for generating patches is, e.g. for mine: git config --global user.name "Hin-Tak Leung" (this writes to ~/.gitconfig, which is a text files that one can edit by hand as well). See "man git-config" for details. Without --global, these config's are set per repository. e.g. you may use different names and e-mail addresses for internal (job-wise) work and external (open) work. I also have a few other global configs of my own; the equivalent of these two are probably useful to most people: git config --global ui.color true and git config --global core.editor emacs (the former sets colorization on for "git log", "git diff", etc; I find it useful of having diff's colorized - that assumes that you do all your development work on a terminal that's color-capable (most recent linux consoles/terminals are); the latter sets the default editor to emacs, when composing commit messages. You may want to set it to your favorite editor, whichever that is.).

1 0

Re: [PATCH 2/5] wined3d: Wrap resource->heapMemory into a structure
by Henri Verbeet Aug. 19, 2013

Aug. 19, 2013

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +struct wined3d_heap_memory *wined3d_alloc_resource_mem(UINT size) > +{ > + struct wined3d_heap_memory *ret; > + > + ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ret)); > + if (!ret) > + return NULL; > + > + ret->alloc_ptr = HeapAlloc(GetProcessHeap(), 0, size + RESOURCE_ALIGNMENT); > + if (!ret->alloc_ptr) > + { > + HeapFree(GetProcessHeap(), 0, ret); > + return NULL; > + } > + ret->ptr = (BYTE *)(((ULONG_PTR)ret->alloc_ptr > + + (RESOURCE_ALIGNMENT - 1)) & ~(RESOURCE_ALIGNMENT - 1)); > + return ret; > +} > + I don't think this is a good idea. How about something like the following? The corresponding free function would be trivial. void *wined3d_memalign(SIZE_T alignment, SIZE_T size) { SIZE_T align; void *mem; void **p; align = max(sizeof(*p), alignment - 1); if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align))) return NULL; p = (void **)(((ULONG_PTR)mem + align) & ~(alignment - 1)) - 1; *p = mem; return ++p; } (Untested, there's probably some room for improvement.)

3 6

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.
by Alexandre Julliard Aug. 19, 2013

Aug. 19, 2013

Kai Tietz <ktietz70(a)googlemail.com> writes: > diff --git a/tools/widl/widl.c b/tools/widl/widl.c > index 5df99fc..6d8ec87 100644 > --- a/tools/widl/widl.c > +++ b/tools/widl/widl.c > @@ -139,7 +139,7 @@ int line_number = 1; > > static FILE *idfile; > > -unsigned int pointer_size = 0; > +unsigned int pointer_size = sizeof(void*); > syskind_t typelib_kind = sizeof(void*) == 8 ? SYS_WIN64 : SYS_WIN32; This is wrong, the host pointer size shouldn't have any influence on the generated code. -- Alexandre Julliard julliard(a)winehq.org

2 3

re: open bugs / multi thread / recommendation on new system
by Dan Kegel Aug. 19, 2013

Aug. 19, 2013

Damian wrote: > 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? Don't know. I just use nvidia cards I find in the trash :-) But then I don't actually play games, so I don't care about 3d performance. > 2) FX 8320 or intel same price class CPU? As the AMD has far inferior > single thread performance but far superior multi thread performance - > does wine run a win32 single thread app as multi thread? does wine > make use of multithread in general? For what it's worth, when I was paying attention to such things, the command for cpu in `seq 0 3` do; sudo cpufreq-set -g performance -c $cpu; done is needed to get reasonable performance on my A8, see http://comments.gmane.org/gmane.comp.emulators.wine.devel/86659 Perhaps this also applies to more capable amd chips and current linux. wine just maps threads one to one, there is no magic. If the game uses multiple threads, then wine uses multiple threads. Rather than ask abstract questions here, you should probably go ask for framerates on specific games on the wine forum.

1 0

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)
by Alexandre Julliard Aug. 19, 2013

Aug. 19, 2013

John Chadwick <johnwchadwick(a)gmail.com> writes: > This patch was posted a bit ago without any objections, but seemingly > slipped through the cracks. Very slight revisions were made since try > 3 to improve the conciseness of code. > > From 8157b8a3d347c47f7f21e74d621632b4a9f50fd6 Mon Sep 17 00:00:00 2001 > From: John Chadwick <johnwchadwick(a)gmail.com> > Date: Sun, 21 Jul 2013 14:41:37 -0400 > Subject: msxml3: Defer the conversion of XPath expressions to UTF-8. > > This patch changes the create_selection interface to accept a wide string > instead of an xmlChar string. This is a transitional change, which will be > needed as libxml2's XPath parser is phased out. > > The implementation of tagName_to_XPath also had to be changed as it was using > libxml2's UTF-8 string API. libxml2 contained a strcat that performed > reallocation, so it was replaced with a new function that does the same with > heap_realloc and wide strings (heap_strcatW in msxml_private.h.) That's a very inefficient way to build a string. Adding this as a helper is even worse since it will encourage other places to use it too. Please try to allocate a large enough buffer from the start, or if not possible grow it quadratically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume
by Henri Verbeet Aug. 19, 2013

Aug. 19, 2013

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) > +{ > + volume->texture_level = level; > +} > I think that's a step in the wrong direction. I think this should be set on volume creation. We do have a construction like this for surfaces, but the reasons for that don't apply to volumes, and I'd like to get rid of it for surfaces as well if at all possible.

2 2

Re: [PATCH 3/5] wined3d: Properly allocate heap memory for volumes
by Henri Verbeet Aug. 19, 2013

Aug. 19, 2013

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -184,7 +184,16 @@ HRESULT CDECL wined3d_volume_map(struct wined3d_volume *volume, > volume, map_desc, box, flags); > > if (!volume->resource.allocatedMemory) > - volume->resource.allocatedMemory = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, volume->resource.size); Can this ever happen?

2 1

Re: [PATCH 4/5] wined3d: Move volume booleans into a flags field
by Henri Verbeet Aug. 19, 2013

Aug. 19, 2013

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + volume->flags |= WINED3D_VFLAG_LOCKABLE; /* FIXME */ You'll probably want to fix that :-) I think you can just leave the flag out until you rename it to WINED3D_VFLAG_MAPPABLE in one of the later patches.

1 0

Re: [PATCH 1/5] wined3d: Keep GL_UNPACK_CLIENT_STORAGE_APPLE off by default
by Stefan Dösinger Aug. 19, 2013

Aug. 19, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Henri, Matteo, When reviewing those patches, please have a look at the attached archive. It contains the rest of the volume cleanup patches and some tests. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSEd58AAoJEN0/YqbEcdMwGygP/3UsMheQPv6ZmMMGdX+QXltj 0LfSKw7wJiNFFc2+rR/NAP8s1+iGtXKvABLvTINv5ZXwngPxUc10g/5MveV1MRzQ lgU2ebRjFnFFCv0ytcSeb5dutH5EMnIplxYQEDvPR+ojkjwS5bvRENtdh4/BZPGc gh0KoKk4YwsBl3GyWwM6hM8NlEFrwvtWeEU3UdXzZiIYg3WfT5CaXGR3A4o4/G+i WBYar5nGocKHs+5Wgfe4BMC4XNuFD/RFT9R7gB7nrIYQgPJ6j+J46Zkt4ux0ivtH eBHQ5QQNB4SdVoCwPf9H56cBYhtmC6iEFYJg4wEGukZPIhaZ0Je2KHUIXuXumVfB ciesPUN+7DhuZCLSFm5eJUO7aTF+WHOD+uyQKZkLN1oK3JkXy2wflE2d8O2BQKTo qCZPtcA8vmE0DIvk9Q6j8Xt2nAmTnnqIh26ZCsCsj9vZvPn+pNlXT1lduwoF3x2H oKZufHdCdgRKLmRLpVnmPdwKTqwmlSZa9u1RVhDAypLVv20VqykOLAh6mDJC9zl7 k/2ozgsfYsl0kYMTVw5o6dx3f3pJGfgGjsw4vuJHN08aeZmVl1EFY8nMlqzrT8Wa cRjSHKxqk+W3BxTsQz9Zi1u0J3v8nE4KM79IpLgfjm8M9Rk6eTaLkwCe5XpFuiSw MJbpYdZZGZfZuP71LMmm =gRPu -----END PGP SIGNATURE-----

1 0

Re: [website] Added templates/zh-cn/cvs.template translation
by Frédéric Delanoy Aug. 19, 2013

Aug. 19, 2013

On Sat, Aug 17, 2013 at 5:57 AM, xulixin <xulixin1990(a)gmail.com> wrote: > Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other > format? Not sure, most people (at least non-Chinese) use firstname lastname convention, but I guess you should use the same convention as other Chinese-speaking committers. Here's a list I extracted from AUTHORS file that *look* Chinese to me (don't know if they're really Chinese, or Korean, or from another Asian country): Chae Jong Bin Cheer Xiao Chia-I Wu Hwang YunSong (황윤성) Jau-Horng Chen Jay Yang Qian Hong Qingchuan Wang Qingdoa Daoo Shi Quan He Wei-Lun Chao Weisheng Li Xiang Li XueFeng Chang Yong Chi Yuxi Zhang Zhangrong Huang Zhan Jianyu Hope this helps, Frédéric Delanoy

2 2

PLEASE add bug links!
by Ken Sharp Aug. 18, 2013

Aug. 18, 2013

There's little point in my continually asking users to add bug links to the AppDB if maintainers and/or administrators don't bother themselves. It takes longer to create a bug report than it does to link it to the database. It really isn't that hard. I've added hundreds over the past few weeks and this is not the first time I have said it, nor am I the first one to do so. It's even on the Wiki. http://wiki.winehq.org/Bugs

8 20

Re: mshtml: Use winehq snapshot instead of the main page in tests.
by Marvin Aug. 18, 2013

Aug. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26726 Your paranoid android. === WXPPROSP2 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00289218) != exmon(002683C0) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00289218) != exmon(002683C0) htmldoc.c:5715: Test failed: mon(00289218) != exmon(002683C0) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(002CFA10) != exmon(002854D0) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(002CFA10) != exmon(002854D0) htmldoc.c:5715: Test failed: mon(002CFA10) != exmon(002854D0) === WXPX64 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(0067F130) != exmon(00653D78) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(0067F130) != exmon(00653D78) htmldoc.c:5715: Test failed: mon(0067F130) != exmon(00653D78) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(006A5D60) != exmon(0069E610) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(006A5D60) != exmon(0069E610) htmldoc.c:5715: Test failed: mon(006A5D60) != exmon(0069E610) === WVISTAX64 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(006F6E18) != exmon(006F6018) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(006F6E18) != exmon(006F6018) htmldoc.c:5715: Test failed: mon(006F6E18) != exmon(006F6018) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(006F6518) != exmon(006F5F18) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(006F6518) != exmon(006F5F18) htmldoc.c:5715: Test failed: mon(006F6518) != exmon(006F5F18) === W7PROX64 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00708F30) != exmon(00708670) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00708F30) != exmon(00708670) htmldoc.c:5715: Test failed: mon(00708F30) != exmon(00708670) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00708C30) != exmon(007081B0) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00708C30) != exmon(007081B0) htmldoc.c:5715: Test failed: mon(00708C30) != exmon(007081B0) === WXPX64 (64 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(0000000000297C90) != exmon(000000000027FD00) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(0000000000297C90) != exmon(000000000027FD00) htmldoc.c:5715: Test failed: mon(0000000000297C90) != exmon(000000000027FD00) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00000000002D1AC0) != exmon(00000000002FC160) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00000000002D1AC0) != exmon(00000000002FC160) htmldoc.c:5715: Test failed: mon(00000000002D1AC0) != exmon(00000000002FC160) === WVISTAX64 (64 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(000000000089DD50) != exmon(0000000000823490) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(000000000089DD50) != exmon(0000000000823490) htmldoc.c:5715: Test failed: mon(000000000089DD50) != exmon(0000000000823490) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(000000000089E1D0) != exmon(0000000000823A90) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(000000000089E1D0) != exmon(0000000000823A90) htmldoc.c:5715: Test failed: mon(000000000089E1D0) != exmon(0000000000823A90) === W7PROX64 (64 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00000000007621D0) != exmon(0000000000761750) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00000000007621D0) != exmon(0000000000761750) htmldoc.c:5715: Test failed: mon(00000000007621D0) != exmon(0000000000761750) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00000000046C9830) != exmon(0000000000761C50) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00000000046C9830) != exmon(0000000000761C50) htmldoc.c:5715: Test failed: mon(00000000046C9830) != exmon(0000000000761C50)

2 1

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)
by John Chadwick Aug. 17, 2013

Aug. 17, 2013

Nikolay, does this patch look good to you? I was advised on #winehackers to get some acknowledgement that the patch is OK. Hopefully doing so can get things moving along.

2 1

open bugs / multi thread / recommendation on new system
by Damian Ivanov Aug. 17, 2013

Aug. 17, 2013

Hi guys, As you have a track of open bugs: 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? 2) FX 8320 or intel same price class CPU? As the AMD has far inferior single thread performance but far superior multi thread performance - does wine run a win32 single thread app as multi thread? does wine make use of multithread in general? Thanks in advance :) Damian

1 0

Re: [PATCH 4/6] oleaut32: TKIND_ALIAS improvements
by Piotr Caban Aug. 17, 2013

Aug. 17, 2013

On 08/16/13 21:40, Andrew Eikum wrote: > @@ -8502,7 +8502,7 @@ static HRESULT WINAPI ICreateTypeLib2_fnCreateTypeInfo(ICreateTypeLib2 *iface, > info->cbSizeInstance = 2; > break; > case TKIND_ALIAS: > - info->cbSizeInstance = -0x75; > + info->cbSizeInstance = 4; > break; > default: > FIXME("unrecognized typekind %d\n", info->typekind); > cbSizeInstance and cbAligment value depends on alias type. As long as alias type is not set cbSizeInstance stores some strange values (-0x75 is matching what one of native versions of dll stores there). Both of these values should be set in SetTypeDescAlias function.

1 0

Re: imm32/tests: Fix a trailing '\n' in an ok() call.
by Qian Hong Aug. 17, 2013

Aug. 17, 2013

> - ok(ic != NULL, "ImmLockIMC failed\n!"); > + ok(ic != NULL, "ImmLockIMC failed!\n"); Oh, good catch... Thanks! -- Regards, Qian Hong - http://www.winehq.org

1 0

Re: Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26722 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [website] Added templates/zh-cn/cvs.template translation
by Frédéric Delanoy Aug. 16, 2013

Aug. 16, 2013

On Fri, Aug 16, 2013 at 8:13 AM, xulixin <xulixin1990(a)gmail.com> wrote: > From 860262aed3d58f42012e6dd5264eb29bd29deffb Mon Sep 17 00:00:00 2001 > From: xulixin <xulixin1990(a)gmail.com> > Date: Fri, 16 Aug 2013 13:56:36 +0800 > Subject: add templates/zh-cn/cvs.template > > --- > templates/zh-cn/cvs.template | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/templates/zh-cn/cvs.template b/templates/zh-cn/cvs.template > index ba10a25..a9bc5d1 100644 > --- a/templates/zh-cn/cvs.template > +++ b/templates/zh-cn/cvs.template > @@ -13,9 +13,9 @@ > > <h1 id="sourcetree">通过 Web 方式浏览源码树</h1> > > -<p>The source code of the entire Wine tree is (<a > href="http://lxr.linux.no/">LXR</a>-based) > - cross-referenced and available for browsing, including a search engine. > - This cross-references source is based on the snapshot-releases and is > made available at:</p> > +<p>Wine tree的源码 (<a href="http://lxr.linux.no/">LXR</a>-based) > + 是相互参照且可供浏览的，包括一个搜索引擎。 > + 这交叉参考的源码是基于snapshot-releases版本，可从下面网站获得：</p> > <ul> > <li><a href="http://source.winehq.org/">source.winehq.org</a></li> > </ul> Hi, the real name is required when sending patches. Also, lxr.linux.no isn't used anymore, so the original file would need to be updated beforehand. -- Frédéric Delanoy

3 5

Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.
by Alexandre Julliard Aug. 16, 2013

Aug. 16, 2013

Kai Tietz <ktietz70(a)googlemail.com> writes: > diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c > index 44802b3..3b9e3c7 100644 > --- a/dlls/msvcrt/dir.c > +++ b/dlls/msvcrt/dir.c > @@ -365,14 +365,25 @@ int CDECL MSVCRT__chdrive(int newdrive) > { > WCHAR buffer[] = {'A', ':', 0}; > > + if (newdrive < 1 || newdrive > 31) > + { > + *MSVCRT___doserrno () = ERROR_INVALID_DRIVE; > + *MSVCRT__errno () = MSVCRT_EACCES; > + return -1; > + } > buffer[0] += newdrive - 1; > - if (!SetCurrentDirectoryW( buffer )) > + > + _lock (_ENV_LOCK); > + > + if (!SetCurrentDirectoryW (buffer)) > { > - msvcrt_set_errno(GetLastError()); > - if (newdrive <= 0) > - *MSVCRT__errno() = MSVCRT_EACCES; > + msvcrt_set_errno (GetLastError ()); > + _unlock (_ENV_LOCK); > return -1; > } > + > + _unlock (_ENV_LOCK); > + > return 0; > } Please add test cases at least for the error values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: empty APC queue before starting an application
by Alexandre Julliard Aug. 16, 2013

Aug. 16, 2013

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > --- > dlls/ntdll/loader.c | 3 +++ > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/sync.c | 16 ++++++++++++++++ > 3 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index b3abad0..1eaa123 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -2747,6 +2747,9 @@ void WINAPI LdrInitializeThunk( void *kernel_start, ULONG_PTR unknown2, > > virtual_release_address_space(); > virtual_clear_thread_stack(); > + > + NtTestAlert(); > + > wine_switch_to_stack( start_process, kernel_start, NtCurrentTeb()->Tib.StackBase ); This would have to run on the thread stack. Also please try to add some tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [website] Update git URL
by Michael Stefaniuc Aug. 16, 2013

Aug. 16, 2013

On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: > --- > templates/en/cvs.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/en/cvs.template b/templates/en/cvs.template > index 202cf60..300b9e4 100644 > --- a/templates/en/cvs.template > +++ b/templates/en/cvs.template > @@ -3,9 +3,9 @@ > > <h1 class="title">The Wine CVS Tree</h1> Schouldn't the title change too? And nowadays people know what git is and that's kinda the default SCM that people expect. > > -<p><strong>Note: We have switched development from CVS to <a href="http://git.or.cz">Git</a>. > +<p><strong>Note: We have switched development from CVS to <a href="http://git-scm.com/">Git</a>. > Wine can no longer be downloaded via CVS. > - Instructions for using the <a href="{$root}/site/git">Wine Git tree</a> > + Instructions for using the Wine Git tree > can be found on the <a href="http://wiki.winehq.org/GitWine">GitWine</a> > page on the <a href="http://wiki.winehq.org">Wine Wiki</a>.</strong></p> bye michael

2 1

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.
by Alexandre Julliard Aug. 16, 2013

Aug. 16, 2013

Kai Tietz <ktietz70(a)googlemail.com> writes: > Due line wrap, I sent patch as attachment. > > Kai > > From 3fcedb770626535b56a789467951a4c9be5f08dc Mon Sep 17 00:00:00 2001 > From: Kai Tietz <ktietz70(a)googlemail.com> > Date: Thu, 8 Aug 2013 12:29:33 +0200 > Subject: [PATCH 01/11] widl: New option --rt for enabling rt's specific > language extensions. > > --- > tools/widl/widl.c | 6 ++++++ > tools/widl/widl.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Please update the usage message and the manpage accordingly. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] apphelp: Add definitions
by Dmitry Timoshkov Aug. 16, 2013

Aug. 16, 2013

Mislav Blazevic <krofnica996(a)gmail.com> wrote: > --- > dlls/apphelp/apphelp.c | 10 +- > dlls/apphelp/apphelp.h | 272 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 273 insertions(+), 9 deletions(-) > create mode 100644 dlls/apphelp/apphelp.h Where all of this comes from? Is there an application that calls apphelp APIs and doesn't work because of failures? How are you testing your implementation? -- Dmitry.

3 6

Re: comsvcs: Add dll comsvcs (resend)
by André Hentschel Aug. 16, 2013

Aug. 16, 2013

Am 16.08.2013 12:39, schrieb Alistair Leslie-Hughes: > Hi, > > > Changelog: > comsvcs: Add dll comsvcs > > > Best Regards > Alistair Leslie-Hughes you missed the configure.ac part?

1 0

Re: [3/3] ntdll/tests: Add a bunch of overlapped IO tests for files.
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26708 Your paranoid android. === WXPX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === WVISTAX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1884: Test failed: expected STATUS_SUCCESS, got 0 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1903: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === W7PROX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === TEST64_W7SP1 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1884: Test failed: expected STATUS_SUCCESS, got 0 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1903: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3

2 1

Re: [2/3] ntdll/tests: Use official path for temporary files instead of current directory.
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26707 Your paranoid android. === WXPX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === WVISTAX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === W7PROX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === TEST64_W7SP1 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3

1 0

Re: [3/3] ntdll: Implement compatible typelib section
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26698 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout === WXPPROSP2 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WXPX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W2K3R2SESP2 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WVISTAX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W7PROX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === TEST64_W7SP1 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WXPX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WVISTAX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W7PROX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === TEST64_W7SP1 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043

1 0

Re: [2/3] ntdll: Added support for all typelib section attributes
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26697 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout === WXPPROSP2 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WXPX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W2K3R2SESP2 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WVISTAX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W2K8SE (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W7PROX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === TEST64_W7SP1 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WXPX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === WVISTAX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === W7PROX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === TEST64_W7SP1 (64 bit actctx) === actctx.c:1357: Test failed: got 409

1 0

Re: [1/3] kernel32: Some tests for typelib sections
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26696 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout

1 0

Re: mscoree: Redirect .NET 1.0 to .NET 2.0
by Alexandre Julliard Aug. 15, 2013

Aug. 15, 2013

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > mscoree: Redirect .NET 1.0 to .NET 2.0 It doesn't work: ../../../tools/runtest -q -P wine -M mscoree.dll -T ../../.. -p mscoree_test.exe.so mscoree.c && touch mscoree.ok mscoree.c:179: Test failed: version is L"v1.1.4322" , expected L"v2.0.50727" mscoree.c:187: Test failed: GetRequestedRuntimeInfo returned 80131700 mscoree.c:188: Test failed: version is L"" , expected L"v2.0.50727" make: *** [mscoree.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: configure.ac: allow disabling winemac.drv (try 2)
by Alexandre Julliard Aug. 15, 2013

Aug. 15, 2013

Austin English <austinenglish(a)gmail.com> writes: > try 2: don't unconditionally disable ApplicationServices.h > > Tested on 10.7 > diff --git a/configure.ac b/configure.ac > index 0e3df61..5e1fe10 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -70,6 +70,7 @@ AC_ARG_WITH(pthread, AS_HELP_STRING([--without-pthread],[do not use the pthrea > AC_ARG_WITH(sane, AS_HELP_STRING([--without-sane],[do not use SANE (scanner support)])) > AC_ARG_WITH(tiff, AS_HELP_STRING([--without-tiff],[do not use TIFF])) > AC_ARG_WITH(v4l, AS_HELP_STRING([--without-v4l],[do not use v4l1 (v4l support)])) > +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build native Mac (Cocoa) driver])) It should be --disable-winemac.drv, and it should work fine already, same as with any other dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mscoree: Attempt to load the assembly from the application directory
by Vincent Povirk Aug. 15, 2013

Aug. 15, 2013

This seems suspicious to me. You appear to be taking the namespace of the class and assuming it's an assembly name. Is there really no other information in the registry that could be used to identify the assembly?

3 4

Re: msvcrt: add support for _chsize_s
by Ken Sharp Aug. 14, 2013

Aug. 14, 2013

On 14/08/13 20:08, morphiend wrote: > -@ stub _chsize_s > +@ cdecl _chsize_s(long int64) msvcrt._chsize > +#@ stub _chsize_s Oops..

1 0

Re: mscoree: Redirect .NET 1.0 to .NET 2.0
by Vincent Povirk Aug. 14, 2013

Aug. 14, 2013

Looks good, thanks.

1 0

Possibility of adding a new patch status
by Hugh McMaster Aug. 14, 2013

Aug. 14, 2013

Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked at yet, there's still hope...". This is ideal for new patches submitted within that 24-hour commit cycle. But I'm finding it difficult to follow patches that remain with a status of 'New' for longer than the 24-hour patch cycle. Obviously, on the weekend, patches are held over till Monday, so a longer lead-time is expected. During weekdays, however, it is unclear what is happening with some patches. This, ultimately, raises the question of timeliness. Has the patch been looked at? If it has, the status often describes what action was taken - committed, rejected, superseded, etc. This is fine, but some patches remain with a status of 'New'. Experience has told me that patches remaining with a status of 'New' are incorrect in some way. But this is not always the case. If the patch is incorrect, but close to being accepted, the patch's status should reflect this, by changing to something like "Revision needed". Of course, the "Rejected" status is also appropriate, depending on the severity of coding error. Also, there are likely to be many times when the maintainer has not had time to evaluate some patches. This means the patch is not new (i.e. recently submitted), but is awaiting review. Once again, I believe the patch status should reflect this situation. The status could be "Not yet reviewed". In summary, the 'New' status should be reserved for patches that are actually new. Just some thoughts.

3 7

Re: gdiplus: Only clip strings if rectangle width and height are positive.
by Dmitry Timoshkov Aug. 14, 2013

Aug. 14, 2013

Vincent Povirk <madewokherd(a)gmail.com> wrote: > if (!(format_flags & StringFormatFlagsNoClip) && > - scaled_rect.Width != 1 << 23 && scaled_rect.Height != 1 << 23) > + scaled_rect.Width != 1 << 23 && scaled_rect.Height != 1 << 23 && > + rect->Width > 0.0 && rect->Height > 0.0) > { > /* FIXME: If only the width or only the height is 0, we should probably still clip */ > rgn = CreatePolygonRgn(corners, 4, ALTERNATE); Probably FIXME should be removed then. -- Dmitry.

2 1

wine-bugs change?
by Thomas Spear Aug. 13, 2013

Aug. 13, 2013

Hi all, I've been subscribed to the lists for several years now, archiving all of the conversations in case a situation ever arises where a backup copy is needed. I've had a filter setup in gmail for wine-bugs that has worked perfectly fine for a long time now, but over the last couple of days, I've noticed that all emails sent to or from wine-bugs are now being directed to my inbox in addition to the folder I have the filter setup for. I'm planning on contacting Google as well, but thought I should cover all of the bases by asking here if there have been any changes made to that list specifically that might have caused the filter to not work. I've tried editing the filter so that I can see what messages it searches for, and it appears to be working properly, in that it appears to locate the emails I have the filter setup for, including those that are currently in both my inbox and the folder I specified to have them moved to, so it could be that there is an issue with the "Skip Inbox" setting of the filter, specifically. But again, I thought I would ask (because Google will and I'll need to have an answer for them) what changes, if any, have been made recently on the mailman side of things. Thank you, Thomas

4 6

Wine Gecko repo
by Jacek Caban Aug. 13, 2013

Aug. 13, 2013

Hi, A few months ago, SourceForge did some deep changes in their Git (and not only) repo hosting. While doing it, the location of repos has changed (which is extremely stupid, if you ask me). The problem is that while doing the update, they also switched to their own Web interface for git. And this shiny new interface doesn't work at all for Wine Gecko repo (wine-gecko.git probably too big and complicated). See [1], it claims to be analyzing the repo, but it has been like that since the switch was done. I contacted them [2] and they are aware of the problem, but it's still not fixed. I already got some questions about outdated sources. Also, our Wiki points to this Git in a few places. I never updated those links because I was waiting for the new repo to work. I think it's time to move the repo. The question is, where should it go? - Github seems to be the choice for most project currently and it's already used by Wine Mono. - Reconsider source.winehq.org. This was not chosen due to account management overhead, but that's the only way to avoid problems similar to recent Sourceforge one (Github nor anyone else is going to give us any guarantees) - Other ideas? I'd appreciate opinions. Thanks, Jacek [1] https://sourceforge.net/p/wine/wine-gecko/ci/master/tree/ [2] https://sourceforge.net/p/forge/site-support/4299/

3 2

Process for reporting security bugs?
by achurch+wine-devel＠achurch.org Aug. 13, 2013

Aug. 13, 2013

[Please cc: me on any replies since I'm not subscribed to the list.] Hi, Is there a specific process for reporting security-related bugs in Wine? I've looked through winehq.org but haven't found any mention of such; I just wanted to make sure I haven't overlooked anything before posting the bug in a publicly visible manner. Thanks, --Andrew Church achurch+wine-devel(a)achurch.org http://achurch.org/

3 5

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events
by Hugh McMaster Aug. 13, 2013

Aug. 13, 2013

On Monday, 12 August 2013, Ruslan Kabatsayev wrote: >I've tried applying your both patches, and it appears that Ctrl+C at >cmd prompt still closes cmd, although pressing it while "dir /s /w" is running works as expected. Hi Ruslan, I've just tested the Ctrl-C patches on the most recent version of Wine available from the Git repository. After patching, compiling and installing, I found no problems with either of the patches as you described. Ctrl-C did nothing when cmd.exe was open and no command was running. To be clear, I was running cmd.exe via wineconsole in Linux Mint 14: 1. wineconsole cmd.exe 2. Press Ctrl-C --> cmd.exe remains open. But if you run cmd.exe via wine itself, the terminal will terminate cmd.exe when Ctrl-C is pressed. 1. wine cmd.exe 2. Press Ctrl-C --> returned to terminal prompt. I hope this helps. If the patch still doesn't seem to work correctly, please let me know what operating system you use, and I'll run further tests. Hugh

2 2

Re: Compiler warnings on Debian Sid kfreebsd-i386
by Ken Sharp Aug. 12, 2013

Aug. 12, 2013

On 12/08/13 20:15, Mislav Blazevic wrote: > It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. It does seem that way. :-) Or maybe :-(

1 0

Re: Compiler warnings on Debian Sid kfreebsd-i386
by Mislav Blazevic Aug. 12, 2013

Aug. 12, 2013

It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. On Mon, Aug 12, 2013 at 9:15 PM, Mislav Blazevic <krofnica996(a)gmail.com>wrote: > It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. > > > > On Mon, Aug 12, 2013 at 9:11 PM, Ken Sharp <kennybobs(a)o2.co.uk> wrote: > >> Following my previous e-mail (http://www.winehq.org/** >> pipermail/wine-devel/2013-**August/100754.html<http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html>) >> I have since moved from Wheezy to Sid to work around a Debian bug. >> >> libxml2 has been updated (2.8.0+dfsg1-7+nmu1 --> 2.9.1+dfsg1-3) as a >> result and introduced some new compiler warnings: >> >> /home/ken/wine-git/dlls/**msxml3/node.c: In function >> ‘htmldtd_dumpcontent’: >> /home/ken/wine-git/dlls/**msxml3/node.c:908:9: warning: passing argument >> 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled >> by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->ExternalID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c:912:13: warning: passing >> argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type >> [enabled by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->SystemID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c:918:9: warning: passing argument >> 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled >> by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->SystemID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c: In function >> ‘node_transform_node’: >> /home/ken/wine-git/dlls/**msxml3/node.c:974:21: warning: passing >> argument 1 of ‘xmlBufferContent’ from incompatible pointer type [enabled by >> default] >> content = xmlBufferContent(output->**buffer); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:734:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferContent (const xmlBufferPtr buf); >> ^ >> >> Hopefully these mean something to someone. >> >> >> >

1 0

Compiler warnings on Debian Sid kfreebsd-i386
by Ken Sharp Aug. 12, 2013

Aug. 12, 2013

Following my previous e-mail (http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html) I have since moved from Wheezy to Sid to work around a Debian bug. libxml2 has been updated (2.8.0+dfsg1-7+nmu1 --> 2.9.1+dfsg1-3) as a result and introduced some new compiler warnings: /home/ken/wine-git/dlls/msxml3/node.c: In function ‘htmldtd_dumpcontent’: /home/ken/wine-git/dlls/msxml3/node.c:908:9: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->ExternalID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c:912:13: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->SystemID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c:918:9: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->SystemID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c: In function ‘node_transform_node’: /home/ken/wine-git/dlls/msxml3/node.c:974:21: warning: passing argument 1 of ‘xmlBufferContent’ from incompatible pointer type [enabled by default] content = xmlBufferContent(output->buffer); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:734:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferContent (const xmlBufferPtr buf); ^ Hopefully these mean something to someone.

1 0

Question about implementing application compatibility
by Mislav Blazevic Aug. 12, 2013

Aug. 12, 2013

For past two weeks I've been implementing apphelp.dll. I got that one working and moved onto kernel32 part of magic. According to various papers and blogs it seems that windows logs all exes and dlls ever executed in registry[1] and uses it as cache to lookup if binary needs to be shimmed or patched (if file isn't found, hard lookup of shim database is done) It is loaded on boot and saved back to registry on shutdown. This is awfully overcomplicated (plus I do not know how to make such a "global" variable in wine) so I was wondering is it OK to implement this differently than windows does it. It would be simpler to control app compat with environmental variable. It would mean that Base*Appcompat* kernel32 APIs would remain unimplemented but as far as I know, no application uses them anyway, other than windows internally. What do you think? [1] https://github.com/mandiant/ShimCacheParser

2 1

Re: ntdll/tests: test FileDispositionInformation file class
by Marvin Aug. 12, 2013

Aug. 12, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26661 Your paranoid android. === WXPX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === WVISTAX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === W7PROX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === TEST64_W7SP1 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002)

1 0

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events
by Ruslan Kabatsayev Aug. 11, 2013

Aug. 11, 2013

Hi, On Sun, Aug 11, 2013 at 12:33 PM, Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > Jason Edmeades and I have developed a patch that handles Ctrl-C and Ctrl-Break events in wineconsole's cmd.exe. > > The patch supports interactive mode, batch contexts and both the cmd /c and cmd /k modes, meaning that pressing Ctrl-C no longer closes cmd.exe. I've tried applying your both patches, and it appears that Ctrl+C at cmd prompt still closes cmd, although pressing it while "dir /s /w" is running works as expected. > > For loops, commands such as 'dir /s /w' and other such commands can be stopped. Batch scripts prompt the user whether the current batch execution should end. > > --- > programs/cmd/builtins.c | 95 ++++++++++++++++++++++++++++++++++++++++++----- > programs/cmd/cmd.rc | 2 + > programs/cmd/wcmd.h | 7 ++++ > programs/cmd/wcmdmain.c | 65 +++++++++++++++++++++++++++++++- > 4 files changed, 158 insertions(+), 11 deletions(-) > > > Regards, Ruslan

1 0

Compiler warnings on Debian kfreebsd-i386
by Ken Sharp Aug. 11, 2013

Aug. 11, 2013

Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/jscript/parser.y: conflicts: 1 shift/reduce, 18 reduce/reduce /home/ken/wine-git/dlls/msi/sql.y: conflicts: 1 reduce/reduce /home/ken/wine-git/dlls/ntdll/directory.c: In function ‘wine_getdirentries’: /home/ken/wine-git/dlls/ntdll/directory.c:1710:5: warning: passing argument 4 of ‘getdirentries’ from incompatible pointer type [enabled by default] In file included from /home/ken/wine-git/dlls/ntdll/directory.c:29:0: /usr/include/dirent.h:313:18: note: expected ‘__off_t * __restrict__’ but argument is of type ‘long int *’ /home/ken/wine-git/dlls/vbscript/parser.y: conflicts: 6 shift/reduce /home/ken/wine-git/programs/winedbg/dbg.y: conflicts: 1 shift/reduce, 1 reduce/reduce /home/ken/wine-git/programs/winedbg/dbg.y: conflicts: 1 shift/reduce, 1 reduce/reduce

2 5

Is it a little bug in wbemprox?
by Jing Li Aug. 10, 2013

Aug. 10, 2013

Hi, When I ran a simple win32 program just via WMI with query of "SELECT * from Win32_Directory", wine1.6 crashed. And when I checked the related code I found that the function of "static UINT seed_dirs( struct dirstack *dirstack, const struct expr *cond, WCHAR root, UINT *count )", in dlls/wbemprox/builtin.c:1086, accessing cond's member without checking if it's NULL! Unfortunately a NULL is passed to it. That's why my program crashed. It's a bug, right?

2 1

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.
by André Hentschel Aug. 9, 2013

Aug. 9, 2013

Am 08.08.2013 17:51, schrieb Kai Tietz: > Hi, > > this patch adds new --rt option to widl. By it you can control, if > RT's IDL-language-extension(?s) getting active. > This initial patch just adds the option-scanning and the global > flag-variable to widl. > > Ok for apply? I'd say no, you are adding dead code, so you might want to merge it with 2/11 to avoid that.

3 2

Re: [2/2] wineserver: perform access check when creating event objects (try 2)
by Andrew Cook Aug. 9, 2013

Aug. 9, 2013

Actually ignore this patch, the problem was introduced by 92db6d2c back in 2007, server: Don't do access checks on the security descriptors of newly created objects which fixes sync.c:363 "CreateEventW with blank sd failed" i'll need to take another look at this, calling CreateEventEx with generic flags fails to correctly set permissions, the patch as it stands though will likely cause regressions. On 02/08/13 21:58, Andrew Cook wrote: > --- > dlls/ntdll/tests/om.c | 4 ++-- > server/event.c | 5 +---- > 2 files changed, 3 insertions(+), 6 deletions(-) > >

1 0

Re: configure.ac: allow disabling winemac.drv
by Ken Thomases Aug. 8, 2013

Aug. 8, 2013

On Aug 8, 2013, at 5:56 PM, Austin English wrote: > +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build native Mac (Cocoa) driver]), > + [if test "x$withval" = "xno"; then ac_cv_header_ApplicationServices_ApplicationServices_h=no; fi]) A switch to disable the Mac driver is fine with me, but you can't pretend that the ApplicationServices framework header isn't present. There are other places within Wine which check that. http://source.winehq.org/source/dlls/windowscodecs/icnsformat.c#L24 http://source.winehq.org/source/dlls/winspool.drv/info.c#L48 -Ken

1 0

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.
by André Hentschel Aug. 8, 2013

Aug. 8, 2013

Am 08.08.2013 17:57, schrieb Kai Tietz: > - if (! is_attr(attrs, ATTR_PUBLIC)) > + if (! is_attr(attrs, ATTR_PUBLIC) && ! is_attr (attrs, ATTR_HIDDEN)) style issue: space after !

2 1

Re: [PATCH 09/11] widl: Handle LLP64 target same as LP64 one.
by André Hentschel Aug. 8, 2013

Aug. 8, 2013

Am 08.08.2013 18:07, schrieb Kai Tietz: > Hi, > > this thing here puzzles me most. I reject this patch, but would like > to get here some discussion to find the actual intended meaning of > this xstrtoul function. Then you should remove it from the patchset and send it as RFC to wine-devel

1 0

Re: Synchronization-patches of widl
by André Hentschel Aug. 8, 2013

Aug. 8, 2013

Am 08.08.2013 10:56, schrieb Kai Tietz: > All these changes were necessary to support the VLC-people to begin > with their WinRT port. By this we began on mingw-w64 to improve - > thanks to Jacek - our IDL-generated header-sources. So you are on a good way with WinRT, nice. What about Windows RT, was there already some ARM work? > A general note I would like to make about the use of sizeof(void*) in > widl to make out what type-library-variant to be choosen. That seems > to be a bit wacky variant, as it makes widl non-useable as cross-tool > on host with different pointer-size. isn't that controled by command line arguments?

1 0

winetestbot question
by Stefan Leichter Aug. 8, 2013

Aug. 8, 2013

Hello, i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc runtime 2008. The other 64 bit VMs have the runtime installed. Because of the missing runtime each patch for the unit tests of the dlls msvcr90 and msvcp90 is marked as "Failed" at http://source.winehq.org/patches -- Stefan

2 1

re: msvcrt: strncpy doesn't compliant C standard (try 3)
by Dan Kegel Aug. 8, 2013

Aug. 8, 2013

Minor problem: +static void test_strncpy(void) +{ + size_t len = 10; + char *ret; + char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems to want to build in c89 compilers: http://www.winehq.org/pipermail/wine-cvs/2011-April/076721.html Try using a #define with a more unique name for the length instead, or better yet, replace len=10 with len=sizeof(dst)-1 or something. Larger problem: ret = strncpy(dst, not_null_less, len); This is ill-defined. You're copying 10 bytes from a 5 byte buffer. Don't do that. Also, passing a not-null-terminated string in as a special test case doesn't seem interesting... just pass in the longer null-terminated string, and specify a shorter length. Fewer test strings needed, easier to read code. Please run 'make check', and test using http://testbot.winehq.org, before submitting patches.

2 1

Re: [PATCH 1/1] msvcrt: Set ?: environment variable in _(w)chdir functions.
by Marvin Aug. 8, 2013

Aug. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26639 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msvcrt: strncpy doesn't compliant C standard (try 3)
by Marvin Aug. 7, 2013

Aug. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26638 Your paranoid android. === W2KPROSP4 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WXPPROSP2 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WXPX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === W2K3R2SESP2 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WVISTAX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === W2K8SE (32 bit string) === string.c:2585: Test failed: dst != 012345 === W7PROX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === TEST64_W7SP1 (32 bit string) === string.c:2585: Test failed: dst != 012345

1 0

Re: msvcp90/tests: Add dynamically loaded functions for ARM
by Marvin Aug. 7, 2013

Aug. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26637 Your paranoid android. === WXPX64 (32 bit misc) === No test summary line found === WXPX64 (32 bit ios) === No test summary line found

1 0

Re: Request to add wow64 keyword to bugzilla
by Ken Sharp Aug. 7, 2013

Aug. 7, 2013

+1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: > On Wed, 07 Aug 2013 14:23:53 +0100 > Ken Sharp <kennybobs(a)o2.co.uk> wrote: > > >> Would I be right in assuming you would like to see bugs in 32-bit >> applications that are only present in a wow64 WINEPREFIX? Are there many? > > Yes. As to how many there are, I've been able to find 7 by doing searches of summaries/comments for things like "wow64" and "64" and then reading the bugs to see if they fit, but since people have such wildly varying ways of phrasing things, I don't know if that's all of them. I have seen it often enough on the forum that I now routinely tell 64 bit users to try a 32 bit wineprefix and have added instructions on how to create one to the FAQ. That's why I'd like an easier way to track these bugs. I see. A lot of people say this over and over again. +1 from me for a wow64 keyword. They may even be fairly easy to solve (picking the right paths / registry entries). > > As to keyword usage, some of those bugs were tagged with the win64 keyword, some weren't. I know there is also a win32 keyword, and perhaps that is meant to be used for the kinds of bugs I am looking for, but if so, that is not at all clear from the keyword definition, and it is not how people are using the keywords. > There's no win32 keyword?

3 2

Re: msvcp90/tests: Skip tests on missing functions
by Piotr Caban Aug. 7, 2013

Aug. 7, 2013

On 08/06/13 23:00, André Hentschel wrote: > @@ -749,6 +749,13 @@ static BOOL init(void) > > SET(p_basic_istream_char_read_uint64, > "??5?$basic_istream(a)DU?$char_traits(a)D@std@@@std@@QAEAAV01(a)AA_K@Z"); > + > + if (!p_basic_istream_char_read_uint64) > + { > + skip("_basic_istream_char_read_uint64 not found, skipping tests\n"); > + return FALSE; > + } Why are you skipping the tests instead of properly initializing functions pointers on ARM?

2 1

Request to add wow64 keyword to bugzilla
by Rosanne DiMesio Aug. 7, 2013

Aug. 7, 2013

Can wow64 be added as a keyword to bugzilla? I know we already have win64 as a keyword, but that's being used for both 64 bit apps and 32 bit apps in a 64 bit wineprefix. I'm interested in being able to track the latter, as it's hitting increasing numbers of users. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: [PATCH] typo fixes (https://github.com/vlajos/misspell_fixer)
by Frédéric Delanoy Aug. 7, 2013

Aug. 7, 2013

On Mon, Aug 5, 2013 at 9:41 PM, Veres Lajos <vlajos(a)gmail.com> wrote: > > Signed-off-by: Veres Lajos <vlajos(a)gmail.com> > --- > dlls/comctl32/tests/trackbar.c | 2 +- > documentation/ChangeLog.ALPHA | 80 ++++++++++++++++++++-------------------- > documentation/ChangeLog.BETA | 44 +++++++++++----------- > documentation/ChangeLog.OLD | 24 ++++++------ > tools/winebuild/utils.c | 2 +- > 5 files changed, 76 insertions(+), 76 deletions(-) The "documentation/ChangeLog.*" files have been removed so the patch won't apply. Frédéric Delanoy

1 0

Re: msvcrt: strncpy doesn't compliant C standard (try 2)
by Frédéric Delanoy Aug. 7, 2013

Aug. 7, 2013

On Tue, Aug 6, 2013 at 10:44 PM, Álvaro Nieto <alvaro.nieto(a)gmail.com> wrote: > Remove strlen and implement some tests You should probably add tests for when the source string is not null-terminated. Frédéric Delanoy

1 0

Re: msvcp90/tests: Skip tests on missing functions
by Marvin Aug. 6, 2013

Aug. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26628 Your paranoid android. === WXPX64 (32 bit misc) === No test summary line found === WXPX64 (32 bit ios) === No test summary line found

1 0

Re: msvcr90/tests: Skip when _type_info_name_internal_method is not found
by Marvin Aug. 6, 2013

Aug. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26627 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: ws2_32/tests: Fix a comment
by Juan Lang Aug. 6, 2013

Aug. 6, 2013

Hi Andre, - /* this is a io heavy test, do it at the end so the kernel doesn't start dropping packets */ + /* this is a heavy io test, do it at the end so the kernel doesn't start dropping packets */ To my eyes, this isn't an improvement. A slight improvement might be "this is a io-heavy test", or "this is an io-heavy test", but I'm not sure it's enough of an improvement to bother. --Juan

1 0

Re: msvcrt: strncpy doesn't compliant C standard
by Nikolay Sivov Aug. 6, 2013

Aug. 6, 2013

On 8/6/2013 11:09, Álvaro Nieto wrote: > This patch solves [Bug 34211]. The implementation of strncpy function > doesn't compliant with C standard [1]. Also Microsoft Visual Studio > C/C++ compiler is ok with the standard [2]. > > Extract from msdn; > > "The strncpy function copies the initial count characters of strSource > to strDest and returns strDest. If count is less than or equal to the > length of strSource, a null character is not appended automatically to > the copied string. If count is greater than the length of strSource, > the destination string is padded with null characters up to length > count. The behavior of strncpy is undefined if the source and > destination strings overlap." > > [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/strncpy.html > [2] http://msdn.microsoft.com/en-us/library/vstudio/xdsywd25.aspx This needs tests.

1 0

Fwd: [AppDB] Submitted test data deleted
by Ken Sharp Aug. 5, 2013

Aug. 5, 2013

Deleting test results because the Wine version is old? What the Hell is the plan there? -------- Original Message -------- Subject: [AppDB] Submitted test data deleted Date: Mon, 05 Aug 2013 15:48:43 -0500 From: AppDB <appdb-noreply(a)winehq.org> Reply-To: AppDB <appdb-noreply(a)winehq.org> To: appdb-noreply(a)winehq.org Submitted test data deleted ------------------------------------------------------- The test report you submitted for 'Microsoft Access 2007' has been deleted. The action was performed by Joerg Schiermeier Reasons given Old wine - deprecated. Best regards. The AppDB team http://appdb.winehq.org/ If you don't want to receive any other e-mail, please change your preferences: http://appdb.winehq.org/preferences.php

1 0

wine mannual is wrong?
by 中川祥 Aug. 5, 2013

Aug. 5, 2013

I'm interpretering wine.man. I found it says"this requires X11 to run". But the newest ver. does not require X11,does it?

3 2

Draft: improve IMC/IMCC related functions
by Qian Hong Aug. 5, 2013

Aug. 5, 2013

Hello, This is a follow up of http://www.winehq.org/pipermail/wine-devel/2013-July/100459.html ( [PATCH] imm32: Fixed crashing in ImmGetIMCCSize. ) I believe the attached patchset is the correct fix for the Office crashing bug, how ever, I'm looking for a more graceful way to improve ImmCreateContext and other IMC functions, I appreciate to any feedback on the patches especially Patch 6/6. My tests show that Windows return a HGLOBAL hmem for ImmCreateIMCC() as the returned HIMCC, so it is easy to re-implement ImmCreateIMCC in a graceful way. However, Windows return a magic number for ImmCreateContext, (for instance, have a look at 000B01D9 in the test show in https://testbot.winehq.org/JobDetails.pl?Key=26619&log_207=1#k207) I have no idea how that magic number comes, while I understand there is no need to re-implement ImmCreateContext in the same way as Windows does, I'm still interesting in a more beautiful implementation like my ImmCreateIMCC reached, get rid of casting InputContextData to HIMC if possible. Thanks in advance for any suggestions! If there is no better way, I'll send this series to wine-patches. -- Regards, Qian Hong - http://www.winehq.org

1 0

Re: inputscope.idl: Imported from mingw-w64.
by Ken Sharp Aug. 5, 2013

Aug. 5, 2013

On 05/08/13 12:14, Jacek Caban wrote: > + * No warranty is given; refer to the file DISCLAIMER.PD within this package. It's a minor point but this may be a bit confusing given the file doesn't exist.

1 0

Re: msvcrt: invoke invalid_handler in _wcscpy_s
by Piotr Caban Aug. 5, 2013

Aug. 5, 2013

On 08/02/13 20:08, Daniel Lehman wrote: > + if(!MSVCRT_CHECK_PMT(wcDest)) > + { > + *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > + } The MSVCRT_CHECK_PMT macro sets the errno value. There's also MSVCRT_CHECK_PMT_ERR macro if you need to set different error.

1 0

po: Add English (Philippines) resource
by Ken Sharp Aug. 5, 2013

Aug. 5, 2013

Hi everyone, Would anyone mind looking at the attached patch? It adds the English (Philippines) resource by linking (or copying) the English (US) resource. See http://bugs.winehq.org/show_bug.cgi?id=23124 Actually, the attached version links to fr.po (French) to make testing much easier. The final won't do that. It's explained in the bug. I have tested this successfully in Linux only. I wanted to test others but: Cygwin 1.7.22: creates its own "symlink" but no translations are built at all. Compilation is basically broken. PC-BSD 9.1: complains about gettext although the config.log seems to complain about gm4. I gave up. OpenIndiana: can't seem to find its own packages. Gave up. Debian kFreeBSD: all sorts of problems in VBox. Might try again later. So clearly I've had no luck on other platforms. If anyone else could quickly test it, that would be great! Thanks to Austin and François for the help thus far. Of course, all feedback welcome. TIA, Ken

2 3

Wiki RFC: Redirects, swarm tactics, etc.
by Kyle Auble Aug. 5, 2013

Aug. 5, 2013

So I've finished with pretty much all of the edits I had in mind for the wiki, but before I ride off into the sunset for a while, I wanted to toss out a few ideas. 1. Do we want some kind of guideline on redirects for the wiki? Some stable "interface" pages to the main site might be good, but beyond that, I think minimizing redirects makes sense in this use case. 2. There's still a lot of old/missing content on the wiki, and much of it requres a good sense of where the code is at. Also, it might be too overwhelming for one person to work in depth on more than a few pages at this point. I feel like a semi-coordinated swarm of editing might be the best bet for further improvements. I was picturing a table of all relevant pages, then people could adopt one or two to work on, then strike/delete a record once that page is finished. Any thoughts? 3. There are actually a few more fixes to the theme code at the head of my bitbucket repo (and also branches for 2 different Moinmoin upgrade paths). I'm cool with keeping the theme code for the near future; if and when we move it onto WineHQ's git server though, just let me know so I can note that I'm not upstream anymore. 4. Finally, spammers... they keep coming... and they're getting smarter. We can mostly stalemate them with the regex filter, but it blocks legit edits too sometimes (in very annoying fashion). In fact, I think there are a few of them that have learned to turn the filter against us by completely wiping pages with false positives so we can't revert the page. Are there any relatively easy things we could do to cut the spam? I don't know, but it's possible the newer version of Moinmoin has more potent anti-spam tools. -Kyle

5 5

help [Abount Sql2005 and WMI]
by Jing Li Aug. 4, 2013

Aug. 4, 2013

Hi, all: I have met a problem when installing sql2005, and it seems related to some WMI problems. As WMI has just been implemented in wine-1.6 ( right? ), I want to know in what degree it has been implemented.By the way is there anyone succeed in install of it? Thanks. Appreciate your kind help.

2 1

Vacation
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Folks, I'll be on vacation for the next 10 days, so you'll have to live without commits for a while... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [docs] wineusr: Assorted formatting & tagging fixes (try 2)
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -710,17 +714,18 @@ Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > choose between several edition modes: > <itemizedlist> > <listitem> > - <para> > - Emacs: the same keybindings as under > - emacs are available. For example, Ctrl-A > - will bring the cursor to the beginning > - of the edition line. See your emacs > - manual for the details of the commands. > - </para> > + <para> > + <literal>Emacs</literal>: the same keybindings as under > + <command>emacs</command> are available. For example, > + <keycombo><keycap>Ctrl</keycap><keycap>A</keycap></keycombo> > + will bring the cursor to the beginning > + of the edition line. See your <command>emacs</command> > + manual for the details of the commands. > + </para> Please avoid messing up the indentation. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: gdi32: Avoid a crash by loading AppKit before using Core Text if might use the Mac driver.
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Ken Thomases <ken(a)codeweavers.com> writes: > + /* If the Mac driver might be used, then load AppKit now before using the Core Text API. > + Otherwise, AppKit crashes on Mac OS X 10.7+ because CTFontDescriptor isn't toll-free > + bridged to NSCTFontDescriptor. That bridging is only set up if AppKit has been loaded > + when CTFontDescriptor is first used. */ > + /* @@ Wine registry key: HKCU\Software\Wine\Drivers */ > + if (!RegOpenKeyA(HKEY_CURRENT_USER, "Software\\Wine\\Drivers", &hkey)) > + { > + char buffer[MAX_PATH]; > + DWORD type, count = sizeof(buffer); > + > + if (!RegQueryValueExA(hkey, "Graphics", 0, &type, (LPBYTE) buffer, &count)) > + { > + char *name = buffer; > + > + usingMacDriver = FALSE; > + while (name) > + { > + char *next = strchr(name, ','); > + if (next) *next++ = 0; > + > + if (!strcmp(name, "mac")) > + { > + usingMacDriver = TRUE; > + break; > + } > + > + name = next; > + } > + } > + > + RegCloseKey(hkey); > + } That's ugly. freetype.c has no business knowing about the details of the graphics driver. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: riched20: Make ITextDocument stub reusable for ITextServices (try 4)
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Caibin Chen <tigersoldi(a)gmail.com> writes: > diff --git a/dlls/riched20/tomimpl.h b/dlls/riched20/tomimpl.h > new file mode 100644 > index 0000000..886c3a8 > --- /dev/null > +++ b/dlls/riched20/tomimpl.h > @@ -0,0 +1,59 @@ > +/* > + * RichEdit - TOM interfaces implementations > + * > + * Copyright 2013 by Caibin Chen > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __RICHOLE_H > +#define __RICHOLE_H > + > +#include <tom.h> > + > +#include "editstr.h" > + > +typedef struct ITextDocumentImpl ITextDocumentImpl; > +typedef struct ITextSelectionImpl ITextSelectionImpl; > + > +/* ITextDocument */ > + > +struct ITextDocumentImpl { > + ITextDocument ITextDocument_iface; > + IUnknown *outer_unk; > + ME_TextEditor *editor; > + ITextSelectionImpl *txtSel; > +}; You shouldn't need a new header either. Particularly since implementation details shouldn't be global. > +/** > + * Create an ITextDocumentImpl object, which acts as an inner object of COM aggression. I'm sure writing COM code can make you feel aggressive, but that's not the right term ;-) > + * > + * The ITextDocumentImpl object will delegate all of its IUnknown calls to the specified > + * {@code outer_unk}. > + * > + * @param outer_unk The outer objects that creates and delegates ITextDocument > + * method calls to the created ITextDocumentImpl. > + * @param editor The editor implementation. > + * > + * @return An ITextDocumentImpl object that should be destroyed with > + * {@code ITextDocumentImpl_destroy} > + */ Please don't use that sort of documentation markup. Besides, things like parameters and return should be obvious from the code, you shouldn't have to add documentation for this, especially not for internal functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: xmllite: Improve attribute value parsing
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +static void reader_normalize_space(xmlreader *reader, WCHAR *ptr) > +{ > + encoded_buffer *buffer = &reader->input->buffer->utf16; > + > + if (!is_wchar_space(*ptr)) return; > + > + if (*ptr == '\r' && *ptr == '\n') That's not going to happen very often... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] oleaut32: ERR on 32bit typelibs on 64bit
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Marcus Meissner <meissner(a)suse.de> writes: > Triggered by the Novell Groupwise installer currently, > from the ISBE64W.exe Installshield Helper program. > > The typelib is contained directly in ISBE64W.exe itself :/ > > Basically if we encounter this case the program will crash > anyway (but with random backtrace), so output an ERR(). That looks like it's just hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon
by Matteo Bruni Aug. 2, 2013

Aug. 2, 2013

2013/8/1 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > + vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) * sizeof(D3DXVECTOR3)); + if (!vertices) + { + TRACE("Not memory enough for vertex buffer\n"); + polygon->lpVtbl->Release(polygon); + return E_OUTOFMEMORY; + } + + hr = polygon->lpVtbl->LockVertexBuffer(polygon, D3DLOCK_DISCARD, (VOID **)&vertices); Why are you allocating memory and immediately dropping track of it? Recheck how ID3DXMesh::LockVertexBuffer works. Also I'm having a deja-vu here, this patch looks suspiciously similar (up to having this same issue) to one I've already reviewed in the past.

2 1

appwiz: Correct Wine Mono installer title in several languages
by Ken Sharp Aug. 2, 2013

Aug. 2, 2013

Hi Alexandre, http://source.winehq.org/patches/data/97460 should be correct but would I be right in assuming you would rather have the changes made along with the next string for each language?

2 4

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.
by Matteo Bruni Aug. 2, 2013

Aug. 2, 2013

2013/7/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/tests/shader.c | 308 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 308 insertions(+) > This is okay, but as a followup can you add some tests with mixed-type structs? Something like: struct { float f; int i; bool b; }; If you have already written tests of this kind, I'd like to know what does the compiler do in this case :)

2 6

Re: [1/2] ntdll: Implement NtQueryEvent
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Andrew Cook <ariscop(a)gmail.com> writes: > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index 10d6674..a44b880 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -7,6 +7,7 @@ C_SRCS = \ > directory.c \ > env.c \ > error.c \ > + event.c \ > exception.c \ > file.c \ > generated.c \ Please don't add a new file for just a couple of tests, merge this into an existing file. -- Alexandre Julliard julliard(a)winehq.org

1 0

jscript FTBFS in Cygwin 1.7.22
by Ken Sharp Aug. 2, 2013

Aug. 2, 2013

Probably better to post this here rather than the forums: http://forum.winehq.org/viewtopic.php?f=2&t=19501 "Not sure if this is a Wine bug (as usual) so I'd rather put this here than to open a new bug. On Cygwin 1.7.22 the compilation stops at jscript, apparently a conflict in the declaration of dtoa. $ make ccache cc -c -I/home/ken/wine-git/dlls/jscript -I. -I/home/ken/wine-git/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O0 -D_WIN32 -o jscript_main.o /home/ken/wine-git/dlls/jscript/jscript_main.c ccache cc -c -I/home/ken/wine-git/dlls/jscript -I. -I/home/ken/wine-git/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O0 -D_WIN32 -o lex.o /home/ken/wine-git/dlls/jscript/lex.c ccache cc -c -I/home/ken/wine-git/dlls/jscript -I. -I/home/ken/wine-git/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O0 -D_WIN32 -o number.o /home/ken/wine-git/dlls/jscript/number.c /home/ken/wine-git/dlls/jscript/number.c:57:20: error: conflicting types for ‘dtoa’ In file included from /home/ken/wine-git/include/wine/port.h:47:0, from /home/ken/wine-git/dlls/jscript/number.c:20: /usr/include/stdlib.h:161:35: note: previous declaration of ‘dtoa’ was here Makefile:199: recipe for target `number.o' failed make: *** [number.o] Error 1 dlls/jscript/number.c: static inline void dtoa(double d, WCHAR *buf, int size, int *dec_point) /usr/include/stdlib.h: char * _EXFUN(dtoa,(double, int, int, int *, int*, char**));"

1 0

Re: ntdll: Implement compatible FindActCtxSectionString() for window class section (try3)
by Alexandre Julliard Aug. 2, 2013

Aug. 2, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -1031,6 +1105,17 @@ static BOOL parse_window_class_elem(xmlbuf_t* xmlbuf, struct dll_redirect* dll) > > if (!(entity->u.class.name = xmlstrdupW(&content))) return FALSE; > > + /* each class entry needs index, data and string data */ > + acl->actctx->wndclass_section_len += sizeof(struct wndclass_index); > + acl->actctx->wndclass_section_len += sizeof(struct wndclass_redirect_data); > + /* original name is stored separately */ > + acl->actctx->wndclass_section_len += aligned_string_len((content.len+1)*sizeof(WCHAR)); > + /* versioned name and module name are stored one after another */ > + len = get_assembly_version(assembly, NULL) + content.len + 2 /* null terminator and '!' separator */; > + len += strlenW(dll->name) + 1; > + acl->actctx->wndclass_section_len += aligned_string_len(len*sizeof(WCHAR)); > + acl->actctx->wndclass_count++; > + It would be better to do this at the time you build the structure. The parser shouldn't need to worry about this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: po: Add English (Canada) resource [Take 2]
by Ken Sharp Aug. 2, 2013

Aug. 2, 2013

Please disregard this patch. I missed a couple of words and with those corrected en_CA.po becomes identical to en.po (except that "serialisation" is fuzzy) and Wine defaults to that anyway for Canadian English. Will re-submit if there are any changes (just noticed -able/-eable). Will keep an eye on the English translations. On 30/07/13 22:37, Ken Sharp wrote: > - Re-based to latest git > - Removed all the fuzzies thanks to http://www.etymonline.com/index.php > > Turns out all the -ise/-ize words used in Wine are of Latin origin anyway. > > > -------- Original Message -------- > Subject: po: Add English (Canada) resource > Date: Mon, 22 Jul 2013 19:28:51 +0100 > From: Ken Sharp <kennybobs(a)o2.co.uk> > To: wine-patches(a)winehq.org > > Canadian English follows some British/French rules but not others. > > I have left some of the -ise/-ize words fuzzy because: > > "the etymological convention that verbs derived from Greek roots are > spelled with -ize and those from Latin with -ise is preserved in that > practice." > http://en.wikipedia.org/wiki/Canadian_english#Spelling_and_dictionaries > > I tried looking for the origins of the words and I couldn't get any. The > non-fuzzies are correct. > > With British, US and Canadian I believe all the English variations (used > in Wine) are covered, except Philippines (follows US rules). > > >

1 1

Re: reg.exe: Add query function
by Nikolay Sivov Aug. 2, 2013

Aug. 2, 2013

On 8/1/2013 17:44, Hugh McMaster wrote: > This patch builds significantly on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. > > Some examples of usage: > > wine reg.exe query "HKCU" > wine reg.exe query "HKCU\Console" > wine reg.exe query "HKCU\Console" /v "ScreenSize" > wine reg.exe query "HKCU\Software" /s > > --- > programs/reg/reg.c | 232 +++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 221 insertions(+), 11 deletions(-) > > +static LPVOID WINAPI mem_alloc(size_t size) > +{ > + return HeapAlloc(GetProcessHeap(), 0, size); > +} > + > +static void WINAPI mem_free(LPVOID mem) > +{ > + HeapFree(GetProcessHeap(), 0, mem); > +} Why WINAPI? It's better to follow naming from existing module, there's plenty of them with similar helpers. > + case REG_SZ: > + case REG_MULTI_SZ: > + case REG_EXPAND_SZ: No tabs please. > +static void reg_output_subkey(LPWSTR key_name, LPWSTR subkeyName) > +{ > + reg_printfW(formatSW, key_name); > + > + if (subkeyName > 0) > + { > + reg_printfW(formatSW, slashW); > + reg_printfW(formatSW, subkeyName); > + reg_printfW(formatSW, newlineW); > + } > +} Comparison looks a bit odd. Also why do you need to break it down to three printf calls instead of one? > + p = strchrW(key_name,'\\'); > + if (!p) > + { > + p = 0; > + } > + else p++; I'm not sure what this is supposed to do. > + case REG_BINARY: > + case REG_NONE: > + pValue = value; > + for (i=0; i<valueSize; i++, pValue++) > + reg_printfW(formatXW, *pValue); > + break; There's no need for separate variable here nor for incrementing pointer.

2 3

Clang warns on "wrong" header guard in "config.h"
by Charles Davis Aug. 2, 2013

Aug. 2, 2013

Hi, I've been building Wine with Clang, and it (apparently, unlike GCC) produces warnings like this: ../../include/config.h:4:9: warning: 'WINE_CROSSTEST' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef WINE_CROSSTEST ^~~~~~~~~~~~~~ ../../include/config.h:5:9: note: '__WINE_CONFIG_H' is defined here; did you mean 'WINE_CROSSTEST'? #define __WINE_CONFIG_H ^~~~~~~~~~~~~~~ WINE_CROSSTEST I tracked this down to these three lines in configure.ac: AH_TOP([#ifndef WINE_CROSSTEST #define __WINE_CONFIG_H]) AH_BOTTOM([#endif /* WINE_CROSSTEST */]) These lines generate what Clang thinks is the header guard for the "config.h" header, but we know that it isn't--that header AFAICT has never had an include guard, and __WINE_CONFIG_H is just there to indicate that it's been included. Should we change the __WINE_CONFIG_H macro to be a real header guard instead, or (as I'll admit it has been in the past) is Clang broken here? I'd imagine you guys don't want to rig configure to add -Wno-header-guard to CFLAGS if you can help it. I will point out that lots of these warnings are generated when building with Clang, because (for obvious reasons) this particular header is included all over the place. It makes it harder to see real warnings (like the ones that caused AJ not to commit my last two patches). And please don't tell me to use GCC instead. I suspect that GCC might pick up a similar warning--there's been lots of cross pollination going on between GCC and Clang, so we might have to deal with this sooner or later--and I'd prefer sooner. (I know the commit that added the WINE_CROSSTEST checks is from over 3 years ago, but this warning was only added recently to Clang, which is why I'm only bringing this up now.) Chip

2 1

Re: [PATCH] d3dx9_36: Implement ID3DXEffect_FindNextValidTechnique + add tests.
by Rico Schüller Aug. 2, 2013

Aug. 2, 2013

On 02.08.2013 00:03, Christian Costa wrote: > + technique = (D3DXHANDLE)0xdeadbeef; > + hr = effect->lpVtbl->FindNextValidTechnique(effect, technique1, &technique); > + ok(hr == D3D_OK, "FindNextValidTechnique failed, got %#x, expected %#x\n", hr, D3D_OK); > + ok(technique == technique2, "Technique returned %p, expected %p\n", technique, technique2); > + > + technique = (D3DXHANDLE)0xdeadbeef; > + hr = effect->lpVtbl->FindNextValidTechnique(effect, technique2, &technique); > + ok(hr == S_FALSE, "FindNextValidTechnique, got %#x, expected %#x\n", hr, S_FALSE); Looks fine to me, but I found one minor issue. I'd write "FindNextValidTechnique failed, ..." as in the line above. Cheers Rico

1 0

Re: [11/11] apphelp: Add tests.
by Marvin Aug. 1, 2013

Aug. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26579 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.
by Alexei Svitkine Aug. 1, 2013

Aug. 1, 2013

Don't let the gdi32 driver allocate memory in the dplayx region. Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095 The issue is that the dplayx code in wine needs to allocate some memory at a static address (0x50000000) and loading the Mac native gdi driver ends up using that part of the address space. This patch fixes that by reserving that part of memory while the display driver is initialized and releasing it after. --- dlls/gdi32/driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+)

2 5

Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().
by Bruno Jesus Aug. 1, 2013

Aug. 1, 2013

On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller <kgbricola(a)web.de> wrote: > --- > dlls/d3dx9_36/effect.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > + if (!This->started) > + return D3D_OK; > + > + This->started = FALSE; > + > + return D3D_OK; Sorry to bother but why not simply force false and using a single return? Best wishes, Bruno

2 1

Re: [PATCH 1/11] apphelp: Add definitions.
by Alexandre Julliard Aug. 1, 2013

Aug. 1, 2013

Mislav Blazevic <krofnica996(a)gmail.com> writes: > @@ -25,6 +26,209 @@ extern "C" { > > BOOL WINAPI ApphelpCheckShellObject(REFCLSID, BOOL, ULONGLONG *); > > +typedef enum _PATH_TYPE { > + DOS_PATH, > + NT_PATH > +} PATH_TYPE; > + > +typedef struct _DB { > + HANDLE file; > + DWORD size; > + PBYTE data; > +} DB, *PDB; > + > +typedef DWORD TAGID; > +typedef WORD TAG; > + > +#define TAGID_NULL 0x0 > +#define TAGID_ROOT 0x0 > + > +/* The above definition of TAGID_ROOT is used in winapi but doesn't make > + * sense, especially internally, because TAGID represents offset into > + * database data and there is a header at offset 0, NOT a tag. > + * Therfore, this definition should only be used internally. */ > +#define _TAGID_ROOT 0xC If it's internal it shouldn't be in the public header. In fact I don't see any of these definitions in the SDK header. -- Alexandre Julliard julliard(a)winehq.org

1 0

reg.exe: Add query function
by Hugh McMaster Aug. 1, 2013

Aug. 1, 2013

This patch significantly builds on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. Some examples of usage: wine reg.exe query "HKCU" wine reg.exe query "HKCU\Console" wine reg.exe query "HKCU\Console" /v "ScreenSize" wine reg.exe query "HKCU\Software" /s --- programs/reg/reg.c | 232 +++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 221 insertions(+), 11 deletions(-)

2 2

Re: [PATCH 2/2] ddraw: Fix double to float conversion warnings
by Henri Verbeet Aug. 1, 2013

Aug. 1, 2013

On 1 August 2013 12:25, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c > index 2925cfa..5c12272 100644 > --- a/dlls/ddraw/executebuffer.c > +++ b/dlls/ddraw/executebuffer.c > @@ -382,10 +382,10 @@ HRESULT d3d_execute_buffer_execute(struct d3d_execute_buffer *buffer, > dst->u8.tv = src->u8.tv; > > /* Now, the matrix multiplication */ > - dst->u1.sx = (src->u1.x * mat._11) + (src->u2.y * mat._21) + (src->u3.z * mat._31) + (1.0 * mat._41); > - dst->u2.sy = (src->u1.x * mat._12) + (src->u2.y * mat._22) + (src->u3.z * mat._32) + (1.0 * mat._42); > - dst->u3.sz = (src->u1.x * mat._13) + (src->u2.y * mat._23) + (src->u3.z * mat._33) + (1.0 * mat._43); > - dst->u4.rhw = (src->u1.x * mat._14) + (src->u2.y * mat._24) + (src->u3.z * mat._34) + (1.0 * mat._44); > + dst->u1.sx = (src->u1.x * mat._11) + (src->u2.y * mat._21) + (src->u3.z * mat._31) + (1.0f * mat._41); > + dst->u2.sy = (src->u1.x * mat._12) + (src->u2.y * mat._22) + (src->u3.z * mat._32) + (1.0f * mat._42); > + dst->u3.sz = (src->u1.x * mat._13) + (src->u2.y * mat._23) + (src->u3.z * mat._33) + (1.0f * mat._43); > + dst->u4.rhw = (src->u1.x * mat._14) + (src->u2.y * mat._24) + (src->u3.z * mat._34) + (1.0f * mat._44); > I get where the 1.0f comes from, but I think you might as well just remove the multiplication completely. And please get rid of the tabs if you're resending anyway.

1 0