August 2013 - Wine-Devel - list.winehq.org

Re: ntdll: Store all 'comClass' attributes
by Alexandre Julliard Aug. 27, 2013

Aug. 27, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > + while (min <= max) > + { > + int n, c; > + > + n = (min+max)/2; > + > + c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. -- Alexandre Julliard julliard(a)winehq.org

2 1

Does auto-apt work to get wine dependencies in source code?
by Susan Cragin Aug. 27, 2013

Aug. 27, 2013

Hello, Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.

4 3

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (try 2).
by Bruno Jesus Aug. 27, 2013

Aug. 27, 2013

On Mon, Aug 5, 2013 at 1:24 AM, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-streaming sites as well). > Sorry it's taken so long to get back to this, life has been busy > lately. > > With this patch the SIO_ADDRESS_LIST_CHANGE call gets passed on to > NotifyAddrChange, which effectively fixes a problem where Silverlight > apps can loop forever calling SIO_ADDRESS_LIST_CHANGE (Bug #32328). > Part 2 actually implements the NotifyAddrChange call on Linux, though > this patch is sufficient on its own to resolve the bug since the > overlapped IO event no longer gets triggered. > > This version of the patch has bee updated to include tests that show > that the notification is not tied to the socket. For example, > changing an interface that the socket is not bound to still results in > an overlapped notification. It's worth noting that these tests > require interactive mode and a PC with two network cards, so for my > testing I used an actual (non-VM) Windows 7 box with a wired and a > wireless card. Was this patch already reviewed? Is there anything else take can be done to get it commited? I tested it in 2 different environments (win7 eth+wifi and winxp eth+eht) and the tests work as expected. Regards, Bruno

1 0

Re: Does auto-apt work to get wine dependencies in source code?
by Susan Cragin Aug. 26, 2013

Aug. 26, 2013

1 0

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.
by Alexandre Julliard Aug. 26, 2013

Aug. 26, 2013

Wolfgang Walter <wine(a)stwm.de> writes: > @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, IO_STATUS_BLOCK* IoStatusBlock > { > NTSTATUS ret; > HANDLE hEvent = NULL; > - > - SERVER_START_REQ( flush_file ) > - { > - req->handle = wine_server_obj_handle( hFile ); > - ret = wine_server_call( req ); > - hEvent = wine_server_ptr_handle( reply->event ); > + enum server_fd_type type; > + unsigned int options; > + int needs_close; > + int unix_handle; > + > + ret = server_get_unix_fd( hFile, FILE_WRITE_DATA, &unix_handle, > + &needs_close, &type, &options ); > + if (ret) return ret; You probably don't want to fail just because there's no unix fd. > + if (ret == STATUS_SUCCESS && IoStatusBlock) { > + IoStatusBlock->u.Status = ret; > } This is an unrelated change and should be a separate patch, with tests (also for failures cases), -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)
by Matteo Bruni Aug. 26, 2013

Aug. 26, 2013

2013/8/26 Stefan Dösinger <stefan(a)codeweavers.com>: > Try 2: > *) Require only GPU access for buffers > *) Reduce number of checkGLcall invocations > *) Remove a return from an ERR case > --- > dlls/wined3d/utils.c | 1 + > dlls/wined3d/volume.c | 168 ++++++++++++++++++++++++++++++++++++----- > dlls/wined3d/wined3d_private.h | 7 +- > 3 files changed, 157 insertions(+), 19 deletions(-) > > + case WINED3D_LOCATION_BUFFER: > + if (!volume->pbo || !(volume->flags & WINED3D_VFLAG_PBO)) > + ERR("Trying to load WINED3D_LOCATION_BUFFER without setting it up first.\n"); > + > + if (volume->locations & WINED3D_LOCATION_DISCARDED) > + { > + TRACE("Volume previously discarded, nothing to do.\n"); > + wined3d_volume_invalidate_location(volume, WINED3D_LOCATION_DISCARDED); > + } > + else if (volume->locations & WINED3D_LOCATION_TEXTURE_RGB) > + { > + struct wined3d_bo_address data = {volume->pbo, NULL}; > + volume_bind_and_dirtify(volume, context); > + wined3d_volume_download_data(volume, context, &data); > + } > + else > + { > + FIXME("Implement WINED3D_LOCATION_SYSMEM loading from %s.\n", > + wined3d_debug_location(volume->locations)); > + return; > + } > + wined3d_volume_validate_location(volume, WINED3D_LOCATION_BUFFER); > + break; > + Not really an actual review, but that FIXME looks wrong (copy-paste remnant probably).

2 1

questions to your commit "wineps.drv: Allow for vertical text printing!"
by Wolfgang Walter Aug. 26, 2013

Aug. 26, 2013

Hello Aric, I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for vertical text printing.) and I have some questions: 1) You added the parameter vertical to PSDRV_WriteSetFont() in ps.c but it remains unused. I think it isn't needed. 2) In PSDRV_WriteSetDownloadFont() in download.c you call PSDRV_WriteSetFont() with (lf.lfFaceName[0] == '@') for this new parameter vertical. I can't see why. 3) You added the parameter vertical to get_download_name() in download.c You use it to add "_vertical" to its name if vertical is true. I can't see why the font needs a different name. This will cause PSDRV_WriteSetDownloadFont() to download a font which is used vertically and horizontally twice. I can't see any reason why this could be necessary. I think that * PSDRV_WriteSetFont() should be changed back and of course the callers, too (in builtin.c and download.c) * get_download_name() should also be changed back (and its call in PSDRV_WriteSetDownloadFont()) Regards, -- Wolfgang Walter Studentenwerk München

2 1

Re: [patch fix]for 98152 and 98151,the encoding type was wrong.
by Akihiro Sagawa Aug. 26, 2013

Aug. 26, 2013

On Sun, 25 Aug 2013 23:13:53 +0900, matyapiro31 wrote: > The first one is > 0001-add-japanese-man-page-of-wine.patch > the second one is > 0001-last-change-of-my-translation-of-man-page.patch > Please cancel 98152 and 98151and try those two. These translations are outdated. The file seems to be based on wine 1.4 release. Makefile.in has a lot of formatting errors. You'd also refine it before resubmitting. Regards, Akihiro Sagawa

1 0

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.
by Alexandre Julliard Aug. 26, 2013

Aug. 26, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > MSDN for FlushFileBuffers says: > Flushes the buffers of a specified file and causes all buffered data to be > written to a file. > > Linux man page says: > tcdrain() waits until all output written to the object referred to by fd has > been transmitted. It's a blocking call, you can't do that on the server side. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/2] advapi32/tests: Add tests for hkcr handle mask
by Nikolay Sivov Aug. 24, 2013

Aug. 24, 2013

On 8/24/2013 07:11, George Stephanos wrote: > +#define IS_HKCR(hk) ((UINT_PTR)hk > 0 && ((UINT_PTR)hk & 3) == 2) > + Why is that important to check? In other words what depends on particular value pattern?

1 0

Re: [PATCH 4/6] wined3d: Enforce volume mapping restrictions
by Alexandre Julliard Aug. 23, 2013

Aug. 23, 2013

Stefan Dösinger <stefan(a)codeweavers.com> writes: > --- > dlls/wined3d/volume.c | 7 +++++++ > 1 file changed, 7 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so volume.c && touch volume.ok volume.c:187: Test succeeded inside todo block: D3DXLoadVolumeFromMemory returned 0x8876086c, expected 0x8876086c make: *** [volume.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Wiki is down
by Rosanne DiMesio Aug. 23, 2013

Aug. 23, 2013

I'm getting an "Unable to connect" message from Firefox and "Connection closed by remote server" from Opera. -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 3

winmm: Increase mmdevapi buffer sizes.
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 23, 2013

Aug. 23, 2013

Hi, Andrew Eikum argued: -/* buffer size = 10 * 100000 (100 ns) = 0.1 seconds */ +/* buffer size = 100 * 100000 (100 ns) = 1 second */ >The tiny buffer size caused audio capture glitches on OSX, where the OS >often returns audio in half-second chunks. That may be good enough for winmm, but that does not solve the problem in general. Since Vista, apps can access mmdevapi directly, thus they won't benefit from this increase in winmm buffer size. I believe that instead and in general, Wine should decouple WinAPI usage from idiosyncrasies of the underlying OS. IOW, apps requesting a mmdevapi capture buffer of a size that typically works on native should work in Wine too. If 100-200ms is that typical size, then it must be made to work with Wine's back-ends, perhaps by using a hidden buffer of at least 1s *internally* in winecoreaudio (and presumably winealsa for when Jack is in use). Somehow, Wine must bridge the impedance mismatch between native's 100-200ms buffers and the observed >0.5s buffer requirements on OSX. BTW, does that imply that input signal processing will see data with 0.5s latency on OSX? Would there be a 0.5s delay in chat applications? Regards, Jörg Höhle

1 0

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes
by Henri Verbeet Aug. 23, 2013

Aug. 23, 2013

On 22 August 2013 23:22, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -145,6 +158,9 @@ static DWORD volume_access_from_location(DWORD location) > case WINED3D_LOCATION_TEXTURE_RGB: > return WINED3D_RESOURCE_ACCESS_GPU; > > + case WINED3D_LOCATION_BUFFER: > + return WINED3D_RESOURCE_ACCESS_CPU | WINED3D_RESOURCE_ACCESS_GPU; > + Why does loading into a PBO require CPU access? > + case WINED3D_LOCATION_BUFFER: > + if (!volume->pbo || !(volume->flags & WINED3D_VFLAG_PBO)) > + { > + ERR("Trying to load WINED3D_LOCATION_BUFFER without setting it up first.\n"); > + return; > + } I think there should never be a PBO without WINED3D_VFLAG_PBO being set. There's also something to be said for leaving out the return, since that would at least in theory allow the compiler to drop the extra checks when compiled without debug messages. That probably applies to ERRs in general, since they're either never supposed to happen, or not supposed to be an ERR. > +/* Context activation is done by the caller. */ > +static void wined3d_volume_prepare_pbo(struct wined3d_volume *volume, struct wined3d_context *context) > +{ > + const struct wined3d_gl_info *gl_info = context->gl_info; > + > + if (volume->pbo) > + return; > + > + GL_EXTCALL(glGenBuffersARB(1, &volume->pbo)); > + checkGLcall("glGenBuffersARB(1, &volume->pbo)"); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, volume->pbo)); > + checkGLcall("glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, volume->pbo)"); > + GL_EXTCALL(glBufferDataARB(GL_PIXEL_UNPACK_BUFFER_ARB, volume->resource.size, NULL, GL_STREAM_DRAW_ARB)); > + checkGLcall("glBufferDataARB(GL_PIXEL_UNPACK_BUFFER_ARB, volume->resource.size, NULL, GL_STREAM_DRAW_ARB"); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)"); > + > + TRACE("Created PBO %u for volume %p.\n", volume->pbo, volume); > +} I think one checkGLcall() per function is enough in general. That's even more true these days with ARB_debug_output that will usually give more specific error messages than checkGLcall() anyway. Applies to a couple of other places as well.

2 5

Re: Permissions bug with Acrobat X Standard
by Alexey Loukianov Aug. 23, 2013

Aug. 23, 2013

Neil, thanks for reporting. Could you please re-report this bug to a place where reports should be posted - i.e. to Wine's Bugzilla which could be found at http://bugs.winehq.com/ ? Thanks in advance. --- Best regards, Alexey Loukianov HPC support and maintenance engineer, RSC Technologies http://rscgroup.ru/en/

1 0

Re: comsvcs: Add dll comsvcs (try 3)
by Nikolay Sivov Aug. 23, 2013

Aug. 23, 2013

On 8/23/2013 13:18, Alistair Leslie-Hughes wrote: > Hi, > Fix build issue > > +#include "rpcproxy.h" I don't think you need this. > +HINSTANCE COMSVCS_hInstance = NULL; This should be static (and without initializer after that).

1 0

Re: server: Store full sized completion information on the server side.
by Alexandre Julliard Aug. 23, 2013

Aug. 23, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -152,7 +152,7 @@ struct completion *get_completion_obj( struct process *process, obj_handle_t han > } > > void add_completion( struct completion *completion, apc_param_t ckey, apc_param_t cvalue, > - unsigned int status, unsigned int information ) > + apc_param_t information, unsigned int status ) There's no reason to change the parameter order. That's only adding noise to the patch, and potential bugs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Request to delete some attachments
by Ken Sharp Aug. 22, 2013

Aug. 22, 2013

Could a Bugzilla admin please delete the attachments in http://bugs.winehq.org/show_bug.cgi?id=24867 ? I don't know if metatester.exe can be freely distributed.

2 1

Re: wined3d: Recognize Nvidia GeForce GTX 770
by Henri Verbeet Aug. 22, 2013

Aug. 22, 2013

On 22 August 2013 03:31, Gediminas Jakutis <gediminas(a)varciai.lt> wrote: > + {"GTX 770", CARD_NVIDIA_GEFORCE_GTX770}, /* Geforce 700 - highend */ > {"GTX 770M", CARD_NVIDIA_GEFORCE_GTX770M}, /* Geforce 700 - midend high mobile */ That doesn't work, it will always match "GTX 770" now, and never "GTX 770M".

1 0

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text. (try 2)
by Ken Thomases Aug. 22, 2013

Aug. 22, 2013

On Aug 22, 2013, at 12:07 AM, Charles Davis wrote: > Try 2: Eliminiate dead store. Sort export functions by name. Looks OK to me. -Ken

1 0

Permissions bug with Acrobat X Standard
by Neil Hellfeldt Aug. 22, 2013

Aug. 22, 2013

err:msi:cabinet_copy_file failed to create L"C:\\users\\Public\\Application Data\\Adobe\\Adobe PDF\\Settings\\Standard.joboptions" (error 3) err:msi:extract_cabinet FDICopy failed err:msi:ACTION_InstallFiles Failed to extract cabinet: L"Data1.cab" err:msi:ITERATE_Actions Execution halted, action L"InstallFiles" returned 1603 err:msi:ITERATE_Actions Execution halted, action L"ExecuteAction" returned 1603 Sysinfo: lubuntu 3.04 64bit WINEARCH=win32 When I go to the parent directory I find this location: ~/.local/share/wineprefixes/acrobatxstd/drive_c/users/Public/Application Data/Adobe drwxrwxr-x 3 hellfeldt hellfeldt 4.0K Aug 21 17:12 Acrobat/ dr-xr-xr-x 3 hellfeldt hellfeldt 4.0K Aug 21 17:12 Adobe PDF/ ~/.local/share/wineprefixes/acrobatxstd/drive_c/users/Public/Application Data/Adobe$ cd Adobe\ PDF/ ~/.local/share/wineprefixes/acrobatxstd/drive_c/users/Public/Application Data/Adobe/Adobe PDF$ mkdir Settings mkdir: cannot create directory ‘Settings’: Permission denied I tried changing the directory permissions and I tried creating the directory but acrobat delete the Adobe PDF directory and recreates it with the bad permissions again.

1 0

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.
by Ken Thomases Aug. 22, 2013

Aug. 22, 2013

On Aug 21, 2013, at 9:42 PM, Charles Davis wrote: > @@ -90,6 +93,9 @@ static CFDataRef export_hdrop_to_filenames(HANDLE data); > static CFDataRef export_oemtext_to_utf8(HANDLE data); > static CFDataRef export_text_to_utf8(HANDLE data); > static CFDataRef export_unicodetext_to_utf8(HANDLE data); > +static CFDataRef export_oemtext_to_utf16(HANDLE data); > +static CFDataRef export_text_to_utf16(HANDLE data); > +static CFDataRef export_unicodetext_to_utf16(HANDLE data); Please keep the export_* functions sorted (although I'm fine with utf8 coming before utf16). This applies to the function definitions, too. (Yes, this is an exceedingly minor issue. Sorry.) > +static HANDLE import_utf16_to_unicodetext(CFDataRef data) > +{ > + const WCHAR *src; > + unsigned long data_len; > + unsigned long new_lines = 0; > + LPWSTR dst; > + unsigned long i, j; > + HANDLE unicode_handle = NULL; This is an unnecessary initialization / dead store, which is frowned upon. Thanks! -Ken

2 2

Re: [PATCH 6/6] wined3d: Implement basic volume location management (try 2)
by Henri Verbeet Aug. 22, 2013

Aug. 22, 2013

On 22 August 2013 14:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (volume->locations & WINED3D_LOCATION_DISCARDED) > + { > + TRACE("Volume previously discarded, nothing to do.\n"); > + wined3d_volume_invalidate_location(volume, WINED3D_LOCATION_DISCARDED); > + } I don't think the location invalidation here is strictly required, although it probably doesn't hurt much in practice. (I.e., consider the sequence DISCARD, load SYSMEM, load TEXTURE_RGB. There's no real reason the RGB load needs to do an upload from SYSMEM in that case, although it's perhaps not something that's going to happen much in practice either way.) > + wined3d_volume_validate_location(volume, WINED3D_LOCATION_SYSMEM); You could probably just have a wined3d_volume_validate_location(volume, location); at the end of the function and return from the default case instead. That's not something I feel strongly about though.

2 1

Re: oleaut32/tests: Some tests for LoadRegTypeLib() with activated context
by Alexandre Julliard Aug. 22, 2013

Aug. 22, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Some tests for LoadRegTypeLib() with activated context > > From 1ea3d8c82dd77ac14f2cdec748c0284032958b2f Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Wed, 21 Aug 2013 12:34:47 +0400 > Subject: [PATCH 5/6] Some tests for LoadRegTypeLib() with activated context It doesn't work here: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so tmarshal.c && touch tmarshal.ok tmarshal.c:999: Test failed: LoadRegTypeLib failed with error 0x8002801d tmarshal.c:1232: Test failed: IKindaEnumWidget_Next failed with error 0x8007000e wine: Unhandled page fault on read access to 0x00000000 at address 0x68640714 (thread 003a), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/5] wined3d: Implement basic volume location management
by Henri Verbeet Aug. 22, 2013

Aug. 22, 2013

On 22 August 2013 00:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +const char *wined3d_debug_location(DWORD location) > +{ > + char buf[238]; That number looks a bit arbitrary, although I suppose it's at least large enough. > + if (volume->resource.pool == WINED3D_POOL_SYSTEM_MEM > + || volume->resource.pool == WINED3D_POOL_SCRATCH) > + { > + if (location & ~WINED3D_LOCATION_SYSMEM) > + { > + ERR("Trying to load a sysmem or scratch volume into %s.\n", > + wined3d_debug_location(location)); > + return; > + } > + } In principle we have resource_access_from_location() and the access_flags field in struct wined3d_resource for this. It's only a warning in surface_load_location() because we load e.g. default pool surfaces into sysmem for CPU fallbacks, but that doesn't apply to volumes. The right way for surfaces would probably be to use a staging resource for CPU fallbacks instead, or something along those lines. > + if (count_bits(location) > 1) > + FIXME("Implement loading two locations with one call\n"); > + I don't think we really want that. > +static void wined3d_volume_update_location(struct wined3d_volume *volume, DWORD location, BOOL keep) > +{ > + if (keep) > + { > + TRACE("Volume %p, invalidating %s.\n", volume, > + wined3d_debug_location(volume->locations & ~location)); > + volume->locations = location; > + } > + else > + { > + TRACE("Volume %p, invalidating %s.\n", volume, wined3d_debug_location(location)); > + volume->locations &= ~location; > + } > +} I'm a bit unhappy with the "persistent" flag to surface_modify_location(), and this is essentially the same thing. I think it would be better to just have two separate functions, wined3d_volume_invalidate_location() and wined3d_volume_validate_location(). Perhaps wined3d_volume_update_location() can work too, but in that case I think it should take two location masks, one to set and one to clear.

2 8