August 2013 - Wine-Devel - list.winehq.org

Re: [4/4] oledb32: A basic test for IRowPosition_Initialize()
by Marvin Aug. 22, 2013

Aug. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26813 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: gdi32: some fix of errors writing Arabic on entry boxs
by Yaron Shahrabani Aug. 22, 2013

Aug. 22, 2013

Ahlan Ya Mas3ab! How can I test it with Hebrew? Yaron Shahrabani <Hebrew translator> On Wed, Aug 21, 2013 at 11:19 PM, مصعب الزعبي <moceap(a)hotmail.com> wrote: > Written By Aric Stewart , fix about 50 percent of Bug 33794 > > --- > dlls/gdi32/font.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >

1 0

Re: msvcrt: _[w]access_s returns an error code.
by Marvin Aug. 21, 2013

Aug. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26809 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

RFC: winedev guide multimedia chapter patch
by Frédéric Delanoy Aug. 21, 2013

Aug. 21, 2013

Hi guys, I've been updating the wine multimedia paths of the wine dev guide, but I'm not really familiar with that area of Wine, so could you please have a look at the attached patch to check if it seems correct? I checked the code a bit but I'm not sure how outdated the guide is. For easier "testing", just clone http://source.winehq.org/git/docs.git, apply the patch and run ./configure, then 'make winedev-guide.html' in the "en/" subdirectory. Thanks, Frédéric Delanoy

2 1

Re: [PATCH] winemac.drv: Use the public UTF-16 type for Unicode text.
by Ken Thomases Aug. 21, 2013

Aug. 21, 2013

On Aug 20, 2013, at 10:49 PM, Charles Davis wrote: > In the Windows world, "Unicode" almost universally means "UTF-16". So, > use the well-known UTF-16 type instead of making up our own. > > I have to wonder if there was a good reason Ken didn't use this > initially. Please hold this patch while I review it. I think there is a good reason why I didn't use it, but I have to figure it out again. :-/ It has to do with a promised pasteboard type (what Microsoft calls delayed rendering) and the conversions to the other text types. I think we need to use a custom type to distinguish between being asked for promised data vs. being asked for a conversion. -Ken

2 2

Re: mscoree: Attempt to load the assembly from the application directory (try 2)
by Vincent Povirk Aug. 21, 2013

Aug. 21, 2013

+ /* Assume the namespace is the Assembly name */ Uh, what? We should only be passing an assembly name to get_file_from_strongname, not the class name. You shouldn't even have access to the class name. I think what you're actually doing here is skipping the assembly name and using the assembly version, which won't work.

1 0

Re: wined3d: Add a function for allocating aligned resource, memory (try 3)
by Alexandre Julliard Aug. 21, 2013

Aug. 21, 2013

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This supersedes patch 98009. It renames the allocation and free > functions as suggested by Henri. It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c && touch texture.ok texture.c:555: Tests skipped: No D3DUSAGE_AUTOGENMIPMAP support for volume textures wine: Unhandled page fault on write access to 0x00000000 at address 0x7bc4a5cf (thread 003c), starting debugger... Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x7bc4a5cf). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7bc4a5cf ESP:0032f79c EBP:0032f898 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:7bcbc474 ECX:00164268 EDX:68d795a0 ESI:00110014 EDI:001642c8 Stack dump: 0x0032f79c: 7bc37d5d 00000050 00000002 00164278 0x0032f7ac: 00000000 00000000 00000000 00000000 0x0032f7bc: 687c05d8 00000001 00000000 00000000 0x0032f7cc: 4d430003 00000000 00000000 00000000 0x0032f7dc: 00000000 00000000 4d430001 00164268 0x0032f7ec: 00000010 00000000 00000000 00000000 Backtrace: =>0 0x7bc4a5cf HEAP_CreateFreeBlock+0x36f(subheap=0x110014, ptr=0x164268, size=0x60) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:101] in ntdll (0x0032f898) 1 0x7bc4a878 HEAP_MakeInUseBlockFree+0x157(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:656] in ntdll (0x0032f938) 2 0x7bc4b8e2 RtlFreeHeap+0xd1(heap=<couldn't compute location>, flags=<couldn't compute location>, ptr=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1771] in ntdll (0x0032f9a8) 3 0x68e0642e wined3d_resource_free_sysmem+0x2d(mem=0x1642c0) [/home/julliard/wine/wine/dlls/wined3d/resource.c:361] in wined3d (0x0032f9d8) 4 0x68e06503 resource_cleanup+0xc2(resource=0x1651e0) [/home/julliard/wine/wine/dlls/wined3d/resource.c:168] in wined3d (0x0032fa28) 5 0x68e6e671 wined3d_volume_decref+0xb0(volume=<couldn't compute location>) [/home/julliard/wine/wine/dlls/wined3d/volume.c:142] in wined3d (0x0032fa68) 6 0x68e5eb42 texture3d_sub_resource_cleanup+0x31(sub_resource=0x1651e0) [/home/julliard/wine/wine/dlls/wined3d/texture.c:1125] in wined3d (0x0032fa98) 7 0x68e5ea8e wined3d_texture_cleanup+0x4d(texture=0x164c70) [/home/julliard/wine/wine/dlls/wined3d/texture.c:126] in wined3d (0x0032fae8) 8 0x68e5fba9 wined3d_texture_decref+0x48(texture=<couldn't compute location>) [/home/julliard/wine/wine/dlls/wined3d/texture.c:449] in wined3d (0x0032fb28) 9 0x68d6701b d3d9_texture_3d_Release+0x5a() in d3d9 (0x0032fb88) 10 0x686a82ea func_texture+0x24d9() [/home/julliard/wine/wine/dlls/d3dx9_36/tests/texture.c:1595] in d3dx9_36_test (0x0032fd38) 11 0x6862c3d7 main+0x386(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3dx9_36/tests/../../../include/wine/test.h:570] in d3dx9_36_test (0x0032fe08) 12 0x686adcc0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3dx9_36_test (0x0032fe58) 13 0x7b85eb8c call_process_entry+0xb() in kernel32 (0x0032fe78) 14 0x7b85fd6b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0032feb8) 15 0x7bc7a170 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 16 0x7bc7d07d call_thread_func+0x7c(entry=0x7b85fd00, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 17 0x7bc7a14e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 18 0x7bc4fade start_process+0x1d(kernel_start=0x7b85fd00) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2694] in ntdll (0x0032ffe8) 19 0x680311ad wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 20 0x6803126b wine_switch_to_stack+0x2a(func=0x7bc4fac0, arg=0x7b85fd00, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffd46e68) 21 0x7bc55617 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2750] in ntdll (0xffd46ed8) 22 0x7b8662e0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xffd47de8) 23 0x7bc55ce3 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2959] in ntdll (0xffd47e78) 24 0x6802edf2 wine_init+0x2a1(argc=0x3, argv=0xffd483b4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xffd47ed8) 25 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffd48318) 26 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x7bc4a5cf HEAP_CreateFreeBlock+0x36f [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:101] in ntdll: movl %edx,0x0(%eax) 101 elem->prev->next = elem->next; -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ieframe: Use winehq snapshot instead of the main page in tests.
by Marvin Aug. 21, 2013

Aug. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26794 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3079: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 004033D1 === WXPPROSP2 (32 bit webbrowser) === webbrowser.c:792: Test failed: ReadyState = 1, expected 4

1 0

Re: [PATCH 2/2] msvcrt: Fix lookahead buffer usage on pipes (try2)
by Piotr Caban Aug. 21, 2013

Aug. 21, 2013

Please ignore this patch, I'll send a better version.

1 0

Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.
by Alexandre Julliard Aug. 21, 2013

Aug. 21, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -748,6 +748,11 @@ err: > } > else > { > + if (type == FD_TYPE_FILE) > + { > + io_status->u.Status = status; > + io_status->Information = total; > + } I don't see why this would have to be specific to files. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] msvcrt: Fix lookahead buffer usage on pipes
by Alexandre Julliard Aug. 21, 2013

Aug. 21, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/file.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so file.c && touch file.ok file.c:2042: Test failed: read returned 2, expected 1 make[1]: *** [file.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] server: Store full sized completion information on the server side.
by Marvin Aug. 21, 2013

Aug. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26791 Your paranoid android. === W2KPROSP4 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPPROSP2 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPX64 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === W2K3R2SESP2 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === W2K8SE (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPX64 (64 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011

1 0

Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.
by Marvin Aug. 21, 2013

Aug. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26790 Your paranoid android. === W2KPROSP4 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPPROSP2 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPX64 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === W2K3R2SESP2 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === W2K8SE (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPX64 (64 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011

1 0

Re: [4/6] ntdll/tests: Mark the NtReadFile call which returns STATUS_SUCCESS for an overlapped IO call as broken, and don't
by Marvin Aug. 21, 2013

Aug. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26789 Your paranoid android. === W2KPROSP4 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPPROSP2 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPX64 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === W2K3R2SESP2 (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === W2K8SE (32 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011 === WXPX64 (64 bit file) === file.c:785: Test failed: expected STATUS_PENDING, got 0xc0000011

1 0

Re: oledb32: Add IDataSourceLocator support (try 6)
by Nikolay Sivov Aug. 21, 2013

Aug. 21, 2013

On 8/21/2013 10:33, Alistair Leslie-Hughes wrote: > +typedef struct DataSourceImpl > +{ > + IDataSourceLocator IDataSourceLocator_iface; > + LONG ref; > + > +} DataSourceImpl; All good, except this one.

1 0

Re: [4/6] kernel32: Make serial tests self-contained.
by Saulius Krasuckas Aug. 21, 2013

Aug. 21, 2013

* On Thu, 15 Aug 2013, Dmitry Timoshkov wrote: > dlls/kernel32/tests/comm.c | 284 ++++++++++++++++++++++++++------------------- > 1 file changed, 167 insertions(+), 117 deletions(-) ... > --- a/dlls/kernel32/tests/comm.c > +++ b/dlls/kernel32/tests/comm.c > @@ -1486,7 +1588,7 @@ static void test_WaitRing(HANDLE hcom) > success, err, evtmask, after-before, after1-before); > > ok(evtmask & EV_RING, "Failed to detect EV_RING: 0x%08x, expected 0x%08x\n", > - evtmask, EV_RING); > + evtmask, EV_CTS); Is everything OK with the constants here? S.

1 0

Re: oledb32: Add IDataSourceLocator support (try 5)
by Nikolay Sivov Aug. 21, 2013

Aug. 21, 2013

On 8/21/2013 10:16, Alistair Leslie-Hughes wrote: > Hi, > Updated naming. You updated method names only, what's left : > +typedef struct DataSourceImpl > +HRESULT create_data_source(IUnknown *outer, void **obj) > +static const IDataSourceLocatorVtbl DataSourceVtbl = Also you most likely don't need these: > +#include "wine/unicode.h" > +#include "wine/list.h" > > > Changelog: > oledb32: Add IDataSourceLocator support > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

Re: oledb32: Add IDataSourceLocator support (try 4)
by Nikolay Sivov Aug. 21, 2013

Aug. 21, 2013

On 8/21/2013 09:15, Alistair Leslie-Hughes wrote: > Hi, > Use helper functions for memory > > > Changelog: > oledb32: Add IDataSourceLocator support > > > Best Regards > Alistair Leslie-Hughes It looks okay, but I suggest to fix a naming: > +typedef struct DataSourceImpl > +{ > + IDataSourceLocator IDataSourceLocator_iface; > + LONG ref; > + > +} DataSourceImpl; > +static HRESULT WINAPI datasource_QueryInterface(IDataSourceLocator *iface, REFIID riid, void **ppvoid) etc. IDataSource is another interface, and it's confusing to name locator after it - dslocator_* naming used in CF is short enough and descriptive to use it everywhere.

1 0

Willing to join Wine
by Priyank Bhatt Aug. 20, 2013

Aug. 20, 2013

I want to work for Wine . I'm a third year undergraduate Student , I have done my elimentary course on machine learning algorithm . I am also familiar with C/C++ and some what of Python . Please suggest what all do I need to learn or read so as to start contributing to the open source community of mlpack. As an amateur and as per your free slots what project form the idea's page should I work on ?

2 1

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.
by Andrew Eikum Aug. 20, 2013

Aug. 20, 2013

On Tue, Aug 20, 2013 at 05:57:34AM +0200, Fabrice Bauzac wrote: > Hello, > > This patch intends to fix the bug: > http://bugs.winehq.org/show_bug.cgi?id=34305 > > The bug: basically, when there is no sound device and the user tries > to WOD_Open() the WAVE_MAPPER pseudodevice, the code calls read_map() > with device index 0 without first checking whether the number of > devices is greater than 0. > Looks good to me, thanks. I tested on Windows 7, and the error code is correct. By the way, the waveIn path (WID_Open) has the same bug. Feel free to fix that, too, if you want. Or I'll submit a patch myself later. Andrew

2 2

Re: [PATCH 2/4] oleaut32: Implement ICreateTypeInfo::SetTypeDescAlias
by Piotr Caban Aug. 20, 2013

Aug. 20, 2013

On 08/20/13 16:57, Andrew Eikum wrote: > @@ -10530,8 +10541,28 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeDescAlias(ICreateTypeInfo2 *ifac > + This->cbSizeInstance = VARIANT_DataSize(This->tdescAlias->vt, This->pTypeLib->ptr_size); > + if(!This->cbSizeInstance){ > + FIXME("Wrong size for variant type! 0x%x\n", This->tdescAlias->vt); > + This->cbSizeInstance = 4; > + } > + > + This->cbAlignment = 4; The This->cbAlignment should be also depending on alias type (e.g. it's 1 for VT_I1).

1 0

Re: Sort the AUTHORS file by their last names.
by Ken Sharp Aug. 20, 2013

Aug. 20, 2013

On 16/08/13 14:46, Tae Wong wrote:> The AUTHORS file have all developers from the GIT log which were > sorted on their first names. > > This patch will switch the sort order from first to last names. This isn't how the AUTHORS file is generated. http://source.winehq.org/git/wine.git/commit/5da31c8817293ff98b4defceb962f7…

5 14

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)
by Henri Verbeet Aug. 20, 2013

Aug. 20, 2013

On 20 August 2013 12:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void *wined3d_alloc_resource_mem(SIZE_T size) > +{ > + void **p; > + SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); > + void *mem; > + > + if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align))) > + return NULL; > + > + p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1; > + *p = mem; > + > + return ++p; > +} I think this should either be called wined3d_resource_allocate_sysmem() and live in resource.c, or accept any np2 alignment and be called something along the lines of wined3d_memalign(). The former probably makes the most sense at this point. Somewhat related, I don't think there's really a reason to have both "allocatedMemory" and "heap_memory" anymore. It should probably just be called "sysmem". That's a cleanup that doesn't necessarily belong in this patch though.

2 2

Re: kernel32: Fix required buffer length for locale values from registry
by Alexandre Julliard Aug. 20, 2013

Aug. 20, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > http://bugs.winehq.org/show_bug.cgi?id=32169 > > Locale info to override is stored as REG_SZ and supposed to be > null-terminated, They are supposed to, but it's not guaranteed. The code should be able to cope with non-terminated strings. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oledb32: Implement IErrorRecord AddErrorRecord
by Nikolay Sivov Aug. 20, 2013

Aug. 20, 2013

On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: > Hi, > Yes we do just take the pointer (pErrorInfo) passed in. MSDN states > that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you have to make a deep copy. > > > Changelog: > oledb32: Implement IErrorRecord AddErrorRecord > > > Best Regards > Alistair Leslie-Hughes > >

2 1