September 2013 - Wine-Devel

Re: add ualapi directory (try 11)
by Marcus Meissner Sept. 28, 2013

Sept. 28, 2013

On Sat, Sep 28, 2013 at 11:58:33AM +0900, Akira Nakagawa wrote: > > > > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapiro31(a)gmail…> > From: Akira Nakagawa <matyapiro31(a)gmail.com> > Date: Mon, 23 Sep 2013 17:00:04 +0900 > Subject: [PATCH] add ual directory (try9) > > --- > configure | 2 + Not needed to be submitted > configure.ac | 2 + also not actually needed as these parts are autogenerated. > dlls/ualapi/Makefile.in | 6 +++ > dlls/ualapi/main.c | 86 +++++++++++++++++++++++++++++++++++++++++ > dlls/ualapi/tests/Makefile.in | 8 ++++ > dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++ You have no working tests yet, so leave these two files out. Add them with the patch with the first tests. > dlls/ualapi/ualapi.spec | 4 ++ > include/Makefile.in | 1 + include/Makefile.in is also autoadjusted. > include/ual.h | 48 +++++++++++++++++++++++ > 9 files changed, 195 insertions(+) rest looks ok, but you really only should submit: dlls/ualapi/Makefile.in dlls/ualapi/main.c dlls/ualapi/ualapi.spec include/ual.h as the rest are autogenerated. Ciao, Marcus

2 1

Re: add ualapi directory (try 12)
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2391 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: [2/2] ws2_32: Implement WSASendMsg()
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2388 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (1c4): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (870): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (870): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (870): error 10054: sock.c:534: Test failed: oob_server (870): not at the OOB mark: 1

1 0

Re: [1/2] ws2_32/tests: Fix an ok() call comment
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2387 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (408): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:509: Test failed: oob_server (bb8): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (bb8): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:528: Test failed: oob_server (6f0): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (940): unexpectedly at the OOB mark: 0

1 0

Re: [2/2] ws2_32: Implement WSASendMsg()
by Bruno Jesus Sept. 28, 2013

Sept. 28, 2013

On Sat, Sep 28, 2013 at 1:50 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Fixes bug 34005. There is a problem with this patch, I'm working on an updated version. Sorry, Bruno

1 0

Re: add ualapi directory (try 11)
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2386 Your paranoid android. === build (build) === Make failed

1 0

Re: (try 6)[5/5] imm32: limit cross thread access to ImmSet* functions
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2377 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 6)[4/5] imm32: Restrict crossthread Association and destruction
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2376 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 6)[3/5] imm32: use thread data from target HWND
by Marvin Sept. 27, 2013

Sept. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2375 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] mshtml: Added IHTMLFormElement::sumit tests.
by Marvin Sept. 27, 2013

Sept. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2374 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] appwiz.cpl: Use the same dialog template for Mono and Gecko downloader.
by Vincent Povirk Sept. 27, 2013

Sept. 27, 2013

Isn't this going to make the caption "Wine Gecko Installer" in both cases?

1 0

Re: add ualapi directory (try 10)
by Marvin Sept. 27, 2013

Sept. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2370 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.
by Stefan Dösinger Sept. 27, 2013

Sept. 27, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: > - swapchain->swapchain_ops->swapchain_present(swapchain, > src_rect, dst_rect, dirty_region, flags); + > wined3d_cs_emit_present(swapchain->device->cs, swapchain, > src_rect, + dst_rect, dst_window_override, dirty_region, > flags); I think we should place comments like "This function is called through the command stream" for all functions that are called through the CS, similar to what we do for context activation. Also note that swapchain_gl_present contains calls to wined3d_surface_blt and wined3d_device_clear that are going to cause problems with the multithreaded CS. I have patches to remove them, so feel free to ignore this problem for now. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRWaKAAoJEN0/YqbEcdMw9VgP/i2n/G2CHOA8XShC8CZnRzSq TNzbfIXwAQljQYtf66U98JmbMIoeS3SMPaJ4O1+mMiT062Udi3YddiTk2AVF9bi+ f6X4y9W8Q3jPolcuTxKpZ26/WFkViHtPEUtFaa5oBtksCNGZ0b3A4oK9zbrPBram EXwovsq649RqCoBf76aidtbypdkFKLfmC6P6KxtjB3C9cdKJ58kMD0YbVsua6zNc g8gUgExEQ0no9WEyWPtlN7PRf3tQlLtuUeqrRockqnK48cKbwk3VaEgfq8o6+INs EvgjoZvc2C/+YoEWUT+n7nCtIKo9IiMSG20Ey0sbmak/K/LrvZvsyHl78nQD4ss+ t5jRCS9QZs/VzJc0VakGsZARP9jGBvzapsrAcy6Ittu1d53fpji6ySwKeUrPKim+ wMtWGtu+q0FXtIRtgDYUOofd9b1o1sB3xPqUIpRm7+yBRpXiBvuGqbmbsa/14wBe vkI5b5S/djskw9M5bV1lAOCgGmo+zFIYyebxwvx8H+sqz4HmYql9uPLTOHqWvHtn J7iXcETOlcOrC+zOOT8nieR8YYuFcda51auvK5lnXtCTQvoQse5egV16x2hJkkjx Pujit58jX2/O0WS0hqR5oAfhYtPydqUf2BayXgkLUODiZa0z1UWD2eerlOvGSvcq AUs+vi2QpDjeWmQH37BZ =QcW+ -----END PGP SIGNATURE-----

2 3

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)
by Alexandre Julliard Sept. 27, 2013

Sept. 27, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Fixes bug 18440, 20847. > > Try 3: > - Rebase to recent source. > - Separate ABC metrics change. > - Use conditional operator. It breaks the tests: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c && touch dib.ok dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 make[1]: *** [dib.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 5)
by Nikolay Sivov Sept. 27, 2013

Sept. 27, 2013

On 9/13/2013 13:27, Jactry Zeng wrote: > Re-based to latest git. > > Does it actually accept any other value besides CP_ACP or 1200? Documentation is unclear here, and makes impression that only two these values are valid.

2 2

Re: ntdll: Make asynchronous WaitCommEvent report correct number of bytes returned.
by Marvin Sept. 27, 2013

Sept. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2356 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)
by Marvin Sept. 27, 2013

Sept. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2351 Your paranoid android. === w7u (32 bit font) === The test timed out

1 0

Re: [3/3] gdi32: Don't modify output glyph metrics unless the function succeeds. (try 2)
by Marvin Sept. 26, 2013

Sept. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2352 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/3] gdi32: Return GDI_ERROR when requested empty glyph bitmaps. (try 2)
by Marvin Sept. 26, 2013

Sept. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2350 Your paranoid android. === w7u (32 bit font) === No test summary line found Failure running script in VM: network read timed out

1 0

Re: [PATCH 1/2] gdi32: fix for rotated Arc, ArcTo, Chord and Pie drawing problem (try 2)
by Alexandre Julliard Sept. 26, 2013

Sept. 26, 2013

Daniel Wendt <daniel.wendt(a)linux.com> writes: > @@ -308,6 +308,11 @@ static int get_arc_points( PHYSDEV dev, const RECT *rect, POINT start, POINT end > } > > memmove( points, points + count, (pos - count) * sizeof(POINT) ); > + > + if (GetGraphicsMode( dev->hdc ) == GM_ADVANCED) > + { > + LPtoDP( dev->hdc, points, pos - count ); > + } > return pos - count; > } > > @@ -322,7 +327,17 @@ static BOOL draw_arc( PHYSDEV dev, INT left, INT top, INT right, INT bottom, > BOOL ret = TRUE; > HRGN outline = 0, interior = 0; > > - if (!get_pen_device_rect( pdev, &rect, left, top, right, bottom )) return TRUE; > + if (GetGraphicsMode(dev->hdc ) != GM_ADVANCED) > + { > + if (!get_pen_device_rect( pdev, &rect, left, top, right, bottom )) return TRUE; > + } > + else > + { > + rect.left = left; > + rect.top = top; > + rect.right = right; > + rect.bottom = bottom; > + } I don't think that you want to draw arcs in logical space, that can be very inefficient. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation (try2)
by Marvin Sept. 26, 2013

Sept. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2349 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: imm32: ImmGetDescriptionA return does not include NULL byte
by Alexandre Julliard Sept. 26, 2013

Sept. 26, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1684,7 +1684,7 @@ UINT WINAPI ImmGetDescriptionA( > > HeapFree( GetProcessHeap(), 0, buf ); > > - return len; > + return min( len - 1, uBufLen ); > } This may do the right thing on failure, but in an ugly way. A few overflow tests would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] riched20: Implement ITextDocument_fnOpen.
by Alexandre Julliard Sept. 26, 2013

Sept. 26, 2013

Jactry <jactry92(a)gmail.com> writes: > + chBuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size+2); > + if(!chBuffer) > + { > + CloseHandle(hFile); > + return HRESULT_FROM_WIN32(GetLastError()); > + } It's not useful to zero the buffer since you are reading into it. Also GetLastError won't do anything useful here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)
by Alexandre Julliard Sept. 26, 2013

Sept. 26, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -6519,11 +6519,17 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, > } > > lpgm->gmBlackBoxX = (right - left) >> 6; > + if (lpgm->gmBlackBoxX == 0) > + lpgm->gmBlackBoxX = 1; > lpgm->gmBlackBoxY = (top - bottom) >> 6; > + if (lpgm->gmBlackBoxY == 0) > + lpgm->gmBlackBoxY = 1; > lpgm->gmptGlyphOrigin.x = origin_x >> 6; > lpgm->gmptGlyphOrigin.y = origin_y >> 6; > abc->abcA = left >> 6; > abc->abcB = (right - left) >> 6; > + if (abc->abcB == 0) > + abc->abcB = 1; > abc->abcC = adv - abc->abcA - abc->abcB; It would be a good idea to add tests for the ABC metrics too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard Sept. 26, 2013

Sept. 26, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -530,12 +591,18 @@ static BOOL CALLBACK _ImmAssociateContextExEnumProc(HWND hwnd, LPARAM lParam) > */ > BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > { > + IMMThreadData* thread_data = NULL; > + > TRACE("(%p, %p, 0x%x):\n", hWnd, hIMC, dwFlags); > > - if (!IMM_GetThreadData()->defaultContext) > - IMM_GetThreadData()->defaultContext = ImmCreateContext(); > + thread_data = IMM_GetInitializedThreadData(); > + if (!thread_data) > + return FALSE; > > - if (!hWnd) return FALSE; > + LeaveCriticalSection(&threaddata_cs); > + > + if (!hWnd) > + return FALSE; > > switch (dwFlags) > { > @@ -543,7 +610,7 @@ BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > ImmAssociateContext(hWnd,hIMC); > return TRUE; > case IACE_DEFAULT: > - ImmAssociateContext(hWnd,IMM_GetThreadData()->defaultContext); > + ImmAssociateContext(hWnd,thread_data->defaultContext); > return TRUE; > case IACE_IGNORENOCONTEXT: > if (GetPropW(hWnd,szwWineIMCProperty)) You shouldn't be accessing thread data outside of the critical section. -- Alexandre Julliard julliard(a)winehq.org

1 0