September 2013 - Wine-Devel

Re: [2/4] ws2_32: Auto detect the socket type and family based on the protocol (try 2)
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2236 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/4] ws2_32: Use the struct information when the parameters are zero in WSASocket (try 2)
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2235 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 8/8] d3d9/tests: Test invalid volume lock boxes.
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2234 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/8] d3d9/tests: Add tests for block-based volume formats.
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2233 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/8] wined3d: Check for support before creating volume textures.
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2232 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/8] d3dx9_36/tests: Create*TextureFromFileInMemory doesn't fail.
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2231 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wsnmp32: Add stub implementations for a couple of functions.
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2230 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] ws2_32: Do not allow socket creation if WSAStartup was not called
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2229 Your paranoid android. === build (build) === Patch failed to apply

1 0

Asynchronous read/write tests in ntdll/tests/file.c
by Thomas Faber Sept. 18, 2013

Sept. 18, 2013

Hey Dmitry, I noticed a couple of tests structured like this: status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, sizeof(contents), &offset, NULL); ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below */, "expected STATUS_PENDING, got %#x\n", status); ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); ok(iob.Information == sizeof(contents), "expected sizeof(contents), got %lu\n", iob.Information); ... ret = WaitForSingleObject(hfile, 3000); Technically, the IO_STATUS_BLOCK (hence also the OVERLAPPED) structure is only filled once the I/O Manager completes the read/write IRP -- meaning its contents should only be read _after_ the wait. So this aspect essentially tests the question of "are ntfs.sys and the cache manager faster to fill the IOSB than the test can read it". That test can be completely valid, especially if it's known that applications do this, however I'm not sure whether that's actually the intention here. (My preference would obviously -- hence this mail -- be to read the result after waiting unless there's a specific reason to do it otherwise. The specifics are kind of up to the FS driver.) Thanks! -Thomas

2 2

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error
by Marvin Sept. 18, 2013

Sept. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2228 Your paranoid android. === build (build) === Patch failed to apply

1 0