September 2013 - Wine-Devel

Re: kernel32/time: Implement GetSystemTimes for linux.
by Bernard Ladenthin Sept. 29, 2013

Sept. 29, 2013

Am 29.09.2013 20:08, schrieb André Hentschel: > Am 28.09.2013 21:51, schrieb Bernard Ladenthin: >> --- >> dlls/kernel32/time.c | 149 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 149 insertions(+) > > > Hi, > please don't use C++ comments, also the rest of the coding style isn't often seen in Wine... > (e.g. missing space between if/for/... and the bracket, your way of variable definig/initializing, most likely more) > > maybe you also want to change the FIXME into something like "not implemented for this platform" and add a TRACE for the linux way. > > > Hi, thanks for the feedback, I will write a new patch. Regards, Bernard

1 0

Re: add ualapi directory (try 12)
by Bruno Jesus Sept. 28, 2013

Sept. 28, 2013

I still don't understand why the copyright is different for the .c and .h file. In one file you add your first name only and in the other your full name. Regards, Bruno On Sat, Sep 28, 2013 at 4:14 AM, Akira Nakagawa <matyapiro31(a)gmail.com> wrote: > > > > > > -- universe* god::bigbang (void); //and then it all began...

1 0

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2393 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (1d0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (5a0): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:509: Test failed: oob_server (b64): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (b64): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:509: Test failed: oob_server (650): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (650): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (650): error 10054: sock.c:534: Test failed: oob_server (650): not at the OOB mark: 1

1 0

Re: [1/3] ws2_32/tests: Fix an ok() call comment
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2392 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (748): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (998): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (2f0): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (2f0): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (2f0): error 10054: sock.c:534: Test failed: oob_server (2f0): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:509: Test failed: oob_server (938): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (938): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE229CD9

1 0

Re: [website] templates: More protocol relative urls
by Jactry Zeng Sept. 28, 2013

Sept. 28, 2013

Hi André, This patch seem let some urls in non-english version broken. Such as some urls in this page in Chinese: http://www.winehq.org/site/forums >- [<a href="http://www.winehq.org/mailman/listinfo/wine-announce ">（取消）订阅</a>] >- [<a href="http://www.winehq.org/pipermail/wine-announce/">存档 1</a>] >+ [<a href=//www.winehq.org/mailman/listinfo/wine-announce">（取消）订阅</a>] >+ [<a href=//www.winehq.org/pipermail/wine-announce/">存档 1</a>] You will find there is a quotation mark in the end of some urls in this page. We may need to remove the / in the end? >-<p> Wine 将会永远是<a href="http://www.winehq.org/license"title="Wine licensing">自由软件</a>。 >+<p> Wine 将会永远是<a href=//www.winehq.org/license"title="Wine licensing">自由软件</a>。 And the about page in Chinese, the urls of "自由软件" (Free Software) also been broken. There seem need a space or a enter between the url and 'title'. Thanks for your work! 2013/9/23 André Hentschel <nerv(a)dawncrow.de> > --- > templates/he/about.template | 2 +- > templates/he/forums.template | 46 > +++++++++++++++++++-------------------- > templates/he/help.template | 8 +++---- > templates/he/home.template | 4 ++-- > templates/he/license.template | 6 +++--- > templates/he/resources.template | 6 +++--- > templates/pl/forums.template | 2 +- > templates/pt/about.template | 4 ++-- > templates/pt/forums.template | 48 > ++++++++++++++++++++--------------------- > templates/pt/help.template | 8 +++---- > templates/pt/home.template | 4 ++-- > templates/zh-cn/about.template | 6 +++--- > templates/zh-cn/forums.template | 44 ++++++++++++++++++------------------- > templates/zh-cn/help.template | 8 +++---- > templates/zh-cn/home.template | 4 ++-- > templates/zh-cn/irc.template | 4 ++-- > 16 files changed, 102 insertions(+), 102 deletions(-) > > > > > > -- Regards, Jactry Zeng

1 0

Re: add ualapi directory (try 11)
by Marcus Meissner Sept. 28, 2013

Sept. 28, 2013

On Sat, Sep 28, 2013 at 11:58:33AM +0900, Akira Nakagawa wrote: > > > > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapiro31(a)gmail…> > From: Akira Nakagawa <matyapiro31(a)gmail.com> > Date: Mon, 23 Sep 2013 17:00:04 +0900 > Subject: [PATCH] add ual directory (try9) > > --- > configure | 2 + Not needed to be submitted > configure.ac | 2 + also not actually needed as these parts are autogenerated. > dlls/ualapi/Makefile.in | 6 +++ > dlls/ualapi/main.c | 86 +++++++++++++++++++++++++++++++++++++++++ > dlls/ualapi/tests/Makefile.in | 8 ++++ > dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++ You have no working tests yet, so leave these two files out. Add them with the patch with the first tests. > dlls/ualapi/ualapi.spec | 4 ++ > include/Makefile.in | 1 + include/Makefile.in is also autoadjusted. > include/ual.h | 48 +++++++++++++++++++++++ > 9 files changed, 195 insertions(+) rest looks ok, but you really only should submit: dlls/ualapi/Makefile.in dlls/ualapi/main.c dlls/ualapi/ualapi.spec include/ual.h as the rest are autogenerated. Ciao, Marcus

2 1

Re: add ualapi directory (try 12)
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2391 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: [2/2] ws2_32: Implement WSASendMsg()
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2388 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (1c4): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (870): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (870): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (870): error 10054: sock.c:534: Test failed: oob_server (870): not at the OOB mark: 1

1 0

Re: [1/2] ws2_32/tests: Fix an ok() call comment
by Marvin Sept. 28, 2013

Sept. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2387 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (408): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:509: Test failed: oob_server (bb8): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (bb8): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:528: Test failed: oob_server (6f0): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (940): unexpectedly at the OOB mark: 0

1 0

Re: [2/2] ws2_32: Implement WSASendMsg()
by Bruno Jesus Sept. 28, 2013

Sept. 28, 2013

On Sat, Sep 28, 2013 at 1:50 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Fixes bug 34005. There is a problem with this patch, I'm working on an updated version. Sorry, Bruno

1 0