September 2013 - Wine-Devel

Re: (try 3) [1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard Sept. 24, 2013

Sept. 24, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -443,6 +473,28 @@ static InputContextData* get_imc_data(HIMC hIMC) > return data; > } > > +static BOOL ensure_default_imc(IMMThreadData** thread_data) > +{ > + if (!(*thread_data)->defaultContext) > + { > + HIMC defaultContext; > + LeaveCriticalSection(&threaddata_cs); > + defaultContext = ImmCreateContext(); > + *thread_data = IMM_GetThreadData(0); > + if (!(*thread_data)) > + { > + IMM_DestroyContext(defaultContext); > + return FALSE; > + } > + > + if ((*thread_data)->defaultContext) /* someone beat us */ > + IMM_DestroyContext(defaultContext); > + else > + (*thread_data)->defaultContext = defaultContext; > + } > + return TRUE; > +} That's fairly inelegant, try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Android has struct user in asm/user.h
by André Hentschel Sept. 24, 2013

Sept. 24, 2013

Am 24.09.2013 17:13, schrieb Huw Davies: > --- > configure.ac | 1 + > server/ptrace.c | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) is that for the warning about the missing casts?

2 1

Virus spread via wine
by Dan Kegel Sept. 24, 2013

Sept. 24, 2013

Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

2 3

Re: [PATCH 4/5] d3d8/tests: Add a volume V16U16 test.
by Marvin Sept. 24, 2013

Sept. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2318 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.
by Marvin Sept. 24, 2013

Sept. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2317 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: server/protocol.def and array types
by Hugh McMaster Sept. 24, 2013

Sept. 24, 2013

Any help for this? -------------------------------------------------------------- I'm testing support for GetConsoleScreenBufferInfoEx. At the moment, I've extended the screen_buffer struct in server/console.c to look like this: struct screen_buffer { struct object obj; /* object header */ struct list entry; /* entry in list of all screen buffers */ struct console_input *input; /* associated console input */ int mode; /* output mode */ int cursor_size; /* size of cursor (percentage filled) */ int cursor_visible;/* cursor visibility flag */ int cursor_x; /* position of cursor */ int cursor_y; /* position of cursor */ int width; /* size (w-h) of the screen buffer */ int height; int max_width; /* size (w-h) of the window given font size */ int max_height; char_info_t *data; /* the data for each cell - a width x height matrix */ unsigned short attr; /* default attribute for screen buffer */ rectangle_t win; /* current visible window on the screen buffer * * as seen in wineconsole */ struct fd *fd; /* for bare console, attached output fd */ unsigned short popup_attr; /* the console popup fill attribute */ BOOL fullscreen; /* indicates whether fullscreen mode is supported */ COLORREF colortable[16];/* an array of DWORD values */ }; In server/protocol.def I have: @REQ(get_console_output_info) obj_handle_t handle; /* handle to the console */ @REPLY short int cursor_size; /* size of cursor (percentage filled) */ short int cursor_visible;/* cursor visibility flag */ short int cursor_x; /* position of cursor (x, y) */ short int cursor_y; short int width; /* width of the screen buffer */ short int height; /* height of the screen buffer */ short int attr; /* default attribute */ short int win_left; /* window actually displayed by renderer */ short int win_top; /* the rect area is expressed within the */ short int win_right; /* boundaries of the screen buffer */ short int win_bottom; short int max_width; /* maximum size (width x height) for the window */ short int max_height; short int popup_attr; /* the console popup fill attribute */ short int fullscreen; /* indicates whether fullscreen mode is supported */ --> type??? colortable; /* a COLORREF array of DWORD values */ @END While colortable is a COLORREF array, protocol.def does not allow types such as DWORD, COLORREF, etc. What type should colortable be given to pass tools/make_requests?

1 0

Re: [PATCH 5/5] ddraw: Avoid VOID.
by Marvin Sept. 24, 2013

Sept. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2316 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: add ualapi directory (try 9
by Marvin Sept. 24, 2013

Sept. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2313 Your paranoid android. === build (build) === Missing build status line The build timed out

2 1

Re: advapi32/tests: Mark a test result as broken.
by Marvin Sept. 24, 2013

Sept. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2315 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/2] winhttp/tests: Remove explicit zero-intialization of static data.
by Marvin Sept. 24, 2013

Sept. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2314 Your paranoid android. === build (build) === Patch failed to apply

1 0