January 2014 - Wine-Devel - list.winehq.org

Re: Command Stream Update
by Forest Jan. 12, 2014

Jan. 12, 2014

On Tue, 07 Jan 2014 22:31:24 +0100, Stefan Dösinger wrote: >I have published an update to the command stream patches from >September. The code is available on Github at >https://github.com/stefand/wine Thanks, Stefan! I used a snapshot of your repository for my latest Ubuntu PPA release. This ought to please the users who have been asking for an update. (Last time I checked, Launchpad said there were a hundred or so people using my builds.) https://launchpad.net/~foresto/+archive/winepatched/ I was pleasantly surprised to find that a long-standing Guild Wars visual bug (reproducible by changing between armor and town clothes) seems to be fixed by your latest code. Here's the bug report: http://bugs.winehq.org/show_bug.cgi?id=29872

1 0

Fwd: nearly all applications immediately crash
by MadLoisae＠gmx.net Jan. 11, 2014

Jan. 11, 2014

Hello wine-users, have an issue with my wine. My system is debian wheezy x86_64 with installed multiarch and wine-bin:i386, the packages are all from debian so it's wine version 1.4.1. nearly all applications crash immediately on useraction. the attached output was from most recent notepad++ installer - I can start it and click on next, I can see the license a very short moment and the installer disappears with an error in console I started from. wine: Unhandled page fault on write access to 0x000000f9 at address 0x7bc4aa6b (thread 0009), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc4aa6b the attached output is with WINEDEBUG=+relay if I copy a windows-installed Notepad++ to program directory and start it from there, I can open files and immediately it crashes. Sometimes the text is displayed, if I then scroll or do anything in program it ... crashes. :-/ I tried so far some gdi based winetricks, also I tried several times purging wine complete (including removing .wine), did not help. my system is headless, no monitor attached. vncserver runs on it, icewm as window manager. any ideas? Thanks! Alois

1 0

Re: iphlpapi: Return error for IP address with value zero in IcmpSendEcho
by Bruno Jesus Jan. 11, 2014

Jan. 11, 2014

Hi, Alexandre. I see this patch is pending and unfortunately it's not obvious to me what the reason is. The IP 0.0.0.0 need to be stopped otherwise linux will turn it into 127.0.0.1 and successfully ping it. Best wishes, Bruno On Thu, Jan 9, 2014 at 8:45 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > I missed the function name in the subject. Please ignore 101595. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=33272

1 0

Command Stream Update
by Stefan Dösinger Jan. 10, 2014

Jan. 10, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I have published an update to the command stream patches from September. The code is available on Github at https://github.com/stefand/wine (direct git url at https://github.com/stefand/wine) A small change summary: *) Tons of bug fixes. *) Dynamic surface maps. This improves World of Warcraft and many other games. *) The code avoids acquiring a GL context on the main thread, with few exceptions. This improves stability on all drivers, especially on fglrx. *) This version essentially matches the command stream code we shipped in CrossOver 13, just applied on top of Wine. *) The Wine version this tree is based on is the git head from this evening, 460991a8. As with the last version you have to set HKEY_CURRENT_USER/Software/Wine/Direct3D/CSMT="enabled" to use it. You should disable StrictDrawOrdering because it is no longer needed with CSMT on. I plan to push updates to this repository at irregular intervals. I probably won't send an announcement to wine-devel every time I do this. I also don't promise any schedule - it mostly depends on how busy I am with other work and how difficult the rebases are. Enjoy, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzHIsAAoJEN0/YqbEcdMw10wQAIBZ1LuNK4By0WLZzujwww3Z mZjd/kgux13THVtTzVoxVL38nzhOxIuGV0B5P6yoXJlKpxILSCdjr208EWMf+qo7 j4m3DGibrSrjPOCog4hXQeMrn2YjHC2BnFtDIiCYKq33ZPjJ60mSKEkpOzzbeEa8 7C7l9Y+mGKHQl6WViUp7HMoxFo3irZ1DCxRiDiOcFXdQhOZEpuuClB+vabUh15OH 3iNQdAwIiH9YZk9ir7nF5zcbnnLJGNjKNNUPEPu91P1PQ9LdM3zNqz7jU2Klo0Kl 7ZA+O6JVHSuWw04w1Lz6UM7Exu1dY6hRL9BfZQxodBOXtC0NwqIMbeW0bKn1VMEL cF4a+3sqGTJhni0dITEP1BzqmZH3sqYBPuOCb244+UOYwUjLTtx2QcASE3khb8D8 XVry6zrGJl1t1WzwPC/SK6/IOWHhvcznX+JeoYQiNIfOuFUsoVjKcswDxDLLi/+0 qUSpdWvI9fWy/udpaJoemspX0fjvNud6TcdLA/hHvfpoa6+fbHEJV+EC0M6PHFw8 RZ6Hi3VTlg0FBKYqowarqjjYNAxYWecTo9LKjMYTzFVpH4fTKcZUOpMdV+A2sRvv F0Hy0beXyih+Q03HwKmIbWQqWME1Fr62iCa88uO6leT4tPJ5SG3oZ2Reb2zmvFJq QbfNO3JMTqTqrXyUcsQj =dysQ -----END PGP SIGNATURE-----

3 8

Re: [website] Make https for wiki
by Jeremy Newman Jan. 10, 2014

Jan. 10, 2014

We cannot apply this patch until the Wiki has a certificate and has been setup with an SSL vhost. -N On 01/10/2014 08:10 AM, Andrey Gusev wrote: > This should fix bug http://bugs.winehq.org/show_bug.cgi?id=34443

1 0

Re: ws2_32/tests: Add a trailing '\n' to a win_skip() call.
by Marvin Jan. 10, 2014

Jan. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4157 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [2/2] dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo (try 2)
by Bruno Jesus Jan. 10, 2014

Jan. 10, 2014

On Fri, Jan 10, 2014 at 5:38 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Remove pointer checks > > Changelog: > dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo > Hi, I'm not used to review patches but please take a look at the points below. + if(This->peername) + HeapFree(GetProcessHeap(), 0, This->peername); + if(This->data) + HeapFree(GetProcessHeap(), 0, This->data); + You don't need to check for NULL. + len = lstrlenW(pdpnPlayerInfo->pwszName); + This->peername = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + memcpy(This->peername, pdpnPlayerInfo->pwszName, len * sizeof(WCHAR)); If peername is a string don't you need a len + 1 to mark NULL in the end? I'm not sure but since you can use lstrlenW can't you use heap_strdupW? + This->data = HeapAlloc(GetProcessHeap(), 0, pdpnPlayerInfo->dwDataSize); + memcpy(This->data, pdpnPlayerInfo->pvData, pdpnPlayerInfo->dwDataSize); Don't you need to store the dwDataSize in datasize you created in the struct? > Best Regards > Alistair Leslie-Hughes > Best regards, Bruno

1 0

Re: [2/2] dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo
by Nikolay Sivov Jan. 10, 2014

Jan. 10, 2014

On 1/10/2014 11:18, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo > > > Best Regards > Alistair Leslie-Hughes > > + if(This->peername) > + HeapFree(GetProcessHeap(), 0, This->peername); > + if(This->data) > + HeapFree(GetProcessHeap(), 0, This->data); > + You don't need to check for NULL.

1 0

Re: [PATCH 1/2] ddraw: Make DirectDrawEnumerateEx only enumerate secondary display devices when requested.
by Henri Verbeet Jan. 9, 2014

Jan. 9, 2014

I think this looks ok in principle, but a test wouldn't hurt.

2 3

Re: Assorted spelling fixes
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4101 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

Re: Command Stream Update
by Yuri Shishenko Jan. 9, 2014

Jan. 9, 2014

Civilization V has performance regression with this wine version. It shows less FPS than unpatched wine-1.7.10: 20 FPS on maximum camera distance while with unpatched wine it shows 40-50 FPS. My PC specs: openSUSE 13.1, linux 3.12.6 x86_64, nVidia GTX660 with 331.20 driver, Intel Core I5-3570k.

1 0

Re: [PATCH 4/5] d3dx9_36/tests: Use a window with a non-zero size.
by Henri Verbeet Jan. 9, 2014

Jan. 9, 2014

On 9 January 2014 13:43, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > WS_SYSMENU | WS_POPUP follows the existing code in D3DXCreateBoxTest, > which is the only test that created a useable device on my system. I think you might as well just use WS_OVERLAPPEDWINDOW like e.g. the d3d9 tests do, but I don't care that much.

1 0

Re: [PATCH 6/6] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger Jan. 9, 2014

Jan. 9, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-09 12:17, schrieb Henri Verbeet: > + hr = IDirectDrawSurface7_GetAttachedSurface(surface, &caps, > &tmp); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr > %#x.\n", hr); + hr = IDirectDrawSurface7_GetColorKey(tmp, > DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got > unexpected hr %#x, i %u.\n", hr, i); + + > color_key.dwColorSpaceLowValue = 0x0000ff00; + > color_key.dwColorSpaceHighValue = 0x0000ff00; + hr = > IDirectDrawSurface7_SetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to set color key, hr > %#x.\n", hr); + memset(&color_key, 0, sizeof(color_key)); + > hr = IDirectDrawSurface7_GetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to get color key, hr > %#x.\n", hr); + ok(color_key.dwColorSpaceLowValue == 0x0000ff00, > "Got unexpected value 0x%08x.\n", + > color_key.dwColorSpaceLowValue); + > ok(color_key.dwColorSpaceHighValue == 0x0000ff00, "Got unexpected > value 0x%08x.\n", + color_key.dwColorSpaceHighValue); + > + IDirectDrawSurface_Release(tmp); Did you mean to call SetColorKey and GetColorKey on tmp instead of surface here? For the sake of completion it might be interesting to test SetColorKey on cube textures. 5 of the faces are attached to a root surface but aren't mipmap sublevels. (I guess it'll still return DDERR_NOTONMIPMAPSUBLEVEL.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzpDjAAoJEN0/YqbEcdMwyl0P/3OHO0kK93dh6XdY1RU9IvNv BASe8YHhv1a6rRxYNGDzGoX5bsnefWLcqUnsWsGGjlxdA13BxAB4NCenaMecu49v d3egCH547Bd94K/9wqqlDxl+aEe0Hh86Ig9t0LNBuruNh1hNKTG9OdohzJBuX1VD TcVYRv6S8wEwM2Gb24RL8wN359497vn58G3fAVxK7PiK/edqxlDTg+6oi6P0/L+x HLGFlSVL9bgtxpwAUVh3i9SRsnA6iS07qPmSHOXdoCz/OhoY29Lx7HLFRCOgUbJS XAo00HKWP+qB4myqt3Iir9QgtiFLFZiyBBn0HQQEWGeRsDpZTazH/EMZrbUPhP03 f9AiW/r7XX5fOoRG5HBv7i/eXdOw6XexVLEyXb57sEilNJfBF3ux2wDw/E34AiGT wUTkgY2VwjgaxNl022qsFYz6fboORwbQm0VyvWzxbKw7326pdt6Y3Q2WTvPEQ5Rk JvlVJ8McRzkrYU5hXjRW1D7/2rVmV8z+xGGi6IU1JoS3PBWIYMKjUDRlFg0n+JQG UzLnJcnxm/js8Ah4R8MWje1v4cq3TlKnc7WrMIwNtu3Wmvwjo34s4A84xdVPneY/ jIqgUGFBOeH/XnK+FAdU+ZFuUn4k/ttVNOuSrPe5HsZxc1uxGnec5OtuZB8FTjFH EH0rn+AxEiyaGPON+4w6 =GtY2 -----END PGP SIGNATURE-----

2 2

Re: [PATCH 5/6] ddraw: Return DDERR_NOTONMIPMAPSUBLEVEL for ddraw_surface7_SetColorKey() on mipmap sub levels.
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4096 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH 4/5] devenum: Make CLSID_VideoCompressorCategory a special category.
by Alexandre Julliard Jan. 9, 2014

Jan. 9, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/devenum/createdevenum.c | 1 + > 1 file changed, 1 insertion(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dxdiagn.dll -p dxdiagn_test.exe.so provider && touch provider.ok provider.c:84: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:88: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:125: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:128: Tests skipped: IDxDiagProvider::Initialize failed make: *** [provider.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32/tests: Add broken for a WSALookupServiceBegin test in NT
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4089 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (174): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:566: Test failed: oob_server (964): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 5/5] devenum: Added more strict CLSID_VideoCompressorCategory test.
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4077 Your paranoid android. === w2008s64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found === w7pro64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found

1 0

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4071 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH] oleaut32: Mask out certain features on array copy
by Dmitry Timoshkov Jan. 8, 2014

Jan. 8, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +/* features listed here are not propagated to newly created array or data copy > + created with SafeArrayCopy()/SafeArrayCopyData() */ > +static const USHORT ignored_copy_features = > + FADF_AUTO | > + FADF_STATIC | > + FADF_EMBEDDED | > + FADF_FIXEDSIZE | > + FADF_CREATEVECTOR | > + FADF_DATADELETED; ... > - (*ppsaOut)->fFeatures = psa->fFeatures & ~FADF_CREATEVECTOR; > + (*ppsaOut)->fFeatures = psa->fFeatures & ~(FADF_CREATEVECTOR|ignored_copy_features); ignored_copy_features already includes FADF_CREATEVECTOR. > --- a/dlls/oleaut32/tests/safearray.c > +++ b/dlls/oleaut32/tests/safearray.c > @@ -57,6 +57,14 @@ static BOOL has_i8; > /* Has INT_PTR/UINT_PTR type? */ > static BOOL has_int_ptr; > > +static const USHORT ignored_copy_features[] = > + { > + FADF_AUTO, > + FADF_STATIC, > + FADF_EMBEDDED, > + FADF_FIXEDSIZE > + }; Tested and actually ignored flags do not match. Either the test is not complete or the ignored list includes too much. -- Dmitry.

2 1

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger Jan. 8, 2014

Jan. 8, 2014

Am 08.01.2014 um 10:56 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > + for (i = 0; i < 7; ++i) > + { > + hr = IDirectDrawSurface_GetAttachedSurface(mipmap, &caps, &tmp); > + ok(SUCCEEDED(hr), "Failed to get attached surface, i %u, hr %#x.\n", i, hr); > + hr = IDirectDrawSurface_GetColorKey(tmp, DDCKEY_SRCBLT, &color_key); > + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x, i %u.\n", hr, i); > + IDirectDrawSurface_Release(mipmap); > + mipmap = tmp; > + } What is the 3D rendering and blitting behavior of the mipmap sublevels? Does an application have to set the color key on all surfaces to get proper color keying on a mipmapped texture, or do the sublevels use the color key from the root surface?

2 6

Re: dpnet: Add stubbed interface IDirectPlay8Server
by Michael Stefaniuc Jan. 8, 2014

Jan. 8, 2014

Hello Alistair, On 01/08/2014 06:26 AM, Alistair Leslie-Hughes wrote: > Changelog: > dpnet: Add stubbed interface IDirectPlay8Server > diff --git a/dlls/dpnet/dpnet_private.h b/dlls/dpnet/dpnet_private.h > index 72012cd..5195d51 100644 > --- a/dlls/dpnet/dpnet_private.h > +++ b/dlls/dpnet/dpnet_private.h > @@ -37,6 +37,7 @@ typedef struct IDirectPlay8AddressImpl IDirectPlay8AddressImpl; > typedef struct IDirectPlay8LobbiedApplicationImpl IDirectPlay8LobbiedApplicationImpl; > typedef struct IDirectPlay8PeerImpl IDirectPlay8PeerImpl; > typedef struct IDirectPlay8ThreadPoolImpl IDirectPlay8ThreadPoolImpl; > +typedef struct IDirectPlay8ServerImpl IDirectPlay8ServerImpl; please add the struct directly to server.c as it is used only there. > +static ULONG WINAPI IDirectPlay8ServerImpl_AddRef(IDirectPlay8Server *iface) > +{ > + IDirectPlay8ServerImpl *This = impl_from_IDirectPlay8Server(iface); > + ULONG refCount = InterlockedIncrement(&This->ref); > + > + TRACE("(%p)->(ref before=%u)\n", This, refCount - 1); The standard to which Wine moves is to print the current refcount. See http://wiki.winehq.org/COMGuideline under "COM aggregation" for sample AddRef / Release functions. > +HRESULT DPNET_CreateDirectPlay8Server(LPCLASSFACTORY iface, LPUNKNOWN punkOuter, REFIID riid, LPVOID *ppobj) IClassFactory* and IUnknown* are much nicer. > +{ > + IDirectPlay8ServerImpl *server; > + > + TRACE("(%p, %s, %p)\n", punkOuter, debugstr_guid(riid), ppobj); > + > + server = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectPlay8ServerImpl)); > + if (!server) > + { > + *ppobj = NULL; > + return E_OUTOFMEMORY; > + } > + server->IDirectPlay8Server_iface.lpVtbl = &DirectPlay8ServerVtbl; > + server->ref = 1; > + > + *ppobj = (LPVOID*)&server->IDirectPlay8Server_iface; This will fail to fail for an unsupported riid. I have added the correct way to the COMGuideline wiki page. thanks bye michael

1 0

Re: dssenh/tests: Added Cylink Mek algorithm definition and crypto provider algorithm tests for dssenh.
by Alexandre Julliard Jan. 8, 2014

Jan. 8, 2014

Marek Chmiel <kcmark(a)gmail.com> writes: > + while(GetLastError() != ERROR_NO_MORE_ITEMS) > + { > + SetLastError(0xdeadbeef); > + dataLen = sizeof(dataBuffer); > + > + result = CryptGetProvParam(hProv, PP_ENUMALGS_EX, dataBuffer, &dataLen, flag); > + ok(result || (!result && GetLastError() == ERROR_NO_MORE_ITEMS), > + "Failed to get parameter, got %x\n", GetLastError()); > + > + pointer = dataBuffer; > + algid = *(ALG_ID *)pointer; pointer += sizeof(ALG_ID); > + defaultLen = *(DWORD *)pointer; pointer += dwIncrement; It doesn't make sense to test last error before the first call, or to test the buffer contents on failure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA (try 3)
by Nikolay Sivov Jan. 8, 2014

Jan. 8, 2014

On 1/8/2014 12:47, Zhenbo Li wrote: > try 3: > Add 'static' in my code > I forgot to call test_SHGetPathFromIDListA() in try2 > Check GetLastError() as well > try 2: > Move code to string.c to avoid creating a new file. > Avoid malloc() and free(). > > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/string.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > +static void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + char pszPath[MAX_PATH]; > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + ok(GetLastError() == ERROR_PROC_NOT_FOUND, > + "Bad GetLastError = %d\n", GetLastError()); > +} > + You need to set last error to something like 0xdeadbeef, your test suggest that this call doesn't set it. I guess you're trying to test return value only, but it could be interesting to test what happens to path buffer too. P.S. please avoid psz* style prefixes in names.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA (try 3)
by Marvin Jan. 8, 2014

Jan. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4066 Your paranoid android. === wxppro (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === wvista (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w2008s64 (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w7pro64 (32 bit string) === string.c:107: Test failed: Bad GetLastError = 1114 === w2008s64 (64 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w7pro64 (64 bit string) === string.c:107: Test failed: Bad GetLastError = 1114

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Dmitry Timoshkov Jan. 8, 2014

Jan. 8, 2014

Zhenbo Li <litimetal(a)gmail.com> wrote: > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + char pszPath[MAX_PATH]; > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > +} 1. the test should be 'static'. 2. who is supposed to call this test? 3. it would be ineteresting to see whether the tested API should set an error code or somehow indicate a reason of the failure. -- Dmitry.

2 1

WineHQ Downtime
by Jeremy Newman Jan. 7, 2014

Jan. 7, 2014

Starting tomorrow at 10:00 CST we will be performing updates and maintenance to the WineHQ server. The service window should be around 2 hours at most. Various services will experience outages during this time frame. This will affect www.winehq.org, appdb.winehq.org, bugs.winehq.org, forum.winehq.org, source.winehq.org, mailing lists, and GIT. wiki.winehq.org will not be affected.

3 4

Re: [PATCH 1/5] wined3d: Check parameters directly in wined3d_surface_update_desc.
by Henri Verbeet Jan. 7, 2014

Jan. 7, 2014

On 7 January 2014 13:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/surface.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 2fca299..9155c6b 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2810,15 +2810,17 @@ HRESULT CDECL wined3d_surface_update_desc(struct wined3d_surface *surface, > struct wined3d_device *device = surface->resource.device; > const struct wined3d_gl_info *gl_info = &device->adapter->gl_info; > const struct wined3d_format *format = wined3d_get_format(gl_info, format_id); > - UINT resource_size = wined3d_format_calculate_size(format, device->surface_alignment, width, height, 1); > BOOL create_dib = FALSE; > HRESULT hr; > > TRACE("surface %p, width %u, height %u, format %s, multisample_type %#x, multisample_quality %u.\n", > surface, width, height, debug_d3dformat(format_id), multisample_type, multisample_type); > > - if (!resource_size) > + if (!width || !height || !format) That's not quite equivalent. For example, a format like WINED3DFMT_NVDB has a zero format->byte_count.

2 1

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Huw Davies Jan. 7, 2014

Jan. 7, 2014

On Tue, Jan 07, 2014 at 02:33:32PM +0100, Ralf Habacker wrote: > @@ -1327,6 +1327,20 @@ BOOL WINAPI GetTextExtentExPointW( HDC hdc, LPCWSTR str, INT count, INT max_ext, > } > } > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } Does Windows really do this only in the same-scaled, non-sheared case? Huw.

1 0

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Nikolay Sivov Jan. 7, 2014

Jan. 7, 2014

On 1/7/2014 17:33, Ralf Habacker wrote: > This patch detects operational condition first and then removes > temporary rotation from the world transform. > Bug: http://bugs.winehq.org/show_bug.cgi?id=33190 > --- > dlls/gdi32/font.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } > + Flag really means do we need to restore transform or not. > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED && exclude_rotation == TRUE ) > + { > + SetWorldTransform( hdc, &old ); > + } > + Doesn't look like you need to check a mode again.

1 0

Re: [1/4] gid32: Add matrix helper functions.
by Nikolay Sivov Jan. 7, 2014

Jan. 7, 2014

On 1/7/2014 17:31, Ralf Habacker wrote: > Contains basic functions required by further patches > --- > dlls/gdi32/dibdrv/graphics.c | 49 > ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > That should be merged with a first patch that uses it. > +/* > + check matrix for condition > +*/ > +BOOL hasRotatedAndSameScaledMatrixOnly(XFORM *xform) > +{ > + return xform->eM11 == xform->eM22 && > + -xform->eM21 == xform->eM12; > +} > + Comment is telling nothing, 'xform' should be const probably. > + double determinant = 0; > + > + /* xform = xfrom-transposed * xform */ > + xform->eM11 = sqrt( xform->eM11 * xform->eM11 + xform->eM21 * xform->eM21 ); > + xform->eM22 = sqrt( xform->eM12 * xform->eM12 + xform->eM22 * xform->eM22 ); > + xform->eM12 = 0; > + xform->eM21 = 0; > + xform->eDx = 0; > + xform->eDy = 0; > + > + if ( rotation_and_translation == NULL ) > + return TRUE; > + > + determinant = xform->eM11 * xform->eM22; > + > + inverse_matrix_scale.eM11 = xform->eM22 / determinant; Is it possible to get 0 determinant here? Function never returns FALSE, so return value is useless. Also please follow function and variable naming conventions used in this file.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Nikolay Sivov Jan. 7, 2014

Jan. 7, 2014

On 1/7/2014 16:08, Zhenbo Li wrote: > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/pidl.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 dlls/shell32/tests/pidl.c > Please use some existing file. > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + LPCSTR pszPath; > + > + pszPath = malloc(MAX_PATH); > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + > + free((void *)pszPath); > +} > + You don't need to allocate it here, even if had to Heap* functions should be used.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Marvin Jan. 7, 2014

Jan. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4048 Your paranoid android. === wxppro (32 bit pidl) === No test summary line found === wvista (32 bit pidl) === No test summary line found === w2008s64 (32 bit pidl) === No test summary line found === w7pro64 (32 bit pidl) === No test summary line found === w2008s64 (64 bit pidl) === No test summary line found === w7pro64 (64 bit pidl) === No test summary line found

1 0

Re: user32/tests: Use BOOL type where appropriate
by Marvin Jan. 7, 2014

Jan. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4032 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

1 0

Re: [2/2] ws2_32/tests: Show that the last WSACleanup must destroy sockets
by Marvin Jan. 6, 2014

Jan. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4029 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4220C0

1 0

Re: [1/2] ws2_32/tests: Add some FIONREAD tests
by Marvin Jan. 6, 2014

Jan. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4028 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

[PATCH] Add support for GNU/Hurd
by Svante Signell Jan. 6, 2014

Jan. 6, 2014

Hi, Currently wine-1.6.1 FTBFS on Debian GNU/Hurd, see https://buildd.debian.org/status/fetch.php?pkg=wine&arch=hurd-i386&ver=1.6.… Attached is a patch enabling the build: - dlls/ntdll/directory.c: Define a character array on the heap of size 4096 instead of using PATH_MAX, which is not defined for GNU/Hurd. This approach was used in dlls/ntdll/file.c:server_get_unix_name() where an array of size 1024 was defined. In case this solution is not OK, a fixed size array on the stack could be used, or as a last resort adding #ifndef PATH_MAX; #define PATH_MAX 4096 to that file (not recommended, at least from a GNU/Hurd aspect). - libs/wine/ldt.c: Add LDT support for GNU/Hurd - dlls/ntdll/signal_i386.c: Add i386 signal handling support for GNU/Hurd Applications tested so far (slow to start) include cmd, hostname, clock, winemine, wineconsole, notepad, wordpad and explorer. This patch is sent upstream on recommendation by the Debian Wine maintainers, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733605 Thanks!

3 7

Re: strmbase: Store BasePinFuncTable inside Base*PinFuncTable structs.
by Aric Stewart Jan. 6, 2014

Jan. 6, 2014

On 1/3/14, 10:08 AM, Jacek Caban wrote: > --- > dlls/amstream/mediastreamfilter.c | 15 +++++++-------- > dlls/qcap/avico.c | 32 ++++++++++++++------------------ > dlls/qcap/avimux.c | 32 ++++++++++++++------------------ > dlls/qcap/vfwcapture.c | 15 +++++++-------- > dlls/quartz/filesource.c | 15 +++++++-------- > dlls/quartz/parser.c | 15 +++++++-------- > dlls/strmbase/pin.c | 24 ++++++++++++------------ > dlls/strmbase/renderer.c | 17 ++++++++--------- > dlls/strmbase/transform.c | 30 ++++++++++++++---------------- > include/wine/strmbase.h | 7 +++++-- > 10 files changed, 95 insertions(+), 107 deletions(-) > Also just so you are aware, all the strmbase stuff is based off actual microsoft strmbase stuff for directshow http://msdn.microsoft.com/en-us/library/windows/desktop/dd318897%28v=vs.85%… Not that this patch specifically breaks that, I have not dug that much, but just so that you are aware of the base for the implementation. -aric

2 1

Re: [1/7] gdi32: Relax vertical face requirements.
by Dmitry Timoshkov Jan. 6, 2014

Jan. 6, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -2148,6 +2148,9 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_ > #endif /* HAVE_CARBON_CARBON_H */ > > do { > + const DWORD DBCS_MASK = 0x3e0000; dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000, I'd guess that one of these places needs to be fixed. -- Dmitry.

2 1

Build fixes for wine-1.6.1 (FreeType2)
by David Naylor Jan. 6, 2014

Jan. 6, 2014

Dear Wine-developers, On behalf of Gerald Pfeifer and the FreeBSD/Wine team I would like to report that wine-1.6.1 does not build against recent versions of FreeType2. This has been fixed in master in commit 67f9b6e3c5d2397446d39ab454f691c1ee46d2c0 by Alexandre Julliard. We would like to request this commit be back-ported to the stable branch. Regards, David P.S. I'm not on the mailing list, please CC me in related correspondence, thanks.

3 2

Re: msvcp: Return if module is not loaded (Coverity)
by Piotr Caban Jan. 6, 2014

Jan. 6, 2014

On 01/04/14 19:24, André Hentschel wrote: > 1147949 > --- > dlls/msvcp90/msvcp_main.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp_main.c b/dlls/msvcp90/msvcp_main.c > index 489aacb..d946f3b 100644 > --- a/dlls/msvcp90/msvcp_main.c > +++ b/dlls/msvcp90/msvcp_main.c > @@ -67,7 +67,14 @@ static void init_cxx_funcs(void) > { > HMODULE hmod = GetModuleHandleA( MSVCRT_NAME(_MSVCP_VER) ); > > - if (!hmod) FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + if (!hmod) > + { > + FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + MSVCRT_operator_new = NULL; > + MSVCRT_operator_delete = NULL; > + MSVCRT_set_new_handler = NULL; > + return; > + } If we want to handle GetModuleHandle failure we should probably fail to load msvcpXX.dll (I'm not sure if it may ever happen unless we forget to import proper msvcrXX dll in makefile).

1 0

Re: ws2_32: Fix FreeBSD compiling issue on ipx address structure
by Francois Gouget Jan. 6, 2014

Jan. 6, 2014

On Sun, 5 Jan 2014, Bruno Jesus wrote: > Manually tested on PC-BSD which also shows the issue. I think it would even work to compare sipx_network and sipx_node in one go. There is already code that copies them that way in ws_sockaddr_ws2u(): memcpy(&uipx->sipx_network,wsipx->sa_netnum,sizeof(uipx->sipx_network)+sizeof(uipx->sipx_node)); So we could do (compiles but not tested): diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 0391554..a92c5c3 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1473,7 +1473,10 @@ static BOOL is_sockaddr_bound(const struct sockaddr *uaddr, int uaddrlen) { static const struct sockaddr_ipx emptyAddr; struct sockaddr_ipx *ipx = (struct sockaddr_ipx*) uaddr; - return ipx->sipx_port || ipx->sipx_network || memcmp(&ipx->sipx_node, &emptyAddr.sipx_node, sizeof(emptyAddr.sipx_node)); + + /* compare sipx_network and sipx_node in one go to ease portability */ + return ipx->sipx_port || + memcmp(&ipx->sipx_network, &emptyAddr.sipx_network, sizeof(emptyAddr.sipx_network) + sizeof(emptyAddr.sipx_node)); } #endif case AF_INET6: But your patch works too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

1 0

Re: [PATCH] msvcp90: mark _invalid_parameter as noreturn (Coverity)
by Piotr Caban Jan. 6, 2014

Jan. 6, 2014

On 01/04/14 18:25, Marcus Meissner wrote: > 1147947 Dereference after null check > > after not seeing that _invalid_parameter will not return, > so just mark the function as such, perhaps coverity then notices it. The function may return if application sets custom invalid parameter handler. I guess it shouldn't be marked as DECLSPEC_NORETURN. Probably all the places where it's used should be changed to return an error after calling _invalid_parameter.

1 0

Re: Assorted spelling fixes
by Marvin Jan. 6, 2014

Jan. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4014 Your paranoid android. === wvista (32 bit render) === render.c:1276: Test failed: GetPosition failed: 00000001 === w7pro64 (64 bit render) === render.c:664: Test failed: Wait(event) after Stop gave 102

1 0

Re: DxDiag Demo Patch
by khuaja_lucky＠yahoo.com Jan. 5, 2014

Jan. 5, 2014

Sent from my iPhone

1 0

Re: bcrypt: Added BCryptGenRandom stub
by Dmitry Timoshkov Jan. 5, 2014

Jan. 5, 2014

Jascha Knack <jascha.knack(a)smail.inf.h-brs.de> wrote: > +NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE hAlgorithm, PUCHAR > pbBuffer, > + ULONG cbBuffer, ULONG dwFlags) > +{ > + FIXME("%08x, %08x, %08x, %08x - stub\n", hAlgorithm, pbBuffer, > cbBuffer, dwFlags); > + > + return ERROR_CALL_NOT_IMPLEMENTED; > +} If the API is supposed to return NTSTATUS it can't return a win32 error code. Also some of the printf format specifiers should be %p. P.S. Your mailer has mangled the patch. -- Dmitry.

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy Jan. 4, 2014

Jan. 4, 2014

On Sat, Jan 4, 2014 at 4:33 PM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > What do you mean saying 'to group together' ? I mean typo fixes in dll_A and dll_B should be in the same patch. -- Frédéric Delanoy

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Bruno Jesus Jan. 4, 2014

Jan. 4, 2014

On Sat, Jan 4, 2014 at 3:25 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Please ignore this patch, I didn't see Erich was trying to get in his interface change notifications patches. They are specially useful for a complete implementation of WSASLookupService*, when they get commited I'll be able to create a more complete test. Best wishes, Bruno

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy Jan. 4, 2014

Jan. 4, 2014

You'd probably want to group together all those typo/spelling patches. They aren't generally susceptible to breaking things. -- Frédéric Delanoy

1 0

Re: comctl32: Add opening and closing brackets and remove spaces
by Dmitry Timoshkov Jan. 4, 2014

Jan. 4, 2014

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > --- a/dlls/comctl32/animate.c > +++ b/dlls/comctl32/animate.c > @@ -499,7 +499,7 @@ static BOOL ANIMATE_GetAviInfo(ANIMATE_INFO *infoPtr) > > if ((ckMainRIFF.ckid != FOURCC_RIFF) || > (ckMainRIFF.fccType != mmioFOURCC('A', 'V', 'I', ' '))) { > - WARN("Can't find 'AVI ' chunk\n"); > + WARN("Can't find 'AVI' chunk\n"); This change is wrong. -- Dmitry.

1 0

Re: [7/7] gdi32: Improve vertical writing metrics.
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3982 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [6/7] gdi32/tests: Add tests for vertical writing metrics.
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3981 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [5/7] gdi32: Fix ABC metrics for rotated font.
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3980 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [4/7] gdi32/tests: Add more GetCharABCWidths tests for rotated font.
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3979 Your paranoid android. === wxppro (32 bit font) === font.c:1330: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0

1 0

Re: [4/4] ws2_32/tests: Add some FIONREAD tests
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3976 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3975 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)
by Dmitry Timoshkov Jan. 4, 2014

Jan. 4, 2014

Zhenbo Li <litimetal(a)gmail.com> wrote: > + > + err = GetLastError(); > + ok ( handle != INVALID_HANDLE_VALUE, "FindFirstFile on %s failed\n", buffer2 ); > + ok ( !err , "FindFirstFile failed, Error number %d\n", err ); > + This block looks like an orphaned part of some removed test. -- Dmitry.

2 2

Question about test_RemoveDirectory()
by Zhenbo Li Jan. 4, 2014

Jan. 4, 2014

Hello, I found that test_RemoveDirectory() is in dlls/kernel32/tests/file.c, while RemoveDirectoryA() and RemoveDirectoryW() are in dlls/kernel32/path.c I checked git log, and found that they came from commit ad9b79932410f7c, Reimplemented CreateDirectoryW and RemoveDirectoryW using ntdll functions. Should I move test_RemoveDirectory() to dlls/kernel32/tests/path.c? Thanks. -- Have a nice day! Zhenbo Li

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 2)
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3973 Your paranoid android. === wxppro (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === wvista (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0

1 0

Re: ntdll/tests: Add test for deleting via NtOpenFile
by Marvin Jan. 4, 2014

Jan. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3962 Your paranoid android. === w7pro64 (32 bit file) === file.c:331: Test failed: open L"system32" failed c000003b file.c:338: Test failed: open L"SYSTEM32" failed c000003b file.c:346: Test failed: open L"\\SYSTEM32" failed c0000034 file.c:356: Test failed: open L"\\SYSTEM32" failed c000003b

2 1

Re: [PATCH 5/5] d3dx9_36/tests: Use NAN.
by Francois Gouget Jan. 3, 2014

Jan. 3, 2014

On Thu, 2 Jan 2014, Stefan Dösinger wrote: [...] > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -4800,7 +4800,7 @@ static void test_create_skin_info(void) [...] > - exp_weights[1] = 0.0f / 0.0f; /* NAN */ > + exp_weights[1] = NAN; This patch breaks the compilation on Solaris because it does not define NAN (except in math_c99.h but we cannot use that, see below). But independently from that I think it's wrong because one should be able to compile the conformance tests on Windows. This means we cannot use things like config.h or port.h and should only use stuff that's defined in Windows headers. But as far as I can tell the Windows SDK does not define NAN. There is a definition of NAN in the CRT xmath.h header but Wine does not have that header and we're obviously not including it here. So one solution would be to revert the patch. Another would be to copy wine/port.h's __port_nan() definition. Yet another might be to add xmath.h and a dependency on msvcrt.dll. But maybe there's a better way still? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

2 2

Re: strmbase: Store BasePinFuncTable inside Base*PinFuncTable structs.
by Alexandre Julliard Jan. 3, 2014

Jan. 3, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/amstream/mediastreamfilter.c | 15 +++++++-------- > dlls/qcap/avico.c | 32 ++++++++++++++------------------ > dlls/qcap/avimux.c | 32 ++++++++++++++------------------ > dlls/qcap/vfwcapture.c | 15 +++++++-------- > dlls/quartz/filesource.c | 15 +++++++-------- > dlls/quartz/parser.c | 15 +++++++-------- > dlls/strmbase/pin.c | 24 ++++++++++++------------ > dlls/strmbase/renderer.c | 17 ++++++++--------- > dlls/strmbase/transform.c | 30 ++++++++++++++---------------- > include/wine/strmbase.h | 7 +++++-- > 10 files changed, 95 insertions(+), 107 deletions(-) There are other users, like winegstreamer and wineqtdecoder. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add test for FindFirstFileA()
by Marvin Jan. 3, 2014

Jan. 3, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3963 Your paranoid android. === wxppro (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\fooD.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === wvista (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\fooFB6A.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w2008s64 (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\foo9FA.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w7pro64 (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\foo580A.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w2008s64 (64 bit file) === file.c:2452: Test failed: FindFirstFile on C:\foo93F.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w7pro64 (64 bit file) === file.c:2452: Test failed: FindFirstFile on C:\fooF4B6.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267

1 0

Re: [PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection (try2)
by Dmitry Timoshkov Jan. 3, 2014

Jan. 3, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static inline ULONG get_refcount(IUnknown *iface) > +{ > + ULONG ref = IUnknown_AddRef(iface); > + IUnknown_Release(iface); > + return ref-1; > +} This one still looks somewhat strange. Why not do something more straightforward like the following one? static inline ULONG get_refcount(IUnknown *iface) { IUnknown_AddRef(iface); return IUnknown_Release(iface); } -- Dmitry.

1 0

Re: [PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection
by Dmitry Timoshkov Jan. 3, 2014

Jan. 3, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static inline ULONG get_refcount(IUnknown *iface) > +{ > + ULONG ref = IUnknown_AddRef(iface); > + IUnknown_Release(iface); > + return ref; > +} This implementation may lead to wrong conclusions. -- Dmitry.

2 3

How to bisect the 1.6.x series of commits
by Alan W. Irwin Jan. 3, 2014

Jan. 3, 2014

I have bisected Wine regressions several times in the last year following the cookbook in http://wiki.winehq.org/RegressionTesting. Those bisections were for the principal branch (or whatever you call it) of development. How do you do similar bisections for the branch of development from 1.6 to 1.6.1? I need the name of that branch of development and how you specify it to the bisect process. Sorry for the git newbie question, but following the above cookbook has been essentially my only git experience to date. The reason I am asking about bisecting from 1.6 to 1.6.1 is I have recently found some fairly strong evidence that there is an important regression in behavior between 1.6-rc4 and 1.6.1. I have used Wine 1.6-rc4 with a lot of success as a test platform for MinGW/MSYS PLplot builds and tests, but when I recently tried 1.6.1, my usual parallel tests of PLplot software failed with an error indicating plot devices (small dll's) cannot be dynamically loaded by the PLplot principal library for that version of Wine. (The problem disappears if I do the tests sequentially for 1.6.1, but I obviously want to avoid that method of testing because it doubles the test time for my two-cpu PC.) The tests of 1.6-rc4 and 1.6.1 were quite similar but not absolutely identical so I do have to confirm the regression in behaviour for 1.6.1 with absolutely identical tests. But assuming I can do that, then I still have to discover if the problem occurred for 1.6. If so, the bisection needs to be an ordinary principal branch one that I am already familiar with between 1.6-rc4 and 1.6, but if not it needs to follow the 1.6.x development branch between 1.6 an 1.6.1. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

4 4

Re: advapi32/tests: Use BOOL type where appropriate
by Dmitry Timoshkov Jan. 3, 2014

Jan. 3, 2014

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c > index 9f1e611..232a729 100644 > --- a/dlls/advapi32/tests/security.c > +++ b/dlls/advapi32/tests/security.c > @@ -4526,13 +4526,14 @@ static void test_mutex_security(HANDLE token) > STANDARD_RIGHTS_ALL | MUTEX_ALL_ACCESS }; > static const struct > { > - int todo, generic, mapped; > + BOOL todo; > + int generic, mapped; > } map[] = > { > - { 1, GENERIC_READ, STANDARD_RIGHTS_READ | MUTANT_QUERY_STATE }, > - { 0, GENERIC_WRITE, STANDARD_RIGHTS_WRITE }, > - { 0, GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE }, > - { 0, GENERIC_ALL, STANDARD_RIGHTS_ALL | MUTANT_QUERY_STATE } > + { TRUE, GENERIC_READ, STANDARD_RIGHTS_READ | MUTANT_QUERY_STATE }, > + { FALSE, GENERIC_WRITE, STANDARD_RIGHTS_WRITE }, > + { FALSE, GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE }, > + { FALSE, GENERIC_ALL, STANDARD_RIGHTS_ALL | MUTANT_QUERY_STATE } > }; Please don't touch these tests, 'int' is intentionally used here, and 'BOOL' buys you nothing. It's better to actually fix the source of these todos and remove them altogether. -- Dmitry.

1 0

Re: ddraw/tests: Use BOOL type where appropriate
by Marvin Jan. 3, 2014

Jan. 3, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3950 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH] ntdll: Improve handling of THUMB_MOV32 relocations
by André Hentschel Jan. 2, 2014

Jan. 2, 2014

Am 02.01.2014 17:01, schrieb Martin Storsjo: > Since the delta variable actually is signed, the delta > 0xffff > condition could be false even if the high part of the delta > was nonzero, ending up with not updating the high half of the > relocation at all. > > Additionally, carry any overflow from the low word into the > high word delta. Hi, Do you have an App that triggers that? So you mean the case when the sign bit is used, e.g. 10101010b... Then the delta is negative, but is everything set correctly in the instruction? > --- > dlls/ntdll/loader.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index e0907e7..1f13424 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -2230,19 +2230,19 @@ IMAGE_BASE_RELOCATION * WINAPI LdrProcessRelocationBlock( void *page, UINT count > DWORD inst = *(INT_PTR *)((char *)page + offset); > DWORD imm16 = ((inst << 1) & 0x0800) + ((inst << 12) & 0xf000) + > ((inst >> 20) & 0x0700) + ((inst >> 16) & 0x00ff); > + int hi_delta; Why you're using int here? DWORD looks much better for this.

2 2

Re: msvcp80: Fix ostreambuf_iterator<char> structure definition
by Alexandre Julliard Jan. 2, 2014

Jan. 2, 2014

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcp90/ios.c | 88 > +++++++++++++++++++++++++++++++++++++------------- > dlls/msvcp90/msvcp90.h | 6 ++++ > 2 files changed, 72 insertions(+), 22 deletions(-) It breaks the Mingw build: locale.o:locale.c:(.text+0x94c): undefined reference to `_num_put_char_do_put_long(a)28' locale.o:locale.c:(.text+0x954): undefined reference to `_num_put_char_put_long(a)28' locale.o:locale.c:(.text+0x95c): undefined reference to `_num_put_char_do_put_ulong(a)28' locale.o:locale.c:(.text+0x964): undefined reference to `_num_put_char_put_ulong(a)28' locale.o:locale.c:(.text+0x96c): undefined reference to `_num_put_char_do_put_double(a)32' locale.o:locale.c:(.text+0x974): undefined reference to `_num_put_char_put_double(a)32' locale.o:locale.c:(.text+0x97c): undefined reference to `_num_put_char_put_ldouble(a)32' locale.o:locale.c:(.text+0x984): undefined reference to `_num_put_char_do_put_ptr(a)28' locale.o:locale.c:(.text+0x98c): undefined reference to `_num_put_char_put_ptr(a)28' locale.o:locale.c:(.text+0x994): undefined reference to `_num_put_char_do_put_int64(a)32' locale.o:locale.c:(.text+0x99c): undefined reference to `_num_put_char_put_int64(a)32' locale.o:locale.c:(.text+0x9a4): undefined reference to `_num_put_char_do_put_uint64(a)32' locale.o:locale.c:(.text+0x9ac): undefined reference to `_num_put_char_put_uint64(a)32' locale.o:locale.c:(.text+0x9b4): undefined reference to `_num_put_char_do_put_bool(a)28' locale.o:locale.c:(.text+0x9bc): undefined reference to `_num_put_char_put_bool(a)28' locale.o:locale.c:(.text+0xa0c): undefined reference to `_num_put_wchar_do_put_long(a)28' locale.o:locale.c:(.text+0xa14): undefined reference to `_num_put_short_do_put_long(a)28' locale.o:locale.c:(.text+0xa1c): undefined reference to `_num_put_wchar_put_long(a)28' locale.o:locale.c:(.text+0xa24): undefined reference to `_num_put_wchar_do_put_ulong(a)28' locale.o:locale.c:(.text+0xa2c): undefined reference to `_num_put_short_do_put_ulong(a)28' locale.o:locale.c:(.text+0xa34): undefined reference to `_num_put_wchar_put_ulong(a)28' locale.o:locale.c:(.text+0xa3c): undefined reference to `_num_put_wchar_do_put_double(a)32' locale.o:locale.c:(.text+0xa44): undefined reference to `_num_put_short_do_put_double(a)32' locale.o:locale.c:(.text+0xa4c): undefined reference to `_num_put_wchar_put_double(a)32' locale.o:locale.c:(.text+0xa54): undefined reference to `_num_put_wchar_put_ldouble(a)32' locale.o:locale.c:(.text+0xa5c): undefined reference to `_num_put_wchar_do_put_ptr(a)28' locale.o:locale.c:(.text+0xa64): undefined reference to `_num_put_short_do_put_ptr(a)28' locale.o:locale.c:(.text+0xa6c): undefined reference to `_num_put_wchar_put_ptr(a)28' locale.o:locale.c:(.text+0xa74): undefined reference to `_num_put_wchar_do_put_int64(a)32' locale.o:locale.c:(.text+0xa7c): undefined reference to `_num_put_short_do_put_int64(a)32' locale.o:locale.c:(.text+0xa84): undefined reference to `_num_put_wchar_put_int64(a)32' locale.o:locale.c:(.text+0xa8c): undefined reference to `_num_put_wchar_do_put_uint64(a)32' locale.o:locale.c:(.text+0xa94): undefined reference to `_num_put_short_do_put_uint64(a)32' locale.o:locale.c:(.text+0xa9c): undefined reference to `_num_put_wchar_put_uint64(a)32' locale.o:locale.c:(.text+0xaa4): undefined reference to `_num_put_wchar_do_put_bool(a)28' locale.o:locale.c:(.text+0xaac): undefined reference to `_num_put_short_do_put_bool(a)28' locale.o:locale.c:(.text+0xab4): undefined reference to `_num_put_wchar_put_bool(a)28' locale.o:locale.c:(.text+0xaec): undefined reference to `_time_put_char_do_put(a)36' locale.o:locale.c:(.text+0xaf4): undefined reference to `_time_put_char_put(a)36' locale.o:locale.c:(.text+0xafc): undefined reference to `_time_put_char_put_format(a)36' locale.o:locale.c:(.text+0xb5c): undefined reference to `_time_put_wchar_do_put(a)36' locale.o:locale.c:(.text+0xb64): undefined reference to `_time_put_wchar_put(a)36' locale.o:locale.c:(.text+0xb6c): undefined reference to `_time_put_wchar_put_format(a)36' collect2: ld returned 1 exit status -- Alexandre Julliard julliard(a)winehq.org

1 0

testbot problem
by Stefan Leichter Jan. 2, 2014

Jan. 2, 2014

Hello, i'm trying to understand why job 27632 did not build on the testbot. It builds fine for Linux 32/64 bit and Windows (make crosstest) on my computer. >From the build log it looks like a problem inside the Makefile (make: Nothing to be done for `all'.). Is there a way to access the Makefile after the job is finished? Regards Stefan

1 0

Better managing icons files names
by Pedro Henrique Lara Campos Jan. 2, 2014

Jan. 2, 2014

Can Wine or could it in newer versions, use a prefix for their icons, like wine_56BA_Tcharam.png, or maybe their own folder? My ~/.local/share/icons is like... full of bottles, every corner I look, I find an icon from wine :P

3 2

Re: [PATCH] msxml3: avoid double free of str (Coverity)
by Marvin Jan. 1, 2014

Jan. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3919 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

Re: [PATCH 12/21] kernel32: conditional variable support (try 6)
by Marcus Meissner Jan. 1, 2014

Jan. 1, 2014

Hmm, THis should have been patch 0021 instead of 0012 , please disregard. Ciao, Marcus On Wed, Jan 01, 2014 at 07:44:16PM +0100, Marcus Meissner wrote: > Hi, > > Additional tightening and cleaning of comments. > > After Alexandres last guidance ("no global allocation") > and some hours of hair pulling I now did a implementation > with just a linked list of waiters. > > variable->Ptr points to the head of this list. > > The bit 0 of variable->Ptr is used for atomic locking of > the list and also its content, avoiding need for a lock variable. > > Small issues: > We are busy waiting on the bit 0 lock, not the most performance > wise best thing. > > Ciao, Marcus > --- > dlls/kernel32/kernel32.spec | 4 ++ > dlls/kernel32/sync.c | 151 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 155 insertions(+) > > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 7779a75..e8d2bf0 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec > @@ -750,6 +750,7 @@ > @ stdcall InitOnceComplete(ptr long ptr) > @ stdcall InitOnceExecuteOnce(ptr ptr ptr ptr) > @ stdcall InitOnceInitialize(ptr) ntdll.RtlRunOnceInitialize > +@ stdcall InitializeConditionVariable(ptr) > @ stdcall InitializeCriticalSection(ptr) > @ stdcall InitializeCriticalSectionAndSpinCount(ptr long) > @ stdcall InitializeCriticalSectionEx(ptr long long) > @@ -1194,6 +1195,7 @@ > @ stdcall SignalObjectAndWait(long long long long) > @ stdcall SizeofResource(long long) > @ stdcall Sleep(long) > +@ stdcall SleepConditionVariableCS(ptr ptr long) > @ stdcall SleepEx(long long) > @ stdcall SuspendThread(long) > @ stdcall SwitchToFiber(ptr) > @@ -1263,6 +1265,8 @@ > @ stdcall WaitForSingleObjectEx(long long long) > @ stdcall WaitNamedPipeA (str long) > @ stdcall WaitNamedPipeW (wstr long) > +@ stdcall WakeAllConditionVariable (ptr) > +@ stdcall WakeConditionVariable (ptr) > @ stdcall WerRegisterFile(wstr long long) > @ stdcall WerRegisterMemoryBlock(ptr long) > @ stdcall WerRegisterRuntimeExceptionModule(wstr ptr) > diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c > index 3c9e42a..34f39cd 100644 > --- a/dlls/kernel32/sync.c > +++ b/dlls/kernel32/sync.c > @@ -2327,3 +2327,154 @@ __ASM_STDCALL_FUNC(InterlockedDecrement, 4, > "ret $4") > > #endif /* __i386__ */ > + > +/* See http://locklessinc.com/articles/mutex_cv_futex/ for a futex implementation > + * See http://www.cs.wustl.edu/~schmidt/win32-cv-1.html for various implementations > + * of pthread_cond_* with Win32 primitives. > + * See glibc/nptl/DESIGN-condvar.txt for the glibc implementation > + * > + * This implementation uses a linked list as waiter queue, and the list > + * and its content is locked for access via bit 0 of variable->Ptr. > + * The actual waiting is done using a Win32 Event. > + */ > + > +struct _condvar_intern { > + struct _condvar_intern *next; > + HANDLE event; > +}; > + > +/********************************************************************** > + * InitializeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI InitializeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + variable->Ptr = NULL; > +} > + > +/* > + * We lock the condition variable by setting bit 0 in variable->Ptr > + * atomically. We busy loop until we succeed and return the current value. > + * We also lock the empty list (NULL). > + * > + * List unlocking is done with "variable->Ptr = <retvalue>" > + */ > +static struct _condvar_intern* > +_lock_list (PCONDITION_VARIABLE variable) { > + struct _condvar_intern *oldvar, *var; > + > + do { > + __asm__ __volatile__("":::"memory"); > + var = variable->Ptr; > + if ((DWORD_PTR)var & 1) continue; /* locked already, retry. */ > + > + oldvar = InterlockedCompareExchangePointer (&variable->Ptr, (void*)((DWORD_PTR)var|1), var); > + if (oldvar == var) > + break; > + /* failed atomic locking, retry. */ > + } while (1); > + return var; > +} > + > +/********************************************************************** > + * WakeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI WakeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condvar_intern *var; > + > + if (!variable->Ptr) > + return; > + > + var = _lock_list (variable); > + if (!var) { > + variable->Ptr = NULL; > + return; > + } > + > + /* remove and wake up the first entry */ > + NtSetEvent (var->event, NULL); > + > + variable->Ptr = var->next; > +} > + > +/********************************************************************** > + * WakeAllConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI WakeAllConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condvar_intern *var; > + > + if (!variable->Ptr) > + return; > + > + var = _lock_list (variable); > + > + /* dequeue the whole waiter chain and wake it up */ > + while (var) { > + NtSetEvent (var->event, NULL); > + var = var->next; > + } > + > + variable->Ptr = NULL; > +} > + > +/********************************************************************** > + * SleepConditionVariableCS (KERNEL32.@) > + */ > +BOOL WINAPI SleepConditionVariableCS(PCONDITION_VARIABLE variable, > + LPCRITICAL_SECTION crit, DWORD timeout > +) > +{ > + struct _condvar_intern myself; > + struct _condvar_intern **xvar, *var; > + BOOL ret = TRUE; > + OBJECT_ATTRIBUTES attr; > + DWORD res; > + > + attr.Length = sizeof(attr); > + attr.RootDirectory = 0; > + attr.Attributes = OBJ_INHERIT; > + attr.ObjectName = NULL; > + attr.SecurityDescriptor = NULL; > + attr.SecurityQualityOfService = NULL; > + > + NtCreateEvent (&myself.event, EVENT_ALL_ACCESS, &attr, NotificationEvent, 0); > + myself.next = NULL; > + > + var = _lock_list (variable); > + /* Attach our stack based struct to the end of the list. > + * (at the end for fairness) > + */ > + xvar = &var; > + while (*xvar) > + xvar = &(*xvar)->next; > + *xvar = &myself; > + variable->Ptr = var; > + > + RtlLeaveCriticalSection(crit); > + > + res = WaitForSingleObject(myself.event, timeout); > + > + var = _lock_list (variable); > + > + /* Remove our entry */ > + xvar = (struct _condvar_intern **)&var; > + while (*xvar) { > + if (*xvar == &myself) { > + *xvar = (*xvar)->next; > + break; > + } > + xvar = &(*xvar)->next; > + } > + variable->Ptr = var; > + > + CloseHandle (myself.event); > + RtlEnterCriticalSection(crit); > + > + if (res == WAIT_TIMEOUT) { > + ret = FALSE; > + /* expected from caller, but not set by WaitForSingleObject */ > + SetLastError(ERROR_TIMEOUT); > + } > + return ret; > +} > -- > 1.7.10.4 > > > >

1 0

Re: [PATCH] msxml3: avoid double free of str (Coverity)
by Nikolay Sivov Jan. 1, 2014

Jan. 1, 2014

On 1/1/2014 22:15, Marcus Meissner wrote: > 1127305 Double free > --- > dlls/msxml3/tests/domdoc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index df11197..f653a8b 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -11047,7 +11047,6 @@ static void test_xmlns_attribute(void) > ok( hr == S_OK, "got 0x%08x\n", hr); > todo_wine ok( lstrcmpW(str, _bstr_("<Testing xmlns:dt=\"urn:schemas-microsoft-com:datatypes\" dt:dt=\"bin.base64\"/>")) == 0, > "got %s\n", wine_dbgstr_w(str)); > - SysFreeString(str); This is a correct fix technically, but it's better to remove second SysFreeString(), not this one. Speaking of style, I'd probably remove all 'if (hr == S_OK)' check, it never fails, or reduced a scope of 'str'.

1 0

Re: [PATCH] msxml3: avoid double free of str (Coverity)
by Marvin Jan. 1, 2014

Jan. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3918 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

about eventlog
by Akira Nakagawa Jan. 1, 2014

Jan. 1, 2014

I examined the design of RegistereventSource(). The return value type is HANDLE,but the details of it is unknown. However,I suppose,the code should be like this(I'm not good at coding of Win32) /****************************************************************************** * RegisterEventSourceW [ADVAPI32.@] * * See RegisterEventSourceA. */ HANDLE WINAPI RegisterEventSourceW( LPCWSTR lpUNCServerName, LPCWSTR lpSourceName ) { int arg_length,path_length; LPDWORD existance; LPWSTR reg_fullpath; LPWSTR filename; LPDWORD lptype; LPWSTR lpdata,gldata; HKEY hkeyp; HANDLE eventhandle; int number_of_entry,length_of_dat; FIXME("(%s,%s): stub\n", debugstr_w(lpUNCServerName), debugstr_w(lpSourceName)); if(lpUNCServerName!=NULL) { FIXME("lpUNCServerName:%s\nExecution in another server is not suppported.", debugstr_w(lpUNCServerName)); } else { existance = NULL; number_of_entry = 0; length_of_dat = 0; filename = (LPWSTR)"Application";//FIXME:this should be all of sub keies. reg_fullpath = lstrcatW((LPWSTR)"System\\CurrentControlSet\\Sevices\\Eventlog\\Application\\",lpSourceName); arg_length = lstrlenW(lpSourceName); RegCreateKeyExW(HKEY_LOCAL_MACHINE,reg_fullpath,0, NULL,REG_OPTION_NON_VOLATILE,KEY_READ,NULL,&hkeyp,existance);//Create or open key. RegQueryInfoKeyW(hkeyp,NULL,0,NULL,NULL,NULL,NULL, (LPDWORD)number_of_entry,NULL,(LPDWORD)length_of_dat,NULL,NULL); if(length_of_dat<2 || number_of_entry<2)//Key entry is void. return NULL; *lptype=(REG_SZ); RegQueryValueExW(hkeyp,(LPWSTR)"EventMessageFile",NULL,lptype,(LPBYTE)lpdata,(LPDWORD)path_length); RegCloseKey(hkeyp); eventhandle = GlobalAlloc(GHND,(arg_length+path_length)*sizeof(LPWSTR)); gldata=(LPWSTR)GlobalLock(eventhandle); //After that,store data follows:filename,file path,source name;I do not know how to. if(eventhandle==INVALID_HANDLE_VALUE) { ERR_(eventlog)("%s\n", debugstr_w(lpUNCServerName)); return NULL; } } return eventhandle; }

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (rebased).
by Marvin Jan. 1, 2014

Jan. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3915 Your paranoid android. === wxppro (32 bit sock) === sock.c:554: Test failed: oob_server (5a8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock.c:554: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:554: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0