January 2014 - Wine-Devel - list.winehq.org

Re: wininet: InternetGetConnectedStateExW must return TRUE for success
by Michael Stefaniuc Jan. 29, 2014

Jan. 29, 2014

Bruno, On 01/29/2014 02:27 AM, Bruno Jesus wrote: > Citavi relies on == TRUE comparison so return TRUE instead of != FALSE > > Fixes bug 17796 > > See http://bugs.winehq.org/show_bug.cgi?id=17796#c6 for AF analysis. > > > connect.txt > > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index a49026c..e0f8f1b 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -1219,7 +1219,7 @@ BOOL WINAPI InternetGetConnectedStateExW(LPDWORD lpdwStatus, LPWSTR lpszConnecti > WARN("always returning LAN connection.\n"); > *lpdwStatus = INTERNET_CONNECTION_LAN; > } > - return LoadStringW(WININET_hModule, IDS_LANCONNECTION, lpszConnectionName, dwNameLen); > + return LoadStringW(WININET_hModule, IDS_LANCONNECTION, lpszConnectionName, dwNameLen) ? TRUE : FALSE; we're getting rid of "? TRUE : FALSE" constructs in Wine as those are ugly and confusing. In this case a "return LoadStringW() != 0;" or even "> 0" is better as LoadString returns 0 on failure and a string length on success. bye michael

2 1

Re: [patch]: include : Add missing API to direct-x 9's shader header
by Henri Verbeet Jan. 29, 2014

Jan. 29, 2014

On 28 January 2014 16:13, Kai Tietz <ktietz70(a)googlemail.com> wrote: > Resent patch without inlining. > Well, inline is prefered, but using git send-email makes it much easier to not mess that up. > +#define D3DXCONSTTABLE_LARGEADDRESSAWARE»······ 0x20000 You have a stray tab here. > -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b); > +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7, 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1); I may not have explicitly said this in my previous mail about this patch, but I think the headers should be consistent. So if you make this change, you can't keep D3DX_SDK_VERSION at 36. If you bump it to 43, there may be changes to other interfaces you need to make as well. This could also have consequences for the actual implementation. > + STDMETHOD(GetConstantBuffer)(THIS_ LPD3DXBUFFER *ppConstantBuffer) PURE; Please avoid names like "ppConstantBuffer" and typedefs like LPD3DXBUFFER unless required for compatibility. So e.g.: + STDMETHOD(GetConstantBuffer)(THIS_ ID3DXBuffer **constant_buffer) PURE;

1 0

Re: gdiplus: Add tests for GetMetafileHeader functions.
by Marvin Jan. 28, 2014

Jan. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4513 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === wvista (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === w2008s64 (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === w7pro64 (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === w2008s64 (64 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279999 metafile.c:339: Test failed: Expected 72.000000, got 81.279999 metafile.c:372: Test failed: Expected 72.000000, got 81.279999 metafile.c:373: Test failed: Expected 72.000000, got 81.279999 metafile.c:399: Test failed: Expected 72.000000, got 81.279999 metafile.c:400: Test failed: Expected 72.000000, got 81.279999 === w7pro64 (64 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991

1 0

FOSDEM planning - last mailing list warning
by Jeremy White Jan. 28, 2014

Jan. 28, 2014

Hi folks, This is it. If you are not subscribed to the wineconf mailing list, but you're planning to be at FOSDEM, you are going to be left out of all the cool parties and fun. We'll move our chatter and planning exclusively to that email list. So, if you're coming to FOSDEM, and you didn't get two copies of this email, sign up for it now: http://www.winehq.org/mailman/listinfo/wineconf Cheers, Jeremy

1 0

Re: shell32/tests: Add test for GetLastError in shlfileop
by Dmitry Timoshkov Jan. 28, 2014

Jan. 28, 2014

Zhenbo Li <litimetal(a)gmail.com> wrote: > ret = SHFileOperationA(&shfo); > todo_wine > ok(ret == 1026 || > ret == ERROR_FILE_NOT_FOUND || /* Vista */ > broken(ret == ERROR_SUCCESS), /* NT4 */ > "Expected 1026 or ERROR_FILE_NOT_FOUND, got %d\n", ret); > + todo_wine > + ok(GetLastError() == 0 || > + broken(GetLastError()==ERROR_FILE_NOT_FOUND), /* win 2000 */ > + "gle = %d\n", GetLastError() ); 'ret == ERROR_SUCCESS (0)' case is marked as broken above, so using broken for 'GetLastError() == 0' instead of ERROR_FILE_NOT_FOUND would match that behaviour. Same comment applies for other added tests. In general I don't think that adding last error tests for SHFileOperation is very useful because 1) this API returns error codes directly 2) according to the tests both returned error codes and set last error values differ in almost every Windows version, so it's very unlikely that there is an app that depends on this. -- Dmitry.

2 5

Re: winhttp/test: Fix a test that fails on Windows.
by Marvin Jan. 28, 2014

Jan. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4504 Your paranoid android. === wxppro (32 bit winhttp) === winhttp.c:324: Test failed: WinHttpSendRequest failed: 12029 winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:346: Test failed: WinHttpReceiveResponse failed: 12017. winhttp.c:350: Test failed: WinHttpReadData failed: 12019. winhttp.c:352: Test failed: Read 0 bytes instead of 14. winhttp.c:353: Test failed: Data read did not match. winhttp.c:936: Test failed: failed to send request 12029 winhttp.c:939: Test failed: failed to receive response 12017 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 4287119 === wvista (32 bit winhttp) === winhttp.c:936: Test failed: failed to send request 12029 winhttp.c:939: Test failed: failed to receive response 12017 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 4287119 winhttp.c:952: Test failed: failed to send request 12029 winhttp.c:955: Test failed: failed to receive response 12017 winhttp.c:962: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 winhttp.c:966: Test failed: failed unexpectedly 12019 winhttp.c:967: Test failed: unexpected size 0 winhttp.c:972: Test failed: failed unexpectedly 12019 winhttp.c:973: Test failed: request failed unexpectedly 4287119 winhttp.c:1765: Test failed: failed to send request winhttp.c:2420: Test failed: got 80072efd === w7pro64 (32 bit winhttp) === winhttp.c:859: Test failed: failed to send request 12175 winhttp.c:939: Test failed: failed to receive response 12002 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 4287119 === w2008s64 (64 bit winhttp) === winhttp.c:936: Test failed: failed to send request 12029 winhttp.c:939: Test failed: failed to receive response 12017 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 0 winhttp.c:955: Test failed: failed to receive response 12029 winhttp.c:973: Test failed: request failed unexpectedly 0 === w7pro64 (64 bit winhttp) === winhttp.c:939: Test failed: failed to receive response 12002 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 0 winhttp.c:952: Test failed: failed to send request 12002 winhttp.c:955: Test failed: failed to receive response 12019 winhttp.c:962: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 winhttp.c:966: Test failed: failed unexpectedly 12019 winhttp.c:967: Test failed: unexpected size 0 winhttp.c:972: Test failed: failed unexpectedly 12019 winhttp.c:973: Test failed: request failed unexpectedly 0

1 0

Re: shell32: Use boolean return value in boolean function
by Michael Stefaniuc Jan. 28, 2014

Jan. 28, 2014

On 01/28/2014 12:07 AM, André Hentschel wrote: > --- > dlls/shell32/shellstring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/shell32/shellstring.c b/dlls/shell32/shellstring.c > index 6b511d2..9eb8536 100644 > --- a/dlls/shell32/shellstring.c > +++ b/dlls/shell32/shellstring.c > @@ -183,7 +183,7 @@ static BOOL StrToOleStrNW (LPWSTR lpWide, INT nWide, LPCWSTR lpStrW, INT nStr) > if (lstrcpynW (lpWide, lpStrW, nWide)) > { return lstrlenW (lpWide); > } > - return 0; > + return FALSE; This looks ugly. StrToOleStrNW() as well as StrToOleStrNA() return string length and not BOOL. What StrToOleStrN() (the sole user of about two functions) should return is not documented nor is there a Wine test for it. > } > > BOOL WINAPI StrToOleStrNAW (LPWSTR lpWide, INT nWide, LPCVOID lpStr, INT nStr) bye michael

1 0

Re: [PATCH] widl: Uuid attribute is allowed for 'struct'
by Marvin Jan. 28, 2014

Jan. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4497 Your paranoid android. === build (build) === Make failed

2 1

Re: user32/tests: Avoid preprocessor check to ensure it compiles (try 2)
by Marvin Jan. 27, 2014

Jan. 27, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4477 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().
by Henri Verbeet Jan. 27, 2014

Jan. 27, 2014

On 22 January 2014 23:42, Ken Thomases <ken(a)codeweavers.com> wrote: > > Consolidates duplicated code by using a simpler table-driven mechanism. > Instead of manually listing out certain combinations of display formats vs. > backbuffer formats, it just lists the formats and some metadata about them. > The algorithm tests every format against every format, using the metadata > to predict success or failure. This also tests that CheckDeviceType() fails > for display formats for which there are no adapter modes, rather than > skipping those. > > Tests windowed mode. > --- > dlls/d3d9/tests/device.c | 162 ++++++++++++++++++---------------------------- > 1 files changed, 64 insertions(+), 98 deletions(-) > This fails on native (Win 7, AMD Radeon HD 6310), and produces quite a lot of output in general: device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_X1R5G5B5 not supported device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_R5G6B5(23) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_X1R5G5B5(24) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A1R5G5B5(25) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_X8R8G8B8(22) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A8R8G8B8(21) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A2R10G10B10(35) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_UNKNOWN(0) windowed passed while it wasn't expected to device.c:2316: Display format D3DFMT_A1R5G5B5 not supported device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_A8R8G8B8 not supported device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2316: Display format D3DFMT_UNKNOWN not supported device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0

2 5

Re: [PATCH] scrrun: Implement IFolder::get_Path()
by Alexandre Julliard Jan. 27, 2014

Jan. 27, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/scrrun/filesystem.c | 10 ++++++++-- > dlls/scrrun/tests/filesystem.c | 9 ++++++++- > 2 files changed, 16 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M scrrun.dll -p scrrun_test.exe.so filesystem && touch filesystem.ok filesystem.c:886: Test failed: got L"wine_ppds", expected L"a" filesystem.c:892: Test failed: got L"C:\\users\\julliard\\Temp\\wine_ppds", expected L"C:\\users\\julliard\\Temp\\a" make[1]: *** [filesystem.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] includes: Fix IDirect3DSwapChain8_Present argument count.
by Henri Verbeet Jan. 27, 2014

Jan. 27, 2014

On 27 January 2014 14:41, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -#define IDirect3DSwapChain8_Present(p,a,b,c) (p)->lpVtbl->Present(p,a,b,c) > +#define IDirect3DSwapChain8_Present(p,a,b,c,d) (p)->lpVtbl->Present(p,a,b,c,d) I think you should fix the C++ version as well.

1 0

Re: [PATCH] api-ms-win-core-synch-l1-2-0: Add stub dll.
by Dmitry Timoshkov Jan. 27, 2014

Jan. 27, 2014

Martin Storsjo <martin(a)martin.st> wrote: > --- /dev/null > +++ b/dlls/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.spec Windows 7 64-bit here has only api-ms-win-core-synch-l1-1-0.dll, did you really mean 1-2-0 and what version of Windows provides it? > +@ stdcall OpenEventA(long long str) kernel32.OpenEventA > +@ stdcall OpenEventW(long long wstr) kernel32.OpenEventW > +@ stdcall OpenMutexW(long long wstr) kernel32.OpenMutexW > +@ stdcall OpenSemaphoreWlong long wstr) kernel32.OpenSemaphoreW The string with OpenSemaphoreW has a typo. If somebody else like me wonders why there is no OpenMutexA and OpenSemaphoreA then the answer is that at least 1-1-0 version of this dll in Windows 7 doesn't export them. -- Dmitry.

2 1

Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes
by Dmitry Timoshkov Jan. 26, 2014

Jan. 26, 2014

Marcus Meissner <marcus(a)jet.franken.de> wrote: > +#define WINPR_API WINBASEAPI This definition doesn't exist in PSDK 7.1. > +typedef DWORD TP_VERSION,*PTP_VERSION; PSDK 7.1 has this one and many other definitions in winnt.h instead. -- Dmitry.

3 3

Re: [PATCH 2/2] kernel32: very simple initial threadpool test
by Dmitry Timoshkov Jan. 26, 2014

Jan. 26, 2014

Marcus Meissner <marcus(a)jet.franken.de> wrote: > +static NTAPI void threadpool_workcallback(PTP_CALLBACK_INSTANCE instance, void *context, PTP_WORK work) { > + int *foo = (int*)context; > + > + (*foo)++; > +} Although this most likely compiles without warnings 'NTAPI' should be replaced by the correct one, and its placement should be fixed. -- Dmitry.

1 0

Cross-regressions between wine and mesa: how to handle them?
by Ruslan Kabatsayev Jan. 26, 2014

Jan. 26, 2014

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

1 0

Re: [17/28] msxml3/tests: Use common wine_dbgstr_guid implementation from test.h (resend)
by Marvin Jan. 25, 2014

Jan. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4440 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9845: Test failed: got 00244F94

1 0

Re: [16/28] mshtml/tests: Use common wine_dbgstr_guid implementation from test.h (resend)
by Marvin Jan. 25, 2014

Jan. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4439 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: [PATCH 5/5] wmp: Added WindowsMediaPlayer object stub implementation.
by Dmitry Timoshkov Jan. 25, 2014

Jan. 25, 2014

Jacek Caban <jacek(a)codeweavers.com> wrote: > +struct WindowsMediaPlayer { > + IOleObject IOleObject_iface; > + LONG ref; > +}; > + > +static inline WindowsMediaPlayer *impl_from_IOleObject(IOleObject *iface) > +{ > + return CONTAINING_RECORD(iface, WindowsMediaPlayer, IOleObject_iface); > +} Will this and below code which needs 'struct WindowsMediaPlayer' but instead gets just 'WindowsMediaPlayer' compile without a typedef? -- Dmitry.

2 1

Re: [PATCH 2/5] wmp: Added new DLL.
by Dmitry Timoshkov Jan. 25, 2014

Jan. 25, 2014

2 1

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 2)
by Marvin Jan. 24, 2014

Jan. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4420 Your paranoid android. === wxppro (32 bit bcrypt) === Timeout

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 5)
by Marvin Jan. 24, 2014

Jan. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4419 Your paranoid android. === wxppro (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === wvista (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w2008s64 (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w7pro64 (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w2008s64 (64 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w7pro64 (64 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737

1 0

Re: [PATCH 2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode
by Bruno Jesus Jan. 24, 2014

Jan. 24, 2014

On Thu, Jan 23, 2014 at 9:41 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 +++ > dlls/bcrypt/tests/bcrypt.c | 59 > +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 65 insertions(+) > Hi, Kai. > + status = pBCryptGetFipsAlgorithmMode(&result); > + ok(!status, "expected status STATUS_SUCCESS(0), got 0x%08X\n", status); > + ok(!result, "expected result FALSE, got %d\n", result); If the value depends on a registry entry how can you be sure it will always return 0? If the registry key is the only parameter required to return in this function IMO you should read the registry here and check against that instead of a fixed value. Best wishes, Bruno

2 1

Re: mscms: make missing lcms2 an error, not a fixme
by Hans Leidekker Jan. 23, 2014

Jan. 23, 2014

On Wed, 2014-01-22 at 21:28 -0800, Austin English wrote: > It breaks applications (e.g., the Adobe Flash installer), it should be an error. In that case many other fixme's also qualify as errors ;-) Loading mscms without liblcms2 support doesn't necessarily mean that the application will break. It may not actually use it or it may only use functions that don't depend on liblcms2.

2 1

Re:[PATCH 4/5] gdiplus: Implement SetPageTransform playback.
by Akira Nakagawa Jan. 23, 2014

Jan. 23, 2014

You have written the following: but you missed break;at the end of case {}. + case EmfPlusRecordTypeSetPageTransform: + { + EmfPlusSetPageTransform *record = (EmfPlusSetPageTransform*)header; + GpUnit unit = (GpUnit)flags; + + if (dataSize + sizeof(EmfPlusRecordHeader) < sizeof(EmfPlusSetPageTransform)) + return InvalidParameter; + + real_metafile->page_unit = unit; + real_metafile->page_scale = record->PageScale; + + return METAFILE_PlaybackUpdateWorldTransform(real_metafile); + } default:

2 1