January 2014 - Wine-Devel - list.winehq.org

Re: [24/28] shell32/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 18, 2014

Jan. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4336 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [23/28] rpcrt4/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 18, 2014

Jan. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4335 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [22/28] riched20/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 18, 2014

Jan. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4334 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [17/28] msxml3/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 18, 2014

Jan. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4329 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9845: Test failed: got 00244F94

1 0

Re: [16/28] mshtml/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 18, 2014

Jan. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4328 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: [21/28] qcap/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 17, 2014

Jan. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4333 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [20/28] oledb32/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin Jan. 17, 2014

Jan. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4332 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/6] dpnet: Add stubbed interface IDirectPlay8Server (try 4)
by Stefan Dösinger Jan. 17, 2014

Jan. 17, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2014-01-17 02:07, schrieb Alistair Leslie-Hughes: > Added server tests. I noticed that you still have style inconsistencies in these patches. I haven't done a deeper review of the content yet. I'll get to that once I'm done with my own patches :-\ . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS2RGzAAoJEN0/YqbEcdMwTPEP/0ugKXy7Ecy6Dev1yXp4k/KG HqDB5DS3pbMcFtFLte8qa0DrtQNz0YsX0Po1Hbsrz6dB1GzVLa0VhqzJxJJ3C48j kkyz2IIXlTTzy2I/53MrZ8/pcjXWbIztkNRuki3OQA31k9VNo1d27cdYWysc2uxs OJKO+QSfM3ZMdrdHJF0sgfynudDnrq7A25KZbwPxnu1io1GKFQFLQVPz1pulnrkz Jp6i8sr2PhtfJU6YrxABP3sOOx8LQSCTVdpHhwOJez4eYSToYs+B5Fa67Ed/ol2m QfeAiwdD1xzA1FtwwzrbOGuy7GK4YB9CM0oNSSCCl2g92jGDR4YAG504L5QfjtBa GtN4CDQETi7phx292cCwNYApPYPwHFeL3lgKW+F6HnkF9oVPXx9IoaX6fwIf9P/Z ADX5coB/wgBsCj5wrjN8axVtFDwzSGTdv+OvHQKwllQKF3RLAthJpeJozg7NXz9N caFZ2Gbs6Sz00RZ7n7LokwMv8p32TY6P9hyKrJfDs0olMymTYCjVvJWUPEaoskIW ZfMAKZrgSgMvCf+ROdmh0ZhfpS+D2A4867vuDO48GfP6HzHG+rEffKwMACJ0uI2+ 7GuKJ83mw5s24pxMoyeByzj7KJgUtMalE+WGSqO8R70B3+aeaR29g6xn5fGu2NL7 TAouZUc5fcNM67Dsr8zp =2wkj -----END PGP SIGNATURE-----

2 2

Re: tests: Avoid duplicating debugstr_guid()
by Jacek Caban Jan. 17, 2014

Jan. 17, 2014

Hi Frédéric, On 01/15/14 23:53, Frédéric Delanoy wrote: > diff --git a/include/wine/test.h b/include/wine/test.h > index 373fe76..d7ce8c1 100644 > --- a/include/wine/test.h > +++ b/include/wine/test.h > @@ -65,6 +65,7 @@ extern void winetest_add_failures( LONG new_failures ); > extern void winetest_wait_child_process( HANDLE process ); > > extern const char *wine_dbgstr_wn( const WCHAR *str, int n ); > +extern const char *debugstr_guid( const GUID *guid ); You probably want to follow existing test.h convention and call it wine_dbgstr_guid. This has a bonus advantage that you may split the patch for function introduction and per-dll replace. > static inline const char *wine_dbgstr_w( const WCHAR *s ) { return wine_dbgstr_wn( s, -1 ); } > > /* strcmpW is available for tests compiled under Wine, but not in standalone > @@ -523,6 +524,21 @@ const char *wine_dbgstr_wn( const WCHAR *str, int n ) > return res; > } > > +const char *debugstr_guid( const GUID *guid ) > +{ > + static char buf[50]; > + > + if (!guid) > + return "(null)"; > + > + sprintf(buf, "{%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}", > + guid->Data1, guid->Data2, guid->Data3, guid->Data4[0], > + guid->Data4[1], guid->Data4[2], guid->Data4[3], guid->Data4[4], > + guid->Data4[5], guid->Data4[6], guid->Data4[7]); > + > + return buf; > +} It would be a good idea to use get_temp_buffer, like wine_dbgstr_wn, instead of static variable. Thanks, Jacek

2 2

Re: mmdevapi/tests: Remove unused dbgstr_guid function
by Marvin Jan. 17, 2014

Jan. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4313 Your paranoid android. === wvista (32 bit render) === render.c:1206: Test failed: GetPosition failed: 00000001 === w7pro64 (32 bit render) === render.c:654: Test failed: Wait(event) after Stop gave 102

1 0