October 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] d3d9/tests: Port test_window_style to d3d9ex.
by Marvin Oct. 14, 2014

Oct. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9534 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:1294: Test failed: Got unexpected hr 0. d3d9ex.c:1296: Test failed: Got unexpected hr 0. d3d9ex.c:1298: Test failed: Got unexpected hr 0. d3d9ex.c:1300: Test failed: Got unexpected hr 0.

1 0

Re: [PATCH 3/3] kernel32/tests: Add tests for UTF-7 conversion. (try 3.1)
by Michael Stefaniuc Oct. 14, 2014

Oct. 14, 2014

Hello Alex, On 10/13/2014 08:19 AM, Alex Henrie wrote: > The only difference from the previous version of this patch is the > correction of a typo in one of the comments. > > --- > dlls/kernel32/tests/codepage.c | 751 ++++++++++++++++++++++++++++++++++ > +++++++ 1 file changed, 751 insertions(+) while more tests are good that's a lot of lines to have for just one function. So splitting the WCHAR => UTF-7 from the UTF-7 => WCHAR tests should help make it more manageable. Also some of the strings are huge. Most of those seem to be for the WCHAR => UTF-7 and could be probably generated by just using the directly_encodable_table[] from patch 2. If the tests cannot be generated from the table then please split the strings into more manageable chunks, as is they are unreadable / unmaintainable. Also the due to the size of the patch it is hard to discern what the difference between the different test structs are. Especially as the names are basically equivalent in this context: - utf16_to_utf7_tests and wcstombs_tests - utf7_to_utf16_tests and mbstowcs_tests bye michael

1 0

Re: [PATCH 3/4] d3d9/tests: Port wndproc tests to d3d9ex.
by Marvin Oct. 14, 2014

Oct. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9533 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:1294: Test failed: Got unexpected hr 0. d3d9ex.c:1296: Test failed: Got unexpected hr 0. d3d9ex.c:1298: Test failed: Got unexpected hr 0. d3d9ex.c:1300: Test failed: Got unexpected hr 0.

1 0

Re: [PATCH 1/1] ddraw: Return the primary legacy ddraw device last.
by Stefan Dösinger Oct. 14, 2014

Oct. 14, 2014

There are a few things I am wondering about and where the test can be extended: The existing test > /* Test with valid callback parameter and count the number of primary devices */ > callbackCount = 0; > ret = pDirectDrawEnumerateExA(test_count_callbackExA, &callbackCount, 0); > ok(ret == DD_OK, "Expected DD_OK, got %d\n", ret); > ok(callbackCount == 1, "Expected 1 primary device, got %d\n", callbackCount); Combined with your change that suggests that without any flag only the NULL guid is enumerated. If so I think that's worth an explicit check. Is the NULL guid enumerated when DDENUM_DETACHEDSECONDARYDEVICES and/or DDENUM_NONDISPLAYDEVICES are set? Regarding the specific changes you make: > dlls/ddraw/tests/ddrawmodes.c | 35 +++++++++++++++++++++++++++++++++++ I'd prefer that this test be moved to ddraw1.c > + static char DriverDescription[] = "DirectDraw HAL"; > + static char DriverName[] = "display"; Please do not use CamelCase or lpFoo in d3d-related code. Somewhat related, but that can be a separate patch: d3d3_EnumDevices() mentions that some games modify the strings. In your code (and the current code), such modifications would persist for the runtime of the application. It would be interesting to add a test for this. > +static BOOL WINAPI test_last_callbackExA(GUID *lpGUID, char *lpDriverDescription, > + char *lpDriverName, void *lpContext, HMONITOR hm) You should be able to combine the callbacks. Just declare a structure and put a counter in it. > +{ > + GUID **context_guid = (GUID **)lpContext; > + static GUID last_guid; I guess this works, but it is somewhat ugly. If you use a struct you can put a GUID and a BOOL guid_was_null in it. Or a GUID and a GUID *. Please extend the test to DirectDrawEnumerateA. MSDN suggests it is equivalent to DirectDrawEnumerateExA(DDENUM_NONDISPLAYDEVICES), but I have my doubts here. Comparing the strings of the non-NULL device against "DirectDraw HAL" and "display" (in the Ex and non-Ex case) would also be a good idea. Am 13.10.2014 um 21:16 schrieb Erich E. Hoover <erich.e.hoover(a)gmail.com>: > Fixes bug #37307. There are a couple of other bugs that are > preventing Urban Assault from working, but this fixes the problem with > returning the interfaces in the wrong order. > <0001-ddraw-Return-the-primary-legacy-ddraw-device-last.patch>

2 2

Re: [PATCH 1/1] d3d8/tests: Allow a width and height to be passed to create_device().
by Marvin Oct. 14, 2014

Oct. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9522 Your paranoid android. === w8 (32 bit device) === device.c:2421: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3078: Test failed: Expected wndproc 0x412c60, got 0x412c60.

1 0

Re: [PATCH] vbscript: Implemented Timer
by Marvin Oct. 14, 2014

Oct. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

3 2

Re: advapi32/tests: Don't crash on Wine in WoW setups
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9509 Your paranoid android. === w7u (32 bit service) === The test timed out

1 0

Re: [PATCH 5/5] ntdll: Implement storing DOS attributes in NtCreateFile.
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9506 Your paranoid android. === build (build) === Make in include dir failed

1 0

Re: [PATCH 4/5] ntdll: Implement storing DOS attributes in NtSetInformationFile.
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9505 Your paranoid android. === build (build) === Make in include dir failed

1 0

RFC: Adding distribution field to Bugzilla
by Austin English Oct. 13, 2014

Oct. 13, 2014

Howdy everyone, I'd like to add a distribution field to Bugzilla, to make it easier to identify when users may have additional patches installed by their distribution and/or other distribution specific issues (e.g., https://bugs.winehq.org/show_bug.cgi?id=35413) It would be a drop down selection, with the major distributions listed (i.e., ArchLinux, Debian, Fedora, Gentoo, Mint, RedHat, Slackware, Suse, Ubuntu, other). Comments/feedback welcome. -- -Austin

6 9

Re: Add WWN 377
by Stefan Dösinger Oct. 13, 2014

Oct. 13, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-10 21:48, schrieb André Hentschel: > +<stats posts="131" size="310" contrib="23" multiples="14" lastweek="11"> > + > +<person posts="9" size="21" who="stefandoesinger at gmail.com (Stefan Dösinger)" /> > +<person posts="6" size="8" who="hverbeet at gmail.com (Henri Verbeet)" /> > +<person posts="6" size="6" who="julliard at winehq.org (Alexandre Julliard)" /> > +<person posts="4" size="8" who="mstefani at redhat.com (Michael Stefaniuc)" /> > +<person posts="3" size="4" who="austinenglish at gmail.com (Austin English)" /> > +<person posts="3" size="3" who="alexhenrie24 at gmail.com (Alex Henrie)" /> > +<person posts="3" size="2" who="nsivov at codeweavers.com (Nikolay Sivov)" /> > +<person posts="2" size="5" who="scottritchie at ubuntu.com (Scott Ritchie)" /> > +<person posts="2" size="2" who="dimesio at earthlink.net (Rosanne DiMesio)" /> > +<person posts="2" size="1" who="piotr.caban at gmail.com (Piotr Caban)" /> You may want to check the stat generation. Those are 38 posts. Plus 8 for the other 4 multiple posters + 9 for the single posters != 131. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUOFxQAAoJEN0/YqbEcdMwMEgP/AycUgCYLAtZ0O8BLi1YCMP2 1asxLYGu0ERqqI+ga/cB83bOSYwDqHMfM4EvxwmEkv+1OunHYObEaTFmGeo/ylee T/GrRg6boHBsgaLyNYsn7xKltBxxY8mZTy8kYEnHi95Hz1r8FBTTjYH93sgUEtRd qmKyL7IJjAAgQzsZe4HBcKUzdGUCRVI0IrFRBc/48SDdVZs47UuTMg2NpLjxF2Db ebgt+YtJQhjnikqMkA541JkxDKd6EIqOIg38dOY1easnqV9WAURdvESY5zrtWmnF ZCPJvmS8PxGylBiI2b/AgrjmoU/cxpjoe1n3Uza8pvdxrCZSVNjDK0ceteIex57g SlqHkplYrrZHaeYsVgdoq+z9+S+4fdgm0pMUUV9W4QBXZdIsoRPFEMbplX7B30Uo /01hVceSzEoM+DeNV4G55KCJnBrPhQ7vOT1rfbdGgcVqX3OEdpv9FaKY0VLmuwNq QBRghN9TY7sX12Q3VPmTkVHkudTCz9gQAScDJpIh60XHj2ZkS8bmQHwhrPDERkoe YvtyR9OROcqrpzCeBW4AnbMuJHeYrGJC7H2OYFbt+N0VAFkV2Zh5Z3+LAkrER5DY 0HIqADQy0c73l7FPT172j3zvC9t4boDelR8Wx5jHsSmUdzboiFQZodLaw2o6b3Mt 2a6cjWARAZNetTBaAPwq =/Lzl -----END PGP SIGNATURE-----

2 1

Re: ieframe: Send command state change notifications from history navigation handlers.
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9497 Your paranoid android. === wvistau64 (32 bit webbrowser) === webbrowser.c:976: Test failed: unexpected dispIdMember 271 webbrowser.c:1602: Test failed: unexpected call TranslateUrl webbrowser.c:445: Test failed: unexpected nCmdID 14

1 0

Re: cmd/tests: Spelling and grammar fixes
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9495 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 690 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 691 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 694 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 695 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 697 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 699 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 707 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 710 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 713 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 716 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 729 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 742 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 767 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 780 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1364 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1365 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1366 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path(a)foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1367 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1368 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1369 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1370 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1371 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1373 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1376 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1377 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1380 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar') === wvistau64 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: [PATCH] widl: Generate method macros/wrappers for overridden methods.
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9493 Your paranoid android. === build (build) === Make failed

2 1

Re: wininet: Remove the content length header after the request is sent.
by Jacek Caban Oct. 13, 2014

Oct. 13, 2014

On 10/13/14 13:57, Hans Leidekker wrote: > This ensures that a new content length header is inserted when the request is reused. Could you please add a test? Jacek

1 0

Re: ieframe: Send command state change notifications from history navigation handlers.
by Jacek Caban Oct. 13, 2014

Oct. 13, 2014

Hi Hans, On 10/13/14 13:56, Hans Leidekker wrote: > HRESULT go_back(DocHost *This) > { > + HRESULT hres; > + > if(!This->travellog.position) { > WARN("No history available\n"); > return E_FAIL; > } > > - return navigate_history(This, This->travellog.position-1); > + hres = navigate_history(This, This->travellog.position-1); > + if(SUCCEEDED(hres)) > + on_commandstate_change(This, CSC_NAVIGATEFORWARD, VARIANT_TRUE); We probably shouldn't call this notification if forward navigation was already possible before the call. Also, if we reach the bottom of history stack, we should also probably notify that back navigation is no longer possible. It would be more generic and easier to get right if you did that in navigate_history, based on previous and current history position. > HRESULT get_location_url(DocHost *This, BSTR *ret) > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index fa37169..238b6de 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -3022,7 +3022,7 @@ static void test_go_back(IWebBrowser2 *wb, const char *back_url) > hres = IWebBrowser2_GoBack(wb); > ok(hres == S_OK, "GoBack failed: %08x\n", hres); > CHECK_CALLED(Invoke_BEFORENAVIGATE2); > - todo_wine CHECK_CALLED(Invoke_COMMANDSTATECHANGE); > + CHECK_CALLED(Invoke_COMMANDSTATECHANGE); > CLEAR_CALLED(Invoke_PROPERTYCHANGE); /* called by IE11 */ > } > > @@ -3038,7 +3038,7 @@ static void test_go_forward(IWebBrowser2 *wb, const char *forward_url) > hres = IWebBrowser2_GoForward(wb); > ok(hres == S_OK, "GoForward failed: %08x\n", hres); > CHECK_CALLED(Invoke_BEFORENAVIGATE2); > - todo_wine CHECK_CALLED(Invoke_COMMANDSTATECHANGE); > + CHECK_CALLED(Invoke_COMMANDSTATECHANGE); > I would be nice to have those tests stricter. For example, by checking command in COMMANDSTATECHANGE notification and have separated Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD and Invoke_COMMANDSTATECHANGE_NAVIGATEBACK. Thanks, Jacek

1 0

Re: jscript: Don't use builtin property for exposing ActiveXObject constructor.
by Marvin Oct. 13, 2014

Oct. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9494 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH v4 5/8] reg.exe: Add wchar/raw data conversion functions
by Stefan Dösinger Oct. 12, 2014

Oct. 12, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This code could use more tests, especially for REG_SZ_MULTI and REG_BINARY. Am 2014-10-09 10:55, schrieb Jonathan Vollebregt: > +static WCHAR *data_get_wchar(const BYTE *data, const DWORD size, const DWORD type) This function is not used until the next patch. From a design point of view it unfortunate that you allocate a new string for the REG_SZ and REG_SZ_MULTI case and essentially just do a memcpy and free the old string. As long as you just need this function to print the values it would be better to add a function that prints directly. Keep reg export in mind though. It may need the function like this, or maybe a printing function that is passed a file descriptor. > + do > + { > + lstrcpyW(output+i, &input[i]); > + > + i += strlenW(&input[i]) + 1; > + > + if (input[i] != 0) > + output[i - 1] = ','; > + } while (input[i]); If I understand this correctly this replaces 0 WCHARs with ',' . There should be nicer ways to do this. > +static BYTE *wchar_get_data(const WCHAR *input, const DWORD type, > + const WCHAR seperator, DWORD *size_out) > ... > + case REG_SZ: > + case REG_EXPAND_SZ: > + { > + i = (strlenW(input) + 1) * sizeof(WCHAR); > + output = HeapAlloc(GetProcessHeap(), 0, i); > + lstrcpyW((WCHAR *) output, input); > + *size_out = i; > + return output; > + } This also has unfortunate copying behavior. Maybe there is a nicer way to solve this. > + for (i = 0, p = 0; i <= strlenW(input); i++, p++) > + { > + if (input[i] == seperator) Please watch the spelling of separator. This confused me a bit in my code search :-) . > + temp[p] = 0; > + else if (seperator == 0 && input[i] == '\\' && input[i + 1] == '0') How does a 0 separator work? The command line interpreter would fail to parse such a string. msdn claims that the default separator is '\0', but maybe they mean a backslash ('\\') like your code uses. If the default separator is a backslash it would be nicer to handle this default in the code that parses the command line. > + { > + temp[p] = 0; > + i++; > + } I don't understand what's special about a 0 or \ separator as far as this loop is concerned. > + if (p % 2) if (p & 1) is nicer to check for odd / even (i.e., the lowest bit). The compiler should be able to to this optimization as well. > + p /= 2; p >>= 1 . Or you could consider incrementing i by 2 in the for loop below. > + for (i = 0; i < p; i++) > + temp[i] = (temp[i * 2] << 4) | temp[i * 2 + 1]; -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUOpgoAAoJEN0/YqbEcdMwyLYP+QFSbpZLsy/Au6uKLQNfcRqS MnHxgrB1wq+RxfDbQ6UdzT6gIVKhEII0c//gZ32H5Fr/+zIofaa38XmtH6Fp8MMg p1s+ubFeZ29vMaNER28zwK/QM6Allwo+JLjqLSM6W2cgrfe1kU/iPWGC97nJktEj cG4wsAdcgYCHvkOH/06ZIC/zSbWyG0yZJSgKfLqfgEbuD/TAmmkXh0TVMm9Znp88 J6mLhcYSbfTK2oHzU9nXETTa5oFR/VfHQHZ7asa+q14kftl24Y5JCs1VD6BK/G4p TjD5jQhIN9L5FHKj79n+9y5eeYjrIiMhdi81ey3Bm8it03ZPUN3aAjXf6CD6UmBu wxHZwB8L1PALJsDBK+E7a8QgeteWxMjX07m2FdfFNewj4IFq4eoASdeINd8Zd1rt TpWl2/jpKz4PecRvGeNKOEgqx+mFcSRWiXErytWtEmJzz+aPEjdjFXesf6aWFB/l +ZZxc202He9JXacPFvmCuL0ltWStJqdSZRZg/FkIgqXZkWfj1bwxDYpu+7Jv6243 KrQrMUGna1VXGM6tAfYph0BLtZnksTwFS6MEoPzirf2Yqe3uuQzecQqhyaStaESJ 5HS+6NTEZT2LhvKy3mui970k2THpmQFb7j4f+xdmKHEj6qdsoH+SHouJgkig/KLk x28pWN1J80RCE92BQdYV =tqtd -----END PGP SIGNATURE-----

2 2

Re: [PATCH v4 3/8] reg.exe: Add wchar/type conversion functions
by Stefan Dösinger Oct. 12, 2014

Oct. 12, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-09 10:55, schrieb Jonathan Vollebregt: > +static const WCHAR *type_get_wchar(const DWORD type) This function is not used. You can add it in patch 5, where you actually use it. > +static DWORD wchar_get_type(const WCHAR *type) > +{ > + static const WCHAR type_dword_le[] = {'R','E','G','_','D','W','O','R','D','_','L','I','T','T','L','E','_','E','N','D','I','A','N',0}; > + DWORD i; > + > + if (lstrcmpiW(type, type_dword_le) == 0) > + return REG_DWORD_LITTLE_ENDIAN; I think a table where you can map two different strings to index 4 is nicer than the special case, unless having the cheap reverse lookup is important for performance. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUOotdAAoJEN0/YqbEcdMwpsAQAJIoOZIzwfKU+EWf6lTO1L6u zhHECP7G8GnlxDI9XGVkg0xvj0v+mxBXUXHdWkCczKyuWJFmUB4adULqpXDloyRa 0aMKSnziixXadiQMY5p36KmTSVLg+rCq3ol/dCjR1E/kCktkwbH0mcx0w4YMf9wZ /gtTRFY7F4OVLFQdhZV4lI2stcJpP057Tx+MivzfpVgw+HXfo3IUZlDtAVY0LNXV DfjX9terIhqE6kqkyalsa6sYczNRgrGF2D+jU+MADJSnQ7bHk15foayV4nzkcqk9 wabU65qY4HEWTo54m4u/W0yVyEb3j3JWN1XQAm/a+ae1iFnE86XHf5eq7s4ze81a Wu5dYdBanrH/qMkzGdG15+3h2u33PxHOL0R/25KrwvZDV61GGJ8r1gJEsPvNWqh3 QomLLMPCSArNLBUQSUrfk84GyeOg0TBfSXTR/JLOxG8GtQ/slAWwa/F310tBxSTa 6Csx6aeazHDMrZhgT2W75hMy1eA8GVGCH5ovBl3ThdJB9kkJM6zIQh7UB940TnVA orZcSXxxKVENO2FTWbeSrsQhjqwwvTL8reRS2T7wZZAQ3J10OI0HXOAIE4hr54wE j7FA5whN86sLXg4stjLW0ExpzlTHvTKYxQJl7CPILaYMQXwVIIdrgeaV8bi9ko5c vlir4SrW/E5rfUfxflAx =eD+7 -----END PGP SIGNATURE-----

1 0

Re: [PATCH v4 1/8] reg.exe: Perform checks in wmain
by Stefan Dösinger Oct. 12, 2014

Oct. 12, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-09 10:55, schrieb Jonathan Vollebregt: > Move as much error-checking to main as possible so sub functions > don't have to repeat basic checks > > IE: Is the key on a remote system, or are we missing arguments? I don't think this is really an improvement. The old code first looked at argvW[1], then argvW[2], ..., with clear checks that the argument count is big enough. The new code jumps around between the arguments without any clear order. As a result it still isn't clear if argv[2] is supposed to be a registry key at all when you check it for remoting. While it may be true in the current form of reg.exe, it won't work if support for e.g. reg import is added. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUOoBfAAoJEN0/YqbEcdMw+ogP/AnFEAMDQrGtrjtau/EL0Yuu vkmUcgAcSG71I//iFchLvpSzzrVlgmrX2t8eatFHyClBh0jhGwtFOvdXHiilsOEV yRcJBlkr5wa+hD+SvpBX4VGTBFJEhbJ9uhzzeFv0teh6AhxVpkjFGM6yR373xmkz Pk9F7sT30YxOqF5RftPwWylihpWNOgMwk2rHJkanImI+Fle0EMQOIaI+ASDsc5i0 DhAl8Xs867wUkiFfBzU5l5p+nARGr971PDj3nUOubDeJEUNBaO7d+Uh4AAa9a+h3 evDd1e+kdW8kjStnFXQZfkFYw+8gK9lxB05NrX1EeIkGoxpKaOXMW+5gEV76eb8z yqfe3vdzijHptKGxAml5Y6A7N3HPuZyi+dwDW41Dmgsz3cY+WmZ6X3CGXB3wBcew SVSoZjfcdE4mq6BDFPRC7A1+Rt6aYUAvxQDQT+jhRtlMBRQrAtML3o9n08JEbqkD T6twKYBniWHBlGgb8rD9yA1snUYlOO2a4zhGzZ2Z/L9WHMzxOXLApa2x6Tcew9Jz V1gqDQPpgwhy4a/8oeukwj9VH2uva12Q72f7RQMKc1Q7CGXskso4RlZpJpHi2eNi 1oHDQzTYX0nLOSeU8C4336zq+ljh2Csme8CtLFw9a44mbzhSzzdtWJBcS3M8pQ8C Txkl4Xka006+rZQHjzQO =inoY -----END PGP SIGNATURE-----

1 0

Re: [PATCH 3/5] wined3d: Track texture allocation per-texture.
by Farmboy0 Oct. 12, 2014

Oct. 12, 2014

On 08.10.2014 08:47, Henri Verbeet wrote: > --- > dlls/wined3d/surface.c | 13 +++-------- > dlls/wined3d/texture.c | 47 ++++++++++++++++++++++++++++++---------- > dlls/wined3d/volume.c | 8 +++---- > dlls/wined3d/wined3d_private.h | 14 ++++++------ > 4 files changed, 49 insertions(+), 33 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index d02d5f2..0967220 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -599,11 +599,6 @@ static void surface_evict_sysmem(struct wined3d_surface *surface) > surface_invalidate_location(surface, WINED3D_LOCATION_SYSMEM); > } > > -static void surface_force_reload(struct wined3d_surface *surface) > -{ > - surface->flags &= ~(SFLAG_ALLOCATED | SFLAG_SRGBALLOCATED); > -} > - > static void surface_release_client_storage(struct wined3d_surface *surface) > { > struct wined3d_context *context = context_acquire(surface->resource.device, NULL); > @@ -621,11 +616,9 @@ static void surface_release_client_storage(struct wined3d_surface *surface) > gl_info->gl_ops.gl.p_glTexImage2D(surface->texture_target, surface->texture_level, > GL_RGB, 1, 1, 0, GL_RGB, GL_UNSIGNED_BYTE, NULL); > } > + wined3d_texture_force_reload(surface->container); > > context_release(context); > - > - surface_invalidate_location(surface, WINED3D_LOCATION_TEXTURE_RGB | WINED3D_LOCATION_TEXTURE_SRGB); > - surface_force_reload(surface); > } > > static BOOL surface_use_pbo(const struct wined3d_surface *surface) > @@ -1211,7 +1204,7 @@ static void surface_unload(struct wined3d_resource *resource) > surface_load_location(surface, surface->resource.map_binding); > surface_invalidate_location(surface, ~surface->resource.map_binding); > } > - surface->flags &= ~(SFLAG_ALLOCATED | SFLAG_SRGBALLOCATED); > + wined3d_texture_force_reload(surface->container); > > context = context_acquire(device, NULL); > gl_info = context->gl_info; > @@ -1845,7 +1838,7 @@ void surface_load(struct wined3d_surface *surface, BOOL srgb) > surface_invalidate_location(surface, ~surface->resource.map_binding); > /* Switching color keying on / off may change the internal format. */ > if (ck_changed) > - surface_force_reload(surface); > + wined3d_texture_force_reload(surface->container); > } > else if (!(surface->locations & location)) > { > diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c > index 27a10c6..bc75305 100644 > --- a/dlls/wined3d/texture.c > +++ b/dlls/wined3d/texture.c > @@ -751,7 +751,26 @@ HRESULT CDECL wined3d_texture_update_desc(struct wined3d_texture *texture, UINT > > void wined3d_texture_prepare_texture(struct wined3d_texture *texture, struct wined3d_context *context, BOOL srgb) > { > + DWORD alloc_flag = srgb ? WINED3D_TEXTURE_SRGB_ALLOCATED : WINED3D_TEXTURE_RGB_ALLOCATED; > + > + if (texture->flags & alloc_flag) > + return; > + > texture->texture_ops->texture_prepare_texture(texture, context, srgb); > + texture->flags |= alloc_flag; > +} > + > +void wined3d_texture_force_reload(struct wined3d_texture *texture) > +{ > + unsigned int sub_count = texture->level_count * texture->layer_count; > + unsigned int i; > + > + texture->flags &= ~(WINED3D_TEXTURE_RGB_ALLOCATED | WINED3D_TEXTURE_SRGB_ALLOCATED); > + for (i = 0; i < sub_count; ++i) > + { > + texture->texture_ops->texture_sub_resource_invalidate_location(texture->sub_resources[i], > + WINED3D_LOCATION_TEXTURE_RGB | WINED3D_LOCATION_TEXTURE_SRGB); > + } > } > > void CDECL wined3d_texture_generate_mipmaps(struct wined3d_texture *texture) > @@ -817,11 +836,17 @@ static void texture2d_sub_resource_cleanup(struct wined3d_resource *sub_resource > wined3d_surface_destroy(surface); > } > > +static void texture2d_sub_resource_invalidate_location(struct wined3d_resource *sub_resource, DWORD location) > +{ > + struct wined3d_surface *surface = surface_from_resource(sub_resource); > + > + surface_invalidate_location(surface, location); > +} > + > /* Context activation is done by the caller. */ > static void texture2d_prepare_texture(struct wined3d_texture *texture, struct wined3d_context *context, BOOL srgb) > { > UINT sub_count = texture->level_count * texture->layer_count; > - DWORD alloc_flag = srgb ? SFLAG_SRGBALLOCATED : SFLAG_ALLOCATED; > const struct wined3d_format *format = texture->resource.format; > const struct wined3d_gl_info *gl_info = context->gl_info; > const struct wined3d_color_key_conversion *conversion; > @@ -864,9 +889,6 @@ static void texture2d_prepare_texture(struct wined3d_texture *texture, struct wi > GLsizei width = surface->pow2Width; > const BYTE *mem = NULL; > > - if (surface->flags & alloc_flag) > - continue; > - > if (converted) > surface->flags |= SFLAG_CONVERTED; > else > @@ -922,8 +944,6 @@ static void texture2d_prepare_texture(struct wined3d_texture *texture, struct wi > gl_info->gl_ops.gl.p_glPixelStorei(GL_UNPACK_CLIENT_STORAGE_APPLE, GL_FALSE); > checkGLcall("glPixelStorei(GL_UNPACK_CLIENT_STORAGE_APPLE, GL_FALSE)"); > } > - > - surface->flags |= alloc_flag; > } > } > > @@ -932,6 +952,7 @@ static const struct wined3d_texture_ops texture2d_ops = > texture2d_sub_resource_load, > texture2d_sub_resource_add_dirty_region, > texture2d_sub_resource_cleanup, > + texture2d_sub_resource_invalidate_location, > texture2d_prepare_texture, > }; > > @@ -1261,9 +1282,15 @@ static void texture3d_sub_resource_cleanup(struct wined3d_resource *sub_resource > wined3d_volume_destroy(volume); > } > > +static void texture3d_sub_resource_invalidate_location(struct wined3d_resource *sub_resource, DWORD location) > +{ > + struct wined3d_volume *volume = volume_from_resource(sub_resource); > + > + wined3d_volume_invalidate_location(volume, location); > +} > + > static void texture3d_prepare_texture(struct wined3d_texture *texture, struct wined3d_context *context, BOOL srgb) > { > - DWORD alloc_flag = srgb ? WINED3D_VFLAG_SRGB_ALLOCATED : WINED3D_VFLAG_ALLOCATED; > unsigned int sub_count = texture->level_count * texture->layer_count; > const struct wined3d_format *format = texture->resource.format; > const struct wined3d_gl_info *gl_info = context->gl_info; > @@ -1276,9 +1303,6 @@ static void texture3d_prepare_texture(struct wined3d_texture *texture, struct wi > struct wined3d_volume *volume = volume_from_resource(texture->sub_resources[i]); > void *mem = NULL; > > - if (volume->flags & alloc_flag) > - continue; > - > if (gl_info->supported[APPLE_CLIENT_STORAGE] && !format->convert > && volume_prepare_system_memory(volume)) > { > @@ -1300,8 +1324,6 @@ static void texture3d_prepare_texture(struct wined3d_texture *texture, struct wi > gl_info->gl_ops.gl.p_glPixelStorei(GL_UNPACK_CLIENT_STORAGE_APPLE, GL_FALSE); > checkGLcall("glPixelStorei(GL_UNPACK_CLIENT_STORAGE_APPLE, GL_FALSE)"); > } > - > - volume->flags |= alloc_flag; > } > } > > @@ -1310,6 +1332,7 @@ static const struct wined3d_texture_ops texture3d_ops = > texture3d_sub_resource_load, > texture3d_sub_resource_add_dirty_region, > texture3d_sub_resource_cleanup, > + texture3d_sub_resource_invalidate_location, > texture3d_prepare_texture, > }; > > diff --git a/dlls/wined3d/volume.c b/dlls/wined3d/volume.c > index 92bc1e1..0cbc7d4 100644 > --- a/dlls/wined3d/volume.c > +++ b/dlls/wined3d/volume.c > @@ -262,9 +262,9 @@ static void wined3d_volume_load_location(struct wined3d_volume *volume, > case WINED3D_LOCATION_TEXTURE_RGB: > case WINED3D_LOCATION_TEXTURE_SRGB: > if ((location == WINED3D_LOCATION_TEXTURE_RGB > - && !(volume->flags & WINED3D_VFLAG_ALLOCATED)) > + && !(volume->container->flags & WINED3D_TEXTURE_RGB_ALLOCATED)) > || (location == WINED3D_LOCATION_TEXTURE_SRGB > - && !(volume->flags & WINED3D_VFLAG_SRGB_ALLOCATED))) > + && !(volume->container->flags & WINED3D_TEXTURE_SRGB_ALLOCATED))) > ERR("Trying to load (s)RGB texture without prior allocation.\n"); > > if (volume->locations & WINED3D_LOCATION_DISCARDED) > @@ -451,8 +451,8 @@ static void volume_unload(struct wined3d_resource *resource) > } > > /* The texture name is managed by the container. */ > - volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED > - | WINED3D_VFLAG_CLIENT_STORAGE); > + wined3d_texture_force_reload(volume->container); > + volume->flags &= ~WINED3D_VFLAG_CLIENT_STORAGE; > > resource_unload(resource); > } > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 17a68dc..5ec5088 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -2116,6 +2116,7 @@ struct wined3d_texture_ops > void (*texture_sub_resource_add_dirty_region)(struct wined3d_resource *sub_resource, > const struct wined3d_box *dirty_region); > void (*texture_sub_resource_cleanup)(struct wined3d_resource *sub_resource); > + void (*texture_sub_resource_invalidate_location)(struct wined3d_resource *sub_resource, DWORD location); > void (*texture_prepare_texture)(struct wined3d_texture *texture, > struct wined3d_context *context, BOOL srgb); > }; > @@ -2123,8 +2124,10 @@ struct wined3d_texture_ops > #define WINED3D_TEXTURE_COND_NP2 0x00000001 > #define WINED3D_TEXTURE_POW2_MAT_IDENT 0x00000002 > #define WINED3D_TEXTURE_IS_SRGB 0x00000004 > -#define WINED3D_TEXTURE_RGB_VALID 0x00000008 > -#define WINED3D_TEXTURE_SRGB_VALID 0x00000010 > +#define WINED3D_TEXTURE_RGB_ALLOCATED 0x00000008 > +#define WINED3D_TEXTURE_RGB_VALID 0x00000010 > +#define WINED3D_TEXTURE_SRGB_ALLOCATED 0x00000020 > +#define WINED3D_TEXTURE_SRGB_VALID 0x00000040 > > struct wined3d_texture > { > @@ -2170,6 +2173,7 @@ void wined3d_texture_bind(struct wined3d_texture *texture, > struct wined3d_context *context, BOOL srgb) DECLSPEC_HIDDEN; > void wined3d_texture_bind_and_dirtify(struct wined3d_texture *texture, > struct wined3d_context *context, BOOL srgb) DECLSPEC_HIDDEN; > +void wined3d_texture_force_reload(struct wined3d_texture *texture) DECLSPEC_HIDDEN; > void wined3d_texture_load(struct wined3d_texture *texture, > struct wined3d_context *context, BOOL srgb) DECLSPEC_HIDDEN; > void wined3d_texture_prepare_texture(struct wined3d_texture *texture, > @@ -2191,9 +2195,7 @@ void wined3d_texture_set_swapchain(struct wined3d_texture *texture, > > const char *wined3d_debug_location(DWORD location) DECLSPEC_HIDDEN; > > -#define WINED3D_VFLAG_ALLOCATED 0x00000001 > -#define WINED3D_VFLAG_SRGB_ALLOCATED 0x00000002 > -#define WINED3D_VFLAG_CLIENT_STORAGE 0x00000004 > +#define WINED3D_VFLAG_CLIENT_STORAGE 0x00000001 > > struct wined3d_volume > { > @@ -2354,8 +2356,6 @@ void flip_surface(struct wined3d_surface *front, struct wined3d_surface *back) D > #define SFLAG_GLCKEY 0x00000100 /* The GL texture was created with a color key. */ > #define SFLAG_CLIENT 0x00000200 /* GL_APPLE_client_storage is used with this surface. */ > #define SFLAG_DIBSECTION 0x00000400 /* Has a DIB section attached for GetDC. */ > -#define SFLAG_ALLOCATED 0x00000800 /* A GL texture is allocated for this surface. */ > -#define SFLAG_SRGBALLOCATED 0x00001000 /* A sRGB GL texture is allocated for this surface. */ > > struct wined3d_sampler > { Hi, This commit causes problems with Eve Online. When switching from Fullscreen to Windowed I get the following errors and the 3d objects look like a mess of colors. err:d3d_surface:surface_load_location Surface 0x1f834240 does not have any up to date location. err:d3d_surface:surface_invalidate_location Surface 0x1f834240 does not have any up to date location. I have bisected the following commit to be the offender: commit ee8a5b7dd1e554ef32229c766715f23ba17c9f6c Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Oct 8 08:47:20 2014 +0200 wined3d: Track texture allocation per-texture.

2 1

Re: Add WWN 377
by Rico Schüller Oct. 11, 2014

Oct. 11, 2014

On 10.10.2014 21:48, André Hentschel wrote: > diff --git a/news/de/2014101001.xml b/news/de/2014101001.xml > new file mode 100644 > index 0000000..8ad495c > --- /dev/null > +++ b/news/de/2014101001.xml > @@ -0,0 +1,11 @@ > +<news> > + <date>10. Oktober 2014</date> > + <title>World Wine News Ausgabe 377</title> > + <body> > +<a href="{$root}/wwn/377">WWN Ausgabe 377 (en)</a> wurde heute verÃ¶ffentlicht. > +<ul> > +<li><a href="{$root}/wwn/377#Idea for a Wine staging tree">Idea fÃ¼r einen Wine Staging Tree</a></li> <li><a href="{$root}/wwn/377#Idea for a Wine staging tree">Idee ... Cheers Rico

1 0

Re: [PATCH] mshtml/tests: Fix typo.
by Marvin Oct. 11, 2014

Oct. 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9465 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

2 1

Re: wined3d: Correctly display fog for right-handed projection matrix (try 6)
by Stefan Dösinger Oct. 10, 2014

Oct. 10, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I missed a few things the last time. This list is exhaustive now, at least as far as I'm concerned. I have listed most things for d3d8, but they apply to the d3d9 test as well. Am 2014-10-10 15:21, schrieb Joachim Priesner: > + static const D3DMATRIX proj_mat = > + {{{ > + 1.0f, 0.0f, 0.0f, 0.0f, > + 0.0f, 1.0f, 0.0f, 0.0f, > + 0.0f, 0.0f, -1.0f, 0.0f, > + 0.0f, 0.0f, -0.0f, 1.0f > + }}}; Minor detail: you left a redundant - in here. (4th row, third column, -0.0f) > + /* Basic vertex shader with fog computation ("foggy"). > + * Using the vertex' x coordinate as fog coordinate so that all test cases that use vertex fog > + * will have a gradient from fully fogged (green, left) to unfogged (red, right). */ This is a bit off-topic, but I'm still noting it here: We don't have any tests for the clamp(0.0, 1.0) we do on the oFog output. Hence it may be interesting to check the middle of the screen in case of the foggy shader. If it is half fogged, the clamp is correct. If it is fully fogged the clamp is wrong (keep in mind that "foggy shaders" have reverse fog with start = 1, end = 0). This shouldn't be part of this patch, but it is an idea for a follow-up test if you or anyone else is interested. > + {0, 0, D3DFOG_NONE, D3DFOG_LINEAR, COLOR_UNFOGGED, COLOR_FOGGED}, > + {0, 1, D3DFOG_NONE, D3DFOG_LINEAR, COLOR_UNFOGGED, COLOR_FOGGED}, > + {0, 0, D3DFOG_LINEAR, D3DFOG_LINEAR, COLOR_UNFOGGED, COLOR_FOGGED}, > + {0, 1, D3DFOG_LINEAR, D3DFOG_LINEAR, COLOR_UNFOGGED, COLOR_FOGGED}, > + {0, 0, D3DFOG_LINEAR, D3DFOG_NONE, COLOR_UNFOGGED, COLOR_FOGGED}, > + {0, 1, D3DFOG_LINEAR, D3DFOG_NONE, COLOR_UNFOGGED, COLOR_FOGGED}, Please add a D3DFOG_NONE, D3DFOG_NONE case for completeness. In case of the shaders I expect the same result as with table fog = NONE, vertex fog = LINEAR. In case of fixed function fragment processing I expect fully fogged because it uses the alpha component of the specular color, which defaults to 0. Fogstart = 255 and fogend = 0 in that case, similar to the vertex shader oFog case. > + /* Note: Shaders expect matrices in column-major form, so they have > + * to be transposed if they are not symmetrical (which is the case at the moment). */ > + hr = IDirect3DDevice8_SetVertexShaderConstant(device, 0, &view_mat, 4); > + ok(SUCCEEDED(hr), "SetVertexShaderConstant (view matrix) failed (%08x)\n", hr); > + hr = IDirect3DDevice8_SetVertexShaderConstant(device, 4, &proj_mat, 4); > + ok(SUCCEEDED(hr), "SetVertexShaderConstant (projection matrix) failed (%08x)\n", hr); I'd expect these calls to fail on hardware that does not support shaders. Same for the Set*Shader(NULL) calls later on. Technically you do not need the matrix multiply inside the shader with the new matrices, but if you want to keep them in to make the fixed function and shader codepaths more similar that's OK with me. The D3DPRASTERCAPS_FOGTABLE capability applies to d3d8/9 as well. I don't know if there's any GPU out there that doesn't support table fog other than my ancient ATI 3D Rage. > + IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); You are not checking the return value here. > + if (caps.PixelShaderVersion >= D3DPS_VERSION(1, 1)) > + { > + hr = IDirect3DDevice9_CreateVertexShader(device, vertex_shader_code1, &vertex_shader[1]); > + ok(SUCCEEDED(hr), "CreateVertexShader failed (%08x)\n", hr); > + hr = IDirect3DDevice9_CreateVertexShader(device, vertex_shader_code2, &vertex_shader[2]); > + ok(SUCCEEDED(hr), "CreateVertexShader failed (%08x)\n", hr); > ... > + } Please check the vertex shader version separately from the pixel shader one. > diff --git a/dlls/ddraw/tests/visual.c b/dlls/ddraw/tests/visual.c > index 0385044..23542ff 100644 > --- a/dlls/ddraw/tests/visual.c > +++ b/dlls/ddraw/tests/visual.c New ddraw tests should go to dlls/ddraw/tests/ddraw*.c. I'm fine with just a ddraw7 test for this. The older ddraw interfaces have a different fog interface (D3DLIGHTSTATE_FOG*, and somehow there's a separate D3DRENDERSTATE_FOGTABLE*). While we could certainly use more tests for this interface it shouldn't be the concern of this patch. > + if (IDirect3DDevice7_BeginScene(device) == D3D_OK) This is not a big issue, but there's no need to have a code branch for BeginScene / EndScene, just let the draws in between fail like you do in d3d8/9. I have never seen a case where BeginScene fails unexpectedly. (Yeah, the existing code isn't consistent on this point.) > + hr = IDirect3DDevice8_SetRenderState(device, D3DRS_FOGEND, end.i); > + ok(SUCCEEDED(hr), "Setting fog end failed (%08x)\n", hr); > ... > + hr = IDirect3DDevice8_SetTransform(device, D3DTS_PROJECTION, &proj_mat); > + ok(SUCCEEDED(hr), "Failed to set projection transform, hr %#x.\n", hr); Another minor style issue: You're mixing %08x and %#x. The preferred one is %#x, but what mostly matters is consistency. Similar for punctuation at the end of the traces. SUCCEEDED(hr) is preferred over hr == D3D_OK. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUOFewAAoJEN0/YqbEcdMwxSYP/jFB5IT9a+7w8JQ7vlziVdGz KZccLwVFSyJqLhEiTIs7B0yz5rWhkjI6HPxzWRPRMVbNTjlUvsiZRLl8FU6hR86A 1G6azwEnMs0/u9LUOfdphBLdj454+E/NJMr1EzkRjL+PMt49RZwSxdCmxPXK/unx yrxLSPuxCjHGhN6K95/xV8fVkbJoa7va8IeKDHhfoFpdpaUqUqyGaSbNCfiyYj6l cyA8ZBlQEEEYBDg8HopQgw99MmfU3BIL4rY984YnsscYMckI5qjOs+joMcUwHscU Vaflkmh5udcj74sdgPguOwigJeLuLzY6zbWzhUGDFzdkXuwfuF0oe+ws/QcNOYX6 r2d/CGa7nYXfTFewR4SODJT+950P8CwuskLsslBAiPpy4uzVcbhKT2oNh7L7vhU1 +o6gYk98ceCaRdZxajf+j2hElg7N9AkWAK/RfLY25d3ALnKKVDbaidWKot3dVcHN nicK89v6jKSmD/FdbVM9/YUi4QzOZM5IJAItG0OuhS0oU/Bfkpr0e7NXvORxdGPC BpRvQrwIJXWiT43aqK8E1w67mE47PMmqoKjO3qVfWLojC0L7KPybDjGtUKj652Qr ixqPlaERPLeRVyAGtpxHlIE2opyx3fOSy/ZSTq6/PzK4GNZ/hgfTLbUff2ixxa+M cL3+mTtlQSBx9yt9BmUG =ZDPP -----END PGP SIGNATURE-----

1 0

Re: kernel32: fix incorrect lastpart in GetFullPathNameA with DBCS
by Akihiro Sagawa Oct. 10, 2014

Oct. 10, 2014

On Thu, 09 Oct 2014 12:03:15 -0500, Aric Stewart wrote: > --- > dlls/kernel32/path.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Hi Aric, Thank you for pointing this out, but unfortunately this seems not to be perfect. Because certain DBCS trail byte range is overlapped its lead byte range [1]. To demonstrate this issue, I attached additional test. The first case (0x955c,0x97a0=表裏) is now pass by your patch, but the second one (0x838f,0x8343,0x8393=ワイン) is failure. In my opinion, the solution is looking up the path separator from the beginning of the string like _mbsrchr() in msvcrt. If you have a further question about this, please contact me. [1] For CP 932 (Japanese Shift JIS), Double byte character: Lead byte (first byte): 0x81-0x9f or 0xe0-0xfc, and Trail byte (second byte): 0x40-0x7e or 0x80-0xfc. Single byte character: 0x00-0x7f, 0xa1-0xdf. Regards, Akihiro Sagawa

2 1

Re: wined3d: Correctly display fog for right-handed projection matrix (try 6)
by Marvin Oct. 10, 2014

Oct. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9439 Your paranoid android. === w8 (32 bit visual) === visual.c:2716: Test failed: unexpected colortable on offscreen surface

1 0

Re: [PATCH 6/6] wined3d: Don't replicate shader limits values for each shader.
by Henri Verbeet Oct. 10, 2014

Oct. 10, 2014

On 9 October 2014 18:01, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +static const struct wined3d_shader_limits vs_limits[] = This doesn't really need to be global. It's not even that I mind that much for this kind of static const array, but it actually makes things easier to keep it local to shader_set_limits(). > struct wined3d_shader_limits > { > + unsigned int min_version; > + unsigned int max_version; > unsigned int sampler; > unsigned int constant_int; > unsigned int constant_float; You don't need that to be part of wined3d_shader_limits.

1 0

Re: [PATCH 5/6] d3d9/tests: Port the unsupported shaders test to D3D9Ex.
by Henri Verbeet Oct. 10, 2014

Oct. 10, 2014

On 9 October 2014 18:00, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +static void test_unsupported_shaders(void) In principle I like this better than "test_wrong_shader()", but could you then please update the d3d8 and d3d9 tests as well? It's a lot easier to find equivalent tests between D3D versions if they at least have the same name.

1 0

Re: [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.
by Francois Gouget Oct. 10, 2014

Oct. 10, 2014

On Wed, 8 Oct 2014, Stefan Dösinger wrote: [...] > There are many more failures in d3d8:device when the test is not in > foreground. Those failures write static lines and I'd prefer the testbot > to be changed to run them in foreground instead. What do you mean by that? The TestBot runs a command line tool in an iconized console. In turn that tool runs the test binary. However I'm not aware of it preventing test windows from being in the foreground. Maybe the console windows being iconized somehow gets inherited by the windows created by the test binary, but shouldn't the test just request to bring its windows to the foreground? -- Francois Gouget <fgouget(a)codeweavers.com>

3 2

Re: [3/3] msvcrt: Added _fflush_nolock() implementation
by Piotr Caban Oct. 10, 2014

Oct. 10, 2014

On 10/09/14 19:52, Iván Matellanes wrote: > @@ -921,22 +921,36 @@ int CDECL MSVCRT_fflush(MSVCRT_FILE* file) > { > if(!file) { > msvcrt_flush_all_buffers(MSVCRT__IOWRT); > + } else if(file->_flag & MSVCRT__IOWRT || file->_flag & MSVCRT__IOREAD) { > + int ret; > + > + MSVCRT__lock_file(file); > + ret = MSVCRT__fflush_nolock(file); > + MSVCRT__unlock_file(file); > + > + return ret; > + } > + return 0; > +} file->_flag should be checked inside the lock (it's already done inside fflush_nolock). Could you please change the code to something like this: if(!file) msvcrt_flush_all_buffers(MSVCRT__IOWRT); MSVCRT__lock_file(file); ret = MSVCRT__fflush_nolock(file); MSVCRT__unlock_file(file); Thanks, Piotr

1 0

Re: kernel32: fix incorrect lastpart in GetFullPathNameA with DBCS
by Dmitry Timoshkov Oct. 10, 2014

Oct. 10, 2014

Aric Stewart <aric(a)codeweavers.com> wrote: > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -271,7 +271,8 @@ DWORD WINAPI GetFullPathNameA( LPCSTR name, DWORD len, LPSTR buffer, > > if (*p != '\\') > { > - while ((p > buffer + 2) && (*p != '\\')) p--; > + while ((p > buffer + 2) && > + ((*p != '\\') || IsDBCSLeadByte(*(p-1)))) p--; This probably should depend on whether ansi or oem code page is active. -- Dmitry.

1 0

Re: [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.
by Henri Verbeet Oct. 9, 2014

Oct. 9, 2014

On 8 October 2014 14:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > These two patches fix test failures when the process is not in > foreground that print changing error lines. This avoids generating > warnings from the testbot whenever d3d8/tests/device.c is touched. > > There are many more failures in d3d8:device when the test is not in > foreground. Those failures write static lines and I'd prefer the testbot > to be changed to run them in foreground instead. Why does this affect d3d8, but not d3d9?

2 1

Re: [PATCH 7/7] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin Oct. 9, 2014

Oct. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9400 Your paranoid android. === w7u (32 bit script) === script.c:632: Test failed: L"elem.readyState = loading" === w8 (32 bit script) === script.c:632: Test failed: L"elem.readyState = loading" script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1,"

1 0

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar. (try 2)
by Alexandre Julliard Oct. 9, 2014

Oct. 9, 2014

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Sorry, I noticed a couple of errors in the utf7_mbstowcs and > utf7_wcstombs documentation. They are now corrected. You still haven't addressed the issues I mentioned last time around. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: msvcr90: Prefer native dll if manifest is not present
by Nikolay Sivov Oct. 8, 2014

Oct. 8, 2014

> +#if _MSVCR_VER == 90 > + static const WCHAR msvcr90W[] = {'m','s','v','c','r','9','0','.','d','l','l',0}; > + ACTCTX_SECTION_KEYED_DATA askd = { sizeof(askd) }; > + > + if(FindActCtxSectionStringW(FIND_ACTCTX_SECTION_KEY_RETURN_HACTCTX, NULL, > + ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, msvcr90W, &askd)) { > + ReleaseActCtx(askd.hActCtx); > + return TRUE; > + } > + > + return FALSE; > +#endif It looks like you won't be using context handle anyway, so you can just set flags to zero, and return FindActCtxSectionStringW() value immediately.

2 1

Re: [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.
by Marvin Oct. 8, 2014

Oct. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9361 Your paranoid android. === w8 (32 bit device) === device.c:3043: Test failed: Expected wndproc 0x412d00, got 0x412d00.

1 0

Re: msvcr90: Prefer native dll if manifest is not present
by Stefan Dösinger Oct. 8, 2014

Oct. 8, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-08 16:35, schrieb Piotr Caban: > DVDFab 9.x is distributed with custom version of msvcr90.dll that > is not compatible with normal dll. I think this comment should go into the code because Alexandre removes it from the commit log. It will be hard to find out the reason for this code without it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUNU0oAAoJEN0/YqbEcdMwalAP/2PgH8yjUYkTImTuMCeFj0+z ZBNVOkDz6+1/qeWZvA7YdnkZ8GqBaAZ48KBTgMMFyjUjiot2Ee2SbfyEJfHGBNE3 PBBaLzWIoxxkSDzkVK4A5XTDqx3gAueiTX79dS3cYd1R2Zb+rnFSkDkxSv0S03Q0 xY/ig2KDcYnm5BXfPcrV9PKTsBzLrJ+73t+4uBh3cKY623V8umZObyjq9yYNdwFn lSH3fIhUM60U6r4xMOw4YkiI7GJ5otlf7ORAA6zh+4N0oKwkcPiC6NJ3a/HLW6xG dyw9fQ3183puDWE+3Fi0ufHSTcbp6evMqY4WhOWwNYRNTjQdMcIY23S6rATGfqS9 TieSwABJ4L3quQ0zjmw920x4rTh7/XAMC3gEpXjlFF23LniHDnQtKjwckHk5a2vh qqDQ7+y7bywb6CDGUJCo/Mp6mT5Mt4qcL3/CZtuCsLM5FLYgvAXaGw3IYTCCxAnF F198/g1En1zjdbJmvDWAda4YAD9ffdmkWrppW0Oq7p8klyd35OktJ4LS6ULqb2jo K90+Ss+5N55rmhfGqPRgWifu+gRK3bdO08YpKkhhGyv6J+5DFyyB7uBqbSnjMNbR 25M2aPGvH4jB9vDD9DVSkt4q35FDmHVRYThW+3L3W92q0WatHhyWwoMTY6f+rvGj ftkB6MWECB/XTl1QxMQW =qeov -----END PGP SIGNATURE-----

1 0

Wine 1.7.28 source code
by Игорь Чебаненко Oct. 8, 2014

Oct. 8, 2014

Hello,I scanned Wine 1.7.28 source code with cppcheck 1.63. I hope my scanning will get attention. Threre's lots of false-positives,but,I think,in my file you will see interesting things. P.S Thank you for Wine. It is very interesting,and important open source project.

3 2

Re: kernel32: add a stub for GetSystemFileCacheSize (2/2)
by Alistair Leslie-Hughes Oct. 8, 2014

Oct. 8, 2014

On 08/10/14 06:37, Austin English wrote: > > @·stub·SetSystemFileCacheSize > +@·stdcall·SetSystemFileCacheSize(long·long·long)·kernel32.SetSystemFileCacheSize > This patch doesn't match the subject. Best Regards Alistair Leslie-Hughes

2 1

Re: [PATCH] mscoree: Use E_NOT_SUFFICIENT_BUFFER definition
by Marvin Oct. 8, 2014

Oct. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9344 Your paranoid android. === wxppro (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === wvistau64 (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w2008s64 (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w7u (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w8 (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === wvistau64 (64 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w2008s64 (64 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f

2 1

Re: wined3d: Correctly display fog for right-handed projection matrix (try 5)
by Stefan Dösinger Oct. 7, 2014

Oct. 7, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2014-10-04 00:24, schrieb Joachim Priesner: > + static const D3DMATRIX proj_mat_rh = > + {{{ > + 0.828732f, 0.0f, 0.0f, 0.0f, > + 0.0f, 1.104976f, 0.0f, 0.0f, > + 0.0f, 0.0f, -1.0001f, -1.0f, > + 0.0f, 0.0f, -0.010001f, 0.0f > + }}}; > ... > + static const D3DMATRIX view_mat_rh = > + {{{ > + 1.0f, 0.0f, 0.0f, 0.0f, > + 0.0f, 1.0f, 0.0f, 0.0f, > + 0.0f, 0.0f, -0.1f, 0.0f, > + 0.0f, 0.0f, 0.0f, 1.0f > + }}}; I'm sorry that this reply is a bit late, but I've been wondering if you need the complicated projection matrix to show the abs() in the vertex pipeline. If I understand it correctly, a view and projection matrix like this should do the job as well with the same input coordinates: static const D3DMATRIX proj_mat = {{{ 1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f, 0.0f, 0.0f, -1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f }}}; static const D3DMATRIX view_mat = {{{ 1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f, 0.0f, 0.0f, -0.1f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f }}}; The test results with these matrices are identical, and the test correctly detects the defect in Wine. The test is much easier to follow. Am I missing something? As an added bonus you could replace the 10.0f in the input vertices with 1.0 and the -0.1f in the view matrix with -1.0f. Some other suggestions: > +/* Some color constants to make tests easier to read. */ > +#define COLOR_FOG 0xff00ff00 > +#define COLOR_FOGGED 0x0000ff00 > +#define COLOR_UNFOGGED 0x00ff0000 > +#define COLOR_CLEAR 0xffff00ff IMHO it would be nicer to either use an enum in the scope of fog_righthanded_test (preferred) or #undef them after the function. > + static struct > + { > + struct vec3 position; > + DWORD diffuse; > + } > + quad[] = > + { > + {{-1.0f, -1.0f, 10.0f}, COLOR_UNFOGGED}, > + {{-1.0f, 1.0f, 10.0f}, COLOR_UNFOGGED}, > + {{ 1.0f, -1.0f, 10.0f}, COLOR_UNFOGGED}, > + {{ 1.0f, 1.0f, 10.0f}, COLOR_UNFOGGED}, > + }; Always drawing a gradient would be better. That avoids other fog setup problems that lead to either always fogged or never fogged quads. Also, this can be static const in d3d8 and d3d9. > + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET | D3DCLEAR_ZBUFFER, COLOR_CLEAR, 1.0f, 0); > + ok(SUCCEEDED(hr), "IDirect3DDevice9_Clear failed (%08x)\n", hr); Do you need the Z buffer? Just disable the depth test, no need to clear it. > + /* Basic vertex shader with fog computation ("foggy"). > + * Using the vertex' x coordinate as fog coordinate so that all test cases that use vertex fog > + * will have a gradient from fully fogged (green, left) to unfogged (red, right). */ > + static const DWORD vertex_shader_code2[] = > + { > + 0xfffe0100, /* vs_1_0 */ > ... > + 0x0000ffff, /* END */ > + }; > + > + /* Basic pixel shader */ Two indentation issues here. The comment needs one extra space, the closing bracket has one too many. I suspect your editor screwed this up when you copied the code from d3d9 to d3d8. > + if (caps.PixelShaderVersion >= D3DPS_VERSION(2, 0)) > + { > + hr = IDirect3DDevice9_CreateVertexShader(device, vertex_shader_code3, &vertex_shader[3]); > + ok(SUCCEEDED(hr), "CreateVertexShader failed (%08x)\n", hr); > + hr = IDirect3DDevice9_CreatePixelShader(device, pixel_shader_code2, &pixel_shader[2]); > + ok(SUCCEEDED(hr), "CreatePixelShader failed (%08x)\n", hr); > + } else { > + skip("No shader model 2 support, skipping some fog tests.\n"); > + } Curly bracket placement. This applies to a few other places. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUNGWtAAoJEN0/YqbEcdMw/+YQAIQxmRjeNMne0+f9AuCwtNVJ /MrhsXPnCFDWbYE6BTXM8/2CvlM5DzhCya2AQg8UFW4qMXQJmijTorCjDF0e7Vc7 RvuP4xJXsqhKDhyoYfSzcX8WYkJZcVow0tQIz++qKfjMbgqnGwoWocYdNgyymy9v pU6Q/shM1qv2PUkDNuMAJI7Tv09R5muYEyi9sfRa+grFGQwDJGQpgOXwP5oR2DWM wjlTIO7wMkXY0XGE5DInxE+slaF2gECrKrHRM+1HNicNq5hGOwYwdm/JcBA9qxGQ uv+w0WMKR0n4FPtJBHXcm3/qshUyBvzSsMSEilfBwOzrrclOx9ctNEuogqufEpF9 6yGuX0PEp+W9g9rN6rCMMBjYmGJdal2bY2F1KQ+iLAYHhMsahy+fibIGEwE7Yugg +ffx3RONm335mpZqQh5NrtHAwf3iLEEA7PQQawW5UKCoKANpV03KyZBFJLZ1lOC4 cEQLQQNo7p/M0211bm4dTN8SSYvucloDSuzwe+PqCNvyL8xJyJCiHMHuVX2cFdgt 7qPA13LdKze/7S4Jk1JjL31tTEdMCGZJSekkTEAJ7C/c01L3DiDVywn9VNVXdPsR 8oW8pfZI0t1g2/Miq08mP1T+IWTftYOQaHyiYrQ73hu8PtDgY3C92JHwV4SmvPUI UxItWlY/H/8FLJG5v5dt =dUDt -----END PGP SIGNATURE-----

1 0

Re: server: KeyNameInformation returns the full name of the key. (try 2)
by Alexandre Julliard Oct. 7, 2014

Oct. 7, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 2: > - Use `for' loops instead of `while' loops in get_key_full_name function. > - Introduce full_name variable to avoid tricky free() condition check at > end of enum_key function. You should be able to do this without allocating memory. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] d3d8/tests: Introduce a create_device_pp function for custom present parameters.
by Marvin Oct. 7, 2014

Oct. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9329 Your paranoid android. === w8 (32 bit device) === device.c:2401: Test failed: Expected foreground window 000B00F8, got 0002004C. device.c:3043: Test failed: Expected wndproc 0x412bd0, got 0x412bd0.

1 0

Re: ntdll: Introduce new function wine_server_set_reply_user for user provided pointers.
by Alexandre Julliard Oct. 7, 2014

Oct. 7, 2014

Sebastian Lackner <sebastian(a)fds-team.de> writes: > This patch is an alternative strategy for fixing the issue described > in http://source.winehq.org/patches/data/106864. Please note that the > patches 2-4 from the previous series are still valid, and can be > applied independently. > > Although Andre_H and ehoover told me that this solution will not be > accepted, I'll give it a try, because its the cleanest approach I can > think of. > > There is a huge amount of wineserver calls that use > wine_server_set_reply incorrectly, and manually adding code to all > these functions seems very complicated. In ntdll we have to use > virtual_check_buffer_for_write, everywhere else we have to use > IsBadWritePtr. And even if we have added that, it could still break > things: When we add the check at the top of each affected function, > and return some general error codes, it could break apps which expect > a page fault exception in some other code branch. There are few places that need this, and even fewer where it's an actual problem in practice. In fact it wouldn't be a problem at all except for your writecopy hack, which is in itself a questionable change. You'll need more convincing arguments for this series. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine crashed on exiting inside gdiplus.
by Hin-Tak Leung Oct. 6, 2014

Oct. 6, 2014

It is probably not important, just in case it is something easily fixable, I just got a crash on exit inside gdiplus. $ git describe wine-1.7.28 the backtrace is: Backtrace: =>0 0x7dcfed37 ipicture_pixel_width+0x7(pic=0xfeeefeee) [/home/Nobak-Hin-Tak/tmp-git/wine/dlls/gdiplus/../../include/ocidl.h:1221] in gdiplus (0x00e7e428) 1 0x7dd0b61b GdipGetImageBounds+0x15a(image=0x4eb5d40, srcRect=0xe7e548, srcUnit=0xe7e4c4) [/home/Nobak-Hin-Tak/tmp-git/wine/dlls/gdiplus/image.c:2182] in gdiplus (0x00e7e488) 2 0x7dce6f9e get_graphics_bounds+0x17d(graphics=<is not available>, rect=<is not available>) [/home/Nobak-Hin-Tak/tmp-git/wine/dlls/gdiplus/graphics.c:1999] in gdiplus (0x00e7e508) 3 0x7dcf2065 GdipGetDC+0xe4(graphics=<is not available>, hdc=<is not available>) [/home/Nobak-Hin-Tak/tmp-git/wine/dlls/gdiplus/graphics.c:5719] in gdiplus (0x00e7e598) 4 0x00bad6c0 (0x00e7e5e8) 5 0x00bad65c (0x00e7e608) ... ... 0x7dcfed37 ipicture_pixel_width+0x7 [/home/Nobak-Hin-Tak/tmp-git/wine/dlls/gdiplus/../../include/ocidl.h:1221] in gdiplus: movl 0x0(%eax),%edx 1221 return This->lpVtbl->get_Width(This,pWidth);

1 0

Re: po: Update German translation.
by Joachim Priesner Oct. 6, 2014

Oct. 6, 2014

> #: jscript.rc:40 > > -#, fuzzy > -#| msgid "Subject Key Identifier" > > msgid "Expected identifier" > > -msgstr "SchlÃ¼sselkennung des Antragstellers" > +msgstr "Erwarteter Bezeichner" This should probably read "Bezeichner erwartet". Best Joachim

1 0

Re: [PATCH 7/7] user32/tests: Test WM_SYSCOMMAND(SC_MINIMIZE) on an unminimizable window.
by Marvin Oct. 6, 2014

Oct. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9283 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:4466: Test failed: SendMessage( WM_SYSCOMMAND, SC_MINIMIZE ):popup, unminimizable: 6: the msg 0x0046 was expected, but got msg 0x0088 instead msg.c:4466: Test failed: SendMessage( WM_SYSCOMMAND, SC_MINIMIZE ):popup, unminimizable: 7: the msg 0x0083 was expected, but got msg 0x0046 instead msg.c:4466: Test failed: SendMessage( WM_SYSCOMMAND, SC_MINIMIZE ):popup, unminimizable: 10: the msg 0x0047 was expected, but got msg 0x0083 instead msg.c:4466: Test failed: SendMessage( WM_SYSCOMMAND, SC_MINIMIZE ):popup, unminimizable: 11: the msg 0x0003 was expected, but got msg 0x0085 instead msg.c:4466: Test failed: SendMessage( WM_SYSCOMMAND, SC_MINIMIZE ):popup, unminimizable: 12: the msg 0x0005 was expected, but got msg 0x000d instead msg.c:4466: Test failed: SendMessage( WM_SYSCOMMAND, SC_MINIMIZE ):popup, unminimizable: 14: the msg sequence is not complete: expected 0000 - actual 0047 === w7u (32 bit msg) === msg.c:12187: Test failed: unexpected hwnd 00080150 msg.c:12209: Test failed: bad time 30ba3/30bb3

2 1

Re: [1/4] ntdll: Trigger write watches before passing userdata pointer to wait_reply.
by Alexandre Julliard Oct. 6, 2014

Oct. 6, 2014

Sebastian Lackner <sebastian(a)fds-team.de> writes: > The reply_data field sometimes points directly to user-provided > memory. That's not supposed to happen. Callers that do that should be fixed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/7] wined3d: Restore the display mode on focus loss (v2).
by Henri Verbeet Oct. 6, 2014

Oct. 6, 2014

On 6 October 2014 13:42, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static BOOL wined3d_swapchain_mode_changed(const struct wined3d_swapchain *swapchain) > +{ > + return swapchain->desc.backbuffer_width != swapchain->original_mode.width > + || swapchain->desc.backbuffer_height != swapchain->original_mode.height > + || swapchain->desc.backbuffer_format != swapchain->original_mode.format_id > + || swapchain->desc.refresh_rate != swapchain->original_mode.refresh_rate; > +} > + > void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) > { > if (!activate) > + { > + if (wined3d_swapchain_mode_changed(swapchain)) > + { > + if (FAILED(wined3d_set_adapter_display_mode(swapchain->device->wined3d, > + swapchain->device->adapter->ordinal, &swapchain->original_mode))) > + ERR("Failed to set display mode.\n"); > + > + swapchain->reapply_mode = TRUE; This seems to imply that if an application created a fullscreen swapchain at the current display resolution, but then some external mode change happened, we should keep the mode from the external mode change on focus loss, but then change it on reset. That may be correct, but it's certainly more complicated than just resetting the original mode on focus loss, and I don't see tests. As a follow up, it would perhaps also be interesting to verify that in some of the places where we're currently using "original_mode", we really shouldn't be using EnumDisplaySettings() with ENUM_REGISTRY_SETTINGS instead.

2 2

Re: [PATCH 6/7] user32/tests: Test minimizing an unminimizable window. (v2)
by Marvin Oct. 6, 2014

Oct. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9282 Your paranoid android. === w7u (32 bit msg) === msg.c:12150: Test failed: unexpected hwnd 0011013C msg.c:12172: Test failed: bad time 31592/315a2

1 0

Re: [PATCH 3/7] d3d9/tests: Test messages on focus loss (v3).
by Henri Verbeet Oct. 6, 2014

Oct. 6, 2014

On 6 October 2014 13:42, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - device = create_device(d3d9, device_window, focus_window, FALSE); > - if (!device) > + present_parameters.Windowed = FALSE; > + present_parameters.hDeviceWindow = device_window; > + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; > + present_parameters.BackBufferWidth = 640; > + present_parameters.BackBufferHeight = 480; > + present_parameters.BackBufferFormat = D3DFMT_A8R8G8B8; > + if (FAILED(IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, focus_window, > + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device))) We're just hoping the display resolution isn't already 640x480 here, right? I'd also rather see this using create_device(). Or perhaps some variant like create_device_pp() taking a D3DPRESENT_PARAMETERS structure, although it seems to me that the issue you're running into is just that screen_width and screen_height aren't very good choices for the backbuffer dimensions in the general case.

2 1

Re: [PATCH 5/7] d3d8/tests: Test messages on focus loss (v3).
by Marvin Oct. 6, 2014

Oct. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9281 Your paranoid android. === w8 (32 bit device) === device.c:2489: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3131: Test failed: Expected wndproc 0x413080, got 0x413080.

1 0

Re: [PATCH 4/7] d3d9/tests: Port test_wndproc to d3d9ex (v2).
by Henri Verbeet Oct. 6, 2014

Oct. 6, 2014

On 6 October 2014 13:42, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + ret = pEnumDisplaySettingsExA(NULL, ENUM_CURRENT_SETTINGS, &orig_mode, 0); Why the Ex versions here? > + user32_handle = GetModuleHandleA("user32.dll"); > + pEnumDisplaySettingsExA = (void*)GetProcAddress(user32_handle, "EnumDisplaySettingsExA"); > + pChangeDisplaySettingsExA = (void*)GetProcAddress(user32_handle, "ChangeDisplaySettingsExA"); I also suspect we don't need to get these through GetProcAddress() on any setup where we still run the tests.

1 0

Wine staging tree
by Michael Müller Oct. 6, 2014

Oct. 6, 2014

Hi, since I already revealed our staging tree idea in a mail which I accidentally send to wine-devel, I think it is time to explain the whole idea. Before you start complaining, please carefully read the whole mail, and especially note that we're in no way trying to compete with vanilla Wine (which seems to be the main counter-argument I've heard so far). Wine is a huge project and it is easy to introduce new regressions or to have mistakes in your patches. For this reason all patches need to be accepted by AJ to keep a good code quality. Nevertheless it is not unusual that patches drop out of the list because they don't get any attention or contributors get frustrated because sending try XX is a slow process of gaining feedback. Just to be clear: I think its absolutely essential that Wine has a stable and very well tested code base, so I'm _not_ suggesting to change the submission rules. Nevertheless its sometimes impossible to test a patch, without having some user feedback. Besides that, there is a huge gap between Wine user perspective and Wine developer perspective: Users sometimes would prefer to use an early beta version of a patch (which might not be the perfect solution, but the application at least works), whereas developers prefer a well-tested and 100% correct solution. For this reason we converted wine-compholio (which was previously used to provide patches for Silverlight / Pipelight) to some kind of staging tree. We add patches there which may not be yet be completely ready for wine-patches, for example some features are not fully implemented yet or need additional testing. This makes it possible for other developers to take a look at them before they reach wine-patches and they can give you feedback and point out possible mistakes. This is especially suited for new contributors. Just think about all the GSoC students, which spend months to implement new features, and at the end the code is lost and not really maintained anymore, because it wasn't in a perfect shape yet to go upstream. That shouldn't happen at my opinion. Besides the possibility of getting feedback, your patches will also be tested by regular users to reveal regressions. We follow the same release cycle as Wine (with usually 1 days offset) and provide prebuilt packages for: Ubuntu, Arch Linux, Debian, OpenSUSE, Fedora, Mageia 4 and there are also 3rd party builds for other distributions like Slackware. Fedora directly integrates our patches into their wine package. Some users also prefer wine-compholio since they get patches for their software earlier, and developers have the advantage to know about regressions faster. Although being a staging tree, we don't want to break too much stuff for our users and therefore do not accept any hacks like PlayOnLinux. If there is a highly demanded application with a known workaround, we may consider making an exception - but we _definitely_ don't want to end up like PlayOnLinux ;-). We always try to find a compromise between the user and the developers perspective. However, If you introduce regressions and don't fix them till the next release we may consider dropping the patches again. Since our aim is to get patches upstream, our repo does not contain the whole wine source code but only patches to make this task easy. We also use a sophisticated patch system which creates a Makefile that automatically figures out dependencies between patchsets and prevents adding patches that do not apply, but explaining all that would be too much for this mail ;-). If you think this might be a great idea and/or you want to make use of it, you can find all required information at: https://github.com/compholio/wine-compholio https://github.com/compholio/wine-compholio/blob/master/DEVELOPER.md We also try to improve existing patches from bugs or patches which did not get upstream, so don't be surprised if you find one your patches in our repo. ;-) There is currently no mailing list for suggesting patches (as mentioned at the beginning our original plan was to wait a bit more, before officially announcing this idea), but you can either talk to us in #wine-compholio on FreeNode or open a bug report on github to propose patches. We neither want to prevent anybody from sending their patches upstream, nor to be a competitor to Wine, we just want to give some optional extra help for both developers and users. Instead of having lots of private developer work-in-progress branches, this makes it possible to create a combined version, and users get an easy way to test fixes without compiling wine on their own (for example if you have a fix for a bug and want other people to verify whether it solves the problem for them). Regards, Michael

9 13

Re: msvcrt: Added _fclose_nolock() implementation.
by Piotr Caban Oct. 6, 2014

Oct. 6, 2014

On 10/04/14 18:53, Iván Matellanes wrote: > Added _fclose_nolock() implementation. Could you please also change _fclose implementation so it calls _fclose_nolock internally? This will avoid some code duplication. Thanks, Piotr

1 0

Re: [PATCH 2/2] gameux: Use CLSIDFromString() instead of shell32 equivalent
by Marvin Oct. 6, 2014

Oct. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9268 Your paranoid android. === w8 (32 bit gameexplorer) === No test summary line found

1 0

[PATCH] dbghelp: implement DW_TAG_const_type in dwarf2_parse_udt_type
by David Heidelberger Oct. 5, 2014

Oct. 5, 2014

Also solve spamming debug output with these messages: fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x26 at ctx(0x33c42c,L"ourlib.so.0"), for debug_info(abbrev:0x1360224,symt:0x159ed70) Signed-off-by: David Heidelberger <david.heidelberger(a)ixit.cz> --- dlls/dbghelp/dwarf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index e7c36b0..1f85f6b 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -1453,6 +1453,9 @@ static struct symt* dwarf2_parse_udt_type(dwarf2_parse_context_t* ctx, case DW_TAG_subprogram: dwarf2_parse_subprogram(ctx, child); break; + case DW_TAG_const_type: + dwarf2_parse_const_type(ctx, child); + break; case DW_TAG_structure_type: case DW_TAG_class_type: case DW_TAG_union_type: -- 2.1.1

1 0

Re: [PATCH] kernel32/nls: Added support for LOCALE_SOPENTYPELANGUAGETAG
by Alistair Leslie-Hughes Oct. 5, 2014

Oct. 5, 2014

On 05/10/14 07:14, Nikolay Sivov wrote: > --- > > +WINBASEAPI·INT·········WINAPI·GetLocaleInfoEx(LPCWSTR,LCTYPE,LPWSTR,INT); > This looks like it doesn't belong to this patch. Best Regards Alistair Leslie-Hughes

2 1

Win10 winetest results
by André Hentschel Oct. 4, 2014

Oct. 4, 2014

Hi, i tried winetest on a fresh win10 (technical preview) install... because of the error number i can't upload it to test.winehq.org for easier review... But here they are: http://wine.dawncrow.de/win10/res164F.tmp http://wine.dawncrow.de/win10/resB470.tmp

1 0

Re: [PATCH] ntdll: test also FullDirectoryInformation
by Marvin Oct. 4, 2014

Oct. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9261 Your paranoid android. === w2000pro (32 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === wxppro (32 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === wvistau64 (32 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === w2008s64 (32 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === w7u (32 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === w8 (32 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === wvistau64 (64 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1 === w2008s64 (64 bit directory) === directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 1, single_entry 1 directory.c:251: Test failed: not enough data in directory (72 expected, 70 got, fnamelen 2), restart 0, single_entry 1

1 0

Re: wined3d: Correctly display fog for right-handed projection matrix (try 5)
by Marvin Oct. 4, 2014

Oct. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9259 Your paranoid android. === w8 (32 bit visual) === visual.c:2717: Test failed: unexpected colortable on offscreen surface

2 1

Re: [PATCH 5/5] ws2_32: Return WSAEINVAL if "out_size" is smaller than the minimum size for SIO_ADDRESS_LIST_QUERY.
by Marvin Oct. 3, 2014

Oct. 3, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9245 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

2 1

Re: [PATCH] jscript: Ignore BOM mark in next_token. (try 5)
by Nikolay Sivov Oct. 3, 2014

Oct. 3, 2014

> static BOOL skip_spaces(parser_ctx_t *ctx) > { > - while(ctx->ptr < ctx->end && isspaceW(*ctx->ptr)) { > + while(ctx->ptr < ctx->end && (isspaceW(*ctx->ptr) || *ctx->ptr == 0xFEFF /* UTF16 BOM */)) { > if(is_endline(*ctx->ptr++)) > ctx->nl = TRUE; > } This looks correct according to ECMA-252 section 7.2 - all of the following is a whitespace: - tab and vertical tab, 0x9 and 0xb; - form feed 0xc - space 0x20 - NBSP 0xa0 - UTF-16 BOM 0xfeff - any other Unicode "space separator" Hopefully isspaceW() covers everything but the BOM. What worries me is that isspaceW() itself is used in numerous places in code on its own. So probably we need more tests to cover more cases where space separators could be used, and later have our own is_space() call that will conform to the standard.

3 5

Re: [PATCH] user32/tests: Test minimizing an unminimizable window. (v2)
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9217 Your paranoid android. === w7u (32 bit msg) === msg.c:11961: Test failed: got message 102 msg.c:11966: Test failed: bad wparam 201a/2260 msg.c:11978: Test failed: bad wparam 201a/2260 msg.c:11985: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:11987: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:11994: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:11996: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12003: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12005: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12012: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12014: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12021: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12023: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12031: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12034: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12039: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12041: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12049: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12057: Test failed: bad wparam 201a/2260 msg.c:12061: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12069: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12071: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12073: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12082: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12085: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12087: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12093: Test failed: no messages: 0: the msg sequence is not complete: expected 0000 - actual 0102 msg.c:12095: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12097: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a msg.c:12102: Test failed: Unicode WM_CHAR: 0: in msg 0x0102 expecting wParam 0x2260 got 0x201a0081 msg.c:12111: Test failed: bad wparam 81/30fb msg.c:12118: Test failed: bad wparam 81/30fb msg.c:12129: Test failed: bad wparam 3f/81 msg.c:12131: Test failed: no message msg.c:12134: Test failed: bad wparam 3f/81 msg.c:12144: Test failed: bad wparam 3f/81 msg.c:12150: Test failed: unexpected hwnd 00060150 msg.c:12152: Test failed: bad wparam 81/81 msg.c:12161: Test failed: bad wparam 3f/81 msg.c:12168: Test failed: unexpected hwnd 00000000 msg.c:12170: Test failed: bad wparam 81/81 msg.c:12171: Test failed: bad lparam 0 msg.c:12183: Test failed: bad wparam 3f/81 msg.c:12188: Test failed: bad wparam 3f/81 msg.c:12190: Test failed: no message msg.c:12193: Test failed: bad wparam 3f/81 msg.c:12195: Test failed: no message msg.c:12198: Test failed: bad wparam 3f/81

1 0

Re: [2/3] shlwapi: Fix swapped argument order in SHMapHandle.
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9214 Your paranoid android. === wvistau64 (32 bit ordinal) === ordinal.c:548: Test failed: SHMapHandle failed: 6 ordinal.c:551: Test failed: SHLockShared failed: 87 ordinal.c:557: Test failed: SHUnlockShared failed: 487 === w2008s64 (32 bit ordinal) === ordinal.c:548: Test failed: SHMapHandle failed: 6 ordinal.c:551: Test failed: SHLockShared failed: 87 ordinal.c:557: Test failed: SHUnlockShared failed: 487 === wvistau64 (64 bit ordinal) === ordinal.c:548: Test failed: SHMapHandle failed: 6 ordinal.c:551: Test failed: SHLockShared failed: 87 ordinal.c:557: Test failed: SHUnlockShared failed: 487 === w2008s64 (64 bit ordinal) === ordinal.c:548: Test failed: SHMapHandle failed: 6 ordinal.c:551: Test failed: SHLockShared failed: 87 ordinal.c:557: Test failed: SHUnlockShared failed: 487

1 0

Re: [1/3] shlwapi/tests: Add test for SHMapHandle.
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9213 Your paranoid android. === wvistau64 (32 bit ordinal) === ordinal.c:549: Test failed: SHMapHandle failed: 6 ordinal.c:553: Test failed: SHLockShared failed: 87 ordinal.c:560: Test failed: SHUnlockShared failed: 487 === w2008s64 (32 bit ordinal) === ordinal.c:549: Test failed: SHMapHandle failed: 6 ordinal.c:553: Test failed: SHLockShared failed: 87 ordinal.c:560: Test failed: SHUnlockShared failed: 487 === wvistau64 (64 bit ordinal) === ordinal.c:549: Test failed: SHMapHandle failed: 6 ordinal.c:553: Test failed: SHLockShared failed: 87 ordinal.c:560: Test failed: SHUnlockShared failed: 487 === w2008s64 (64 bit ordinal) === ordinal.c:549: Test failed: SHMapHandle failed: 6 ordinal.c:553: Test failed: SHLockShared failed: 87 ordinal.c:560: Test failed: SHUnlockShared failed: 487

1 0

Re: [PATCH 3/3] jscript: Added support for relational CC expressions.
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9211 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3] jscript: Added support for '==' CC expression.
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9210 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [2/2] kernel32/tests: Add tests for FindFirstFileExA with FIND_FIRST_EX_CASE_SENSITIVE flag.
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9200 Your paranoid android. === wvistau64 (32 bit file) === file.c:367: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:367: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [1/2] kernel32/tests: Add tests for FindFirstFileExA with FIND_FIRST_EX_LARGE_FETCH flag.
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9199 Your paranoid android. === wvistau64 (32 bit file) === file.c:367: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:367: Test failed: attributes of file "testfile.xxx" are 0x0820

2 1

Re: Assorted spelling/grammar fixes
by Marvin Oct. 2, 2014

Oct. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9197 Your paranoid android. === w8 (32 bit visual) === visual.c:2635: Test failed: unexpected colortable on offscreen surface

1 0

Re: msvcrt: Make the first call to fwrite bufferred (try2)
by Andreas Fuchs Oct. 2, 2014

Oct. 2, 2014

Hi Piotr, Hi all, I traced down this commit as the origin of the regression, where I cannot parse stdout of wine correctly anymore. See also https://bugs.winehq.org/show_bug.cgi?id=37345 I hope, sombody knowledgable (Piotr maybe you as the author) could help me figure this out or even provide a fix... Description: When calling wine from another process after redirecting stdout to a pipe, wine does not flush the stdout-buffer correctly anymore (Wine 1.6 did correctly). Attached is a usecase. To test do: i686-w64-mingw32-gcc helloworld.c gcc callwine.c ./a.out What will happen is: - on a buggy wine it will take 10 seconds and then all of the stdout-buffer is flushed on the exit of the child. (imagine the child would run longer than the 10 seconds) - on a good wine we will see some stdout-content then 10 second sleep and then the rest of the content. This is a regression that happened between 1.7.4 and 1.7.5. The bisect identified commit afec0b00bd6250fe21e8deccbc8116a4aca6a7a4 "msvcrt: Make the first call to fwrite buffered." as problem. The attached patch is a revert of this commit ported forward to 1.7.27. Unfortunately I don't quite grasp the logics of the offending commit. If somebody who knows that patch could help, I'd highly appreciate it. Cheers, Andreas

3 2

Re: [PATCH 1/3] comctl32: Move TaskDialogIndirect function to separate file
by Nikolay Sivov Oct. 2, 2014

Oct. 2, 2014

On 10/1/2014 16:35, Joachim Priesner wrote: > +#include <stdarg.h> > +#include <string.h> > + > +#include "comctl32.h" > +#include "shlwapi.h" > + > +#include "windef.h" > +#include "winbase.h" > +#include "wingdi.h" > +#include "winternl.h" > +#include "dlgs.h" > +#include "wine/debug.h" > +#include "wine/unicode.h" It's unlikely you need all of those. > +#define TD_WARNING_ICON MAKEINTRESOURCEW(-1) > +#define TD_ERROR_ICON MAKEINTRESOURCEW(-2) > +#define TD_INFORMATION_ICON MAKEINTRESOURCEW(-3) > +#define TD_SHIELD_ICON MAKEINTRESOURCEW(-4) Where this comes from? I mean particular id values.

2 2

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.
by Dmitry Timoshkov Oct. 2, 2014

Oct. 2, 2014

Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This shows that the abesence of a minimization button does not prevent > the application from programmatically minimizing the window. KWin and > fvwm behave like Windows in this regard, whereas Metacity-based WMs > prevent the minimization. My understanding is that not the absence of minimize/maximize button prevents an ability to programmatically minimize/maximize a window, but an item in the system menu. I'd suggest to also add a test for sending WM_SYSCOMMAND/SC_MINIMIZE/SC_MAXIMIZE behaviour. -- Dmitry.

2 2

Re: [PATCH 6/6] d3d8/tests: Test messages on focus loss (v2).
by Marvin Oct. 1, 2014

Oct. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9170 Your paranoid android. === w8 (32 bit device) === device.c:2325: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2330: Test failed: The focus window is active. device.c:2336: Test failed: Got unexpect width 640. device.c:2337: Test failed: Got unexpect height 480. device.c:2477: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3119: Test failed: Expected wndproc 0x413050, got 0x413050.

2 1

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.
by Marvin Oct. 1, 2014

Oct. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9167 Your paranoid android. === w7u (32 bit msg) === msg.c:12149: Test failed: unexpected hwnd 0017014A msg.c:12171: Test failed: bad time 3077e/3078e

2 1

Re: [2/4] server: Support sending process and thread security descriptors for the "new_process" request in the protocol.
by Alexandre Julliard Oct. 1, 2014

Oct. 1, 2014

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > + if (req->process_sd_size > get_req_data_size() || > + req->thread_sd_size > get_req_data_size() - req->process_sd_size || > + req->info_size > get_req_data_size() - req->process_sd_size - req->thread_sd_size) > + { > + close( socket_fd ); > + return; > + } You have to return an error. > + req_info = (const startup_info_t *) > + ((char*)get_req_data() + req->process_sd_size + req->thread_sd_size); > + req_env = (const WCHAR *) > + ((char*)get_req_data() + req->process_sd_size + req->thread_sd_size + req->info_size); > + req_env_size = get_req_data_size() - (req->process_sd_size + req->thread_sd_size + req->info_size); These may not be valid pointers (alignment is not checked) so it would be better to avoid declaring them as variables. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Gecko 2.34-beta1 release
by Jacek Caban Oct. 1, 2014

Oct. 1, 2014

Hi all, After about a year since the last release, I'm happy to announce that we have a new Wine Gecko packages ready for testing. I'm not attaching a patch this time, because it's quite big and will change over next few weeks (I will be submitting some of those changes, so the patch would be invalid soon). I set up a Wine fork at [1] instead. It contains snapshot of my development tree on top of Wine, so be prepared for forced updates. Let me know if you'd prefer it to be in a different form. This update catches up on development made for 10 Firefox releases that happened meantime. There were many problems that needed to be solved for this to happen. There were tree wide changes breaking our build config as well as API changes, that needed to be fixed. We still have long term problem with API that we use for embedding Gecko (mostly DOM APIs) that is slowly removed from Gecko. We need a long term solution, which means working on auto generated C/C++ bindings based on the new, WebIDL files. I may write a separated mail about that if there is an interest. I decided to make this beta from Gecko tip at the point where it's branched. I usually waited until Gecko enters beta, but I want to catch up on development as much as possible this time. How the final release will look like depends on how testing goes. It will not be sooner than after a bit of Firefox beta. As usually, everything that uses MSHTML is an interesting testing target. Let me know if there are any problems. Thanks, Jacek [1] http://repo.or.cz/w/wine/wine-gecko.git

2 3

Re: [PATCH 4/5] d3d9/tests: Add a test for vs_3_0 shaders using more than 256 constants.
by Stefan Dösinger Oct. 1, 2014

Oct. 1, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-09-30 14:51, schrieb Matteo Bruni: > --- > dlls/d3d9/tests/device.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) I think it would be a good idea to check the behavior of d3d9ex. It may lift some restrictions of plain d3d9. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUK+z6AAoJEN0/YqbEcdMwrrsP/1aU53A4nN8vmohZ4KtnKs42 DYvnr1cJxCjRCTM9c8xcH4t1FAMcbIy0HTygQNrvifvYBZbGqSmkA3vArIRxsIeK t5vSlAFvV14sWi4krsw+sRLzsYtpe1LWji9AW6DpzheJDNl2eaE2oxFRhloPv/KE 9d2O3x/9g0ww/231drtc6RxL5kd7cFs15XKw1LnawurxOB79McuEFkt75OEOFpB6 7wlzQdhe9PI0uiluxhXfKqLF3EehBR4j2KAYQO5O8KpFLMObSUJrdwhvc6Fmlwtb t6vH20mDewuCJF6fliCKyLpM4ujnxuwmBz5sl6D50javzknqX2kzG5PX6jnj8ezR iSBoGZJMY/B+UKKMHgJNzgbP6g3X7LICAs7lBlfuiTdVau+YvUf+8JiNoCkF7NFO aXPuVt/rJ+4k5Q5ZFCq9Vt7dmy9gtJGM8ZJw4z30Nz0v16LSRFQHMfBaqco3HCib todvTsy1/bLwrA6k+ANvWWwJmqKHaLIFm7ZcEZNi5cMxNtAKKHbyPzN19syhFuVU gxlqVtTuB/yT+3Kd7G+1pH2Wr7NZNG1szJfQLVS4ns4PXBtbarINDCYW2fUpfvS6 bpzMjYzWe0ePGN58XRCVqrptx7q6IW3GLueJYq5zSHsRRmawwQx1xJBTA0qAqq7I GworiiALSOo3MMD4YZb+ =42bF -----END PGP SIGNATURE-----

1 0

Re: [PATCH 5/5] jscript: Added support for '-' CC expression.
by Marvin Oct. 1, 2014

Oct. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9163 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] jscript: Added tests for @if/@elif/@else/@end.
by Marvin Oct. 1, 2014

Oct. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9160 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByName (try 2)
by Marvin Oct. 1, 2014

Oct. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9156 Your paranoid android. === w8 (32 bit address) === Failure running script in VM: timed out waiting for the child process

1 0

DirectPlay
by Michael Müller Oct. 1, 2014

Oct. 1, 2014

Hello Alistair, I am watching your DirectPlay patches for some time and I am very happy that you haven't yet given up implementing it. Most of the Wine developers do not really care much about DirectPlay since there is an easy workaround and no modern game makes use of it. Just today I wrote a fix for a multiplayer lobby client for Age of Empires 2 which also makes use of DP ( https://bugs.winehq.org/show_bug.cgi?id=29384 ). Although using the Windows 98 dlls works, I think it is important for ordinary wine users that it works out of the box. Sometimes Wine is not really that user friendly and I think it is important to enhance these parts to improve the image of wine. Not everybody is searching through the AppDB or bugtracker, instead most people give up if it does not work out of the box. For this reason I am contributing to a project called wine-compholio ( https://github.com/compholio/wine-compholio ) which collects correct patches that did not get upstream because AJ did not like them for some reason (although they were correct) or they didn't get any attention and dropped out of the queue. The idea is to use this project as staging tree and to improve these patches till wine accepts them. We also add our own patches there before we send them upstream so that other people can review and test them. This makes fixes/patches faster available to users as for example Fedora applies all our patches to their wine build. Moreover often developers review your patches before you send them to Wine devel. This makes it easier to get patches upstream since the chance that they contain a critical errors is much lower. If you think this might also help your patches, you can find us in #pipelight / #wine-compholio on FreeNode. However, I just wanted to say thank you that you are still working on DP. Regards, Michael Müller

1 0