October 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] d3d9/tests: The device restores the mode settings from the registry.
by Marvin Oct. 24, 2014

Oct. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9731 Your paranoid android. === w8 (32 bit device) === device.c:4008: Test failed: Expected {0, 0, 800, 600}, got {0, 0, 652, 492}.

1 0

Re: [PATCH 4/5] dwrite: Pass raw NAME table pointer to table reading code
by Marvin Oct. 24, 2014

Oct. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9730 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] dwrite: Cache fontface instances at factory level
by Marvin Oct. 24, 2014

Oct. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9729 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/2] ws2_32: Properly implement SO_CONNECT_TIME (try 3)
by Marvin Oct. 24, 2014

Oct. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9727 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:6676: Test failed: failed to create socket 10022 sock.c:6679: Test failed: failed to create completion port 87 sock.c:6684: Test failed: WSAIoctl failed 10038 sock.c:6687: Test failed: failed to get completion status 6

1 0

Re: [PATCH] wininet: remove custom port handling in HTTP_HandleRedirect (try 2)
by Alexandre Julliard Oct. 24, 2014

Oct. 24, 2014

Daniel Lehman <dlehman(a)esri.com> writes: > HTTP_HandleRedirect updates both: > - the Host: field > - and session->hostname > > If there is a custom port, it is appended to session->hostName. This causes problems for later HttpOpenRequest/process_host_port calls that append the port to the host name (resulting in "foobar:1234:1234") > > There is already logic in HTTP_HandleRequest that will update the > request->server if the new host or port don't match. in that case, > get_server/process_host_port use the updated host and port and store > them appended in server->host_port. If they already match, > server->host_port is left untouched > > The attached change removes the current custom port logic to instead > use server->host_port to update the Host: field It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M wininet.dll -p wininet_test.exe.so http && touch http.ok http.c:693: Test failed: Wrong URL http://test.winehq.org:80/tests/hello.html http.c:693: Test failed: Wrong URL http://test.winehq.org:80/tests/hello.html make[1]: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx10_43: Add stub for D3DXCpuOptimizations
by Henri Verbeet Oct. 24, 2014

Oct. 24, 2014

On 24 October 2014 00:28, André Hentschel <nerv(a)dawncrow.de> wrote: > +typedef enum _D3DX_CPU_OPTIMIZATION > +{ > + D3DX_NOT_OPTIMIZED = 0, > + D3DX_3DNOW_OPTIMIZED = 1, > + D3DX_SSE2_OPTIMIZED = 2, > + D3DX_SSE_OPTIMIZED = 3 > +} D3DX_CPU_OPTIMIZATION; I think this should be in d3dx10math.h. > + FIXME("%i - stub\n", enable); I'd like to see that as "FIXME("enable %#x stub!\n", enable);" for consistency with other D3D code, but I don't think it's a big deal.

1 0

[PATCH] mshtml: check null before release the elem object
by Hao Peng Oct. 24, 2014

Oct. 24, 2014

Check null pointer before release the script elem object, prevent to release them twice. --- dlls/mshtml/script.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

1 0

Fw:[PATCH] mlang: add gbk to Chinese Simplified codepage
by Hao Peng Oct. 24, 2014

Oct. 24, 2014

Add gbk to Chinese Simplified codepage data array in mlang, to make sure GBK encoded strings were decoded in codepage 936. --- dlls/mlang/mlang.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-)

1 0

Re: [PATCH] vbscript: Implemented String
by Nikolay Sivov Oct. 23, 2014

Oct. 23, 2014

> + str = SysAllocStringLen(NULL, 1023); > + newstr = SysAllocStringLen(NULL, 1023); Where this length comes from? > + switch(V_VT(arg + 1)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_BSTR: > + str = V_BSTR(arg + 1); > + break; > + case VT_ARRAY|VT_BYREF|VT_VARIANT: > + return DISP_E_TYPEMISMATCH; > + default: > + hres = to_short(arg + 1, &tmp); > + if(FAILED(hres)) > + return hres; > + str[0] = (char)tmp; > + break; > + } You only need first character, right? Then why do you need a full BSTR pointer in VT_BSTR case? And assigning it to 'str' you leak a previously allocated buffer. Why cast to (char)tmp? > + else if(len == 0) > + newstr = '\0'; Same way you're losing pointer to allocated buffer.

2 4

Re: [PATCH 2/2] dwrite/tests: Some tests for local font file loader
by Marvin Oct. 23, 2014

Oct. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9714 Your paranoid android. === wvistau64 (32 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057 === w2008s64 (32 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057 === wvistau64 (64 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057 === w2008s64 (64 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057

1 0

Re: [PATCH v3 1/6] reg.exe/tests: Parameterise error messages
by Alexandre Julliard Oct. 23, 2014

Oct. 23, 2014

Jonathan Vollebregt <jnvsor(a)gmail.com> writes: > Also use %u for DWORD instead of %d It's not worth changing that sort of thing, the expected value is in general not useful. In the tests that you are modifying you can get rid of it, otherwise leave them alone. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 1/3] d3d8/tests: Skip unsupported resources in test_resource_type.
by Marvin Oct. 22, 2014

Oct. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9711 Your paranoid android. === w8 (32 bit device) === device.c:2437: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3141: Test failed: Expected wndproc 0x412ba0, got 0x412ba0.

1 0

Re: dpnet: Check if DirectDplay is installed (try 4 - resend)
by Stefan Dösinger Oct. 22, 2014

Oct. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I don't remember and cannot find out from the archives what happened to try 1-3. > +#include "dpnet_private.h" I think we want our test files to be stand-alone if possible. Having a copy of the code in each file or merging the test files are alternatives to giving up this independence. Though at least dlls/ntdll/tests/ntdll_test.h is an example of an existing test header. Another option is to generalize this function beyond dpnet.dll and put it in include/wine/test.h or make programs/winetest responsible for checking for stubs. I think programs/winetest is the best place, as it also handles missing DLLs. If you keep the header please rename it, along with the protection define. > +extern BOOL IsStubDLL(const char *filename) DECLSPEC_HIDDEN; You have CamelCase in there. You could also consider making this a static inline function in the header, that way you avoid dependencies between the .c files. > +/* + * Windows 8 has a concept of stub DLL's. When DLLMain is > called the user is prompted I think DLLs is the correct plural, DLL's would be the possessive. > + LPSTR data = HeapAlloc(GetProcessHeap(), 0, size); LPFOO. There are other cases on this code. > + if (VerQueryValueA(data, > "\\StringFileInfo\\040904b0\\OriginalFilename", (LPVOID*)&p, > &size)) What's 040904b0? I could not find an explanation on google, so maybe there's no way to avoid it. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUSAkhAAoJEN0/YqbEcdMw3y8QAJMwgh4rHP2iHgQV1mPkjSFR bHMv/CZynb/cd6e8of2oQybSC+iAt4e6MUPqMQCkg0CcsqcDTHf27Ci6r5q+P7Lg fTxAp2U/Vz5r77cKRejarjNueN62SBet7wDR9Bx8pIZ7+yAQDQ6H2qf5iqHOr5KU 0kjftpeKA9YUy1nuQJEf3wUUqnXEy8tZBL9UqryV6ya+HLzYdwq1SNJunH/rOaFh QQBM9CQ4HPMvj7BnGmKdQhFdssptaNYLPrK0QUCb/EyroqB0YGQ2QZsINQREKGYl y8iwjFaMkpIALtXX88UapHfPBn6jc4Y7abaEWm0ReRly1FCkMOgoPIqwLyWIunga sJalQeULE8ztPh/dseofH7mtOJyWY82JCs2l8F3iTRANwjbJCiZVE/dFJHurs8EZ 0wQ4zNH3wp1HwjYXDxOuVS2phJ9Y1SC30Cjb2jDLotg1NX/5QWLbQvn6R+S1+YV/ AkFbizAFUf6GNhnLTKMB+WC+lChc2ZF57P+H0iFixbpnW8OTNYDKiefKKQuScicE i6TgiKBTw7pWrn6h+s1GV+nILBsqzO8HqGaTLvvQUGkPKdaxjN/5HJLYQ60Xhg7P RvLSiYm0xOQNgZyoVCrGlLyiKZg7r192q+Yv9OG4AQ/GQkdeP9PahKmhu9a0WhDt xD1zmLqLy45erH4m4oa4 =Wf/H -----END PGP SIGNATURE-----

1 0

Re: [PATCH v3 1/6] reg.exe/tests: Parameterise error messages
by Stefan Dösinger Oct. 22, 2014

Oct. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 These patches look reasonable to me. There are some things that are matters of opinion as far as I can see, like printing static expected values in this patch, or reusing the same buffer in patch 4-6. I left those up to Jonathan to decide. If we have written rules about those please point them out. Am 2014-10-22 18:13, schrieb Jonathan Vollebregt: > Also use %u for DWORD instead of %d > --- > programs/reg/tests/reg.c | 60 ++++++++++++++++++++++++------------------------ > 1 file changed, 30 insertions(+), 30 deletions(-) > > diff --git a/programs/reg/tests/reg.c b/programs/reg/tests/reg.c > index 5b79aed..772d81d 100644 > --- a/programs/reg/tests/reg.c > +++ b/programs/reg/tests/reg.c > @@ -73,13 +73,13 @@ static void verify_reg_(unsigned line, HKEY hkey, const char* value, > return; > > if (todo & TODO_REG_TYPE) > - todo_wine lok(type == exp_type, "got wrong type %d, expected %d\n", type, exp_type); > + todo_wine lok(type == exp_type, "got wrong type %u, expected %u\n", type, exp_type); > else > - lok(type == exp_type, "got wrong type %d, expected %d\n", type, exp_type); > + lok(type == exp_type, "got wrong type %u, expected %u\n", type, exp_type); > if (todo & TODO_REG_SIZE) > - todo_wine lok(size == exp_size, "got wrong size %d, expected %d\n", size, exp_size); > + todo_wine lok(size == exp_size, "got wrong size %u, expected %u\n", size, exp_size); > else > - lok(size == exp_size, "got wrong size %d, expected %d\n", size, exp_size); > + lok(size == exp_size, "got wrong size %u, expected %u\n", size, exp_size); > if (todo & TODO_REG_DATA) > todo_wine lok(memcmp(data, exp_data, size) == 0, "got wrong data\n"); > else > @@ -93,7 +93,7 @@ static void test_add(void) > DWORD r, dword, type, size; > > run_reg_exe("reg add", &r); > - ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + ok(r == REG_EXIT_FAILURE, "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > > err = RegDeleteKeyA(HKEY_CURRENT_USER, KEY_BASE); > ok(err == ERROR_SUCCESS || err == ERROR_FILE_NOT_FOUND, "got %d\n", err); > @@ -102,7 +102,7 @@ static void test_add(void) > ok(err == ERROR_FILE_NOT_FOUND, "got %d\n", err); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > > err = RegOpenKeyExA(HKEY_CURRENT_USER, KEY_BASE, 0, KEY_READ, &hkey); > ok(err == ERROR_SUCCESS, "key creation failed, got %d\n", err); > @@ -110,36 +110,36 @@ static void test_add(void) > /* REG_SZ */ > run_reg_exe("reg add HKCU\\" KEY_BASE " /d WineTest /f", &r); > ok(r == REG_EXIT_SUCCESS || broken(r == REG_EXIT_FAILURE /* WinXP */), > - "got exit code %d, expected 0\n", r); > + "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > if (r == REG_EXIT_SUCCESS) > verify_reg(hkey, "", REG_SZ, "WineTest", 9, 0); > else > win_skip("broken reg.exe detected\n"); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v test /d deadbeef /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > verify_reg(hkey, "test", REG_SZ, "deadbeef", 9, 0); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v test /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > verify_reg(hkey, "test", REG_SZ, "", 1, TODO_REG_SIZE); > > run_reg_exe("reg add HKEY_CURRENT_USER\\" KEY_BASE " /ve /d WineTEST /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > verify_reg(hkey, "", REG_SZ, "WineTEST", 9, 0); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_SZ /v test2 /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > verify_reg(hkey, "test2", REG_SZ, "", 1, TODO_REG_SIZE); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_SZ /v test3 /f /d \"\"", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > verify_reg(hkey, "test3", REG_SZ, "", 1, 0); > > /* REG_DWORD */ > run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_DWORD /f /d 12345678", &r); > ok(r == REG_EXIT_SUCCESS || broken(r == REG_EXIT_FAILURE /* WinXP */), > - "got exit code %d, expected 0\n", r); > + "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > dword = 12345678; > if (r == REG_EXIT_SUCCESS) > verify_reg(hkey, "", REG_DWORD, &dword, sizeof(dword), 0); > @@ -148,41 +148,41 @@ static void test_add(void) > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword1 /t REG_DWORD /f", &r); > todo_wine ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */), > - "got exit code %d, expected 0\n", r); > + "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword2 /t REG_DWORD /d zzz /f", &r); > - todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword3 /t REG_DWORD /d deadbeef /f", &r); > - todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword4 /t REG_DWORD /d 123xyz /f", &r); > - todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword5 /t reg_dword /d 12345678 /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > dword = 12345678; > verify_reg(hkey, "dword5", REG_DWORD, &dword, sizeof(dword), 0); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword6 /t REG_DWORD /D 0123 /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > size = sizeof(dword); > err = RegQueryValueExA(hkey, "dword6", NULL, &type, (LPBYTE)&dword, &size); > ok(err == ERROR_SUCCESS, "RegQueryValueEx failed: got %d\n", err); > - ok(type == REG_DWORD, "got wrong type %d, expected %d\n", type, REG_DWORD); > - ok(size == sizeof(DWORD), "got wrong size %d, expected %d\n", size, (int)sizeof(DWORD)); > + ok(type == REG_DWORD, "got wrong type %u, expected %u\n", type, REG_DWORD); > + ok(size == sizeof(DWORD), "got wrong size %u, expected %u\n", size, (unsigned int) sizeof(DWORD)); > todo_wine ok(dword == 123 || broken(dword == 0123 /* WinXP */), > - "got wrong data %d, expected %d\n", dword, 123); > + "got wrong data %u, expected %u\n", dword, 123); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword7 /t reg_dword /d 0xabcdefg /f", &r); > - todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword8 /t REG_dword /d 0xdeadbeef /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > dword = 0xdeadbeef; > verify_reg(hkey, "dword8", REG_DWORD, &dword, sizeof(dword), > (sizeof(long) > sizeof(DWORD)) ? 0 : TODO_REG_DATA); > > /* REG_DWORD_LITTLE_ENDIAN */ > run_reg_exe("reg add HKCU\\" KEY_BASE " /v DWORD_LE /t REG_DWORD_LITTLE_ENDIAN /d 456 /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > dword = 456; > verify_reg(hkey, "DWORD_LE", REG_DWORD_LITTLE_ENDIAN, &dword, sizeof(dword), 0); > > @@ -200,7 +200,7 @@ static void test_delete(void) > const DWORD deadbeef = 0xdeadbeef; > > run_reg_exe("reg delete", &r); > - ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + ok(r == REG_EXIT_FAILURE, "got exit code %u, expected %u\n", r, REG_EXIT_FAILURE); > > err = RegCreateKeyExA(HKEY_CURRENT_USER, KEY_BASE, 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hkey, NULL); > ok(err == ERROR_SUCCESS, "got %d\n", err); > @@ -219,17 +219,17 @@ static void test_delete(void) > RegCloseKey(hsubkey); > > run_reg_exe("reg delete HKCU\\" KEY_BASE " /v bar /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > err = RegQueryValueExA(hkey, "bar", NULL, NULL, NULL, NULL); > ok(err == ERROR_FILE_NOT_FOUND, "got %d\n", err); > > run_reg_exe("reg delete HKCU\\" KEY_BASE " /ve /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > err = RegQueryValueExA(hkey, "", NULL, NULL, NULL, NULL); > todo_wine ok(err == ERROR_FILE_NOT_FOUND, "got %d\n", err); > > run_reg_exe("reg delete HKCU\\" KEY_BASE " /va /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > err = RegQueryValueExA(hkey, "foo", NULL, NULL, NULL, NULL); > ok(err == ERROR_FILE_NOT_FOUND, "got %d\n", err); > err = RegOpenKeyExA(hkey, "subkey", 0, KEY_READ, &hsubkey); > @@ -238,7 +238,7 @@ static void test_delete(void) > RegCloseKey(hkey); > > run_reg_exe("reg delete HKCU\\" KEY_BASE " /f", &r); > - ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); > err = RegOpenKeyExA(HKEY_CURRENT_USER, KEY_BASE, 0, KEY_READ, &hkey); > ok(err == ERROR_FILE_NOT_FOUND, "got %d\n", err); > } > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUSAPxAAoJEN0/YqbEcdMw46UP/2gJ9G9eYnhotsSlgl5S+fKw +BheiroQvKsqoCVHxw4LdunAtJDYA7i9lohaXrl+3EmMlgA/YMzwhRiZawC2Nukh 6OkZrjCYNx9V5PWNPrzAmj6wWE0UJ9QJDlm6krN9sI8KtFRG3Xaeo6qcWF/Hb3Rj S9htN0+hi5mex8v0mAEICkoISDgmfUVvHc1CF/W9wx1aNYMN1vmgdRNd4R6HrnTg rOH4AFugV5rdHHvZxfcnHg1S7k0T+uiXp7qN5o3rch2zE5yM/YXGzapMRT9OijpC rm+AntnROz4NgW3lZdR4rCOGm1dFmaP87NAAnm3o+LWioWzgV4YsalfowDxSi7L5 TTwE/+NfYhrkgFfTRywFeAdO3Yj6hQ1gLe8rwUrA2fprNxRbloLXRfsBuuzi2HHR DAndXbzLvLydu87I5DvmZKWcwvch68RqsBLDUMcyApquXNULINOLi3Wdrn7Ce4vq CLQEyUFS9Yl+IyoSOC0Xh1VXZ6tmRsJQAsOsm2DGLZpwRCSNjgmR1SBb4mM4TH0m n6010JV5apbQX0csTF3xQX7OXzYR6DT4IfkI4CndtMkUOSJfGigE6OydtaeH/+mF MGTWvJlmbG98U59fZYoCR/FmxsHHrc4clpZNkaNFH0RK/bbcUrzHRdV0A/IKAOWM MFGf31X9gvGNdeuBjqNP =vmiv -----END PGP SIGNATURE-----

1 0

Re: [PATCH 4/4] d3d8/tests: Use create_device in test_swvp_buffer.
by Marvin Oct. 22, 2014

Oct. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9690 Your paranoid android. === w8 (32 bit device) === device.c:2437: Test failed: Expected foreground window 000301B8, got 0002004C. device.c:3141: Test failed: Expected wndproc 0x412ae0, got 0x412ae0.

1 0

Re: [PATCH 3/4] d3d8/tests: Use create_device for test_fpu_setup.
by Marvin Oct. 21, 2014

Oct. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9689 Your paranoid android. === w8 (32 bit device) === device.c:2432: Test failed: Expected foreground window 00080166, got 0002004C. device.c:3136: Test failed: Expected wndproc 0x412b10, got 0x412b10.

1 0

Re: [PATCH 1/6] reg.exe/tests: Parameterise error messages
by Stefan Dösinger Oct. 21, 2014

Oct. 21, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-20 22:24, schrieb Jonathan Vollebregt: > - ok(type == REG_DWORD, "got wrong type %d, expected %d\n", type, REG_DWORD); > - ok(size == sizeof(DWORD), "got wrong size %d, expected %d\n", size, (int)sizeof(DWORD)); > + ok(type == REG_DWORD, "got wrong type %u, expected %u\n", type, REG_DWORD); > + ok(size == sizeof(DWORD), "got wrong size %u, expected %u\n", size, (DWORD)sizeof(DWORD)); I don't know if this is the canonical way to handle this. My gut feeling is that a cast to unsigned int would be nicer than a cast of DWORD, but I hope others can give a better answer. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJURiJmAAoJEN0/YqbEcdMw3HEP/1MBp8qA+CyiaauJYQiiQ7+s Ixo1oO/cBewMzYwbqf+4luIxtWPl2v3ocRecHVrns7SRoOrLnsdfp/Tjf5pzx3GL 0mjDrXjKJCPEsY6tTTx3uHKnGhMt7coYymef4LPpZHVwYdy8DuwhCaCiZWwxY54M /apfZ3sFieiMqO4aXPAMR02mKcyPDIarLn0t2A1pJWV10iSJ1BunyM+tBNV0523B V98UknVYqlBUoqwqywbMKMCCnCCvN/Z7gtUiydodQdHlkPTgWFSwNvLTrEgSclXo 1L04NH9JzvTYlIN2oHSELNpdiZycEaBS7xTaYk0DjdnvXYG3jS/zsgYBURjnuWJr oFz86pFOnEeirvkixEfAtPy5RwKfJKvgXVKH3eP75g9pLpGJ7L5+2hS/VMYbV40O ENK4D/U41L4ldJVDo/3GQUyiU8Me0OukgIFbHS+axygKgp5YWcH7HDhAgwG3xTu9 LLeAgLnWxeQ0RHVSohPLrVVNSOlwFyLQQsc6Jh+ZbcnxetF0mFJtvVPfRfkWjzkV nC6AamdvpnZlxfrqP66VB3ZKaSScMiqvlUvP/JRRd9bto6Hp5wbnD/1g9sAV8Iyl 6cSOH44kDB5qdFg8IWr+Dsh8PpQVUai1HzBioKrDA3av6XVgV/rwCSaoRhwkdjTS MmjNbHDCXnNMlx7S7dQe =3Os0 -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/6] d3d9/tests: Use create_device in test_fpu_setup.
by Henri Verbeet Oct. 21, 2014

Oct. 21, 2014

On 20 October 2014 13:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -3598,20 +3604,18 @@ static void test_fpu_setup(void) > d3d9 = Direct3DCreate9(D3D_SDK_VERSION); > ok(!!d3d9, "Failed to create a D3D object.\n"); > > - memset(&present_parameters, 0, sizeof(present_parameters)); > - present_parameters.Windowed = TRUE; > - present_parameters.hDeviceWindow = window; > - present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; > + device_desc.device_window = window; > + device_desc.width = 640; > + device_desc.height = 480; > + device_desc.flags = CREATE_DEVICE_HWVP_ONLY; > This essentially matches the existing code, but does the test really not work with software vertexprocessing? It seems to work for me.

2 2

Re: [PATCH 5/6] reg.exe/tests: Add REG_BINARY tests for reg add
by Stefan Dösinger Oct. 21, 2014

Oct. 21, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-20 22:24, schrieb Jonathan Vollebregt: > + // Remaining nibble prefixed C++ comments are not allowed in Wine. Otherwise this series looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJURiGjAAoJEN0/YqbEcdMwoCAP/RZB/7kV5iPt9E2yQ9f5Dr0G wlo+XleoqM8oQ87lPKT7RturEb0LAhZRWFp9IAh32CoxKyTqoMSlvCMJ1I266dXz 7CDxe7+HW8HvDziUBAM5FMKno/PXQoBoLCjx0EUXAmbTCQP9hIxWwr6knPgXsJo4 OF1PIUH3xJQ+O4/hea4EGNl2zmglkBQhYpq6Ab+jSNEd42MYHTq0x+W987ltW9eA KnrTZbXg+wAW0GIxJaZkeiwV6fKDNxbb4DbRnti1O31C7k+kzQ8nUciDVo/BpaXd FBa89MBWvuMLva7W3OcncOmTR6thOQiutS3363dNfsOrTvL1EwU9FBSNui1yl18Q y0WPmpoH4IDEhcfdcQ8gbCENQrM9ybltpRFTonSom0L0PYff1Irc2mvw7O0SGzxj a6V4oipqTkdHCwiMGEW5h05K2KMAuwq8dYTXoGgtODjLO1bm79SHKSHS7jQ6Vldd WR6rhkJKStOc/EpuPF9ls6gLcDZJsHxqoz66Qj77XQnwPrmduWtMMhty9Eg/eMMH WHZr8PrgS77nFdA4xmBqYpk8opOfTTNfBO0vjBG+l2ymBdTSYoCvzPmMtCMlcC55 aePuvqflwuvqZ7RogSa9GMkVJEEP1xHOJUWPWos95YsslCQyQox7qvOQcccPx+Nz xUeuNIXIay7SBn9EINVC =8eal -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/2] kernel32: Handle win32 hresult in FormatMessage.
by Sebastian Lackner Oct. 20, 2014

Oct. 20, 2014

On 20.10.2014 19:05, Catalin Patulea wrote: > +static LPWSTR search_message( DWORD flags, HMODULE module, UINT id, WORD lang ) > +{ > + LPWSTR from = NULL; > + if (flags & FORMAT_MESSAGE_FROM_HMODULE) > + from = load_message( module, id, lang ); > + if (!from && (flags & FORMAT_MESSAGE_FROM_SYSTEM)) { <---- [1] > + // Fold win32 hresult to its embedded error code. <---- [2] > + if (HRESULT_SEVERITY(id) == SEVERITY_ERROR && > + HRESULT_FACILITY(id) == FACILITY_WIN32) { <---- [1] > + id = HRESULT_CODE(id); > + } > + from = load_message( kernel32_handle, id, lang ); > + } > + return from; > +} > + Some small style improvement suggestions: 1) better use this style for if conditions: --- snip --- if (...) { } --- snip --- 2) Wine prefers comments using the following style --- snip --- /* ... */ --- snip --- Regards, Sebastian

1 0

Re: [PATCH 1/2] kernel32/tests: Add test for FormatMessage with HRESULT
by Sebastian Lackner Oct. 20, 2014

Oct. 20, 2014

On 20.10.2014 19:05, Catalin Patulea wrote: > > + /* Test HRESULT. It's not documented but in practice _com_error::ErrorMessage relies on this. */ > + ret = FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_FROM_HMODULE, h, 0x80070005 /* E_ACCESSDENIED */, > + MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL), out, sizeof(out)/sizeof(CHAR), NULL); > + ok(ret != 0, "FormatMessageA returned 0\n"); > + As this test is failing on Wine you should mark it with "todo_wine", to avoid introducing test failures. Patch 2 which fixes the issue should remove the "todo_wine" again.

1 0

Re: secur32/test: Switch requested protocol from SSL3 to TLS1.
by Marvin Oct. 20, 2014

Oct. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9643 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] vbscript: Implemented String
by Piotr Caban Oct. 20, 2014

Oct. 20, 2014

On 10/19/14 17:44, Shuai Meng wrote: > + newstr = SysAllocStringLen(NULL, 1023); You need to allocate correct length string. First argument should be used here. You're also leaking the string in error-handling paths. > + > + switch(V_VT(arg + 1)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_BSTR: > + str = V_BSTR(arg + 1); > + break; > + case VT_ARRAY|VT_BYREF|VT_VARIANT: > + return DISP_E_TYPEMISMATCH; > + default: > + hres = to_short(arg + 1, &tmp); > + if(FAILED(hres)) > + return hres; > + str[0] = (char)tmp; Please add a test with second argument larger then 256. It would be also interesting to see a test with second argument being BSTR with first character out of ASCII range. Please also check what happens if V_BSTR(arg+1)==NULL. > + hres = to_short(arg, &len); > + if(FAILED(hres)) > + return hres; > + if(len < 0) > + return MAKE_VBSERROR(VBSE_ILLEGAL_FUNC_CALL); > + else if(len == 0) > + newstr = '\0'; > + else if(len > 1023) > + len = 1023; I guess that first argument is probably an integer. The length of produced string is probably also not limited to 1023 characters. Thanks, Piotr

2 1

Re: [v5 03/12] reg.exe: Add REG_MULTI_SZ tests for reg add
by Stefan Dösinger Oct. 20, 2014

Oct. 20, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-17 20:38, schrieb Jonathan Vollebregt: > + /* REG_MULTI_SZ */ > + run_reg_exe("reg add HKCU\\" KEY_BASE " /v multi0 /t REG_MULTI_SZ /d \"three\\0little\\0strings\" /f", &r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + memcpy(buffer, "three", 6); > + memcpy(buffer+6, "little", 7); > + memcpy(buffer+6+7, "strings", 8); > + buffer[21] = 0; > + verify_reg(hkey, "multi0", REG_MULTI_SZ, buffer, 22, TODO_REG_SIZE); I think this shoudl work as well: const char buffer[] = "three\0little\0strings\0"; verify_reg(hkey, "multi0", REG_MULTI_SZ, buffer, sizeof(buffer), TODO_REG_SIZE); Notice the [] to declare an array so sizeof returns the proper value. strlen will not work. > + run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_MULTI_SZ /v multi4 /s \"#randomgibberish\" /d \"three#little#strings\" /f", &r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_MULTI_SZ /v multi4 /s \"\" /d \"three#little#strings\" /f", &r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_MULTI_SZ /v multi4 /s \"#\" /d \"##\" /f", &r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_MULTI_SZ /v multi4 /s \"#\" /d \"two##strings\" /f", &r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); > + run_reg_exe("reg add HKCU\\" KEY_BASE " /t REG_MULTI_SZ /v multi4 /s \"#\" /d \"#a\" /f", &r); > + todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); What about the following cases? /s ABC /d threeABClittleABCstrings /s \\0 /d three\\0little\\0strings -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJURR9NAAoJEN0/YqbEcdMw/6UP/Rs7diy+TUkZDbJq2x3JyZYZ c+YK2Z9PoWNs3oTvwvVtaxrVqSX1y0fVnGEpNixGEMbo5fae7/rm9fN5WqvI+1FW RWG0ViCpJ4EduNVhORtHmMGzhqQAAGlfuEF0fthSshynaD8MirwPMW5LzBVTK/A8 zhI0wvveQElhscEoYtaZOkuI5WZzzKnjGpuGtserx31B41ClASEpR/MiU4XJD78p OvqaPotzlbQermrte9B+ZWcxjjVyrsM2fToVbXMNhtBDyDy17uG1Lpr8lQrXL85J uFYpVFiYoRf7CCHrhY2Gx8H7AsHwc8W0LDlnvlIKk6yRWnzyQuSzQJVbFNzBAy9u wBlQ6kZjMJzvaGCk9el5MXiwgN6Vs2bHa3j/8qvrzQyaGNebiZA7QLaXUXOqXpb6 De6/ev8iyTD1cyFwVootQBAsb40HKBk24ZwmP0sp+j3seJUlzR37ve/R71avexWL uheZ9Xj5xeBm0G3JJQ3C0cxUYo+f22t9gDLbKtOa+5BcRskjtmgHjEHEzZs33T8F BcXhGtAyL99XwXh73ILHg321pjkTu1sWzd9ILigVz6mYmOJzZp/L4Azy6E3W/U7j GHkT46Ag7/aUN4BTR5MieySdFtAQ9pbdYI1FRMBINie2Ny9AC71UrDYtFpNQuzaN C4BbMES4ZXNJQuGSHs33 =iJxu -----END PGP SIGNATURE-----

2 2

Re: [v5 01/12] reg.exe: Fix wrong error message in reg add DWORD test
by Stefan Dösinger Oct. 20, 2014

Oct. 20, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-17 20:38, schrieb Jonathan Vollebregt: > run_reg_exe("reg add HKCU\\" KEY_BASE " /v dword1 /t REG_DWORD /f", &r); > todo_wine ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */), > - "got exit code %d, expected 0\n", r); > + "got exit code %d, expected 1\n", r); r is a DWORD, which is an unsigned value, so %u is the correct format to print it. There's not much point in printing the expected value. One can look it up by looking at the source file. Having the expected value twice only asks for inconsistencies like the one you're fixing here. If you want to print the expected value I'd prefer something like this: todo_wine ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */), "got exit code %u, expected %u\n", r, REG_EXIT_SUCCESS); or maybe todo_wine ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */), "got exit code %d, expected REG_EXIT_SUCCESS(%d)\n", r, REG_EXIT_SUCCESS); That way you don't hardcode the numerical value of REG_EXIT_SUCCESS. I recommend sending smaller patchsets, e.g. in your case send the tests, and once they are in, send the implementation changes. The tests make sense on their own, and that way you don't flood wine-patches too much. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJURSKoAAoJEN0/YqbEcdMwgVsP/0rEoBVYlB3zoP979b5q4Wbw U0Y+ilARyJ4vAoeVKlJtQ8xLxg2Mej6vYvCx5fve6cq6pokUbfrHBpEgBNsjx7gq AI88t8CSDYnpFBGpDYRVDdwq5enLP0cJKOZHb7pVIR5+1JIbDW/RxA3eLGmbvLsE EU8nGiSEzYuRwKMy4XfuMFCG1oPRIzg2WO+8ckneJ+P2ZYDmNVWv1sxcuitAm7Lr g6pq5CwN1Y1agzPHd45W10/hPTnD9ViqaSQgHIpXs47urElL6z1nRb3bgwKAVeBf 9KA9qm12F+zqNoEc9cTHPdnjjOHM7LgQFTmWJDNdZSiXDKMvqZAldRkuI2cAp4jX tRFYSeUlNk3KDLnJ5msINwRklatovSBbUizHY/D+YhCJVU1aRIKsebJ0zOFrVoUp 2UBbtfBembEOr917aXngNlpZzKPbwPGpm+wyBum7q8OU19CN5X8/WqXZVhms3QAU bchyP9EnX6SjnHiZn4XE0gC8ABj5LeS24/Zgtfm/T19FT7NL00U49pis+F8RMim8 kthoNp2YO+rpzcvQjaWvBMQlCtecpZx2f9b9x/lfAxd+fMVDGjsVxFcp5V7OipJG 1pdISvYtwOqrlgqiy1Bm4q9vX47y+qDmM1NnAvfBcDkkE/hk+QaCQo+MjAW1W/Bm 7DS30tdCw2E6+XWdk/Du =Xz8b -----END PGP SIGNATURE-----

1 0

Re: [v5 02/12] reg.exe: Add REG_EXPAND_SZ tests for reg add
by Stefan Dösinger Oct. 20, 2014

Oct. 20, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-17 20:38, schrieb Jonathan Vollebregt: > + /* REG_EXPAND_SZ */ > + run_reg_exe("reg add HKCU\\" KEY_BASE " /v expand0 /t REG_EXpand_sz /d \"dead%PATH%beef\" /f", &r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + verify_reg(hkey, "expand0", REG_EXPAND_SZ, "dead%PATH%beef", 15, TODO_REG_SIZE); Is there really no observable difference between REG_SZ and REG_EXPAND_SZ? The MSDN description suggests that the behavior you observe here is correct, but I wonder what REG_EXPAND_SZ is good for in this case, other than just an elaborate way to set a flag that says "please call ExpandEnvironmentStrings". -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJURRrSAAoJEN0/YqbEcdMwsFMP/0KQ0ZQxOe5pwDcAX2h2B1tI peMiCJsmb8AwNru1qNjfwEZ/cU5Y7JvDmue3AQqkHKenkyyu5dYw1ItWmsTYW1z/ mRqK7R7/v6frRzPr1iMT4+8MKYVuiPxkgCPHQsMWQGfYBhLk3xVLq/ev64+paLw3 09GjgVWY5JS+vChI+4WX8T0+WS0mmmnbp/+QZb/z3jfNZvYEDXaNFmkITwROfaif ftuYS5VJL70UUxHvHcx6ctcexwnga0ka+voCVFRK/yALLesTB01+eYkn9bgVYVPl O4UC3INvMJsfdDd3KhFJSh/RZBHKn/4TyKQDu0DZDeMJMx/l8Q22TxsutsR5de+L BLQhrxzHVirrBkBrOwc5GCrpdBU0NpQX8mBW/E9kISzFlCHbtWa97F2gqCw6rnaA BU3430R+6aolQ3E47y4CdMZA5I7sIbTa5EdXJdkshExuMDS1V8xph2N/JCttzNPh QczIL7NAHekm+5W/DvuC4wx9jajmiQ/ol4Jr140h48SaEKL97/tWkoXTF/UmtqPi k7kaY3zqTNUyrLAQxarERVy3tZkicRMimvTCLbAFTZ4g86JgU9vjNYRbdbGS/fwr e0bsk8k3C1vtARYi+pYIbHQaQrzAE+/dR3caMVsXf08PTfituRQjlCqgb637Uf43 5iX8bhy6U/mdi9xIUn5W =7z6c -----END PGP SIGNATURE-----

1 0

Re: [PATCH 6/6] d3d8/tests: Use create_device in test_swvp_buffer.
by Marvin Oct. 20, 2014

Oct. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9637 Your paranoid android. === w8 (32 bit device) === device.c:2438: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3142: Test failed: Expected wndproc 0x412ae0, got 0x412ae0.

1 0

Re: [PATCH 5/6] d3d8/tests: Use create_device for test_fpu_setup.
by Marvin Oct. 20, 2014

Oct. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9636 Your paranoid android. === w8 (32 bit device) === device.c:2435: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3139: Test failed: Expected wndproc 0x412b30, got 0x412b30.

1 0

Re: [PATCH 4/6] d3d8/tests: Update create_device to match d3d9.
by Marvin Oct. 20, 2014

Oct. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9635 Your paranoid android. === w8 (32 bit device) === device.c:2423: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3130: Test failed: Expected wndproc 0x412e30, got 0x412e30.

1 0

Re: comctl32: Use strcmpW instead of pointer comparison to ensure treeview updates correctly
by Nikolay Sivov Oct. 19, 2014

Oct. 19, 2014

On 10/19/2014 20:01, Dan Bassi wrote: > Hi Nikolay. In uTorrent, the Treeview box on the left doesn't update > under Wine unless the box is clicked (whereas under Windows, it > updates automatically without clicking). > > I later traced the error to the "item_changed()" function in > comctl32/treeview.c, which was (incorrectly) detecting the text as > never having changed. This patch seems to fix that behaviour. > > Please let me know your thoughts. Many thanks. What I mean is that we need more tests in comctl32/tests/treeview.c to prove that patch is correct. The fact that it fixes some case with some application is not enough. > > On Sun, Oct 19, 2014 at 4:49 PM, Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>> wrote: > > On 10/19/2014 18:44, Dan Bassi wrote: > > + /* Old text is a null pointer due to HeapAlloc() failing, > therefore unable to perform strcmpW so assume text has changed */ > + if (!tiOld->pszText) > + return TRUE; > + > > I don't think you should necessary assume it's changed. > > /* Text has changed and it's not a callback */ > - if ((tvChange->mask & TVIF_TEXT) && (tiOld->pszText != > tiNew->pszText) && > + if ((tvChange->mask & TVIF_TEXT) && > (strcmpW(tiOld->pszText, tiNew->pszText) != 0) && > tiNew->pszText != LPSTR_TEXTCALLBACKW) > return TRUE; > > This is wrong, you can't compare if it's a special callback value. > > + originalItem.pszText = HeapAlloc(GetProcessHeap(), 0, > originalItem.cchTextMax * sizeof(WCHAR)); > > Normally comctl32 code uses Alloc()/Free() functions. > > This patch needs tests first, those tests should cover all > possible combinations regarding callback cases, different pointers > but same data, > same data but different pointers, maybe something else. > > >

1 0

Re: [PATCH] vbscript: Implemented String
by Marvin Oct. 19, 2014

Oct. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9624 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: comctl32: Use strcmpW instead of pointer comparison to ensure treeview updates correctly
by Nikolay Sivov Oct. 19, 2014

Oct. 19, 2014

On 10/19/2014 18:44, Dan Bassi wrote: > + /* Old text is a null pointer due to HeapAlloc() failing, therefore unable to perform strcmpW so assume text has changed */ > + if (!tiOld->pszText) > + return TRUE; > + I don't think you should necessary assume it's changed. > /* Text has changed and it's not a callback */ > - if ((tvChange->mask & TVIF_TEXT) && (tiOld->pszText != tiNew->pszText) && > + if ((tvChange->mask & TVIF_TEXT) && (strcmpW(tiOld->pszText, tiNew->pszText) != 0) && > tiNew->pszText != LPSTR_TEXTCALLBACKW) > return TRUE; This is wrong, you can't compare if it's a special callback value. > + originalItem.pszText = HeapAlloc(GetProcessHeap(), 0, originalItem.cchTextMax * sizeof(WCHAR)); Normally comctl32 code uses Alloc()/Free() functions. This patch needs tests first, those tests should cover all possible combinations regarding callback cases, different pointers but same data, same data but different pointers, maybe something else.

1 0

Re: wined3d: Correctly display fog for right-handed projection matrix (try 7)
by Stefan Dösinger Oct. 18, 2014

Oct. 18, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, This one looks good to me. Am 2014-10-12 17:08, schrieb Joachim Priesner: > + enum > + { > + COLOR_ALPHA_0x00 = 0x00000000, > + COLOR_CLEAR = 0xffff00ff, > + COLOR_FOGGED = 0x0000ff00, > + COLOR_UNFOGGED = 0x00ff0000 > + }; > + > + /* Fill the null-shader entry with the FVF (SetVertexShader is "overloaded" on d3d8). */ > + DWORD vertex_shader[3] = {D3DFVF_XYZ | D3DFVF_DIFFUSE | D3DFVF_SPECULAR, 0, 0}; Do you need the specular color on Windows as well, or to make this work right on Wine? I suspect that the NONE/NONE test doesn't work right on Wine because we do not set a controlled fog coordinate in wined3d/state.c, load_vertex_data(), in the case where WINED3D_FFP_SPECULAR is absent and similarly in drawprim.c, drawStridedSlow(). In either case that's no reason to hold up this patch any longer IMHO. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUOp0lAAoJEN0/YqbEcdMwgD4P/iLeSfFbE/jEsJ+Yux1lR9PC FDoJ50dxiedieOJWl4TbvIgr5uNyXnBm9YtPiiLgZJNfwoJ2znYjYDsA4h2yZ8FU lrgHwWcAo1ZvlPS0QolSYfx7QH4TpGIKklfEr7Qe4LQgftJjHNGioDuK1zpT+E3e JjcZOXDKjOP4ACNu5awEBq9v427TxOT9E+GJQWrq/cxbCYRbDurFwuFS2Jb1o/j+ 9zEoy8qiaQ+6v0j8+RcAkBTMdg6DBwSOYsH7P/KjrnzUkj+yH1w+R9dcnHMdaeMP RRoJSLsGzfANXF05vn7vE5Q5QzOjhXtIWWL/yun/IAL/EofZrXyVikoGP28wxUV1 QBICfDUvel4dhnYxNzNGUMQXC7gaXmJI3q12gemhkX4vj2W/FxVIaSN7vr5j+5rp 2ijdi9rexyBopbDM/9ay599GSNjXrTljkv8sEH23JMIpKR2BP7afyih6Hta9e/zf Ao9LtFwyBye2F9HTyM9G10MBrnVdNIKhJ9ZY30bRhomtXrfP1HuRvvpfRPja9gjZ M/aiwqPM6a3vfdJ/kIOra72vNZAoE9ccEOuDPQqMhg2ccoYvLUg6+LGvKRLanmOO lCsKiFYUChwJlebbo98+bfhMiR7TBI5fkwXOxR4coDu9jIl1oP2GblaL5Sul+zg1 rXbnkL2Pltlb/ZaW33l0 =Ozzv -----END PGP SIGNATURE-----

3 6

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar. (try 3)
by Michael Stefaniuc Oct. 17, 2014

Oct. 17, 2014

Hello Alex, I'll have a go at reviewing your patches as Alexandre didn't take them as is. On 10/13/2014 05:54 AM, Alex Henrie wrote: > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c I'm pulling this diff chunk to the front as it is wrong and some of your code is over-complicated based on that assumption. > @@ -1963,7 +2119,7 @@ BOOL WINAPI EnumSystemCodePagesW( CODEPAGE_ENUMPROCW lpfnCodePageEnum, DWORD fla > * flags [I] Character mapping flags > * src [I] Source string buffer > * srclen [I] Length of src (in bytes), or -1 if src is NUL terminated > - * dst [O] Destination buffer > + * dst [O] Destination buffer, or NULL to compute the required length > * dstlen [I] Length of dst (in WCHARs), or 0 to compute the required length The only case where dst == NULL is when dstlen == 0 but that already implies computing the required length. dst == NULL and dstlen != 0 is an error and MultiByteToWideChar() bails out. > @@ -1954,6 +1954,162 @@ BOOL WINAPI EnumSystemCodePagesW( CODEPAGE_ENUMPROCW lpfnCodePageEnum, DWORD fla > > > /*********************************************************************** > + * write_to_w_string > + * > + * Helper for utf7_mbstowcs > + * > + * RETURNS > + * TRUE on success, FALSE on error > + */ > +static inline BOOL write_to_w_string(WCHAR *dst, int dstlen, int *index, WCHAR character) This isn't a good name for the helper as that's not what it does. It is more a "count and optionally write". Also prefixing it utf7 would make it clear that is just a helper for utf7_mbstowcs and not a generic function and thus would remove the need for the comment that it is just a helper for utf7_mbstowcs. I know you're using this helper to avoid code duplication between the length calculation and the conversion unlike wine_utf8_mbstowcs(). But it complicates the handling of available space in dst. Without seeing the code for both approaches I'm not sure what is best so I'll review it as is. > +{ > + if (dst) You have to force dst = NULL in utf7_mbstowcs() for this to work. Just checking for dstlen > 0 should avoid that. > + { > + if (*index >= dstlen) > + return FALSE; > + > + dst[*index] = character; > + } > + > + (*index)++; > + > + return TRUE; > +} > + > +/*********************************************************************** > + * utf7_mbstowcs > + * > + * UTF-7 to UTF-16 string conversion, helper for MultiByteToWideChar > + * > + * RETURNS > + * On success, the number of characters written > + * On dst buffer overflow, -1 What about the case where it fails to decode a character? E.g. wine_utf8_mbstowcs() has -2 for that case which then translates to SetLastError(ERROR_NO_UNICODE_TRANSLATION). I looked at the tests but you didn't seem to test the GetLastError in the cases with the invalid input characters. > + */ > +static int utf7_mbstowcs(const char *src, int srclen, WCHAR *dst, int dstlen) > +{ > + static const WCHAR base64_decoding_table[] = { Why is this table an array of WCHAR? The entries aren't WCHARs. > + /* \0 */ -1, /* \x01 */ -1, /* \x02 */ -1, /* \x03 */ -1, This table is really hard to read even in a editor that does syntax highlighting. As you just need 4 characters per column you could have sixteen columns and merge the comments to one comment at the end of the line. Something like this would be more readable as well as being more compact: -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, /* 0x00 - 0x15 */ .... /* '0' - '?' */ > + /* \x04 */ -1, /* \x05 */ -1, /* \x06 */ -1, /* \a */ -1, > + /* \b */ -1, /* \t */ -1, /* \n */ -1, /* \v */ -1, > + /* \f */ -1, /* \r */ -1, /* \x0E */ -1, /* \x0F */ -1, > + /* \x10 */ -1, /* \x11 */ -1, /* \x12 */ -1, /* \x13 */ -1, > + /* \x14 */ -1, /* \x15 */ -1, /* \x16 */ -1, /* \x17 */ -1, > + /* \x18 */ -1, /* \x19 */ -1, /* \x1A */ -1, /* \e */ -1, > + /* \x1C */ -1, /* \x1D */ -1, /* \x1E */ -1, /* \x1F */ -1, > + /* */ -1, /* ! */ -1, /* " */ -1, /* # */ -1, > + /* $ */ -1, /* % */ -1, /* & */ -1, /* ' */ -1, > + /* ( */ -1, /* ) */ -1, /* * */ -1, /* + */ 62, > + /* , */ -1, /* - */ -1, /* . */ -1, /* / */ 63, > + /* 0 */ 52, /* 1 */ 53, /* 2 */ 54, /* 3 */ 55, > + /* 4 */ 56, /* 5 */ 57, /* 6 */ 58, /* 7 */ 59, > + /* 8 */ 60, /* 9 */ 61, /* : */ -1, /* ; */ -1, > + /* < */ -1, /* = */ -1, /* > */ -1, /* ? */ -1, > + /* @ */ -1, /* A */ 0, /* B */ 1, /* C */ 2, > + /* D */ 3, /* E */ 4, /* F */ 5, /* G */ 6, > + /* H */ 7, /* I */ 8, /* J */ 9, /* K */ 10, > + /* L */ 11, /* M */ 12, /* N */ 13, /* O */ 14, > + /* P */ 15, /* Q */ 16, /* R */ 17, /* S */ 18, > + /* T */ 19, /* U */ 20, /* V */ 21, /* W */ 22, > + /* X */ 23, /* Y */ 24, /* Z */ 25, /* [ */ -1, > + /* \ */ -1, /* ] */ -1, /* ^ */ -1, /* _ */ -1, > + /* ` */ -1, /* a */ 26, /* b */ 27, /* c */ 28, > + /* d */ 29, /* e */ 30, /* f */ 31, /* g */ 32, > + /* h */ 33, /* i */ 34, /* j */ 35, /* k */ 36, > + /* l */ 37, /* m */ 38, /* n */ 39, /* o */ 40, > + /* p */ 41, /* q */ 42, /* r */ 43, /* s */ 44, > + /* t */ 45, /* u */ 46, /* v */ 47, /* w */ 48, > + /* x */ 49, /* y */ 50, /* z */ 51, /* { */ -1, > + /* | */ -1, /* } */ -1, /* ~ */ -1, /* \x7F */ -1 > + }; > + > + const char *source_end = src + srclen; > + int dest_index = 0; > + > + DWORD byte_pair = 0; > + short offset = 0; > + > + /* MultiByteToWideChar guarantees that srclen > 0 */ > + assert(srclen > 0); This assert isn't needed. Just rewriting the first do..while loop to a while loop avoids it. That eliminates 3 lines of code of which one is a comment pointing to an unneeded assert. > + > + if (!dstlen) > + dst = NULL; Unneeded if the helper just checks for dstlen > 0. > + > + do Should be just "while (src < source_end)" to avoid the assert from above. > + { > + if (*src == '+') > + { > + src++; /* skip the + sign */ > + if (src >= source_end) > + break; > + > + if (*src == '-') > + { > + /* just a plus sign escaped as +- */ > + if (!write_to_w_string(dst, dstlen, &dest_index, '+')) > + return -1; > + src++; > + continue; > + } > + > + do > + { > + WCHAR sextet = *src; Same as for base64_decoding_table, sextet is not a WCHAR. > + if (sextet == '-') > + { > + /* skip over the dash and end base64 decoding */ > + /* the current, unfinished byte pair is discarded */ > + src++; > + offset = 0; > + break; > + } > + else if (sextet <= 127) > + { > + sextet = base64_decoding_table[sextet]; > + if (sextet == (WCHAR)-1) Unneeded cast. Using a signed type for sextet also avoids the -Wsign-compare compiler warning. Alternatively use ~0 instead of -1 if you want to keep an unsigned type. > + { > + /* -1 means that the next character of src is not part of a base64 sequence */ This upper part of the comment is better placed in the declaration of base64_decoding_table. > + /* in other words, all sextets in this base64 sequence have been processed */ > + /* the current, unfinished byte pair is discarded */ > + offset = 0; > + break; > + } > + } > + else > + { > + /* the next character of src is > 127 and therefore not part of a base64 sequence */ > + /* the current, unfinished byte pair is NOT discarded in this case */ > + /* this is probably a bug in Windows */ > + break; > + } > + > + byte_pair = (byte_pair << 6) | sextet; > + offset += 6; > + > + if (offset >= 16) > + { > + /* this byte pair is done */ > + if (!write_to_w_string(dst, dstlen, &dest_index, (byte_pair >> (offset - 16)) & 0xFFFF)) > + return -1; > + offset -= 16; > + } > + > + /* this sextet is done */ > + src++; > + } while (src < source_end); > + } > + else > + { > + /* we have to convert to unsigned char in case *src > 127 */ > + if (!write_to_w_string(dst, dstlen, &dest_index, (unsigned char)*src)) > + return -1; > + src++; > + } > + } while (src < source_end); > + > + return dest_index; > +} > + > +/*********************************************************************** > * MultiByteToWideChar (KERNEL32.@) > * > * Convert a multibyte character string into a Unicode string. bye michael

3 7

reg.exe platform specific test?
by Jonathan Vollebregt Oct. 17, 2014

Oct. 17, 2014

In the reg.exe tests around line 181: > verify_reg(hkey, "dword8", REG_DWORD, &dword, sizeof(dword), > (sizeof(long) > sizeof(DWORD)) ? 0 : TODO_REG_DATA); What's the reason for this? Is there some platform specific quirk I should be aware of?

4 4

Re: Italian translation of Wine
by Matteo Bruni Oct. 17, 2014

Oct. 17, 2014

2014-10-16 11:19 GMT+02:00 Davide Pizzetti <erpizzo(a)alice.it>: > This is an updated patch for the Italian translation of Wine. > Hi Davide, Please bear with me, but: @@ -30,7 +34,6 @@ msgid "&Install..." msgstr "&Installa..." #: appwiz.rc:65 -#, fuzzy #| msgid "" #| "The following software can be automatically removed. To remove a program " #| "or to modify its installed components, select it from the list and click " I still think you should remove those "#| msgid" lines when removing the fuzzy tags. If the program you're using to update the .po file doesn't help you with that, you might have to do it by hand by opening the .po file in a plain text editor. @@ -1682,11 +1682,11 @@ msgstr "Autenticazione del client" #: crypt32.rc:140 msgid "Code Signing" -msgstr "Firma codice" +msgstr "Firma del codice" #: crypt32.rc:141 msgid "Secure Email" -msgstr "Email sicura" +msgstr "E-mail sicura" #: crypt32.rc:142 msgid "Time Stamping" I don't like those changes, they seem mostly gratuitous to me (there are others similar instances below). If you're changing the "email" translation, make sure to be consistent. In general I'd avoid adding more stuff to this patch on each iteration, first get this patch in and then you can work on another one with more string translations. @@ -1834,7 +1834,7 @@ msgstr "Altro nome=" #: crypt32.rc:186 msgid "Email Address=" -msgstr "Indirizzo Email=" +msgstr "Indirizzo mail=" This looks wrong. @@ -2861,7 +2855,7 @@ msgstr "" #: cryptui.rc:127 msgid "Protects e-mail messages" -msgstr "Protegge messaggi e-mail" +msgstr "Protegge i messaggi mail" Same. @@ -4800,7 +4785,7 @@ msgstr "Nessuno spegnimento in corso.\n" #: winerror.mc:1381 msgid "I/O device error.\n" -msgstr "Errore I/O dell'unità.\n" +msgstr "Errore I/O del dispositiov.\n" #: winerror.mc:1386 This is still wrong. #: netstat.rc:48 msgid "Reset Connections" -msgstr "Connessione LAN" +msgstr "Resetta le connessioni" This means "Connessioni resettate". You can use "chiuse" instead, or probably even "annullate" as you wrote in another message translation. @@ -13103,7 +13080,7 @@ msgstr "Wine" #: wineboot.rc:46 msgid "The Wine configuration in %s is being updated, please wait..." msgstr "" -"La configurazione di Wine in %s è in aggiornamento, aspetta un momento..." +"La configurazione di Wine in %s sta venendo aggiornata, aspetta un momento..." I prefer the previous translation.

3 4

Re: server: Fix invalid memory access when copying KeyNameInformation data.
by Austin English Oct. 17, 2014

Oct. 17, 2014

On Thu, Oct 16, 2014 at 11:13 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=37411 for me. > > --- > server/registry.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Works here as well, thanks for the fix. -- -Austin

2 1

todo_wine under the hood
by Jonathan Vollebregt Oct. 17, 2014

Oct. 17, 2014

I was looking at verify_reg_() in programs/reg/tests/reg.c:61 and noticed some simple if statements: > if (todo & TODO_REG_TYPE) > todo_wine lok(type == exp_type, "got wrong type %d, expected %d\n", type, exp_type); > else > lok(type == exp_type, "got wrong type %d, expected %d\n", type, exp_type); > if (todo & TODO_REG_SIZE) > todo_wine lok(size == exp_size, "got wrong size %d, expected %d\n", size, exp_size); > else > lok(size == exp_size, "got wrong size %d, expected %d\n", size, exp_size); > if (todo & TODO_REG_DATA) > todo_wine lok(memcmp(data, exp_data, size) == 0, "got wrong data\n"); > else > lok(memcmp(data, exp_data, size) == 0, "got wrong data\n"); Simple enough, except if I pass TODO_REG_TYPE to this function it never even tries the size or data blocks. While this makes sense to implement (You can't test the data if you don't know it's size) I have no idea *how* it does it. I've tried the obvious - the mask values don't overlap in a way that would cause it to fallthrough. The lok and todo_wine macros don't have anything in them that returns. In fact the todo_wine macro appears to start a loop for some reason and all in all I'm very confused as to how exactly it's doing this. I'm curious as to how this works under the hood. I also need to stick a broken() in there somewhere but every time I do it falls through, and I don't want to rewrite the entire verify_reg_() function for a single exception. (If you're interested, reg add a REG_BINARY with an odd number of characters prefixes a 0 nibble, but suffixes it in XP)

2 4

Re: [PATCH 3/5] d3d9/tests: Add style and size tests for D3DCREATE_NOWINDOWCHANGES.
by Henri Verbeet Oct. 17, 2014

Oct. 17, 2014

On 16 October 2014 17:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/d3d9/tests/d3d9ex.c b/dlls/d3d9/tests/d3d9ex.c > index 11fe091..34b967a 100644 > --- a/dlls/d3d9/tests/d3d9ex.c > +++ b/dlls/d3d9/tests/d3d9ex.c > @@ -37,6 +37,7 @@ struct device_desc > unsigned int width; > unsigned int height; > BOOL windowed; > + DWORD behavior_flags; > }; > I don't like this much, I'd probably prefer "windowed" and "behavior_flags" to be merged into a single flags field and then have flags along the lines of e.g. CREATE_DEVICE_FULLSCREEN, CREATE_DEVICE_NOWINDOWCHANGES, CREATE_DEVICE_SWVP_ONLY, etc.

2 1

Re: server: KeyNameInformation returns the full name of the key. (try 3)
by Austin English Oct. 16, 2014

Oct. 16, 2014

On Mon, Oct 13, 2014 at 10:25 AM, Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > Try 3: > - Avoid allocating memory. (Based on Alexandre's comment, thanks.) > - Use k != root_key instead of k->namelen != 0. > - Add insufficient buffer test. > > --- > dlls/ntdll/tests/reg.c | 19 ++++++++++++++----- > server/registry.c | 25 ++++++++++++++++++++++++- > 2 files changed, 38 insertions(+), 6 deletions(-) > Hi Akihiro, This change breaks the tests on my machine (causing wineserver to crash and the ntdll/reg test to fail), see https://bugs.winehq.org/show_bug.cgi?id=37411 Could you please take a look? Thanks, -Austin

1 1

Wine Gecko 2.34-beta2
by Jacek Caban Oct. 16, 2014

Oct. 16, 2014

Hi all, I uploaded new beta2 Wine Gecko builds. I believe that it makes sense to have another beta this time, because beta1 was off the tip. This week Firefox 34 entered beta stage and I merged its changes made upstream meantime. To test it, use the attached patch or my Wine fork [1]. It should work out of box as soon as [2] is committed. Until then, you may download the package manually [3]. I will be mostly away next week. If all goes well, I will merge Mozilla beta and release new Wine Gecko in about two weeks. All testing is appreciated. If you find any regression, please let me know. Thanks, Jacek [1] http://repo.or.cz/w/wine/wine-gecko.git [2] http://source.winehq.org/patches/data/107093 [3] https://sourceforge.net/projects/wine/files/Wine%20Gecko/2.34-beta2/

1 0

d3d focus patches
by Stefan Dösinger Oct. 16, 2014

Oct. 16, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Matteo, I have attached the current state of my focus handling patches. They are more readable than the last ones and contain additional tests, but they're not finished yet. I hope they help with the gamma restore handling. I'd be interested to know if they pass for you on Windows. Especially d3d9ex has unreliable / buggy behavior on my Windows boxes. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUPtvBAAoJEN0/YqbEcdMw6JoP/jIUtgxta1SubRejbBz6lVS3 +CXS5WFNV8Kpc1fKpK6VRqs+HHNy7fH55zXAuw3KCzIarh7JPPjrgP2U4pSzuaHa fH2cWhysMbxK2tKRD0VHiZY696H/rpGgqFVwxusQuB/+Pzeqe7wpSOFOJ2QGUWqb GuAm4YFRfNdXaSQ94c4NBMU+a4N+TcXuI7YDus3WDcDIASAUnMs3i3NCmh/0IxI0 wrIfuY1szbVqI+qs6eGeN0TzTcRgEC9QHrevwdOyE7OsiN7z850wKX0k/zHxuHCl BazHk6JS0i0r3r9V+6NmUVCAqmplY93Kr04hHWxJDMWIilIxvVHs62m+wEBg+pDC LBTVlJhh28fPNAM6pPqrTUeAKnNGXwd+bevGrjl1035+qokKsj2VbIL6TnP2vDKo APORCXZ7INPp8c4EVIKHex60N2+Ec+Y8CWruUtn/UIJeMue2dgKxEq/FY5c4otWn Xu2OIUe/76cWG1tNxsTp6QhauYCW/JlteBKkyNnt/Wj/1I2LkQ8PxKEwNNCF9sbq +0oQIbLH0TRO5qU4uNAiKzPhFY4Sgy6RfMZpNpyQLSm0rT7bXeIb/EnF0Isklkaz t++UztQ/1A5ZjfeH235sPuyJ61YUTFgLfFG5swZcyZTdtTa0gymG4Ku9G1P018TU gwUbjaw/QqYKJsmEcjFK =Y/QI -----END PGP SIGNATURE-----

3 4

Re: [PATCH 2/5] d3d8/tests: Port the applicable parts of the new unsupported shaders tests to d3d8.
by Marvin Oct. 16, 2014

Oct. 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9559 Your paranoid android. === w8 (32 bit device) === device.c:2421: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3128: Test failed: Expected wndproc 0x412e30, got 0x412e30.

1 0

Re: [PATCH 1/5] d3d9/tests: Port the unsupported shaders test to D3D9Ex.
by Marvin Oct. 16, 2014

Oct. 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9558 Your paranoid android. === w8 (32 bit device) === device.c:2421: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3078: Test failed: Expected wndproc 0x412c60, got 0x412c60.

1 0

Re: Italian translation of Wine
by Matteo Bruni Oct. 15, 2014

Oct. 15, 2014

2014-10-15 15:55 GMT+02:00 Davide Pizzetti <erpizzo(a)alice.it>: > This is the patch that improves the Italian translation of Wine. > Davide > Thank you for the translation! I do have some comments though. @@ -187,8 +188,8 @@ msgid "" "href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> for " "details." msgstr "" -"Wine non ha trovato un pacchetto Gecko, necessario ad applicazioni che " -"incorporano HTML per funzionare correttamente. Wine lo può scaricare e " +"Wine non è riuscito a trovare un pacchetto Mono, che è necessario ad " +"applicazioni .NET per funzionare correttamente. Wine lo può scaricare e " "ad" doesn't sound right. Maybe "per"? Or something like "per far sì che applicazioni .NET funzionino correttamente". @@ -868,7 +869,7 @@ msgstr "Il file non esiste" #: comdlg32.rc:40 msgid "The selection contains a non-folder object" -msgstr "" +msgstr "La selezione contiene un oggetto non in una cartella" That's not what the original message means. I don't have a nice translation for it though... @@ -3579,33 +3570,30 @@ msgstr "Errore di sintassi" #: jscript.rc:37 msgid "Expected ';'" -msgstr "Richiesto ';'" +msgstr "Previsto ';'" I'd probably prefer "Atteso", here and in the other similar messages. @@ -3613,7 +3601,7 @@ msgstr "Costante stringa non terminata" #: jscript.rc:44 msgid "'return' statement outside of function" -msgstr "" +msgstr "dichiarazione 'return' al di fuori della funzione" A nitpick, but 'return' is not a declaration. I would simply go for "Istruzione". @@ -4785,10 +4769,9 @@ msgid "No Unicode translation.\n" msgstr "Nessuna traduzione Unicode.\n" #: winerror.mc:1366 -#, fuzzy #| msgid "DLL init failed.\n" msgid "DLL initialization failed.\n" -msgstr "Inizializzazione DLL fallita.\n" +msgstr "Inizializzazione del DLL fallita.\n" Another one that's probably arguable, but I prefer the previous translation here. If you really want to add the preposition, that clearly wants the feminine form - yeah I know foreign words don't have a gender in Italian :P FWIW you use the feminine form with "DLL" later on in the patch. A general comment, I think it's best if you also remove the old, commented out, msgid when you fix those fuzzy translations. @@ -4800,7 +4783,7 @@ msgstr "Nessuno spegnimento in corso.\n" #: winerror.mc:1381 msgid "I/O device error.\n" -msgstr "Errore I/O dell'unità.\n" +msgstr "Errore I/O del dispositiov.\n" Typo. #: oleacc.rc:110 msgctxt "object state" msgid "floating" -msgstr "" +msgstr "ondeggiante" "ondeggiante" sounds quite bad. Not sure what would be the right translation here though... "galleggiante" would be the most direct translation but it doesn't seem right either. Maybe "mobile" or something? #: oleacc.rc:121 msgctxt "object state" msgid "traversed" -msgstr "" +msgstr "attraversabile" "attraversato" #: oleacc.rc:127 -#, fuzzy #| msgid "Write protected.\n" msgctxt "object state" msgid "protected" -msgstr "Protetto da scrittura.\n" +msgstr "protetto\n" You should drop the \n here. #: urlmon.rc:43 msgid "" "When installed, an ActiveX component has full access to your computer. Do " "not click install unless you have absolute trust in the above source." msgstr "" +"Quando installato, un componente ActiveX ha un accesso completo al tuo " +"computer. Non installarlo finché non ne hai una fiducia assoluta." "finché" doesn't seem appropriate. I'd go with "a meno che". @@ -9737,14 +9690,13 @@ msgid "" "CD <directory> is the short version of CHDIR. It changes the current\n" "default directory.\n" msgstr "" -"CD <dir> è la versione ridotta di CHDIR. Cambia la cartella\n" +"CD <director> è la versione ridotta di CHDIR. Cambia la cartella\n" "predefinita attuale.\n" Typo. @@ -9810,7 +9761,9 @@ msgstr "" "Il comando FOR è usato per eseguire un comando per ciascuno di un set di " "files.\n" "\n" -"Sintassi: FOR %variabile IN (set) DO comando\n" +"Sintassi: FOR %variable IN (set) DO comando\n" +"\n" +"Il segno % dev'essere ripetuto quando si utilizza FOR in un file batch.\n" "%variabile" was probably on purpose. #: netstat.rc:56 -#, fuzzy #| msgid "Decoding Error" msgid "Receive Errors" -msgstr "Errore di decodifica" +msgstr "Ricevi gli errori" That message means "Errori di ricezione". @@ -11095,7 +11026,7 @@ msgid "" msgstr "" "Il file '%s' non esiste.\n" "\n" -"Creare un nuovo file?" +"Vuoi creare un nuovo file?" Arguable, but I preferred the impersonal form of the previous translation. #: winecfg.rc:226 -#, fuzzy #| msgid "Wine configuration" msgid "Drive configuration" -msgstr "Configurazione di Wine" +msgstr "Configurazione dell'unità di memorizzazione di massa" Maybe simply "Configurazione dischi"? I do like the general tone of your translations. Thank you again!

1 0

Re: [PATCH 4/4] dwrite: Implement HasCharacter()
by Marvin Oct. 15, 2014

Oct. 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9549 Your paranoid android. === wvistau64 (32 bit font) === font.c:676: Test failed: got 0x80004002 === w2008s64 (32 bit font) === font.c:676: Test failed: got 0x80004002 === wvistau64 (64 bit font) === font.c:676: Test failed: got 0x80004002 === w2008s64 (64 bit font) === font.c:676: Test failed: got 0x80004002

1 0

Re: [PATCH 3/4] dwrite: Added one more test for system font collection
by Marvin Oct. 15, 2014

Oct. 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9548 Your paranoid android. === wvistau64 (32 bit font) === font.c:665: Test failed: got 0x80004002 === w2008s64 (32 bit font) === font.c:665: Test failed: got 0x80004002 === wvistau64 (64 bit font) === font.c:665: Test failed: got 0x80004002 === w2008s64 (64 bit font) === font.c:665: Test failed: got 0x80004002

2 1

Re: [3/3] msvcrt: Added _fflush_nolock() implementation
by Piotr Caban Oct. 15, 2014

Oct. 15, 2014

Hi, On 10/09/14 19:52, Iván Matellanes wrote: > +/********************************************************************* > + * _fflush_nolock (MSVCRT.@) > + */ > +int CDECL MSVCRT__fflush_nolock(MSVCRT_FILE* file) > +{ > + if(!file) { > + msvcrt_flush_all_buffers(MSVCRT__IOWRT); There's one more thing that looks strange here. msvcrt_flush_all_buffers calls MSVCRT_fflush internally. That causes some streams to get locked and unlocked. Could you please add a test that checks how native behaves here? I'm not sure if we should lock any FILE's in a _nolock function variant. Thanks, Piotr

2 2

Re: Updated the Italian .po file of Wine
by Nikolay Sivov Oct. 15, 2014

Oct. 15, 2014

On 10/14/2014 04:48 PM, Davide Pizzetti wrote: > I just updated the Italian translation of Wine. > Davide > > > Hi, Davide. Thank you for your contribution, but you need to do one more step to these changes accepted into Wine - changes should be sent in a diff format. That means you need to fetch Wine git repo, update translations and generate a patch that will contain your changes only, not the whole po-file. Whole process is described here http://wiki.winehq.org/SubmittingPatches, if you have any question after reading this wiki article feel free to ask them on wine-devel mailing list.

1 0

Re: [PATCH 2/4] d3d9/tests: Avoid mode changes in d3d9ex' test_lost_device.
by Marvin Oct. 15, 2014

Oct. 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9532 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:1276: Test failed: Got unexpected hr 0. d3d9ex.c:1278: Test failed: Got unexpected hr 0. d3d9ex.c:1280: Test failed: Got unexpected hr 0. d3d9ex.c:1282: Test failed: Got unexpected hr 0.

3 3