November 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] winex11.drv: call XRRSetScreenSize when changing resolution
by Henri Verbeet Nov. 20, 2014

Nov. 20, 2014

On 20 November 2014 13:11, Mark Harmstone <hellas(a)burntcomma.com> wrote: > This changes xrandr12_set_current_mode so it behaves the same way as xrandr > does in 1.2 mode (e.g, `xrandr --output HDMI-0 --crtc 0 --mode 640x480`). > Before XRRSetCrtcConfig is called, the CRTC is temporarily disabled, then > XRRSetScreenSize is called. (XRRSetCrtcConfig will fail if the CRTC isn't > disabled first.) > Stefan did tests for this a while back so he'll know the details, but I'm pretty sure this will do the wrong thing on multihead systems.

1 0

Re: Update dmFormName when changing paper size in print ui.(resend, try2)
by Dmitry Timoshkov Nov. 20, 2014

Nov. 20, 2014

Ralf Habacker <ralf.habacker(a)freenet.de> wrote: > + GetDlgItemTextA(hDlg, cmb2, lpdm->dmFormName, sizeof(lpdm->dmFormName)); Please use CCHFORMNAME instead of sizeof(). > + GetDlgItemTextW(hDlg, cmb2, lpdm->dmFormName, sizeof(lpdm->dmFormName)/sizeof(WCHAR)); Same here. -- Dmitry.

1 0

Re: [PATCH 2/2] Do not call SendMessage() to hide a window that is already hidden (try 3)
by Marvin Nov. 20, 2014

Nov. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10365 Your paranoid android. === w7u (32 bit msg) === msg.c:12214: Test failed: unexpected hwnd 00080150 msg.c:12236: Test failed: bad time 30b26/30b36

1 0

Re: Update dmFormName when changing paper size in print ui. (resend)
by Nikolay Sivov Nov. 20, 2014

Nov. 20, 2014

On 20.11.2014 10:42, Ralf Habacker wrote: > - if(Sel != CB_ERR) > + if(Sel != CB_ERR) { > lpdm->u1.s1.dmPaperSize = SendDlgItemMessageW(hDlg, cmb2, > CB_GETITEMDATA, > Sel, 0); > + GetDlgItemTextW(hDlg, cmb2, lpdm->dmFormName, sizeof(lpdm->dmFormName)); > + } This looks wrong, this function takes character length, not byte length.

1 0

Re: [PATCH 4/5] wined3d: Don't minimize hidden Windows.
by Marvin Nov. 20, 2014

Nov. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10357 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2476: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2481: Test failed: The focus window is active. device.c:2489: Test failed: Got unexpected hr 0x88760869. device.c:2495: Test failed: Got unexpect screen size 800x600. device.c:2510: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2519: Test failed: Got unexpect screen size 800x600. device.c:2532: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2539: Test failed: Got unexpect width 640. device.c:2540: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 2/5] wined3d: Set the device window size on focus window activation.
by Marvin Nov. 20, 2014

Nov. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10354 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2454: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2459: Test failed: The focus window is active. device.c:2467: Test failed: Got unexpected hr 0x88760869. device.c:2473: Test failed: Got unexpect screen size 800x600. device.c:2488: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2497: Test failed: Got unexpect screen size 800x600. device.c:2633: Test failed: Expected foreground window 000500F6, got 0002004C. device.c:3009: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3013: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3036: Test failed: Failed to reset device, hr 0x88760868. device.c:3040: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3044: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3058: Test failed: Failed to set foreground window. device.c:3062: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:3066: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: d3dcompiler_43: Remove a no-op statement (PVS-Studio)
by Matteo Bruni Nov. 19, 2014

Nov. 19, 2014

2014-11-19 9:10 GMT+01:00 Michael Stefaniuc <mstefani(a)redhat.de>: > D3DSRO_POSITION is 0. Yes, it is 0, but I still feel like it should stay there for consistency with the other cases. What I mean is that if that line is removed I'm pretty sure I'd be like "oh wow, this is clearly broken" every time I happen to look at that piece of code. But maybe that's just me. > --- > dlls/d3dcompiler_43/bytecodewriter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/dlls/d3dcompiler_43/bytecodewriter.c b/dlls/d3dcompiler_43/bytecodewriter.c > index 46187f9..71ee6c1 100644 > --- a/dlls/d3dcompiler_43/bytecodewriter.c > +++ b/dlls/d3dcompiler_43/bytecodewriter.c > @@ -855,7 +855,6 @@ static DWORD map_vs_output(struct bc_writer *This, DWORD regnum, DWORD mask, DWO > *has_components = TRUE; > if(regnum == This->oPos_regnum) { > token |= (D3DSPR_RASTOUT << D3DSP_REGTYPE_SHIFT) & D3DSP_REGTYPE_MASK; > - token |= D3DSRO_POSITION & D3DSP_REGNUM_MASK; /* No shift */ > return token; > } > if(regnum == This->oFog_regnum && mask == This->oFog_mask) { > -- > 1.9.3 Cheers, Matteo.

3 2

Re: [PATCH 1/2] mmdevapi: allow GetPropValue function in audio drivers (try 2)
by Andrew Eikum Nov. 19, 2014

Nov. 19, 2014

Looks good, just one small note below. On Wed, Nov 19, 2014 at 02:35:14PM +0000, Mark Harmstone wrote: > + if (!drvs.pGetPropValue) > + { > + TRACE("Driver does not implement GetPropValue\n"); > + return E_NOTIMPL; > + } > + This makes the drivers without GetPropValue pretty noisy during loading. I don't think anything needs to be printed, since we'll see the TRACEs from the driver if the function is present. Andrew

1 0

Re: [PATCH 2/2] winealsa: implement GetPropValue and return device path (try 2)
by Andrew Eikum Nov. 19, 2014

Nov. 19, 2014

Looking pretty good. Couple notes below. On Wed, Nov 19, 2014 at 02:35:39PM +0000, Mark Harmstone wrote: > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 5ad72f9..c21fd0c 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -3823,3 +3823,107 @@ HRESULT WINAPI AUDDRV_GetAudioSessionManager(IMMDevice *device, > > return S_OK; > } > + > +enum AudioDeviceConnectionType { > + AudioDeviceConnectionType_Unknown = 0, > + AudioDeviceConnectionType_PCI, > + AudioDeviceConnectionType_USB > +}; > + > +HRESULT WINAPI AUDDRV_GetPropValue(GUID *guid, const PROPERTYKEY *prop, PROPVARIANT *out) > +{ > + static const PROPERTYKEY devicepath_key = { /* undocumented? - {b3f8fa53-0004-438e-9003-51a46e139bfc},2 */ > + {0xb3f8fa53, 0x0004, 0x438e, {0x90, 0x03, 0x51, 0xa4, 0x6e, 0x13, 0x9b, 0xfc}}, 2 > + }; > + > + static const char dev_info[] = "/sys/class/sound/card%u/device/uevent"; > + I'd prefer "const char *" and actually, is there any reason not to just put this string straight in the sprintf? > + TRACE("%s, (%s,%u), %p\n", wine_dbgstr_guid(guid), wine_dbgstr_guid(&prop->fmtid), prop->pid, out); > + > + if(IsEqualGUID(&prop->fmtid, &devicepath_key.fmtid) && prop->pid == devicepath_key.pid) > + { I think you can use IsEqualPropertyKey here. > + char name[256], uevent[MAX_PATH]; > + EDataFlow flow; > + FILE *fuevent; > + int card, device; > + > + if(!get_alsa_name_by_guid(guid, name, sizeof(name), &flow)) > + { > + WARN("Unknown interface %s\n", debugstr_guid(guid)); > + return E_NOINTERFACE; > + } > + > + /* only implemented for identifiable devices, i.e. not "default" */ > + if(!sscanf(name, "plughw:%u,%u", &card, &device)) > + return E_NOTIMPL; > + > + sprintf(uevent, dev_info, card); > + fuevent = fopen(uevent, "r"); > + > + if(fuevent){ > + enum AudioDeviceConnectionType connection = AudioDeviceConnectionType_Unknown; > + USHORT vendor_id = 0, product_id = 0; > + char *line = NULL; > + > + while (!feof(fuevent)) { > + char *val; > + size_t val_len, len = 0; > + > + getline(&line, &len, fuevent); > + We should probably break on failure here. > + if((val = strchr(line, '='))) { > + val[0] = 0; > + val++; > + > + val_len = strlen(val); > + if (val_len > 0 && val[val_len - 1] == '\n') { val[val_len - 1] = 0; } > + > + if(!strcmp(line, "PCI_ID")){ > + connection = AudioDeviceConnectionType_PCI; > + sscanf(val, "%hX:%hX", &vendor_id, &product_id); > + }else if (!strcmp(line, "DEVTYPE") && !strcmp(val,"usb_interface")) > + connection = AudioDeviceConnectionType_USB; > + else if (!strcmp(line, "PRODUCT")) > + sscanf(val, "%hx/%hx/", &vendor_id, &product_id); > + } > + } Can we do anything sane on sscanf failure here? Maybe dump a WARN and revert back to AudioDeviceConnectionType_Unknown. Is that preferable to falling back on 0 for one or more of the IDs? Andrew

1 0

Re: [2/2] vssapi: Add stub implementations for a couple of functions.
by Alexandre Julliard Nov. 19, 2014

Nov. 19, 2014

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/vssapi/main.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/vssapi/vssapi.spec | 10 +++--- > include/Makefile.in | 1 + > include/vss.idl | 31 ++++++++++++++++++ > include/vswriter.h | 47 ++++++++++++++++++++++++++++ > 5 files changed, 167 insertions(+), 5 deletions(-) > create mode 100644 include/vss.idl > create mode 100644 include/vswriter.h It doesn't build on Mingw: ../../../wine/dlls/vssapi/main.c:33:0: warning: "__thiscall" redefined [enabled by default] <built-in>:0:0: note: this is the location of the previous definition main.o:main.c:(.text+0x14): undefined reference to `_VSSAPI_CVssWriter_Initialize(a)36' collect2: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] wined3d: Take abs() of vertex z coordinate as FFP fog coordinate (try 7)
by Stefan Dösinger Nov. 19, 2014

Nov. 19, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-14 22:40, schrieb Joachim Priesner: > Take the absolute value of vertex.z as fog coordinate instead of > just the z coordinate. This fixes e.g. fog for applications that > use right-handed projection matrices. > > Also test the clamp behavior of the oFog vertex shader output. Fwiw, the start / end tests look good to me, and the results match what I expected. However I think Henri still disagrees with this patch. Henri, I'd appreciate if you would say what you want. Without that I can offer Joachim only guesswork. My guess is that the test is too complex. There are some parts that are technically not required to demonstrate the correctness of the abs(), but I see some value in the additional checks: *) The "interrupted" quad with extra vertices at z = 0. It shows that the fully fogged other quad is not a result of the interpolation failing entirely and producing INF or NaN. *) The foggy shader test: It shows how negative values coming from vertex shaders are treated. It's just logical to test this considering the behavior of the fixed function pipeline. *) The manual fog coord / unfogged shader tests: Those could be removed I guess, although at least the manual fog coord test shows that there isn't some unexpected interference with negative depth values. Joachim, I can offer you that I try to simplify those tests. If you're still motivated to work on this I'm happy to leave this up to you though. Some ideas for simplifying the test, but I don't know yet if they'll work: *) Split the shader and fixed function tests into separate tests. *) Remove the interpolation tests from the fixed function tests. fog_interpolation_test shows that the fog equation is evaluated in the vertex pipeline in the affected cases, and the fogstart = -1, fogend = 0 test shows that the abs() happens before the fog equation. So I think removing this part of the test for the fixed function part is safe. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUbK/nAAoJEN0/YqbEcdMworwP/2OytnoHiSrHWoFK9YPUvEGQ XIyIDZhe/PoMKaBGRdgqFWd4EjoVr9haUmCcPWb1BK/0R2MVSTIK0TS88RlotiMx ZIBcJJWCiiBvhNrydAW5Qqg/80h5UOgaumkWdi2qF4SfkvP/A3jLXvulXZaOU88k rmnlWXxiQun0EIMzShzms0OZmKxmyKkhm84CXAAr3hIh3k9anXVsr0Nsgi2UXTBl ey55rNaE/NBZdNMP/in/5kEq76f0WA7bx1CV2zfCds5p34thQPQLjuvYQ0mqz3Qg zo24W/J52m70W1GmqD/J2+4g5XPO2Gf3xIjV0NyJW988hsCoHIyQHFXZbRkZQpbQ ULdhBq6VgW6O9d1f9H1hy18HxVwlGPFjnu7gniMTWqtBLzyC3b6pppSqQfg1zRhj X/Njp/JBhSUWe8is4sP2R7sHl2fqMi5ROWQyXVpca/rUdoiu6dAH8zYo3IqepGDW P1RoSiwQXXDEh0tV/gzW7pVnk7nNRtcL6el0R5C7aqrytWi3xLXYfdsug6sluKK6 onN/Iz0PpBDsokaTFUMua1JgZ8fx7+Av/S/2xfPvMpSFyrp+q/Q4fw5HdQEKfCIb +JtA03sG0ZfKLjCWL3JRW2kt3G3TxQTOdaJ+Dic5S50xMjs04Ze2Ie3BzbY4FEn0 ZqXciJ+kIVCN4+LD5aJp =RHD+ -----END PGP SIGNATURE-----

1 0

Re: [PATCH 6/6] wined3d: Restore the display mode on focus change.
by Henri Verbeet Nov. 19, 2014

Nov. 19, 2014

On 18 November 2014 21:26, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!EnumDisplaySettingsW(adapter->DeviceName, ENUM_REGISTRY_SETTINGS, &new_mode)) Formatting. > + else if (current_mode.dmPelsWidth == new_mode.dmPelsWidth > + && current_mode.dmPelsHeight == new_mode.dmPelsHeight > + && current_mode.dmBitsPerPel == new_mode.dmBitsPerPel > + && (current_mode.dmDisplayFrequency == new_mode.dmDisplayFrequency > + || !(new_mode.dmFields & DM_DISPLAYFREQUENCY)) > + && (current_mode.u2.dmDisplayFlags == new_mode.u2.dmDisplayFlags > + || new_mode.dmFields & DM_DISPLAYFLAGS)) Shouldn't that be "!(new_mode.dmFields & DM_DISPLAYFLAGS)"? > - struct wined3d_display_mode original_mode; > + struct wined3d_display_mode original_mode, d3d_mode; I might have just gone for "mode", but I don't care strongly.

1 0

Re: [PATCH 1/2] ole32/tests: Release() doesn't return HRESULT code
by Marvin Nov. 19, 2014

Nov. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10342 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004209EA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004209EA

2 1

Re: ole32: Simplify a function by removing no-op code (PVS-Studio).
by Sebastian Lackner Nov. 19, 2014

Nov. 19, 2014

On 19.11.2014 09:26, Michael Stefaniuc wrote: > MSHLFLAGS_NORMAL is 0. > --- > dlls/ole32/stubmanager.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/dlls/ole32/stubmanager.c b/dlls/ole32/stubmanager.c > index 96d710d..1aca924 100644 > --- a/dlls/ole32/stubmanager.c > +++ b/dlls/ole32/stubmanager.c > @@ -536,7 +536,6 @@ HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, > /* returns TRUE if it is possible to unmarshal, FALSE otherwise. */ > BOOL stub_manager_notify_unmarshal(struct stub_manager *m, const IPID *ipid) > { > - BOOL ret = TRUE; > struct ifstub *ifstub; > > if (!(ifstub = stub_manager_ipid_to_ifstub(m, ipid))) > @@ -545,23 +544,7 @@ BOOL stub_manager_notify_unmarshal(struct stub_manager *m, const IPID *ipid) > return FALSE; > } > > - EnterCriticalSection(&m->lock); > - > - /* track normal marshals so we can enforce rules whilst in-process */ > - if (ifstub->flags & MSHLFLAGS_NORMAL) > - { > - if (m->norm_refs) > - m->norm_refs--; > - else > - { > - ERR("attempted invalid normal unmarshal, norm_refs is zero\n"); > - ret = FALSE; > - } > - } > - > - LeaveCriticalSection(&m->lock); > - > - return ret; > + return TRUE; > } > > /* handles refcounting for CoReleaseMarshalData */ > Although logically correct, I am not sure if this is what it should look like. In ole32/marshal for example there is also: --- snip --- if (flags & MSHLFLAGS_TABLEWEAK) TRACE(" MSHLFLAGS_TABLEWEAK"); if (!(flags & (MSHLFLAGS_TABLESTRONG|MSHLFLAGS_TABLEWEAK))) TRACE(" MSHLFLAGS_NORMAL"); if (flags & MSHLFLAGS_NOPING) TRACE(" MSHLFLAGS_NOPING"); --- snip --- This could probably mean that fixing the if condition is a more correct solution, but I don't know that part well enough.

2 1

Re: [PATCH 1/2] mmdevapi: allow GetPropValue function in audio drivers
by Nikolay Sivov Nov. 19, 2014

Nov. 19, 2014

On 18.11.2014 20:59, Mark Harmstone wrote: > + if (SUCCEEDED(hr)) > + { > + MMDevice_SetPropValue(id, flow, prop, &pv); > + > + if (pv.vt == VT_LPWSTR) > + HeapFree(GetProcessHeap(), 0, pv.u.pwszVal); > + } > + out->vt = VT_LPWSTR; > + out->u.pwszVal = HeapAlloc(GetProcessHeap(), 0, 256 * sizeof(WCHAR)); This is a wrong way dealing with PROPVARIANT, you need to use PropVariantClear() and InitPropVariantFromString() - PROPVARIANT implies CoTaskMemAlloc/CoTaskMemFree memory management.

1 0

Re: [PATCH 6/6] wined3d: Restore the display mode on focus change.
by Marvin Nov. 19, 2014

Nov. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10336 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2446: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2451: Test failed: The focus window is active. device.c:2459: Test failed: Got unexpected hr 0x88760869. device.c:2465: Test failed: Got unexpect screen size 800x600. device.c:2485: Test failed: Got unexpect screen size 800x600. device.c:2621: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2997: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3001: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3024: Test failed: Failed to reset device, hr 0x88760868. device.c:3028: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3032: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3046: Test failed: Failed to set foreground window. device.c:3050: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:3054: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 4/6] d3d8/tests: Test mode restoration on focus loss.
by Marvin Nov. 19, 2014

Nov. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10334 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2446: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2451: Test failed: The focus window is active. device.c:2459: Test failed: Got unexpected hr 0x88760869. device.c:2465: Test failed: Got unexpect screen size 800x600. device.c:2485: Test failed: Got unexpect screen size 800x600. device.c:2621: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2997: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3001: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3024: Test failed: Failed to reset device, hr 0x88760868. device.c:3028: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3032: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3046: Test failed: Failed to set foreground window. device.c:3050: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:3054: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 2/2] winealsa: implement GetPropValue and return device path
by Nikolay Sivov Nov. 18, 2014

Nov. 18, 2014

On 18.11.2014 20:59, Mark Harmstone wrote: > --- a/dlls/winealsa.drv/Makefile.in > +++ b/dlls/winealsa.drv/Makefile.in > @@ -1,5 +1,5 @@ > MODULE = winealsa.drv > -IMPORTS = uuid ole32 advapi32 > +IMPORTS = uuid ole32 advapi32 user32 > DELAYIMPORTS = winmm > EXTRALIBS = $(ALSA_LIBS) If you need this only for wsprintfW() you could try sprintfW() from include/wine/unicode.h.

1 0

Re: [PATCH 1/2] mshtml: Added support for IHTMLFrameBase::put_src call on detached element.
by Marvin Nov. 18, 2014

Nov. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10324 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] ddraw/tests: Test messages on focus loss (v2).
by Henri Verbeet Nov. 18, 2014

Nov. 18, 2014

On 17 November 2014 21:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2291,6 +2320,18 @@ static void test_coop_level_mode_set(void) > user32_rect.left, user32_rect.top, user32_rect.right, user32_rect.bottom, > r.left, r.top, r.right, r.bottom); > > + expect_messages = exclusive_focus_loss_messages; > + SetForegroundWindow(GetDesktopWindow()); > + ok(!expect_messages->message, "Expected message %#x, but didn't receive it.\n", expect_messages->message); This fails for me on Windows: ddraw1.c:2295: Test failed: Expected message 0x46, but didn't receive it.

1 0

Re: [3/6] user32/tests: Reenable test function for WM_GETTEXT.
by Marvin Nov. 18, 2014

Nov. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10317 Your paranoid android. === w2008s64 (64 bit win) === win.c:3367: Test failed: hwnd 00000000000100F4 message 0118

2 1

Re: configure: Fix detection of gnutls on Ubuntu 14.10.
by Nicolas Le Cam Nov. 18, 2014

Nov. 18, 2014

2014-11-17 9:37 GMT+01:00 Sebastian Lackner <sebastian(a)fds-team.de>: > Someone asked me to submit this, although its very Ubuntu specific. > > On some Ubuntu versions there only exists a package where libgnutls was renamed to libgnutls-deb0. As an effect ./configure fails to detect it properly because it compares the exact soname. > > http://packages.ubuntu.com/precise/amd64/libgnutls28/filelist > http://packages.ubuntu.com/utopic/amd64/libgnutls-deb0-28/filelist > > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Hi Sebastian, This also fixes libgnutls detection on Debian testing (and futur Jessie) and derivatives. What about [[libgnutls\$-deb[[0-9]]\$\\{0,1\\}]] or [[libgnutls\$-[[0-9A-Za-z]]\+\$\\{0,1\\}]] instead. I don't think the debian specific soname will bump too often but it could avoid the need for another patch. -- Nicolas Le Cam

2 1

Re: [PATCH 4/6] d3d8/tests: Test style changes on focus loss.
by Marvin Nov. 17, 2014

Nov. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10310 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2364: Test failed: Expected message 0x46 for window 0, but didn't receive it. device.c:2369: Test failed: The focus window is active. device.c:2373: Test failed: Got unexpected hr 0. device.c:2379: Test failed: Got unexpected hr 0. device.c:2393: Test failed: Got unexpected hr 0. device.c:2523: Test failed: Expected foreground window 000501B8, got 0002004C. device.c:2899: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2903: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2926: Test failed: Failed to reset device, hr 0x88760868. device.c:2930: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2934: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2948: Test failed: Failed to set foreground window. device.c:2952: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:2956: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 3/6] d3d8/tests: Test messages on focus loss (v2).
by Marvin Nov. 17, 2014

Nov. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10309 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2364: Test failed: Expected message 0x46 for window 0, but didn't receive it. device.c:2369: Test failed: The focus window is active. device.c:2373: Test failed: Got unexpected hr 0. device.c:2379: Test failed: Got unexpected hr 0. device.c:2393: Test failed: Got unexpected hr 0. device.c:2523: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2898: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2902: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2925: Test failed: Failed to reset device, hr 0x88760868. device.c:2929: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2933: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3301: Test failed: Failed to reset device. device.c:3308: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3316: Test failed: Expected wndproc != 0x411620.

1 0

Re: cryptext: add stubs for CryptExtAddPFX/CryptExtAddPFXW
by Nikolay Sivov Nov. 17, 2014

Nov. 17, 2014

On 17.11.2014 22:21, Austin English wrote: > +HRESULT WINAPI CryptExtAddPFX(LPCSTR filename) > +{ > + FIXME("stub: %s\n", debugstr_a(filename)); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} Return type and error code don't match here. If it should be HRESULT use E_NOTIMPL, otherwise return type should be DWORD or similar.

1 0

Re: [PATCH 2/2] mshtml: Added IHTMLStyleSheet::cssText tests.
by Marvin Nov. 17, 2014

Nov. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10298 Your paranoid android. === w2000pro (32 bit dom) === dom: unhandled exception c0000005 at 780104AC

1 0

Re: [PATCH 2/7] d3d9/tests: Test messages on focus loss.
by Alexandre Julliard Nov. 17, 2014

Nov. 17, 2014

Stefan Dösinger <stefan(a)codeweavers.com> writes: > Resolution changing behavior will be tested in a separate patch. > --- > dlls/d3d9/tests/d3d9ex.c | 277 ++++++++++++++++++++++++++++---------------- > dlls/d3d9/tests/device.c | 293 +++++++++++++++++++++++++++++++---------------- > 2 files changed, 375 insertions(+), 195 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so d3d9ex && touch d3d9ex.ok d3d9ex.c:1656: Tests skipped: This GPU supports SM3, skipping unsupported shader test. d3d9ex.c:1942: Test failed: Expected message 0x6 for window 0x1, but didn't receive it, i=0. d3d9ex.c:1964: Test failed: Got unexpected hr 0x8760878, i=0. d3d9ex.c:1942: Test failed: Expected message 0x6 for window 0x1, but didn't receive it, i=1. d3d9ex.c:1964: Test failed: Got unexpected hr 0x8760878, i=1. make: *** [d3d9ex.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 5/5] d3d10core/tests: Port alpha_test() to d3d10core.
by Marvin Nov. 17, 2014

Nov. 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10295 Your paranoid android. === w8 (32 bit visual) === visual.c:2635: Test failed: unexpected colortable on offscreen surface

1 0

Re: Update on MSNet
by Susan Cragin Nov. 14, 2014

Nov. 14, 2014

You can now ask that or any other question. I just asked about the licenses, Page 6. http://blogs.msdn.com/b/dotnet/archive/2014/11/12/net-core-is-open-source.a…

2 1

Update on MSNet
by Susan Cragin Nov. 14, 2014

Nov. 14, 2014

I'm sure you know this, but thought I would pass this along. MSNet framework is open-source. http://blogs.msdn.com/b/dotnet/archive/2014/11/12/net-core-is-open-source.a… An article I read said that MS has committed to developing linux and mac versions, but I don't see where MS has committed money to it. Keep up the good work! Susan

3 2

Re: [2/2] ntdll: Implement Rtl[Add|Remove]VectoredContinueHandler semi-stubs.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10262 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/003C0001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [1/2] ntdll/tests: Add basic tests for Rtl[Add|Remove]VectoredContinueHandler.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10261 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00350000/00350001 exception: unhandled exception 80000004 at 00350000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/00350001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/003D0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/003C0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 5/7] d3d8/tests: Test style changes on focus loss.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10250 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2889: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2893: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2916: Test failed: Failed to reset device, hr 0x88760868. device.c:2920: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2924: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2938: Test failed: Failed to set foreground window. device.c:2942: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:2946: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 4/7] d3d8/tests: Test messages on focus loss.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10249 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000301BA, got 0002004C. device.c:2888: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2892: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2915: Test failed: Failed to reset device, hr 0x88760868. device.c:2919: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2923: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3291: Test failed: Failed to reset device. device.c:3298: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3306: Test failed: Expected wndproc != 0x413100.

1 0

Re: winemac: WS_EX_DLGMODALFRAME shouldn't prevent the window being resizeable.
by Ken Thomases Nov. 13, 2014

Nov. 13, 2014

Hi, On Nov 13, 2014, at 3:26 AM, Huw Davies <huw(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index e61a517..54bd56e 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -72,12 +72,12 @@ static void get_cocoa_window_features(struct macdrv_win_data *data, > if (ex_style & WS_EX_TOOLWINDOW) wf->utility = TRUE; > } > } > - if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > - else if (style & WS_THICKFRAME) > + if (style & WS_THICKFRAME) > { > wf->shadow = TRUE; > if (!data->shaped) wf->resizable = TRUE; > } > + else if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) wf->shadow = TRUE; > } I think that's the correct logic, but it would be better to separate out setting resizable and shadow. The shadow stuff can be a single "if" with the conditions ORed together. Resizable can be a single "if" or even a simple assignment of a boolean expression. Thanks, Ken

1 1

RE: [PATCH] reg.exe: Modernise print functions
by Hugh McMaster Nov. 13, 2014

Nov. 13, 2014

On Monday, 10 November 2014, Jonathan Vollebregt wrote: >> WCHAR msg_buffer[1024]; >No easy way to get the expected size and dynamically allocate the output I take it? >I looked into it before but besides _vscprintf (In msvcrt, which we're >not allowed to use) there doesn't seem to be a way to get the expected >output size besides perhaps growing the buffer over and over again until >it fits (Which seems inefficient for a simple printing function) One possible way would be to avoid using vsnprintfW() and pass everything through to output_vprintf(). static void __cdecl reg_printfW(const WCHAR* msg, ...) { __ms_va_list va_args; __ms_va_start(va_args, msg); output_vprintf(msg, va_args); __ms_va_end(va_args); } This would have the advantage of using FormatMessage() to allocate memory. But we would have to replace all format specifiers (four or five?) with their FormatMessage() equivalents. static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','x',' ',' ','d','a','t','a',' ','%','s','\n',0}; becomes static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','1','!','x','!',' ',' ','d','a','t','a',' ','%','2','\n',0};

3 4

Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).
by Henri Verbeet Nov. 13, 2014

Nov. 13, 2014

On 12 November 2014 22:15, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) > +{ > + if (!activate && !(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES)) > + ShowWindow(swapchain->device_window, SW_MINIMIZE); > +} This patch is mostly just blocked by the tests failing, but I'd also have to wonder if the window proc should be installed in the first place if the device is created with NOWINDOWCHANGES.

2 1

Re: [5/5] windowscodecs: Implement ComponentFactory_CreateMetadataReaderFromContainer.
by Alexandre Julliard Nov. 13, 2014

Nov. 13, 2014

Vincent Povirk <madewokherd(a)gmail.com> writes: > From a3735fa76b9dc568f32561eda4617e216af82138 Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Wed, 12 Nov 2014 15:51:09 -0600 > Subject: [PATCH 5/7] windowscodecs: Implement > ComponentFactory_CreateMetadataReaderFromContainer. > > --- > dlls/windowscodecs/imgfactory.c | 101 +++++++++++++++++++++++++++++++++++- > dlls/windowscodecs/tests/metadata.c | 25 +++++---- > 2 files changed, 115 insertions(+), 11 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M windowscodecs.dll -p windowscodecs_test.exe.so metadata && touch metadata.ok metadata.c:953: Test succeeded inside todo block: unexpected count 1 make[1]: *** [metadata.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/tests: Get rid of "defined but not used" warnings on non-x86(_64) platforms
by Marvin Nov. 13, 2014

Nov. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10227 Your paranoid android. === w2000pro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:484: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:484: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00340000/00340001 exception: unhandled exception 80000004 at 00340000 exception.c:484: Test failed: 42: Wrong exception address 7751ED97/00340001 === w2008s64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:484: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:484: Test failed: 42: Wrong exception address 77CDE34F/003D0001 === w8 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:484: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 6/6] ddraw/tests: Test focus loss style changes.
by Marvin Nov. 13, 2014

Nov. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10223 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 7256F329

1 0

Re: [PATCH 5/6] ddraw/tests: Test messages on focus loss.
by Marvin Nov. 13, 2014

Nov. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10222 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 7256F329

1 0

Re: [PATCH 4/6] d3d9/tests: Test style changes on focus loss.
by Marvin Nov. 12, 2014

Nov. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10221 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:2354: Test failed: Expected device window style 0x4cf0000, got 0x14cf0000, i=2. d3d9ex.c:2358: Test failed: Expected device window extended style 0x100, got 0x108, i=2. d3d9ex.c:2358: Test failed: Expected device window extended style 0x100, got 0x108, i=3. d3d9ex.c:2385: Test failed: Expected device window style 0x14cf0000, got 0x34cf0000, i=3.

1 0

How to loop all server objects of type = socket?
by Bruno Jesus Nov. 12, 2014

Nov. 12, 2014

Hi all, I'm wondering how to do some sort of loop to be able to check all currently opened sockets. If possible knowing the process which they belong to. Any hints are welcome. Best regards, Bruno

2 2

Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).
by Stefan Dösinger Nov. 12, 2014

Nov. 12, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The attached archives contains follow-up patches that implement resolution changes and add tests for CreateAdditionalSwapchain. I expect that many more small fixes will be needed for some games, similar in nature to patch 19. There are also problems in some window managers (read: those forked from Metacity)for which I haven't filed bugs yet. Am 2014-11-12 22:15, schrieb Stefan Dösinger: > Tests for d3d8 will follow after 107631 has been committed. > > v3: Check for D3DCREATE_NOWINDOWCHANGES. > > v2: Move to wined3d. The different behavior in d3d9ex was due to a > hidden window and not a difference how d3d9ex handles focus loss. See > patch 7. > > Another patch will add an action (resize the window to match the > backbuffer size) on window activation. For this reason the swapchain > helper function is called on both activation and deactivation. > --- > dlls/wined3d/device.c | 5 +++++ > dlls/wined3d/swapchain.c | 6 ++++++ > dlls/wined3d/wined3d_private.h | 1 + > 3 files changed, 12 insertions(+) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index ee3636e..0de444b 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4983,6 +4983,11 @@ LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL > } > else if (message == WM_ACTIVATEAPP) > { > + UINT i; > + > + for (i = 0; i < device->swapchain_count; i++) > + wined3d_swapchain_activate(device->swapchains[i], wparam); > + > device->device_parent->ops->activate(device->device_parent, wparam); > } > > diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c > index 25e2107..4c0948f 100644 > --- a/dlls/wined3d/swapchain.c > +++ b/dlls/wined3d/swapchain.c > @@ -1175,3 +1175,9 @@ void swapchain_update_draw_bindings(struct wined3d_swapchain *swapchain) > wined3d_resource_update_draw_binding(&swapchain->back_buffers[i]->resource); > } > } > + > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) > +{ > + if (!activate && !(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES)) > + ShowWindow(swapchain->device_window, SW_MINIMIZE); > +} > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 0f302c4..5f90e9a 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -2701,6 +2701,7 @@ struct wined3d_swapchain > > void x11_copy_to_screen(const struct wined3d_swapchain *swapchain, const RECT *rect) DECLSPEC_HIDDEN; > > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) DECLSPEC_HIDDEN; > struct wined3d_context *swapchain_get_context(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; > void swapchain_destroy_contexts(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; > HDC swapchain_get_backup_dc(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUY883AAoJEN0/YqbEcdMwU/EP/2AAyRwHeT/rJJt1ocC3EgSq ttCBQSjH0plrsm1y+zIfFJ6+iNFfXooO1ub3qC980Ub32v5EV7p9yUxbbvfpRt1T aF7kh5WDfbPvpkGdAKmSo7C3gCzHratuPxLokDIiHAKnqhsknFmIr6dwVfaYKqmd 1eoJghdpuapyQ5TiTblU54b6tuTLyWmyZlxDNHFUSQaBCLvC7pR5eXo7nvARwYLK ahP87S7htMA+rqudvctwkPNWEa7F3dSayWyLoOp6qW3abBwfpbBAWS9KEfCztc6i zAE6LOuVy9IWewmZ5j87DNZJmKSJj/tgMHhdJ5BHxEcyJALjdg4qSsgp9olFBkpm 0DXjc0qlqdrdFiNMPG2y5i6N5vMuT9srVgDEjFAW40dnu3aEPSqHmPqKhDVrAs8s Ci3G9mV4uDK4JNI/sWJd632yWaDHGNZSdZYETof3DaR6a6K8IMktG0vqBKrapZ2K RzWz8DEonbIx5W1mKQROr5Wj+0Qs5+AkeQoWbWFEYuubtU0oisp3evRCPtjCLXjB GSwObVGohUNdwiVonYCAXtu3C80HNYwMGObcoB7p9ok3RQc60e6gOb1RdshfTcvF e4oEWOHOdqmbtj8gqLftx1qsnwPmK4gHc6ho2KfXaAZTnQdkdeUw6VG+pkNUxwJb zj94p5A5sSlJEUTmCnyx =LNWo -----END PGP SIGNATURE-----

1 0

Re: d3d8/tests: Allow passing a resolution to reset_device (v2).
by Marvin Nov. 12, 2014

Nov. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10211 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2447: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2822: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2826: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2849: Test failed: Failed to reset device, hr 0x88760868. device.c:2853: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2857: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3225: Test failed: Failed to reset device. device.c:3232: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3240: Test failed: Expected wndproc != 0x412e90.

1 0

Re: dinput: Fix device type dump
by Michael Stefaniuc Nov. 12, 2014

Nov. 12, 2014

Bruno, On 11/12/2014 02:06 AM, Bruno Jesus wrote: > Related to bug https://bugs.winehq.org/show_bug.cgi?id=35954 > > using a switch statement instead of the ?: chain of death looks IMHO nicer. You can even use a macro like the popular #define X(x) case (x): return #x to make it more concise and avoid copy and paste errors. > > diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c index > 0d61f57..2931832 100644 --- a/dlls/dinput/joystick.c +++ > b/dlls/dinput/joystick.c @@ -402,14 +402,30 @@ HRESULT WINAPI > JoystickAGenericImpl_SetProperty(LPDIRECTINPUTDEVICE8A iface, REF > > void _dump_DIDEVCAPS(const DIDEVCAPS *lpDIDevCaps) { + int type > = GET_DIDEVICE_TYPE(lpDIDevCaps->dwDevType); TRACE("dwSize: %d\n", > lpDIDevCaps->dwSize); TRACE("dwFlags: %08x\n", > lpDIDevCaps->dwFlags); TRACE("dwDevType: %08x %s\n", > lpDIDevCaps->dwDevType, - lpDIDevCaps->dwDevType == > DIDEVTYPE_DEVICE ? "DIDEVTYPE_DEVICE" : - > lpDIDevCaps->dwDevType == DIDEVTYPE_MOUSE ? "DIDEVTYPE_MOUSE" : - > lpDIDevCaps->dwDevType == DIDEVTYPE_KEYBOARD ? "DIDEVTYPE_KEYBOARD" > : - lpDIDevCaps->dwDevType == DIDEVTYPE_JOYSTICK ? > "DIDEVTYPE_JOYSTICK" : - lpDIDevCaps->dwDevType == > DIDEVTYPE_HID ? "DIDEVTYPE_HID" : "UNKNOWN"); + /* Directx > <= 7 definitions */ + type == DIDEVTYPE_DEVICE ? > "DIDEVTYPE_DEVICE" : + type == DIDEVTYPE_MOUSE ? > "DIDEVTYPE_MOUSE" : + type == DIDEVTYPE_KEYBOARD ? > "DIDEVTYPE_KEYBOARD" : + type == DIDEVTYPE_JOYSTICK ? > "DIDEVTYPE_JOYSTICK" : + type == DIDEVTYPE_HID ? > "DIDEVTYPE_HID" : + /* Directx >= 8 definitions */ + > type == DI8DEVTYPE_DEVICE ? "DI8DEVTYPE_DEVICE" : + type > == DI8DEVTYPE_MOUSE ? "DI8DEVTYPE_MOUSE" : + type == > DI8DEVTYPE_KEYBOARD ? "DI8DEVTYPE_KEYBOARD" : + type == > DI8DEVTYPE_JOYSTICK ? "DI8DEVTYPE_JOYSTICK" : + type == > DI8DEVTYPE_GAMEPAD ? "DI8DEVTYPE_GAMEPAD" : + type == > DI8DEVTYPE_DRIVING ? "DI8DEVTYPE_DRIVING" : + type == > DI8DEVTYPE_FLIGHT ? "DI8DEVTYPE_FLIGHT" : + type == > DI8DEVTYPE_1STPERSON ? "DI8DEVTYPE_1STPERSON" : + type == > DI8DEVTYPE_DEVICECTRL ? "DI8DEVTYPE_DEVICECTRL" : + type > == DI8DEVTYPE_SCREENPOINTER ? "DI8DEVTYPE_SCREENPOINTER" : + > type == DI8DEVTYPE_REMOTE ? "DI8DEVTYPE_REMOTE" : + type > == DI8DEVTYPE_SUPPLEMENTAL ? "DI8DEVTYPE_SUPPLEMENTAL" : + > "UNKNOWN"); TRACE("dwAxes: %d\n", lpDIDevCaps->dwAxes); > TRACE("dwButtons: %d\n", lpDIDevCaps->dwButtons); TRACE("dwPOVs: > %d\n", lpDIDevCaps->dwPOVs); bye michael

1 0

Re: [PATCH 5/5] d3d8/tests: Allow passing a resolution to reset_device.
by Henri Verbeet Nov. 12, 2014

Nov. 12, 2014

On 12 November 2014 00:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2830,7 +2844,8 @@ static void test_window_style(void) > focus_rect.left, focus_rect.top, focus_rect.right, focus_rect.bottom, > r.left, r.top, r.right, r.bottom); > · > - hr = reset_device(device, device_window, TRUE); > + device_desc.flags = 0;· You have a whitespace error here.

1 0

Re: [PATCH 5/5] d3d8/tests: Allow passing a resolution to reset_device.
by Marvin Nov. 12, 2014

Nov. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10199 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2447: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2822: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2826: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2849: Test failed: Failed to reset device, hr 0x88760868. device.c:2853: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2857: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3225: Test failed: Failed to reset device. device.c:3232: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3240: Test failed: Expected wndproc != 0x412e90.

1 0

Re: [PATCH 2/2] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin Nov. 11, 2014

Nov. 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10188 Your paranoid android. === w8 (32 bit script) === script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1,"

1 0

Re: [PATCH v2] cmd/tests: Add tests for 'del' (Fixes bug 35970)
by Marvin Nov. 11, 2014

Nov. 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10186 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 690 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 691 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 694 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 695 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 697 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 699 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 707 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 710 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 713 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 716 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 729 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 742 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 767 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 780 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1367 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1368 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1369 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path(a)foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1370 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1371 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1372 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1373 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1374 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1376 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1379 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1380 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1383 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1384 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1385 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar') === wvistau64 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'')

1 0