December 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 3/9] d3d8/tests: Test focus loss message filtering.
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10618 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2524: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2529: Test failed: The focus window is active. device.c:2537: Test failed: Got unexpected hr 0x88760869. device.c:2543: Test failed: Got unexpect screen size 800x600. device.c:2558: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2567: Test failed: Got unexpect screen size 800x600. device.c:2580: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2587: Test failed: Got unexpect width 640. device.c:2588: Test failed: Got unexpect height 480.

1 0

Re: ntdll: Adds support for custom serial port baudrates on Mac
by Nikolay Sivov Dec. 4, 2014

Dec. 4, 2014

On 11/29/2014 07:53 PM, Nathan Fearnley wrote: > Mac OS X supports a special function call for custom baud rates. I have > implemented this feature to allow non-standard baud rates. > Unfortunately, setting any other parameters using tcsetattr will fail, > because it does not support the higher baud rates. In order to work > around this, when setting other parameters, the baud rate is temporarily > set to 9600, then reset back to custom rate after the changes are complete. > > I can't comment on functional part, but regarding code structure this should be better separated imho. Maybe it's even better to duplicate whole functions and ifdef them all in case when __APPLE__ is not defined. Also don't use C++ 'bool', use BOOL with TRUE/FALSE defines.

2 1

Re: [PATCH] winealsa: do not destroy remapping info on IsFormatSupported
by Andrew Eikum Dec. 4, 2014

Dec. 4, 2014

Good catch. I don't like the copying, though. What about making: struct alsa_channel_map { int alsa_channels; int map[32]; }; and passing that into map_channels()? need_remapping can be indicated by a S_FALSE vs S_OK return from map_channels(), or maybe set outside the call in _Initialize(). What do you think? Andrew On Thu, Dec 04, 2014 at 02:26:05PM +0000, Mark Harmstone wrote: > At present, AudioClient_IsFormatSupported nukes the remapping information > if called after AudioClient_Initialize. > > --- > dlls/winealsa.drv/mmdevdrv.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 007f351..3d14a53 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -1598,6 +1598,8 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > WAVEFORMATEX *closest = NULL; > unsigned int max = 0, min = 0; > int err; > + int alsa_channels_orig, alsa_channel_map_orig[32]; > + BOOL need_remapping_orig; > > TRACE("(%p)->(%x, %p, %p)\n", This, mode, fmt, out); > > @@ -1692,9 +1694,18 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > closest->nChannels = min; > } > > + need_remapping_orig = This->need_remapping; > + alsa_channels_orig = This->alsa_channels; > + memcpy(alsa_channel_map_orig, This->alsa_channel_map, sizeof(This->alsa_channel_map)); > + > if(FAILED(map_channels(This, fmt))){ > hr = AUDCLNT_E_DEVICE_INVALIDATED; > WARN("map_channels failed\n"); > + > + This->need_remapping = need_remapping_orig; > + This->alsa_channels = alsa_channels_orig; > + memcpy(This->alsa_channel_map, alsa_channel_map_orig, sizeof(This->alsa_channel_map)); > + > goto exit; > } > if(This->alsa_channels > max){ > @@ -1702,6 +1713,10 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > closest->nChannels = max; > } > > + This->need_remapping = need_remapping_orig; > + This->alsa_channels = alsa_channels_orig; > + memcpy(This->alsa_channel_map, alsa_channel_map_orig, sizeof(This->alsa_channel_map)); > + > if(closest->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > ((WAVEFORMATEXTENSIBLE*)closest)->dwChannelMask = get_channel_mask(closest->nChannels); > > >

1 0

Re: [PATCH 6/8] ddraw/tests: Test WM_SYSCOMMAND handling.
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10606 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:3814: Test failed: Expected WM_ACTIVATEAPP, but did not receive it. === w8 (32 bit ddraw4) === ddraw4.c:4169: Test failed: Expected WM_ACTIVATEAPP, but did not receive it.

2 1

Re: [PATCH 8/8] wined3d: Pass WM_SYSCOMMAND(SC_RESTORE) to DefWindowProc.
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10609 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 7/8] wined3d: Filter messages generated by focus handling.
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10607 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: ole32: fixed CoWaitForMultipleHandles cause app hang
by Changhui Liu Dec. 4, 2014

Dec. 4, 2014

Hi, it's not your recent fix cause. The app is named QQ, a very popular IM client in China. When it runs, it create two process named QQ.exe and TXPlatform.exe. The TXPlatform.exe is an out-of-process COM server, The QQ.exe is the GUI process. When the user click the exit button of the QQ.exe, the QQ.exe and TXPlatform.exe both hang. The backtrace of the GUI thread of QQ.exe is like this: =>0 0xf779d42e __kernel_vsyscall+0xe() in [vdso].so (0x0033e938) 1 0xf7598e1b __libc_read+0x4a() in libpthread.so.0 (0x0033e938) 2 0x7ef8ec9a wait_select_reply+0x30(cookie=0x33e968) 3 0x7ef8fac6 server_select+0x20c(select_op=0x33ea8c, size=0x8, flags=0x2, timeout=(nil)) 4 0x7ef998e7 NtWaitForMultipleObjects+0xbc(count=0x1, handles=0x33ebe0, wait_any=1, alertable=0, timeout=(nil)) 5 0x7ecbcd31 WaitForMultipleObjectsEx+0x191 in kernel32 (0x0033ecf8) 6 0x7e13c224 CoWaitForMultipleHandles+0x4e2 in ole32 (0x0033edf8) 7 0x7e1775b8 ClientRpcChannelBuffer_SendReceive+0x598 in ole32 (0x0033eef8) ... And the backtrace of another thread of QQ.exe is like this: Backtracing for thread 0080 in process 003c (C:\Program Files\Tencent\QQ\Bin\QQ.exe): Backtrace: =>0 0xf779d42e __kernel_vsyscall+0xe() in [vdso].so (0x020ce2a8) 1 0xf7598e1b __libc_read+0x4a() in libpthread.so.0 (0x020ce2a8) 2 0x7ef8ec9a wait_select_reply+0x30(cookie=0x20ce2d8) 3 0x7ef8fac6 server_select+0x20c(select_op=0x20ce3fc, size=0x8, flags=0x2, timeout=(nil)) 4 0x7ef998e7 NtWaitForMultipleObjects+0xbc(count=0x1, handles=0x20ce550, wait_any=1, alertable=0, timeout=(nil)) 5 0x7ecbcd31 WaitForMultipleObjectsEx+0x191 6 0x7ecbcae7 WaitForSingleObject+0x45 7 0x7e179258 dispatch_rpc+0x350(msg=0x3f24668) in ole32 (0x020ce788) 8 0x7e0c10fa process_request_packet+0x3b8(conn=0x158370, hdr=0x55a12e8, msg=0x3f24668) in rpcrt4 (0x020ce8c8) 9 0x7e0c15c6 RPCRT4_process_packet+0x114(conn=0x158370, hdr=0x55a12e8, msg=0x3f24668, auth_data=0x0(nil), auth_length=0) in rpcrt4 (0x020ce928) 10 0x7e0c1759 RPCRT4_worker_thread+0x4e( in rpcrt4 (0x020ce978) ... The dispatch_rpc thread has post a 0x400 RPC message to the GUI thread and is waiting for GUI thread to process the RPC request. But the GUI thread has received WM_QUIT message, the message_loop variable set to FALSE and it only wait for event signal, so the 0x400 RPC message can't be handled. The TXPlatform.exe hang because it is waiting for dispatch_rpc thread send RPC result to a named pipe. Because the hang is too complex , I don't know how to add a test for it. ------------------ Original ------------------ From: "Sebastian Lackner"<sebastian(a)fds-team.de>; Date: Wed, Dec 3, 2014 06:42 PM To: "liuchanghui"<liuchanghui(a)linuxdeepin.com>; Cc: "wine-devel"<wine-devel(a)winehq.org>; Subject: Re: ole32: fixed CoWaitForMultipleHandles cause app hang On 03.12.2014 08:15, Changhui Liu wrote: > > > Do I understand you correctly that this is caused by my recent fix of CoWaitForMultipleHandles? Which app is it? Your change might be correct, but to ensure that this is the case please add a test for it: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ole32/tests/compobj.c… Moreover you should completely remove old code then, not just comment it out. Regards, Sebastian

1 0

Re: [PATCH 5/8] d3d8/tests: Test WM_SYSCOMMAND handling.
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10605 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 3/8] d3d8/tests: Test focus loss message filtering.
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10603 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2524: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2529: Test failed: The focus window is active. device.c:2537: Test failed: Got unexpected hr 0x88760869. device.c:2543: Test failed: Got unexpect screen size 800x600. device.c:2558: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2567: Test failed: Got unexpect screen size 800x600. device.c:2580: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2587: Test failed: Got unexpect width 640. device.c:2588: Test failed: Got unexpect height 480.

1 0

Re: urlmon/tests: Remove unused strings (Clang)
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10595 Your paranoid android. === w2008s64 (32 bit url) === url.c:1478: Test failed: progress 2: hres = 1, expected 0 url.c:1668: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1478: Test failed: progress 1: hres = 1, expected 0 url.c:1680: Test failed: unexpected call OnProgress_CONNECTING url.c:1478: Test failed: progress 2: hres = 1, expected 0 url.c:1701: Test failed: unexpected call OnProgress_SENDINGREQUEST

1 0

Re: user32/tests: Remove unused variables (Clang)
by Marvin Dec. 4, 2014

Dec. 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10592 Your paranoid android. === w7u (32 bit msg) === msg.c:12105: Test failed: unexpected hwnd 0012013C msg.c:12127: Test failed: bad time 310a2/310b2

1 0

Re: user32/tests: Remove unused variables (Clang)
by André Hentschel Dec. 3, 2014

Dec. 3, 2014

Am 03.12.2014 um 23:53 schrieb André Hentschel: > --- > dlls/user32/tests/msg.c | 112 ------------------------------------------------ > 1 file changed, 112 deletions(-) Just want to note, that this code was added in 2003 and most likely has never been used, just in case someone wonders why i dare to remove so much code ;)

1 0

Re: [PATCH 08/15] msvcr120: Remove stray parameter specs for stub functions.
by Alexandre Julliard Dec. 3, 2014

Dec. 3, 2014

Martin Storsjo <martin(a)martin.st> writes: > This avoids adding stray functions when using make_specfiles. There shouldn't be any reason to do that. The parameters are here on purpose. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.
by Qian Hong Dec. 3, 2014

Dec. 3, 2014

Hi Indrek, On Mon, Dec 1, 2014 at 3:46 PM, Indrek Altpere <efbiaiinzinz(a)hotmail.com> wrote: > Hello > > I even saw your patch in my inbox but it does not appear at > https://source.winehq.org/patches/data/107949 for some reason, so I don't > remember what lines you changed exactly so apologies if I seem to be > re-stating things tou fixed already. > > > When checking > http://source.winehq.org/git/wine.git/blob_plain/HEAD:/loader/wine.inf.in > there is also tons of other discrepancies (if you didn't already). > > > Parameters are escaped with ""%1"" but not command: > HKCR,Msi.Package\shell\Open\command,,2,"%11%\msiexec.exe /i ""%1""" > HKCR,Msi.Package\shell\Repair\command,,2,"%11%\msiexec.exe /f ""%1""" > HKCR,Msi.Package\shell\Uninstall\command,,2,"%11%\msiexec.exe /x ""%1""" > > > Command itself is escaped: > HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" > > > Neither command nor parameter is escaped: > HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe > setupapi,InstallHinfSection DefaultInstall 132 %1" > > HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" > > > If winebrowser needs escaping because %11 contains a space then all other > places also use %11 need that escaping. And if msiexec need to escape %1 > then all other places need it too don't they? > Thanks a lot for your comment, I'm investigating a bit more... Will update later :) -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 01/15] msvcr120: Implement the _vacopy function.
by Martin Storsjö Dec. 3, 2014

Dec. 3, 2014

Hi, On Mon, 1 Dec 2014, Martin Storsjo wrote: > --- > dlls/msvcr120/msvcr120.spec | 2 +- > dlls/msvcrt/misc.c | 8 ++++++++ > include/msvcrt/crtdefs.h | 2 ++ > 3 files changed, 11 insertions(+), 1 deletion(-) I saw on http://source.winehq.org/patches/ that this one was rejected - any comment on why and what needs to be fixed? // Martin

2 1

Re: [PATCH 02/15] msvcr120: Implement more C99 math functions.
by Alexandre Julliard Dec. 3, 2014

Dec. 3, 2014

Martin Storsjo <martin(a)martin.st> writes: > Implement the *rint, trunc, *round, log2, exp2 and cbrt > function families. > > These are directly passed on to the corresponding host > libc functions. You can't do that, there's no guarantee that the host has these functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ole32: fixed CoWaitForMultipleHandles cause app hang
by Sebastian Lackner Dec. 3, 2014

Dec. 3, 2014

On 03.12.2014 08:15, Changhui Liu wrote: > > > Do I understand you correctly that this is caused by my recent fix of CoWaitForMultipleHandles? Which app is it? Your change might be correct, but to ensure that this is the case please add a test for it: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ole32/tests/compobj.c… Moreover you should completely remove old code then, not just comment it out. Regards, Sebastian

1 0

Re: msi: Properly handle service control events in Start/StopService.
by Marvin Dec. 2, 2014

Dec. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10574 Your paranoid android. === wxppro (32 bit action) === The test timed out === w7u (32 bit action) === The test timed out === w8 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

1 0

Re: ole32/tests: Remove unused variable (Clang)
by Marvin Dec. 2, 2014

Dec. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10569 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000421BDA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000421BDA

1 0

Re: msi/tests: Remove unused variables (Clang)
by Marvin Dec. 2, 2014

Dec. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10567 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out === w8 (32 bit install) === The test timed out

1 0

Re: mshtml/tests: Remove unused variable (Clang)
by Marvin Dec. 2, 2014

Dec. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10565 Your paranoid android. === w2000pro (32 bit events) === The test timed out

1 0

Re: kernel32/tests: Remove unused strings (Clang)
by Marvin Dec. 2, 2014

Dec. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10564 Your paranoid android. === wvistau64 (32 bit file) === file.c:365: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:365: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [PATCH 2/3] d3d8: Refuse to reset a lost device (v2).
by Marvin Dec. 2, 2014

Dec. 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10563 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 1/5] d3d9: Refuse to reset a lost device.
by Henri Verbeet Dec. 1, 2014

Dec. 1, 2014

On 28 November 2014 at 11:16, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!device->d3d_parent->extended && InterlockedCompareExchange(&device->device_state, > + D3D9_DEVICE_STATE_LOST, D3D9_DEVICE_STATE_LOST) == D3D9_DEVICE_STATE_LOST) Do you need the InterlockedCompareExchange()?

2 3

Re: mshtml: Added support for flag 2 in getAttribute.
by Marvin Dec. 1, 2014

Dec. 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10556 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.
by Qian Hong Dec. 1, 2014

Dec. 1, 2014

Hi, `git grep command | grep HKCR | grep -v '"""'` exposed more places which seems missing quotes in command key, anyone know if we should update every place? Any advice is great appreciated! loader/wine.inf.in:HKCR,chm.file\shell\open\command,,2,"%10%\hh.exe %1" loader/wine.inf.in:HKCR,cplfile\shell\cplopen\command,,2,"rundll32.exe shell32.dll,Control_RunDLL ""%1"",%*" loader/wine.inf.in:HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" loader/wine.inf.in:HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe setupapi,InstallHinfSection DefaultInstall 132 %1" loader/wine.inf.in:HKCR,inifile\shell\open\command,,2,"%11%\notepad.exe %1" loader/wine.inf.in:HKCR,inifile\shell\print\command,,2,"%11%\notepad.exe /p %1" loader/wine.inf.in:HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" loader/wine.inf.in:HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" loader/wine.inf.in:HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" loader/wine.inf.in:HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" loader/wine.inf.in:HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" loader/wine.inf.in:HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" On Mon, Dec 1, 2014 at 1:38 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hi Piotr, > > This is a follow up of the below commit: > > commit 54833c9b7cf5f8f5e37b43038e1fa4c1c369deb0 > Author: Piotr Caban <piotr(a)codeweavers.com> > Date: Wed May 4 13:20:41 2011 +0200 > > wine.inf: Add quotes to webbrowser command keys. > > To make sure i'm not breaking anything which is intended, would you mind > have a look? > > Thanks! > > --- > loader/wine.inf.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0