February 2014 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Wine 64 bit
by Kevin Davies June 5, 2015

June 5, 2015

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

13 31

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard April 23, 2015

April 23, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Fixing conflicts between WineD3D and WGL
by Ken Thomases April 28, 2014

April 28, 2014

Hi, This email brings together several threads of conversation that have been spread across different bug reports. Sorry for the length. The problem: WineD3D is based on WGL (a.k.a. opengl32). As a consequence, it conflicts with application use of WGL in a number of ways. It's also limited by WGL, which doesn't allow for all of the behaviors of DirectDraw and Direct3D. https://bugs.winehq.org/show_bug.cgi?id=28869 WineD3D needs to make its own GL context current temporarily and then restore the previous GL context, but WGL requires a DC to restore it and the DC may no longer be valid. https://bugs.winehq.org/show_bug.cgi?id=29301 WineD3D changes the window style of the device window when it should not. It needs to do that in order to render to the full screen where WGL only allows full-featured rendering to a window. https://bugs.winehq.org/show_bug.cgi?id=2082 Again, WineD3D is rendering to a window when it wants to render full-screen. In this case, the affected apps create an owned window that sits in front of the device window, obscuring it. http://bugs.winehq.org/show_bug.cgi?id=29934 WineD3D sets a pixel format on the application window. This conflicts with a later attempt by the app to set a different pixel format on the window via WGL. I think the solution to these problems is for WineD3D to have an alternative path to set up its GL context. Henri and I have been discussing using Wine-specific extensions to WGL to do this. There's already the extension WGL_WINE_pixel_format_passthrough which provides the wglSetPixelFormatWINE() function which is just like GDI's SetPixelFormat() and WGL's wglSetPixelFormat() except it allows for changing the pixel format after it's been set once. WineD3D needs to change it even though WGL doesn't allow that. In some of the bug reports listed above, I've suggested adding new extensions or modifying WGL_WINE_pixel_format_passthrough. We probably need a more comprehensive approach. WGL exposes various pieces of state to the application. Ideally, WineD3D would not alter any of that state since such alterations are visible to the app and Direct3D doesn't do that on Windows. I'm not sure that's achievable but we should at least minimize such visible state changes to the extent we can. WGL state: * The DC pixel format. For window DCs (which I believe are the only ones of real interest), this is actually a property of the window, not the DC. Changed by SetPixelFormat(), wglSetPixelFormat(); exposed by GetPixelFormat(), wglGetPixelFormat(). * The current GL context for the thread. Changed by wglMakeCurrent(), wglMakeContextCurrentARB(); exposed by wglGetCurrentContext(). * The DC for the current GL context. Changed by wglMakeCurrent(), wglMakeContextCurrentARB(); exposed by wglGetCurrentDC(), wglGetCurrentReadDCARB(). The most important things to achieve are a) to not "consume" the only opportunity the app has to set the window's pixel format, and b) to restore the app's current GL context (and implicitly its DC) when returning control to it. I don't think it's necessary to avoid WineD3D ever changing WGL's notion of the current context. Certainly, while a WineD3D GL context is current, GL functions like glClear() will operate on WineD3D's context. If the app thinks its context is current and calls GL functions, its context better really be current. So, WineD3D really needs to restore the app's context before returning control (and it generally does, I think). If it's going to do that, then wglGetCurrentContext() will take care of itself. Same for wglGetCurrentDC(). Here's my proposal: Extension WGL_WINE_surface: HANDLE wglCreateSurfaceWINE(HDC hdc, int pixel_format); // if hdc is GetDC(<some normal window>), a window surface is created // if hdc is GetDC(0), GetDC(GetDesktopWindow()), or CreateDC("display", …), a full-screen surface is created. // once the surface is created, it no longer refers to hdc void wglDestroySurfaceWINE(HANDLE surface); HDC wglGetSurfaceDCWINE(HANDLE surface); // Returns a DC created for the surface. This is not the DC passed in to wglCreateSurfaceWINE(). void wglReleaseSurfaceDCWINE(HANDLE surface, HDC hdc); This is somewhat modeled on WGL_ARB_pbuffer. <http://www.opengl.org/registry/specs/ARB/wgl_pbuffer.txt> A surface represents a "place" where GL can render, a potential target for a context. It can correspond to a Win32 window or it can be a full-screen surface. A full-screen surface will likely be a platform window (X11 or Mac) managed by the graphics driver but won't be a Win32 window. It should not interfere with mouse events or focus. A surface has a pixel format, similar to a window. Even if the surface was created from a window DC, its pixel format is independent of the window's. Since a surface is created with a pixel format, it shouldn't be necessary to set one with SetPixelFormat() on a surface DC. If it helps keep WineD3D's code simpler, we could allow it. I'm not sure if it will be necessary to support changing the pixel format after it's been set, using wglSetPixelFormatWINE(), or if the surface should just be destroyed and recreated as necessary. Doing the latter may eventually allow the removal of wglSetPixelFormatWINE(). The lifetime of a surface controls whatever resources the graphics driver has to manage for it. For a normal window, this may include a drawable. For a full-screen surface, this would include any full-screen platform window it might have created. WineD3D would obtain a DC from a surface using wglGetSurfaceDCWINE() just as it now obtains one for a window using GetDC(). There can be multiple DCs for a given surface. In particular, a DC can only be used on a single thread, so multiple threads would each have to get their own DC. The different lifetimes of surfaces vs. surface DCs is why this proposal differs from my approach in bug 2082, where I proposed an extension which just added full-screen DCs without a corresponding full-screen surface object. Destroying a surface while it still has extant surface DCs results in undefined behavior. Once WineD3D has a surface DC, it should be able to work with it as it currently does with window DCs. wglMakeCurrent() with a surface DC will associate the context with the surface drawable. For a surface created from a window, this would work as it does now in the graphics drivers with the exception of how the drawable is looked up from the DC. For a full-screen surface, this would target whatever full-screen drawable the graphics driver provides (possibly a platform window). There's a wrinkle having to do with the pixel format. User32 and the wineserver use the fact that a window has a pixel format to compute the "surface region" for the top-level window. This is a different "surface" than the concept central to this proposal. This "surface" is used for client-side GDI rendering using the DIB engine. Maintaining a surface region is necessary to prevent the contents of the window surface buffer from being blitted on top of any 3D rendering done to the window. To keep that functioning, the graphics drivers will still have to inform user32 that 3D rendering is being done to the window. It can do that using the existing mechanism, but that's not currently reversible because it's tied to the pixel format and that's a permanent property of a window. We'd like it to be reversible, since WineD3D can stop targeting a window. I'm thinking of using a count in user32. Extension WGL_WINE_make_current: BOOL wglMakeContextCurrentWINE(HGLRC hglrc); The standard WGL function wglMakeCurrent() combines two operations. It sets the a GL context's drawable to the provided DC and it makes the GL context current for the thread. This new function, wglMakeContextCurrentWINE(), would only do the latter. It would make a GL context current for the thread without changing which DC it's associated with. Both the X11 and Mac drivers already maintain the necessary state to do that. They don't need to have the DC passed in again. (If a GL context is associated with separate draw and read DCs using wglMakeContextCurrentARB(), then this function will leave it associated with both DCs.) This allows WineD3D to faithfully restore the app's previously-current WGL context. This addresses bug 28869. I considered some other designs but I don't think they work well. I looked for a way to do without special DCs. We could directly specify a pixel format when creating a context rather than getting it from the window or surface via the DC. We could make a context current directly on a surface rather than a surface DC. Unfortunately, too much of WGL depends on having a DC. For example, ChoosePixelFormat() and wglSwapBuffers(). What do folks think? Any feedback would be appreciated. -Ken

7 21

Advice fixing #13683 (DirectX mouse overlay?)
by Christopher Thielen April 26, 2014

April 26, 2014

Hi wine-devel, I'm attempting to fix http://bugs.winehq.org/show_bug.cgi?id=13683 but need some advice as to where to start. I'm not too familiar with hacking on Wine. I'd like to test Stefan Dösinger's theory outlined in the comments for #13683 that the missing second mouse cursor is perhaps being implemented using DirectX overlays and that Wine's lack of overlay compatibility flags is to blame. Would the proper action to test this theory be to fake a certain set of flags in dlls/d3d8/device.c's static HRESULT WINAPI d3d8_device_GetDeviceCaps(IDirect3DDevice8 *iface, D3DCAPS8 *caps) ? If that proves to be the issue, I'd then need to write proper code to report the correct set of flags presumably. Is there any easy way to see which DLLs Wine loads when running an application? I appreciate any advice, I'm new but want to help, Christopher Thielen

4 25

Cross-regressions between wine and mesa: how to handle them?
by Ruslan Kabatsayev March 17, 2014

March 17, 2014

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

4 13

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries (resend)
by Marvin March 3, 2014

March 3, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5094 Your paranoid android. === w2000pro (32 bit package) === package.c:3945: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3951: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3957: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3969: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3975: Test failed: Expected "C:\\", got "C:\" package.c:3981: Test failed: Expected "C:\\", got "C:\" package.c:3997: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4008: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4467: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4559: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4570: Test failed: Expected "C:\\", got "C:\" package.c:4581: Test failed: Expected "C:\\", got "C:\" package.c:4631: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4642: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4657: Test failed: Expected "C:\\", got "C:\" package.c:4662: Test failed: Expected "", got "C:\" package.c:4678: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4937: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4948: Test failed: Expected "C:\\", got "C:\" package.c:4954: Test failed: Expected "C:\\", got "C:\" package.c:4975: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4986: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5226: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5232: Test failed: Expected "C:\\", got "C:\" package.c:5249: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5260: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5268: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5612: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6244: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6268: Test failed: Expected C:\\ or empty string, got C:\ package.c:6312: Test failed: Expected C:\\ or empty string, got C:\ package.c:6321: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6551: Test failed: Expected "C:\\", got "C:\" package.c:6552: Test failed: Expected 4, got 3 package.c:6559: Test failed: Expected "C:\\", got "C:\" package.c:6560: Test failed: Expected 4, got 3 package.c:6576: Test failed: Expected "C:\\", got "C:\" package.c:6577: Test failed: Expected 4, got 3 package.c:6583: Test failed: Expected "C:\\", got "C:\" package.c:6584: Test failed: Expected 4, got 3 package.c:6591: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6592: Test failed: Expected 14, got 13 package.c:6599: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6600: Test failed: Expected 19, got 18 package.c:6610: Test failed: Expected "C:\\", got "C:\" package.c:6611: Test failed: Expected 4, got 3 package.c:6618: Test failed: Expected "C:\\", got "C:\" package.c:6619: Test failed: Expected 4, got 3 package.c:6635: Test failed: Expected "C:\\", got "C:\" package.c:6636: Test failed: Expected 4, got 3 package.c:6642: Test failed: Expected "C:\\", got "C:\" package.c:6643: Test failed: Expected 4, got 3 package.c:6650: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6651: Test failed: Expected 14, got 13 package.c:6658: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6659: Test failed: Expected 19, got 18 package.c:6669: Test failed: Expected "C:\\", got "C:\" package.c:6670: Test failed: Expected 4, got 3 package.c:6677: Test failed: Expected "C:\\", got "C:\" package.c:6678: Test failed: Expected 4, got 3 package.c:6694: Test failed: Expected "C:\\", got "C:\" package.c:6695: Test failed: Expected 4, got 3 package.c:6701: Test failed: Expected "C:\\", got "C:\" package.c:6702: Test failed: Expected 4, got 3 package.c:6709: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6710: Test failed: Expected 14, got 13 package.c:6717: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6718: Test failed: Expected 19, got 18 package.c:6728: Test failed: Expected "C:\\", got "C:\" package.c:6729: Test failed: Expected 4, got 3 package.c:6736: Test failed: Expected "C:\\", got "C:\" package.c:6737: Test failed: Expected 4, got 3 package.c:6753: Test failed: Expected "C:\\", got "C:\" package.c:6754: Test failed: Expected 4, got 3 package.c:6760: Test failed: Expected "C:\\", got "C:\" package.c:6761: Test failed: Expected 4, got 3 package.c:6768: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6769: Test failed: Expected 14, got 13 package.c:6776: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6777: Test failed: Expected 19, got 18 package.c:6792: Test failed: Expected 4, got 3 package.c:6809: Test failed: Expected 4, got 3 package.c:6815: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6818: Test failed: Expected 4, got 3 package.c:6825: Test failed: Expected "C:\\", got "C:\" package.c:6826: Test failed: Expected 4, got 3 package.c:6837: Test failed: Expected "C:\\", got "C:\" package.c:6838: Test failed: Expected 4, got 3 package.c:6933: Test failed: Expected "C:\\", got "C:\" package.c:6934: Test failed: Expected 4, got 3 package.c:6941: Test failed: Expected "C:\\", got "C:\" package.c:6942: Test failed: Expected 4, got 3 package.c:6951: Test failed: Expected "C:\\", got "C:\" package.c:6952: Test failed: Expected 4, got 3 package.c:6960: Test failed: Expected "C:\\", got "C:\" package.c:6961: Test failed: Expected 4, got 3 package.c:6967: Test failed: Expected "C:\\", got "C:\" package.c:6968: Test failed: Expected 4, got 3 package.c:6975: Test failed: Expected "C:\\", got "C:\" package.c:6976: Test failed: Expected 4, got 3 package.c:6983: Test failed: Expected "C:\\", got "C:\" package.c:6984: Test failed: Expected 4, got 3 package.c:6994: Test failed: Expected "C:\\", got "C:\" package.c:6995: Test failed: Expected 4, got 3 package.c:7002: Test failed: Expected "C:\\", got "C:\" package.c:7003: Test failed: Expected 4, got 3 package.c:7012: Test failed: Expected "C:\\", got "C:\" package.c:7013: Test failed: Expected 4, got 3 package.c:7021: Test failed: Expected "C:\\", got "C:\" package.c:7022: Test failed: Expected 4, got 3 package.c:7028: Test failed: Expected "C:\\", got "C:\" package.c:7029: Test failed: Expected 4, got 3 package.c:7036: Test failed: Expected "C:\\", got "C:\" package.c:7037: Test failed: Expected 4, got 3 package.c:7044: Test failed: Expected "C:\\", got "C:\" package.c:7045: Test failed: Expected 4, got 3 package.c:7055: Test failed: Expected "C:\\", got "C:\" package.c:7056: Test failed: Expected 4, got 3 package.c:7063: Test failed: Expected "C:\\", got "C:\" package.c:7064: Test failed: Expected 4, got 3 package.c:7073: Test failed: Expected "C:\\", got "C:\" package.c:7074: Test failed: Expected 4, got 3 package.c:7082: Test failed: Expected "C:\\", got "C:\" package.c:7083: Test failed: Expected 4, got 3 package.c:7089: Test failed: Expected "C:\\", got "C:\" package.c:7090: Test failed: Expected 4, got 3 package.c:7097: Test failed: Expected "C:\\", got "C:\" package.c:7098: Test failed: Expected 4, got 3 package.c:7105: Test failed: Expected "C:\\", got "C:\" package.c:7106: Test failed: Expected 4, got 3 package.c:7116: Test failed: Expected "C:\\", got "C:\" package.c:7117: Test failed: Expected 4, got 3 package.c:7124: Test failed: Expected "C:\\", got "C:\" package.c:7125: Test failed: Expected 4, got 3 package.c:7134: Test failed: Expected "C:\\", got "C:\" package.c:7135: Test failed: Expected 4, got 3 package.c:7143: Test failed: Expected "C:\\", got "C:\" package.c:7144: Test failed: Expected 4, got 3 package.c:7150: Test failed: Expected "C:\\", got "C:\" package.c:7151: Test failed: Expected 4, got 3 package.c:7158: Test failed: Expected "C:\\", got "C:\" package.c:7159: Test failed: Expected 4, got 3 package.c:7166: Test failed: Expected "C:\\", got "C:\" package.c:7167: Test failed: Expected 4, got 3 package.c:7264: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7265: Test failed: Expected 9, got 8 package.c:7274: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7275: Test failed: Expected 9, got 8 package.c:7284: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7285: Test failed: Expected 9, got 8 package.c:7296: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7297: Test failed: Expected 8, got 7 package.c:7308: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7309: Test failed: Expected 9, got 8 package.c:7320: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7321: Test failed: Expected 8, got 7 package.c:7332: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7333: Test failed: Expected 10, got 9 package.c:7344: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7345: Test failed: Expected 8, got 7 package.c:7356: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7357: Test failed: Expected 11, got 10 package.c:7408: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7409: Test failed: Expected 10, got 9 package.c:7418: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7419: Test failed: Expected 10, got 9 package.c:7428: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7429: Test failed: Expected 10, got 9 package.c:7440: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7441: Test failed: Expected 8, got 7 package.c:7452: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7453: Test failed: Expected 10, got 9 package.c:7464: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7465: Test failed: Expected 9, got 8 package.c:7476: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7477: Test failed: Expected 10, got 9 package.c:7488: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7489: Test failed: Expected 9, got 8 package.c:7500: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7501: Test failed: Expected 11, got 10 package.c:7637: Test failed: Expected "C:\\", got "C:\" package.c:7638: Test failed: Expected 4, got 3 package.c:7649: Test failed: Expected "C:\\", got "C:\" package.c:7650: Test failed: Expected 4, got 3 package.c:7657: Test failed: Expected "C:\\", got "C:\" package.c:7658: Test failed: Expected 4, got 3 package.c:7755: Test failed: Expected "C:\\", got "C:\" package.c:7756: Test failed: Expected 4, got 3 package.c:7763: Test failed: Expected "C:\\", got "C:\" package.c:7764: Test failed: Expected 4, got 3 package.c:7771: Test failed: Expected "C:\\", got "C:\" package.c:7772: Test failed: Expected 4, got 3 package.c:7791: Test failed: Expected "C:\\", got "C:\" package.c:7792: Test failed: Expected 4, got 3 package.c:7799: Test failed: Expected "C:\\", got "C:\" package.c:7800: Test failed: Expected 4, got 3 package.c:7819: Test failed: Expected "C:\\", got "C:\" package.c:7820: Test failed: Expected 4, got 3 package.c:7827: Test failed: Expected "C:\\", got "C:\" package.c:7828: Test failed: Expected 4, got 3 package.c:7847: Test failed: Expected "C:\\", got "C:\" package.c:7848: Test failed: Expected 4, got 3 package.c:7855: Test failed: Expected "C:\\", got "C:\" package.c:7856: Test failed: Expected 4, got 3

2 2

Conferences wiki page
by Rosanne DiMesio March 1, 2014

March 1, 2014

FYI, I've created a wiki page to collect information on conferences that might be good venues for Wine outreach efforts, http://wiki.winehq.org/Conferences2014. Please add any conferences/meetings you think might be suitable, even if the deadline for this year has passed (it will serve as a reminder to check earlier for next year). -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Fwd: [The Wine Project] Your organization application has been accepted.
by Austin English Feb. 28, 2014

Feb. 28, 2014

We're in for GSoC 2014! Please update http://wiki.winehq.org/SummerOfCode#head-008ecfc639831c4db4d11a0e8983ef4eb0… any ideas you have for potential students. Let me or Andre know if you have any questions. ---------- Forwarded message ---------- From: <no-reply(a)google-melange.appspotmail.com> Date: Mon, Feb 24, 2014 at 10:40 AM Subject: [The Wine Project] Your organization application has been accepted. To: austinenglish(a)gmail.com Congratulations! Your Organization Application for The Wine Project to Google Summer of Code 2014 has been accepted. Your organization's information will be auto-populated from your Organization profile onto our Participating Organizations page. Please click http://www.google-melange.com/gsoc/org/profile/edit/google/gsoc2014/wine if you want to modify your Organization profile. We recommend you take time to review your profile carefully and add relevant information and links for the students where applicable. If you have questions about items on this profile we would recommend you read over the Melange User's Guide's section titled "Our organization was accepted! How do I create my organization homepage?<http://en.flossmanuals.net/melange/org-application-period/> " Please be aware the your organization's information is now available to students, so you should expect to get contact from potential applicants very soon. If you have any questions, please email Carol Smith directly at carols(a)google.com, but generally, you are off to the races. Student applications formally open on 10 March at 19:00 UTC. Best regards, -- -Austin

1 0

Re: itss: Use BOOL type where appropriate
by Nikolay Sivov Feb. 28, 2014

Feb. 28, 2014

On 2/28/2014 20:17, Frédéric Delanoy wrote: > --- > dlls/itss/lzx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dlls/itss/lzx.c b/dlls/itss/lzx.c > index 01a9492..9e343da 100644 > --- a/dlls/itss/lzx.c > +++ b/dlls/itss/lzx.c > @@ -85,14 +85,14 @@ struct LZXstate > ULONG window_posn; /* current offset within the window */ > ULONG R0, R1, R2; /* for the LRU offset system */ > UWORD main_elements; /* number of main tree elements */ > - int header_read; /* have we started decoding at all yet? */ > + BOOL header_read; /* have we started decoding at all yet? */ > UWORD block_type; /* type of this block */ > ULONG block_length; /* uncompressed length of this block */ > ULONG block_remaining; /* uncompressed bytes still left to decode */ > ULONG frames_read; /* the number of CFDATA blocks processed */ > LONG intel_filesize; /* magic header value used for transform */ > LONG intel_curpos; /* current offset in transform space */ > - int intel_started; /* have we seen any translatable data yet? */ > + BOOL intel_started; /* have we seen any translatable data yet? */ > This is a part of another project, I don't think we need it to differ more than it does already.

1 0

Re: TestBot job 5278 results: [PATCH] scrrun: Implement CreateTextFile() method (try2)
by Nikolay Sivov Feb. 28, 2014

Feb. 28, 2014

On 2/28/2014 18:42, Marvin wrote: > === w2000pro (32 bit filesystem) === > > scrrun: > filesystem.c:140: Test failed: got 0x800a0046 I don't think it's related, this test already supposed to fail, with a different error code however.

1 0

Re: [PATCH] scrrun: Implement CreateTextFile() method (try2)
by Marvin Feb. 28, 2014

Feb. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5278 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

1 0

Re: [PATCH] scrrun: Implement CreateTextFile() method
by Dmitry Timoshkov Feb. 28, 2014

Feb. 28, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + /* map access mode */ > + if (mode & (ForWriting | ForAppending)) > + access = GENERIC_WRITE; > + if (mode & ForReading) > + access |= GENERIC_READ; Probably append mode needs additional handling. -- Dmitry.

1 0

Re: [PATCH] scrrun: Implement CreateTextFile() method
by Marvin Feb. 28, 2014

Feb. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5276 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

1 0

Re: [PATCH 4/5] ddraw/tests: Don't trust what EnumDevices() tells us about the supported Z buffer formats.
by Marvin Feb. 28, 2014

Feb. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5274 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:746: Test failed: Got unexpected color 0x00000000. ddraw2.c:3199: Test failed: Got unexpected color 0x000000ff. Failure running script in VM: network read timed out === w8 (32 bit ddraw1) === ddraw1.c:783: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4103: Test failed: Got unexpected refcount 3. ddraw1.c:4122: Test failed: Got unexpected refcount 3. ddraw1.c:4129: Test failed: Got unexpected hr 0. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 2. ddraw1.c:4140: Test failed: Got unexpected hr 0. ddraw1.c:4143: Test failed: Got unexpected refcount 2. ddraw1.c:4145: Test failed: Got unexpected refcount 1.

1 0

Re: [PATCH 3/5] ddraw/tests: Properly create offscreen plain surfaces.
by Marvin Feb. 28, 2014

Feb. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5273 Your paranoid android. === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5817: Test failed: Got unexpected refcount 3. ddraw4.c:5836: Test failed: Got unexpected refcount 3. ddraw4.c:5843: Test failed: Got unexpected hr 0. ddraw4.c:5846: Test failed: Got unexpected refcount 3. ddraw4.c:5848: Test failed: Got unexpected refcount 2. ddraw4.c:5854: Test failed: Got unexpected hr 0. ddraw4.c:5857: Test failed: Got unexpected refcount 2. ddraw4.c:5859: Test failed: Got unexpected refcount 1. ddraw4.c:5861: Test failed: Got unexpected refcount 6. ddraw4.c:5985: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:6024: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6027: Test failed: Got unexpected hr 0. ddraw4.c:6029: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6032: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6035: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6037: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6040: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6042: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6045: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6047: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [PATCH 2/5] ddraw/tests: Try 24 bpp display modes if 32 bpp modes are unavailable.
by Marvin Feb. 28, 2014

Feb. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5272 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00425FE5 === w8 (32 bit ddraw2) === ddraw2.c:5217: Test failed: Got unexpected refcount 3. ddraw2.c:5236: Test failed: Got unexpected refcount 3. ddraw2.c:5243: Test failed: Got unexpected hr 0. ddraw2.c:5246: Test failed: Got unexpected refcount 3. ddraw2.c:5248: Test failed: Got unexpected refcount 2. ddraw2.c:5254: Test failed: Got unexpected hr 0. ddraw2.c:5257: Test failed: Got unexpected refcount 2. ddraw2.c:5259: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:4120: Test failed: Got unexpected refcount 3. ddraw1.c:4139: Test failed: Got unexpected refcount 3. ddraw1.c:4146: Test failed: Got unexpected hr 0. ddraw1.c:4149: Test failed: Got unexpected refcount 3. ddraw1.c:4151: Test failed: Got unexpected refcount 2. ddraw1.c:4157: Test failed: Got unexpected hr 0. ddraw1.c:4160: Test failed: Got unexpected refcount 2. ddraw1.c:4162: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045AFE8 === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 0043FF75 === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057.

1 0

Re: msi: Use BOOL type where appropriate
by Hans Leidekker Feb. 28, 2014

Feb. 28, 2014

On Fri, 2014-02-28 at 10:35 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h > index 75d1920..62d69b2 100644 > --- a/dlls/msi/msipriv.h > +++ b/dlls/msi/msipriv.h > @@ -409,13 +409,13 @@ typedef struct tagMSIPACKAGE > struct list sourcelist_info; > struct list sourcelist_media; > > - unsigned char scheduled_action_running : 1; > - unsigned char commit_action_running : 1; > - unsigned char rollback_action_running : 1; > - unsigned char need_reboot_at_end : 1; > - unsigned char need_reboot_now : 1; > - unsigned char need_rollback : 1; > - unsigned char full_reinstall : 1; > + BOOL scheduled_action_running; > + BOOL commit_action_running; > + BOOL rollback_action_running; > + BOOL need_reboot_at_end; > + BOOL need_reboot_now; > + BOOL need_rollback; > + BOOL full_reinstall; > } MSIPACKAGE; > > typedef struct tagMSIPREVIEW > @@ -486,10 +486,10 @@ typedef struct tagMSICOMPONENT > MSIASSEMBLY *assembly; > int num_clients; > > - unsigned int anyAbsent:1; > - unsigned int hasAdvertisedFeature:1; > - unsigned int hasLocalFeature:1; > - unsigned int hasSourceFeature:1; > + BOOL anyAbsent; > + BOOL hasAdvertisedFeature; > + BOOL hasLocalFeature; > + BOOL hasSourceFeature; > } MSICOMPONENT; > > typedef struct tagComponentList I don't think it's worth the extra memory use here.

1 0

Swat4 -too dark shadows maybe solved
by Jarkko Korpi Feb. 28, 2014

Feb. 28, 2014

I downloaded swat4 demo. It has too dark swats and shadows. http://bugs.winehq.org/show_bug.cgi?id=8848 (which is reported here too also with demo) I think I figured out what is causing it. I noticed that setting windows registerykey useGLSL=disabled made swats look like normal (see my sent pics). I debuged the game and there wasn't many different lines. fixme:exec:SHELL_execute flags ignored: 0x00000100 fixme:process:GetProcessWorkingSetSize (0xffffffff,0x33eac4,0x33eac0): stub fixme:win:EnumDisplayDevicesW ((null),0,0x33ed48,0x00000000), stub! fixme:wbemprox:client_security_SetBlanket 0x7cf14558, 0x1396f0, 10, 0, (null), 3, 3, (nil), 0x00000000 fixme:wbemprox:client_security_Release 0x7cf14558 fixme:wbemprox:wbem_services_CreateInstanceEnum unsupported flags 0x00000030 fixme:win:EnumDisplayDevicesW ((null),0,0x33ec68,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x33ef58,0x00000000), stub! fixme:system:SystemParametersInfoW Unimplemented action: 59 (SPI_SETSTICKYKEYS) fixme:win:EnumDisplayDevicesW ((null),0,0x33ca58,0x00000000), stub! fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. etc etc But I think wine is missing the next feature, what's causing the black shadows http://msdn.microsoft.com/en-us/library/windows/desktop/bb173461%28v=vs.85%… "You can include the D3DSGR_CALIBRATE value for the first parameter of SetGammaRamp", well its definitely trying to set gamma, but it's IGNORED. Here are the pics, before and setting that useGLSL registery key http://postimg.org/image/kxct6863j/ http://postimg.org/image/n48bm1dk9/ But setting that registery key dosn't help on shadows which are too dark. According to my knowledge reading some part of that Microsoft explanation making this setgammaramp function shoulnt be too hard, it just adjust the amount of RGB.

1 0

Failing dpnet tests
by Alistair Leslie-Hughes Feb. 28, 2014

Feb. 28, 2014

Hi, On Windows 8, the dpnet are failing with a timeout. After manually running the tests, I found a possible cause. The dpnet.dll cause the dpnsvr.exe to be loaded which attempts to create a socket. In turn the firewall dialog appears prompting whether it's allowed to do so. So no communication between the dpnet test exe and dpnsvr.exe thus the timeout. Could someone run the dpnet test manually and allow the dpnsvr.exe to create connections? Best Regards Alistair Leslie-Hughes

2 4

Re: dmime: Do not try to query a NULL direct sound buffer
by Nikolay Sivov Feb. 28, 2014

Feb. 28, 2014

On 2/26/2014 13:03, Aric Stewart wrote: > --- > dlls/dmime/audiopath.c | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) Why is it NULL though? The only place I found that sets it is this: --- hr = IDirectSound8_CreateSoundBuffer ((LPDIRECTSOUND8) This->pDirectSound, &desc, &buffer, NULL); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, default_path); *ppNewPath = NULL; return DSERR_BUFFERLOST; } default_path->pDSBuffer = buffer; --- That means CreateSoundBuffer() doesn't return error code properly?

2 1

Re: shell32: Supply a module name to CreateProcess
by Alexandre Julliard Feb. 27, 2014

Feb. 27, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -330,9 +332,14 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait, > /* ShellExecute specifies the command from psei->lpDirectory > * if present. Not from the current dir as CreateProcess does */ > if( lpDirectory ) > + { > if( ( gcdret = GetCurrentDirectoryW( MAX_PATH, curdir))) > if( !SetCurrentDirectoryW( lpDirectory)) > ERR("cannot set directory %s\n", debugstr_w(lpDirectory)); > + > + PathCombineW(module_path, psei->lpDirectory, psei->lpFile); > + path = module_path; > + } We'd want to specify the path in all cases, not only when we have a directory. Also the SetCurrentDirectory shouldn't be needed with a proper path. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox() (try 2)
by Marvin Feb. 27, 2014

Feb. 27, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5256 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8158: Test failed: Mesh 27: new_num_vertices == 6, expected 4. mesh.c:8172: Test failed: Mesh 27: indices[3] == 3, expected 1 mesh.c:8172: Test failed: Mesh 27: indices[4] == 4, expected 3 mesh.c:8172: Test failed: Mesh 27: indices[5] == 5, expected 2 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 mesh.c:8228: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000).

1 0

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox()
by Marvin Feb. 27, 2014

Feb. 27, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5232 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8156: Test failed: Mesh 27: new_num_vertices == 6, expected 4. mesh.c:8170: Test failed: Mesh 27: indices[3] == 3, expected 1 mesh.c:8170: Test failed: Mesh 27: indices[4] == 4, expected 3 mesh.c:8170: Test failed: Mesh 27: indices[5] == 5, expected 2 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 mesh.c:8226: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000).

2 1

Re: urlmon: Fixed url.c tests on IE11.
by Marvin Feb. 27, 2014

Feb. 27, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5243 Your paranoid android. === wxppro (32 bit url) === url.c:1669: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1878: Test failed: binding failed: 800c0005, expected 00000000 url.c:1889: Test failed: res = 00002efd, expected 00000000 url.c:3146: Test failed: expected OnProgress_SENDINGREQUEST url.c:3152: Test failed: expected OnResponse url.c:3156: Test failed: expected OnProgress_MIMETYPEAVAILABLE url.c:3157: Test failed: expected OnProgress_BEGINDOWNLOADDATA url.c:3158: Test failed: expected OnProgress_ENDDOWNLOADDATA url.c:3170: Test failed: expected OnDataAvailable

2 1

Use of wined3d_mutex?
by Max TenEyck Woodbury Feb. 27, 2014

Feb. 27, 2014

I have been looking at the use of the wined3d_mutex_lock and wined3d_mutex_unlock functions in the drawing code. I strongly suspect that it is being badly over-used. In particular, user call back functions are being called in several places with this mutex held. If the callback starts another thread to do something graphical where the thread needs the mutex, and then waits for the thread to finish, both threads will hang until the mutex times out. There are also places where a function that takes out the mutex is called with the mutex already held. Switching to another terminal window and back again sometimes breaks these deadlocks. It used to be that I had to do this several times doing a 'make test', but it just takes a long time now. (Yes, years ago I left the test running for several hours when I went out for a few hours and it was still hung when I got back. That does not happen now,) This shows up running Guild Wars 2. I have a CPU monitor running while I play and I can see the game chomping on both cores, except that the game will sometimes hang for 30-45 seconds and then resume. I am in the process of annotating the drawing routines use of the mutex, and there is simply a lot of code to go through. Could someone with a good understanding of the drawing part of wine comment please. In particular, are there places where the lock-like action of the reference counts can be used in place of taking out the mutex? max

3 2

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken
by Marvin Feb. 27, 2014

Feb. 27, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5238 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFE4220C0 === w7pro64 (64 bit sock) === sock.c:622: Test failed: oob_server (98c): not at the OOB mark: 1

2 1

Re: [PATCH 1/2] d3dx9: Implement D3DXCreateBox()
by Henri Verbeet Feb. 27, 2014

Feb. 27, 2014

I'm not really in charge of d3dx9, and I would've expected Matteo or Rico to write this instead, but here are some comments. On 27 February 2014 11:38, Gediminas Jakutis <gediminas(a)varciai.lt> wrote: > + static const float sign_x[24] = {-1.0f, -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, > + 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, > + -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f}; The explicit array size isn't needed, and I don't think it adds much for clarity. The indentation looks pretty arbitrary, the usual style for tables like these is to put the brace on a new line, and then indent the elements once. I.e.: static const float sign_x[] = { -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, }; > + TRACE("(%p, %f, %f, %f, %p, %p)\n", device, width, height, depth, mesh, adjacency); I know d3dx9 isn't terribly consistent about this, but: TRACE("device %p, width %.8e, height %.8e, depth %.8e, mesh %p, adjacency %p.\n", device, width, height, depth, mesh, adjacency); > + hr = D3DXCreateMeshFVF(12, 24, D3DXMESH_MANAGED, D3DFVF_XYZ | D3DFVF_NORMAL, device, &box); > + > + if (FAILED(hr)) > + { > + return hr; > + } > + > + if (FAILED(hr = box->lpVtbl->LockVertexBuffer(box, 0, (void **)&vertices))) > + { > + box->lpVtbl->Release(box); > + return hr; > + } These are inconsistent. I'd prefer the second. > + for (i = 0; i < 24; i++) > + { > + vertices[i].position.x = width * sign_x[i]; > + vertices[i].position.y = height * sign_y[i]; > + vertices[i].position.z = depth * sign_z[i]; I suppose this works, but I think it would be clearer to store a unit box as an array of D3DXVECTOR3s, and then call D3DXVec3Scale() on the vectors. The "24" would then become "ARRAY_SIZE(unit_box)" as well. > + hr = D3DXCreateBuffer(36 * sizeof(DWORD), adjacency); > + > + if (FAILED(hr)) if (FAILED(hr = D3DXCreateBuffer(sizeof(adjacency_table), adjacency)))

1 0

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken
by Bruno Jesus Feb. 27, 2014

Feb. 27, 2014

On Thu, Feb 27, 2014 at 11:33 AM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > dlls/ws2_32/tests/sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 2252245..3f27b02 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -610,7 +610,7 @@ static VOID WINAPI oob_server ( server_params *par ) > ok ( pos == -1, "simple_server (%x): test pattern error: %d\n", id, pos); > > ioctlsocket ( mem->sock[0].s, SIOCATMARK, &atmark ); > - ok ( atmark == 1, "oob_server (%x): unexpectedly at the OOB mark: %i\n", id, atmark ); > + ok ( atmark == 1 || broken(atmark == 0), "oob_server (%x): unexpectedly at the OOB mark: %i\n", id, atmark ); There is other test failing too, right? At least for me. So this would only "solve" half of the problem. What we need to do IMO is simplify the test using a more sequential way to ensure normal and OOB data does not get mixed. Regards, Bruno

1 0

ddraw/tests: Don't crash after a failed CreateSurface() call.
by Francois Gouget Feb. 27, 2014

Feb. 27, 2014

So there are a number of CreateSurface() calls that fail and these are causing the tests to crash. For instance for ddraw2: http://test.winehq.org/data/tests/ddraw:ddraw2.html Is there a way to check what surface types are supported? create_device() calls EnumDevices() but finding a match clearly does not guarantee we'll be able to create a surface given the error we get there (but presumably that check was more for the following CreateDevice() call). I tried using EnumSurfaces() but without much luck. I'm also a bit worried that DDENUMSURFACES_MATCH is not used anywhere in Wine (*). Alternatively we can just react to failing CreateSurface() calls and clean up + abort a bit like is done in the following patch. (*) Also the DDENUMSURFACES_{SEARCH,MATCH}TYPE macros found in dlls/ddraw/ddraw.c are not used anymore since c8901d6f. diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 5a3bd77..2a5a9c4 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -227,7 +227,7 @@ static IDirect3DDevice2 *create_device(IDirectDraw2 *ddraw, HWND window, DWORD c surface_desc.dwWidth = 640; surface_desc.dwHeight = 480; hr = IDirectDraw2_CreateSurface(ddraw, &surface_desc, &ds, NULL); - ok(SUCCEEDED(hr), "Failed to create depth buffer, hr %#x.\n", hr); + ok(SUCCEEDED(hr) || broken(hr == DDERR_INVALIDPIXELFORMAT), "Failed to create depth buffer, hr %#x.\n", hr); if (FAILED(hr)) { IDirect3D2_Release(d3d); @@ -4451,6 +4451,8 @@ static void test_surface_lock(void) hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, type %s, hr %#x.\n", tests[i].name, hr); + if (FAILED(hr)) + continue; memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); @@ -4817,6 +4819,8 @@ static void test_set_surface_desc(void) hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + goto done; hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); @@ -5113,6 +5117,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw2_Release(ddraw); + DestroyWindow(window); + return; + } hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 81c043c..5da4a71 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -5423,6 +5423,12 @@ static void test_set_surface_desc(void) hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw4_Release(ddraw); + DestroyWindow(window); + return; + } reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -5715,6 +5721,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw4_Release(ddraw); + DestroyWindow(window); + return; + } memset(data, 0xaa, sizeof(data)); reset_ddsd(&ddsd); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 8e01238..4735fca 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -5301,6 +5301,12 @@ static void test_set_surface_desc(void) hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw7_Release(ddraw); + DestroyWindow(window); + return; + } reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -5594,6 +5600,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw7_Release(ddraw); + DestroyWindow(window); + return; + } memset(data, 0xaa, sizeof(data)); reset_ddsd(&ddsd);

2 1

Re: d3d9/tests: Fix some test failures on Windows 2000.
by Henri Verbeet Feb. 27, 2014

Feb. 27, 2014

On 24 February 2014 23:54, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > Most of the IDirect3D9_CreateDevice() calls in device.c should be calls to create_device() instead. (And then just skip() if it fails to create a device.) I think the only exceptions are test_fpu_setup() and test_swvp_buffer().

2 2

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.
by Henri Verbeet Feb. 27, 2014

Feb. 27, 2014

On 27 February 2014 02:24, Francois Gouget <fgouget(a)codeweavers.com> wrote: > * QEmu can emulate an old Cirrus 5446 graphics card that tops out at > 24bpp and thus does not support the 32bpp modes we want. For Windows > 2000 that's all that works. > For most of these tests, perhaps all of them, we don't care about the difference between 24 and 32 bpp modes. I'm going to look into writing a small set_display_mode() helper that just tries both, which would allow these tests to be run on the Windows 2000 testbot as well. That doesn't help for 8 bpp modes, but there are only a few tests that need those, and I think the way we handle those currently is fine.

1 0

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 2).
by Henri Verbeet Feb. 27, 2014

Feb. 27, 2014

> diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 0ceb6f1..c7c420a 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +void wined3d_privstore_init(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +void wined3d_privstore_cleanup(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, DWORD *flags) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > Perhaps this should just be a set of inline helpers in something like include/wine/wined3d_util.h, or possibly wined3d.h, similar to e.g. include/wine/list.h. I'm not really a fan of the name wined3d_privstore. I suppose wined3d_private_store would be slightly preferable, but I don't think that's particularly great either.

1 0

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.
by Stefan Dösinger Feb. 27, 2014

Feb. 27, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-27 02:24, schrieb Francois Gouget: > * HD4000 : Intel they decided that 256 color modes are obsolete > (they are) and not worth supporting. Out of curiosity, does that system run old game classics like Age of Empires 2 or old StarCraft 1? If so, how? If not, I'd consider that a pretty bad non-feature. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTDvTdAAoJEN0/YqbEcdMw+lcP/j5K7N52A6J6WhLqpSZrP7Ha AbptP8Z9L+O0G33rZlUbZAsT8w64aTDXjKL9ahIua9ia+lxl55JJaD9ectiV8clo 22PNXK1CdubY3pIrwKdlax0f+hM5ZqTOBN6gaG1th/CTau8SqXSI3scJZDoimnJO 9UQpwYj6smghh3uQhYx62KJKPDe3Ek9zgAMKRdkWRGc5P4zL/tk4uwGYm8CGM8Oy eAg9tthRUwDeYUaQ/MPdAOO82T42Z9WLEvJO+zk/VNr23P7E+H4WoYAuM9JMM1dP 8/x6CM7hmVrz8sE45wgpxrD/IDzZtIIzEBndjojhBEp2bctEIUJADKk23zGnIxHy 87OotuP7BFgrtZG0vXWO2eOV1xmcdXWdhZaHYzG8MDHLsUwLBgzL49gC5wA+UHL3 ad/IhIr+ok9wx1dXJYMrLfrPG05x93f1CmeNnPXU7gv1z/pQ+VoLbIvhsvlLUdap 9mmJC9ogbBju7whb+aNF1SAi/JrE4IkohiDkGvii2vWB4eGpOUCxKfhriEyJTKRQ iEjcWzxZ0d9CzDA0Lhe18ia8LoUafDvY9U/Q6c6fWhA/xt8ysTvgU+CmfiFNg9xN cYGkZSEaFMrq9mWfTRAdi/Kl7ZJ2DgOZGq3hKHm5XSd4rKkLlAWOpELiycpl8tqQ gaOLXi9E/iShT2ECIEu5 =AGOH -----END PGP SIGNATURE-----

1 0

Re: [PATCH] taskschd: Create dummy task definition for GetTask()
by Dmitry Timoshkov Feb. 27, 2014

Feb. 27, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > RegisteredTask_create() doesn't handle NULL definition, > neither does IRegisteredTask code. If it's meant to be fixed differently > please let me know. This still needs a lot of work, there is no need to pitch in. -- Dmitry.

2 2

Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid (try3)
by Marvin Feb. 27, 2014

Feb. 27, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5216 Your paranoid android. === wvistau64 (64 bit olepicture) === olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 === w2008s64 (64 bit olepicture) === olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 === w7pro64 (64 bit olepicture) === olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000

1 0

Re: [2/2] ws2_32: Add WSAEnumNameSpaceProviders[A|W] implementation
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5214 Your paranoid android. === build (build) === Make failed

1 0

Re: [1/2] ws2_32/tests: Add WSAEnumNameSpaceProviders[A|W] tests (try 2)
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5213 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.
by Ken Thomases Feb. 26, 2014

Feb. 26, 2014

On Feb 21, 2014, at 6:35 PM, mtewoodbury(a)gmail.com wrote: > Note that this greatly improves network reliability. How did you determine that? How could we confirm that? > - if ( (n = recvmsg(fd, &hdr, wsa->flags)) == -1 ) > + n = recvmsg(fd, &hdr, wsa->flags); > + if (n == -1 && (errno == EINTR || errno == EAGAIN)) > + n = recvmsg(fd, &hdr, wsa->flags); > + if (n == -1) > + > return -1; What's with that blank line between the last "if" and its corresponding statement? > - if (ret >= 0) > - { > + if (ret == -1 && (errno == EINTR || errno == EAGAIN)) > + ret = sendmsg(fd, &hdr, wsa->flags); /* Try it again quickly */ > + if (ret >= 0) { Why did you change the existing lines? You could have just added your two lines. In general: Is this actually the second patch of a two-patch series as indicated by the "[PATCH 2/2]" in the subject? I didn't receive the first patch. Have you tested to see if just retrying on EINTR is sufficient to improve the reliability? EAGAIN is not typically a situation where an immediate retry helps. The callers of WS2_recv() and WS2_send() already have tests for EINTR and EAGAIN. The strategy for dealing with those should probably exist in just one place. For my part, I think that all interruptible syscalls should be in a loop that immediately retries for EINTR, but EAGAIN should usually go back to some select(), poll(), kevent() or similar wait function. -Ken

4 12

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5210 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00426DB5 === w8 (32 bit ddraw2) === ddraw2.c:5278: Test failed: Got unexpected refcount 3. ddraw2.c:5297: Test failed: Got unexpected refcount 3. ddraw2.c:5304: Test failed: Got unexpected hr 0. ddraw2.c:5307: Test failed: Got unexpected refcount 3. ddraw2.c:5309: Test failed: Got unexpected refcount 2. ddraw2.c:5315: Test failed: Got unexpected hr 0. ddraw2.c:5318: Test failed: Got unexpected refcount 2. ddraw2.c:5320: Test failed: Got unexpected refcount 1. No test summary line found Failure running script in VM: network read timed out === w8 (32 bit ddraw1) === ddraw1.c:4182: Test failed: Got unexpected refcount 3. ddraw1.c:4201: Test failed: Got unexpected refcount 3. ddraw1.c:4208: Test failed: Got unexpected hr 0. ddraw1.c:4211: Test failed: Got unexpected refcount 3. ddraw1.c:4213: Test failed: Got unexpected refcount 2. ddraw1.c:4219: Test failed: Got unexpected hr 0. ddraw1.c:4222: Test failed: Got unexpected refcount 2. ddraw1.c:4224: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045C558 === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 00441995 === w8 (32 bit ddraw4) === ddraw4.c:5874: Test failed: Got unexpected refcount 3. ddraw4.c:5893: Test failed: Got unexpected refcount 3. ddraw4.c:5900: Test failed: Got unexpected hr 0. ddraw4.c:5903: Test failed: Got unexpected refcount 3. ddraw4.c:5905: Test failed: Got unexpected refcount 2. ddraw4.c:5911: Test failed: Got unexpected hr 0. ddraw4.c:5914: Test failed: Got unexpected refcount 2. ddraw4.c:5916: Test failed: Got unexpected refcount 1. ddraw4.c:5918: Test failed: Got unexpected refcount 6. Timeout Failure running script in VM: network read timed out

1 0

Re: ddraw/tests: Simplify the 'NT4 testbot' special case a bit.
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5209 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 004267A5 === w8 (32 bit ddraw2) === Timeout === w8 (32 bit ddraw1) === ddraw1.c:4113: Test failed: Got unexpected refcount 3. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4139: Test failed: Got unexpected hr 0. ddraw1.c:4142: Test failed: Got unexpected refcount 3. ddraw1.c:4144: Test failed: Got unexpected refcount 2. ddraw1.c:4150: Test failed: Got unexpected hr 0. ddraw1.c:4153: Test failed: Got unexpected refcount 2. ddraw1.c:4155: Test failed: Got unexpected refcount 1.

1 0

Re: ddraw: Add some more D3DDEVCAPS constants.
by Henri Verbeet Feb. 26, 2014

Feb. 26, 2014

> --- a/include/d3dcaps.h > +++ b/include/d3dcaps.h > @@ -302,6 +302,11 @@ typedef struct _D3DDeviceDesc7 { > #define D3DDEVCAPS_HWTRANSFORMANDLIGHT 0x00010000 > #define D3DDEVCAPS_CANBLTSYSTONONLOCAL 0x00020000 > #define D3DDEVCAPS_HWRASTERIZATION 0x00080000 > +#define D3DDEVCAPS_PUREDEVICE 0x00100000 > +#define D3DDEVCAPS_QUINTICRTPATCHES 0x00200000 > +#define D3DDEVCAPS_RTPATCHES 0x00400000 > +#define D3DDEVCAPS_RTPATCHHANDLEZERO 0x00800000 > +#define D3DDEVCAPS_NPATCHES 0x01000000 Where did you find these? They're not in any SDK I have.

2 1

Fwd: Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.
by Max TenEyck Woodbury Feb. 26, 2014

Feb. 26, 2014

-------- Original Message -------- Subject: Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR. Date: Wed, 26 Feb 2014 13:33:22 -0500 From: Max Woodbury <mtewoodbury(a)gmail.com> To: Ken Thomases <ken(a)codeweavers.com> On 02/23/2014 05:23 AM, Ken Thomases wrote: > On Feb 21, 2014, at 6:35 PM, mtewoodbury(a)gmail.com wrote: > >> Note that this greatly improves network reliability. > > How did you determine that? How could we confirm that? Feature of Guild Wars 2 (trading post) that failed to work on wine now works. Lower Game latency. Fewer login failures. > > >> - if ( (n = recvmsg(fd, &hdr, wsa->flags)) == -1 ) >> + n = recvmsg(fd, &hdr, wsa->flags); >> + if (n == -1 && (errno == EINTR || errno == EAGAIN)) >> + n = recvmsg(fd, &hdr, wsa->flags); >> + if (n == -1) >> + >> return -1; > > What's with that blank line between the last "if" and its corresponding statement? To emphasize the exit from the function. I find that I often want to know where such exits are and this makes them easier to fined. Personal preference... > >> - if (ret >= 0) >> - { >> + if (ret == -1 && (errno == EINTR || errno == EAGAIN)) >> + ret = sendmsg(fd, &hdr, wsa->flags); /* Try it again quickly */ >> + if (ret >= 0) { > > Why did you change the existing lines? You could have just added your two lines. Mostly just personal preference... > > In general: > > Is this actually the second patch of a two-patch series as indicated by the "[PATCH 2/2]" > in the subject? I didn't receive the first patch. No, my dyslexia strikes again. > > Have you tested to see if just retrying on EINTR is sufficient to improve the > reliability? EAGAIN is not typically a situation where an immediate retry helps. EAGAIN says specifically resources _temporarily_ unavailable. How temporary is not specified, so one quick retry could fix the problem. > > The callers of WS2_recv() and WS2_send() already have tests for EINTR and EAGAIN. > The strategy for dealing with those should probably exist in just one place. > For my part, I think that all interruptible syscalls should be in a loop that > immediately retries for EINTR, but EAGAIN should usually go back to some select(), > poll(), kevent() or similar wait function. I'd more or less agree except that there is, if I recall correctly, some other stuff that has to happen before the retry at the higher levels and I was getting game feature failures and latency waiting for those fixes. By all means, something like this could and should be done for most system calls. This one just annoyed me enough to try fiddling with it. Since it seemed to make a difference, I posted it... > > -Ken

1 0

Re: ddraw/tests: Fix some comma versus semi-colon mixups.
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5200 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00426825 === w8 (32 bit ddraw2) === ddraw2.c:5212: Test failed: Got unexpected refcount 3. ddraw2.c:5231: Test failed: Got unexpected refcount 3. ddraw2.c:5238: Test failed: Got unexpected hr 0. ddraw2.c:5241: Test failed: Got unexpected refcount 3. ddraw2.c:5243: Test failed: Got unexpected refcount 2. ddraw2.c:5249: Test failed: Got unexpected hr 0. ddraw2.c:5252: Test failed: Got unexpected refcount 2. ddraw2.c:5254: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:4115: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 3. ddraw1.c:4141: Test failed: Got unexpected hr 0. ddraw1.c:4144: Test failed: Got unexpected refcount 3. ddraw1.c:4146: Test failed: Got unexpected refcount 2. ddraw1.c:4152: Test failed: Got unexpected hr 0. ddraw1.c:4155: Test failed: Got unexpected refcount 2. ddraw1.c:4157: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045BF78 === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 00440B85 === w8 (32 bit ddraw4) === ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. No test summary line found Failure running script in VM: network read timed out

1 0

Re: [PATCH] winegcc: Don't set stdcall and fastcall attributes on ARM.
by Alexandre Julliard Feb. 26, 2014

Feb. 26, 2014

Grazvydas Ignotas <notasas(a)gmail.com> writes: > Otherwise we get lots of "attribute directive ignored" warnings. > Wine headers can take care defining __stdcall to nothing on ARM. If we wanted to rely on the headers we wouldn't need any of this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d9/tests: Fix some test failures on Windows 2000.
by Bruno Jesus Feb. 26, 2014

Feb. 26, 2014

On Mon, Feb 24, 2014 at 7:54 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) I was not aware that we are adding broken for Windows 2000. Otherwise I would not have sent http://source.winehq.org/git/wine.git/commitdiff/de0c46fd52b9f9f4ebfff256c7… I thought broken was for <= NT only. Bruno

2 1

Re: user32: Check WS_CHILD style in IsChild function (try3)
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5184 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040140 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Check WS_CHILD style in IsChild function (try2)
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5182 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Patch to fix bug 34324
by Zhenbo Li Feb. 26, 2014

Feb. 26, 2014

Hello, I've been working on http://bugs.winehq.org/show_bug.cgi?id=34324. Till now, I have found two solutions, one is simple and one is complex. Both of them would fix #34324, and I don't know which one is better. As Alexandre Julliard mentioned[1], I would use the value of GetLastError() as the return (error) value in delete_files(). The simple patch would fix part of the 'todo_wine' marks. Meanwhile, the complex patch would fix *all* todo marks about return value in test_delete(). I really appreciate your help (especially for Dmitry Timoshkov, thank you very much). And I'm looking for your feedbacks. Thank you. [1]: http://markmail.org/message/fblet7gadeusyauv#query:+page:1+mid:6eu2a72uuchh… -- Have a nice day! Zhenbo Li

2 5

Re: usp10: Use BOOL type where appropriate
by Nikolay Sivov Feb. 26, 2014

Feb. 26, 2014

On 2/26/2014 11:12, Frédéric Delanoy wrote: > cf. http://msdn.microsoft.com/en-us/library/windows/desktop/dd374096%28v=vs.85%… > --- > dlls/usp10/opentype.c | 32 ++++++++++++++++---------------- > dlls/usp10/shape.c | 36 ++++++++++++++++++------------------ > dlls/usp10/usp10.c | 26 +++++++++++++------------- > 3 files changed, 47 insertions(+), 47 deletions(-) > > diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c > index 166d823..5b3bdc7 100644 > --- a/dlls/usp10/opentype.c > +++ b/dlls/usp10/opentype.c > @@ -645,34 +645,34 @@ void OpenType_GDEF_UpdateGlyphProps(ScriptCache *psc, const WORD *pwGlyphs, cons > { > case 0: > case BaseGlyph: > - pGlyphProp[i].sva.fClusterStart = 1; > - pGlyphProp[i].sva.fDiacritic = 0; > - pGlyphProp[i].sva.fZeroWidth = 0; > + pGlyphProp[i].sva.fClusterStart = TRUE; > + pGlyphProp[i].sva.fDiacritic = FALSE; > + pGlyphProp[i].sva.fZeroWidth = FALSE; > break; I think it's a wrong change.Even if msdn says you can use TRUE/FALSE here, field is not defined as of 'BOOL' type.

3 5

Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid
by Alistair Leslie-Hughes Feb. 26, 2014

Feb. 26, 2014

On 26/02/2014 8:05 PM, Nikolay Sivov wrote: > --- > dlls/oleaut32/olepicture.c | 51 ++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 47 insertions(+), 4 deletions(-) > I submitted a similar patch http://www.winehq.org/pipermail/wine-patches/2011-December/109566.html It was rejected because it lacked tests. Best Regards Alistair Leslie-Hughes

2 1

Re: usp10/tests: Use BOOL type where appropriate
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5166 Your paranoid android. === w8 (32 bit usp10) === usp10.c:497: Test failed: 0:Wrong fRTL(0) usp10.c:497: Test failed: 0:Wrong fLayoutRTL(0) usp10.c:497: Test failed: 0:Wrong BidiLevel(0) usp10.c:498: Test failed: 1:Wrong fRTL(0) usp10.c:498: Test failed: 1:Wrong fLayoutRTL(0) usp10.c:498: Test failed: 1:Wrong BidiLevel(0)

1 0

Getting Introduced with the Community and Looking forward to Contribute to the Project as part of Gsoc 2014
by Gaurav Bansal Feb. 25, 2014

Feb. 25, 2014

Hi, Firstly I, Gaurav would like to introduce myself to the developers of this commmunity. I am a sophomore from Birla Institute of Science and Technology Pilani, India currently pursuing Bachelors in Computer Science and Engineering. My skills include Programming languages: GNU C/C++, Python, Java,PHP/MySQL Version control systems and Git/Github. I am also aware with many of the web development application tools and content management systems. I am an ambitous person willing to learn other technologies when need in future. I choose this organisation for the contribution as the work the community does looks very appealing and interesting to me and useful for the whole community. The skills used by the organisation for the development of open source software matches with my skills to much extent. I had installed the required necessary tools and setup the environment in my system needed for the contribution to open source software. I had got myself aware of the source to some extent. I had also read the contribution, development tutorial on the community webpage. I would like to seek the mentors help in the selection of the project for which the idea has been proposed for the Gsoc and someone is willing to mentor the project idea. I will highly appreciate with any kind of help, guidance from the mentors to help me move forward to contribute to the software starting off with some easy tasks and then moving levels higher so as to make a strong proposal for the upcoming Google Summer of Code 2014. [1] Github : https://github.com/gauravb7090 [2] IRC : gauravb7090 *--Gaurav*

1 0

Re: user32: Check WS_CHILD style in IsChild function
by Marvin Feb. 25, 2014

Feb. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5155 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00050094 fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6180: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure.
by Henri Verbeet Feb. 25, 2014

Feb. 25, 2014

On 24 February 2014 15:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +struct wined3d_privstore *wined3d_privstore_create(void) DECLSPEC_HIDDEN; > +void wined3d_privstore_destroy(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, BOOL addref) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > I'm not entirely convinced this is how we want this to work. Calling HeapAlloc() for a struct list seems less than ideal, and I'd like the WINED3DSPD_IUNKNOWN handling to be done by the callers.

2 1

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 3)
by Bruno Jesus Feb. 25, 2014

Feb. 25, 2014

Please rebase and resend your patches. On Fri, Jan 24, 2014 at 5:46 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > Load registry functions dynamically, test caused an error message box to pop > up on Windows XP instead of skipping the test, causing a timout error. > > Test now queries registry values to compare them with the function's result. > > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 ++ > dlls/bcrypt/tests/bcrypt.c | 107 > ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 113 insertions(+) > > >

1 0

Re: Raise the minimum version of FreeBSD to 8.0. (PING)
by Lauri Kenttä Feb. 25, 2014

Feb. 25, 2014

On 2014-02-24 00:15, Gerald Pfeifer wrote: > Any problem why this patch was not included yet? At least you have not changed all 7.0's to 8.0's, for example README.sv: "FreeBSD-versioner äldre än 7.0." -- Lauri Kenttä

1 0

Re: winmm/tests: Change the current directory to a place that will be writable.
by Marvin Feb. 25, 2014

Feb. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5140 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

2 1

Re: Assorted typos fixes (try 2)
by Nikolay Sivov Feb. 25, 2014

Feb. 25, 2014

On 2/25/2014 13:53, Andrey Gusev wrote: > --- a/dlls/dssenh/tests/dssenh.c > +++ b/dlls/dssenh/tests/dssenh.c > @@ -405,7 +405,7 @@ struct hash_test { > }; > > static const char testHashVal1[] = "I love working with Wine"; > -static const char testHashVal2[] = "Wine is not an emulater."; > +static const char testHashVal2[] = "Wine is not an emulator."; > static const char testHashVal3[] = ""; > This breaks now. Don't forget to do a 'make test' after making changes to test data.

1 0

Suggested RFP: LinuxFest Northwest
by Jeremy White Feb. 25, 2014

Feb. 25, 2014

As part of our new initiative, we're trying to encourage people to submit RFPs to give Wine talks. The Wine project can potentially help defray travel costs, although the ideal is to encourage folks that don't have to travel far. So here's one: http://linuxfestnorthwest.org/present LinuxFest Northwest. About 1500 Linux geeks. I'm told by an organizer that a Wine talk would be welcome. Anyone on the US West coast up for giving a talk? Cheers, Jeremy

3 2

Re: Assorted typos fixes (try 2)
by Marvin Feb. 25, 2014

Feb. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5149 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

1 0

Re: msi: Add tests for [un]registering progids.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5134 Your paranoid android. === w2000pro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605 === wxppro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605

1 0

Re: [PATCH 2/5] wined3d: Make use of WGL_WINE_make_current extension to restore the previous GL context without reference to its DC.
by Henri Verbeet Feb. 24, 2014

Feb. 24, 2014

On 23 February 2014 23:58, Ken Thomases <ken(a)codeweavers.com> wrote: > + if (gl_info->supported[WGL_WINE_MAKE_CURRENT] && > + !(gl_info->p_wglMakeContextCurrentWINE = (void *)wglGetProcAddress("wglMakeContextCurrentWINE"))) > + gl_info->supported[WGL_WINE_MAKE_CURRENT] = FALSE; Why can't load_gl_funcs() take care of this? > {"WGL_WINE_pixel_format_passthrough", WGL_WINE_PIXEL_FORMAT_PASSTHROUGH}, > + {"WGL_WINE_make_current", WGL_WINE_MAKE_CURRENT}, ... > WGL_WINE_PIXEL_FORMAT_PASSTHROUGH, > + WGL_WINE_MAKE_CURRENT, With the (obvious) exceptions of WINED3D_GL_EXT_NONE and WINED3D_GL_EXT_COUNT, the wined3d_gl_extension enum is supposed to be in lexicographical order.

2 2

Re: urlmon: Fixed some tests on IE11.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5116 Your paranoid android. === w8 (32 bit protocol) === protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20

1 0

Re: [PATCH 3/4] wmp: Added SetObjectRects implementation.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5115 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: [PATCH 2/4] wmp: Added DoVerb(OLEIVERB_HIDE) implementation.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5114 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: [PATCH 1/4] wmp: Return success in IPersistStreamInit::InitNew.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5113 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: ntdll: use case-insensitive matching for typelib flags
by Nikolay Sivov Feb. 23, 2014

Feb. 23, 2014

On 2/22/2014 03:06, Austin English wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35636 > > -- > -Austin Add a test please.

2 2

Re: Assorted typos fixes
by Dmitry Timoshkov Feb. 23, 2014

Feb. 23, 2014

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index c4e61cc..1f94516 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -3251,7 +3251,7 @@ static void test_GdipGetAllPropertyItems(void) > { PropertyTagTypeShort, 0x102, 6, { 8,0,8,0,8,0 } }, > { PropertyTagTypeShort, 0x103, 2, { 1 } }, > { PropertyTagTypeShort, 0x106, 2, { 2,0 } }, > - { PropertyTagTypeASCII, 0x10d, 27, "/home/meh/Desktop/test.tif" }, > + { PropertyTagTypeASCII, 0x10d, 27, "/home/meh/Desktop/test.tiff" }, > { PropertyTagTypeLong, 0x111, 4, { 8,0,0,0 } }, This change is obviously wrong. > diff --git a/dlls/ieframe/dochost.c b/dlls/ieframe/dochost.c > index 8c5d4b5..78b3f9e 100644 > --- a/dlls/ieframe/dochost.c > +++ b/dlls/ieframe/dochost.c > @@ -846,7 +846,7 @@ static HRESULT WINAPI DocHostUIHandler_ResizeBorder(IDocHostUIHandler2 *iface, > LPCRECT prcBorder, IOleInPlaceUIWindow *pUIWindow, BOOL fRameWindow) > { > DocHost *This = impl_from_IDocHostUIHandler2(iface); > - FIXME("(%p)->(%p %p %X)\n", This, prcBorder, pUIWindow, fRameWindow); > + FIXME("(%p)->(%p %p %x)\n", This, prcBorder, pUIWindow, fRameWindow); > return E_NOTIMPL; > } What's the reason for this one? -- Dmitry.

1 0

Re: Assorted typos fixes
by Marvin Feb. 23, 2014

Feb. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5100 Your paranoid android. === wxppro (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === wvista (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === wvistau64 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w2008s64 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w7pro64 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w8 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === wvistau64 (64 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w2008s64 (64 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w7pro64 (64 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch

1 0

Re: Assorted typos fixes
by Marvin Feb. 23, 2014

Feb. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5099 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

1 0

Re: resend: Windows sets CCS_VERT when TBSTYLE_EX_VERTICAL is set
by Marvin Feb. 23, 2014

Feb. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5097 Your paranoid android. === build (build) === Make failed

1 0

ff-core effect id handling in case of a failed effect upload
by Elias Vanderstuyft Feb. 23, 2014

Feb. 23, 2014

Hi, In the process of reviewing the Wine DInput translation layer, I noticed an inconvenience (in the ff-core implementation?) that can possibly lead to confusing problems to application developers (not only for Wine), in short: If a new (id==-1) effect was uploaded (look at ff-core.c::input_ff_upload(...)) that failed (e.g. returning EINVAL), ff-core will have assigned a positive number to the effect id. This can be confusing because the dev->ff->effects[] array will not contain an element at the index of that new effect id. Here is a more elaborated description/discussion: - This is a bug that is either the responsibility of the Linux kernel, or of Wine (and possibly other applications that do the same thing as described below): It is caused by the following situation: When uploading an effect, the specific kernel device driver may return an error, e.g. EINVAL for example when a periodic's effect period is set to zero. This error will then be returned by "ioctl(*(This->fd), EVIOCSFF, &This->effect)". With or without error, one can find out that /drivers/input/ff-core.c:input_ff_upload(...) is called, which will set effect->id >= 0, if it was set to -1 (=> new effect created) by the user. But in case of an error: - Assume effect->id was set to -1 by the user: The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will also be set >= 0 (*). The offending effect will not be saved in the ff->effects[] array (***). - Assume effect->id was set >= 0 by the user (and ff->effects[effect->id] is a valid existing effect): The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will remain unchanged (**). The offending effect will not overwrite the ff->effects[effect->id] element (****). Is this (see *, **, *** and ****) desired behaviour? - If yes: Change the following in Wine's dinput/effect_linuxinput.c:90 : if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { to : int effectId_old = This->effect.id; if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { This->effect.id = effectId_old; - If no for *: Kernel code /drivers/input/ff-core.c:input_ff_upload(...) has to be patched to revert "effect->id" back to its original value set by the user, which is only needed when the initial (by user) value of "effect->id" was equal to -1. - If no for **** (or maybe also ***): ff->effects[effect->id] could be replaced by an 'empty' effect (however this can get complex because the effect's type has to remain unchanged) This would be a change in the kernel code /drivers/input/ff-core.c:input_ff_upload(...). - If no for **: I don't really know. Discussion is needed. - In my opinion, **, *** and **** are desired behaviour, while * should leave the effect->id at -1. In that case, Wine's dinput implementation does not have to be patched, and the kernel code only should apply a minor patch. Best regards, Elias

4 8

Re: oleaut32: Use BOOL type where appropriate
by Nikolay Sivov Feb. 22, 2014

Feb. 22, 2014

On 2/22/2014 15:22, Frédéric Delanoy wrote: > --- > dlls/oleaut32/varformat.c | 8 ++++---- > dlls/oleaut32/vartype.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/oleaut32/varformat.c b/dlls/oleaut32/varformat.c > index e72a170..a6a10cf 100644 > --- a/dlls/oleaut32/varformat.c > +++ b/dlls/oleaut32/varformat.c > @@ -2303,9 +2303,9 @@ HRESULT WINAPI VarFormatNumber(LPVARIANT pVarIn, INT nDigits, INT nLeading, INT > if (nLeading == -2) > GETLOCALENUMBER(LOCALE_ILZERO, LeadingZero); > else if (nLeading == -1) > - numfmt.LeadingZero = 1; > + numfmt.LeadingZero = TRUE; > else > - numfmt.LeadingZero = 0; > + numfmt.LeadingZero = FALSE; > > if (nGrouping == -2) > { > @@ -2484,9 +2484,9 @@ HRESULT WINAPI VarFormatCurrency(LPVARIANT pVarIn, INT nDigits, INT nLeading, > if (nLeading == -2) > GETLOCALENUMBER(LOCALE_ILZERO, LeadingZero); > else if (nLeading == -1) > - numfmt.LeadingZero = 1; > + numfmt.LeadingZero = TRUE; > else > - numfmt.LeadingZero = 0; > + numfmt.LeadingZero = FALSE; > That's not a case when it's appropriate - 'LeadingZero' is UINT, not BOOL. Somewhat improved variant of above conditions could look like that: --- else numfmt.LeadingZero = nLeading == -1; ---

3 3

Fixing up the code style
by Stefan Dösinger Feb. 22, 2014

Feb. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, After recently helping two contributors (the Pipelight guys and Martin Storsjö) through the maze of the Wine code style I think it's best to lift the ban against style-only patches and unify the code style once and for all. The basic reasoning is that from my point of view the lack of clarity wrt the code style and lack of automatic enforceability is causing more issues than the problems style-only patches cause with git blame. Finding a style-only change with git blame can be handled by running git blame again. Frustrating contributors on the other hand has no workaround. So I propose to agree on a code style for the entire project, fixing it up preferably with an automated tool and in the future enforcing the style with checks in the Testbot. Opinions? Wrt the code style I propose the style that is used in wineserver. It is the same one as the new style in the d3d code except for single-line if conditions. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIbBAEBAgAGBQJS/MQGAAoJEN0/YqbEcdMw7rMP+LAP5pnxyy9onITtJVe8swuy pKrS+U1NgLIru9yGuuxUsejUr8gY9hD27nSQQ2OddzSV3pEkY6vmqftSIFVT8Oli d0kEXbxZhlzRe9rCgEJGLGx73ap/LBOm0k3jtslOVONlIyH8AXdEG37a2P7s8SKV D9p0Sw7ggNRF8D0eIszSPKjfUfBYph+9XU1SDA9aEfokv6rs6AFt9xehCOUsdayZ gwqiigg70tkez81GhDRfuXWVn6pdsVpeLDjxF4P2XFMT00OInJIYBIy2w91sxgOs 3vos4X60+qg+sIGxAhxgfLilVQSbBOqvBz9QEUycOduzJK87sVfGtpsipCX4qW1Z QNE+SOINHjazNPB0mydO7s6rThOuZS2BU5nG+ZaXmbe5RBUXLMqqjUmIGL2ZYodJ zQ+3eOHC0H8fxaNhqwpRh5Gq8fVE+xcXauovLv0Ro+FskOitfazIBJEfktjJuXZ8 YZcmLqQAGCwd0Y9pTOTXldoR9ah1+gO7ya5n2ljR0+viAol6KQoUaD4dFNhEur4j cpmW2EDks/wPVrvjX2u8cphHGeOLSjDEErnE/PoX5w7jNarekRWSSalanYB+04SX rjxUXSVq30upNdJ07W2L8gLaHTgHq0rglR1ZrSYEDw5FtaG/Xs4W0YqyX5APl/+O Bj4qRaV70TNOicRNgaA= =DQdS -----END PGP SIGNATURE-----

9 12

Re: Windows sets CCS_VERT when TB_GETEXTENDEDSTYLE is set
by Marvin Feb. 22, 2014

Feb. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5092 Your paranoid android. === build (build) === Make failed

1 0

Re: ws2_32/tests: Add W2K error values as valid
by Marvin Feb. 22, 2014

Feb. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5087 Your paranoid android. === w2000pro (32 bit sock) === sock.c:613: Test failed: oob_server (444): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (b28): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 7C9010E6 === wvistau64 (32 bit sock) === sock.c:613: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:613: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit sock) === sock.c:613: Test failed: oob_server (63c): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:613: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Re: Help about implementing WSACleanup (ws2_32)
by Bruno Jesus Feb. 21, 2014

Feb. 21, 2014

The attached patch implements a socket queue in the DLL side and implements WSACleanup. For now the socket list does not have any parameter but my target is to add more stuff to it and reduce the server calls. Any comments are appreciated. Best wishes, Bruno On Sun, Dec 29, 2013 at 4:21 PM, David Quintana (gigaherz) <gigaherz(a)gmail.com> wrote: > I have no knowledge about windows sockets, but DLLs are not shared across > processes. If a DLL wants shared memory it has to map it explicitly, like > everything else. On the other hand threads do share all memory, and windows > provides thread-local storage to allow thread-specific variables. > > On 29 Dec 2013 19:15, "Bruno Jesus" <00cpxxx(a)gmail.com> wrote: >> >> Hi, in an attempt to fix bugs 18670 and 26031 I would like to try >> implementing WSACleanup more properly. My limited knowledge in the >> interactions between the ws2_32 dll and wine server makes me think >> this is easy. >> >> The idea is to add the created socket in WSASocketW in a list and >> remove it from the list when closesocket is called. When the last >> WSACleanup is called it would iterate through the socket list and >> destroy the remaining sockets. >> >> When WSASocketW is called it calls the server to create the socket, >> when closesocket is called the server is also called and the function >> sock_destroy takes care of shutting down the socket. >> >> Currently I'm thinking about doing this in the dll side because the >> server is not aware of WSACleanup, but maybe it should because it >> needs to avoid calling any async operation completion. >> >> My questions are: >> 1) When I open 2 programs that use ws2_32 dll the global variables >> memory is not shared, right? Otherwise the WSAStartup/Cleanup count >> could be messed up if one application didn't call the Cleanup >> function. I hope this true so the socket list would not have to take >> care of different processes id. >> >> I understand that one application can have multiple threads and that's >> what the struct per_thread_data is about, but I hope the dll is not >> shared among different processes. >> >> 2) Is this a reasonable approach? If yes, is there any example of a >> critical protected list (add, iterate, remove items) that I could use? >> >> Best wishes, >> Bruno >> >> > -- universe* god::bigbang (void); //and then it all began...

2 4

Why using WINE not ReactOS-programs?
by theUser BL Feb. 21, 2014

Feb. 21, 2014

What stands on the WINE main-side for one of the new features of WINE 1.7.13? »More Windows Media Player stubs.« So you do not only reimplementing the platform. You also reimplement the MediaPlayer, the InternetExplorer, Wordpad, etc. A month ago, I already asked in the forum, why you don't take ReactOS programs for WINE: http://forum.winehq.org/viewtopic.php?f=8&t=20836 There are programs under the GPL. But some are under the LGPL. For example mspaint: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mspaint/ It can be possible, that there are programs for Windows, which makes use of mspaint and wants to start it, because it exists since Windows 95. So any Windows-developer can assume, that mspaint exists on the system. Same with some other programs. Greatings theuserbl

2 1

[idea]wine support for Chrome OS
by 中川祥 Feb. 21, 2014

Feb. 21, 2014

Now,we don't run wine in Chrome OS. Google also think they can run windows executable files. My idea is about how to use wine in the OS. Google Chrome has two types of extensions:one is the extension,that support only web technology.the other is PPAPI,Google Native Client. Here's the overview↓ https://developers.google.com/native-client/dev/overview For example,Flash Player uses PPAPI. C/C++ programs can be transformed and run in its sandbox. then we can run wine in Chrome OS. I think if wine supports Chrome OS,Google helps us.

3 5

Re: user32/tests: Add some SetDlgItemTextA tests
by Alexandre Julliard Feb. 20, 2014

Feb. 20, 2014

Bruno Jesus <00cpxxx(a)gmail.com> writes: > This patch was an attempt to reproduce the issue in bug 35621, I could > not get what I wanted but at least here I got the following error > covered in a todo: > > dialog.c:1022: Test failed: GetDlgItemText error, expected 102400, got > 80968. > dialog.c:1023: Test failed: Different text read. Works fine here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so dialog && touch dialog.ok dialog.c:1022: Test succeeded inside todo block: GetDlgItemText error, expected 102400, got 102400. dialog.c:1023: Test succeeded inside todo block: Different text read. make: *** [dialog.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: secur32: return success on graceful close of SSL connection
by Ken Thomases Feb. 20, 2014

Feb. 20, 2014

On Feb 20, 2014, at 3:41 PM, Aric Stewart wrote: > --- > dlls/secur32/schannel_macosx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/secur32/schannel_macosx.c b/dlls/secur32/schannel_macosx.c > index 5d88223..1d1df26 100644 > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -989,6 +989,8 @@ SECURITY_STATUS schan_imp_recv(schan_imp_session session, void *buffer, > else > TRACE("Read %lu bytes before would block\n", *length); > } > + else if (status == errSSLClosedGraceful) > + return SEC_E_OK; > else > { > WARN("SSLRead failed: %ld\n", (long)status); Every other path has a log line. You could add one to this case, but it's probably just sufficient to put an "or" clause in the noErr condition: if (status == noErr || status == errSSLClosedGraceful) TRACE("Read %lu bytes\n", *length); -Ken

1 0

FFE (force feedback) file format reverse engineered
by Elias Vanderstuyft Feb. 20, 2014

Feb. 20, 2014

Hi, Two weeks ago, I started working on reverse engineering the FFE file format, because the functionality to load and write is currently not available in Wine: http://wiki.winehq.org/ForceFeedbackSummerOfCode2005Summary " Missing functionality: - Reading and writing FF effects to files (IDirectInputDevice8::WriteEffectToFile and IDirectInputDevice8::EnumEffectsInFile) have not been implemented. They are stored in a RIFF file, the details of which are undocumented. Given the nature of RIFF, it should be relatively simple (albeit time-consuming) to determine the exact format of the effect files. " So I wrote a Python program that can read and validate FFE files, based on my assumption of the file format structure. In the Python file: - I tried to maximally expose the relation of the FFE file contents and the RIFF structure. - Every single bit in the FFE file will be tested/validated, and the program will throw a 'Warning' when something odd/against my assumptions, occurred with the file of interest. I did not yet implement write functionality in the Python file, but it should not be difficult (~inverse operation of read). For the CustomForce effect, my assumptions are hypothetical: there was no way to test it, because: - I did not find any file containing such effect - I couldn't create such file, because FEdit.exe does not support CustomForce effects to be created. This should be a starting point to implement these read and write stubs in Wine. I don't have time to do that now, so, maybe someone else is interested to do so? Any feedback is welcome, Best regards, Elias

2 3

Re: [3/3] gdi32/tests: Avoid using GetGlyphIndices directly.
by 中川祥 Feb. 20, 2014

Feb. 20, 2014

What a phrase it is! By the way,please replay to my patches 102290 and 102289. Please comment if they are safe,if true,they will be comitted. 2014-02-19 21:02 GMT+09:00 Akihiro Sagawa <sagawa.aki(a)gmail.com>: > > This makes NT4 happy. > --- > dlls/gdi32/tests/font.c | 45 ++++++++++++++++++++++++++++----------------- > 1 file changed, 28 insertions(+), 17 deletions(-) > > > > >

2 1

Re: [PATCH 2/2] oleaut32: Fix VariantCopy() for VT_RECORD variants (resent)
by Alexandre Julliard Feb. 20, 2014

Feb. 20, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/oleaut32/tests/vartest.c | 46 ++++++++++++++++++++++--- > dlls/oleaut32/variant.c | 79 ++++++++++++++++++++----------------------- > 2 files changed, 79 insertions(+), 46 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M jscript.dll -p jscript_test.exe.so run && touch run.ok wine: Unhandled page fault on read access to 0x00000001 at address 0x686c7866 (thread 007f), starting debugger... Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0x686c7866). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686c7866 ESP:0032f6a0 EBP:0032f6d8 EFLAGS:00010202( R- -- I - - - ) EAX:0032f720 EBX:687a01ec ECX:0032f6f0 EDX:00000001 ESI:00000000 EDI:0032f720 Stack dump: 0x0032f6a0: 001d0ca8 000012e0 0032f6e8 686c6914 0x0032f6b0: 00000020 00000000 001d0da8 0032f758 0x0032f6c0: 4d430003 00000000 0032f6f0 687a01ec 0x0032f6d0: 558b6bc0 00000000 0032f748 686c8eed 0x0032f6e0: 00000018 00000000 00000000 686c8eed 0x0032f6f0: 003315c0 0032f720 00000080 0032f70c Backtrace: =>0 0x686c7866 SafeArrayGetRecordInfo+0x46(psa=<couldn't compute location>, pRinfo=<couldn't compute location>) [/home/julliard/wine/wine/dlls/oleaut32/../../include/oaidl.h:4140] in oleaut32 (0x0032f6d8) 1 0x686c8eed SAFEARRAY_CopyData+0x28c(psa=0x3315c0, dest=0x331e78) [/home/julliard/wine/wine/dlls/oleaut32/safearray.c:409] in oleaut32 (0x0032f748) 2 0x686c91e6 SafeArrayCopy+0x145(psa=<couldn't compute location>, ppsaOut=<couldn't compute location>) [/home/julliard/wine/wine/dlls/oleaut32/safearray.c:1409] in oleaut32 (0x0032f7a8) 3 0x5589c671 VBArrayConstr_value+0x140(ctx=0x1ba150, vthis=0x32f838, flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/vbarray.c:308] in jscript (0x0032f808) 4 0x5587810b invoke_value_proc.isra+0x6a() in jscript (0x0032f858) 5 0x55878a57 Function_invoke+0x66(func_this=0x1d0d60, jsthis=(nil), flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/function.c:351] in jscript (0x0032f8a8) 6 0x5586b089 jsdisp_call_value+0xd8(jsfunc=0x1d0d60, jsthis=(nil), flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/dispex.c:1061] in jscript (0x0032f8f8) 7 0x5586b1a1 disp_call_value+0xb0(ctx=0x1ba150, disp=0x1d0d60, jsthis=(nil), flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/dispex.c:1200] in jscript (0x0032f9f8) 8 0x5586ef84 interp_new+0xc3(ctx=<is not available>) [/home/julliard/wine/wine/dlls/jscript/engine.c:985] in jscript (0x0032fa58) 9 0x55874a94 exec_source+0x1e3(ctx=<is not available>, code=<is not available>, func=<is not available>, from_eval=<is not available>, ret=<is not available>) [/home/julliard/wine/wine/dlls/jscript/engine.c:2462] in jscript (0x0032fad8) 10 0x5587eb46 exec_global_code.isra+0x85() in jscript (0x0032fb18) 11 0x5587ee19 JScriptParse_ParseScriptText+0x2a8(iface=<couldn't compute location>, pstrCode=<couldn't compute location>, pstrItemName=<couldn't compute location>, punkContext=<couldn't compute location>, pstrDelimiter=<couldn't compute location>, dwSourceContextCookie=<couldn't compute location>, ulStartingLine=<couldn't compute location>, dwFlags=<couldn't compute location>, pvarResult=<couldn't compute location>, pexcepinfo=<couldn't compute location>) [/home/julliard/wine/wine/dlls/jscript/jscript.c:805] in jscript (0x0032fba8) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: If the listbox loses focus while holding capture, release it by essentially simulating a button up event.
by Nikolay Sivov Feb. 20, 2014

Feb. 20, 2014

On 2/20/2014 15:35, Huw Davies wrote: > --- > dlls/user32/listbox.c | 1 + > dlls/user32/tests/listbox.c | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+) > > case WM_KILLFOCUS: > + LISTBOX_HandleLButtonUp( descr ); /* Release capture if we have it */ > descr->in_focus = FALSE; > descr->wheel_remain = 0; This isn't totally correct. It's fine for when you press and hold left button and then change focus with Tab for example, LBN_SELCHANGE does indeed happen in this case. But when you just Tab away from a list with no mouse commands you shouldn't send LBN_SELCHANGE.

2 2

Re: [PATCH 2/2] oleaut32: Fix VariantCopy() for VT_RECORD variants (resent)
by Marvin Feb. 20, 2014

Feb. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5039 Your paranoid android. === wvistau64 (64 bit vartest) === No test summary line found === w2008s64 (64 bit vartest) === No test summary line found === w7pro64 (64 bit vartest) === No test summary line found

1 0

Re: [PATCH 1/2] oleaut32/tests: Test for VariantClear() on VT_RECORD variant (try2)
by Marvin Feb. 20, 2014

Feb. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5038 Your paranoid android. === wvistau64 (64 bit vartest) === No test summary line found === w2008s64 (64 bit vartest) === No test summary line found === w7pro64 (64 bit vartest) === No test summary line found

1 0

Re: msi: Dont crash on installation of services without component KeyPath
by Hans Leidekker Feb. 20, 2014

Feb. 20, 2014

On Wed, 2014-02-19 at 14:49 +0900, Aric Stewart wrote: > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index 07322fe..a004225 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -5794,27 +5794,30 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) > goto done; > } > key = MSI_RecordGetString(row, 6); > - file = msi_get_loaded_file(package, key); > - msiobj_release(&row->hdr); > - if (!file) > - { > - ERR("Failed to load the service file\n"); > - goto done; > - } > - > - if (!args || !args[0]) image_path = file->TargetPath; > - else > + if (key) > { > - int len = strlenW(file->TargetPath) + strlenW(args) + 2; > - if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) > + file = msi_get_loaded_file(package, key); > + msiobj_release(&row->hdr); > + if (!file) > { > - ret = ERROR_OUTOFMEMORY; > + ERR("Failed to load the service file\n"); > goto done; > } > > - strcpyW(image_path, file->TargetPath); > - strcatW(image_path, szSpace); > - strcatW(image_path, args); > + if (!args || !args[0]) image_path = file->TargetPath; > + else > + { > + int len = strlenW(file->TargetPath) + strlenW(args) + 2; > + if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) > + { > + ret = ERROR_OUTOFMEMORY; > + goto done; > + } > + > + strcpyW(image_path, file->TargetPath); > + strcatW(image_path, szSpace); > + strcatW(image_path, args); > + } > } > service = CreateServiceW(hscm, name, disp, GENERIC_ALL, serv_type, > start_type, err_control, image_path, load_order, > @@ -5831,7 +5834,7 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) > WARN("failed to set service description %u\n", GetLastError()); > } > > - if (image_path != file->TargetPath) msi_free(image_path); > + if (image_path && image_path != file->TargetPath) msi_free(image_path); > done: > CloseServiceHandle(service); > CloseServiceHandle(hscm); Should we still create the service if the installer doesn't specify the image path?

4 8

Re: [PATCH 2/2] oleaut32: Fix VariantCopy() for VT_RECORD variants
by Marvin Feb. 20, 2014

Feb. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5036 Your paranoid android. === wvistau64 (64 bit vartest) === No test summary line found === w2008s64 (64 bit vartest) === No test summary line found === w7pro64 (64 bit vartest) === No test summary line found

1 0

Re: [1/2] shell32: Correct create flags when SEE_MASK_NO_CONSOLE isn't specified (resend)
by Alexandre Julliard Feb. 20, 2014

Feb. 20, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > shell32: Correct create flags when SEE_MASK_NO_CONSOLE isn't specified There's more to it than that, now it's popping up consoles all over the place during make test. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/2] oleaut32/tests: Test for VariantClear() on VT_RECORD variant
by Marvin Feb. 20, 2014

Feb. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5035 Your paranoid android. === wvistau64 (64 bit vartest) === No test summary line found === w2008s64 (64 bit vartest) === No test summary line found === w7pro64 (64 bit vartest) === No test summary line found

1 0

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries
by Marvin Feb. 20, 2014

Feb. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5034 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 3)winemac.drv: Improve positioning of IME client window based on caret
by Ken Thomases Feb. 20, 2014

Feb. 20, 2014

On Feb 20, 2014, at 12:28 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/ime.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) Looks good to me. -Ken

1 0