February 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] winegcc: Don't set stdcall and fastcall attributes on ARM.
by Alexandre Julliard Feb. 26, 2014

Feb. 26, 2014

Grazvydas Ignotas <notasas(a)gmail.com> writes: > Otherwise we get lots of "attribute directive ignored" warnings. > Wine headers can take care defining __stdcall to nothing on ARM. If we wanted to rely on the headers we wouldn't need any of this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d9/tests: Fix some test failures on Windows 2000.
by Bruno Jesus Feb. 26, 2014

Feb. 26, 2014

On Mon, Feb 24, 2014 at 7:54 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) I was not aware that we are adding broken for Windows 2000. Otherwise I would not have sent http://source.winehq.org/git/wine.git/commitdiff/de0c46fd52b9f9f4ebfff256c7… I thought broken was for <= NT only. Bruno

2 1

Re: user32: Check WS_CHILD style in IsChild function (try3)
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5184 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040140 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Check WS_CHILD style in IsChild function (try2)
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5182 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Patch to fix bug 34324
by Zhenbo Li Feb. 26, 2014

Feb. 26, 2014

Hello, I've been working on http://bugs.winehq.org/show_bug.cgi?id=34324. Till now, I have found two solutions, one is simple and one is complex. Both of them would fix #34324, and I don't know which one is better. As Alexandre Julliard mentioned[1], I would use the value of GetLastError() as the return (error) value in delete_files(). The simple patch would fix part of the 'todo_wine' marks. Meanwhile, the complex patch would fix *all* todo marks about return value in test_delete(). I really appreciate your help (especially for Dmitry Timoshkov, thank you very much). And I'm looking for your feedbacks. Thank you. [1]: http://markmail.org/message/fblet7gadeusyauv#query:+page:1+mid:6eu2a72uuchh… -- Have a nice day! Zhenbo Li

2 5

Re: usp10: Use BOOL type where appropriate
by Nikolay Sivov Feb. 26, 2014

Feb. 26, 2014

On 2/26/2014 11:12, Frédéric Delanoy wrote: > cf. http://msdn.microsoft.com/en-us/library/windows/desktop/dd374096%28v=vs.85%… > --- > dlls/usp10/opentype.c | 32 ++++++++++++++++---------------- > dlls/usp10/shape.c | 36 ++++++++++++++++++------------------ > dlls/usp10/usp10.c | 26 +++++++++++++------------- > 3 files changed, 47 insertions(+), 47 deletions(-) > > diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c > index 166d823..5b3bdc7 100644 > --- a/dlls/usp10/opentype.c > +++ b/dlls/usp10/opentype.c > @@ -645,34 +645,34 @@ void OpenType_GDEF_UpdateGlyphProps(ScriptCache *psc, const WORD *pwGlyphs, cons > { > case 0: > case BaseGlyph: > - pGlyphProp[i].sva.fClusterStart = 1; > - pGlyphProp[i].sva.fDiacritic = 0; > - pGlyphProp[i].sva.fZeroWidth = 0; > + pGlyphProp[i].sva.fClusterStart = TRUE; > + pGlyphProp[i].sva.fDiacritic = FALSE; > + pGlyphProp[i].sva.fZeroWidth = FALSE; > break; I think it's a wrong change.Even if msdn says you can use TRUE/FALSE here, field is not defined as of 'BOOL' type.

3 5

Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid
by Alistair Leslie-Hughes Feb. 26, 2014

Feb. 26, 2014

On 26/02/2014 8:05 PM, Nikolay Sivov wrote: > --- > dlls/oleaut32/olepicture.c | 51 ++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 47 insertions(+), 4 deletions(-) > I submitted a similar patch http://www.winehq.org/pipermail/wine-patches/2011-December/109566.html It was rejected because it lacked tests. Best Regards Alistair Leslie-Hughes

2 1

Re: usp10/tests: Use BOOL type where appropriate
by Marvin Feb. 26, 2014

Feb. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5166 Your paranoid android. === w8 (32 bit usp10) === usp10.c:497: Test failed: 0:Wrong fRTL(0) usp10.c:497: Test failed: 0:Wrong fLayoutRTL(0) usp10.c:497: Test failed: 0:Wrong BidiLevel(0) usp10.c:498: Test failed: 1:Wrong fRTL(0) usp10.c:498: Test failed: 1:Wrong fLayoutRTL(0) usp10.c:498: Test failed: 1:Wrong BidiLevel(0)

1 0

Getting Introduced with the Community and Looking forward to Contribute to the Project as part of Gsoc 2014
by Gaurav Bansal Feb. 25, 2014

Feb. 25, 2014

Hi, Firstly I, Gaurav would like to introduce myself to the developers of this commmunity. I am a sophomore from Birla Institute of Science and Technology Pilani, India currently pursuing Bachelors in Computer Science and Engineering. My skills include Programming languages: GNU C/C++, Python, Java,PHP/MySQL Version control systems and Git/Github. I am also aware with many of the web development application tools and content management systems. I am an ambitous person willing to learn other technologies when need in future. I choose this organisation for the contribution as the work the community does looks very appealing and interesting to me and useful for the whole community. The skills used by the organisation for the development of open source software matches with my skills to much extent. I had installed the required necessary tools and setup the environment in my system needed for the contribution to open source software. I had got myself aware of the source to some extent. I had also read the contribution, development tutorial on the community webpage. I would like to seek the mentors help in the selection of the project for which the idea has been proposed for the Gsoc and someone is willing to mentor the project idea. I will highly appreciate with any kind of help, guidance from the mentors to help me move forward to contribute to the software starting off with some easy tasks and then moving levels higher so as to make a strong proposal for the upcoming Google Summer of Code 2014. [1] Github : https://github.com/gauravb7090 [2] IRC : gauravb7090 *--Gaurav*

1 0

Re: user32: Check WS_CHILD style in IsChild function
by Marvin Feb. 25, 2014

Feb. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5155 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00050094 fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6180: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure.
by Henri Verbeet Feb. 25, 2014

Feb. 25, 2014

On 24 February 2014 15:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +struct wined3d_privstore *wined3d_privstore_create(void) DECLSPEC_HIDDEN; > +void wined3d_privstore_destroy(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, BOOL addref) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > I'm not entirely convinced this is how we want this to work. Calling HeapAlloc() for a struct list seems less than ideal, and I'd like the WINED3DSPD_IUNKNOWN handling to be done by the callers.

2 1

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 3)
by Bruno Jesus Feb. 25, 2014

Feb. 25, 2014

Please rebase and resend your patches. On Fri, Jan 24, 2014 at 5:46 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > Load registry functions dynamically, test caused an error message box to pop > up on Windows XP instead of skipping the test, causing a timout error. > > Test now queries registry values to compare them with the function's result. > > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 ++ > dlls/bcrypt/tests/bcrypt.c | 107 > ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 113 insertions(+) > > >

1 0

Re: Raise the minimum version of FreeBSD to 8.0. (PING)
by Lauri Kenttä Feb. 25, 2014

Feb. 25, 2014

On 2014-02-24 00:15, Gerald Pfeifer wrote: > Any problem why this patch was not included yet? At least you have not changed all 7.0's to 8.0's, for example README.sv: "FreeBSD-versioner äldre än 7.0." -- Lauri Kenttä

1 0

Re: winmm/tests: Change the current directory to a place that will be writable.
by Marvin Feb. 25, 2014

Feb. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5140 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

2 1

Re: Assorted typos fixes (try 2)
by Nikolay Sivov Feb. 25, 2014

Feb. 25, 2014

On 2/25/2014 13:53, Andrey Gusev wrote: > --- a/dlls/dssenh/tests/dssenh.c > +++ b/dlls/dssenh/tests/dssenh.c > @@ -405,7 +405,7 @@ struct hash_test { > }; > > static const char testHashVal1[] = "I love working with Wine"; > -static const char testHashVal2[] = "Wine is not an emulater."; > +static const char testHashVal2[] = "Wine is not an emulator."; > static const char testHashVal3[] = ""; > This breaks now. Don't forget to do a 'make test' after making changes to test data.

1 0

Suggested RFP: LinuxFest Northwest
by Jeremy White Feb. 25, 2014

Feb. 25, 2014

As part of our new initiative, we're trying to encourage people to submit RFPs to give Wine talks. The Wine project can potentially help defray travel costs, although the ideal is to encourage folks that don't have to travel far. So here's one: http://linuxfestnorthwest.org/present LinuxFest Northwest. About 1500 Linux geeks. I'm told by an organizer that a Wine talk would be welcome. Anyone on the US West coast up for giving a talk? Cheers, Jeremy

3 2

Re: Assorted typos fixes (try 2)
by Marvin Feb. 25, 2014

Feb. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5149 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

1 0

Re: msi: Add tests for [un]registering progids.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5134 Your paranoid android. === w2000pro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605 === wxppro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605

1 0

Re: [PATCH 2/5] wined3d: Make use of WGL_WINE_make_current extension to restore the previous GL context without reference to its DC.
by Henri Verbeet Feb. 24, 2014

Feb. 24, 2014

On 23 February 2014 23:58, Ken Thomases <ken(a)codeweavers.com> wrote: > + if (gl_info->supported[WGL_WINE_MAKE_CURRENT] && > + !(gl_info->p_wglMakeContextCurrentWINE = (void *)wglGetProcAddress("wglMakeContextCurrentWINE"))) > + gl_info->supported[WGL_WINE_MAKE_CURRENT] = FALSE; Why can't load_gl_funcs() take care of this? > {"WGL_WINE_pixel_format_passthrough", WGL_WINE_PIXEL_FORMAT_PASSTHROUGH}, > + {"WGL_WINE_make_current", WGL_WINE_MAKE_CURRENT}, ... > WGL_WINE_PIXEL_FORMAT_PASSTHROUGH, > + WGL_WINE_MAKE_CURRENT, With the (obvious) exceptions of WINED3D_GL_EXT_NONE and WINED3D_GL_EXT_COUNT, the wined3d_gl_extension enum is supposed to be in lexicographical order.

2 2

Re: urlmon: Fixed some tests on IE11.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5116 Your paranoid android. === w8 (32 bit protocol) === protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20

1 0

Re: [PATCH 3/4] wmp: Added SetObjectRects implementation.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5115 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: [PATCH 2/4] wmp: Added DoVerb(OLEIVERB_HIDE) implementation.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5114 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: [PATCH 1/4] wmp: Return success in IPersistStreamInit::InitNew.
by Marvin Feb. 24, 2014

Feb. 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5113 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: ntdll: use case-insensitive matching for typelib flags
by Nikolay Sivov Feb. 23, 2014

Feb. 23, 2014

On 2/22/2014 03:06, Austin English wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35636 > > -- > -Austin Add a test please.

2 2

Re: Assorted typos fixes
by Dmitry Timoshkov Feb. 23, 2014

Feb. 23, 2014

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index c4e61cc..1f94516 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -3251,7 +3251,7 @@ static void test_GdipGetAllPropertyItems(void) > { PropertyTagTypeShort, 0x102, 6, { 8,0,8,0,8,0 } }, > { PropertyTagTypeShort, 0x103, 2, { 1 } }, > { PropertyTagTypeShort, 0x106, 2, { 2,0 } }, > - { PropertyTagTypeASCII, 0x10d, 27, "/home/meh/Desktop/test.tif" }, > + { PropertyTagTypeASCII, 0x10d, 27, "/home/meh/Desktop/test.tiff" }, > { PropertyTagTypeLong, 0x111, 4, { 8,0,0,0 } }, This change is obviously wrong. > diff --git a/dlls/ieframe/dochost.c b/dlls/ieframe/dochost.c > index 8c5d4b5..78b3f9e 100644 > --- a/dlls/ieframe/dochost.c > +++ b/dlls/ieframe/dochost.c > @@ -846,7 +846,7 @@ static HRESULT WINAPI DocHostUIHandler_ResizeBorder(IDocHostUIHandler2 *iface, > LPCRECT prcBorder, IOleInPlaceUIWindow *pUIWindow, BOOL fRameWindow) > { > DocHost *This = impl_from_IDocHostUIHandler2(iface); > - FIXME("(%p)->(%p %p %X)\n", This, prcBorder, pUIWindow, fRameWindow); > + FIXME("(%p)->(%p %p %x)\n", This, prcBorder, pUIWindow, fRameWindow); > return E_NOTIMPL; > } What's the reason for this one? -- Dmitry.

1 0