February 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 3/6] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting
by Stefan Dösinger Feb. 11, 2014

Feb. 11, 2014

Am 11.02.2014 um 12:14 schrieb Martin Storsjo <martin(a)martin.st>: > --- > dlls/wined3d/arb_program_shader.c | 187 +++++++++++++++++++++++++------------- > 1 file changed, 122 insertions(+), 65 deletions(-) > > diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c > index 6d17ea3..8390c9e 100644 > --- a/dlls/wined3d/arb_program_shader.c > +++ b/dlls/wined3d/arb_program_shader.c > @@ -6768,22 +6768,68 @@ const struct fragment_pipeline arbfp_fragment_pipeline = { > arbfp_fragmentstate_template, > }; > > +struct arbfp_blit_type > +{ > + enum complex_fixup fixup; > + GLenum textype; > +}; > ... > +static int arbfp_blit_type_compare(const void *key, const struct wine_rb_entry *entry) > +{ > + const struct arbfp_blit_type *ka = key; > + const struct arbfp_blit_type *kb = &WINE_RB_ENTRY_VALUE(entry, const struct arbfp_blit_desc, entry)->type; > + > + return memcmp(ka, kb, sizeof(*ka)); > +} You have to watch out for padding space added by the compiler if you memcmp the structure. I think there’s no guarantee that enum complex_fixup is 4 bytes. Either use memset to initialize it to zero, or (preferred) make the fixup member a bitfield and add an explicit padding field for the remaining bits (see some structures in wined3d_private.h for examples) and set the padding to zero manually. > + desc = HeapAlloc(GetProcessHeap(), 0, sizeof(*desc)); > + if (!desc) > + { > + ERR("Out of memory\n"); > + GL_EXTCALL(glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)); > + checkGLcall("glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)"); > + GL_EXTCALL(glDeleteProgramsARB(1, &shader)); > + checkGLcall("GL_EXTCALL(glDeleteProgramsARB(1, &shader))"); > + return 0; > + } > ... > + ERR("Out of memory\n"); > + GL_EXTCALL(glDeleteProgramsARB(1, &shader)); > + checkGLcall("GL_EXTCALL(glDeleteProgramsARB(1, &shader))"); > + GL_EXTCALL(glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)); > + checkGLcall("glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)"); > + HeapFree(GetProcessHeap(), 0, desc); > + return 0; > + } You can use goto (yes, goto) to avoid code duplication in error handling. See e.g. wined3d_device_init_3d in device.c > - upload_palette(surface, context); I think you lost that call. The unfortunate thing about the P8 conversion is that the shader conversion codepath is essentially dead code for various reasons. So it’s tricky to test and likely already broken.

2 1

Re: [PATCH 1/3] msvcrt/tests: Don't pass path containing spaces to _spawnvp (try3)
by Piotr Caban Feb. 11, 2014

Feb. 11, 2014

Hi, s I've seen that this patch was marked as pending. I'm not sure what should I change in it. The argv[0] argument is not used in child process so maybe it will be clearer if I put some dummy value there. I can also change the tests to not use _spawnvp. There's following comment near _spawnvp implementation: Like on Windows, this function does not handle arguments with spaces or double-quotes. Here are some results that shows what happens on windows when the tests are executed without this patch. The behavior on wine is similar. E:\>msvcrt_crosstest.exe file file: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 791 tests executed (0 marked as todo, 0 failures), 0 skipped. E:\>"a a\msvcrt_crosstest.exe" file Fatal: test 'a\msvcrt_crosstest.exe' does not exist. file.c:1417: Test failed: bad position 0 expecting 8 file.c:1419: Test failed: Couldn't read back the data Fatal: test 'a\msvcrt_crosstest.exe' does not exist. Fatal: test 'a\msvcrt_crosstest.exe' does not exist. file.c:1987: Test failed: i 0, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '⌂' file.c:1987: Test failed: i 1, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '⌂' file.c:1987: Test failed: i 2, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '⌂' Fatal: test 'a\msvcrt_crosstest.exe' does not exist. file.c:2024: Test failed: fread() returned 0: ferror=0 file.c:2027: Test failed: got '⌂' expected 'Hello worldHello worldHello world' file: 791 tests executed (0 marked as todo, 10 failures), 0 skipped. In the failing case argv[0] = "a" argv[1] = "a\msvcrt_crosstest.exe" argv[2] = "file" Thanks, Piotr

2 1

Re: [PATCH 1/2] wined3d: Add support for NV12 textures
by Stefan Dösinger Feb. 11, 2014

Feb. 11, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, The shader looks ok to me. Please add a test - see yuv_color_test in dlls/d3d9/tests/visual.c as an example, although it might not be feasible to integrate a NV12 test into the UYVY / YUY2 test loop. Since the UYVY / YUY2 test already covers the color space conversion parts I think a NV12 test should make sure that the coordinate selection works properly. Test that e.g. a 4x4 or 8x8 texture produces the correct color pattern. Am 2014-02-10 12:08, schrieb Martin Storsjo: > This fixes video playback with the sample app from OpenH264. > --- > I haven't been able to test the GL_TEXTURE_RECTANGLE_ARB codepath > here - if I explicitly disable > gl_info->supported[ARB_TEXTURE_NON_POWER_OF_TWO] the same app > crashes. Similarly for YV12 (which already exists and works), > if I disable ARB_TEXTURE_NON_POWER_OF_TWO there, the app crashes > and the video output is also garbled (the luma channel seems to > be right but chroma is handled incorrectly). I don't know what could be wrong with the texture rectangle codepath. I tested it when I wrote it for other formats, but it's quite possible that it has suffered from bitrot in the years since then. Also keep in mind that wined3d assumes limited ARB_TEXTURE_NON_POWER_OF_TWO support if OpenGL 2.0 is supported. > @@ -6772,6 +6772,7 @@ struct arbfp_blit_priv { > GLenum yuy2_rect_shader, yuy2_2d_shader; > GLenum uyvy_rect_shader, uyvy_2d_shader; > GLenum yv12_rect_shader, yv12_2d_shader; > + GLenum nv12_rect_shader, nv12_2d_shader; > GLenum p8_rect_shader, p8_2d_shader; > GLuint palette_texture; > }; It might be a good idea to replace those 10 shaders and the poorly scaling search for them with a rbtree. Yeah, I know, I started this mess, but back then it was just 4 shaders and we've been too lazy to clean this up since then :-\ . > + switch(textype) { > + case GL_TEXTURE_2D: tex = "2D"; break; > + case GL_TEXTURE_RECTANGLE_ARB: tex = "RECT"; break; > + default: > + FIXME("Implement nv12 correction for non-2d, non-rect textures\n"); > + return FALSE; > + } Regarding the code style please use the style found in dlls/wined3d/cs.c. We're migrating the code style of wined3d to this style, but since style-only changes are frowned upon we're doing this as we go. I'm sorry for the mess :-( -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS+MA3AAoJEN0/YqbEcdMw434P/36l/R7vl7k3mx24+cYw1mll DOqx4yov+V+I3ERFbQjWmzwvAKoxFbo2+Qn7AaEAegGk1x5G3cuw4jZmo+C4bUb0 uvePY9WbvZptGFdavLAEgYWaBtY6M9pNJkp1PuIehqeq9D3XP98AUH4awzWFbfcD /dQQGVow1D8hkp57iATzUpEwDZBGttAePxyYR/gj7r1FnqPpVD0NW/zWoLJBWMrq 4YQSZBmJQK3xq5mcVlajNUg0Ylh82fp0bzxCie8Zw1jNuahmbGEAaht87fzxWCMc DgdcCS19aZEa39kNT/0ft/vybIPNyHVA+Mon+JgYmEVQRxhJMCl6gYbEKYCWcs0f OZc6d5B8Z4PX9FiPTnofs49SRq2+Gh6YggJdjToY2YZ2iOGgD4A87EIj2iZQc+6w 9jz2SLIZPl4zrjBY5Ji31qyKy8c+emOO9KC1OdnkFPo6eUeIussjrCfX7r2mNyRs 2qNHLz2yrd8aG0+swYvHocZ/wnUeOtgaTYJef8BTEut0+iBsDJ/eQom1/84orhxJ oHmdTbfepXMEoQvhkMSu79gZBMnwvFERZngzOPjKuw0KS3XM+KIFOy1nFeVAMGvb AoVa39jkByIcF0tN6vuf12LdWtdMqkwKeNuF36iEwVAgzkr8pAU6xHL5QqY1QhuB zsCB0PSX3QSmNC/4s7k8 =r3du -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/2] draw: Return the D3D identifier when GetDeviceIdentifier is called with no flags.
by Henri Verbeet Feb. 11, 2014

Feb. 11, 2014

On 11 February 2014 06:54, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > + memset(&adapter_id, 0x0, sizeof(adapter_id)); > + adapter_id.driver = DriverName; > + adapter_id.driver_size = sizeof(DriverName); > + adapter_id.description = DriverDescription; > + adapter_id.description_size = sizeof(DriverDescription); I think you can just write that as: + adapter_id.driver = DDDI->szDriver; + adapter_id.driver_size = sizeof(DDDI->szDriver); + adapter_id.description = DDDI->szDescription; + adapter_id.description_size = sizeof(DDDI->szDescription); + adapter_id.device_name_size = 0; > + /* check how strings are copied into the structure */ > + ok(pdddi2->szDriver[MAX_DDDEVICEID_STRING - 1]==0, "szDriver not cleared\n"); > + ok(pdddi2->szDescription[MAX_DDDEVICEID_STRING - 1]==0, "szDescription not cleared\n"); I don't think there anything in the code that guarantees this.

1 0

Re: [2/2] shell32: Supply a module name to CreateProcess
by Dmitry Timoshkov Feb. 11, 2014

Feb. 11, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- a/dlls/shell32/shlexec.c > +++ b/dlls/shell32/shlexec.c > @@ -315,6 +315,8 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait, > WCHAR curdir[MAX_PATH]; > DWORD dwCreationFlags; > const WCHAR *lpDirectory = NULL; > + WCHAR module_path[MAX_PATH] {0}; Does this really compile? -- Dmitry.

1 0

Re: [PATCH 1/5] wined3d: Introduce a sub resource structure.
by Henri Verbeet Feb. 10, 2014

Feb. 10, 2014

On 10 February 2014 13:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This structure will be a base structure for buffers, surfaces and > volumes. It will take care of location management, opengl buffers, > mapping and (at least for now) memory allocation. Sub resources will > also store the pointer to the container resource. > I'm not convinced this is really the correct approach to this.

2 1

Re: bcrypt: Add semi-stub implementation of BCryptGenRandom (try 2)
by Alexandre Julliard Feb. 10, 2014

Feb. 10, 2014

Bruno Jesus <00cpxxx(a)gmail.com> writes: > + > + /* Zero sized buffer should work too */ > + ret = pBCryptGenRandom(NULL, buffer, 0, BCRYPT_USE_SYSTEM_PREFERRED_RNG); > + ok(ret == STATUS_SUCCESS, "Expected success, got 0x%x\n", ret); > + > + /* Test random number generation - It's impossible for a sane RNG to return 8 zeros */ > + rnd[0] = 0; > + rnd[1] = 0; > + ret = pBCryptGenRandom(NULL, buffer, sizeof(DWORD) * 2, BCRYPT_USE_SYSTEM_PREFERRED_RNG); > + ok(ret == STATUS_SUCCESS, "Expected success, got 0x%x\n", ret); > + ok(rnd[0] || rnd[1], "Expected a random number, got 0\n"); > + trace("BCryptGenRandom : %08X%08X\n", rnd[0], rnd[1]); There's no reason to work with DWORDs, the function returns bytes, just use that directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: configure: Avoid nesting cat calls.
by Alexandre Julliard Feb. 10, 2014

Feb. 10, 2014

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -3453,9 +3453,7 @@ fi > AC_CONFIG_COMMANDS([Makefile], [wine_fn_output_makefile Makefile], > [wine_fn_output_makefile () > { > - cat Make.tmp - <<\_WINE_EOF >\$tmp/makefile && mv -f \$tmp/makefile \$[]1 && rm -f Make.tmp && return > -`cat $wine_rules_file` > -_WINE_EOF > + cat Make.tmp $wine_rules_file >\$tmp/makefile && mv -f \$tmp/makefile \$[]1 && rm -f Make.tmp && return This doesn't do the same thing at all, it can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Alexandre Julliard : Wine release 1.7.12
by Joseph Facciponti Feb. 9, 2014

Feb. 9, 2014

remove me from your list please On Fri, Feb 7, 2014 at 2:04 PM, Alexandre Julliard <julliard(a)winehq.org>wrote: > Module: website > Branch: master > Commit: 14ca1bc06c384e1a3c2d51b3205a7e1e54045519 > URL: > http://source.winehq.org/git/website.git/?a=commit;h=14ca1bc06c384e1a3c2d51… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Feb 7 20:04:34 2014 +0100 > > Wine release 1.7.12 > > --- > > news/en/2014020701.xml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/news/en/2014020701.xml b/news/en/2014020701.xml > new file mode 100644 > index 0000000..ce004de > --- /dev/null > +++ b/news/en/2014020701.xml > @@ -0,0 +1,16 @@ > +<news> > +<date>February 7, 2014</date> > +<title>Wine 1.7.12 Released</title> > +<body> > + The Wine development release 1.7.12 is now available. > + <a href="{$root}/announce/1.7.12">What's new</a> in this release: > +<ul> > + <li>Initial support for Window Media Player interfaces.</li> > + <li>Some more Task Scheduler support.</li> > + <li>Various C++ runtime fixes.</li> > + <li>More dlls with ugly names for Windows 8 API set support.</li> > + <li>Various bug fixes.</li> > +</ul> > +The source is <a href=" > http://prdownloads.sourceforge.net/wine/wine-1.7.12.tar.bz2">available > now</a>. > +Binary packages are in the process of being built, and will appear soon > at their respective <a href="{$root}/download">download locations</a>. > +</body></news> > > > >

2 1

FOSDEM Presentations
by Stefan Dösinger Feb. 9, 2014

Feb. 9, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Do we collect FOSDEM presentations in a central place? Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS9nIIAAoJEN0/YqbEcdMwXWIP/iB5Hb647oT5UcSiUy7Zru7a YaFb5/uTkBpOJZhD9KAa/u6XT8l7jh9pB633RgZSPl4xBY9/T3aIo+5amMF7IOvA 3NP3I0bRehnlbzAaeqhoN97BIHJQ4Y2ulub+FPx/GDY/kxwXayd0jurEcf+ZL4K2 csOtkgSplI05YXxBw1ZmYjiOGfXgqRH1DCEyaFaFgEWenYrfER7XzaiT2xAK64JN 85Cmp2vh5zlTh3C5jChpoeaWIHcweHC5EYONYOCAk9W2wxZdin0QWjYVnja5+DzR HnrcIsiFAXdD9IRxBStc+y4yqUq5YIDfZczpj0fI5cuPrqOxvnomyNI/y2Zs4epz sq1lL5eEyo5hTQS99PbqbENrT7IRF0IpSIebcrPCTbCpuKHctwWe3oFFS2BuqIPl 4Q/6bsNXxvQW4B3es4vcGDov05Aiy/MT1NQZoEsIXvYNa/ufqiEDmmXVCRz7rI6f 9D4hiMzS6Dxh3VRSigBcg1R3H+rYc+v1gUxGutcXWplGrVLFuE3iBY7UYfdp9rkC 6zcidSNrUDMsQMKLbmCXQV361RcL03bi+rtTVzl4d/u5RhpgVZG8BSoq49+Nt3ea MHNplal9pHWXcBHXos3L0o4PeF2tf7rdNRuLOdVYya6bBYP/UpVtHeJ2/SD7WoOV HvlQe9zHcOxAKYSX0M0P =bd+Z -----END PGP SIGNATURE-----

3 3

Re: oleaut32: Resolve embedded unnamed TypeLib dependencies using their GUID.
by Nikolay Sivov Feb. 7, 2014

Feb. 7, 2014

On 2/8/2014 03:27, guillaume.charifi(a)sfr.fr wrote: > This patch is designed to fix the bug: > http://bugs.winehq.org/show_bug.cgi?id=34184 > It appears that while the dependency checking of a TypeLib is being > processed, some programs have the requested TypeLib in their Resource > section/TYPELIB. Before this patch, the behavior was to look for the > TLB on the disk, using the name provided. Obviously, when it is > embedded into the program, the function fails everytime. Now, > considering the GUID in place of the TLB name, and searching into the > Resource section, the TLB is correctly loaded. > This is what happens with Skype's "uc.tlb", whose name is only > referenced in the TLB skControl, and nowhere else. Using instead the > GUID, we are able to find and load the unnamed "uc.tlb" from the > program resources. > > --- > dlls/oleaut32/typelib.c 193 > +++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 192 insertions(+), 1 deletion(-) > We already have a code to load from resource section, it should be reused instead of duplicating it like this. Also a test would be nice.

1 0

Re: Assorted spelling fixes
by Marvin Feb. 7, 2014

Feb. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4688 Your paranoid android. === w2008s64 (64 bit url) === url.c:1662: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1674: Test failed: unexpected call OnProgress_CONNECTING === w7pro64 (64 bit url) === url.c:1662: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1674: Test failed: unexpected call OnProgress_CONNECTING url.c:1871: Test failed: binding failed: 800c0005, expected 00000000 url.c:1882: Test failed: res = 00002efd, expected 00000000 url.c:3141: Test failed: expected OnProgress_SENDINGREQUEST url.c:3147: Test failed: expected OnResponse url.c:3151: Test failed: expected OnProgress_MIMETYPEAVAILABLE url.c:3152: Test failed: expected OnProgress_BEGINDOWNLOADDATA url.c:3153: Test failed: expected OnProgress_ENDDOWNLOADDATA url.c:3165: Test failed: expected OnDataAvailable url.c:1660: Test failed: unexpected call OnProgress_FINDINGRESOURCE

1 0

Re: Assorted spelling fixes
by Marvin Feb. 7, 2014

Feb. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4686 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

1 0

Re: [Tools] winetest: Make the WineTest executable links more visible.
by Alexandre Julliard Feb. 7, 2014

Feb. 7, 2014

Francois Gouget <fgouget(a)free.fr> writes: > --- > > As per WineConf. > Note that the choice of a 'legend' class rather than nothing or some > other class is mostly a matter of taste. I don't think that users not finding the test binary is a major problem. A better approach would be to add some help page on the wiki and link to that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: kernel32: In FindFirstFileExW(), call NtQueryDirectoryFile() again to determine if it read all files.
by Alexandre Julliard Feb. 7, 2014

Feb. 7, 2014

Ken Thomases <ken(a)codeweavers.com> writes: > Previously, it only checked if the first call failed to fill the buffer. This > is unreliable since the underlying implementation may be forced to return > a short buffer by the semantics of the system calls used. In particular, > getdirentries() on Mac OS X can only read at the resolution of whole blocks > rather than individual directory entries for AFP-mounted volumes. It would be better to fix the ntdll side. -- Alexandre Julliard julliard(a)winehq.org

2 5

Preferred License for Presentations?
by Michael Stefaniuc Feb. 7, 2014

Feb. 7, 2014

Hello guys, what license do we prefer to use for Wine presentations and the related material? For the LinuxTag presentation I have the option to pick one of: - Creative Commons License - UVM Lizenz für die freie Nutzung unveränderter Inhalte - GNU General Public License - UVM Lizenz für Freie Inhalte - GNU Free Documentation License thanks bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Supervisor, APAC/EMEA IT Network/Telephony Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 Grasbrunn Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Mark Hegarty, Charlie Peters, Michael Cunningham, Charles Cachera

2 2

Call for updating recent news queue
by André Hentschel Feb. 7, 2014

Feb. 7, 2014

Hi, After getting some very positive feedback at FOSDEM2014 i decided (even with lack of time) to get WWN started again. I'm still a developer, so my time is limited, therefor it would be nice if we could crowdsource this as far as possible. So it would be nice if everyone could have a look at: http://wiki.winehq.org/RecentNewsQueue and update it again. I know this worked last time, but we had no WWN for it. Even if this will be my first try to push out a WWN, i'll make sure this won't happen this time. Thanks in advance

3 2

Re: [PATCH 2/2] d3d9/tests: Test that Direct3D restores the pixel format on the window it targets. (try 2)
by Henri Verbeet Feb. 7, 2014

Feb. 7, 2014

On 7 February 2014 02:13, Ken Thomases <ken(a)codeweavers.com> wrote: > > + ZeroMemory(&present_parameters, sizeof(present_parameters)); > + present_parameters.Windowed = TRUE; > + present_parameters.hDeviceWindow = hwnd; > + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; > + > + hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, > + hwnd, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device); > + if (FAILED(hr) || !device) > + { > + skip("Failed to create device\n"); > + goto cleanup; > + } Please use create_device() for creating the device, unless there's some reason it can't work here. > + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); > + ok(SUCCEEDED(hr), "Present failed %#x\n", hr); I think an interesting test would be Present() with a non-NULL destination window. I'd also like the equivalent test for d3d8, and ddraw with a clip window.

1 0

questionarie
by Akira Nakagawa Feb. 7, 2014

Feb. 7, 2014

Why my patch,101880 and 102083 are not commited? They have no problem,certified by Akihiro. -- Akira Nakagawa <matyapiro31(a)gmail.com>

2 1

Re: [PATCH 1/2] msvcrt: Return error on invalid handle in _open_osfhandle
by Marvin Feb. 7, 2014

Feb. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4655 Your paranoid android. === wxppro (32 bit file) === file.c:1417: Test failed: bad position 0 expecting 8 file.c:1419: Test failed: Couldn't read back the data file.c:1987: Test failed: i 0, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:1987: Test failed: i 1, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:1987: Test failed: i 2, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:2024: Test failed: fread() returned 0: ferror=0 file.c:2027: Test failed: got '' expected 'Hello worldHello worldHello world'

1 0

Re: [PATCH 2/2] d3d9/tests: Test that Direct3D restores the pixel format on the window it targets.
by Marvin Feb. 6, 2014

Feb. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4644 Your paranoid android. === wxppro (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === wvista (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w2008s64 (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w7pro64 (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w2008s64 (64 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w7pro64 (64 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2

1 0

Re: msvcrt: Don't prevent msvcrt from getting unloaded
by Piotr Caban Feb. 6, 2014

Feb. 6, 2014

On 02/06/14 15:54, Piotr Caban wrote: > --- > dlls/msvcrt/main.c | 3 --- > 1 file changed, 3 deletions(-) Please ignore this patch for now. It breaks the app it was originally added for (bug 21930).

1 0

Wine at LinuxTag in Berlin
by Michael Stefaniuc Feb. 6, 2014

Feb. 6, 2014

Hello guys, to follow up to Jeremy's email on doing more Wine "evangelism" the idea quickly came up to do something for LinuxTag which happens from 8th to 10th May in Berlin / Germany http://www.linuxtag.org/2014/en/ . Talks: ------ The deadline for proposals is the 7th February. - I will submit a talk proposal: "Is Wine Still Relevant?" with a a subtitle along the lines of "A Wine status update focusing on current use cases and new exciting developments". Needs more buzzwords, I know ;) - Marcus had other ideas for talks, of course somebody would need to hold them. <_Marcus_> and a Playing Windows games with Wine could be seperate if necessary /& wanted... would surely also be interesting <_Marcus_> and Wine on Android , which I was surprised to have it fill the room ;) <_Marcus_> and a pipelight talk ... that would surely pull folks. - We're open to other talk proposals. Please don't hesitate to reply if you're interested. Booth: ------ - I'm still trying to figure out the deadline for the registration of a booth. - With 3 days this is a significant time investment. - Needs around 3-4 people to man the booth. - We could share a booth with an other project but we will still need at least 2 persons for that, 3 or more is better. - Let me know if somebody is interested in this. bye michael

9 13

Profiling CS:GO
by Brock York Feb. 6, 2014

Feb. 6, 2014

Hey list I'm trying to find out why CS:GO is slower under wine then windows. When running a benchmark in CS:GO Win8 gets ~134fps and wine ~51fps. I've been following Stefan Dösingers guide ( http://wiki.winehq.org/Performance) and have compiled wined3d for windows and tryed running CS:GO using wined3d under win8 but it just crashes while loading the map. At a guess I'd say once it trys to do 3D rendering. Which brings me to my first question. How do you debug and profile wined3d when using windows? Because when every I tried to run a debugger or attach one under windows or using winedbg the game just crashes when booting. Anti-debug techniques maybe? The second being that when using perf under linux it doens't seem to really be a wined3d problem after all the effort of testing it. Attached is the perf output where is shows most of it's time is spent in the actual csgo.exe code. CS:GO under linux seems to have a lot less cpu utilisation under wine. Win8 65-78% utilisation wine 48-51% utilisation of the cpu. Where should I look next for what's causing the problem? Also I'm really new to wine development. I'm still a uni student. Apologies for anything stupidly obvious I've missed. Regards Brock York.

2 6

Re: kernel32/tests: Add test for FindFirstFileA()
by Dmitry Timoshkov Feb. 6, 2014

Feb. 6, 2014

Zhenbo Li <litimetal(a)gmail.com> wrote: > + strcpy(buffer2, nonexistent); > + handle = CreateFileA(buffer2, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0 ); There is no need for a strcpy(). > + ok(handle != INVALID_HANDLE_VALUE, "failed to create a file\n"); > + handle = FindFirstFileA(buffer2, &data); > + ok(handle != FindFirstFileA, "failed to find an existent file\n"); It would be useful to actually test what FindFirstFileA() returns. Also not leaking the handle *twice* would be a bonus point. -- Dmitry.

2 2