March 2014 - Wine-Devel - list.winehq.org

Need help getting Win32_PNPEntity WMI class added
by Luke A. Guest March 4, 2014

March 4, 2014

Hi, I thought I understood this thing, but I don't. I'm trying to get this working so that I can work towards getting Rocksmith going. I've added: diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 4b02ea2..0051837 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -75,6 +75,8 @@ static const WCHAR class_paramsW[] = {'_','_','P','A','R','A','M','E','T','E','R','S',0}; static const WCHAR class_physicalmediaW[] = {'W','i','n','3','2','_','P','h','y','s','i','c','a','l','M','e','d','i','a',0}; +static const WCHAR class_pnpentityW[] = + {'W','i','n','3','2','_','P','N','P','E','n','t','i','t','y',0}; static const WCHAR class_qualifiersW[] = {'_','_','Q','U','A','L','I','F','I','E','R','S',0}; static const WCHAR class_process_getowner_outW[] = @@ -394,6 +396,10 @@ static const struct column col_physicalmedia[] = { { prop_serialnumberW, CIM_STRING } }; +static const struct column col_pnpentity[] = +{ + { prop_deviceidW, CIM_STRING|COL_FLAG_KEY } +}; static const struct column col_process[] = { { prop_captionW, CIM_STRING|COL_FLAG_DYNAMIC }, @@ -513,6 +519,8 @@ static const WCHAR diskdrive_manufacturerW[] = {'(','S','t','a','n','d','a','r','d',' ','d','i','s','k',' ','d','r','i','v','e','s',')',0}; static const WCHAR diskdrive_serialW[] = {'W','I','N','E','H','D','I','S','K',0}; +static const WCHAR pnpentity_rscableW[] = + {'U','S','B','\ \','V','I','D','_','1','2','B','A','&','P','I','D','_','0','0','F','F','&','R','E','V','_','0','1','0','0',0}; static const WCHAR networkadapter_pnpdeviceidW[]= {'P','C','I','\ \','V','E','N','_','8','0','8','6','&','D','E','V','_','1','0','0','E','&', 'S','U','B','S','Y','S','_','0','0','1','E','8','0','8','6','&','R','E','V','_','0','2','\\', @@ -796,6 +804,10 @@ static const struct record_physicalmedia data_physicalmedia[] = { { diskdrive_serialW } }; +static const struct record_physicalmedia data_pnpentity[] = +{ + { pnpentity_rscableW } +}; static const struct record_qualifier data_qualifier[] = { { class_process_getowner_outW, param_userW, CIM_SINT32, FLAVOR_ID, prop_idW, 0 }, @@ -2241,6 +2253,7 @@ static struct table builtin_classes[] = { class_osW, SIZEOF(col_os), col_os, 0, 0, NULL, fill_os }, { class_paramsW, SIZEOF(col_param), col_param, SIZEOF(data_param), 0, (BYTE *)data_param }, { class_physicalmediaW, SIZEOF(col_physicalmedia), col_physicalmedia, SIZEOF(data_physicalmedia), 0, (BYTE *)data_physicalmedia }, + { class_pnpentityW, SIZEOF(col_pnpentity), col_pnpentity, SIZEOF(data_pnpentity), 0, (BYTE *)data_pnpentity }, { class_processW, SIZEOF(col_process), col_process, 0, 0, NULL, fill_process }, { class_processorW, SIZEOF(col_processor), col_processor, 0, 0, NULL, fill_processor }, { class_qualifiersW, SIZEOF(col_qualifier), col_qualifier, SIZEOF(data_qualifier), 0, (BYTE *)data_qualifier }, With the *_pnpentity* elements being mine. I've hardcoded the USB device hardware ID in for now. I also added a TRACE to get_propval, but that's not being called. Here's the relevant part of the log: 0009:trace:wbemprox:wbem_services_CreateInstanceEnum 0x3cd6b58, L"Win32_PNPEntity", 000000000, (nil), 0x32f858 0009:trace:wbemprox:parse_query parse_query: L"SELECT * FROM Win32_PNPEntity" 0009:trace:wbemprox:parse_query wql_parse returned 0 0009:trace:wbemprox:EnumWbemClassObject_create 0x32f858 0009:trace:wbemprox:EnumWbemClassObject_create returning iface 0x3cd6ea8 0009:trace:wbemprox:enum_class_object_Next 0x3cd6ea8, 10000, 20, 0x32f888, 0x32f864 0009:fixme:wbemprox:enum_class_object_Next timeout not supported 0009:trace:wbemprox:enum_class_object_Release destroying 0x3cd6ea8 0009:trace:wbemprox:wbem_locator_Release destroying 0x3cd6cc8 0009:trace:wbemprox:wbem_services_Release destroying 0x3cd6b58 0009:trace:wbemprox:DllGetClassObject {4590f811-1d3a-11d0-891f-00aa004b2e24} {00000001-0000-0000-c000-000000000046} 0x32f80c 0009:trace:wbemprox:wbemprox_cf_CreateInstance (nil) {dc12a687-737f-11cf-884d-00aa004b2e24} 0x32f85c 0009:trace:wbemprox:WbemLocator_create (0x32f78c) 0009:trace:wbemprox:WbemLocator_create returning iface 0x3cd6b78 0009:trace:wbemprox:wbem_locator_QueryInterface 0x3cd6b78 {dc12a687-737f-11cf-884d-00aa004b2e24} 0x32f85c 0009:trace:wbemprox:wbem_locator_ConnectServer 0x3cd6b78, L"\\\\.\\root\ \cimv2", (null), (null), (null), 0x00000000, (null), (nil), 0x32f860) 0009:trace:wbemprox:WbemServices_create (0x32f860) 0009:trace:wbemprox:WbemServices_create returning iface 0x3cd6f10 Have I missed something here? Thanks, Luke.

2 4

Re: mshtml: Don't use fragment navigation for SuperNavigate calls.
by Marvin March 4, 2014

March 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5364 Your paranoid android. === w8 (32 bit webbrowser) === webbrowser.c:425: Test failed: unexpected nsCmdID 74 webbrowser.c:702: Test failed: V_I4(V_VARIANTREF(flags)) = 100, expected 0x40 or 0 webbrowser.c:442: Test failed: unexpected nCmdID 119 webbrowser.c:454: Test failed: unexpected nCmdID 178 webbrowser.c:454: Test failed: unexpected nCmdID 135 webbrowser.c:425: Test failed: unexpected nsCmdID 74

1 0

Discussion and Improvement of Wine's Linux Force Feedback implementation
by Elias Vanderstuyft March 4, 2014

March 4, 2014

Hi, In the past few weeks I've been reviewing Wine's Linux Force Feedback implementation. I annotated questions and proposals for improvement and bundled them in a file "Improvements.txt". Now, I think it's time to post my results, before someone begins to work on the dinput files I started from (untouched since wine-1.7.11-206-g82b3813). The reason why I don't send this to wine-patches, is because it is more a review and discussion, than a set of actual diff-generated patch files. Because of the rather massive amount of text I've written, I decided to split them up in separate mails in subjects, each containing 3 questions/proposals on average: Subjects [11] ------------- - Joystick control panel program [2] - Linux effect status management [3] - Linux effect parameter: start delay [1] - Linux effect parameter: periodic effect's phase [1] - Linux effect parameters: time parameters [3] - Linux effect: conditional effect's parameters [2] - Linux effect: axes [1] - Linux effect direction [7] - Linux effect parameters (global) [6] - Linux joystick initialization [1] - Debug message fixes/additions [6] I'll send them with the prefix "[RFC x/11] Linux FF: <subject>". Am I allowed to send this? Thanks, Elias

2 1

Drowning in a sea of red
by Jeremy White March 4, 2014

March 4, 2014

Alright, one month from FOSDEM, and I load test.winehq.org, and I'm still drowning in a sea of red. This is shameful. At the very least, all of the test bot vms should be green. How do we fix this? Should I just pick one failure at a time, and publicly shake it, and shame people as best I can? Cheers, Jeremy

1 0

Re: [PATCH 5/5] winex11: Add support for WGL_WINE_make_current extension. (resend)
by Alexandre Julliard March 4, 2014

March 4, 2014

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/winex11.drv/opengl.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d8.dll -p d3d8_test.exe.so device && touch device.ok X Error of failed request: GLXBadDrawable Major opcode of failed request: 153 (GLX) Minor opcode of failed request: 26 (X_GLXMakeContextCurrent) Serial number of failed request: 3303 Current serial number in output stream: 3303 make: *** [device.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Assorted spelling fixes
by Marvin March 4, 2014

March 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5347 Your paranoid android. === w8 (32 bit crypt) === crypt.c:554: Test failed: got 11 expected ERROR_INVALID_PARAMETER

1 0

Re: Assorted spelling fixes
by Marvin March 4, 2014

March 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5346 Your paranoid android. === w8 (32 bit sync) === sync.c:1670: Test failed: SleepConditionVariableCS should still return TRUE on crit unlock delay

1 0

Re: Assorted spelling fixes
by Marvin March 4, 2014

March 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5341 Your paranoid android. === w2000pro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 263 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 264 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 299 (got 'C:\C D', wanted '@pwd@\C D(a)or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 300 (got 'C:\E', wanted '@pwd@\E(a)or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 303 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 304 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 310 (got ''C:\R S'', wanted ''@drive@@shortpath(a)R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 311 (got ''C:\T'', wanted ''@drive@@shortpath(a)T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 312 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath(a)ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 321 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 322 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 335 (got 'C:\C D', wanted '@pwd@\C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 336 (got 'C:\E', wanted '@pwd@\E') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 339 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 340 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 346 (got ''C:\R S'', wanted ''@drive@@shortpath(a)R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 347 (got ''C:\T'', wanted ''@drive@@shortpath(a)T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 348 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath(a)ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 349 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 350 (got 'C:\', wanted '@drive@@path@') batch.c:304: Test failed: excess characters on line 392 (got 'Current dir: C:\foobar', wanted 'Current dir: @pwd@\foobar(a)or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 393 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 395 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 397 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 401 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 402 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 403 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1090 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1092 (got 'C:\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1094 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1099 (got 'A C:\foobar\foo', wanted 'A @pwd@\foobar\foo(a)or_broken@A @pwd@\foobar\foo(a)or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1101 (got 'A R C:\foobar\foo', wanted 'A R @pwd@\foobar\foo(a)or_broken@A R @pwd@\foobar\foo(a)or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1107 (got 'A C:\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2(a)or_broken@A @pwd@\foobar\baz\level2(a)or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1108 (got 'A R C:\foobar\level1', wanted 'A R @pwd@\foobar\level1(a)or_broken@A R @pwd@\foobar\level1(a)or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1109 (got 'A R C:\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2(a)or_broken@A R @pwd@\foobar\baz\level2(a)or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\bar', wanted 'A @pwd@\foobar\bar(a)or_broken@A @pwd@\foobar\bar(a)or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1112 (got ' C:\foobar', wanted ' @pwd@\foobar(a)or_broken@ @pwd@\foobar(a)or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1113 (got ' R C:\foobar\baz', wanted ' R @pwd@\foobar\baz(a)or_broken@ R @pwd@\foobar\baz(a)or_broken@ @pwd@\foobar\baz(a)or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1114 (got 'A C:\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto(a)or_broken@A @pwd@\foobar\baz\toto(a)or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1251 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1253 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1255 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1259 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1261 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1279 (got 'C:\foobar\foodir3', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1284 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1288 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1290 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1295 (got 'C:\foobar', wanted '@pwd@\foobar') === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\Documents and Settings\winetest\My Documents', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 410 (got 'C:\Documents and Settings\winetest>type foobaz ', wanted '@pwd@>type foobaz(a)space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 413 (got 'C:\Documents and Settings\winetest>echo --- ', wanted '@pwd@>echo ---(a)space@') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1168 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1170 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1172 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1174 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1175 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1176 (got 'C:\Documents and Settings\winetest\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1177 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1178 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1179 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1180 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1181 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1183 (got 'A C:\Documents and Settings\winetest\foobar\foo', wanted 'A @pwd@\foobar\foo(a)or_broken@A @pwd@\foobar\foo(a)or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1185 (got 'A R C:\Documents and Settings\winetest\foobar\foo', wanted 'A R @pwd@\foobar\foo(a)or_broken@A R @pwd@\foobar\foo(a)or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1191 (got 'A C:\Documents and Settings\winetest\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2(a)or_broken@A @pwd@\foobar\baz\level2(a)or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1192 (got 'A R C:\Documents and Settings\winetest\foobar\level1', wanted 'A R @pwd@\foobar\level1(a)or_broken@A R @pwd@\foobar\level1(a)or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1193 (got 'A R C:\Documents and Settings\winetest\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2(a)or_broken@A R @pwd@\foobar\baz\level2(a)or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1194 (got 'A C:\Documents and Settings\winetest\foobar\bar', wanted 'A @pwd@\foobar\bar(a)or_broken@A @pwd@\foobar\bar(a)or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1196 (got ' C:\Documents and Settings\winetest\foobar', wanted ' @pwd@\foobar(a)or_broken@ @pwd@\foobar(a)or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1197 (got ' R C:\Documents and Settings\winetest\foobar\baz', wanted ' R @pwd@\foobar\baz(a)or_broken@ R @pwd@\foobar\baz(a)or_broken@ @pwd@\foobar\baz(a)or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1198 (got 'A C:\Documents and Settings\winetest\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto(a)or_broken@A @pwd@\foobar\baz\toto(a)or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1335 (got 'C:\Documents and Settings\winetest\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1337 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1339 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1343 (got 'C:\Documents and Settings\winetest\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1345 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1372 (got 'C:\Documents and Settings\winetest\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 315 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: Assorted spelling fixes
by Marvin March 4, 2014

March 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5339 Your paranoid android. === w2000pro (32 bit shlfolder) === shlfolder.c:557: Test failed: Got 0x80004005 shlfolder.c:601: Test failed: Got 0x80004005 shlfolder.c:627: Test failed: Got 0x80004005

1 0

Re: comctl32/tests: Use BOOL type where appropriate (try 2)
by Nikolay Sivov March 3, 2014

March 3, 2014

On 2/28/2014 13:58, Frédéric Delanoy wrote: > --- > dlls/comctl32/tests/toolbar.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c > index 29c80fb..1206429 100644 > --- a/dlls/comctl32/tests/toolbar.c > +++ b/dlls/comctl32/tests/toolbar.c > @@ -42,8 +42,8 @@ static struct msg_sequence *sequences[NUM_MSG_SEQUENCES]; > static HWND hMainWnd; > static BOOL g_fBlockHotItemChange; > static BOOL g_fReceivedHotItemChange; > -static BOOL g_fExpectedHotItemOld; > -static BOOL g_fExpectedHotItemNew; > +static int g_fExpectedHotItemOld; > +static int g_fExpectedHotItemNew; > static DWORD g_dwExpectedDispInfoMask; > static BOOL g_ResetDispTextPtr; This is correct. > > @@ -623,12 +623,12 @@ static void test_hotitem(void) > g_fReceivedHotItemChange = FALSE; > ret = SendMessageA(hToolbar, TB_SETHOTITEM, 0xbeaf, 0); > ok(ret == 3, "TB_SETHOTITEM returned %ld, expected 3\n", ret); > - ok(g_fReceivedHotItemChange == FALSE, "TBN_HOTITEMCHANGE received for invalid parameter\n"); > + ok(!g_fReceivedHotItemChange, "TBN_HOTITEMCHANGE received for invalid parameter\n"); And this is not better than it was. I prefer original patch, with variable type fixes only.

1 0

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries (resend)
by Marvin March 3, 2014

March 3, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5094 Your paranoid android. === w2000pro (32 bit package) === package.c:3945: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3951: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3957: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3969: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3975: Test failed: Expected "C:\\", got "C:\" package.c:3981: Test failed: Expected "C:\\", got "C:\" package.c:3997: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4008: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4467: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4559: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4570: Test failed: Expected "C:\\", got "C:\" package.c:4581: Test failed: Expected "C:\\", got "C:\" package.c:4631: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4642: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4657: Test failed: Expected "C:\\", got "C:\" package.c:4662: Test failed: Expected "", got "C:\" package.c:4678: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4937: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4948: Test failed: Expected "C:\\", got "C:\" package.c:4954: Test failed: Expected "C:\\", got "C:\" package.c:4975: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4986: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5226: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5232: Test failed: Expected "C:\\", got "C:\" package.c:5249: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5260: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5268: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5612: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6244: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6268: Test failed: Expected C:\\ or empty string, got C:\ package.c:6312: Test failed: Expected C:\\ or empty string, got C:\ package.c:6321: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6551: Test failed: Expected "C:\\", got "C:\" package.c:6552: Test failed: Expected 4, got 3 package.c:6559: Test failed: Expected "C:\\", got "C:\" package.c:6560: Test failed: Expected 4, got 3 package.c:6576: Test failed: Expected "C:\\", got "C:\" package.c:6577: Test failed: Expected 4, got 3 package.c:6583: Test failed: Expected "C:\\", got "C:\" package.c:6584: Test failed: Expected 4, got 3 package.c:6591: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6592: Test failed: Expected 14, got 13 package.c:6599: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6600: Test failed: Expected 19, got 18 package.c:6610: Test failed: Expected "C:\\", got "C:\" package.c:6611: Test failed: Expected 4, got 3 package.c:6618: Test failed: Expected "C:\\", got "C:\" package.c:6619: Test failed: Expected 4, got 3 package.c:6635: Test failed: Expected "C:\\", got "C:\" package.c:6636: Test failed: Expected 4, got 3 package.c:6642: Test failed: Expected "C:\\", got "C:\" package.c:6643: Test failed: Expected 4, got 3 package.c:6650: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6651: Test failed: Expected 14, got 13 package.c:6658: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6659: Test failed: Expected 19, got 18 package.c:6669: Test failed: Expected "C:\\", got "C:\" package.c:6670: Test failed: Expected 4, got 3 package.c:6677: Test failed: Expected "C:\\", got "C:\" package.c:6678: Test failed: Expected 4, got 3 package.c:6694: Test failed: Expected "C:\\", got "C:\" package.c:6695: Test failed: Expected 4, got 3 package.c:6701: Test failed: Expected "C:\\", got "C:\" package.c:6702: Test failed: Expected 4, got 3 package.c:6709: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6710: Test failed: Expected 14, got 13 package.c:6717: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6718: Test failed: Expected 19, got 18 package.c:6728: Test failed: Expected "C:\\", got "C:\" package.c:6729: Test failed: Expected 4, got 3 package.c:6736: Test failed: Expected "C:\\", got "C:\" package.c:6737: Test failed: Expected 4, got 3 package.c:6753: Test failed: Expected "C:\\", got "C:\" package.c:6754: Test failed: Expected 4, got 3 package.c:6760: Test failed: Expected "C:\\", got "C:\" package.c:6761: Test failed: Expected 4, got 3 package.c:6768: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6769: Test failed: Expected 14, got 13 package.c:6776: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6777: Test failed: Expected 19, got 18 package.c:6792: Test failed: Expected 4, got 3 package.c:6809: Test failed: Expected 4, got 3 package.c:6815: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6818: Test failed: Expected 4, got 3 package.c:6825: Test failed: Expected "C:\\", got "C:\" package.c:6826: Test failed: Expected 4, got 3 package.c:6837: Test failed: Expected "C:\\", got "C:\" package.c:6838: Test failed: Expected 4, got 3 package.c:6933: Test failed: Expected "C:\\", got "C:\" package.c:6934: Test failed: Expected 4, got 3 package.c:6941: Test failed: Expected "C:\\", got "C:\" package.c:6942: Test failed: Expected 4, got 3 package.c:6951: Test failed: Expected "C:\\", got "C:\" package.c:6952: Test failed: Expected 4, got 3 package.c:6960: Test failed: Expected "C:\\", got "C:\" package.c:6961: Test failed: Expected 4, got 3 package.c:6967: Test failed: Expected "C:\\", got "C:\" package.c:6968: Test failed: Expected 4, got 3 package.c:6975: Test failed: Expected "C:\\", got "C:\" package.c:6976: Test failed: Expected 4, got 3 package.c:6983: Test failed: Expected "C:\\", got "C:\" package.c:6984: Test failed: Expected 4, got 3 package.c:6994: Test failed: Expected "C:\\", got "C:\" package.c:6995: Test failed: Expected 4, got 3 package.c:7002: Test failed: Expected "C:\\", got "C:\" package.c:7003: Test failed: Expected 4, got 3 package.c:7012: Test failed: Expected "C:\\", got "C:\" package.c:7013: Test failed: Expected 4, got 3 package.c:7021: Test failed: Expected "C:\\", got "C:\" package.c:7022: Test failed: Expected 4, got 3 package.c:7028: Test failed: Expected "C:\\", got "C:\" package.c:7029: Test failed: Expected 4, got 3 package.c:7036: Test failed: Expected "C:\\", got "C:\" package.c:7037: Test failed: Expected 4, got 3 package.c:7044: Test failed: Expected "C:\\", got "C:\" package.c:7045: Test failed: Expected 4, got 3 package.c:7055: Test failed: Expected "C:\\", got "C:\" package.c:7056: Test failed: Expected 4, got 3 package.c:7063: Test failed: Expected "C:\\", got "C:\" package.c:7064: Test failed: Expected 4, got 3 package.c:7073: Test failed: Expected "C:\\", got "C:\" package.c:7074: Test failed: Expected 4, got 3 package.c:7082: Test failed: Expected "C:\\", got "C:\" package.c:7083: Test failed: Expected 4, got 3 package.c:7089: Test failed: Expected "C:\\", got "C:\" package.c:7090: Test failed: Expected 4, got 3 package.c:7097: Test failed: Expected "C:\\", got "C:\" package.c:7098: Test failed: Expected 4, got 3 package.c:7105: Test failed: Expected "C:\\", got "C:\" package.c:7106: Test failed: Expected 4, got 3 package.c:7116: Test failed: Expected "C:\\", got "C:\" package.c:7117: Test failed: Expected 4, got 3 package.c:7124: Test failed: Expected "C:\\", got "C:\" package.c:7125: Test failed: Expected 4, got 3 package.c:7134: Test failed: Expected "C:\\", got "C:\" package.c:7135: Test failed: Expected 4, got 3 package.c:7143: Test failed: Expected "C:\\", got "C:\" package.c:7144: Test failed: Expected 4, got 3 package.c:7150: Test failed: Expected "C:\\", got "C:\" package.c:7151: Test failed: Expected 4, got 3 package.c:7158: Test failed: Expected "C:\\", got "C:\" package.c:7159: Test failed: Expected 4, got 3 package.c:7166: Test failed: Expected "C:\\", got "C:\" package.c:7167: Test failed: Expected 4, got 3 package.c:7264: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7265: Test failed: Expected 9, got 8 package.c:7274: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7275: Test failed: Expected 9, got 8 package.c:7284: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7285: Test failed: Expected 9, got 8 package.c:7296: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7297: Test failed: Expected 8, got 7 package.c:7308: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7309: Test failed: Expected 9, got 8 package.c:7320: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7321: Test failed: Expected 8, got 7 package.c:7332: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7333: Test failed: Expected 10, got 9 package.c:7344: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7345: Test failed: Expected 8, got 7 package.c:7356: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7357: Test failed: Expected 11, got 10 package.c:7408: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7409: Test failed: Expected 10, got 9 package.c:7418: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7419: Test failed: Expected 10, got 9 package.c:7428: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7429: Test failed: Expected 10, got 9 package.c:7440: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7441: Test failed: Expected 8, got 7 package.c:7452: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7453: Test failed: Expected 10, got 9 package.c:7464: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7465: Test failed: Expected 9, got 8 package.c:7476: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7477: Test failed: Expected 10, got 9 package.c:7488: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7489: Test failed: Expected 9, got 8 package.c:7500: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7501: Test failed: Expected 11, got 10 package.c:7637: Test failed: Expected "C:\\", got "C:\" package.c:7638: Test failed: Expected 4, got 3 package.c:7649: Test failed: Expected "C:\\", got "C:\" package.c:7650: Test failed: Expected 4, got 3 package.c:7657: Test failed: Expected "C:\\", got "C:\" package.c:7658: Test failed: Expected 4, got 3 package.c:7755: Test failed: Expected "C:\\", got "C:\" package.c:7756: Test failed: Expected 4, got 3 package.c:7763: Test failed: Expected "C:\\", got "C:\" package.c:7764: Test failed: Expected 4, got 3 package.c:7771: Test failed: Expected "C:\\", got "C:\" package.c:7772: Test failed: Expected 4, got 3 package.c:7791: Test failed: Expected "C:\\", got "C:\" package.c:7792: Test failed: Expected 4, got 3 package.c:7799: Test failed: Expected "C:\\", got "C:\" package.c:7800: Test failed: Expected 4, got 3 package.c:7819: Test failed: Expected "C:\\", got "C:\" package.c:7820: Test failed: Expected 4, got 3 package.c:7827: Test failed: Expected "C:\\", got "C:\" package.c:7828: Test failed: Expected 4, got 3 package.c:7847: Test failed: Expected "C:\\", got "C:\" package.c:7848: Test failed: Expected 4, got 3 package.c:7855: Test failed: Expected "C:\\", got "C:\" package.c:7856: Test failed: Expected 4, got 3

2 2

Re: [PATCH 1/5] d3dx9: Turn D3DXCreateEffectEx FIXME into a TRACE, improve it a bit.
by Henri Verbeet March 3, 2014

March 3, 2014

On 3 March 2014 16:28, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/d3dx9_36/effect.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index a4325af..0ec17c1 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -5294,8 +5294,10 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s > struct ID3DXEffectImpl *object; > HRESULT hr; > > - FIXME("(%p, %p, %u, %p, %p, %p, %#x, %p, %p, %p): semi-stub\n", device, srcdata, srcdatalen, defines, include, > - skip_constants, flags, pool, effect, compilation_errors); > + TRACE("device %p, srcdata %p, srcdatalen %u, defines %p, include %p,\n", > + device, srcdata, srcdatalen, defines, include); > + TRACE("skip_constants %p, flags %#x, pool %p, effect %p, compilation_errors %p.\n", > + skip_constants, flags, pool, effect, compilation_errors); > Mostly just FWIW, I think it's generally nicer to keep that as a single TRACE.

2 2

gihanshanuka20@gmail.com has indicated you're a friend. Accept?
by gihanshanuka20＠gmail.com March 3, 2014

March 3, 2014

Hi, gihanshanuka20(a)gmail.com wants to follow you. ****** Is gihanshanuka20(a)gmail.com you friend? ****** If Yes please follow the link below: http://invites.fliporamail.com/signup_e.html?fullname=Gihanshanuka20+Achala… If No please follow the link below: http://invites.fliporamail.com/signup_e.html?fullname=Gihanshanuka20+Achala… Follow the link below to remove yourself from all such emails http://invites.fliporamail.com/uns.jsp?email=wine-devel(a)winehq.org&iid=30…

1 0

Re: [PATCH 2/6] wininet: Added support for MSG_DONTWAIT to secure NETCON_recv.
by Alexandre Julliard March 3, 2014

March 3, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/netconnection.c | 82 > ++++++++++++++++++++++++++++++-------------- > 1 file changed, 56 insertions(+), 26 deletions(-) This breaks the Windows build (missing MSG_DONTWAIT). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: fonts: Add Liberation Sans (SIL Open Font License) as an Arialreplacement.
by Mariusz Wawrzyński March 3, 2014

March 3, 2014

thank you very much for message. I do not know NET platform. Dnia 27 lutego 2014 23:14 "Erich E. Hoover" <erich.e.hoover(a)gmail.com> napisał(a): The attached patch adds the Arial font (arial.ttf) using version 2.00.1 of the Liberation Sans font. The Liberation Sans font is licensed under the SIL Open Font License, which is, to the best of my knowledge, compatible with our other license restrictions. This patch fixes an issue where several Silveright and .NET applications expect either Arial or Verdana to be installed on the system (Bug #32323).

2 1

Re: [PATCH 1/6] wininet: Fixed tests for the new winehq.org cert.
by Marvin March 3, 2014

March 3, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5325 Your paranoid android. === w2000pro (32 bit http) === http.c:4477: Test failed: HttpSendRequest failed: 12037 http.c:4482: Test failed: expected secure flag to be set http.c:4536: Test failed: HttpSendRequest failed: 12037 http.c:4541: Test failed: expected secure flag to be set, got 0 === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4308: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4308: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4311: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4311: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4477: Test failed: HttpSendRequest failed: 12037 http.c:4482: Test failed: expected secure flag to be set http.c:4076: Test failed: dwKeySize = 0 http.c:4513: Test failed: expected a non-zero key size http.c:4536: Test failed: HttpSendRequest failed: 12037 http.c:4541: Test failed: expected secure flag to be set, got 0 http.c:4565: Test failed: expected a non-zero key size http.c:4597: Test failed: expected a non-zero key size http.c:4636: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

1 0

Re: kernel32/time: Implement GetSystemTimes using /proc/stat.
by André Hentschel March 3, 2014

March 3, 2014

Am 03.03.2014 14:44, schrieb Bernard Ladenthin: > Hi André, > > you wrote me a few suggestions for my patch at 29.09.2013 20:08. > > I wrote a new patch and tried it three times, the patch is always > "pending". Maybe you can examine the patch and write to me what is > wrong? Thank you for any help. > > http://source.winehq.org/patches/data/102340 > > From: Bernard Ladenthin <bernard.ladenthin(a)gmail.com> > Subject: kernel32/time: Implement GetSystemTimes using /proc/stat. > Message-Id: <52F9075B.4000601(a)gmail.com> > Date: Mon, 10 Feb 2014 18:07:39 +0100 mostly code style, spaces, variable names, variable types think about the use of ERR, FIXME, WARN, TRACE

1 0

Re: patch:add HANDLE
by Nikolay Sivov March 3, 2014

March 3, 2014

On 3/3/2014 16:32, Akira Nakagawa wrote: > It was a little hurtful that you have said... > what did you mean of "dead code"? I mean that code that your patch adds is not used. > > I've checked Windows itself uses it as public handle. What does a public handle mean and what did you check exactly? > My patch is not enough,you say,to be send,then I send after finished > eventlog functions works. You shouldn't send everything as one patch either, it needs to be incremental but without dead parts. Please CC wine-devel(a)winehq.org if you want my reply. > 2014年3月3日月曜日、Nikolay Sivov<bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>> さんは書きました: > > On 3/2/2014 15:18, 中川祥 wrote: >> Hum? >> I thought all the HANDLEs are hosted by server. > I don't think you need event log handles to be handled by server, > I'd rather had a service handling them. >> Hence,I did. >> It need be hosted by server because you need to distinguish one >> eventlog from the ohter,any way. >> > I'm not sure I follow you here.Anyway, you'll need some plan for > all parts involved (advapi32, logging service, something else?) > before sending such dead code patches. > > Please keep wine-devel CC. >> 2014年3月2日日曜日、Nikolay Sivov<bunglehead(a)gmail.com >> <javascript:_e(%7B%7D,'cvml','bunglehead(a)gmail.com');>> さんは書 >> きました: >> >> On 3/2/2014 14:13, 中川祥 wrote: >>> Handle for eventlog. >>> It is different from event. >>> It's almost same as hfile,but more info needed. >>> Is it implemented? >> What event log API are you talking about? Why does this >> handle have to be maintained by a server? >>> >>> >>> 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com>: >>> >>> On 3/2/2014 10:44, Akira Nakagawa wrote: >>> >>> What's that about? >>> >>> >> >

1 0

About GSoC 2014
by Nemina Amarasinghe March 3, 2014

March 3, 2014

Hi, I am willing to participate GSoC this year. I looked through the accepted organization list and I'm interested in wine. So I would like to know how to connect with mentors to get more details. I would really appreciate if someone help me to get above information Best regards, Nemina

2 1

Re: patch:add HANDLE
by Nikolay Sivov March 3, 2014

March 3, 2014

On 3/2/2014 15:18, 中川祥 wrote: > Hum? > I thought all the HANDLEs are hosted by server. I don't think you need event log handles to be handled by server, I'd rather had a service handling them. > Hence,I did. > It need be hosted by server because you need to distinguish one > eventlog from the ohter,any way. > I'm not sure I follow you here.Anyway, you'll need some plan for all parts involved (advapi32, logging service, something else?) before sending such dead code patches. Please keep wine-devel CC. > 2014年3月2日日曜日、Nikolay Sivov<bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>> さんは書きました: > > On 3/2/2014 14:13, 中川祥 wrote: >> Handle for eventlog. >> It is different from event. >> It's almost same as hfile,but more info needed. >> Is it implemented? > What event log API are you talking about? Why does this handle > have to be maintained by a server? >> >> >> 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com >> <javascript:_e(%7B%7D,'cvml','bunglehead(a)gmail.com');>>: >> >> On 3/2/2014 10:44, Akira Nakagawa wrote: >> >> What's that about? >> >> >

1 0

Re: dpnet: Check if DirectDplay is installed
by Marvin March 2, 2014

March 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5312 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: patch:add HANDLE
by Nikolay Sivov March 2, 2014

March 2, 2014

On 3/2/2014 14:13, 中川祥 wrote: > Handle for eventlog. > It is different from event. > It's almost same as hfile,but more info needed. > Is it implemented? What event log API are you talking about? Why does this handle have to be maintained by a server? > > > 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>>: > > On 3/2/2014 10:44, Akira Nakagawa wrote: > > What's that about? > >

1 0

Re: patch:add HANDLE
by Nikolay Sivov March 2, 2014

March 2, 2014

On 3/2/2014 10:44, Akira Nakagawa wrote: What's that about?

1 0

Re: [PATCH 3/3] gdiplus/tests: Added tests for GdipCreateStreamOnFile.
by Dmitry Timoshkov March 2, 2014

March 2, 2014

Qian Hong <qhong(a)codeweavers.com> wrote: > +static void test_gdipstream(void) > +{ > + IStream *stream; > + WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'}; > + WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'}; > + GpStatus stat; > + HANDLE hfile; > + > + hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n"); Same problem with temp files in current directory. > + stream = (IStream *)0xdeadcafe; > + stat = GdipCreateStreamOnFile(nonexistentW, GENERIC_READ, &stream); > + todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat); > + todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream); > + > + stream = (IStream *)0xdeadcafe; > + stat = GdipCreateStreamOnFile(nonshareW, GENERIC_READ, &stream); > + todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat); > + todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream); > + > + CloseHandle(hfile); > +} Please use common 0xdeadbeef instead of new inventions. -- Dmitry.

1 0

Re: [PATCH 1/3] gdiplus/tests: Added more tests for image loading functions.
by Dmitry Timoshkov March 2, 2014

March 2, 2014

Qian Hong <qhong(a)codeweavers.com> wrote: > + WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'}; > + WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'}; > + HANDLE hfile; > + > + hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n"); Please use official temporary storage instead of creating files in current directory. -- Dmitry.

1 0