March 2014 - Wine-Devel - list.winehq.org

About GSoC - The Wine Project
by SpedsT . March 15, 2014

March 15, 2014

Hello. I want to apply to this project and I have a question about this note: * Note: Beginning with Summer of Code 2014, applicants *MUST* have submitted a patch or testcase to wine-patches (see http://wiki.winehq.org/SubmittingPatches) to be considered for acceptance. What kind of patch or testcase should I submit, what would you like to be about?

2 1

Re: gdiplus: Use BOOL type where appropriate
by Vincent Povirk March 15, 2014

March 15, 2014

On Sat, Mar 15, 2014 at 9:44 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - rotate_90 = type&1; > + rotate_90 = (type & 1) != 0; > flip_x = (type&6) == 2 || (type&6) == 4; > flip_y = (type&3) == 1 || (type&3) == 2; If you must change the style, I prefer (type&1) == 1 here, as it has fewer negatives and matches the lines after it.

1 0

Re: mshtml: Added IHTMLTableRow::rowIndex property implementation.
by Zhenbo Li March 15, 2014

March 15, 2014

Sorry, I sent the same patch twice due to network problem. Please ignore the second one. Thank you. 2014-03-15 11:23 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/mshtml/htmltablerow.c | 11 +++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH 2/2] wined3d: Re-use old wined3d_private_data structures if the size matches.
by Henri Verbeet March 14, 2014

March 14, 2014

On 14 March 2014 14:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if ((old = wined3d_private_store_get_private_data(store, guid)) && old->size == data_size) > + { > + IUnknown *release = NULL; > + if (old->flags & WINED3DSPD_IUNKNOWN) > + release = old->content.object; > + memcpy(old->content.data, ptr, data_size); > + old->flags = flags; > + if (flags & WINED3DSPD_IUNKNOWN) > + IUnknown_AddRef(old->content.object); > + if (release) > + IUnknown_Release(release); > + return WINED3D_OK; > + } What is the motivation for this? It certainly doesn't make the code any prettier.

2 1

Re: [3/3] gdiplus: Limit image output to the bounds of the Graphics object.
by Vincent Povirk March 14, 2014

March 14, 2014

Don't commit this one. I messed up the case where output is fully outside the Graphics object bounds. On Thu, Mar 13, 2014 at 4:49 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >

1 0

Re: [PATCH] winedump: Improve typelib header dumping
by Jacek Caban March 14, 2014

March 14, 2014

Hi Nikolay, On 03/14/14 14:48, Nikolay Sivov wrote: > + if (flags & 1) > + printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0); > + flags >>= 1; i should be increased on each iteration, not only when the flag is found. Cheers, Jacek

1 1

Re: [PATCH] msxml3: Fix some test failures on Win8.1
by Alexandre Julliard March 13, 2014

March 13, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/msxml3/schema.c | 9 +++++++-- > dlls/msxml3/tests/domdoc.c | 28 +++++++++++++++++----------- > 2 files changed, 24 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M msxml3.dll -p msxml3_test.exe.so schema && touch schema.ok schema.c:1526: Test failed: got 0x80004003, expected 0x80004001 make: *** [schema.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: vbscript: Allow empty brackets in argument declarations.
by Marvin March 13, 2014

March 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5671 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: shell32: Supply a module name to CreateProcess (try 5)
by Alexandre Julliard March 13, 2014

March 13, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Corrected the accidental line being removed. > > Changelog: > shell32: Supply a module name to CreateProcess It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlexec && touch shlexec.ok Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 10, but got 10 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params20", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="p"): the cmdline is '(null)' instead of ' "p0"' shlexec.c:1457: Test failed: argvA4 expected 'p0', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="'p2 p3` p4\ $even"): the cmdline is '(null)' instead of ' "'p2" "p3`" "p4\" "$even" ""' shlexec.c:1457: Test failed: argvA4 expected ''p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3`', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p=2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p-3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA9 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA10 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 Fatal: test 'file.shlexec' does not exist. etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20/tests: Fix a SysAllocString leak
by Nikolay Sivov March 13, 2014

March 13, 2014

On 3/12/2014 19:36, Jactry Zeng wrote: > I made this leak, sorry.. :( > "What goes around comes around" was confirmed! :p > VariantInit(&testfile); > V_VT(&testfile) = VT_BSTR; > V_BSTR(&testfile) = SysAllocString(filename); No need for VariantInit() here. > + SysFreeString(V_BSTR(&testfile)); It's cleaner to use VariantClear().

2 1

Re: [PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.
by Qian Hong March 13, 2014

March 13, 2014

Hi Jacek, + + hres = get_frame_by_name(top_window, target, TRUE, &ret_window); + if(FAILED(hres) || !window) { + *use_new_window = TRUE; + return NULL; + } Is there a typo here? Is "!window" suppose to be "!ret_window"? Thanks for the work!

2 1

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation (try2)
by Alexandre Julliard March 13, 2014

March 13, 2014

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL)) > + return c; You'd also have to handle the case of the length being just 1. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation
by Alexandre Julliard March 13, 2014

March 13, 2014

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!MultiByteToWideChar(locinfo->lc_codepage, > + MB_ERR_INVALID_CHARS, (char*)str, p-str, &wide, 1)) > + return c; > + > + lower = tolowerW(wide); > + if(lower == wide) > + return str[0] + (str[1]<<8); > + > + WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL); You should probably also check the resulting length here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/5] d3d8/tests: Move some stateblock tests to device.c.
by Marvin March 13, 2014

March 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5656 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0005025E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x411180, got 0x411180.

1 0

Re: TestBot job 5654 results: [PATCH] msxml3: Respect stylesheet output mode when dumping resulting document
by Nikolay Sivov March 13, 2014

March 13, 2014

On 3/13/2014 15:41, Marvin wrote: > > === w8 (32 bit domdoc) === > > msxml3: > domdoc.c:10385: Test failed: got 00000000 > domdoc.c:10399: Test failed: got 00000000 > domdoc.c:10451: Test failed: got 0 > domdoc.c:10476: Test failed: got 00000000 > domdoc.c:10550: Test failed: got 00000000 > domdoc.c:10565: Test failed: got 00000000 > domdoc.c:10619: Test failed: got 0 > domdoc.c:11268: Test failed: got 00000000 > domdoc.c:11294: Test failed: got 00000000 This is unrelated, I'll send a patch.

1 0

Re: [PATCH] msxml3: Respect stylesheet output mode when dumping resulting document
by Marvin March 13, 2014

March 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5654 Your paranoid android. === w8 (32 bit domdoc) === domdoc.c:10385: Test failed: got 00000000 domdoc.c:10399: Test failed: got 00000000 domdoc.c:10451: Test failed: got 0 domdoc.c:10476: Test failed: got 00000000 domdoc.c:10550: Test failed: got 00000000 domdoc.c:10565: Test failed: got 00000000 domdoc.c:10619: Test failed: got 0 domdoc.c:11268: Test failed: got 00000000 domdoc.c:11294: Test failed: got 00000000

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLDocument7 stub implementation.
by Alexandre Julliard March 13, 2014

March 13, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > Due to how tests are written, we need to switch to IWebBrowserPriv2IE9 > in the same patch. > > --- > dlls/ieframe/ieframe.h | 2 +- > dlls/ieframe/navigate.c | 104 +---- > dlls/mshtml/Makefile.in | 1 + > dlls/mshtml/htmldoc.c | 4 + > dlls/mshtml/htmldoc7.c | 939 +++++++++++++++++++++++++++++++++++++++++++ Merging htmldoc3 and htmldoc5 was a good start, couldn't we do this with the rest of the htmldoc implementations too? There are way too many files in that dll already. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: schedsvc: Add Task Scheduler service. Try 2.
by Dmitry Timoshkov March 13, 2014

March 13, 2014

Hi, Is there a reason why this patch is marked as 'pending'? -- Dmitry.

2 16

Glorious winetestbot results, why this matters
by Jeremy White March 13, 2014

March 13, 2014

So here's today's data: http://www.winehq.org/~jwhite/31faed571d5a.html The main changes are the addition of some new failures in mshtml; failures that Marvin actually pointed out here: http://www.winehq.org/pipermail/wine-devel/2014-March/103419.html The glorious result is that if I get to publicly shame anyone, it's both Jacek and Alexandre. For someone with my JR, that's a rare opportunity <grin>. But really, it illustrates the problem: Alexandre does not trust the new test bot results, so he did not wait for testbot review of patches, and so he did not catch a problem. We need to restore that trust. That's why this matters. Cheers, Jeremy p.s. Looks like Francois's patch has fixed winmm:mci (yay!), and a few tests that my script felt were 'solved' have proven themselves to be actually intermittent (comctl:propsheet and user32:listbox)

5 5

[RFC 5/11] Linux FF: Linux effect parameters: time parameters
by Elias Vanderstuyft March 12, 2014

March 12, 2014

a) Because of the higher time resolution of DInput parameters (in microseconds instead of milliseconds), e.g. dwPeriod, and because truncating may result in "periodic.period == 0", while "1 <= dwPeriod (non-zero) < 1000", and because "periodic.period == 0" is an invalid argument, we might set periodic.period to the smallest non-zero value (that is 1) when dwPeriod is non-zero, to avoid unnecessary exceptions. So change in dinput/effect_linuxinput.c:488 : This->effect.u.periodic.period = tsp->dwPeriod / 1000; to : if (0 < tsp->dwPeriod && tsp->dwPeriod <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = tsp->dwPeriod / 1000; b) Anticipate if dwPeriod < 0, otherwise periodic.period will incorrectly wrap around because it's unsigned. We can choose to let periodic.period be proportional to: - 0 (driver will generate EINVAL) - abs(dwPeriod) (no error, and is mathematically more correct) Choosing the latter, so change in dinput/effect_linuxinput.c:488 : if (0 < tsp->dwPeriod && tsp->dwPeriod <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = tsp->dwPeriod / 1000; to : if (tsp->dwPeriod && abs(tsp->dwPeriod) <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = abs(tsp->dwPeriod) / 1000; c) Something similar is needed for 'dwDuration': Set infinite replay-length in linux by "replay.length == 0": discussion: http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08459.html Knowing that DInput "INFINITE == -1", we convert -1 to 0. If "peff->dwDuration == 0", we can: - not start the effect - set the effect duration to the absolute minimum I would choose the latter, because otherwise more behaviour of the code would change. And lastly, we don't throw exceptions when "dwDuration < 0": MSDN does not require us to throw DIERR_INVALIDPARAM. So, change in dinput/effect_linuxinput.c:191 : if (dwFlags & DIEP_DURATION) { peff->dwDuration = (DWORD)This->effect.replay.length * 1000; } to : if (dwFlags & DIEP_DURATION) { peff->dwDuration = (This->effect.replay.length ? (DWORD)This->effect.replay.length * 1000 : -1); } And change in dinput/effect_linuxinput.c:424 : if (dwFlags & DIEP_DURATION) This->effect.replay.length = peff->dwDuration / 1000; to : if (dwFlags & DIEP_DURATION) { if (peff->dwDuration == -1) This->effect.replay.length = 0; // Infinity else if (peff->dwDuration > 1000) This->effect.replay.length = peff->dwDuration / 1000; else This->effect.replay.length = 1; // Smallest non-zero value } Elias

2 4

[RFC 2/11] Linux FF: Linux effect status management
by Elias Vanderstuyft March 12, 2014

March 12, 2014

a) This is a bug that is either the responsibility of the Linux kernel, or of Wine: It is caused by the following situation: When uploading an effect, the specific kernel device driver may return an error, e.g. EINVAL for example when a periodic's effect period is set to zero. This error will then be returned by "ioctl(*(This->fd), EVIOCSFF, &This->effect)". With or without error, one can find out that /drivers/input/ff-core.c:input_ff_upload(...) is called, which will set effect->id >= 0, if it was set to -1 (=> new effect created) by the user. But in case of an error: - Assume effect->id was set to -1 by the user: The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will also be set >= 0 (*). The offending effect will not be saved in the ff->effects[] array (***). - Assume effect->id was set >= 0 by the user (and ff->effects[effect->id] is a valid existing effect): The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will remain unchanged (**). The offending effect will not overwrite the ff->effects[effect->id] element (****). Is this (see *, **, *** and ****) desired behavior? - If yes: Change the following in Wine's dinput/effect_linuxinput.c:84 : LinuxInputEffectImpl *This = impl_from_IDirectInputEffect(iface); TRACE("(this=%p)\n", This); if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { to : LinuxInputEffectImpl *This = impl_from_IDirectInputEffect(iface); int effectId_old; TRACE("(this=%p)\n", This); effectId_old = This->effect.id; if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { This->effect.id = effectId_old; - If no for *: Kernel code /drivers/input/ff-core.c:input_ff_upload(...) has to be patched to revert "effect->id" back to its original value set by the user, which is only needed when the initial (by user) value of "effect->id" was equal to -1. - If no for **** (or maybe also ***): ff->effects[effect->id] could be replaced by an 'empty' effect (however this can get complex because the effect's type has to remain unchanged) This would be a change in the kernel code /drivers/input/ff-core.c:input_ff_upload(...). - If no for **: I don't really know. Discussion is needed. - In my opinion, **, *** and **** are desired behavior, while * should leave the effect->id at -1. In that case, Wine's dinput implementation does not have to be patched, and the kernel code only should apply a minor patch. => This has been discussed (see http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08513.html) and the following is true: My opinion appeared to be correct, but for to be sure, I was recommended to apply the change in Wine as well. b) Be more precise in returning errors. In dinput/effect_linuxinput.c:89, change : if (errno == ENOMEM) { return DIERR_DEVICEFULL; } else { FIXME("Could not upload effect. Assuming a disconnected device %d \"%s\".\n", *This->fd, strerror(errno)); return DIERR_INPUTLOST; } to : switch (errno) { case EINVAL: TRACE("Could not upload effect: Invalid argument.\n"); return DIERR_INVALIDPARAM; case ENOSPC: TRACE("Could not upload effect: No space left on device.\n"); return DIERR_DEVICEFULL; case ENOMEM: TRACE("Could not upload effect: Out of memory.\n"); return DIERR_OUTOFMEMORY; default: FIXME("Could not upload effect. Assuming a disconnected device %d \"%s\".\n", *This->fd, strerror(errno)); return DIERR_INPUTLOST; } c) The following in dinput/effect_linuxinput.c:336 : if (res != DI_OK) should be probably : if (FAILED(res)) for example if a device reports S_FALSE because it has already updated an identical effect. The same for line 549: if (retval != DI_OK) should be then : if (FAILED(retval)) Elias

2 4

Re: [5/6] user32: Set capture on the owner of popup menus.
by Alexandre Julliard March 12, 2014

March 12, 2014

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -2057,6 +2057,19 @@ BOOL CDECL X11DRV_ScrollDC( HDC hdc, INT dx, INT dy, HRGN update ) > } > > > +BOOL CALLBACK find_popup_menu_window(HWND hwnd, LPARAM lparam) > +{ > + HWND *result = (HWND*)lparam; > + > + if (GetClassLongW(hwnd, GCW_ATOM) == MAKEINTATOM(32768)) > + { > + *result = hwnd; > + return FALSE; > + } That's ugly and unreliable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] d3d8/tests: Test GetPrivateData size behavior.
by Marvin March 12, 2014

March 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5629 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000901BC, got 00010048.

1 0

Re: [PATCH 4/5] d3d8/tests: Use a custom GUID for the private data tests.
by Marvin March 12, 2014

March 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5628 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000401E4, got 00010048. device.c:3038: Test failed: Expected wndproc 0x40fa10, got 0x40fa10.

1 0

Valve has released a Direct3D to OpenGL translator (for a subset of Direct3D 9.0c)
by Artem S. Tashkinov March 12, 2014

March 12, 2014

Hi, Just wanted to let everyone know that Valve has released a Direct3D to OpenGL translator (for a subset of Direct3D 9.0c). More here: https://github.com/ValveSoftware/ToGL I don't know if it's of any use for Wine development however. The license is as permissive as possible - in short Valve allows to do anything with their code. Artem

2 1