March 2014 - Wine-Devel - list.winehq.org

[RFC 6/11] Linux FF: Linux effect: conditional effect's parameters
by Elias Vanderstuyft March 9, 2014

March 9, 2014

a) There is some ambiguity about the range of the following Linux ff_condition_effect struct members: right_saturation, left_saturation and deadband They are all __u16, but /include/uapi/linux/input.h does not say what the maximum values are. I'm doing a proposal to define and document this (in the Linux kernel) in the following way, also take a look at "interactive.fig" in the kernel documentation: Max Range of {right_saturation and left_saturation} = 0x7FFF Because the maximal value of the saturation bound can be only half of the total range covered by the max negative to max positive bounds. And also because they are related to some form of force, and all other forms of force in linux have a maximum value of 0x7FFF Max Range of {deadband} = 0xFFFF This is a bit harder to explain: - First, I would suggest to alter the deadband definition in figure "interactive.fig": I would define deadband as going from a deadband-bound to the center (=> This is how MSDN defines it: "In other words, the condition is not active between lOffset minus lDeadBand and lOffset plus lDeadBand."), instead of from a deadband-bound to the other deadband-bound. => No changes needed in Wine. - Now, knowing that ff_condition_effect->center is __s16: The worst case scenario is that "center = -32768" or "center = +32767" while still wanting to cover the whole region (this is actually not possible with DInput's specs: in that case, they can only cover half of the total region): Then, to keep the scale of "center" and "deadband" the same, "deadband = 65535" = +32767 - -32768 = 0xFFFF This means that dinput deadband 10000 maps to 32767.5. (And dinput deadband 20000 (not possible in dinput) would map to 65535) => No changes needed in Wine (actually, there was, but applying the changes to the documentation, errors cancel out) => After having discussed this (see http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08459.html) the following is true: - offset: [-10000, 10000] (dinput) -> [-0x7FFF, 0x7FFF] (linux) - deadband: [ 0, 10000] (dinput) -> [ 0, 0xFFFF] (linux) - p/n-coeff: [-10000, 10000] (dinput) -> [-0x7FFF, 0x7FFF] (linux) - p/n-sat: [ 0, 10000] (dinput) -> [ 0, 0xFFFF] (linux) So change dinput/effect_linuxinput.c:271 : for (i = 0; i < 2; ++i) { tsp[i].lOffset = (This->effect.u.condition[i].center / 33) * 10; tsp[i].lPositiveCoefficient = (This->effect.u.condition[i].right_coeff / 33) * 10; tsp[i].lNegativeCoefficient = (This->effect.u.condition[i].left_coeff / 33) * 10; tsp[i].dwPositiveSaturation = (This->effect.u.condition[i].right_saturation / 33) * 10; tsp[i].dwNegativeSaturation = (This->effect.u.condition[i].left_saturation / 33) * 10; tsp[i].lDeadBand = (This->effect.u.condition[i].deadband / 33) * 10; } to : for (i = 0; i < 2; ++i) { tsp[i].lOffset = (This->effect.u.condition[i].center / 33) * 10; tsp[i].lPositiveCoefficient = (This->effect.u.condition[i].right_coeff / 33) * 10; tsp[i].lNegativeCoefficient = (This->effect.u.condition[i].left_coeff / 33) * 10; tsp[i].dwPositiveSaturation = (This->effect.u.condition[i].right_saturation / 66) * 10; tsp[i].dwNegativeSaturation = (This->effect.u.condition[i].left_saturation / 66) * 10; tsp[i].lDeadBand = (This->effect.u.condition[i].deadband / 66) * 10; } And change dinput/effect_linuxinput.c:511 : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (int)(factor[i] * (tsp->lOffset / 10) * 32); This->effect.u.condition[i].right_coeff = (int)(factor[i] * (tsp->lPositiveCoefficient / 10) * 32); This->effect.u.condition[i].left_coeff = (int)(factor[i] * (tsp->lNegativeCoefficient / 10) * 32); This->effect.u.condition[i].right_saturation = (int)(factor[i] * (tsp->dwPositiveSaturation / 10) * 32); This->effect.u.condition[i].left_saturation = (int)(factor[i] * (tsp->dwNegativeSaturation / 10) * 32); This->effect.u.condition[i].deadband = (int)(factor[i] * (tsp->lDeadBand / 10) * 32); } to : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (int)(factor[i] * (tsp->lOffset / 10) * 32); This->effect.u.condition[i].right_coeff = (int)(factor[i] * (tsp->lPositiveCoefficient / 10) * 32); This->effect.u.condition[i].left_coeff = (int)(factor[i] * (tsp->lNegativeCoefficient / 10) * 32); This->effect.u.condition[i].right_saturation = (int)(factor[i] * (tsp->dwPositiveSaturation / 10) * 65); This->effect.u.condition[i].left_saturation = (int)(factor[i] * (tsp->dwNegativeSaturation / 10) * 65); This->effect.u.condition[i].deadband = (int)(factor[i] * (tsp->lDeadBand / 10) * 65); } and change dinput/effect_linuxinput.c:522 : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; This->effect.u.condition[i].right_coeff = (tsp[i].lPositiveCoefficient / 10) * 32; This->effect.u.condition[i].left_coeff = (tsp[i].lNegativeCoefficient / 10) * 32; This->effect.u.condition[i].right_saturation = (tsp[i].dwPositiveSaturation / 10) * 32; This->effect.u.condition[i].left_saturation = (tsp[i].dwNegativeSaturation / 10) * 32; This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 32; } to : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; This->effect.u.condition[i].right_coeff = (tsp[i].lPositiveCoefficient / 10) * 32; This->effect.u.condition[i].left_coeff = (tsp[i].lNegativeCoefficient / 10) * 32; This->effect.u.condition[i].right_saturation = (tsp[i].dwPositiveSaturation / 10) * 65; This->effect.u.condition[i].left_saturation = (tsp[i].dwNegativeSaturation / 10) * 65; This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 65; } b) Spring (or other conditional effects) does not work (aborted in SetParameters while setting a non-zero envelope) in FEdit: This needs discussion: MSDN says: "Typically, you can apply an envelope to a constant force, a ramp force, or a periodic effect, but not to a condition." Linux's ff_condition_effect struct doesn't contain an ff_envelope struct, so it seems to be logically to say "if (!env) return DIERR_INVALIDPARAM;" (dinput/effect_linuxinput.c:444 SetParameters), but when taking a look at the envelope (that FEdit defines for such effect), it seems to be 'neutral': "Envelope has attack (level: 10000 time: 0), fade (level: 10000 time: 0)" So what should we do? - Leave it as is, but this will disable effects on hardware that is capable of applying them (without envelope). - Only return an error if the envelope is not 'neutral', but then we have to provide a rigorous definition of 'neutral'. - Don't return an error. This seems to be the behavior of the Windows Logitech FFB driver (MOMO, MOMO2, ...). Choosing the latter: change dinput/effect_linuxinput.c:444 : if (!env) return DIERR_INVALIDPARAM; /* copy the envelope */ env->attack_length = peff->lpEnvelope->dwAttackTime / 1000; env->attack_level = (peff->lpEnvelope->dwAttackLevel / 10) * 32; env->fade_length = peff->lpEnvelope->dwFadeTime / 1000; env->fade_level = (peff->lpEnvelope->dwFadeLevel / 10) * 32; to : if (!env) WARN("We get passed an envelope for a type (0x%x) that doesn't even have one.\n", This->effect.type); else { /* copy the envelope */ env->attack_length = peff->lpEnvelope->dwAttackTime / 1000; env->attack_level = (peff->lpEnvelope->dwAttackLevel / 10) * 32; env->fade_length = peff->lpEnvelope->dwFadeTime / 1000; env->fade_level = (peff->lpEnvelope->dwFadeLevel / 10) * 32; } Elias

2 2

GSoC 2014
by HuddenSin Yuan March 8, 2014

March 8, 2014

Hello, I'm Yuanchen,an undergraduate student from China.I have begun to use C to program sth since two years ago.I'm willing to take part in GSoC 2014. The Wine Project has many ideas programed by C,I think I can do sth helpful to you and also can apply what I learn to reality.And I want to do sth cool like fixing bugs. I'm interested in Winetest User Graphic Interface and other similiar ideas which use C. I'll appreciate it very much if you give me some advice. Regards, Yuanchen

2 1

Wine project aspirant for GSOC 2014 : Tools - Winetest Graphical User Interface
by Siddhartha Narang March 8, 2014

March 8, 2014

Hello , I am Siddhartha Narang a second year Undergraduate in INFORMATION TECHNOLOGY at University Institute of Engineering and Technology (UIET) Panjab University, Chandigarh,India . Skill set :- I have a deep knowledge of C and C++ and have made various games on console like the snake and food, tunnel came , bouncing ball . I have a average knowledge of Data Structures ,linux, Html5. I am currently learning Css . I have gone through various projects of your's for GSOC and the one which interest me a most is Tools - Winetest Graphical User Interface . I am very keen to be a part of this project . What i could interpret from the idea's page about the project is that to build a graphical user interface where user can see the test results . I am very enthusiastic about the coding. I would put my best foot forward to learn as much as I can and try and contribute to your community . It will be very nice of you if you guide me how to go about this project and from where i could start and elaborate what i need to do . Hoping to hear from you soon. -- REGARDS SIDDHARTHA NARANG SECOND YEAR UNDERGRADUATE INFORMATION TECHNOLOGY UIET, PANJAB UNIVERSITY CHANDIGARH , INDIA

2 1

Re: [PATCH 4/4] vbscript: Added support for VARIANT references to interp_newenum.
by Marvin March 8, 2014

March 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5511 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscipt: Allow ':' to be a separator in select case statement.
by Marvin March 8, 2014

March 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5510 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] vbscript: Use VariantCopyInd in invoke_variant_prop.
by Marvin March 8, 2014

March 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5509 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] vbscipt: Use VariantCopyInd in exec_script.
by Marvin March 8, 2014

March 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5508 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

[RFC 4/11] Linux FF: Linux effect parameter: periodic effect's phase
by Elias Vanderstuyft March 7, 2014

March 7, 2014

a) Periodic phase is not implemented conform most efficient implementations of linux FF-devices: phase should be related to time, not to angle: - HW interface example: In /drivers/input/joystick/iforce/iforce-ff.c : make_period_modifier(...): "iforce_send_packet(iforce, FF_CMD_PERIOD, data)" where data[4] = HI(phase); make_core(...): "iforce_send_packet(iforce, FF_CMD_EFFECT, data)" where data[4] = HI(duration); => Conclusion: phase likely to be related to time, not to angle - SW kernel interface example, which is going to be used for all memless FF devices in the future: (http://permalink.gmane.org/gmane.linux.kernel/1620326) in ff-memless-next.c:149 : mlnxeff->playback_time = effect->u.periodic.phase - SW interface example: SDL2-2.0.1/src/haptic/linux/SDL_syshaptic.c:640 There is also written on /include/uapi/linux/input.h:1058 : "@phase: 'horizontal' shift" where 'horizontal' most likely means time dimension, not phase of the waveform. => To be sure, I asked this at http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08459.html, but didn't receive any answer yet. So change the following in dinput/effect_linuxinput.c:259 : tsp->lOffset = (This->effect.u.periodic.offset / 33) * 10; tsp->dwPhase = (This->effect.u.periodic.phase / 33) * 36; tsp->dwPeriod = (This->effect.u.periodic.period * 1000); to : tsp->lOffset = (This->effect.u.periodic.offset / 33) * 10; if (!This->effect.u.periodic.period) { /* Avoid division by zero period, set tsp->dwPhase arbitrarily to zero. */ tsp->dwPhase = 0; } else tsp->dwPhase = (((int)This->effect.u.periodic.phase * 36000) / This->effect.u.periodic.period) % 36000; tsp->dwPeriod = (This->effect.u.periodic.period * 1000); and change the following in dinput/effect_linuxinput.c:486 : This->effect.u.periodic.offset = (tsp->lOffset / 10) * 32; This->effect.u.periodic.phase = (tsp->dwPhase / 9) * 8; /* == (/ 36 * 32) */ This->effect.u.periodic.period = tsp->dwPeriod / 1000; to : This->effect.u.periodic.offset = (tsp->lOffset / 10) * 32; This->effect.u.periodic.period = tsp->dwPeriod / 1000; This->effect.u.periodic.phase = ((int)(tsp->dwPhase % 36000) * This->effect.u.periodic.period) / 36000; Elias

2 2

[RFC 3/11] Linux FF: Linux effect parameter: start delay
by Elias Vanderstuyft March 7, 2014

March 7, 2014

a) Keep in mind that startDelay is not supported in DX5 or lower: In the SetParameters(...) case, we're sure This->effect.replay.delay is set to zero, because the HEAP_ZERO_MEMORY flag was set when allocating the LinuxInputEffectImpl 'This' struct in linuxinput_create_effect(...). So change dinput/effect_linuxinput.c:223 : if (dwFlags & DIEP_STARTDELAY) { peff->dwStartDelay = This->effect.replay.delay * 1000; } to : if ((dwFlags & DIEP_STARTDELAY) && (peff->dwSize > sizeof(DIEFFECT_DX5))) { peff->dwStartDelay = This->effect.replay.delay * 1000; } and change dinput/effect_linuxinput.c:463 : if (dwFlags & DIEP_STARTDELAY) This->effect.replay.delay = peff->dwStartDelay / 1000; to : if ((dwFlags & DIEP_STARTDELAY) && (peff->dwSize > sizeof(DIEFFECT_DX5))) This->effect.replay.delay = peff->dwStartDelay / 1000; Elias

2 2

Re: oleaut32: Resolve TypeLib dependencies with GUID
by guillaume.charifi＠sfr.fr March 7, 2014

March 7, 2014

Hello, I have no certainty, and not even a test, but the Windows version of Skype (which you know is released by Microsoft) tries to load a TypeLib named "uc.tlb", which cannot be find in path, and even in the registry. In fact, this library is into Skype.exe resources section, but it can only be found using its GUID (only the GUID is present in the library, not the name "uc.tlb". In fact it is a unnamed library). So there seems that two possibilities remains : - All the Typelibs of the executable are probed at launch (I don't think so, but...) - The Windows' oleaut32.dll scans the TypeLibs embedded into the executable and tries to match them not only by their name, but by their GUID to. Thanks for your reading, Guillaume ======================================== Message du : 07/03/2014 16:18 De : "Jacek Caban " <jacek(a)codeweavers.com> A : wine-devel(a)winehq.org, guillaume.charifi(a)sfr.fr Copie à : Sujet : Re: oleaut32: Resolve TypeLib dependencies with GUID On 03/07/14 15:53, guillaume.charifi(a)sfr.fr wrote: > Bug: http://bugs.winehq.org/show_bug.cgi?id=34184 Please send a test convincing that that's what Windows does. We already have a typelib in oleaur32 tests, so this should be a matter of loading it by GUID without having it registered. Thanks, Jacek

1 0

Re: oleaut32: Resolve TypeLib dependencies with GUID
by Jacek Caban March 7, 2014

March 7, 2014

On 03/07/14 15:53, guillaume.charifi(a)sfr.fr wrote: > Bug: http://bugs.winehq.org/show_bug.cgi?id=34184 Please send a test convincing that that's what Windows does. We already have a typelib in oleaur32 tests, so this should be a matter of loading it by GUID without having it registered. Thanks, Jacek

1 0

Re: [PATCH 2/2] vbscript: Directly access 'this' object properties in interpreter.
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscipt: Added beginning support for arrays as class members.
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5489 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: ws2_32/tests: Mark some test results on Windows 8 as broken.
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5487 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 0000000000000000

1 0

Re: [PATCH 2/5] d3d8/tests: Use create_device() in more tests.
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5480 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0005019E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x40f890, got 0x40f890.

1 0

Re: StrCatChainW implementation
by Nikolay Sivov March 7, 2014

March 7, 2014

On 3/6/2014 15:17, Huw Campbell wrote: > Hello > > Please see my implementation of this function, which has not been > seen in wine previously. Explorer.exe calls it, so it's kind of important. > > I ran a lot of tests on the edge cases: including: same ends, 0 ends, > end beyond the length... Hi, Huw. We need those tests in shlwapi/tests. Now regarding patch itself. > +DWORD WINAPI StrCatChainW(PWSTR pszDst, DWORD cchDst, DWORD ichAt, PCWSTR pszSrc) Please use lower case naming that's more readable, like 'dest', 'dest_len', 'at', 'src'. > +{ > + LPWSTR d = pszDst; > + LPCWSTR s = pszSrc; It doesn't look like you need this 'd' and 's', you could use passed pointers. > + DWORD mark; > + > + TRACE("(%s,%i,%i,%s)\n", debugstr_w(pszDst), cchDst, ichAt, debugstr_w(pszSrc)); Is it possible that destination buffer is uninitialized? In this case you can't trace in like this. > + > + if (ichAt == -1) > + mark = strlenW(pszDst); > + else > + mark = ichAt; > + if (mark > cchDst || cchDst == 0) > + return mark; > + if (mark == cchDst) > + mark--; > + d = d + mark; > + if (pszSrc) > + { > + while ((mark < cchDst-1) && *s) > + { > + mark++; > + *d++ = *s++; > + } > + } > + *d = 0; What happens if 'd' is null? Could this loop be replaced with StrNCatW or something similar? > + return mark; > +}

1 0

Re: [PATCH 2/3] gdiplus: Set outer pointer to NULL when image loading functions fail.
by Dmitry Timoshkov March 7, 2014

March 7, 2014

Qian Hong <qhong(a)codeweavers.com> wrote: > @@ -1365,10 +1365,12 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromFile(GDIPCONST WCHAR* filename, > if(!filename || !bitmap) > return InvalidParameter; > > + *bitmap = NULL; Is there an application that depends on this behaviour? > stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > > if(stat != Ok) > - return stat; > + return InvalidParameter; Probably GdipCreateStreamOnFile should be fixed instead (with tests of course). > > stat = GdipCreateBitmapFromStream(stream, bitmap); > > @@ -2923,10 +2925,12 @@ GpStatus WINGDIPAPI GdipLoadImageFromFile(GDIPCONST WCHAR* filename, > if (!filename || !image) > return InvalidParameter; > > + *image = NULL; Same question as above. > stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > > if (stat != Ok) > - return stat; > + return OutOfMemory; Same note about GdipCreateStreamOnFile. And I don't think that's a good idea to replicate weird return error codes without actually getting any memory allocation errors. -- Dmitry.

2 7

Re: [1/6] user32: Add a test for empty popup menus.
by Dmitry Timoshkov March 7, 2014

March 7, 2014

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Even with the message test (patch 3), I think this one is worthwhile > as it includes the cases of popup menu initialization in wndproc, and > reusing the HMENU after the error path. These patches look good to me. -- Dmitry.

1 0

Re: [PATCH 1/2] dinput8: Flush input events queue before calling GetDeviceData
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5461 Your paranoid android. === w8 (32 bit device) === device.c:125: Test failed: GetDeviceData() failed: 00000000 device.c:128: Test failed: GetDeviceData() failed: 00000000 cnt:0

1 0

Re: ws2_32/tests: Free TLS after WSACleanup
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5460 Your paranoid android. === w2000pro (32 bit sock) === sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: [6/6] user32: Skip menu loop for empty popup menus.
by Marvin March 7, 2014

March 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5456 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [5/6] user32: Set capture on the owner of popup menus.
by Marvin March 6, 2014

March 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5455 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [3/6] user32: Add message tests for TrackPopupMenu.
by Marvin March 6, 2014

March 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5454 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:8398: Test failed: did not get expected count for minimum timeout (54 != ~64). msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [3/3] ws2_32/tests: Get rid of the do_oob_send helper function
by Marvin March 6, 2014

March 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5420 Your paranoid android. === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF0720C0 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFE4220C0

3 4

Wine test day #2: an easy lob
by Jeremy White March 6, 2014

March 6, 2014

So it looks like the easy test for the day is drag/drop: http://test.winehq.org/data/tests/ole32:dragdrop.html Evidence suggests both that Piotr broke it, but is also working to fix it, so I don't think I get to shame him publicly...yet <grin>. Cheers, Jeremy

3 3