March 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] ddraw/tests: Use a custom GUID for the private data tests.
by Marvin March 16, 2014

March 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5718 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] ddraw/tests: Use a custom GUID for the private data tests.
by Marvin March 16, 2014

March 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5715 Your paranoid android. === wvistau64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w2008s64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w8 (32 bit ddraw4) === No test summary line found Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: [PATCH 3/5] ddraw/tests: Add mipmap private data tests.
by Marvin March 16, 2014

March 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5714 Your paranoid android. === w8 (32 bit ddraw7) === Failure running script in VM: timed out waiting for the child process === wvistau64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w2008s64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w8 (32 bit ddraw4) === ddraw4.c:5731: Test failed: Got unexpected refcount 3. ddraw4.c:5750: Test failed: Got unexpected refcount 3. ddraw4.c:5757: Test failed: Got unexpected hr 0. ddraw4.c:5760: Test failed: Got unexpected refcount 3. ddraw4.c:5762: Test failed: Got unexpected refcount 2. ddraw4.c:5768: Test failed: Got unexpected hr 0. ddraw4.c:5771: Test failed: Got unexpected refcount 2. ddraw4.c:5773: Test failed: Got unexpected refcount 1. ddraw4.c:5775: Test failed: Got unexpected refcount 6.

1 0

Re: [PATCH 2/5] ddraw/tests: Test GetPrivateData size behavior.
by Marvin March 16, 2014

March 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5713 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === The test timed out

1 0

Re: cmd: Dont assume cmd.exe is the first argument
by Qian Hong March 16, 2014

March 16, 2014

Hi Alistair, + args = 0; /* start at first arg, skipping cmd.exe itself */ Could you also consider fixing the comment here? Have a nice weekend :) -- Regards, Qian Hong - http://www.winehq.org

1 0

About GSoC - The Wine Project
by SpedsT . March 15, 2014

March 15, 2014

Hello. I want to apply to this project and I have a question about this note: * Note: Beginning with Summer of Code 2014, applicants *MUST* have submitted a patch or testcase to wine-patches (see http://wiki.winehq.org/SubmittingPatches) to be considered for acceptance. What kind of patch or testcase should I submit, what would you like to be about?

2 1

Re: gdiplus: Use BOOL type where appropriate
by Vincent Povirk March 15, 2014

March 15, 2014

On Sat, Mar 15, 2014 at 9:44 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - rotate_90 = type&1; > + rotate_90 = (type & 1) != 0; > flip_x = (type&6) == 2 || (type&6) == 4; > flip_y = (type&3) == 1 || (type&3) == 2; If you must change the style, I prefer (type&1) == 1 here, as it has fewer negatives and matches the lines after it.

1 0

Re: mshtml: Added IHTMLTableRow::rowIndex property implementation.
by Zhenbo Li March 15, 2014

March 15, 2014

Sorry, I sent the same patch twice due to network problem. Please ignore the second one. Thank you. 2014-03-15 11:23 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/mshtml/htmltablerow.c | 11 +++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH 2/2] wined3d: Re-use old wined3d_private_data structures if the size matches.
by Henri Verbeet March 14, 2014

March 14, 2014

On 14 March 2014 14:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if ((old = wined3d_private_store_get_private_data(store, guid)) && old->size == data_size) > + { > + IUnknown *release = NULL; > + if (old->flags & WINED3DSPD_IUNKNOWN) > + release = old->content.object; > + memcpy(old->content.data, ptr, data_size); > + old->flags = flags; > + if (flags & WINED3DSPD_IUNKNOWN) > + IUnknown_AddRef(old->content.object); > + if (release) > + IUnknown_Release(release); > + return WINED3D_OK; > + } What is the motivation for this? It certainly doesn't make the code any prettier.

2 1

Re: [3/3] gdiplus: Limit image output to the bounds of the Graphics object.
by Vincent Povirk March 14, 2014

March 14, 2014

Don't commit this one. I messed up the case where output is fully outside the Graphics object bounds. On Thu, Mar 13, 2014 at 4:49 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >

1 0