March 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] d3dx9: Always use type->Rows as D3DXPC_MATRIX_ROWS parameters size. (resend)
by Rico Schüller March 5, 2014

March 5, 2014

On 03.03.2014 17:48, Matteo Bruni wrote: > diff --git a/dlls/d3dx9_36/tests/shader.c b/dlls/d3dx9_36/tests/shader.c > index 74ada6e..80c0f64 100644 > --- a/dlls/d3dx9_36/tests/shader.c > +++ b/dlls/d3dx9_36/tests/shader.c > @@ -120,7 +120,7 @@ static const DWORD ctab_matrices[] = { > 0x000000ac, > 0x00000058, 0x00070002, 0x00000001, 0x00000064, 0x00000000, /* Constant 1 desc (fmatrix3x1) */ > 0x00000074, 0x00000002, 0x00000004, 0x00000080, 0x00000000, /* Constant 2 desc (fmatrix4x4) */ > - 0x00000090, 0x00040002, 0x00000003, 0x0000009c, 0x00000000, /* Constant 3 desc (imatrix2x3) */ > + 0x00000090, 0x00040002, 0x00000002, 0x0000009c, 0x00000000, /* Constant 3 desc (imatrix2x3) */ Why this? Was the shader blob wrong (invalid)? Or did you just compile with vs without optimization? > 0x74616D66, 0x33786972, 0xab003178, /* Constant 1 name */ > 0x00030003, 0x00010003, 0x00000001, 0x00000000, /* Constant 1 type desc */ > 0x74616D66, 0x34786972, 0xab003478, /* Constant 2 name */ > @@ -133,8 +133,9 @@ static const DWORD ctab_matrices[] = { > > static const D3DXCONSTANT_DESC ctab_matrices_expected[] = { > {"fmatrix4x4", D3DXRS_FLOAT4, 0, 4, D3DXPC_MATRIX_COLUMNS, D3DXPT_FLOAT, 4, 4, 1, 0, 64, NULL}, > - {"imatrix2x3", D3DXRS_FLOAT4, 4, 3, D3DXPC_MATRIX_ROWS, D3DXPT_INT, 2, 3, 1, 0, 24, NULL}, > - {"fmatrix3x1", D3DXRS_FLOAT4, 7, 1, D3DXPC_MATRIX_COLUMNS, D3DXPT_FLOAT, 3, 1, 1, 0, 12, NULL}}; > + {"imatrix2x3", D3DXRS_FLOAT4, 4, 2, D3DXPC_MATRIX_ROWS, D3DXPT_INT, 2, 3, 1, 0, 24, NULL}, > + {"fmatrix3x1", D3DXRS_FLOAT4, 7, 1, D3DXPC_MATRIX_COLUMNS, D3DXPT_FLOAT, 3, 1, 1, 0, 12, NULL}, > +}; > > static const DWORD ctab_matrices2[] = { > 0xfffe0200, /* vs_2_0 */ >

2 1

winetestbot day 1: Frustrating lack of personal blame, praise required instead
by Jeremy White March 5, 2014

March 5, 2014

Alright, So I have started my once a day attack on test.winehq.org. Summary: 049f08f4cda0 04 Mar 39 test failures on wtb * But the win8 wtb did not fire, so there are likely 38 more The first set I examined were the Wine Test Bot Win 2K tests with 12 failures. This is a relatively new VM, and it has a new set of failures, not seen on the old test bot. A number of the test failures: comctl32:listview, comctl32:propsheet, and a few others, look to be timing related. So there is not a clear person to blame; in fact, it may be a qemu bug. However, Nikolay, as the last person to touch the comctl32:listview test, has volunteered to look into this issue and see if he can get to the bottom of it. So I cannot publicly shame anyone, as I had hoped, and instead have to commend Nikolay for volunteering. Cheers, Jeremy

1 0

Re: cmd/tests: Fix a test in Windows 8
by Marvin March 5, 2014

March 5, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5397 Your paranoid android. === w2000pro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 263 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 264 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 299 (got 'C:\C D', wanted '@pwd@\C D(a)or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 300 (got 'C:\E', wanted '@pwd@\E(a)or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 303 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 304 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 310 (got ''C:\R S'', wanted ''@drive@@shortpath(a)R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 311 (got ''C:\T'', wanted ''@drive@@shortpath(a)T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 312 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath(a)ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 321 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 322 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 335 (got 'C:\C D', wanted '@pwd@\C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 336 (got 'C:\E', wanted '@pwd@\E') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 339 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 340 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 346 (got ''C:\R S'', wanted ''@drive@@shortpath(a)R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 347 (got ''C:\T'', wanted ''@drive@@shortpath(a)T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 348 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath(a)ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 349 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 350 (got 'C:\', wanted '@drive@@path@') batch.c:304: Test failed: excess characters on line 392 (got 'Current dir: C:\foobar', wanted 'Current dir: @pwd@\foobar(a)or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 393 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 395 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 397 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 401 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 402 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 403 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1090 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1092 (got 'C:\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1094 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1099 (got 'A C:\foobar\foo', wanted 'A @pwd@\foobar\foo(a)or_broken@A @pwd@\foobar\foo(a)or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1101 (got 'A R C:\foobar\foo', wanted 'A R @pwd@\foobar\foo(a)or_broken@A R @pwd@\foobar\foo(a)or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1107 (got 'A C:\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2(a)or_broken@A @pwd@\foobar\baz\level2(a)or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1108 (got 'A R C:\foobar\level1', wanted 'A R @pwd@\foobar\level1(a)or_broken@A R @pwd@\foobar\level1(a)or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1109 (got 'A R C:\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2(a)or_broken@A R @pwd@\foobar\baz\level2(a)or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\bar', wanted 'A @pwd@\foobar\bar(a)or_broken@A @pwd@\foobar\bar(a)or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1112 (got ' C:\foobar', wanted ' @pwd@\foobar(a)or_broken@ @pwd@\foobar(a)or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1113 (got ' R C:\foobar\baz', wanted ' R @pwd@\foobar\baz(a)or_broken@ R @pwd@\foobar\baz(a)or_broken@ @pwd@\foobar\baz(a)or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1114 (got 'A C:\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto(a)or_broken@A @pwd@\foobar\baz\toto(a)or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1251 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1253 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1255 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1259 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1261 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1279 (got 'C:\foobar\foodir3', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1284 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1288 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1290 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1295 (got 'C:\foobar', wanted '@pwd@\foobar') === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

1 0

Re: msi/tests: Skip some package tests if in a non-administrator, non-power user account.
by Marvin March 5, 2014

March 5, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5390 Your paranoid android. === w2000pro (32 bit package) === package.c:3954: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3960: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3966: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3978: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3984: Test failed: Expected "C:\\", got "C:\" package.c:3990: Test failed: Expected "C:\\", got "C:\" package.c:4006: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4017: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4476: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4568: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4579: Test failed: Expected "C:\\", got "C:\" package.c:4590: Test failed: Expected "C:\\", got "C:\" package.c:4640: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4651: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4666: Test failed: Expected "C:\\", got "C:\" package.c:4671: Test failed: Expected "", got "C:\" package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4696: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4946: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4957: Test failed: Expected "C:\\", got "C:\" package.c:4963: Test failed: Expected "C:\\", got "C:\" package.c:4984: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4995: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5235: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5241: Test failed: Expected "C:\\", got "C:\" package.c:5258: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5269: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5277: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5621: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6253: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6277: Test failed: Expected C:\\ or empty string, got C:\ package.c:6321: Test failed: Expected C:\\ or empty string, got C:\ package.c:6330: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6560: Test failed: Expected "C:\\", got "C:\" package.c:6561: Test failed: Expected 4, got 3 package.c:6568: Test failed: Expected "C:\\", got "C:\" package.c:6569: Test failed: Expected 4, got 3 package.c:6585: Test failed: Expected "C:\\", got "C:\" package.c:6586: Test failed: Expected 4, got 3 package.c:6592: Test failed: Expected "C:\\", got "C:\" package.c:6593: Test failed: Expected 4, got 3 package.c:6600: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6601: Test failed: Expected 14, got 13 package.c:6608: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6609: Test failed: Expected 19, got 18 package.c:6619: Test failed: Expected "C:\\", got "C:\" package.c:6620: Test failed: Expected 4, got 3 package.c:6627: Test failed: Expected "C:\\", got "C:\" package.c:6628: Test failed: Expected 4, got 3 package.c:6644: Test failed: Expected "C:\\", got "C:\" package.c:6645: Test failed: Expected 4, got 3 package.c:6651: Test failed: Expected "C:\\", got "C:\" package.c:6652: Test failed: Expected 4, got 3 package.c:6659: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6660: Test failed: Expected 14, got 13 package.c:6667: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6668: Test failed: Expected 19, got 18 package.c:6678: Test failed: Expected "C:\\", got "C:\" package.c:6679: Test failed: Expected 4, got 3 package.c:6686: Test failed: Expected "C:\\", got "C:\" package.c:6687: Test failed: Expected 4, got 3 package.c:6703: Test failed: Expected "C:\\", got "C:\" package.c:6704: Test failed: Expected 4, got 3 package.c:6710: Test failed: Expected "C:\\", got "C:\" package.c:6711: Test failed: Expected 4, got 3 package.c:6718: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6719: Test failed: Expected 14, got 13 package.c:6726: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6727: Test failed: Expected 19, got 18 package.c:6737: Test failed: Expected "C:\\", got "C:\" package.c:6738: Test failed: Expected 4, got 3 package.c:6745: Test failed: Expected "C:\\", got "C:\" package.c:6746: Test failed: Expected 4, got 3 package.c:6762: Test failed: Expected "C:\\", got "C:\" package.c:6763: Test failed: Expected 4, got 3 package.c:6769: Test failed: Expected "C:\\", got "C:\" package.c:6770: Test failed: Expected 4, got 3 package.c:6777: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6778: Test failed: Expected 14, got 13 package.c:6785: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6786: Test failed: Expected 19, got 18 package.c:6801: Test failed: Expected 4, got 3 package.c:6818: Test failed: Expected 4, got 3 package.c:6824: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6827: Test failed: Expected 4, got 3 package.c:6834: Test failed: Expected "C:\\", got "C:\" package.c:6835: Test failed: Expected 4, got 3 package.c:6846: Test failed: Expected "C:\\", got "C:\" package.c:6847: Test failed: Expected 4, got 3 package.c:6942: Test failed: Expected "C:\\", got "C:\" package.c:6943: Test failed: Expected 4, got 3 package.c:6950: Test failed: Expected "C:\\", got "C:\" package.c:6951: Test failed: Expected 4, got 3 package.c:6960: Test failed: Expected "C:\\", got "C:\" package.c:6961: Test failed: Expected 4, got 3 package.c:6969: Test failed: Expected "C:\\", got "C:\" package.c:6970: Test failed: Expected 4, got 3 package.c:6976: Test failed: Expected "C:\\", got "C:\" package.c:6977: Test failed: Expected 4, got 3 package.c:6984: Test failed: Expected "C:\\", got "C:\" package.c:6985: Test failed: Expected 4, got 3 package.c:6992: Test failed: Expected "C:\\", got "C:\" package.c:6993: Test failed: Expected 4, got 3 package.c:7003: Test failed: Expected "C:\\", got "C:\" package.c:7004: Test failed: Expected 4, got 3 package.c:7011: Test failed: Expected "C:\\", got "C:\" package.c:7012: Test failed: Expected 4, got 3 package.c:7021: Test failed: Expected "C:\\", got "C:\" package.c:7022: Test failed: Expected 4, got 3 package.c:7030: Test failed: Expected "C:\\", got "C:\" package.c:7031: Test failed: Expected 4, got 3 package.c:7037: Test failed: Expected "C:\\", got "C:\" package.c:7038: Test failed: Expected 4, got 3 package.c:7045: Test failed: Expected "C:\\", got "C:\" package.c:7046: Test failed: Expected 4, got 3 package.c:7053: Test failed: Expected "C:\\", got "C:\" package.c:7054: Test failed: Expected 4, got 3 package.c:7064: Test failed: Expected "C:\\", got "C:\" package.c:7065: Test failed: Expected 4, got 3 package.c:7072: Test failed: Expected "C:\\", got "C:\" package.c:7073: Test failed: Expected 4, got 3 package.c:7082: Test failed: Expected "C:\\", got "C:\" package.c:7083: Test failed: Expected 4, got 3 package.c:7091: Test failed: Expected "C:\\", got "C:\" package.c:7092: Test failed: Expected 4, got 3 package.c:7098: Test failed: Expected "C:\\", got "C:\" package.c:7099: Test failed: Expected 4, got 3 package.c:7106: Test failed: Expected "C:\\", got "C:\" package.c:7107: Test failed: Expected 4, got 3 package.c:7114: Test failed: Expected "C:\\", got "C:\" package.c:7115: Test failed: Expected 4, got 3 package.c:7125: Test failed: Expected "C:\\", got "C:\" package.c:7126: Test failed: Expected 4, got 3 package.c:7133: Test failed: Expected "C:\\", got "C:\" package.c:7134: Test failed: Expected 4, got 3 package.c:7143: Test failed: Expected "C:\\", got "C:\" package.c:7144: Test failed: Expected 4, got 3 package.c:7152: Test failed: Expected "C:\\", got "C:\" package.c:7153: Test failed: Expected 4, got 3 package.c:7159: Test failed: Expected "C:\\", got "C:\" package.c:7160: Test failed: Expected 4, got 3 package.c:7167: Test failed: Expected "C:\\", got "C:\" package.c:7168: Test failed: Expected 4, got 3 package.c:7175: Test failed: Expected "C:\\", got "C:\" package.c:7176: Test failed: Expected 4, got 3 package.c:7273: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7274: Test failed: Expected 9, got 8 package.c:7283: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7284: Test failed: Expected 9, got 8 package.c:7293: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7294: Test failed: Expected 9, got 8 package.c:7305: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7306: Test failed: Expected 8, got 7 package.c:7317: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7318: Test failed: Expected 9, got 8 package.c:7329: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7330: Test failed: Expected 8, got 7 package.c:7341: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7342: Test failed: Expected 10, got 9 package.c:7353: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7354: Test failed: Expected 8, got 7 package.c:7365: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7366: Test failed: Expected 11, got 10 package.c:7417: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7418: Test failed: Expected 10, got 9 package.c:7427: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7428: Test failed: Expected 10, got 9 package.c:7437: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7438: Test failed: Expected 10, got 9 package.c:7449: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7450: Test failed: Expected 8, got 7 package.c:7461: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7462: Test failed: Expected 10, got 9 package.c:7473: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7474: Test failed: Expected 9, got 8 package.c:7485: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7486: Test failed: Expected 10, got 9 package.c:7497: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7498: Test failed: Expected 9, got 8 package.c:7509: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7510: Test failed: Expected 11, got 10 package.c:7646: Test failed: Expected "C:\\", got "C:\" package.c:7647: Test failed: Expected 4, got 3 package.c:7658: Test failed: Expected "C:\\", got "C:\" package.c:7659: Test failed: Expected 4, got 3 package.c:7666: Test failed: Expected "C:\\", got "C:\" package.c:7667: Test failed: Expected 4, got 3 package.c:7764: Test failed: Expected "C:\\", got "C:\" package.c:7765: Test failed: Expected 4, got 3 package.c:7772: Test failed: Expected "C:\\", got "C:\" package.c:7773: Test failed: Expected 4, got 3 package.c:7780: Test failed: Expected "C:\\", got "C:\" package.c:7781: Test failed: Expected 4, got 3 package.c:7800: Test failed: Expected "C:\\", got "C:\" package.c:7801: Test failed: Expected 4, got 3 package.c:7808: Test failed: Expected "C:\\", got "C:\" package.c:7809: Test failed: Expected 4, got 3 package.c:7828: Test failed: Expected "C:\\", got "C:\" package.c:7829: Test failed: Expected 4, got 3 package.c:7836: Test failed: Expected "C:\\", got "C:\" package.c:7837: Test failed: Expected 4, got 3 package.c:7856: Test failed: Expected "C:\\", got "C:\" package.c:7857: Test failed: Expected 4, got 3 package.c:7864: Test failed: Expected "C:\\", got "C:\" package.c:7865: Test failed: Expected 4, got 3

1 0

Re: atl/tests: Update registrar's is_process_limited() to deal with non-administrator, non-power user accounts.
by Jacek Caban March 5, 2014

March 5, 2014

Hi Francois, On 03/05/14 11:31, Francois Gouget wrote: > --- > > This should fix the test failures on the fg-win2000-rusr, fg-winxp-lusr > and fg-win7u64-1spie9usr VMs. I think we could change tests to use HKCU only so that those checks are not needed. Could you please test if the attached patch works on those boxes? Thanks, Jacek

1 0

Re: [PATCH 4/5] ddraw/tests: Avoid using EnumDevices() to get a supported Z buffer format.
by Marvin March 5, 2014

March 5, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5387 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:752: Test failed: Got unexpected color 0x00000000. ddraw2.c:3207: Test failed: Got unexpected color 0x000000ff. ddraw2.c:5209: Test failed: Got unexpected refcount 3. ddraw2.c:5228: Test failed: Got unexpected refcount 3. ddraw2.c:5235: Test failed: Got unexpected hr 0. ddraw2.c:5238: Test failed: Got unexpected refcount 3. ddraw2.c:5240: Test failed: Got unexpected refcount 2. ddraw2.c:5246: Test failed: Got unexpected hr 0. ddraw2.c:5249: Test failed: Got unexpected refcount 2. ddraw2.c:5251: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:789: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:1464: Test failed: Got unexpected color 0x000000ff. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4085: Test failed: Got unexpected refcount 3. ddraw1.c:4104: Test failed: Got unexpected refcount 3. ddraw1.c:4111: Test failed: Got unexpected hr 0. ddraw1.c:4114: Test failed: Got unexpected refcount 3. ddraw1.c:4116: Test failed: Got unexpected refcount 2. ddraw1.c:4122: Test failed: Got unexpected hr 0. ddraw1.c:4125: Test failed: Got unexpected refcount 2. ddraw1.c:4127: Test failed: Got unexpected refcount 1.

1 0

Re: [PATCH 3/5] ddraw/tests: Add a test for creating surfaces with an explicit pitch.
by Marvin March 5, 2014

March 5, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5386 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:746: Test failed: Got unexpected color 0x00000000. ddraw2.c:3199: Test failed: Got unexpected color 0x000000ff. === w8 (32 bit ddraw1) === ddraw1.c:783: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4103: Test failed: Got unexpected refcount 3. ddraw1.c:4122: Test failed: Got unexpected refcount 3. ddraw1.c:4129: Test failed: Got unexpected hr 0. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 2. ddraw1.c:4140: Test failed: Got unexpected hr 0. ddraw1.c:4143: Test failed: Got unexpected refcount 2. ddraw1.c:4145: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5817: Test failed: Got unexpected refcount 3. ddraw4.c:5836: Test failed: Got unexpected refcount 3. ddraw4.c:5843: Test failed: Got unexpected hr 0. ddraw4.c:5846: Test failed: Got unexpected refcount 3. ddraw4.c:5848: Test failed: Got unexpected refcount 2. ddraw4.c:5854: Test failed: Got unexpected hr 0. ddraw4.c:5857: Test failed: Got unexpected refcount 2. ddraw4.c:5859: Test failed: Got unexpected refcount 1. ddraw4.c:5861: Test failed: Got unexpected refcount 6. ddraw4.c:5985: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:6024: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6027: Test failed: Got unexpected hr 0. ddraw4.c:6029: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6032: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6035: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6037: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6040: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6042: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6045: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6047: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [4/5] schedsvc: Implement SchRpcRegisterTask.
by Hans Leidekker March 5, 2014

March 5, 2014

On Wed, 2014-03-05 at 18:07 +0900, Dmitry Timoshkov wrote: > +static HRESULT write_xml_utf8(const WCHAR *name, DWORD disposition, const WCHAR *xmlW) > +{ > + static const char bom_utf8[] = { 0xef,0xbb,0xbf }; > + static const char comment[] = "\n"; > + HANDLE hfile; > + DWORD size; > + char *xml; > + HRESULT hr = S_OK; > + > + hfile = CreateFileW(name, GENERIC_WRITE, 0, NULL, disposition, 0, 0); > + if (hfile == INVALID_HANDLE_VALUE) > + { > + if (GetLastError() == ERROR_FILE_EXISTS) > + return HRESULT_FROM_WIN32(ERROR_ALREADY_EXISTS); > + > + return HRESULT_FROM_WIN32(GetLastError()); > + } > + > + size = WideCharToMultiByte(CP_UTF8, 0, xmlW, -1, NULL, 0, NULL, NULL); > + xml = heap_alloc(size); > + if (!xml) > + { > + CloseHandle(hfile); > + return E_OUTOFMEMORY; > + } > + WideCharToMultiByte(CP_UTF8, 0, xmlW, -1, xml, size, NULL, NULL); > + > + if (!WriteFile(hfile, bom_utf8, strlen(bom_utf8), &size, NULL)) bom_utf8 is not null-terminated.

2 1

Re: [PATCH] msxml3: Added stub support for ISAXDTDHandler/IVBSAXDTDHandler for MXWriter
by Nikolay Sivov March 5, 2014

March 5, 2014

Please skip this one, it's a part of a series now.

1 0

[RFC 11/11] Linux FF: Debug message fixes/additions
by Elias Vanderstuyft March 4, 2014

March 4, 2014

a) An effectSpecific structure corresponding with a condition effect, can have 2 possible valid sizes, instead of 1: sizeof(DICONDITION) and 2*sizeof(DICONDITION); the latter is even more common. Solution: change in dinput/joystick.c:216 : if (eff->cbTypeSpecificParams != sizeof(DICONDITION)) { WARN("Effect claims to be a condition but the type-specific params are the wrong size!\n"); } else { _dump_DICONDITION(eff->lpvTypeSpecificParams); } to : if (eff->cbTypeSpecificParams == sizeof(DICONDITION)) { _dump_DICONDITION(eff->lpvTypeSpecificParams); } else if (eff->cbTypeSpecificParams == 2 * sizeof(DICONDITION)) { TRACE("Effect has two condition blocks:\n"); _dump_DICONDITION(eff->lpvTypeSpecificParams); _dump_DICONDITION(eff->lpvTypeSpecificParams + sizeof(DICONDITION)); } else { WARN("Effect claims to be a condition but the type-specific params are the wrong size (0x%x instead of 0x%x)!\n", eff->cbTypeSpecificParams, sizeof(DICONDITION)); } b) Question: consider following code in dinput/effect_linuxinput:369 : if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | DIEP_GAIN | DIEP_SAMPLEPERIOD | DIEP_STARTDELAY | DIEP_TRIGGERBUTTON | DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; Q1: Why is everything set, if dwFlags has no bits set (except DIEP_NORESTART, DIEP_NODOWNLOAD or DIEP_START)? I can see no mention of it on MSDN. Q2: Why "dwFlags = " and not "dwFlags |= "? E.g. assume dwFlags = DIEP_START, then the if-test will cause the DIEP_START flag to be lost, resulting in an effect not started. c) If Q1 is right, then the order of "dump_DIEFFECT" on dinput/effect_linuxinput:367 should be changed, from : dump_DIEFFECT(peff, &This->guid, dwFlags); if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | DIEP_GAIN | DIEP_SAMPLEPERIOD | DIEP_STARTDELAY | DIEP_TRIGGERBUTTON | DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; } to : if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | DIEP_GAIN | DIEP_SAMPLEPERIOD | DIEP_STARTDELAY | DIEP_TRIGGERBUTTON | DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; } dump_DIEFFECT(peff, &This->guid, dwFlags); d) Add debug info for rglDirection: Change in dinput/joystick.c:169 : TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - rglDirection: %p\n", eff->rglDirection); TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); /* Only trace some members if dwFlags indicates they have data */ if (dwFlags & DIEP_AXES) { TRACE(" - cAxes: %d\n", eff->cAxes); TRACE(" - rgdwAxes: %p\n", eff->rgdwAxes); if (TRACE_ON(dinput) && eff->rgdwAxes) { TRACE(" "); for (i = 0; i < eff->cAxes; ++i) TRACE("%d ", eff->rgdwAxes[i]); TRACE("\n"); } } to : TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); /* Only trace some members if dwFlags indicates they have data */ if ((dwFlags & DIEP_AXES) || (dwFlags & DIEP_DIRECTION)) { TRACE(" - cAxes: %d\n", eff->cAxes); if (dwFlags & DIEP_AXES) { TRACE(" - rgdwAxes: %p\n", eff->rgdwAxes); if (TRACE_ON(dinput) && eff->rgdwAxes) { TRACE(" "); for (i = 0; i < eff->cAxes; ++i) TRACE("%d ", eff->rgdwAxes[i]); TRACE("\n"); } } if (dwFlags & DIEP_DIRECTION) { TRACE(" - rglDirection: %p\n", eff->rglDirection); if (TRACE_ON(dinput) && eff->rglDirection) { TRACE(" "); for (i = 0; i < eff->cAxes; ++i) TRACE("%d ", eff->rglDirection[i]); TRACE("\n"); } } } e) Add debug info for dwSamplePeriod: Change in dinput/joystick.c:166 : if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); to : if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); if (dwFlags & DIEP_SAMPLEPERIOD) TRACE(" - dwSamplePeriod: %d\n", eff->dwSamplePeriod); TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); f) Why not consistently only trace set (and probably thus valid) parameters in dump_DIEFFECT? Change in dinput/joystick.c:163 : TRACE(" - dwDuration: %d\n", eff->dwDuration); TRACE(" - dwGain: %d\n", eff->dwGain); if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); if (dwFlags & DIEP_SAMPLEPERIOD) TRACE(" - dwSamplePeriod: %d\n", eff->dwSamplePeriod); TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); to : if (dwFlags & DIEP_DURATION) TRACE(" - dwDuration: %d\n", eff->dwDuration); if (dwFlags & DIEP_GAIN) { TRACE(" - dwGain: %d\n", eff->dwGain); if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); } if (dwFlags & DIEP_SAMPLEPERIOD) TRACE(" - dwSamplePeriod: %d\n", eff->dwSamplePeriod); if (dwFlags & DIEP_TRIGGERBUTTON) TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); if (dwFlags & DIEP_TRIGGERREPEATINTERVAL) TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); if (dwFlags & DIEP_TYPESPECIFICPARAMS) { TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); } and change on dinput/joystick.c:194 : if (eff->dwSize > sizeof(DIEFFECT_DX5)) TRACE(" - dwStartDelay: %d\n", eff->dwStartDelay); to : if ((dwFlags & DIEP_STARTDELAY) && (eff->dwSize > sizeof(DIEFFECT_DX5))) TRACE(" - dwStartDelay: %d\n", eff->dwStartDelay); Note: If applying that patch, maybe we should use TRACE_ON(dinput) to circumvent all these ifs for performance reasons? Elias

1 0