March 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] docobj.idl: Added some new OLDCMDID values.
by Dmitry Timoshkov March 31, 2014

March 31, 2014

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > include/docobj.idl | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) A typo in the commit message: OLD -> OLE. -- Dmitry.

1 0

Re: apphelp: add a stub for SdbInitDatabase
by Hans Leidekker March 31, 2014

March 31, 2014

On Sun, 2014-03-30 at 14:36 -0700, Austin English wrote: > +PDB WINAPI SdbInitDatabase(DWORD flags, LPCSTR path) > +{ > + FIXME("stub: %u %s\n", flags, debugstr_a(path)); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return NULL; > +} Return type should be HSDB. Please trace flags in hex.

1 0

Re: mshtml: Added IHTMLTable::bgColor property implementation.
by Nikolay Sivov March 30, 2014

March 30, 2014

On 3/30/2014 19:18, Zhenbo Li wrote: > + nsAString_Init(&strColor, NULL); > + nsres = nsIDOMHTMLTableElement_GetBgColor(This->nstable, &strColor); > + nsAString_Finish(&strColor); > + > + if(NS_SUCCEEDED(nsres)) { > + nsAString_GetData(&strColor, &color); > + V_VT(p) = VT_BSTR; > + hres = nscolor_to_str(color, &V_BSTR(p)); > + }else { > + ERR("SetBgColor failed: %08x\n", nsres); > + hres = E_FAIL; > + } I think you can't do GetData() after Finish().

1 0

Re: [PATCH] comctl32/tests: Fix a couple of uninitialized variables (Coverity)
by Marvin March 30, 2014

March 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6070 Your paranoid android. === wvistau64 (32 bit button) === button.c:654: Test failed: BM_SETCHECK on a button: the msg sequence is not complete: expected 0000 - actual 000f

2 1

Re: [PATCH 1/2] ole32: Fix equality check in CommonPrefixWith() for pointer moniker
by Marvin March 30, 2014

March 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6068 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A

1 0

Re: [1/2] ntdll/tests: Add tests for RtlUnicodeToUTF8N.
by Nikolay Sivov March 29, 2014

March 29, 2014

On 3/29/2014 20:16, Thomas Faber wrote: > + /* output truncation */ > +#define truncate_expect(len, out_len, expect_status) do { \ > + bytes_out = 0x55555555; \ > + memset(buffer, 0x55, sizeof(buffer)); \ > + status = pRtlUnicodeToUTF8N( \ > + buffer, len, &bytes_out, \ > + special_string, sizeof(special_string)); \ > + ok(status == (expect_status), "status = 0x%x\n", status); \ > + ok(bytes_out == (out_len), "bytes_out = %u\n", bytes_out); \ > + for (i = 0; i < bytes_out; i++) \ > + ok(buf[i] == special_expected[i], \ > + "buffer[%d] = 0x%x\n", i, buf[i]); \ > + for (; i < sizeof(buffer); i++) \ > + ok(buf[i] == 0x55, "buffer[%d] = 0x%x\n", i, buf[i]); \ > + } while (0) It's better to avoid large macros like this one. A common way to do that is to move code to another function and call it with a single line macro, for line information ok_() should be used.

2 1

How to cross-compile wine?
by Akira Nakagawa March 29, 2014

March 29, 2014

./configure --host=arm-linux-androideabi then it said --with-wine-tools was needed. What do I set to the option? -- Akira Nakagawa <matyapiro31(a)gmail.com>

1 0

MS releases vintage DOS source code
by Michael Stefaniuc March 28, 2014

March 28, 2014

Not directly relevant to us as DOS got outsourced to dosbox but here it is nevertheless: http://www.computerhistory.org/atchm/microsoft-ms-dos-2-0-source-code/ If they keep releasing the source roughly 30 years after the OS hit the market, then Windows 3.11 is still 10 years out. bye michael

3 2

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Alexandre Julliard March 28, 2014

March 28, 2014

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/rpcrt4/tests/server.c | 55 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 5 ++++ > 2 files changed, 60 insertions(+) It doesn't work on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M rpcrt4.dll -p rpcrt4_test.exe.so server && touch server.ok server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process make[1]: *** [server.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/6] winemac: Make ChangeDisplaySettingsEx() operate on the display named by the devname parameter.
by Ken Thomases March 28, 2014

March 28, 2014

Hi, The first two patches in this series aren't quite right. Please don't commit them. They don't do the right thing with the registry settings. Patches 3 through 6 can be applied independently and are useful, so they can still be committed. (Bug 34978 won't quite be solved because DisplayFusion will be confused by enumerating the wrong modes for the second display.) -Ken

1 0