April 2014 - Wine-Devel - list.winehq.org

Re: msvcp90: Added complex_float_pow impletation and tests
by YongHao Hu April 25, 2014

April 25, 2014

On Saturday, April 12, 2014 03:59 PM, YongHaoWu wrote: > --- > dlls/msvcp70/msvcp70.spec | 12 ++++----- > dlls/msvcp71/msvcp71.spec | 12 ++++----- > dlls/msvcp80/msvcp80.spec | 12 ++++----- > dlls/msvcp90/math.c | 18 ++++++++++++++ > dlls/msvcp90/msvcp90.spec | 12 ++++----- > dlls/msvcp90/tests/misc.c | 60 +++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 102 insertions(+), 24 deletions(-) >

1 0

Re: [4/6] shell32/tests: Use SEE_MASK_NO_CONSOLE with ShellExecuteExA.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6549 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1220: Test failed: expected 1 args, got 4 === w864 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\wtF77.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\wtF77.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2111: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\wtF77.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1565: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1565: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\wtFECD.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\wtFECD.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2111: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\wtFECD.tmp" Exec") succeeded: rc=42

1 0

Re: [3/5] user32: Our popup test window loses capture to itself.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6544 Your paranoid android. === w864 (64 bit win) === win.c:6436: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6458: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6436: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6458: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6436: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6458: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6219: Test failed: wrong error 31

1 0

Re: [2/5] user32: Add a message test for popup menus on windows that have capture.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6543 Your paranoid android. === w7u (32 bit msg) === msg.c:12092: Test failed: unexpected hwnd 00080140 msg.c:12114: Test failed: bad time 3298f/329ae === w864 (64 bit msg) === msg.c:6048: Test failed: Update region shouldn't be empty msg.c:6282: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6284: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6054: Test failed: Regions are different msg.c:6054: Test failed: Regions are different msg.c:6054: Test failed: Regions are different

1 0

Re: [1/5] user32: Add test calling EndMenu from WM_ENTERMENULOOP.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6542 Your paranoid android. === w7u (32 bit msg) === msg.c:12074: Test failed: unexpected hwnd 0009013C msg.c:12096: Test failed: bad time 312b5/312c4 === w864 (64 bit msg) === msg.c:6030: Test failed: Update region shouldn't be empty msg.c:6264: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6266: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6036: Test failed: Regions are different msg.c:6036: Test failed: Regions are different msg.c:6036: Test failed: Regions are different

1 0

Re: msxml3: complain louder if libxslt was missing at compile time
by Nikolay Sivov April 24, 2014

April 24, 2014

> + ERR_(winediag)("libxslt headers were not found at compile time. This is not supported, expect problems!\n"); I'm not sure if it's supported or not. It's allowed to build msxml3 without libxslt and some parts will work fine, but I can't imagine a real world situation when somebody really doesn't want to build with libxslt. In my opinion 'Expect problems.' (without exclamation mark) would be enough.

1 0

Re: [PATCH 3/3] ddraw/tests: Test P8 to RGB blits (try 2).
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6538 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045EB3B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00784A78. ddraw7: unhandled exception c0000005 at 0045EB3B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005DFE60. ddraw7: unhandled exception c0000005 at 0045EB3B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0077BEB8. ddraw7: unhandled exception c0000005 at 0045EB3B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000802980. ddraw7: unhandled exception c0000005 at 0000000000454871 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000006BFD90. ddraw7: unhandled exception c0000005 at 0000000000454871 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

2 1

Re: [4/4] ole32: Initial storage file locking implementation.
by Nikolay Sivov April 24, 2014

April 24, 2014

On 4/24/2014 00:10, Vincent Povirk wrote: > +static HRESULT StorageImpl_GrabLocks(StorageImpl *This, DWORD openFlags) > +{ > + HRESULT hr; > + ULARGE_INTEGER offset; > + ULARGE_INTEGER cb; > + DWORD share_mode = STGM_SHARE_MODE(openFlags); > + > + /* Wrap all other locking inside a single lock so we can check ranges safely */ > + offset.QuadPart = 0x7fffff92; > + cb.QuadPart = 1; > + hr = StorageImpl_LockRegionSync(This, offset, cb, LOCK_ONLYONCE); > + > + /* If the ILockBytes doesn't support locking that's ok. */ > + if (FAILED(hr)) return S_OK; > + > + hr = S_OK; > + > + /* First check for any conflicting locks. */ > + if (SUCCEEDED(hr) && (openFlags & STGM_PRIORITY) == STGM_PRIORITY) > + hr = StorageImpl_CheckLockRange(This, 0x80, 0x80, STG_E_LOCKVIOLATION); > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_WRITE)) > + hr = StorageImpl_CheckLockRange(This, 0xbb, 0xce, STG_E_SHAREVIOLATION); > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_READ)) > + hr = StorageImpl_CheckLockRange(This, 0xcf, 0xe2, STG_E_SHAREVIOLATION); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_READ || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_CheckLockRange(This, 0x93, 0xa6, STG_E_LOCKVIOLATION); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_WRITE || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_CheckLockRange(This, 0xa7, 0xba, STG_E_LOCKVIOLATION); > + > + /* Then grab our locks. */ > + if (SUCCEEDED(hr) && (openFlags & STGM_PRIORITY) == STGM_PRIORITY) > + { > + hr = StorageImpl_LockOne(This, 0x58, 0x7f); > + if (SUCCEEDED(hr)) > + hr = StorageImpl_LockOne(This, 0x81, 0x91); > + } > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_WRITE)) > + hr = StorageImpl_LockOne(This, 0x93, 0xa6); > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_READ)) > + hr = StorageImpl_LockOne(This, 0xa7, 0xba); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_READ || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_LockOne(This, 0xbb, 0xce); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_WRITE || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_LockOne(This, 0xcf, 0xe2); > + > + offset.QuadPart = 0x7fffff92; > + cb.QuadPart = 1; > + ILockBytes_UnlockRegion(This->lockBytes, offset, cb, LOCK_ONLYONCE); > + > + return hr; Maybe it'd be better to add some symbols for all these magic numbers? They are at least used twice in this functions, didn't look at others. Also it looks like it's possible to collapse it a bit, for example STGM_SHARE_EXCLUSIVE could check whole 0x93-0xba range with a single code, if I'm reading this right.

2 1

Re: [PATCH 4/5] wined3d: Store palettes in textures instead of in surfaces.
by Henri Verbeet April 24, 2014

April 24, 2014

On 24 April 2014 12:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Since palettes only really matter on frontbuffers we could also consider > removing them from wined3d entirely and performing the ddraw frontbuffer > present with a d3d draw and d3d shaders. This would mean that the shadow > frontbuffer remains in ddraw, and that Shader Model 2 cards are required > for hardware P8 conversion. (Unless we implement full d3d shader support > for older HW, which I consider unlikely.) Or we could just attach them to the swapchain.

2 3

Re: [PATCH 2/3] ddraw/tests: Add a test for mipmap palettes (try 2).
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6537 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045D69B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00774A78. ddraw7: unhandled exception c0000005 at 0045D69B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 008EFE60. ddraw7: unhandled exception c0000005 at 0045D69B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 002BBEB8. ddraw7: unhandled exception c0000005 at 0045D69B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000312980. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000322A20. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: mshtml: Added IConnectionPoint::EnumConnections implementation.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6536 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74 === w864 (32 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74 === w864 (64 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74

2 1

Re: [PATCH 3/5] ddraw/tests: Test P8 to RGB blits.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6535 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045EADB === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00314A78. ddraw7: unhandled exception c0000005 at 0045EADB === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005EFE60. ddraw7: unhandled exception c0000005 at 0045EADB === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 006DBEB8. ddraw7: unhandled exception c0000005 at 0045EADB === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000006E2980. ddraw7: unhandled exception c0000005 at 0000000000454811 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007E0720. ddraw7: unhandled exception c0000005 at 0000000000454811 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [PATCH 1/5] ddraw: Only ddraw7 disallows SetPalette on sublevels.
by Henri Verbeet April 24, 2014

April 24, 2014

On 24 April 2014 12:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (!(surface->surface_desc.u4.ddpfPixelFormat.dwFlags & (DDPF_PALETTEINDEXED1 | DDPF_PALETTEINDEXED2 > - | DDPF_PALETTEINDEXED4 | DDPF_PALETTEINDEXED8 | DDPF_PALETTEINDEXEDTO8))) > - return DDERR_INVALIDPIXELFORMAT; > - > if (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL) > return DDERR_NOTONMIPMAPSUBLEVEL; > Note that this inverts the ordering of the pixel format and sub-level validation. That might even be correct, but the associated test doesn't cover that case at all.

2 1

Re: [PATCH 2/5] ddraw/tests: Add a test for mipmap palettes.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6534 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045D69B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 002E4A78. ddraw7: unhandled exception c0000005 at 0045D69B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0092FE60. ddraw7: unhandled exception c0000005 at 0045D69B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0072BEB8. ddraw7: unhandled exception c0000005 at 0045D69B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007C2980. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000325470. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [2/2] dpnet: Improve Error checking in Get/Set SP (try 6 Resend)
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6531 Your paranoid android. === w864 (32 bit address) === The test timed out

1 0

Re: [1/2] dpnet: Use dxguid for tests (resend)
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6530 Your paranoid android. === w864 (64 bit peer) === The test timed out

1 0

Re: [4/4] ole32: Initial storage file locking implementation.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6527 Your paranoid android. === w2000pro (32 bit storage32) === storage32.c:3213: Test failed: file with mode 1012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11022 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11021 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 12 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 10012 should not be openable with WRITE permission

1 0

Re: [2/4] ole32: Add tests for sharing storages in transacted mode.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6526 Your paranoid android. === w2000pro (32 bit storage32) === storage32.c:3213: Test failed: file with mode 1012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11022 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11021 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 12 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 10012 should not be openable with WRITE permission

1 0

Re: [1/4] ole32: Add tests for storage locking.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6524 Your paranoid android. === w2000pro (32 bit storage32) === storage32.c:3213: Test failed: file with mode 1012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11022 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11021 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 12 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 10012 should not be openable with WRITE permission

1 0

Re: vbscript: Return proper error on invalid argument in Chr.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6517 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] ddraw: Validate the pitch for user memory surfaces against the unaligned minimum pitch.
by Marvin April 24, 2014

April 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045C03B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00314A78. ddraw7: unhandled exception c0000005 at 0045C03B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005BFE60. ddraw7: unhandled exception c0000005 at 0045C03B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0076BEB8. ddraw7: unhandled exception c0000005 at 0045C03B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000762980. ddraw7: unhandled exception c0000005 at 00000000004520D1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007150E0. ddraw7: unhandled exception c0000005 at 00000000004520D1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

GSoC 2014 - accepted proposals announcement
by Austin English April 23, 2014

April 23, 2014

The accepted proposals for Google's Summer of Code 2014 have been announced. We have accepted 4 proposals this year. * Implement missing and improve existing D3DX9 APIs - by Gediminas Jakutis, mentored by: Matteo Bruni and Stefan Dösinger * Implement ITextDocument::Range and ITextRange - by Jactry Zeng, mentored by Huw Davies and André Hentschel * Implement VBScript built-in functions - by Shuai Meng, mentored by Piotr Caban and Detlef Riekenberg * Implemention for mshtml.dll - by Zhenbo Li, mentored by Jacek Caban and Ulrich Czekalla Congratulations! Students, this is the community bonding period ( http://googlesummerofcode.blogspot.com/2007/04/so-what-is-this-community-bo…) which you should use to get up to speed on your project. In other words, discuss your goals/milestones with your mentors, reviewing bugs in those areas, reading the code, etc. Coding begins May 19th, and mid term reviews are June 23-27th. If you have any GSoC questions, please contact your mentors or the administrators (myself and André Hentschel). Technical questions should be discussed with your mentor or on wine-devel/#winehackers on Freenode IRC. Once again, congratulations! Welcome to Wine, and good luck on your project. -- -Austin

1 0

Re: wined3d: Add NVIDIA Geforce GTX 780 Ti to supported device list
by Henri Verbeet April 23, 2014

April 23, 2014

On 23 April 2014 00:17, André Hentschel <nerv(a)dawncrow.de> wrote: > Information gathered at: > http://pci-ids.ucw.cz/read/PC/10de > https://freedesktop.org/nouveau/CodeNames/ > http://www.nvidia.de/object/geforce-gtx-780-ti-de.html#pdpContent=2 > > Should i rather add a whole bunch of cards using these sources of information? > I'd prefer this kind of patch to be verified against the actual Windows and Linux drivers.

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Jacek Caban April 23, 2014

April 23, 2014

On 04/23/14 02:20, Shuai Meng wrote: > --- a/dlls/vbscript/global.c > +++ b/dlls/vbscript/global.c > @@ -557,8 +557,41 @@ static HRESULT Global_IsNull(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VA > > static HRESULT Global_IsNumeric(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + if(res) { > + V_VT(res) = VT_BOOL; You can't assume that res is non-NULL. > + switch(V_VT(arg)) { > + case VT_UI1: > + case VT_I2: > + case VT_I4: > + case VT_I8: > + case VT_R4: > + case VT_R8: > + case VT_BOOL: > + case VT_EMPTY: > + case VT_CY: > + V_BOOL(res) = VARIANT_TRUE; > + break; > + case VT_BSTR: { > + HRESULT hRet; > + double d; > + > + hRet = VarR8FromStr(V_BSTR(arg), LOCALE_USER_DEFAULT, 0, &d); > + if(SUCCEEDED(hRet)) > + V_BOOL(res) = VARIANT_TRUE; > + else > + V_BOOL(res) = VARIANT_FALSE; > + break; > + } > + default: > + V_BOOL(res) = VARIANT_FALSE; > + break; That's a risky assumption. There are tons of other VT_* types possible and at least VT_UI2, VT_UI4 and alike should most likely return true. It's much safer to add explicit list of *tested* cases to return false and FIXME(); return E_NOTIMPL for other cases. > + } > + } > + return S_OK; > } > > static HRESULT Global_IsArray(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index beee4d4..cf63fb9 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -170,6 +170,25 @@ Call ok(not isNull(4), "isNull(4) is true?") > Call ok(not isNull("x"), "isNull(""x"") is true?") > Call ok(isNull(Null), "isNull(Null) is not true?") > > +Call ok(isNumeric(empty), "isNumeric(empty) is not true?") > +Call ok(not isNumeric(Null), "isNumeric(Null) is not true?") > +Call ok(isNumeric(32767), "isNumeric(32767) is true?") > +Call ok(isNumeric(32768), "isNumeric(32768) is true?") > +Call ok(isNumeric(CSng(3242.4)), "isNumeric(CSng(3242.4)) is true?") > +Call ok(isNumeric(32768.4), "isNumeric(32768.4) is true?") > +Call ok(isNumeric(CCur(32768.4)), "isNumeric(CCur(32768.4)) is true?") > +Call ok(not isNumeric(CDate(32)), "isNumeric(CDate(32)) is true?") > +Call ok(isNumeric("44"), "isNumeric(""44"") is true?") > +Call ok(not isNumeric("rwrf"), "isNumeric(""rwrf"") is not true?") > +Call ok(not isNumeric(Nothing), "isNumeric(Nothing) is not true?") > +Call ok(not isNumeric(New EmptyClass), "isNumeric(New EmptyClass) is not true?") > +Call ok(isNumeric(true), "isNumeric(true) is true?") > +Call ok(isNumeric(CByte(32)), "isNumeric(CByte(32)) is true?") > +Dim arr(2) > +arr(0) = 2 > +arr(1) = 3 > +Call ok(not isNumeric(arr), "isNumeric(arr) is not true?") > + > Call ok(getVT(err) = "VT_DISPATCH", "getVT(err) = " & getVT(err)) > Your tests depend on your previous patches that were not committed and I already commented them. Please concentrate on getting them committed first. Jacek

1 1

Re: imagehlp: Implement (parts of) BindImageEx (try 4)
by Marvin April 23, 2014

April 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6512 Your paranoid android. === w2000pro (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINNT\system32\KERNEL32.DLL === wxppro (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\system32\KERNEL32.DLL === wvista (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w2008s64 (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w7u (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w864 (32 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\SYSTEM32\KERNEL32.DLL === w2008s64 (64 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 === w864 (64 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\SYSTEM32\KERNEL32.DLL

1 0