April 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 4/5] d3dx9: Copy the entire vector at once if there is no need of type conversions.
by Henri Verbeet April 14, 2014

April 14, 2014

On 14 April 2014 19:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -740,6 +740,12 @@ static void set_vector(struct d3dx_parameter *param, const D3DXVECTOR4 *vector) > { > UINT i; > > + if (param->type == D3DXPT_FLOAT) > + { > + memcpy(param->data, vector, param->columns * sizeof(float)); > + return; > + } > + When called from d3dx9_base_effect_set_vector_array(), this is not quite optimal either.

1 0

Re: [PATCH 5/5] ddraw/tests: Try to make test_coop_level_mode_set() more reliable.
by Marvin April 14, 2014

April 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6316 Your paranoid android. === w2000pro (32 bit ddraw2) === The test timed out === w2000pro (32 bit ddraw1) === The test timed out === w2000pro (32 bit ddraw7) === The test timed out === w2000pro (32 bit ddraw4) === The test timed out

1 0

Re: [advapi32] add stub for GetTraceLoggerHandle (try 2)
by Nikolay Sivov April 14, 2014

April 14, 2014

On 4/14/2014 12:11, Vijay Kiran Kamuju wrote: > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} It's still not fixed.

1 0

Re: [advapi32] add stub for GetTraceLoggerHandle (try 2)
by Dmitry Timoshkov April 14, 2014

April 14, 2014

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} What this API is supposed to return? -- Dmitry.

1 0

Re: typo fixes
by Nikolay Sivov April 14, 2014

April 14, 2014

> +++ b/documentation/ChangeLog.ALPHA This file doesn't exist any more, so you need to rebase.

1 0

Re: typo fixes
by Marvin April 14, 2014

April 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6317 Your paranoid android. === build (build) === Patch failed to apply

1 0

typo fixes
by Veres Lajos April 13, 2014

April 13, 2014

Hi, I attached a patch with a few typo fixes. I created it a few months ago... I hope it applies easily. Thanks! Best regards, -- Veres Lajos vlajos(a)gmail.com +36 20 438 5909

1 0

Re: [advapi32] Add stub for GetTraceLoggerHandle
by Nikolay Sivov April 13, 2014

April 13, 2014

> /****************************************************************************** > + * EnableTrace [ADVAPI32.@] > + */ > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} It returns trace handle, not an error code. Comment is wrong too.

2 1

Re: [advapi32] Add stub for GetTraceLoggerHandle
by Dmitry Timoshkov April 13, 2014

April 13, 2014

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > /****************************************************************************** > + * EnableTrace [ADVAPI32.@] > + */ What does this belong to? > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} What this API is supposed to return? > + > +ULONG WINAPI EnableTrace( ULONG enable, ULONG flag, ULONG level, LPCGUID guid, TRACEHANDLE hSession ) > +/****************************************************************************** What's that? -- Dmitry.

2 1

Recent 64-bit kernel breaks Win16 apps
by Jan Janecek April 12, 2014

April 12, 2014

See the discussion on LKML: http://lkml.org/lkml/2014/4/11/514

1 0