May 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] msxml3: removed unused allocation (Coverity)
by Marvin May 20, 2014

May 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7177 Your paranoid android. === w2008s64 (32 bit domdoc) === Unable to set the VM system time: the "nc -q0 '10.42.42.136' '4242'" command returned 1

1 0

Re: [2/2] server: Clear the queue's QS_SMRESULT bit when sending a new message.
by Alexandre Julliard May 19, 2014

May 19, 2014

Vincent Povirk <madewokherd(a)gmail.com> writes: > This keeps the QS_SMRESULT bit in sync with the reply status of the > most recent sent message, if it happens that the > previously-most-recent sent message already has a reply. > wait_message_reply depends on this to work correctly. I believe you'll also need to set it again when the result is removed. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/3] user32: Don't rely on HMENU for showing popups
by Alexandre Julliard May 19, 2014

May 19, 2014

Andrew Eikum <aeikum(a)codeweavers.com> writes: > The idea here is to push the conversions from HMENU to struct pointer > up the call stack until eventually we are only converting to/from > HMENUs near the client code border, so we don't depend on HMENU > internally at all. To do this right, you'd want to increase the refcount every time you get a pointer. Otherwise the pointer could become invalid as soon as control is transferred to the app through SendMessage (not that the current code always gets it right, but when using handles the problem is much reduced). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: vbscript: Support multibyte characters in Global_Chr
by Marvin May 19, 2014

May 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7147 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] mmdevapi: Clock rate should be in bytes for shared mode
by Marvin May 19, 2014

May 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7145 Your paranoid android. === w7u (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.501088 render.c:2005: Test failed: Got wrong volume: 0.501088 === w8 (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.671337 render.c:2005: Test failed: Got wrong volume: 0.671337

1 0

Re: [PATCH 1/2] mmdevapi: Make buffer size divisible by number of periods
by Marvin May 19, 2014

May 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7144 Your paranoid android. === w7u (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.501088 render.c:2005: Test failed: Got wrong volume: 0.501088 === w8 (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.671337 render.c:2005: Test failed: Got wrong volume: 0.671337

1 0

Re: [PATCH] vbscript: Implemented CCur
by Piotr Caban May 19, 2014

May 19, 2014

On 05/19/14 08:47, Shuai Meng wrote: > +Call ok(CCur(0.000149) = 0.0001, "CCur(0.000149) = " & CCur(0.000149)) > +Call ok(getVT(CCur(0.000149)) = "VT_CY", "getVT(CCur(0.000149)) = " & getVT(CCur(0.000149))) > +Call ok(CCur(2147483647.99) = 2147483647.99, "CCur(2147483647.99) = " & CCur(2147483647.99)) > +Call ok(getVT(CCur(2147483647.99)) = "VT_CY", "getVT(CCur(2147483647.99)) = " & getVT(CCur(2147483647.99))) This tests are failing on polish locale. > +Call ok(CCur(MyObject) = 0, "CCur(MyObject) = " & CCur(MyObject)) > +Call ok(getVT(CCur(MyObject)) = "VT_CY", "getVT(CCur(MyObject)) = " & getVT(CCur(MyObject))) > +MyObject.myval = 1 > +Call ok(CCur(MyObject) = 1, "CCur(MyObject) = " & CCur(MyObject)) > +Call ok(getVT(CCur(MyObject)) = "VT_CY", "getVT(CCur(MyObject)) = " & getVT(CCur(MyObject))) > +MyObject.myval = 0 > +Call ok(CCur(MyObject) = 0, "CCur(MyObject) = " & CCur(MyObject)) > +Call ok(getVT(CCur(MyObject)) = "VT_CY", "getVT(CCur(MyObject)) = " & getVT(CCur(MyObject))) There are two identical tests on MyObject. MyObject.myval is set to 0 in first test (it's set this way in earlier tests). Thanks, Piotr

2 2

Re: shell32: Fix SHFileOperation when deleting a nonexistent directory.
by Alexandre Julliard May 19, 2014

May 19, 2014

Zhenbo Li <litimetal(a)gmail.com> writes: > @@ -353,8 +353,13 @@ static BOOL SHELL_DeleteDirectoryW(HWND hwnd, LPCWSTR pszDir, BOOL bShowUI) > HANDLE hFind; > WIN32_FIND_DATAW wfd; > WCHAR szTemp[MAX_PATH]; > + DWORD attrib; > > /* Make sure the directory exists before eventually prompting the user */ > + attrib = GetFileAttributesW(pszDir); > + if (attrib == INVALID_FILE_ATTRIBUTES || !(attrib & FILE_ATTRIBUTE_DIRECTORY)) > + return FALSE; It would be better to avoid a redundant file lookup, particularly since it's only to set last error (which BTW you are not setting at all in the non-directory case). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [website] German translation for release 1.7.19
by Frédéric Delanoy May 19, 2014

May 19, 2014

On Sun, May 18, 2014 at 5:40 PM, Julian Rüger <jr98(a)gmx.net> wrote: > Hi Frédéric, > >> "writer" should probably be translated as well... > > I don't think there is a useful translation that is not clunky or sounds > awkward. Plus, "writer" is probably a familiar term to most users > because of i.e. LibreOffice Writer. LibreOffice Writer is an English product name, and maybe not known to non-techies (it's just a word processing application to them) IMHO. In German, it should probably be something like Redaktor, but you know German better than me ;-) Frédéric Delanoy

2 1

Re: msi: Prevent call to memset with a nullptr in get_tablecolumns function
by Hans Leidekker May 19, 2014

May 19, 2014

On Sun, 2014-05-18 at 13:27 -0400, Daniel Beitler wrote: > This is a fix for bug #36139. > > It looks like calling memset with a nullptr is undefined behavior. Gcc > 4.9 will actually optimize out the "if(colinfo)" condition if memset was > called on colinfo before. > > > --- > dlls/msi/table.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Looks good, thanks.

1 0

Re: [patch]Japanese Translation update
by Akihiro Sagawa May 18, 2014

May 18, 2014

On Fri, 16 May 2014 10:08:47 -0400 (EDT), Toshiaki Hirose wrote: > From 67e0fca928a2f2de03adaf96f7a1f8f55e2cf85d Mon Sep 17 00:00:00 2001 > Message-Id: <67e0fca928a2f2de03adaf96f7a1f8f55e2cf85d.1400248197.git.t_hirose(a)aol.com> > From: Toshiaki Hirose <t_hirose(a)aol.com> > Date: Fri, 16 May 2014 22:49:46 +0900 > Subject: [PATCH] Japanese Translation Update for 1.7.18 > > --- > po/ja.po | 172 ++++++++++++++++++++++++--------------------------------------- > 1 file changed, 65 insertions(+), 107 deletions(-) Hello Hirose-san, Your translation is getting better, but it needs some more work. Could you read my comments and submit again? I also welcome your feedback. > #: oleacc.rc:97 > -#, fuzzy > #| msgid "Normal" > -msgctxt "object state" > msgid "normal" > -msgstr "標準" > +msgstr "normal" Msgctxt line can't be removed. The line indicates message context, and is used with msgid to specify translation. > #: oleacc.rc:98 > #: oleacc.rc:99 : : > #: oleacc.rc:128 Same as above. > #: regsvr32.rc:41 > msgid "" > "regsvr32: Invalid or unrecognized switch [%1]\n" > "\n" > msgstr "" > +"regsvr32: 無効または認識できない切り替えです[%1]\n" > +"\n" I'm not sure about this translation. This `switch' means `command-line switch'. In that case, we usually translate into `スイッチ'. For instance, see http://support.microsoft.com/kb/227091/ja vs http://support.microsoft.com/kb/227091/en-us . > #: regsvr32.rc:46 > msgid "regsvr32: Failed to unregister DLL '%1'\n" > -msgstr "" > +msgstr "regsvr32: DLL '%1'の登録消去に失敗しました。\n" You removed some full-stops, but didn't about this line. > #: regsvr32.rc:49 > msgid "regsvr32: Successfully installed DLL '%1'\n" > -msgstr "" > +msgstr "regsvr32: DLL '%1'のインストールに成功しました。\n" Ditto. Otherwise looks fine. Regards, Akihiro Sagawa

1 0

Re: [website] German translation for release 1.7.19
by André Hentschel May 18, 2014

May 18, 2014

Am 17.05.2014 02:10, schrieb Julian Rüger: > +<date>16. Main 2014</date> -n, everything else is fine ;)

3 2

msvcp90/msvcp90.h: right-hand operand of comma expression has no effect
by Gerald Pfeifer May 18, 2014

May 18, 2014

Building git head with GCC development sources (soon to be GCC 4.9.0) gives me the following warnings ../msvcp90/msvcp90.h:529:75: warning: right-hand operand of comma expression has no effect [-Wunused-value] ../msvcp90/msvcp90.h:530:77: warning: right-hand operand of comma expression has no effect [-Wunused-value] several times. Digging into this in more detail I see ../msvcp90/ios.c: In function 'basic_streambuf_char__Xsgetn_s': ../msvcp90/msvcp90.h:529:75: warning: right-hand operand of comma expression has no effect [-Wunused-value] #define memcpy_s( dst, size, src, count ) (memcpy( (dst), (src), (count) ), 0) ^ ../msvcp90/ios.c:1218:13: note: in expansion of macro 'memcpy_s' memcpy_s(ptr+copied, size, *this->prpos, chunk); ^ Someone must have written that code intentionally, so I am wondering how to best address this. Gerald

2 2

Re: shell32: Fix SHFileOperation when deleting a nonexistent directory.
by Marvin May 17, 2014

May 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6958 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

2 2

Re: vbscript: Parse doubles with bigger precision in parse_numeric_literal
by Marvin May 16, 2014

May 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7112 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: gdi32/tests: tmLastChar is solely governed by the last entry before 0xffff in the cmap.
by Marvin May 16, 2014

May 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7109 Your paranoid android. === w2000pro (32 bit font) === font.c:5076: Test failed: got 00a8 === wxppro (32 bit font) === font.c:5076: Test failed: got 00a8 === wvistau64 (32 bit font) === The test timed out === w2008s64 (32 bit font) === font.c:5076: Test failed: got 00a8 === w7u (32 bit font) === font.c:5076: Test failed: got 00a8 === w8 (32 bit font) === font.c:5076: Test failed: got 00a8 === wvistau64 (64 bit font) === font.c:5076: Test failed: got 00a8 === w2008s64 (64 bit font) === font.c:5076: Test failed: got 00a8

3 2

Wine Test analysis, report
by Jeremy White May 16, 2014

May 16, 2014

Just wanted to report that I do periodically do my analysis. It looks as though the test bot is beginning to be usable again, although the results are currently ugly: http://www.winehq.org/~jwhite/fba08e34c447.html I'm waiting for Francois to report that things are essentially operational again; until I get that word, I'm not planning to beat the drum. Francois, can we get an update? Cheers, Jeremy

7 8

Re: audio reset failed
by Pawel Por May 16, 2014

May 16, 2014

>>* I receive periodically the following error popup window: *>>* "Audio Reset Failed: Access violation at address 7BC503AA in module *>>* 'ntdll.dll'. Write of address F818611C" * >What is displaying this message? Wine itself does not contain the >message "Audio Reset Failed." This message is from the application that generates text voice messages using SAPI4 voices. This application works perfectly under wine launched in 32 bit linux. >>* When it occurs the audio hangs up and only the restart of the wine *>>* application helps. * >There is a list of sound-related debug log channels at ><http://wiki.winehq.org/Sound>. Getting a debug log with those >channels set could give us a clue as to what's going wrong. I've upgraded wine to version wine 1.7.18 (Arch Linux). I still receive the message: "Audio Reset Failed: Access violation at address 7BC4D272 in module 'ntdll.dll'. Write of address F82A011C" This time I've run wine with the following debug channels: +tid,+mmdevapi,+winmm,+driver,+msacm,+midi,+dsound,+dsound3d,+dmusic,+mci,+oss,+alsa,+coreaudio. I've attached the log. Please write me if I can provide anything else. Great thanks for your help.

2 1

Re: mshtml: Added IHTMLLocation::assign method implementation.
by Nikolay Sivov May 16, 2014

May 16, 2014

> HTMLLocation *This = impl_from_IHTMLLocation(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(bstr)); > - return E_NOTIMPL; > + TRACE("(%p)->(%s)\n", This, debugstr_w(bstr)); > + return HTMLLocation_put_href(iface, bstr); I don't know if it correct or not, but please use method wrappers when calling from interface pointer instead of calling implementation directly.

1 0

Re: dpnet: Stub interface IDirectPlay8LobbyClient (try 3)
by Alexandre Julliard May 16, 2014

May 16, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/dpnet/Makefile.in b/dlls/dpnet/Makefile.in > index 541e104..70ccef0 100644 > --- a/dlls/dpnet/Makefile.in > +++ b/dlls/dpnet/Makefile.in > @@ -7,6 +7,7 @@ C_SRCS = \ > client.c \ > dpnet_main.c \ > lobbiedapp.c \ > + lobbyclient.c \ > peer.c \ > server.c \ > threadpool.c Please merge that code into some existing files, we don't need so many new files. -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: [PATCH 2/5] wined3d: Set palettes on the swapchain.
by Henri Verbeet May 16, 2014

May 16, 2014

On 15 May 2014 14:33, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/palette.c b/dlls/wined3d/palette.c > index 3f7e2ad..780f068 100644 > --- a/dlls/wined3d/palette.c > +++ b/dlls/wined3d/palette.c > @@ -136,8 +136,8 @@ HRESULT CDECL wined3d_palette_set_entries(struct wined3d_palette *palette, > if (resource->type == WINED3D_RTYPE_SURFACE) > { > struct wined3d_surface *surface = surface_from_resource(resource); > - if (surface->palette == palette) > - surface->surface_ops->surface_realize_palette(surface); > + if (surface->swapchain && surface->swapchain->palette == palette) > + surface->swapchain->swapchain_ops->swapchain_realize_palette(surface->swapchain); > } > } > I don't think this kind of thing should be needed. You should be able to make the palette texture that currently lives in the ARB program shader backend a property of the wined3d palette, and then presents can just make sure the palette texture is current. Something similar, if perhaps slightly more involved, should be possible for the GDI swapchain with GDI palettes.

2 3

Re: [PATCH 4/5] d2d1: Add the ID2D1RenderTarget interface.
by Jacek Caban May 16, 2014

May 16, 2014

Hi Henri, On 05/16/14 09:59, Henri Verbeet wrote: > diff --git a/dlls/d2d1/d2d1_main.c b/dlls/d2d1/d2d1_main.c > index 9a389a2..d1e5e8f 100644 > --- a/dlls/d2d1/d2d1_main.c > +++ b/dlls/d2d1/d2d1_main.c > @@ -21,6 +21,9 @@ > #include "wine/port.h" > #include "wine/debug.h" > > +#include "winbase.h" > +#include "winuser.h" > +#undef DrawText It's probably better to place such #undef in .idl file itself (inside cpp_quote). That's what we already do in quite a few places and it avoids the need for hacking every .c file using the header. Jacek

1 0

Re: mshtml: Fixed a few more IE11 test failures.
by Marvin May 15, 2014

May 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7098 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74 === w8 (32 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74

1 0

Re: audio reset failed
by Pawel Por May 15, 2014

May 15, 2014

> An HTML attachment was scrubbed... > URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20140513/8f5f34ee/at…> I've uploaded the wine log at (37 KB): http://www.sendspace.pl/en/file/294794be77c2a1703e60d94 thanks for your help

2 1

Re: [PATCH 7/7] oleacc: Add WindowFromAccessibleObject implementation
by Marvin May 15, 2014

May 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7083 Your paranoid android. === wxppro (32 bit main) === main.c:104: Test failed: GetRoleTextA returned not zero-length buffer : (t)

1 0