May 2014 - Wine-Devel - list.winehq.org

Re: dpnet: Implement IDirectPlay8LobbiedApplication Initialize (try 2)
by Stefan Dösinger May 2, 2014

May 2, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-02 07:26, schrieb Alistair Leslie-Hughes: > Hi, Remove the Initial value from Create function. The changes of > spaces was done on purpose, future patches will change the other > places. > > Changelog: dpnet: Implement IDirectPlay8LobbiedApplication > Initialize Looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTY2cZAAoJEN0/YqbEcdMwKTgP/1rHmFZTq7GVcDfVyvjgrJvv BQmCMFJZs0/DYgy0+D+ZR5UccLaaoJD75+GyWjSuw2AITOHJ2q8kyREAms4nNQiR /DUa4ZDMeCFfVuC7aStSal2LOiMEqfZycrHa5ryu189mhoyObOT+xQtRa19rzxuJ OLN4IDe0eOSx1KyShiFzYueLY+oNnIf5IJ/omCTfvug5xPP45ZUby74VTXzmahD3 FU+oEBisuv2vXC7mHCjIsWUCadOh1G3UHtZ39/w/70Yj9HaxGipq6bxN4CD/5gho 99qy5JqqE+88gLTjgvsAFGoUpXCdc6k2hQXW9FviV/PbIYFy62tzmpmicmHVknKO XKrRP74l4bI4QutTxBOwN4d2SmGhFD/y8n0oi1c6SgwgfzdMO9nEv3Bx4F7d+pzi JZJnN7A++j5OInGow4xHd1b6oui55MLIMtbW3QJ7auBM+Ue0tB68UKYcrZkPYb29 JpmxFoNSJbqGAhw+0YH5KiemYKb7y/KD7uctrKodsbzQJFqA5gGEUTrTj7h2mo4+ kws3INzZlWJLMIoreaxtfNCco+SFtYIhD72io9KGSdIXc92GJOLTcG0JHXNC709s Rr3Ttl7hnYN6Y6YZsCpZQKE29ZsivUVUs4idL2AuYzHlUWbdJm3RUTRQVF7ncM2f OScvgQEx3PjLqCg861pY =pRHL -----END PGP SIGNATURE-----

1 0

Re: dpnet: Store DPN_SP_CAPS as part of the object
by Stefan Dösinger May 2, 2014

May 2, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-02 07:58, schrieb Alistair Leslie-Hughes: > +void init_dpn_sp_caps(DPN_SP_CAPS * pdpspCaps) DECLSPEC_HIDDEN; Why do you need the declaration in the header file? As far as I can see you're calling it from one file only. If you'll need it in a later patch just add it in the patch that needs it and keep the function static for now. Please avoid the Hungarian notation ("pdpspCaps") in new code. While you're at it: The placement of the * is inconsistent with the rest of the code. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTY2axAAoJEN0/YqbEcdMwOGYP/12lXZrx8HnEa1y1N3VHd/7W DMA9os0kqxyEuvBO0+4QCaTi8s8yjhlA0034xK4Tjl+ZYCy3sK8cx+1q1sM4PV2L XYxaRxddqWtNkuEVXbm9Kcq/P+xIzv+d8zcZ0j8WcPOX2fn0Y6YTyBGDHKQZGq/y QFLN1rLDoUksJ78L6Ik7s6zalGLmPw3SeZ7vsTvjiEaXBbbj/wBXy1LY/I4lVxXO uleeQpApV/h/3ul5mne9hnU5SkpskW6ECaNTW1ggmxA+GCSzy0UGK7Cd+LOb/gL+ wLaFXzdBop25LyGygNuzd6w+SwZ2VULPJY+IwVvZvprGMMQYYxrrdtc6B5kgJm51 tpitxyX/s2IqJUFDLPOp5yDUowmfrNWlrptS6iOjJ/j8g29PvTz4MAmoABm8UHm+ eDYUsn1jQhWp9zA7cuZL5G9JpxA7hY5xwlttBZLHqyYWzsNqC0c0XELwp6sCMAqx rH9RmFNH/Oo75puFav0YdfIQ1Zwmt8wgnaobFS1COIZ8u3gXAc36HsrPfQiaPIPQ TYiO7EwPAFx3+Tz1FHNln/PjUnbbND7s5KJtRs9CxVMiGnN3oyw7wNRyB7HbKP0u YcMXCTv6MlpMnFVSXM7zf0E1ahxTmMY3Z6qr+Y/N3EQVY+vHKxNBlXNZsaLfiJqj 8aXBZ1QdgGJ//Jn0dn3d =VadZ -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Client Initialize
by Stefan Dösinger May 2, 2014

May 2, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-01 07:41, schrieb Alistair Leslie-Hughes: > +START_TEST(client) > +{ > + test_init_dp(); > + test_enum_service_providers(); > + test_enum_hosts(); > + test_get_sp_caps(); > + test_cleanup_dp(); > +} I think that needs splitting. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIbBAEBAgAGBQJTYn8SAAoJEN0/YqbEcdMwonoP9A8x5zWuCAlVxAVYi9Hsz7yL jkSay3KVxAmyU1mkboG3LBVEQP/ZSkD99oXlu2t/++GL2+FZuX9ms9vJNSxmETQn WBdu9LRqqh8QrGKuKjdyjr8aPzphqAkwNkfbHFpfvTZ9WDGqSXV2atv7pFB7ytfH 4Qrs//RYXE6n6feQB2LGSp6faupX+SGWA5hAKyWD3oKUthMNTo4C9lCjeBKg7az1 kvY45VbTthruv+YHuPnMBZk/hH5yZpxhyrM7yvBwMz/raia05Rf4Ok9xrp8FVX9k IyYX+vgYWi5OtK5XRtpwih3qpnk1v975owTcHmK/ngU2g/wkCmYszXhs+1t5hVti e4rMDByQXXgdFKV0w9uT1YnUwqgRIFMizKGLmBEougFzjtUVndXwK4U7tE0ar2Pd wwDnkQ5m0mcpZ2X690aGqnXhXg8hxsvMCFEDNQvwStH/2d1+2qpjrkaZ5WSW5W7E kEn1tTcqipoK2AVZ49ZXBa6xdtPn/ZafK3YWzwv5nvv52BhL7XE3HIByZvcuD5IM LdEr3O0xVojJLRoJ7f9dzUJWK+Fgi5TvVRMabzYEMemLWfQLEuNIZvse7JvXXu+5 bomwR2QR8+2+xv1L60CbMVepidN8bduQXNyzQdE974ZeK8ahLxWvUBS8mAlmb9aF /xU3BmBfPBwIVQIxw+s= =MrVx -----END PGP SIGNATURE-----

2 1

Re: [PATCH] vbscript: Fixed CBool(try 3)
by Marvin May 2, 2014

May 2, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6732 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: dpnet: Implement IDirectPlay8LobbiedApplication Initialize
by Stefan Dösinger May 1, 2014

May 1, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-01 07:42, schrieb Alistair Leslie-Hughes: > static HRESULT WINAPI IDirectPlay8LobbiedApplicationImpl_RegisterProgram(IDirectPlay8LobbiedApplication *iface, > @@ -191,6 +201,11 @@ HRESULT DPNET_CreateDirectPlay8LobbiedApp(LPCLASSFACTORY iface, LPUNKNOWN punkOu > } > app->IDirectPlay8LobbiedApplication_iface.lpVtbl = &DirectPlay8LobbiedApplication_Vtbl; > app->ref = 0; > + app->msghandler = NULL; > + app->flags = 0; > + app->usercontext = NULL; > + app->connection = NULL; This is redundant, HEAP_ZERO_MEMORY clears that for you. Also, in the other patches you changed the indentation to 4 spaces, but not here. If this was intentional I'm fine with that - just pointing it out. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTYn7KAAoJEN0/YqbEcdMwV2UP/jkWB0vY5CLO+A0z9JISmIJT V+dlgPTTWHYgxTVBpDVoBlfYl3vmVTqoHPMExWef8lts0Dx1+Gv0pDQZpwUFXJ9P 9jOBZsuyNwcwU1uSm8BvFXQFWs6XCUoQn9nHC5Y9GNezLQy4KRpPX3xkHf1QuHZw CI/Z8oLwcHT9zy4uWUcYe1ciATCRHx9noLFR7cHIIkOuI1kakptX1DYMp39uo7Hg qah9QP+yA88MDnXQlUSLOSui0dd7lmbqPTHwsHAm8VCgUWUdqFIT0Yt5kITxZjyW tKz1XM7aRZ+V4kbdg8R7PbmFdent/xa79ceOnOIg5MQEWc3LBY+ynh5vgAqEUgAA ynIFlJMyB09D9JRVKj6ETxoIrx+m+FN/z6xD66GvD9ehqQZXH8v+fUc+xyGg0d5o Yj+2R0HJLUEtN7h3n1o9+8EJ6YhmceyOnu7OtrSN7Mapw7qXT4aESSCiRy8j7c1T fy3qvPrmEPRjCN8e1Tu0IJn4EyQl6Eke9BB4CXtuxhOgNC+Z2GekgU1k4Dj78iiQ VXpD9jw/CblEYv+iu4Lvo+E76nHMvF4R0M/UooS+urSnIfKGiNSorMCJOQ+xM1hs b634KfA1gpfq/foDRY0pVcxQVEbN5nKS8vAiv7wul/bhIoWMAZr2DktBdYP08Ye2 pbmU+Nd4X5lclBbj2Rnq =jFdr -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/6] wined3d: Validate and handle query size parameter.
by Marvin May 1, 2014

May 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6720 Your paranoid android. === w864 (32 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000). === w864 (64 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000).

1 0

Re: [PATCH 1/6] d3d9/tests: Test GetData behavior with various size values.
by Marvin May 1, 2014

May 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6719 Your paranoid android. === w864 (32 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000). === w864 (64 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000).

1 0

Re: [PATCH] vbscript: Fixed CBool(try 2)
by Piotr Caban May 1, 2014

May 1, 2014

On 05/01/14 10:16, Shuai Meng wrote: > Changelog: > added tests on object subtype. > improved CBool. > > https://newtestbot.winehq.org/JobDetails.pl?Key=6689 > > --- > dlls/vbscript/global.c | 41 > ++++++++++++----------------------------- > dlls/vbscript/tests/api.vbs | 42 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 29 deletions(-) The tests are not passing on wine: run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" These are the failing tests: Call testCBoolError("#TRUE#", 458) Call testCBoolError("#FALSE#", 458) Call testCBoolError(MyObject, 458) Could you please also add following tests: MyObject.myval = 1 Call ok(CBool(MyObject) = True, "CBool(MyObject) = " & CBool(MyObject)) MyObject.myval = 0 Call ok(CBool(MyObject) = False, "CBool(MyObject) = " & CBool(MyObject))

3 3

Re: [PATCH 11/11] oleacc: Add tests for default client accessible object (try2)
by Marvin May 1, 2014

May 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6716 Your paranoid android. === w2000pro (32 bit main) === main.c:347: Test failed: V_I4(&v) = 8000 === w2008s64 (64 bit main) === main.c:223: Test failed: wparam = 0 main.c:229: Test failed: unexpected (-12) === w864 (64 bit main) === main.c:223: Test failed: wparam = 0 main.c:229: Test failed: unexpected (-12)

1 0

Re: [PATCH 11/11] oleacc: Add tests for default client accessible object
by Marvin May 1, 2014

May 1, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6714 Your paranoid android. === build (build) === Unable to regenerate dlls/oleacc/Makefile Unable to regenerate dlls/oleacc/Makefile

1 0