June 2014 - Wine-Devel - list.winehq.org

Re: msvcr110: Fix typo in exported symbol _set_SSE2_enable.
by Piotr Caban June 16, 2014

June 16, 2014

Hi, You need to generate the patch on top of newest wine from git. Cheers, Piotr

1 0

Re: ole32: Return the correct error in FileLockBytesImpl_*LockRegion*().
by Vincent Povirk June 16, 2014

June 16, 2014

It looks to me like locks that fail due to conflicts will set ERROR_LOCK_VIOLATION, not ERROR_ACCESS_DENIED. We should probably add some tests for the error to the LockFileEx tests. I'd also be interested in what Windows returns on a filesystem that doesn't support locking, if such a thing exists.

1 0

Re: ole32: Fix StorageImpl_LockRegionSync() to actually wait between locking attempts.
by Vincent Povirk June 16, 2014

June 16, 2014

Oops. Thanks for the fix. On Mon, Jun 16, 2014 at 11:23 AM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/ole32/storage32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c > index 757138d..49d16fd 100644 > --- a/dlls/ole32/storage32.c > +++ b/dlls/ole32/storage32.c > @@ -2874,16 +2874,16 @@ static HRESULT StorageImpl_LockRegionSync(StorageImpl *This, ULARGE_INTEGER offs > ULARGE_INTEGER cb, DWORD dwLockType) > { > HRESULT hr; > + int delay; > > /* if it's a FileLockBytesImpl use LockFileEx in blocking mode */ > if (SUCCEEDED(FileLockBytesImpl_LockRegionSync(This->lockBytes, offset, cb))) > return S_OK; > > /* otherwise we have to fake it based on an async lock */ > + delay = 0; > do > { > - int delay=0; > - > hr = ILockBytes_LockRegion(This->lockBytes, offset, cb, dwLockType); > > if (hr == STG_E_ACCESSDENIED) > -- > 2.0.0 > > >

1 0

Re: [PATCH 5/5] ddraw/tests: Properly declare matrices.
by Marvin June 16, 2014

June 16, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7524 Your paranoid android. === w8 (32 bit visual) === visual.c:2619: Test failed: unexpected colortable on offscreen surface === w2000pro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvistau64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7u (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w8 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

2 1

Re: kernel32: Raise DBG_PRINTEXCEPTION_C exception in OutputDebugStringA.
by Marvin June 15, 2014

June 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7510 Your paranoid android. === w2000pro (32 bit exception) === exception.c:406: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:406: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:406: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:406: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:406: Test failed: 42: Wrong exception address 00340000/00340001 exception: unhandled exception 80000004 at 00340000 exception.c:406: Test failed: 42: Wrong exception address 7751ED97/00340001 === w2008s64 (32 bit exception) === exception.c:406: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:406: Test failed: 42: Wrong exception address 77E5ED97/003C0001 === w7u (32 bit exception) === exception.c:406: Test failed: 42: Wrong exception address 003F0000/003F0001 exception: unhandled exception 80000004 at 003F0000 exception.c:406: Test failed: 42: Wrong exception address 77CDE34F/003F0001 === w8 (32 bit exception) === exception.c:406: Test failed: 42: Wrong exception address 004F0000/004F0001 exception: unhandled exception 80000004 at 004F0000 exception.c:406: Test failed: 42: Wrong exception address 77174D17/004F0001

1 0

Re: windowscodecs/tests: Fixed some leaks on error path (Valgrind)
by Vincent Povirk June 15, 2014

June 15, 2014

+ if (FAILED(hr)) + { + IStream_Release(stream); + IWICComponentFactory_Release(factory); + return; + } The rest of the function is already has code to handle failure, so returning early is unnecessary.

1 0

Re: shell32: Fix SHFileOperation when deleting a nonexistent directory. (try 2)
by Zhenbo Li June 14, 2014

June 14, 2014

2014-05-21 9:23 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > Thanks Alexandre > > try 2: > 1. Let SHELL_DeleteDirectoryW return DWORD > 2. Get the right return value by > ret = SHNotifyRemoveDirectoryW(pszDir) > origin: > Thanks Bruno Jesus > This patch would fix bug 34324, by returning correct > error value of SHFileOperation. > > --- > dlls/shell32/shlfileop.c | 55 > +++++++++++++++++++++--------------------- > dlls/shell32/tests/shlfileop.c | 4 --- > 2 files changed, 27 insertions(+), 32 deletions(-) Hi, Could someone have a look with my patch after three weeks :-) Thank you very much -- Have a nice day! Zhenbo Li

1 0

Re: ws2_32/socket.c: Fix compile for linux systems without net/ipx.h
by Bruno Jesus June 13, 2014

June 13, 2014

On Mon, Jun 2, 2014 at 3:01 PM, Felix Janda <felix.janda(a)posteo.de> wrote: > --- > dlls/ws2_32/socket.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index e31f396..cf5473d 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -109,6 +109,8 @@ > # include <linux/types.h> > # endif > # include <linux/ipx.h> > +# define SOL_IPX 256 > +# define IPX_TYPE 1 > # define HAS_IPX > #endif Hi, can you share the details about how you are compiling this? There may be a better solution like not defining HAS_IPX if SOL_IPX is not present. If you help me reproduce the issue I can help to fix it. Best regards, Bruno

2 3

Re: [1/4] msvcrt/tests: Add a test for fwrite flushing behavior. (try 2)
by Piotr Caban June 13, 2014

June 13, 2014

Hi, On 06/13/14 01:27, Grazvydas Ignotas wrote: > +static void test_write_flush(void) > +{ > + char iobuf[1024]; > + char *tempf; > + FILE *file; > + > + tempf = _tempnam(".","wne"); > + file = fopen(tempf, "wb+"); > + ok(file != NULL, "unable to create test file\n"); > + /* the default should be 4K */ > + test_write_flush_size(file, 4096); It would be nice to read the size from the file->_bufsiz instead of hard-coding 4096. This value is not initialized while the file is opened so you will need to call something before reading it's value. > + setvbuf(file, iobuf, _IOFBF, sizeof(iobuf)); > + test_write_flush_size(file, sizeof(iobuf)); > + fclose(file); Current implemententation of setvbuf is broken in wine. This code will cause free(iobuf) to be called. I think that setvbuf needs to be fixed before this test can be added. > + unlink(tempf); > + free(tempf); _tempnam returns internal buffer, free should not be called on it. Thanks, Piotr

2 2

Re: vbscript: Reset error number on error mode change.
by Marvin June 13, 2014

June 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7476 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.
by Jactry Zeng June 13, 2014

June 13, 2014

Hello, Could someone take a look at this patch? Any comment will be appreciate! Thanks. 2014-05-28 15:17 GMT+08:00 Jactry Zeng <wine(a)jactry.com>: > ChangeLog: > - skip a test in native 64bit riched20 > - implementing without helper function > > --- > dlls/riched20/richole.c | 28 +++++++++++++- > dlls/riched20/tests/richole.c | 88 ++++++++++++++++++++++++++++++ > ++++++++++++- > 2 files changed, 113 insertions(+), 3 deletions(-) > > > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 2/2] vbscript: Fixed CStr
by Jacek Caban June 13, 2014

June 13, 2014

Hi Shuai, On 06/13/14 06:26, Shuai Meng wrote: > - hres = to_string(arg, &str); > + assert(args_cnt == 1); > + > + V_VT(&v) = VT_EMPTY; > + hres = VariantChangeType(&v, arg, VARIANT_LOCALBOOL, VT_BSTR); Why do you change it? to_string() already does the same call. Jacek

2 1

Re: [3/4] msvcrt: change default buffer size to 4k.
by Piotr Caban June 13, 2014

June 13, 2014

On 06/13/14 01:27, Grazvydas Ignotas wrote: > -#define MSVCRT_BUFSIZ 512 > +#define MSVCRT_BUFSIZ 4096 You can't change BUFSIZ value.

2 2

Re: [PATCH 2/2] vbscript: Fixed CStr
by Piotr Caban June 13, 2014

June 13, 2014

On 06/13/14 06:26, Shuai Meng wrote: > --- > dlls/vbscript/global.c | 16 +++++++++++++--- > dlls/vbscript/tests/api.vbs | 21 +++++++++++++++++++++ > 2 files changed, 34 insertions(+), 3 deletions(-) > You have probably sent wrong patch, one that you've sent me earlier is better (https://github.com/Shuai-Meng/wine/commit/54bb6a783a623a3bf30c8fe33187c8a35…) Taking in account you'll need to resend it, could you please also change: + if(!res) + return DISP_E_BADVARTYPE; + else { + *res = v; + return S_OK; + } to if(!res) return DISP_E_BADVARTYPE; *res = v; return S_OK; It's a style change that makes your code similar to other code in global.c Thanks, Piotr

1 0

Re: [PATCH 2/2] vbscript: Fixed CStr
by Marvin June 13, 2014

June 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7468 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] msvcrt: Add _strxfrm_l implementation
by Marvin June 12, 2014

June 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7457 Your paranoid android. === w2000pro (32 bit string) === string: unhandled exception c0000005 at 78010362 === wxppro (32 bit string) === string: unhandled exception c0000005 at 77C47AD8

1 0

Re: services: Defer service delete until all handles are closed
by Marvin June 12, 2014

June 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7438 Your paranoid android. === w7u (32 bit service) === service.c:1381: Test failed: Something wrong in the calculation service.c:1417: Test failed: Active services mismatch 1 The test timed out

2 1

Re: [PATCH 07/10] dmloader: Use the generic DirectMusicObject implementation for DMContainer.
by Marvin June 12, 2014

June 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7450 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [PATCH 09/10] dmloader: Add and use a generic IPersistStream_GetClassID.
by Marvin June 12, 2014

June 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7452 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 08/10] dmloader/tests: Add more DirectMusicCollection tests.
by Marvin June 12, 2014

June 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7451 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wined3d: Recognize cards that expose GLSL 1.30 as DX10 capable even if they don't support EXT_GPU_SHADER4 (try 4)
by Stefan Dösinger June 11, 2014

June 11, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-30 00:45, schrieb Andrei Slăvoiu: > Add back glsl check to make sure the card is capable of DX10. > > --- dlls/wined3d/directx.c | 4 +++- 1 file changed, 3 > insertions(+), 1 deletion(-) Looks good to me. Note that Alexandre and Henri are on holidays right now, so it might take a while before it is committed or you receive further comments. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTiD0QAAoJEN0/YqbEcdMwcjcP/jAOsNo8MoM8sSlc2RVtU7Y5 tHVmUyMZ0xPSa7DaA13GFT7/hPnRXimRY39epjJ3subulmprkXV+HNtaHWBVkEvR lB+YSJJDFGJ9V81o7aVSUfXydeY81C3TB6TbztO9WtVPSVaE9/ZXJ1ZO3edufoXT XhXMJwce9HmL8nU+SRFo+mAc/FLimCuTwMMf6OF61KlAMTkzGSQoh8sUSwO0hndL /+yARXxgYhBAtepVb2vuL7411/VWlbzrD8S8h4sZhEnCgLNuyGjXFyggjTZn+MWd zYf5MgBWmY/YJu1VES3lkM8VM5FpgJgEcM3DG8BEQ3yI5eyBLReMiKQe3uuyhlnJ KdE9tSPP3Ts2gHYeZ90kGImebtjy5sxA0gsekY5J4oNsbDUfO01OoHde+54GG6WD 25aogs1+edJNZMGI6pxScDl6EoPgbTlBjL5dJ2xDYc1P/ACezNqPBe+tCDoqoVon WBlqNSNntcfCUBEoiXpOcRFK0PeJDIMHRKpZEBM63V3gFW6w0KuI+Sj0JcwFxy+u saLOwXDpaGerhar2njWiCEKwM1NfW2Wj7wcY0/eiy56bi9UvhDCAUqqZ98xlFZuP m8Js4Bwzlp7NHQjaqXo/h3uK36B0OngHZkjRm/hXMEFuQHfCSbKtUMZLn27JI+3a chXJiqk95eUes6GLKzGo =tusS -----END PGP SIGNATURE-----

3 2

Re: [PATCH 4/5] ddraw: Properly support creating compressed user memory surfaces.
by Marvin June 11, 2014

June 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7433 Your paranoid android. === wvistau64 (64 bit ddraw7) === ddraw7.c:6467: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw7) === ddraw7.c:6467: Test failed: Test 7: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6644: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw4) === ddraw4.c:6644: Test failed: Test 7: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 1/5] ddraw: Clear DDSD_LINEARSIZE on uncompressed surfaces.
by Marvin June 11, 2014

June 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7432 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5647: Test failed: Test 3: Got unexpected pitch 252, expected 256. ddraw2.c:5647: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw2) === ddraw2.c:5647: Test failed: Test 3: Got unexpected pitch 252, expected 256. ddraw2.c:5647: Test failed: Test 7: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4571: Test failed: Test 3: Got unexpected pitch 252, expected 256. ddraw1.c:4571: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw1) === ddraw1.c:4571: Test failed: Test 3: Got unexpected pitch 252, expected 256. ddraw1.c:4571: Test failed: Test 7: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6377: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw7) === ddraw7.c:6377: Test failed: Test 7: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6554: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw4) === ddraw4.c:6554: Test failed: Test 7: Got unexpected pitch 252, expected 256.

1 0

Undocumented Function in WINE-API
by Pit Demmer June 11, 2014

June 11, 2014

Hi! I´m a 47 year old German - programming BASIC, Assembler and sometime pure C since 1981. Please! NO discussion´s about my love - the VB and Power BASIC's... ;-) My newest project (It´s called LetsLOCO), is a "MultiIO-LongDistance-BusSystem for Logging and Controlling" over an electrical- and protocol-extended I2C-Bus which can adress standard I2C compatible IC´s, too. The fully Project is not only Software! I´ve made many HardWare, too. I want to make this Project free. Hardware fully free under a license similar to a GPL. The Software should be at first Freeware, but only for running under WINE! If somebody plan to use the Software outside WINE... I want some little money for it. And here is the problem... I need a function, which exist in the WINE-API but not in the Original Win-API´s. Can anyone from the WINE-Developers help me? Exist a little 'dummy'-function in user32.dll, kernel32.dll, shell32.dll,... which have no similar function in the original Win-DLL´s? Any other 'safe' way to verify that my EXEs and DLLs running through WINE is welcome, too. Thanks! And sorry for my English! Pit

2 1

Re: gdi32: CLIP_DFA_DISABLE should disable the font association mechanism.
by Marvin June 10, 2014

June 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7430 Your paranoid android. === wvistau64 (32 bit font) === The test timed out === wvistau64 (64 bit font) === The test timed out

1 0