June 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] vbscript: Implemented Sgn(try 2)
by Jacek Caban June 25, 2014

June 25, 2014

On 06/17/14 07:59, Shuai Meng wrote: > diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c > index c2b2edd..d21784d 100644 > --- a/dlls/vbscript/global.c > +++ b/dlls/vbscript/global.c > @@ -1320,8 +1320,24 @@ static HRESULT Global_Int(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIA > > static HRESULT Global_Sgn(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + VARIANT v; > + HRESULT hres; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + V_VT(&v) = VT_EMPTY; > + hres = VariantChangeType(&v, arg, VARIANT_LOCALBOOL, VT_R8); > + if (FAILED(hres)) > + return S_OK; Please use to_double() instead. to_double may need some fixes (it may require similar changes as you did for to_string first). Jacek

2 4

Re: [5/5] user32: Skip menu loop for empty popup menus.
by Marvin June 24, 2014

June 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7669 Your paranoid android. === w7u (32 bit msg) === msg.c:12099: Test failed: unexpected hwnd 003D013E msg.c:12121: Test failed: bad time 30e71/30e80

1 0

Re: [3/5] user32: Set capture on the owner of popup menus.
by Marvin June 24, 2014

June 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7664 Your paranoid android. === w7u (32 bit msg) === msg.c:12098: Test failed: unexpected hwnd 0007013A

1 0

Re: [4/5] user32: Set capture earlier on popup menus.
by Marvin June 24, 2014

June 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7665 Your paranoid android. === build (build) === Failure running the build script in the VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: ntdll/nt: Improve NtQuerySystemInformation, cpu_user/cpu_nice already include cpu_guest/cpu_guest_nice
by André Hentschel June 24, 2014

June 24, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 24.06.2014 01:57, schrieb Bernard Ladenthin: Somehow too many comments... Also you just number your patches like e.g. [1/2] in the subject, see other patches -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQGcBAEBAgAGBQJTqdl5AAoJEGm5GZTakYssInAL/j59ymw++Chfn8hfF9TYsGU7 Gg8w1k451vXrezpRHsLrYB72UrLbnlD35TJx3FBV3nCEhuX/LVGj7EyTh6gA+aki p1RmHmqZSvxzuI7RF6a9LbfwjwwSQ392huraBUzmNFOMKMwQ1cZfCfFxA+Xvr/kL bwKcN/+EeSBYDUHIp3ug9ib0SL+d1IMeqQDSstviEKEHfAjbUsAICWBKMU5jmrDt ZEHLrugbfQ15qRITbBbqKvPTSrR1VRglOYwT44kwB4w+xZCJ8u+zgEQhMpg6dN6H JkgG4VjH7ObksiASY0wUAmL+c9KwNcmwyJ7SwG5o+nmgF/kNjzOZhgw80wtrXNCi 659GCVBLFENKSOPWh84nxhRFXKlH6uubqxcRI4WtTNQGfdsI7MqB1qGf9Y45TvyP aHfEd/hBVvNaNRj9Vzax3z3ze2nshEczhpuv8PkTcyLUr/zA+ju+w+FkwUJesjY9 zbGao2AjHszVl9LDvJoKXV6cc+lCTqlIe3BTYa79qw== =8YJ/ -----END PGP SIGNATURE-----

1 0

Re: fix stack corruption and LastError results in shlwapi PathCombine
by Vincent Povirk June 24, 2014

June 24, 2014

The length of the ANSI string doesn't necessarily match the length of the Unicode string after conversion. We should be checking the return value of MultiByteToWideChar to find out whether the converted string fit. Why aren't the 'strlenW(szTemp) + strlenW(lpszFile)' test and uses of lstrcpynW in PathCombineW sufficient to avoid stack corruption?

1 0

Re: wininet/tests: Add more HTTP_QUERY_RAW_HEADERS tests
by Alexandre Julliard June 24, 2014

June 24, 2014

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Related to http://bugs.winehq.org/show_bug.cgi?id=36641 It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M wininet.dll -p wininet_test.exe.so http && touch http.ok http.c:647: Test succeeded inside todo block: HttpQueryInfoA(HTTP_QUERY_RAW_HEADERS) failed with error 122 http.c:649: Test succeeded inside todo block: Expected 0x00, got 00 http.c:652: Test succeeded inside todo block: Value should not have changed: 465 != 465 http.c:647: Test succeeded inside todo block: HttpQueryInfoA(HTTP_QUERY_RAW_HEADERS) failed with error 122 http.c:649: Test succeeded inside todo block: Expected 0x00, got 00 http.c:652: Test succeeded inside todo block: Value should not have changed: 403 != 403 wine: Unhandled page fault on write access to 0x00630065 at address 0x7bc4ef6f (thread 0088), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: glGetString() requires an active GL context (try 2)
by Alexandre Julliard June 24, 2014

June 24, 2014

Bruno Jesus <00cpxxx(a)gmail.com> writes: > try2: > > Add tests. That test will work fine on Wine without code changes, so it's not very convincing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Avoid compiler warnings in freetype_SelectFont. Simplify logic a bit.
by Alexandre Julliard June 24, 2014

June 24, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This is similar to the warning removal patch I submitted yesterday. > > On top of that it replaces > ! something == ! a_0_1_boolean > by > !! something == a_0_1_boolean > since !! reflects the intention (to convert whatever value to one of > 0 or 1) better than the former and may be more efficient, too. That's not an improvement. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: glBindTexture() and glDeleteTextures() require an active GL context
by Roderick Colenbrander June 24, 2014

June 24, 2014

Hi Bruno, My initial feeling is that the app is just buggy, since calling functions without a context is very questionable. Assuming we want to any checking on NULL-contexts, please edit the make_opengl script since opengl_norm.c is all auto-generated. Since this code is tricky, I would recommend writing a test case for our test suite. Years ago (pre-wine 1.0) we had code to keep some implicit GL context around, because allegedly some game required it (I think it was Homeland). Though when I tried to reproduce that behavior I didn't see it in the game. I think I wrote some tests for Windows, but don't remember the results. Thanks, Roderick On Sat, Jun 21, 2014 at 11:36 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Very similar to bug 36506 but for other functions. > > Fixes bug http://bugs.winehq.org/show_bug.cgi?id=34847 > > > >

2 3