July 2014 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Wine 64 bit
by Kevin Davies June 5, 2015

June 5, 2015

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

13 31

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard April 23, 2015

April 23, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

[RFC 0/11] Linux FF: Intro
by Elias Vanderstuyft Sept. 7, 2014

Sept. 7, 2014

Hi, This is the sequel of the mail with title: "Discussion and Improvement of Wine's Linux Force Feedback implementation". This mail is meant to give an introduction to the next 11 mails: All tests were performed using wine-1.7.11-206-g82b3813 (but none of the files of which I propose changes to be made in, are affected in the current (2014-03-04) wine-version 1.7.13) Because I haven't created any (formal) patch yet (and instead first request for comments), I tried to keep the line numbers to reference the affected files more or less based to the version I started from, where I could. However, the orig code of a (informal) patch that has to be applied after (and thus is dependent of) a previous patch, may be different from the initial code of the wine-version I started from. After having discussed everything, I will send a proper patchset. In these mails, sometimes 'FEdit' is mentioned: it's a MS application that allows to create all FF effect types (except CustomForce and rumble/vibration effects), and therefore the ideal test application. Physical behavior is compared between Windows7 (using Logitech MOMO wheel with latest drivers installed) running in Virtualbox, and my patched Wine-version. In the end, (using a dummy FF driver on the Linux side, thanks to Michal Malý), the behavior of Wine is almost (limitations caused by the dummy ff driver, such as updating an effect while playing is not implemented) identical, if not better (in some aspects) then the Windows equivalent. Sometimes I refer to linux-input mailing lists to prove a statement, because the links may vanish (unlikely though), I provide the titles corresponding with the links: (http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08513.html) "ff-core effect id handling in case of a failed effect upload" (http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08459.html) "Questions about the documentation/specification of Linux ForceFeedback input.h" Subjects [11] ------------- - Joystick control panel program [2] - Linux effect status management [3] - Linux effect parameter: start delay [1] - Linux effect parameter: periodic effect's phase [1] - Linux effect parameters: time parameters [3] - Linux effect: conditional effect's parameters [2] - Linux effect: axes [1] - Linux effect direction [7] - Linux effect parameters (global) [6] - Linux joystick initialization [1] - Debug message fixes/additions [6] Elias

2 3

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/2] imagehlp/tests: Add test for BindImageEx (try 12)
by Alexandre Julliard Aug. 4, 2014

Aug. 4, 2014

Bernhard Reiter <ockham(a)raz.or.at> writes: > @@ -31,6 +31,8 @@ > static HMODULE hImageHlp; > > static BOOL (WINAPI *pImageGetDigestStream)(HANDLE, DWORD, DIGEST_FUNCTION, DIGEST_HANDLE); > +static BOOL (WINAPI *pBindImageEx)(DWORD Flags, const char *ImageName, const char *DllPath, > + const char *SymbolPath, void *StatusRoutine); That's not the correct prototype. > +static BOOL WINAPI testing_status_routine(IMAGEHLP_STATUS_REASON reason, char *ImageName, > + char *DllName, ULONG_PTR Va, ULONG_PTR Parameter) > +{ > + char kernel32_path[MAX_PATH]; > + > + status_routine_called[reason]++; This will have nasty results if you get an unexpected code. > + default: > + ok(0, "expected reason to be one of BindImportModule, BindImportProcedure, or " > + "BindForwarderNOT, got %d\n", reason); Please simplify your error messages. In particular, this one would need to be changed every time the test is expanded, that's not a good idea. > +static void test_bind_image_ex(void) > +{ > + BOOL ret; > + HANDLE file; > + char temp_file[MAX_PATH] = "nonexistant.dll"; There's no reason to use a variable for this. > + /* Under 64 bit images of Vista Ultimate, 2008 Server, and 7 Pro, StatusRoutine is called with > + * reason BindForwarderNOT instead of BindImportProcedure. */ > + todo_wine ok((status_routine_called[BindImportProcedure] == 1) || > + (status_routine_called[BindForwarderNOT] == 1), > + "Expected StatusRoutine to be called once with reason BindImportProcedure or " > + "BindForwarderNOT, but it was called %d and %d times, respectively\n", > + status_routine_called[BindImportProcedure], status_routine_called[BindForwarderNOT]); You'd most likely want the test to depend on 32/64-bit instead of always accepting both. -- Alexandre Julliard julliard(a)winehq.org

2 2

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: [3/3] dwrite/tests: Some tests for drawing sequence for a layout
by Marvin July 31, 2014

July 31, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8225 Your paranoid android. === w8 (32 bit layout) === layout.c:191: Test failed: unexpected QI {d3e0e934-22a0-427e-aae4-7d9574b59db1}

2 1

Re: [PATCH 5/6] quartz: Fix race condition on EndFlush between csRenderLock and filter.csFilter.
by Michael Stefaniuc July 31, 2014

July 31, 2014

On 07/31/2014 03:48 AM, Erich E. Hoover wrote: > From b67543fba9b2af87654533831aee2c4dae43571a Mon Sep 17 00:00:00 2001 > From: "Erich E. Hoover" <erich.e.hoover(a)gmail.com> > Date: Thu, 17 Jul 2014 10:31:17 -0600 > Subject: quartz: Fix race condition on EndFlush between csRenderLock and > filter.csFilter. > > --- > dlls/quartz/videorenderer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c > index 4e8f359..5fe0aea 100644 > --- a/dlls/quartz/videorenderer.c > +++ b/dlls/quartz/videorenderer.c > @@ -377,8 +377,8 @@ static HRESULT WINAPI VideoRenderer_EndFlush(BaseRenderer* iface) > LeaveCriticalSection(&iface->csRenderLock); > LeaveCriticalSection(&iface->filter.csFilter); Eric, shouldn't you release the inner lock first? > WaitForSingleObject(This->hEvent, INFINITE); > - EnterCriticalSection(&iface->filter.csFilter); > EnterCriticalSection(&iface->csRenderLock); > + EnterCriticalSection(&iface->filter.csFilter); > EnterCriticalSection(iface->pInputPin->pin.pCritSec); > } > if (This->renderer.filter.state == State_Paused) { bye michael

2 1

mshtml: Added IHTMLImgElement::isMap property implementation.
by Zhenbo Li July 31, 2014

July 31, 2014

--- dlls/mshtml/htmlimg.c | 27 +++++++++++++++++++++++---- dlls/mshtml/tests/dom.c | 18 ++++++++++++++++++ 2 files changed, 41 insertions(+), 4 deletions(-)

1 0

XInput over SDL
by akjsdfk sdkfnskd July 31, 2014

July 31, 2014

Long story short, while I helped my friend with his "up to the neck in MS API" game, I wrote him complete drop in solution library for XInput over SDL. And since making patch for wine was easier than testing his half done game... well, it came to full featured XInput handling It supports: - hotplugging/unplugging (well, only if game didn't use DInput to scan new devices. if it is pure XInput, then it just works) - all controllers supported by SDL are XInput capable - haptic works And before cleaning it, I just wanted to ask if XInput over SDL is wanted or not. There is no point in working on regular patch if that is out of question. Just short points why SDL and not native (which I'm not interested in even remotely): - far better API than XInput - controller database is updated - completely cross platform - same source can be reused to port game ... but, don't treat this as I would try starting some holy war. If it doesn't fit in wine plans, no problem. I can still provide it as standalone patch for those that want it with regards wh1sper_123

5 7

[PATCH 3/3] iphlpapi: Add PfUnBindInterface function stub (try 2)
by Hao Peng July 31, 2014

July 31, 2014

fix bug 36833 sorry for that I didn't follow the rules to send patches to wine dev channel. Hope I corrected everything this time.--- dlls/iphlpapi/iphlpapi.spec | 2 +- dlls/iphlpapi/iphlpapi_main.c | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[PATCH 2/3] iphlpapi: Add PfDeleteInterface function stub (try 2)
by Hao Peng July 31, 2014

July 31, 2014

fix bug 36833 sorry for that I didn't follow the rules to send patches to wine dev channel. Hope I corrected everything this time.--- dlls/iphlpapi/iphlpapi.spec | 2 +- dlls/iphlpapi/iphlpapi_main.c | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[PATCH 1/3] iphlpapi: Add PfBindInterfaceToIPAddress function stub (try 2)
by Hao Peng July 31, 2014

July 31, 2014

fix bug 36833 sorry for that I didn't follow the rules to send patches to wine dev channel. Hope I corrected everything this time. --- dlls/iphlpapi/iphlpapi.spec | 2 +- dlls/iphlpapi/iphlpapi_main.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-)

1 0

Re: [PATCH] riched20: Stub for ITextRange interface and implement ITextDocument::Range.
by Marvin July 31, 2014

July 31, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8174 Your paranoid android. === w2000pro (32 bit richole) === The test timed out

2 1

Re: shell32: Implement IEnumShellItems for IShellItemArray.
by Marvin July 30, 2014

July 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8193 Your paranoid android. === w7u (32 bit shlfolder) === shlfolder.c:3688: Test failed: Got 00000000 === w8 (32 bit shlfolder) === shlfolder.c:3688: Test failed: Got 00000000

1 0

Re: (Retry)[4/5] imm32: Restrict crossthread Association and destruction
by Marvin July 30, 2014

July 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8186 Your paranoid android. === wvistau64 (32 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed === w2008s64 (32 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed === wvistau64 (64 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed === w2008s64 (64 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed

1 0

Re: (Retry)[6/6]imm32: limit cross thread access to ImmSet* functions
by Aric Stewart July 30, 2014

July 30, 2014

Sorry this patch is mislabeled as [6/6] it should be [5/5] -aric On 7/30/14, 3:32 PM, Aric Stewart wrote: > Resolves bug 35361 > --- > dlls/imm32/imm.c | 21 +++++++++++++++++++++ > dlls/imm32/tests/imm32.c | 28 ++++++++++++++-------------- > 2 files changed, 35 insertions(+), 14 deletions(-) > > > > >

1 0

Re: shell32: Create profile directories available in Vista and above
by Alexandre Julliard July 30, 2014

July 30, 2014

Michael Müller <michael(a)fds-team.de> writes: > diff --git a/include/shlobj.h b/include/shlobj.h > index 9025a73..dcea14e 100644 > --- a/include/shlobj.h > +++ b/include/shlobj.h > @@ -1529,6 +1529,15 @@ HRESULT WINAPI SHGetFolderPathW(HWND hwnd, int nFolder, HANDLE hToken, DWORD dwF > #define CSIDL_CDBURN_AREA 0x003b > #define CSIDL_COMPUTERSNEARME 0x003d > #define CSIDL_PROFILES 0x003e > + > +/* Wine internal CSIDLs */ > +#define CSIDL_WINE_CONTACTS 0x0043 > +#define CSIDL_WINE_DOWNLOADS 0x0047 > +#define CSIDL_WINE_LINKS 0x004d > +#define CSIDL_WINE_APPDATA_LOCALLOW 0x004e > +#define CSIDL_WINE_SAVED_GAMES 0x0062 > +#define CSIDL_WINE_SEARCHES 0x0063 This should be private to shell32. Also please avoid the WINE_ prefix, that makes it sound like they are Wine extensions (the defines may not exist on Windows, but the folders do). -- Alexandre Julliard julliard(a)winehq.org

1 0

Confusion with submitting changes
by Kyle Marek July 30, 2014

July 30, 2014

I am looking at the pages on winehq for development for wine. I am noticing that everything is talking about guidelines for making patches and submitting patches. Can I not make a pull request on my changes? I also noticed that it said that not everyone can submit patches and i inferred by the linked pages that it's to prevent legal trouble. How can I become eligible to submit changes?

3 3

Re: Regarding DXVA support in Wine (DXVA2 -> VA_API)
by Jaeyong Yoo July 30, 2014

July 30, 2014

Oops sorry, the mail sent while I'm writing... Here goes again: Hello Wine I’ve seen Michael Muller is writing DXVA2 -> VA_API conversion in the following link: http://www.winehq.org/pipermail/wine-devel/2014-March/103687.html I'm wondering the current status of Michael's work. Is there more progress, such as supporting MPEG4 APIs? Best regards, Jaeyong

1 0

Regarding DXVA support in Wine (DXVA2 -> VA_API)
by Jaeyong Yoo July 30, 2014

July 30, 2014

Hello Wine, I've seen Michael Muller is writing DXVA2 -> VA_API conversion in the following link:

1 0

Re: mshtml: Added IHTMLInputElement_get_form method implementation. (try 2)
by Jacek Caban July 29, 2014

July 29, 2014

Hi Zhenbo, On 07/29/14 05:24, Zhenbo Li wrote: > + nsres = nsIDOMHTMLInputElement_GetForm(This->nsinput, &nsform); > + if (NS_FAILED(nsres) || nsform == NULL) { > + ERR("GetForm failed: %08x, nsform: %p\n", nsres, nsform); > + p = NULL; Not setting output value would be probably fine in this case, but if you do, please do it right (*p = NULL;). Jacek

1 0

Re: mshtml: Added IHTMLWindow2::navigate implementation.
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8129 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [3/3] wined3d: replace vendor specific callbacks with generic code that uses vendor specific renderer string tables
by Henri Verbeet July 28, 2014

July 28, 2014

On 26 July 2014 20:24, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > + /*Direct 3D 11*/ I guess this happened while rebasing.

2 1

Re: XInput over SDL
by akjsdfk sdkfnskd July 28, 2014

July 28, 2014

> My 2c is that this is more of an issue than SDL. Using SDL is probably > fine if there are good arguments that support its use and the > Wine-internal layering makes sure that xinput_*.dll, dinput > and winmm see the same joystick configuration. You could think about > calling SDL from winex11.drv or dinput. I think you missed the point completely here. Example I posted link for is not if you see/can use device or you don't as device is visible full time. Games use this code to decide which interface they use that way to run, DInput or XInput. And since that code does following - enumerate all DInput visible devices (XInput are exposed there too) ---- for each DInput device check if it is XInput ------ for each passed DInput device parse trough all system devices and when you find it (!!!!!) -------- check if device ID contains "IG_", if it does lets proclaim this XInput compatible now if any of devices was XInput compatible LoadLibrary ("XInput1_3.dll") and use XInput API, if there was no compatible device then LoadLibrary ("DInput.dll") and use DInput API. This all happens in game, not in Windows or Wine. In wine case, NO compatible device is reported (!!!!!) - This part is where my question was aiming for, which part of wine creates devices here, so I wouldn't need to hack CoSetProxyBlanket This part has nothing to do with DInput or XInput. Wine simply doesn't provide XInput compatible device when game parses them with CoSetProxyBlanket setup enumeration Maybe you missed it before "*If you want your game to support legacy DirectInput <http://msdn.microsoft.com/en-us/library/windows/desktop/ee416842(v=vs.85).a…>** devices, you may use DirectInput and XInput side by side. When enumerating your DirectInput devices, all DirectInput devices will enumerate correctly. All XInput devices will show up as both XInput and DirectInput devices, but they should not be handled through DirectInput. You will need to determine which of your DirectInput devices are legacy devices, and which are XInput devices, and remove them from the enumeration of DirectInput devices.*" >From same page > I guess here you mean the X input extension rather than Microsoft's > xinput_*.dll, right? I guess XInput works better in remote X11 > situations than anything SDL, /dev/js* or /dev/event/* based. (But tbh I > don't really know how SDL talks to the joystick.) No, I meant exactly what I said. XInput is terribly deficient API. And as far as remote situations, X11 has way too terrible remote display to be usable for game in 50x50 resolution, way off some normal @Vincent Povirk > From what I could tell, SDL has a game controller api that's very > similar to xinput, which is pretty nice, and it can be configured to > map to any controller. It goes further, you can access same device as Joystick and handle axis and buttons manually or you can access it as Gamepad and have instant correct axis/button mapping. Not to mention haptic in XInput is downright terribly deficient (set left/right, ok it works), SDL is downright brilliant on haptic handling Since I'm not native english speaker, some parts might sound like I would try to persuade in use of SDL. If it does, I sincerely apologize and believe me... I don't, I'm honestly only interested in my question regarding who/where creates devices in CoSetProxyBlanket part p.s. sorry for double message Stefan, accidentally only sent response to you and not to list with regards wh1sper_123 On 28 July 2014 20:43, akjsdfk sdkfnskd <wh1sper.123.wtfit(a)gmail.com> wrote: > > My 2c is that this is more of an issue than SDL. Using SDL is probably > > fine if there are good arguments that support its use and the > > Wine-internal layering makes sure that xinput_*.dll, dinput > > and winmm see the same joystick configuration. You could think about > > calling SDL from winex11.drv or dinput. > > I think you missed the point completely here. > > Example I posted link for is not if you see/can use device or you don't as > device is visible full time. Games use this code to decide which interface > they use that way to run, DInput or XInput. And since that code does > following > - enumerate all DInput visible devices (XInput are exposed there too) > ---- for each DInput device check if it is XInput > ------ for each passed DInput device parse trough all system devices and > when you find it (!!!!!) > -------- check if device ID contains "IG_", if it does lets proclaim this > XInput compatible > > now if any of devices was XInput compatible LoadLibrary ("XInput1_3.dll") > and use XInput API, if there was no compatible device then LoadLibrary > ("DInput.dll") and use DInput API. This all happens in game, not in Windows > or Wine. In wine case, NO compatible device is reported > > (!!!!!) - This part is where my question was aiming for, which part of > wine creates devices here, so I wouldn't need to hack CoSetProxyBlanket > > This part has nothing to do with DInput or XInput. Wine simply doesn't > provide XInput compatible device when game parses them with CoSetProxyBlanket > setup enumeration > > Maybe you missed it before "*If you want your game to support > legacy DirectInput > <http://msdn.microsoft.com/en-us/library/windows/desktop/ee416842(v=vs.85).a…>** devices, > you may use DirectInput and XInput side by side. When enumerating your > DirectInput devices, all DirectInput devices will enumerate correctly. All > XInput devices will show up as both XInput and DirectInput devices, but > they should not be handled through DirectInput. You will need to determine > which of your DirectInput devices are legacy devices, and which are XInput > devices, and remove them from the enumeration of DirectInput devices.*" > From same page > > > I guess here you mean the X input extension rather than Microsoft's > > xinput_*.dll, right? I guess XInput works better in remote X11 > > situations than anything SDL, /dev/js* or /dev/event/* based. (But tbh I > > don't really know how SDL talks to the joystick.) > > No, I meant exactly what I said. XInput is terribly deficient API. And as > far as remote situations, X11 has way too terrible remote display to be > usable for game in 50x50 resolution, way off some normal > @Vincent Povirk > > From what I could tell, SDL has a game controller api that's very > > similar to xinput, which is pretty nice, and it can be configured to > > map to any controller. > > It goes further, you can access same device as Joystick and handle axis > and buttons manually or you can access it as Gamepad and have instant > correct axis/button mapping. Not to mention haptic in XInput is downright > terribly deficient (set left/right, ok it works), SDL is downright > brilliant on haptic handling > > > Since I'm not native english speaker, some parts might sound like I would > try to persuade in use of SDL. If it does, I sincerely apologize and > believe me... I don't, I'm honestly only interested in my question > regarding who/where creates devices in CoSetProxyBlanket part > > with regards > wh1sper_123 > > > On 28 July 2014 19:50, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Am 2014-07-26 22:52, schrieb akjsdfk sdkfnskd: >> > - hotplugging/unplugging (well, only if game didn't use DInput to >> > scan new devices. if it is pure XInput, then it just works) >> My 2c is that this is more of an issue than SDL. Using SDL is probably >> fine if there are good arguments that support its use and the >> Wine-internal layering makes sure that xinput_*.dll, dinput >> and winmm see the same joystick configuration. You could think about >> calling SDL from winex11.drv or dinput. >> >> > - far better API than XInput >> I guess here you mean the X input extension rather than Microsoft's >> xinput_*.dll, right? I guess XInput works better in remote X11 >> situations than anything SDL, /dev/js* or /dev/event/* based. (But tbh I >> don't really know how SDL talks to the joystick.) >> >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2 >> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ >> >> iQIcBAEBAgAGBQJT1o1zAAoJEN0/YqbEcdMwWiYP/1/hOzt/v6VIp+gDS+cYJF5u >> 4fRyjT4zoWoFmOUrtApSj1VaBA2DeIaeeT97D0AAvD+FQ0GLaSYcEbn2EqLTcPJO >> N2IGHeTABdt3IBcD1Ya4AOVAryITaqoR83qmI6KElv/jrdpNDD6BaMemcFDno4Tm >> pqAYdlZBlFUWP5kEcSp7OsztNWCin0gdQ6BRRnU8nhtBtlOC5qV9VQPW5CQ66SDK >> +CM+3YkzARMoqmPk1qNu/OnkrubRRuwpHLsCySkfE9WnIDd29tIEAvMThUeZ8ucN >> OKmdIhs+RSOijrZecj0QDzhNA3fPR+EYx+OFr6h10Y3PxOgdwwAstDoakEhk1x4Y >> /jQu0XKtP6hDqCtSruxE8Ny3Hpb8p/zsdodHIhmp1W99QdHLbnKVdZJiCYBLToFW >> AVJ69NPm4Ae92jerN8pesHEl5B7kIGkQepCCpxWUjwPVWEjbB6fEcegGcGN/ccNn >> EWiBm1+14L5wgPSPCG/DhAfEPtfsig7TLdsL6zIZFLq0/+O6PVmjW9ezjT1PD00U >> NP7VqmYWY5Is7XtWI6NQ1Vqi5En47uKz+ZaQLPB0ExQB57XrubMo6C6aE53Q4HRg >> 5Kmh7vTBZecXPZGToT6Eg3z3y1Bc6B9piipxxfRzuqOU6EUzqHO8RzG/LuMrOLG7 >> kHdS1Q1gRro1FRAFDT3M >> =gcqc >> -----END PGP SIGNATURE----- >> > >

1 0

Re: mshtml: Added IHTMLInputElement_get_form method implementation.
by Jacek Caban July 28, 2014

July 28, 2014

On 07/28/14 16:58, Zhenbo Li wrote: > My code is a little ugly, and I'm wondering if there is a better > solution. Is there any reason why you don't use nsIDOMHTMLInputElement::GetForm? Jacek

1 0

Re: [PATCH 4/4] vbscript: Implemented ScriptEngineMinorVersion(try 2)
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8122 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscript: Implemented ScriptEngineMajorVersion(try 2)
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8121 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] vbscript: Inplemented ScriptEngineBuildVersion(try 2)
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8120 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] vbscript: Implemented ScriptEngine(try 2)
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8119 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/4] vbscript: Implemented ScriptEngineMinorVersion
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8117 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] vbscript: Implemented ScriptEngineMajorVersion
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8116 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] vbscript: Implemented ScriptEngineBuildVersion
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8115 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] vbscript: Implemented ScriptEngine
by Marvin July 28, 2014

July 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8114 Your paranoid android. === build (build) === Patch failed to apply

1 0

Partial fix for issue 17982 (PatBlt cannot draw arbitrary parallelograms based on the world transform)
by Alexander Almaleh July 28, 2014

July 28, 2014

I made a partial fix of this bug - https://bugs.winehq.org/show_bug.cgi?id=17982, only for the PATCOPY rop. It's based on the observation that the Polygon() function does support arbitrary parallelograms, including when defined through the XFORM matrix, so for PATCOPY we can just delegate the implementation to it (with a NULL_PEN because PatBlt doesn't use a pen). Is this patch acceptable? I have no idea if delegating to Polygon() will hurt performance. If that is a concern, I can do it only in case the physical coordinates after the world transform are not rectangular. If it is, I will submit it to wine-patches, then.

1 0

dlls/ntdll/signal_i386.c changes break FreeBSD
by Gerald Pfeifer July 25, 2014

July 25, 2014

Over the last 24 hours, signal_i386.c stopped building on FreeBSD/i386 10.0 as follows: +signal_i386.c:283:40: error: 'ucontext_t' has no member named 'sc_trapno' +signal_i386.c:284:40: error: 'ucontext_t' has no member named 'sc_err' +signal_i386.c:279:40: error: 'ucontext_t' has no member named 'sc_fs' +signal_i386.c:280:40: error: 'ucontext_t' has no member named 'sc_gs' +signal_i386.c:276:40: error: 'ucontext_t' has no member named 'sc_cs' +signal_i386.c:281:40: error: 'ucontext_t' has no member named 'sc_ss' +signal_i386.c:288:40: error: 'ucontext_t' has no member named 'sc_esp' +signal_i386.c:268:40: error: 'ucontext_t' has no member named 'sc_eax' +signal_i386.c:269:40: error: 'ucontext_t' has no member named 'sc_ebx' +signal_i386.c:270:40: error: 'ucontext_t' has no member named 'sc_ecx' +signal_i386.c:271:40: error: 'ucontext_t' has no member named 'sc_edx' +signal_i386.c:272:40: error: 'ucontext_t' has no member named 'sc_esi' +signal_i386.c:273:40: error: 'ucontext_t' has no member named 'sc_edi' : +signal_i386.c:997:1: warning: control reaches end of non-void function [-Wreturn-type] +signal_i386.c:566:1: warning: control reaches end of non-void function [-Wreturn-type] +signal_i386.c:580:1: warning: control reaches end of non-void function [-Wreturn-type] On FreeBSD, /usr/include/sys/ucontext.h has the following: typedef struct __ucontext { /* * Keep the order of the first two fields. Also, * keep them the first two fields in the structure. * This way we can have a union with struct * sigcontext and ucontext_t. This allows us to * support them both at the same time. * note: the union is not defined, though. */ sigset_t uc_sigmask; mcontext_t uc_mcontext; struct __ucontext *uc_link; stack_t uc_stack; int uc_flags; #define UCF_SWAPPED 0x00000001 /* Used by swapcontext(3). */ int __spare__[4]; } ucontext_t; mcontext_t is defined in /usr/include/x86/ucontext as follows: typedef struct __mcontext { /* * The definition of mcontext_t must match the layout of * struct sigcontext after the sc_mask member. This is so * that we can support sigcontext and ucontext_t at the same * time. */ __register_t mc_onstack; /* XXX - sigcontext compat. */ __register_t mc_gs; /* machine state (struct trapframe) */ __register_t mc_fs; __register_t mc_es; __register_t mc_ds; __register_t mc_edi; __register_t mc_esi; __register_t mc_ebp; __register_t mc_isp; __register_t mc_ebx; __register_t mc_edx; __register_t mc_ecx; __register_t mc_eax; __register_t mc_trapno; __register_t mc_err; __register_t mc_eip; __register_t mc_cs; __register_t mc_eflags; __register_t mc_esp; __register_t mc_ss; : Gerald

2 2

Re: [1/3] oleaut32: Add test for TLB dependencies lookup in resources (try 2)
by Guillaume Charifi July 25, 2014

July 25, 2014

Alexandre Julliard wrotes: > Simply create it directly into a temp dir, no moving needed. I am reusing a TLB created by building process, because this test requires two typelibs, to check whether or not, from a TypeInfo requested from one of them, we can get the corresponding RefTypeInfo from the other. The aim is to see if the imlementation can find the TypeLib in which the RefTypeInfo is. So I don't really need to create it at runtime, I just need it to be in the ressource table of the test program, and nowhere else.

1 0

Re: [1/3] oleaut32: Add test for TLB dependencies lookup in resources (try 2)
by Guillaume Charifi July 25, 2014

July 25, 2014

Alexandre Julliard wrotes: > Simply create it directly into a temp dir, no moving needed. I am reusing a TLB created by building process, because this test requires two typelibs, to check whether or not, from a TypeInfo requested from one of them, we can get the corresponding RefTypeInfo from the other. The aim is to see if the imlementation can find the TypeLib in which the RefTypeInfo is. So I don't really need to create it at runtime, I just need it to be in the ressource table of the test program, and nowhere else.

1 0

Re: [1/3] oleaut32: Add test for TLB dependencies lookup in resources (try 2)
by Guillaume Charifi July 25, 2014

July 25, 2014

Alexandre Julliard <julliard at winehq.org> writes: > It doesn't work here: > > ../../../tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so typelib && touch typelib.ok > typelib.c:5528: Test failed: test_tlb.tlb is on the path or registered > typelib.c:5542: Test succeeded inside todo block: got: 0 > make[1]: *** [typelib.ok] Error 2 Yes, in fact the test does not make sense if the test_tlb.tlb is locatable on disk by the program, it must be out of the path. That's why I was initially just skipping the test if test_tlb.tlb could be loaded from disk, but some suggested me to make the test fail in that case. Should I restore the old behaviour ? Or do something else ?

2 2

Re: [1/3] oleaut32: Add test for TLB dependencies lookup in resources (try 2)
by Alexandre Julliard July 24, 2014

July 24, 2014

Guillaume Charifi <guillaume.charifi(a)sfr.fr> writes: > Some file had nothing to be there... > > Supersedes http://source.winehq.org/patches/data/105527 > --- > dlls/oleaut32/tests/Makefile.in 1 + > dlls/oleaut32/tests/test_dep.idl 44 > ++++++++++++++++++++++++++++++++++++++++++++ > dlls/oleaut32/tests/tmarshal.rc 3 +++ > dlls/oleaut32/tests/typelib.c 40 > ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 88 insertions(+) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so typelib && touch typelib.ok typelib.c:5528: Test failed: test_tlb.tlb is on the path or registered typelib.c:5542: Test succeeded inside todo block: got: 0 make[1]: *** [typelib.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: libwine: Added wine_dbgstr_variant and wine_dbgstr_vt implementations.
by Alexandre Julliard July 24, 2014

July 24, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > This is meant to remove all the duplicated debugstr_variant > implementations. While this is ugly, mostly due to duplicated > declarations, this is the most straightforward solution. An alternative > would be to implement this in ntdll (using __wine_debug_functions). This > would avoid headers problem (well, it's still ugly to use oaidl.h in > ntdll, but technically allowed) and allow exception protection, like > string printing functions. I'm not sure if that's better. I'm ready to > change the patch. Either way requires breaking the libwine interface, it's not worth it for something like that. Simply make them inline in debug.h. We don't want to include the needed headers from debug.h, but you could make the definitions conditional on the headers having been already included. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Don't threat '#' as path delimiter in file URIs.
by Marvin July 24, 2014

July 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8089 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wine.inf: Create Links directory in user profile folder to make SHGetKnownFolderPath working for KNOWNFOLDERID_Links (with test)
by Alexandre Julliard July 24, 2014

July 24, 2014

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -2552,6 +2552,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" > 16410,Microsoft, > 16412,Microsoft, > 16422,Internet Explorer,iexplore.exe > +16424,Links, It should be created in shell32 like the other shell folders. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] msi: Don't publish features with non positive install level
by Marvin July 24, 2014

July 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8087 Your paranoid android. === w2000pro (32 bit package) === package.c:3985: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3991: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3997: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:4009: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:4015: Test failed: Expected "C:\\", got "C:\" package.c:4021: Test failed: Expected "C:\\", got "C:\" package.c:4037: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4048: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4507: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4599: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4610: Test failed: Expected "C:\\", got "C:\" package.c:4621: Test failed: Expected "C:\\", got "C:\" package.c:4671: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4682: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4697: Test failed: Expected "C:\\", got "C:\" package.c:4702: Test failed: Expected "", got "C:\" package.c:4718: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4727: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4977: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4988: Test failed: Expected "C:\\", got "C:\" package.c:4994: Test failed: Expected "C:\\", got "C:\" package.c:5015: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:5026: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5266: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5272: Test failed: Expected "C:\\", got "C:\" package.c:5289: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5300: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5308: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5652: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6284: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6308: Test failed: Expected C:\\ or empty string, got C:\ package.c:6352: Test failed: Expected C:\\ or empty string, got C:\ package.c:6361: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6591: Test failed: Expected "C:\\", got "C:\" package.c:6592: Test failed: Expected 4, got 3 package.c:6599: Test failed: Expected "C:\\", got "C:\" package.c:6600: Test failed: Expected 4, got 3 package.c:6616: Test failed: Expected "C:\\", got "C:\" package.c:6617: Test failed: Expected 4, got 3 package.c:6623: Test failed: Expected "C:\\", got "C:\" package.c:6624: Test failed: Expected 4, got 3 package.c:6631: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6632: Test failed: Expected 14, got 13 package.c:6639: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6640: Test failed: Expected 19, got 18 package.c:6650: Test failed: Expected "C:\\", got "C:\" package.c:6651: Test failed: Expected 4, got 3 package.c:6658: Test failed: Expected "C:\\", got "C:\" package.c:6659: Test failed: Expected 4, got 3 package.c:6675: Test failed: Expected "C:\\", got "C:\" package.c:6676: Test failed: Expected 4, got 3 package.c:6682: Test failed: Expected "C:\\", got "C:\" package.c:6683: Test failed: Expected 4, got 3 package.c:6690: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6691: Test failed: Expected 14, got 13 package.c:6698: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6699: Test failed: Expected 19, got 18 package.c:6709: Test failed: Expected "C:\\", got "C:\" package.c:6710: Test failed: Expected 4, got 3 package.c:6717: Test failed: Expected "C:\\", got "C:\" package.c:6718: Test failed: Expected 4, got 3 package.c:6734: Test failed: Expected "C:\\", got "C:\" package.c:6735: Test failed: Expected 4, got 3 package.c:6741: Test failed: Expected "C:\\", got "C:\" package.c:6742: Test failed: Expected 4, got 3 package.c:6749: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6750: Test failed: Expected 14, got 13 package.c:6757: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6758: Test failed: Expected 19, got 18 package.c:6768: Test failed: Expected "C:\\", got "C:\" package.c:6769: Test failed: Expected 4, got 3 package.c:6776: Test failed: Expected "C:\\", got "C:\" package.c:6777: Test failed: Expected 4, got 3 package.c:6793: Test failed: Expected "C:\\", got "C:\" package.c:6794: Test failed: Expected 4, got 3 package.c:6800: Test failed: Expected "C:\\", got "C:\" package.c:6801: Test failed: Expected 4, got 3 package.c:6808: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6809: Test failed: Expected 14, got 13 package.c:6816: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6817: Test failed: Expected 19, got 18 package.c:6832: Test failed: Expected 4, got 3 package.c:6849: Test failed: Expected 4, got 3 package.c:6855: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6858: Test failed: Expected 4, got 3 package.c:6865: Test failed: Expected "C:\\", got "C:\" package.c:6866: Test failed: Expected 4, got 3 package.c:6877: Test failed: Expected "C:\\", got "C:\" package.c:6878: Test failed: Expected 4, got 3 package.c:6973: Test failed: Expected "C:\\", got "C:\" package.c:6974: Test failed: Expected 4, got 3 package.c:6981: Test failed: Expected "C:\\", got "C:\" package.c:6982: Test failed: Expected 4, got 3 package.c:6991: Test failed: Expected "C:\\", got "C:\" package.c:6992: Test failed: Expected 4, got 3 package.c:7000: Test failed: Expected "C:\\", got "C:\" package.c:7001: Test failed: Expected 4, got 3 package.c:7007: Test failed: Expected "C:\\", got "C:\" package.c:7008: Test failed: Expected 4, got 3 package.c:7015: Test failed: Expected "C:\\", got "C:\" package.c:7016: Test failed: Expected 4, got 3 package.c:7023: Test failed: Expected "C:\\", got "C:\" package.c:7024: Test failed: Expected 4, got 3 package.c:7034: Test failed: Expected "C:\\", got "C:\" package.c:7035: Test failed: Expected 4, got 3 package.c:7042: Test failed: Expected "C:\\", got "C:\" package.c:7043: Test failed: Expected 4, got 3 package.c:7052: Test failed: Expected "C:\\", got "C:\" package.c:7053: Test failed: Expected 4, got 3 package.c:7061: Test failed: Expected "C:\\", got "C:\" package.c:7062: Test failed: Expected 4, got 3 package.c:7068: Test failed: Expected "C:\\", got "C:\" package.c:7069: Test failed: Expected 4, got 3 package.c:7076: Test failed: Expected "C:\\", got "C:\" package.c:7077: Test failed: Expected 4, got 3 package.c:7084: Test failed: Expected "C:\\", got "C:\" package.c:7085: Test failed: Expected 4, got 3 package.c:7095: Test failed: Expected "C:\\", got "C:\" package.c:7096: Test failed: Expected 4, got 3 package.c:7103: Test failed: Expected "C:\\", got "C:\" package.c:7104: Test failed: Expected 4, got 3 package.c:7113: Test failed: Expected "C:\\", got "C:\" package.c:7114: Test failed: Expected 4, got 3 package.c:7122: Test failed: Expected "C:\\", got "C:\" package.c:7123: Test failed: Expected 4, got 3 package.c:7129: Test failed: Expected "C:\\", got "C:\" package.c:7130: Test failed: Expected 4, got 3 package.c:7137: Test failed: Expected "C:\\", got "C:\" package.c:7138: Test failed: Expected 4, got 3 package.c:7145: Test failed: Expected "C:\\", got "C:\" package.c:7146: Test failed: Expected 4, got 3 package.c:7156: Test failed: Expected "C:\\", got "C:\" package.c:7157: Test failed: Expected 4, got 3 package.c:7164: Test failed: Expected "C:\\", got "C:\" package.c:7165: Test failed: Expected 4, got 3 package.c:7174: Test failed: Expected "C:\\", got "C:\" package.c:7175: Test failed: Expected 4, got 3 package.c:7183: Test failed: Expected "C:\\", got "C:\" package.c:7184: Test failed: Expected 4, got 3 package.c:7190: Test failed: Expected "C:\\", got "C:\" package.c:7191: Test failed: Expected 4, got 3 package.c:7198: Test failed: Expected "C:\\", got "C:\" package.c:7199: Test failed: Expected 4, got 3 package.c:7206: Test failed: Expected "C:\\", got "C:\" package.c:7207: Test failed: Expected 4, got 3 package.c:7304: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7305: Test failed: Expected 9, got 8 package.c:7314: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7315: Test failed: Expected 9, got 8 package.c:7324: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7325: Test failed: Expected 9, got 8 package.c:7336: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7337: Test failed: Expected 8, got 7 package.c:7348: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7349: Test failed: Expected 9, got 8 package.c:7360: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7361: Test failed: Expected 8, got 7 package.c:7372: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7373: Test failed: Expected 10, got 9 package.c:7384: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7385: Test failed: Expected 8, got 7 package.c:7396: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7397: Test failed: Expected 11, got 10 package.c:7448: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7449: Test failed: Expected 10, got 9 package.c:7458: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7459: Test failed: Expected 10, got 9 package.c:7468: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7469: Test failed: Expected 10, got 9 package.c:7480: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7481: Test failed: Expected 8, got 7 package.c:7492: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7493: Test failed: Expected 10, got 9 package.c:7504: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7505: Test failed: Expected 9, got 8 package.c:7516: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7517: Test failed: Expected 10, got 9 package.c:7528: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7529: Test failed: Expected 9, got 8 package.c:7540: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7541: Test failed: Expected 11, got 10 package.c:7677: Test failed: Expected "C:\\", got "C:\" package.c:7678: Test failed: Expected 4, got 3 package.c:7689: Test failed: Expected "C:\\", got "C:\" package.c:7690: Test failed: Expected 4, got 3 package.c:7697: Test failed: Expected "C:\\", got "C:\" package.c:7698: Test failed: Expected 4, got 3 package.c:7795: Test failed: Expected "C:\\", got "C:\" package.c:7796: Test failed: Expected 4, got 3 package.c:7803: Test failed: Expected "C:\\", got "C:\" package.c:7804: Test failed: Expected 4, got 3 package.c:7811: Test failed: Expected "C:\\", got "C:\" package.c:7812: Test failed: Expected 4, got 3 package.c:7831: Test failed: Expected "C:\\", got "C:\" package.c:7832: Test failed: Expected 4, got 3 package.c:7839: Test failed: Expected "C:\\", got "C:\" package.c:7840: Test failed: Expected 4, got 3 package.c:7859: Test failed: Expected "C:\\", got "C:\" package.c:7860: Test failed: Expected 4, got 3 package.c:7867: Test failed: Expected "C:\\", got "C:\" package.c:7868: Test failed: Expected 4, got 3 package.c:7887: Test failed: Expected "C:\\", got "C:\" package.c:7888: Test failed: Expected 4, got 3 package.c:7895: Test failed: Expected "C:\\", got "C:\" package.c:7896: Test failed: Expected 4, got 3 === wvistau64 (32 bit package) === package.c:3985: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:3991: Test failed: Expected "E:\\FileName2", got "E:\FileName2" package.c:3997: Test failed: Expected "E:\\FileName3", got "E:\FileName3" package.c:4009: Test failed: Expected "E:\\FileName5", got "E:\FileName5" package.c:4015: Test failed: Expected "E:\\", got "E:\" package.c:4021: Test failed: Expected "E:\\", got "E:\" package.c:4037: Test failed: Expected "E:\\FileName8.dll", got "E:\FileName8.dll" package.c:4048: Test failed: Expected "E:\\FileName10.dll", got "E:\FileName10.dll" package.c:4507: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4599: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4610: Test failed: Expected "E:\\", got "E:\" package.c:4621: Test failed: Expected "E:\\", got "E:\" package.c:4671: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:4682: Test failed: Expected "E:\\FileName5.dll", got "E:\FileName5.dll" package.c:4697: Test failed: Expected "E:\\", got "E:\" package.c:4702: Test failed: Expected "", got "E:\" package.c:4718: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4727: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4977: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4988: Test failed: Expected "E:\\", got "E:\" package.c:4994: Test failed: Expected "E:\\", got "E:\" package.c:5015: Test failed: Expected "E:\\FileName2.dll", got "E:\FileName2.dll" package.c:5026: Test failed: Expected "E:\\FileName4.dll", got "E:\FileName4.dll" package.c:5266: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5272: Test failed: Expected "E:\\", got "E:\" package.c:5289: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5300: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5308: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:5652: Test failed: Expected E:\\winetest-package.msi, got E:\winetest-package.msi package.c:6284: Test failed: Expected E:\\abelisaurus or empty string, got E:\abelisaurus package.c:6308: Test failed: Expected E:\\ or empty string, got E:\ package.c:6352: Test failed: Expected E:\\ or empty string, got E:\ package.c:6361: Test failed: Expected E:\\neosodon\ or empty string, got E:\neosodon\ package.c:6591: Test failed: Expected "E:\\", got "E:\" package.c:6592: Test failed: Expected 4, got 3 package.c:6599: Test failed: Expected "E:\\", got "E:\" package.c:6600: Test failed: Expected 4, got 3 package.c:6616: Test failed: Expected "E:\\", got "E:\" package.c:6617: Test failed: Expected 4, got 3 package.c:6623: Test failed: Expected "E:\\", got "E:\" package.c:6624: Test failed: Expected 4, got 3 package.c:6631: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6632: Test failed: Expected 14, got 13 package.c:6639: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6640: Test failed: Expected 19, got 18 package.c:6650: Test failed: Expected "E:\\", got "E:\" package.c:6651: Test failed: Expected 4, got 3 package.c:6658: Test failed: Expected "E:\\", got "E:\" package.c:6659: Test failed: Expected 4, got 3 package.c:6675: Test failed: Expected "E:\\", got "E:\" package.c:6676: Test failed: Expected 4, got 3 package.c:6682: Test failed: Expected "E:\\", got "E:\" package.c:6683: Test failed: Expected 4, got 3 package.c:6690: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6691: Test failed: Expected 14, got 13 package.c:6698: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6699: Test failed: Expected 19, got 18 package.c:6709: Test failed: Expected "E:\\", got "E:\" package.c:6710: Test failed: Expected 4, got 3 package.c:6717: Test failed: Expected "E:\\", got "E:\" package.c:6718: Test failed: Expected 4, got 3 package.c:6734: Test failed: Expected "E:\\", got "E:\" package.c:6735: Test failed: Expected 4, got 3 package.c:6741: Test failed: Expected "E:\\", got "E:\" package.c:6742: Test failed: Expected 4, got 3 package.c:6749: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6750: Test failed: Expected 14, got 13 package.c:6757: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6758: Test failed: Expected 19, got 18 package.c:6768: Test failed: Expected "E:\\", got "E:\" package.c:6769: Test failed: Expected 4, got 3 package.c:6776: Test failed: Expected "E:\\", got "E:\" package.c:6777: Test failed: Expected 4, got 3 package.c:6793: Test failed: Expected "E:\\", got "E:\" package.c:6794: Test failed: Expected 4, got 3 package.c:6800: Test failed: Expected "E:\\", got "E:\" package.c:6801: Test failed: Expected 4, got 3 package.c:6808: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6809: Test failed: Expected 14, got 13 package.c:6816: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6817: Test failed: Expected 19, got 18 package.c:6832: Test failed: Expected 4, got 3 package.c:6849: Test failed: Expected 4, got 3 package.c:6855: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6858: Test failed: Expected 4, got 3 package.c:6865: Test failed: Expected "E:\\", got "E:\" package.c:6866: Test failed: Expected 4, got 3 package.c:6877: Test failed: Expected "E:\\", got "E:\" package.c:6878: Test failed: Expected 4, got 3 package.c:6973: Test failed: Expected "E:\\", got "E:\" package.c:6974: Test failed: Expected 4, got 3 package.c:6981: Test failed: Expected "E:\\", got "E:\" package.c:6982: Test failed: Expected 4, got 3 package.c:6991: Test failed: Expected "E:\\", got "E:\" package.c:6992: Test failed: Expected 4, got 3 package.c:7000: Test failed: Expected "E:\\", got "E:\" package.c:7001: Test failed: Expected 4, got 3 package.c:7007: Test failed: Expected "E:\\", got "E:\" package.c:7008: Test failed: Expected 4, got 3 package.c:7015: Test failed: Expected "E:\\", got "E:\" package.c:7016: Test failed: Expected 4, got 3 package.c:7023: Test failed: Expected "E:\\", got "E:\" package.c:7024: Test failed: Expected 4, got 3 package.c:7034: Test failed: Expected "E:\\", got "E:\" package.c:7035: Test failed: Expected 4, got 3 package.c:7042: Test failed: Expected "E:\\", got "E:\" package.c:7043: Test failed: Expected 4, got 3 package.c:7052: Test failed: Expected "E:\\", got "E:\" package.c:7053: Test failed: Expected 4, got 3 package.c:7061: Test failed: Expected "E:\\", got "E:\" package.c:7062: Test failed: Expected 4, got 3 package.c:7068: Test failed: Expected "E:\\", got "E:\" package.c:7069: Test failed: Expected 4, got 3 package.c:7076: Test failed: Expected "E:\\", got "E:\" package.c:7077: Test failed: Expected 4, got 3 package.c:7084: Test failed: Expected "E:\\", got "E:\" package.c:7085: Test failed: Expected 4, got 3 package.c:7095: Test failed: Expected "E:\\", got "E:\" package.c:7096: Test failed: Expected 4, got 3 package.c:7103: Test failed: Expected "E:\\", got "E:\" package.c:7104: Test failed: Expected 4, got 3 package.c:7113: Test failed: Expected "E:\\", got "E:\" package.c:7114: Test failed: Expected 4, got 3 package.c:7122: Test failed: Expected "E:\\", got "E:\" package.c:7123: Test failed: Expected 4, got 3 package.c:7129: Test failed: Expected "E:\\", got "E:\" package.c:7130: Test failed: Expected 4, got 3 package.c:7137: Test failed: Expected "E:\\", got "E:\" package.c:7138: Test failed: Expected 4, got 3 package.c:7145: Test failed: Expected "E:\\", got "E:\" package.c:7146: Test failed: Expected 4, got 3 package.c:7156: Test failed: Expected "E:\\", got "E:\" package.c:7157: Test failed: Expected 4, got 3 package.c:7164: Test failed: Expected "E:\\", got "E:\" package.c:7165: Test failed: Expected 4, got 3 package.c:7174: Test failed: Expected "E:\\", got "E:\" package.c:7175: Test failed: Expected 4, got 3 package.c:7183: Test failed: Expected "E:\\", got "E:\" package.c:7184: Test failed: Expected 4, got 3 package.c:7190: Test failed: Expected "E:\\", got "E:\" package.c:7191: Test failed: Expected 4, got 3 package.c:7198: Test failed: Expected "E:\\", got "E:\" package.c:7199: Test failed: Expected 4, got 3 package.c:7206: Test failed: Expected "E:\\", got "E:\" package.c:7207: Test failed: Expected 4, got 3 package.c:7304: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7305: Test failed: Expected 9, got 8 package.c:7314: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7315: Test failed: Expected 9, got 8 package.c:7324: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7325: Test failed: Expected 9, got 8 package.c:7336: Test failed: Expected "E:\\two\", got "E:\two\" package.c:7337: Test failed: Expected 8, got 7 package.c:7348: Test failed: Expected "E:\\four\", got "E:\four\" package.c:7349: Test failed: Expected 9, got 8 package.c:7360: Test failed: Expected "E:\\six\", got "E:\six\" package.c:7361: Test failed: Expected 8, got 7 package.c:7372: Test failed: Expected "E:\\eight\", got "E:\eight\" package.c:7373: Test failed: Expected 10, got 9 package.c:7384: Test failed: Expected "E:\\ten\", got "E:\ten\" package.c:7385: Test failed: Expected 8, got 7 package.c:7396: Test failed: Expected "E:\\twelve\", got "E:\twelve\" package.c:7397: Test failed: Expected 11, got 10 package.c:7448: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7449: Test failed: Expected 10, got 9 package.c:7458: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7459: Test failed: Expected 10, got 9 package.c:7468: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7469: Test failed: Expected 10, got 9 package.c:7480: Test failed: Expected "E:\\one\", got "E:\one\" package.c:7481: Test failed: Expected 8, got 7 package.c:7492: Test failed: Expected "E:\\three\", got "E:\three\" package.c:7493: Test failed: Expected 10, got 9 package.c:7504: Test failed: Expected "E:\\five\", got "E:\five\" package.c:7505: Test failed: Expected 9, got 8 package.c:7516: Test failed: Expected "E:\\seven\", got "E:\seven\" package.c:7517: Test failed: Expected 10, got 9 package.c:7528: Test failed: Expected "E:\\nine\", got "E:\nine\" package.c:7529: Test failed: Expected 9, got 8 package.c:7540: Test failed: Expected "E:\\eleven\", got "E:\eleven\" package.c:7541: Test failed: Expected 11, got 10 package.c:7677: Test failed: Expected "E:\\", got "E:\" package.c:7678: Test failed: Expected 4, got 3 package.c:7689: Test failed: Expected "E:\\", got "E:\" package.c:7690: Test failed: Expected 4, got 3 package.c:7697: Test failed: Expected "E:\\", got "E:\" package.c:7698: Test failed: Expected 4, got 3 package.c:7795: Test failed: Expected "E:\\", got "E:\" package.c:7796: Test failed: Expected 4, got 3 package.c:7803: Test failed: Expected "E:\\", got "E:\" package.c:7804: Test failed: Expected 4, got 3 package.c:7811: Test failed: Expected "E:\\", got "E:\" package.c:7812: Test failed: Expected 4, got 3 package.c:7831: Test failed: Expected "E:\\", got "E:\" package.c:7832: Test failed: Expected 4, got 3 package.c:7839: Test failed: Expected "E:\\", got "E:\" package.c:7840: Test failed: Expected 4, got 3 package.c:7859: Test failed: Expected "E:\\", got "E:\" package.c:7860: Test failed: Expected 4, got 3 package.c:7867: Test failed: Expected "E:\\", got "E:\" package.c:7868: Test failed: Expected 4, got 3 package.c:7887: Test failed: Expected "E:\\", got "E:\" package.c:7888: Test failed: Expected 4, got 3 package.c:7895: Test failed: Expected "E:\\", got "E:\" package.c:7896: Test failed: Expected 4, got 3 === w7u (32 bit package) === The test timed out === wvistau64 (64 bit package) === package.c:3985: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:3991: Test failed: Expected "E:\\FileName2", got "E:\FileName2" package.c:3997: Test failed: Expected "E:\\FileName3", got "E:\FileName3" package.c:4009: Test failed: Expected "E:\\FileName5", got "E:\FileName5" package.c:4015: Test failed: Expected "E:\\", got "E:\" package.c:4021: Test failed: Expected "E:\\", got "E:\" package.c:4037: Test failed: Expected "E:\\FileName8.dll", got "E:\FileName8.dll" package.c:4048: Test failed: Expected "E:\\FileName10.dll", got "E:\FileName10.dll" package.c:4507: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4599: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4610: Test failed: Expected "E:\\", got "E:\" package.c:4621: Test failed: Expected "E:\\", got "E:\" package.c:4671: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:4682: Test failed: Expected "E:\\FileName5.dll", got "E:\FileName5.dll" package.c:4697: Test failed: Expected "E:\\", got "E:\" package.c:4702: Test failed: Expected "", got "E:\" package.c:4718: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4727: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4977: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4988: Test failed: Expected "E:\\", got "E:\" package.c:4994: Test failed: Expected "E:\\", got "E:\" package.c:5015: Test failed: Expected "E:\\FileName2.dll", got "E:\FileName2.dll" package.c:5026: Test failed: Expected "E:\\FileName4.dll", got "E:\FileName4.dll" package.c:5266: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5272: Test failed: Expected "E:\\", got "E:\" package.c:5289: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5300: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5308: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:5652: Test failed: Expected E:\\winetest-package.msi, got E:\winetest-package.msi package.c:6284: Test failed: Expected E:\\abelisaurus or empty string, got E:\abelisaurus package.c:6308: Test failed: Expected E:\\ or empty string, got E:\ package.c:6352: Test failed: Expected E:\\ or empty string, got E:\ package.c:6361: Test failed: Expected E:\\neosodon\ or empty string, got E:\neosodon\ package.c:6591: Test failed: Expected "E:\\", got "E:\" package.c:6592: Test failed: Expected 4, got 3 package.c:6599: Test failed: Expected "E:\\", got "E:\" package.c:6600: Test failed: Expected 4, got 3 package.c:6616: Test failed: Expected "E:\\", got "E:\" package.c:6617: Test failed: Expected 4, got 3 package.c:6623: Test failed: Expected "E:\\", got "E:\" package.c:6624: Test failed: Expected 4, got 3 package.c:6631: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6632: Test failed: Expected 14, got 13 package.c:6639: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6640: Test failed: Expected 19, got 18 package.c:6650: Test failed: Expected "E:\\", got "E:\" package.c:6651: Test failed: Expected 4, got 3 package.c:6658: Test failed: Expected "E:\\", got "E:\" package.c:6659: Test failed: Expected 4, got 3 package.c:6675: Test failed: Expected "E:\\", got "E:\" package.c:6676: Test failed: Expected 4, got 3 package.c:6682: Test failed: Expected "E:\\", got "E:\" package.c:6683: Test failed: Expected 4, got 3 package.c:6690: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6691: Test failed: Expected 14, got 13 package.c:6698: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6699: Test failed: Expected 19, got 18 package.c:6709: Test failed: Expected "E:\\", got "E:\" package.c:6710: Test failed: Expected 4, got 3 package.c:6717: Test failed: Expected "E:\\", got "E:\" package.c:6718: Test failed: Expected 4, got 3 package.c:6734: Test failed: Expected "E:\\", got "E:\" package.c:6735: Test failed: Expected 4, got 3 package.c:6741: Test failed: Expected "E:\\", got "E:\" package.c:6742: Test failed: Expected 4, got 3 package.c:6749: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6750: Test failed: Expected 14, got 13 package.c:6757: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6758: Test failed: Expected 19, got 18 package.c:6768: Test failed: Expected "E:\\", got "E:\" package.c:6769: Test failed: Expected 4, got 3 package.c:6776: Test failed: Expected "E:\\", got "E:\" package.c:6777: Test failed: Expected 4, got 3 package.c:6793: Test failed: Expected "E:\\", got "E:\" package.c:6794: Test failed: Expected 4, got 3 package.c:6800: Test failed: Expected "E:\\", got "E:\" package.c:6801: Test failed: Expected 4, got 3 package.c:6808: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6809: Test failed: Expected 14, got 13 package.c:6816: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6817: Test failed: Expected 19, got 18 package.c:6832: Test failed: Expected 4, got 3 package.c:6849: Test failed: Expected 4, got 3 package.c:6855: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6858: Test failed: Expected 4, got 3 package.c:6865: Test failed: Expected "E:\\", got "E:\" package.c:6866: Test failed: Expected 4, got 3 package.c:6877: Test failed: Expected "E:\\", got "E:\" package.c:6878: Test failed: Expected 4, got 3 package.c:6973: Test failed: Expected "E:\\", got "E:\" package.c:6974: Test failed: Expected 4, got 3 package.c:6981: Test failed: Expected "E:\\", got "E:\" package.c:6982: Test failed: Expected 4, got 3 package.c:6991: Test failed: Expected "E:\\", got "E:\" package.c:6992: Test failed: Expected 4, got 3 package.c:7000: Test failed: Expected "E:\\", got "E:\" package.c:7001: Test failed: Expected 4, got 3 package.c:7007: Test failed: Expected "E:\\", got "E:\" package.c:7008: Test failed: Expected 4, got 3 package.c:7015: Test failed: Expected "E:\\", got "E:\" package.c:7016: Test failed: Expected 4, got 3 package.c:7023: Test failed: Expected "E:\\", got "E:\" package.c:7024: Test failed: Expected 4, got 3 package.c:7034: Test failed: Expected "E:\\", got "E:\" package.c:7035: Test failed: Expected 4, got 3 package.c:7042: Test failed: Expected "E:\\", got "E:\" package.c:7043: Test failed: Expected 4, got 3 package.c:7052: Test failed: Expected "E:\\", got "E:\" package.c:7053: Test failed: Expected 4, got 3 package.c:7061: Test failed: Expected "E:\\", got "E:\" package.c:7062: Test failed: Expected 4, got 3 package.c:7068: Test failed: Expected "E:\\", got "E:\" package.c:7069: Test failed: Expected 4, got 3 package.c:7076: Test failed: Expected "E:\\", got "E:\" package.c:7077: Test failed: Expected 4, got 3 package.c:7084: Test failed: Expected "E:\\", got "E:\" package.c:7085: Test failed: Expected 4, got 3 package.c:7095: Test failed: Expected "E:\\", got "E:\" package.c:7096: Test failed: Expected 4, got 3 package.c:7103: Test failed: Expected "E:\\", got "E:\" package.c:7104: Test failed: Expected 4, got 3 package.c:7113: Test failed: Expected "E:\\", got "E:\" package.c:7114: Test failed: Expected 4, got 3 package.c:7122: Test failed: Expected "E:\\", got "E:\" package.c:7123: Test failed: Expected 4, got 3 package.c:7129: Test failed: Expected "E:\\", got "E:\" package.c:7130: Test failed: Expected 4, got 3 package.c:7137: Test failed: Expected "E:\\", got "E:\" package.c:7138: Test failed: Expected 4, got 3 package.c:7145: Test failed: Expected "E:\\", got "E:\" package.c:7146: Test failed: Expected 4, got 3 package.c:7156: Test failed: Expected "E:\\", got "E:\" package.c:7157: Test failed: Expected 4, got 3 package.c:7164: Test failed: Expected "E:\\", got "E:\" package.c:7165: Test failed: Expected 4, got 3 package.c:7174: Test failed: Expected "E:\\", got "E:\" package.c:7175: Test failed: Expected 4, got 3 package.c:7183: Test failed: Expected "E:\\", got "E:\" package.c:7184: Test failed: Expected 4, got 3 package.c:7190: Test failed: Expected "E:\\", got "E:\" package.c:7191: Test failed: Expected 4, got 3 package.c:7198: Test failed: Expected "E:\\", got "E:\" package.c:7199: Test failed: Expected 4, got 3 package.c:7206: Test failed: Expected "E:\\", got "E:\" package.c:7207: Test failed: Expected 4, got 3 package.c:7304: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7305: Test failed: Expected 9, got 8 package.c:7314: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7315: Test failed: Expected 9, got 8 package.c:7324: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7325: Test failed: Expected 9, got 8 package.c:7336: Test failed: Expected "E:\\two\", got "E:\two\" package.c:7337: Test failed: Expected 8, got 7 package.c:7348: Test failed: Expected "E:\\four\", got "E:\four\" package.c:7349: Test failed: Expected 9, got 8 package.c:7360: Test failed: Expected "E:\\six\", got "E:\six\" package.c:7361: Test failed: Expected 8, got 7 package.c:7372: Test failed: Expected "E:\\eight\", got "E:\eight\" package.c:7373: Test failed: Expected 10, got 9 package.c:7384: Test failed: Expected "E:\\ten\", got "E:\ten\" package.c:7385: Test failed: Expected 8, got 7 package.c:7396: Test failed: Expected "E:\\twelve\", got "E:\twelve\" package.c:7397: Test failed: Expected 11, got 10 package.c:7448: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7449: Test failed: Expected 10, got 9 package.c:7458: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7459: Test failed: Expected 10, got 9 package.c:7468: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7469: Test failed: Expected 10, got 9 package.c:7480: Test failed: Expected "E:\\one\", got "E:\one\" package.c:7481: Test failed: Expected 8, got 7 package.c:7492: Test failed: Expected "E:\\three\", got "E:\three\" package.c:7493: Test failed: Expected 10, got 9 package.c:7504: Test failed: Expected "E:\\five\", got "E:\five\" package.c:7505: Test failed: Expected 9, got 8 package.c:7516: Test failed: Expected "E:\\seven\", got "E:\seven\" package.c:7517: Test failed: Expected 10, got 9 package.c:7528: Test failed: Expected "E:\\nine\", got "E:\nine\" package.c:7529: Test failed: Expected 9, got 8 package.c:7540: Test failed: Expected "E:\\eleven\", got "E:\eleven\" package.c:7541: Test failed: Expected 11, got 10 package.c:7677: Test failed: Expected "E:\\", got "E:\" package.c:7678: Test failed: Expected 4, got 3 package.c:7689: Test failed: Expected "E:\\", got "E:\" package.c:7690: Test failed: Expected 4, got 3 package.c:7697: Test failed: Expected "E:\\", got "E:\" package.c:7698: Test failed: Expected 4, got 3 package.c:7795: Test failed: Expected "E:\\", got "E:\" package.c:7796: Test failed: Expected 4, got 3 package.c:7803: Test failed: Expected "E:\\", got "E:\" package.c:7804: Test failed: Expected 4, got 3 package.c:7811: Test failed: Expected "E:\\", got "E:\" package.c:7812: Test failed: Expected 4, got 3 package.c:7831: Test failed: Expected "E:\\", got "E:\" package.c:7832: Test failed: Expected 4, got 3 package.c:7839: Test failed: Expected "E:\\", got "E:\" package.c:7840: Test failed: Expected 4, got 3 package.c:7859: Test failed: Expected "E:\\", got "E:\" package.c:7860: Test failed: Expected 4, got 3 package.c:7867: Test failed: Expected "E:\\", got "E:\" package.c:7868: Test failed: Expected 4, got 3 package.c:7887: Test failed: Expected "E:\\", got "E:\" package.c:7888: Test failed: Expected 4, got 3 package.c:7895: Test failed: Expected "E:\\", got "E:\" package.c:7896: Test failed: Expected 4, got 3

2 1

Re: [PATCH 4/4] msi: Add more feature state tests
by Marvin July 24, 2014

July 24, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8088 Your paranoid android. === w2000pro (32 bit package) === package.c:4034: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4040: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:4046: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:4058: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:4064: Test failed: Expected "C:\\", got "C:\" package.c:4070: Test failed: Expected "C:\\", got "C:\" package.c:4086: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4097: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4556: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4648: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4659: Test failed: Expected "C:\\", got "C:\" package.c:4670: Test failed: Expected "C:\\", got "C:\" package.c:4720: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4731: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4746: Test failed: Expected "C:\\", got "C:\" package.c:4751: Test failed: Expected "", got "C:\" package.c:4767: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4776: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5026: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5037: Test failed: Expected "C:\\", got "C:\" package.c:5043: Test failed: Expected "C:\\", got "C:\" package.c:5064: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:5075: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5315: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5321: Test failed: Expected "C:\\", got "C:\" package.c:5338: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5349: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5357: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5701: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6333: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6357: Test failed: Expected C:\\ or empty string, got C:\ package.c:6401: Test failed: Expected C:\\ or empty string, got C:\ package.c:6410: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6640: Test failed: Expected "C:\\", got "C:\" package.c:6641: Test failed: Expected 4, got 3 package.c:6648: Test failed: Expected "C:\\", got "C:\" package.c:6649: Test failed: Expected 4, got 3 package.c:6665: Test failed: Expected "C:\\", got "C:\" package.c:6666: Test failed: Expected 4, got 3 package.c:6672: Test failed: Expected "C:\\", got "C:\" package.c:6673: Test failed: Expected 4, got 3 package.c:6680: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6681: Test failed: Expected 14, got 13 package.c:6688: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6689: Test failed: Expected 19, got 18 package.c:6699: Test failed: Expected "C:\\", got "C:\" package.c:6700: Test failed: Expected 4, got 3 package.c:6707: Test failed: Expected "C:\\", got "C:\" package.c:6708: Test failed: Expected 4, got 3 package.c:6724: Test failed: Expected "C:\\", got "C:\" package.c:6725: Test failed: Expected 4, got 3 package.c:6731: Test failed: Expected "C:\\", got "C:\" package.c:6732: Test failed: Expected 4, got 3 package.c:6739: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6740: Test failed: Expected 14, got 13 package.c:6747: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6748: Test failed: Expected 19, got 18 package.c:6758: Test failed: Expected "C:\\", got "C:\" package.c:6759: Test failed: Expected 4, got 3 package.c:6766: Test failed: Expected "C:\\", got "C:\" package.c:6767: Test failed: Expected 4, got 3 package.c:6783: Test failed: Expected "C:\\", got "C:\" package.c:6784: Test failed: Expected 4, got 3 package.c:6790: Test failed: Expected "C:\\", got "C:\" package.c:6791: Test failed: Expected 4, got 3 package.c:6798: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6799: Test failed: Expected 14, got 13 package.c:6806: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6807: Test failed: Expected 19, got 18 package.c:6817: Test failed: Expected "C:\\", got "C:\" package.c:6818: Test failed: Expected 4, got 3 package.c:6825: Test failed: Expected "C:\\", got "C:\" package.c:6826: Test failed: Expected 4, got 3 package.c:6842: Test failed: Expected "C:\\", got "C:\" package.c:6843: Test failed: Expected 4, got 3 package.c:6849: Test failed: Expected "C:\\", got "C:\" package.c:6850: Test failed: Expected 4, got 3 package.c:6857: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6858: Test failed: Expected 14, got 13 package.c:6865: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6866: Test failed: Expected 19, got 18 package.c:6881: Test failed: Expected 4, got 3 package.c:6898: Test failed: Expected 4, got 3 package.c:6904: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6907: Test failed: Expected 4, got 3 package.c:6914: Test failed: Expected "C:\\", got "C:\" package.c:6915: Test failed: Expected 4, got 3 package.c:6926: Test failed: Expected "C:\\", got "C:\" package.c:6927: Test failed: Expected 4, got 3 package.c:7022: Test failed: Expected "C:\\", got "C:\" package.c:7023: Test failed: Expected 4, got 3 package.c:7030: Test failed: Expected "C:\\", got "C:\" package.c:7031: Test failed: Expected 4, got 3 package.c:7040: Test failed: Expected "C:\\", got "C:\" package.c:7041: Test failed: Expected 4, got 3 package.c:7049: Test failed: Expected "C:\\", got "C:\" package.c:7050: Test failed: Expected 4, got 3 package.c:7056: Test failed: Expected "C:\\", got "C:\" package.c:7057: Test failed: Expected 4, got 3 package.c:7064: Test failed: Expected "C:\\", got "C:\" package.c:7065: Test failed: Expected 4, got 3 package.c:7072: Test failed: Expected "C:\\", got "C:\" package.c:7073: Test failed: Expected 4, got 3 package.c:7083: Test failed: Expected "C:\\", got "C:\" package.c:7084: Test failed: Expected 4, got 3 package.c:7091: Test failed: Expected "C:\\", got "C:\" package.c:7092: Test failed: Expected 4, got 3 package.c:7101: Test failed: Expected "C:\\", got "C:\" package.c:7102: Test failed: Expected 4, got 3 package.c:7110: Test failed: Expected "C:\\", got "C:\" package.c:7111: Test failed: Expected 4, got 3 package.c:7117: Test failed: Expected "C:\\", got "C:\" package.c:7118: Test failed: Expected 4, got 3 package.c:7125: Test failed: Expected "C:\\", got "C:\" package.c:7126: Test failed: Expected 4, got 3 package.c:7133: Test failed: Expected "C:\\", got "C:\" package.c:7134: Test failed: Expected 4, got 3 package.c:7144: Test failed: Expected "C:\\", got "C:\" package.c:7145: Test failed: Expected 4, got 3 package.c:7152: Test failed: Expected "C:\\", got "C:\" package.c:7153: Test failed: Expected 4, got 3 package.c:7162: Test failed: Expected "C:\\", got "C:\" package.c:7163: Test failed: Expected 4, got 3 package.c:7171: Test failed: Expected "C:\\", got "C:\" package.c:7172: Test failed: Expected 4, got 3 package.c:7178: Test failed: Expected "C:\\", got "C:\" package.c:7179: Test failed: Expected 4, got 3 package.c:7186: Test failed: Expected "C:\\", got "C:\" package.c:7187: Test failed: Expected 4, got 3 package.c:7194: Test failed: Expected "C:\\", got "C:\" package.c:7195: Test failed: Expected 4, got 3 package.c:7205: Test failed: Expected "C:\\", got "C:\" package.c:7206: Test failed: Expected 4, got 3 package.c:7213: Test failed: Expected "C:\\", got "C:\" package.c:7214: Test failed: Expected 4, got 3 package.c:7223: Test failed: Expected "C:\\", got "C:\" package.c:7224: Test failed: Expected 4, got 3 package.c:7232: Test failed: Expected "C:\\", got "C:\" package.c:7233: Test failed: Expected 4, got 3 package.c:7239: Test failed: Expected "C:\\", got "C:\" package.c:7240: Test failed: Expected 4, got 3 package.c:7247: Test failed: Expected "C:\\", got "C:\" package.c:7248: Test failed: Expected 4, got 3 package.c:7255: Test failed: Expected "C:\\", got "C:\" package.c:7256: Test failed: Expected 4, got 3 package.c:7353: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7354: Test failed: Expected 9, got 8 package.c:7363: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7364: Test failed: Expected 9, got 8 package.c:7373: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7374: Test failed: Expected 9, got 8 package.c:7385: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7386: Test failed: Expected 8, got 7 package.c:7397: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7398: Test failed: Expected 9, got 8 package.c:7409: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7410: Test failed: Expected 8, got 7 package.c:7421: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7422: Test failed: Expected 10, got 9 package.c:7433: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7434: Test failed: Expected 8, got 7 package.c:7445: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7446: Test failed: Expected 11, got 10 package.c:7497: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7498: Test failed: Expected 10, got 9 package.c:7507: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7508: Test failed: Expected 10, got 9 package.c:7517: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7518: Test failed: Expected 10, got 9 package.c:7529: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7530: Test failed: Expected 8, got 7 package.c:7541: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7542: Test failed: Expected 10, got 9 package.c:7553: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7554: Test failed: Expected 9, got 8 package.c:7565: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7566: Test failed: Expected 10, got 9 package.c:7577: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7578: Test failed: Expected 9, got 8 package.c:7589: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7590: Test failed: Expected 11, got 10 package.c:7726: Test failed: Expected "C:\\", got "C:\" package.c:7727: Test failed: Expected 4, got 3 package.c:7738: Test failed: Expected "C:\\", got "C:\" package.c:7739: Test failed: Expected 4, got 3 package.c:7746: Test failed: Expected "C:\\", got "C:\" package.c:7747: Test failed: Expected 4, got 3 package.c:7844: Test failed: Expected "C:\\", got "C:\" package.c:7845: Test failed: Expected 4, got 3 package.c:7852: Test failed: Expected "C:\\", got "C:\" package.c:7853: Test failed: Expected 4, got 3 package.c:7860: Test failed: Expected "C:\\", got "C:\" package.c:7861: Test failed: Expected 4, got 3 package.c:7880: Test failed: Expected "C:\\", got "C:\" package.c:7881: Test failed: Expected 4, got 3 package.c:7888: Test failed: Expected "C:\\", got "C:\" package.c:7889: Test failed: Expected 4, got 3 package.c:7908: Test failed: Expected "C:\\", got "C:\" package.c:7909: Test failed: Expected 4, got 3 package.c:7916: Test failed: Expected "C:\\", got "C:\" package.c:7917: Test failed: Expected 4, got 3 package.c:7936: Test failed: Expected "C:\\", got "C:\" package.c:7937: Test failed: Expected 4, got 3 package.c:7944: Test failed: Expected "C:\\", got "C:\" package.c:7945: Test failed: Expected 4, got 3 === wvistau64 (32 bit package) === package.c:4034: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4040: Test failed: Expected "E:\\FileName2", got "E:\FileName2" package.c:4046: Test failed: Expected "E:\\FileName3", got "E:\FileName3" package.c:4058: Test failed: Expected "E:\\FileName5", got "E:\FileName5" package.c:4064: Test failed: Expected "E:\\", got "E:\" package.c:4070: Test failed: Expected "E:\\", got "E:\" package.c:4086: Test failed: Expected "E:\\FileName8.dll", got "E:\FileName8.dll" package.c:4097: Test failed: Expected "E:\\FileName10.dll", got "E:\FileName10.dll" package.c:4556: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4648: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4659: Test failed: Expected "E:\\", got "E:\" package.c:4670: Test failed: Expected "E:\\", got "E:\" package.c:4720: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:4731: Test failed: Expected "E:\\FileName5.dll", got "E:\FileName5.dll" package.c:4746: Test failed: Expected "E:\\", got "E:\" package.c:4751: Test failed: Expected "", got "E:\" package.c:4767: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4776: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5026: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5037: Test failed: Expected "E:\\", got "E:\" package.c:5043: Test failed: Expected "E:\\", got "E:\" package.c:5064: Test failed: Expected "E:\\FileName2.dll", got "E:\FileName2.dll" package.c:5075: Test failed: Expected "E:\\FileName4.dll", got "E:\FileName4.dll" package.c:5315: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5321: Test failed: Expected "E:\\", got "E:\" package.c:5338: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5349: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5357: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:5701: Test failed: Expected E:\\winetest-package.msi, got E:\winetest-package.msi package.c:6333: Test failed: Expected E:\\abelisaurus or empty string, got E:\abelisaurus package.c:6357: Test failed: Expected E:\\ or empty string, got E:\ package.c:6401: Test failed: Expected E:\\ or empty string, got E:\ package.c:6410: Test failed: Expected E:\\neosodon\ or empty string, got E:\neosodon\ package.c:6640: Test failed: Expected "E:\\", got "E:\" package.c:6641: Test failed: Expected 4, got 3 package.c:6648: Test failed: Expected "E:\\", got "E:\" package.c:6649: Test failed: Expected 4, got 3 package.c:6665: Test failed: Expected "E:\\", got "E:\" package.c:6666: Test failed: Expected 4, got 3 package.c:6672: Test failed: Expected "E:\\", got "E:\" package.c:6673: Test failed: Expected 4, got 3 package.c:6680: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6681: Test failed: Expected 14, got 13 package.c:6688: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6689: Test failed: Expected 19, got 18 package.c:6699: Test failed: Expected "E:\\", got "E:\" package.c:6700: Test failed: Expected 4, got 3 package.c:6707: Test failed: Expected "E:\\", got "E:\" package.c:6708: Test failed: Expected 4, got 3 package.c:6724: Test failed: Expected "E:\\", got "E:\" package.c:6725: Test failed: Expected 4, got 3 package.c:6731: Test failed: Expected "E:\\", got "E:\" package.c:6732: Test failed: Expected 4, got 3 package.c:6739: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6740: Test failed: Expected 14, got 13 package.c:6747: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6748: Test failed: Expected 19, got 18 package.c:6758: Test failed: Expected "E:\\", got "E:\" package.c:6759: Test failed: Expected 4, got 3 package.c:6766: Test failed: Expected "E:\\", got "E:\" package.c:6767: Test failed: Expected 4, got 3 package.c:6783: Test failed: Expected "E:\\", got "E:\" package.c:6784: Test failed: Expected 4, got 3 package.c:6790: Test failed: Expected "E:\\", got "E:\" package.c:6791: Test failed: Expected 4, got 3 package.c:6798: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6799: Test failed: Expected 14, got 13 package.c:6806: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6807: Test failed: Expected 19, got 18 package.c:6817: Test failed: Expected "E:\\", got "E:\" package.c:6818: Test failed: Expected 4, got 3 package.c:6825: Test failed: Expected "E:\\", got "E:\" package.c:6826: Test failed: Expected 4, got 3 package.c:6842: Test failed: Expected "E:\\", got "E:\" package.c:6843: Test failed: Expected 4, got 3 package.c:6849: Test failed: Expected "E:\\", got "E:\" package.c:6850: Test failed: Expected 4, got 3 package.c:6857: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6858: Test failed: Expected 14, got 13 package.c:6865: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6866: Test failed: Expected 19, got 18 package.c:6881: Test failed: Expected 4, got 3 package.c:6898: Test failed: Expected 4, got 3 package.c:6904: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6907: Test failed: Expected 4, got 3 package.c:6914: Test failed: Expected "E:\\", got "E:\" package.c:6915: Test failed: Expected 4, got 3 package.c:6926: Test failed: Expected "E:\\", got "E:\" package.c:6927: Test failed: Expected 4, got 3 package.c:7022: Test failed: Expected "E:\\", got "E:\" package.c:7023: Test failed: Expected 4, got 3 package.c:7030: Test failed: Expected "E:\\", got "E:\" package.c:7031: Test failed: Expected 4, got 3 package.c:7040: Test failed: Expected "E:\\", got "E:\" package.c:7041: Test failed: Expected 4, got 3 package.c:7049: Test failed: Expected "E:\\", got "E:\" package.c:7050: Test failed: Expected 4, got 3 package.c:7056: Test failed: Expected "E:\\", got "E:\" package.c:7057: Test failed: Expected 4, got 3 package.c:7064: Test failed: Expected "E:\\", got "E:\" package.c:7065: Test failed: Expected 4, got 3 package.c:7072: Test failed: Expected "E:\\", got "E:\" package.c:7073: Test failed: Expected 4, got 3 package.c:7083: Test failed: Expected "E:\\", got "E:\" package.c:7084: Test failed: Expected 4, got 3 package.c:7091: Test failed: Expected "E:\\", got "E:\" package.c:7092: Test failed: Expected 4, got 3 package.c:7101: Test failed: Expected "E:\\", got "E:\" package.c:7102: Test failed: Expected 4, got 3 package.c:7110: Test failed: Expected "E:\\", got "E:\" package.c:7111: Test failed: Expected 4, got 3 package.c:7117: Test failed: Expected "E:\\", got "E:\" package.c:7118: Test failed: Expected 4, got 3 package.c:7125: Test failed: Expected "E:\\", got "E:\" package.c:7126: Test failed: Expected 4, got 3 package.c:7133: Test failed: Expected "E:\\", got "E:\" package.c:7134: Test failed: Expected 4, got 3 package.c:7144: Test failed: Expected "E:\\", got "E:\" package.c:7145: Test failed: Expected 4, got 3 package.c:7152: Test failed: Expected "E:\\", got "E:\" package.c:7153: Test failed: Expected 4, got 3 package.c:7162: Test failed: Expected "E:\\", got "E:\" package.c:7163: Test failed: Expected 4, got 3 package.c:7171: Test failed: Expected "E:\\", got "E:\" package.c:7172: Test failed: Expected 4, got 3 package.c:7178: Test failed: Expected "E:\\", got "E:\" package.c:7179: Test failed: Expected 4, got 3 package.c:7186: Test failed: Expected "E:\\", got "E:\" package.c:7187: Test failed: Expected 4, got 3 package.c:7194: Test failed: Expected "E:\\", got "E:\" package.c:7195: Test failed: Expected 4, got 3 package.c:7205: Test failed: Expected "E:\\", got "E:\" package.c:7206: Test failed: Expected 4, got 3 package.c:7213: Test failed: Expected "E:\\", got "E:\" package.c:7214: Test failed: Expected 4, got 3 package.c:7223: Test failed: Expected "E:\\", got "E:\" package.c:7224: Test failed: Expected 4, got 3 package.c:7232: Test failed: Expected "E:\\", got "E:\" package.c:7233: Test failed: Expected 4, got 3 package.c:7239: Test failed: Expected "E:\\", got "E:\" package.c:7240: Test failed: Expected 4, got 3 package.c:7247: Test failed: Expected "E:\\", got "E:\" package.c:7248: Test failed: Expected 4, got 3 package.c:7255: Test failed: Expected "E:\\", got "E:\" package.c:7256: Test failed: Expected 4, got 3 package.c:7353: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7354: Test failed: Expected 9, got 8 package.c:7363: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7364: Test failed: Expected 9, got 8 package.c:7373: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7374: Test failed: Expected 9, got 8 package.c:7385: Test failed: Expected "E:\\two\", got "E:\two\" package.c:7386: Test failed: Expected 8, got 7 package.c:7397: Test failed: Expected "E:\\four\", got "E:\four\" package.c:7398: Test failed: Expected 9, got 8 package.c:7409: Test failed: Expected "E:\\six\", got "E:\six\" package.c:7410: Test failed: Expected 8, got 7 package.c:7421: Test failed: Expected "E:\\eight\", got "E:\eight\" package.c:7422: Test failed: Expected 10, got 9 package.c:7433: Test failed: Expected "E:\\ten\", got "E:\ten\" package.c:7434: Test failed: Expected 8, got 7 package.c:7445: Test failed: Expected "E:\\twelve\", got "E:\twelve\" package.c:7446: Test failed: Expected 11, got 10 package.c:7497: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7498: Test failed: Expected 10, got 9 package.c:7507: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7508: Test failed: Expected 10, got 9 package.c:7517: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7518: Test failed: Expected 10, got 9 package.c:7529: Test failed: Expected "E:\\one\", got "E:\one\" package.c:7530: Test failed: Expected 8, got 7 package.c:7541: Test failed: Expected "E:\\three\", got "E:\three\" package.c:7542: Test failed: Expected 10, got 9 package.c:7553: Test failed: Expected "E:\\five\", got "E:\five\" package.c:7554: Test failed: Expected 9, got 8 package.c:7565: Test failed: Expected "E:\\seven\", got "E:\seven\" package.c:7566: Test failed: Expected 10, got 9 package.c:7577: Test failed: Expected "E:\\nine\", got "E:\nine\" package.c:7578: Test failed: Expected 9, got 8 package.c:7589: Test failed: Expected "E:\\eleven\", got "E:\eleven\" package.c:7590: Test failed: Expected 11, got 10 package.c:7726: Test failed: Expected "E:\\", got "E:\" package.c:7727: Test failed: Expected 4, got 3 package.c:7738: Test failed: Expected "E:\\", got "E:\" package.c:7739: Test failed: Expected 4, got 3 package.c:7746: Test failed: Expected "E:\\", got "E:\" package.c:7747: Test failed: Expected 4, got 3 package.c:7844: Test failed: Expected "E:\\", got "E:\" package.c:7845: Test failed: Expected 4, got 3 package.c:7852: Test failed: Expected "E:\\", got "E:\" package.c:7853: Test failed: Expected 4, got 3 package.c:7860: Test failed: Expected "E:\\", got "E:\" package.c:7861: Test failed: Expected 4, got 3 package.c:7880: Test failed: Expected "E:\\", got "E:\" package.c:7881: Test failed: Expected 4, got 3 package.c:7888: Test failed: Expected "E:\\", got "E:\" package.c:7889: Test failed: Expected 4, got 3 package.c:7908: Test failed: Expected "E:\\", got "E:\" package.c:7909: Test failed: Expected 4, got 3 package.c:7916: Test failed: Expected "E:\\", got "E:\" package.c:7917: Test failed: Expected 4, got 3 package.c:7936: Test failed: Expected "E:\\", got "E:\" package.c:7937: Test failed: Expected 4, got 3 package.c:7944: Test failed: Expected "E:\\", got "E:\" package.c:7945: Test failed: Expected 4, got 3 === wvistau64 (64 bit package) === package.c:4034: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4040: Test failed: Expected "E:\\FileName2", got "E:\FileName2" package.c:4046: Test failed: Expected "E:\\FileName3", got "E:\FileName3" package.c:4058: Test failed: Expected "E:\\FileName5", got "E:\FileName5" package.c:4064: Test failed: Expected "E:\\", got "E:\" package.c:4070: Test failed: Expected "E:\\", got "E:\" package.c:4086: Test failed: Expected "E:\\FileName8.dll", got "E:\FileName8.dll" package.c:4097: Test failed: Expected "E:\\FileName10.dll", got "E:\FileName10.dll" package.c:4556: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4648: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4659: Test failed: Expected "E:\\", got "E:\" package.c:4670: Test failed: Expected "E:\\", got "E:\" package.c:4720: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:4731: Test failed: Expected "E:\\FileName5.dll", got "E:\FileName5.dll" package.c:4746: Test failed: Expected "E:\\", got "E:\" package.c:4751: Test failed: Expected "", got "E:\" package.c:4767: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:4776: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5026: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5037: Test failed: Expected "E:\\", got "E:\" package.c:5043: Test failed: Expected "E:\\", got "E:\" package.c:5064: Test failed: Expected "E:\\FileName2.dll", got "E:\FileName2.dll" package.c:5075: Test failed: Expected "E:\\FileName4.dll", got "E:\FileName4.dll" package.c:5315: Test failed: Expected "E:\\FileName1", got "E:\FileName1" package.c:5321: Test failed: Expected "E:\\", got "E:\" package.c:5338: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5349: Test failed: Expected "E:\\one\two\three\FileName2", got "E:\one\two\three\FileName2" package.c:5357: Test failed: Expected "E:\\FileName3.dll", got "E:\FileName3.dll" package.c:5701: Test failed: Expected E:\\winetest-package.msi, got E:\winetest-package.msi package.c:6333: Test failed: Expected E:\\abelisaurus or empty string, got E:\abelisaurus package.c:6357: Test failed: Expected E:\\ or empty string, got E:\ package.c:6401: Test failed: Expected E:\\ or empty string, got E:\ package.c:6410: Test failed: Expected E:\\neosodon\ or empty string, got E:\neosodon\ package.c:6640: Test failed: Expected "E:\\", got "E:\" package.c:6641: Test failed: Expected 4, got 3 package.c:6648: Test failed: Expected "E:\\", got "E:\" package.c:6649: Test failed: Expected 4, got 3 package.c:6665: Test failed: Expected "E:\\", got "E:\" package.c:6666: Test failed: Expected 4, got 3 package.c:6672: Test failed: Expected "E:\\", got "E:\" package.c:6673: Test failed: Expected 4, got 3 package.c:6680: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6681: Test failed: Expected 14, got 13 package.c:6688: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6689: Test failed: Expected 19, got 18 package.c:6699: Test failed: Expected "E:\\", got "E:\" package.c:6700: Test failed: Expected 4, got 3 package.c:6707: Test failed: Expected "E:\\", got "E:\" package.c:6708: Test failed: Expected 4, got 3 package.c:6724: Test failed: Expected "E:\\", got "E:\" package.c:6725: Test failed: Expected 4, got 3 package.c:6731: Test failed: Expected "E:\\", got "E:\" package.c:6732: Test failed: Expected 4, got 3 package.c:6739: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6740: Test failed: Expected 14, got 13 package.c:6747: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6748: Test failed: Expected 19, got 18 package.c:6758: Test failed: Expected "E:\\", got "E:\" package.c:6759: Test failed: Expected 4, got 3 package.c:6766: Test failed: Expected "E:\\", got "E:\" package.c:6767: Test failed: Expected 4, got 3 package.c:6783: Test failed: Expected "E:\\", got "E:\" package.c:6784: Test failed: Expected 4, got 3 package.c:6790: Test failed: Expected "E:\\", got "E:\" package.c:6791: Test failed: Expected 4, got 3 package.c:6798: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6799: Test failed: Expected 14, got 13 package.c:6806: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6807: Test failed: Expected 19, got 18 package.c:6817: Test failed: Expected "E:\\", got "E:\" package.c:6818: Test failed: Expected 4, got 3 package.c:6825: Test failed: Expected "E:\\", got "E:\" package.c:6826: Test failed: Expected 4, got 3 package.c:6842: Test failed: Expected "E:\\", got "E:\" package.c:6843: Test failed: Expected 4, got 3 package.c:6849: Test failed: Expected "E:\\", got "E:\" package.c:6850: Test failed: Expected 4, got 3 package.c:6857: Test failed: Expected "E:\\subsource\", got "E:\subsource\" package.c:6858: Test failed: Expected 14, got 13 package.c:6865: Test failed: Expected "E:\\subsource\sub2\", got "E:\subsource\sub2\" package.c:6866: Test failed: Expected 19, got 18 package.c:6881: Test failed: Expected 4, got 3 package.c:6898: Test failed: Expected 4, got 3 package.c:6904: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6907: Test failed: Expected 4, got 3 package.c:6914: Test failed: Expected "E:\\", got "E:\" package.c:6915: Test failed: Expected 4, got 3 package.c:6926: Test failed: Expected "E:\\", got "E:\" package.c:6927: Test failed: Expected 4, got 3 package.c:7022: Test failed: Expected "E:\\", got "E:\" package.c:7023: Test failed: Expected 4, got 3 package.c:7030: Test failed: Expected "E:\\", got "E:\" package.c:7031: Test failed: Expected 4, got 3 package.c:7040: Test failed: Expected "E:\\", got "E:\" package.c:7041: Test failed: Expected 4, got 3 package.c:7049: Test failed: Expected "E:\\", got "E:\" package.c:7050: Test failed: Expected 4, got 3 package.c:7056: Test failed: Expected "E:\\", got "E:\" package.c:7057: Test failed: Expected 4, got 3 package.c:7064: Test failed: Expected "E:\\", got "E:\" package.c:7065: Test failed: Expected 4, got 3 package.c:7072: Test failed: Expected "E:\\", got "E:\" package.c:7073: Test failed: Expected 4, got 3 package.c:7083: Test failed: Expected "E:\\", got "E:\" package.c:7084: Test failed: Expected 4, got 3 package.c:7091: Test failed: Expected "E:\\", got "E:\" package.c:7092: Test failed: Expected 4, got 3 package.c:7101: Test failed: Expected "E:\\", got "E:\" package.c:7102: Test failed: Expected 4, got 3 package.c:7110: Test failed: Expected "E:\\", got "E:\" package.c:7111: Test failed: Expected 4, got 3 package.c:7117: Test failed: Expected "E:\\", got "E:\" package.c:7118: Test failed: Expected 4, got 3 package.c:7125: Test failed: Expected "E:\\", got "E:\" package.c:7126: Test failed: Expected 4, got 3 package.c:7133: Test failed: Expected "E:\\", got "E:\" package.c:7134: Test failed: Expected 4, got 3 package.c:7144: Test failed: Expected "E:\\", got "E:\" package.c:7145: Test failed: Expected 4, got 3 package.c:7152: Test failed: Expected "E:\\", got "E:\" package.c:7153: Test failed: Expected 4, got 3 package.c:7162: Test failed: Expected "E:\\", got "E:\" package.c:7163: Test failed: Expected 4, got 3 package.c:7171: Test failed: Expected "E:\\", got "E:\" package.c:7172: Test failed: Expected 4, got 3 package.c:7178: Test failed: Expected "E:\\", got "E:\" package.c:7179: Test failed: Expected 4, got 3 package.c:7186: Test failed: Expected "E:\\", got "E:\" package.c:7187: Test failed: Expected 4, got 3 package.c:7194: Test failed: Expected "E:\\", got "E:\" package.c:7195: Test failed: Expected 4, got 3 package.c:7205: Test failed: Expected "E:\\", got "E:\" package.c:7206: Test failed: Expected 4, got 3 package.c:7213: Test failed: Expected "E:\\", got "E:\" package.c:7214: Test failed: Expected 4, got 3 package.c:7223: Test failed: Expected "E:\\", got "E:\" package.c:7224: Test failed: Expected 4, got 3 package.c:7232: Test failed: Expected "E:\\", got "E:\" package.c:7233: Test failed: Expected 4, got 3 package.c:7239: Test failed: Expected "E:\\", got "E:\" package.c:7240: Test failed: Expected 4, got 3 package.c:7247: Test failed: Expected "E:\\", got "E:\" package.c:7248: Test failed: Expected 4, got 3 package.c:7255: Test failed: Expected "E:\\", got "E:\" package.c:7256: Test failed: Expected 4, got 3 package.c:7353: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7354: Test failed: Expected 9, got 8 package.c:7363: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7364: Test failed: Expected 9, got 8 package.c:7373: Test failed: Expected "E:\\long\", got "E:\long\" package.c:7374: Test failed: Expected 9, got 8 package.c:7385: Test failed: Expected "E:\\two\", got "E:\two\" package.c:7386: Test failed: Expected 8, got 7 package.c:7397: Test failed: Expected "E:\\four\", got "E:\four\" package.c:7398: Test failed: Expected 9, got 8 package.c:7409: Test failed: Expected "E:\\six\", got "E:\six\" package.c:7410: Test failed: Expected 8, got 7 package.c:7421: Test failed: Expected "E:\\eight\", got "E:\eight\" package.c:7422: Test failed: Expected 10, got 9 package.c:7433: Test failed: Expected "E:\\ten\", got "E:\ten\" package.c:7434: Test failed: Expected 8, got 7 package.c:7445: Test failed: Expected "E:\\twelve\", got "E:\twelve\" package.c:7446: Test failed: Expected 11, got 10 package.c:7497: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7498: Test failed: Expected 10, got 9 package.c:7507: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7508: Test failed: Expected 10, got 9 package.c:7517: Test failed: Expected "E:\\short\", got "E:\short\" package.c:7518: Test failed: Expected 10, got 9 package.c:7529: Test failed: Expected "E:\\one\", got "E:\one\" package.c:7530: Test failed: Expected 8, got 7 package.c:7541: Test failed: Expected "E:\\three\", got "E:\three\" package.c:7542: Test failed: Expected 10, got 9 package.c:7553: Test failed: Expected "E:\\five\", got "E:\five\" package.c:7554: Test failed: Expected 9, got 8 package.c:7565: Test failed: Expected "E:\\seven\", got "E:\seven\" package.c:7566: Test failed: Expected 10, got 9 package.c:7577: Test failed: Expected "E:\\nine\", got "E:\nine\" package.c:7578: Test failed: Expected 9, got 8 package.c:7589: Test failed: Expected "E:\\eleven\", got "E:\eleven\" package.c:7590: Test failed: Expected 11, got 10 package.c:7726: Test failed: Expected "E:\\", got "E:\" package.c:7727: Test failed: Expected 4, got 3 package.c:7738: Test failed: Expected "E:\\", got "E:\" package.c:7739: Test failed: Expected 4, got 3 package.c:7746: Test failed: Expected "E:\\", got "E:\" package.c:7747: Test failed: Expected 4, got 3 package.c:7844: Test failed: Expected "E:\\", got "E:\" package.c:7845: Test failed: Expected 4, got 3 package.c:7852: Test failed: Expected "E:\\", got "E:\" package.c:7853: Test failed: Expected 4, got 3 package.c:7860: Test failed: Expected "E:\\", got "E:\" package.c:7861: Test failed: Expected 4, got 3 package.c:7880: Test failed: Expected "E:\\", got "E:\" package.c:7881: Test failed: Expected 4, got 3 package.c:7888: Test failed: Expected "E:\\", got "E:\" package.c:7889: Test failed: Expected 4, got 3 package.c:7908: Test failed: Expected "E:\\", got "E:\" package.c:7909: Test failed: Expected 4, got 3 package.c:7916: Test failed: Expected "E:\\", got "E:\" package.c:7917: Test failed: Expected 4, got 3 package.c:7936: Test failed: Expected "E:\\", got "E:\" package.c:7937: Test failed: Expected 4, got 3 package.c:7944: Test failed: Expected "E:\\", got "E:\" package.c:7945: Test failed: Expected 4, got 3

1 0

Re: [website] German translation for release 1.7.22
by Rico Schüller July 24, 2014

July 24, 2014

On 16.07.2014 00:24, Julian Rüger wrote: > + <p>Der Quelltext ist ab sofort <a href="http://prdownloads.sourceforge.net/wine/wine-1.7.22.tar.bz2">verfügbar</a>. > +15 Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. There is a 15 too much...

2 1

Re: [PATCH] riched20: Implement ITextSelection::GetChar.
by Huw Davies July 23, 2014

July 23, 2014

On Tue, Jul 22, 2014 at 06:11:07PM +0800, Jactry Zeng wrote: > --- > dlls/riched20/richole.c | 13 +++++++++-- > dlls/riched20/tests/richole.c | 51 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 62 insertions(+), 2 deletions(-) > Before you start implementing the ITextSelection methods, have you thought about how the ITextRange returned by ITextDocument::GetStoryRanges would work? It seems to me it would be useful to have a text range object that could be used by both, rather than implementing two lots of ITextRange methods. Huw.

2 4

Re: winetest: Consistently use strict and warnings in the main CGI scripts.
by Alexandre Julliard July 22, 2014

July 22, 2014

Francois Gouget <fgouget(a)codeweavers.com> writes: > diff --git a/winetest/winetest.cgi b/winetest/winetest.cgi > index 8c72e02..61dba49 100755 > --- a/winetest/winetest.cgi > +++ b/winetest/winetest.cgi > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/perl -w Any reason for adding this? I thought you wanted to remove them... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msi/tests: Add non-existence value tests for mixed package. (try 2)
by Alexandre Julliard July 22, 2014

July 22, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This is part 1 of 2 of retrying `[7/8] msi/tests: Add more registry > tests.' (Patch 105588). > In this try, I divided the previous patch into two pieces because the > test was failed on Alexandre's 64-bit environment due to some uncertain > reason. With this series we can figure out failure points. If part 1 > (this patch) is failed, existing table is broken. Otherwise, additional > entries trigger failures. Of course now it's no longer failing, even with all the patches ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

imagehlp: Implement (parts of) BindImageEx
by Bernhard Reiter July 22, 2014

July 22, 2014

Okay, on to the implementation. Grateful for any reviews!

1 0

Re: quartz: Destroy BaseFilter after child class.
by Austin English July 21, 2014

July 21, 2014

On Mon, Jul 21, 2014 at 12:04 PM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > For the AsyncReader, this is a use after free on the critical section > again. > > The NullRenderer doesn't have any pins, so that change is mostly > cosmetical to align it with the other classes. > > The Parser change fixes a memory leak in addition to the use after free, > because AVISplitter_Release manually decrements the refCount and calls > Parser_Destroy instead of using Parser_Release -- so the filter's > members were never released in this code path. > > > You forgot the patch. Cheers, -Austin

1 0

imagehlp/tests: Add test for BindImageEx
by Bernhard Reiter July 21, 2014

July 21, 2014

Still struggling to get my first patch ready to be committed. I've removed all the typecasts I was able to, fixed variable names, and tried to initialize variables whereever required, as told by people on #winehackers. Having been told on that channel to only post to wine-patches@ after having the patch reviewed on this list, I'd be grateful for a (hopefully final) review. Bernhard

2 1

Re: [PATCH] vbscript: Implemented IsNumeric(try 2)
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8046 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)
by Huw Davies July 21, 2014

July 21, 2014

On Thu, Jul 03, 2014 at 04:45:42PM +0800, Jactry Zeng wrote: > index 6f2d579..2553b50 100644 > --- a/dlls/riched20/richole.c > +++ b/dlls/riched20/richole.c > @@ -783,11 +783,31 @@ static HRESULT WINAPI ITextSelection_fnInvoke( > static HRESULT WINAPI ITextSelection_fnGetText(ITextSelection *me, BSTR *pbstr) > { > ITextSelectionImpl *This = impl_from_ITextSelection(me); > + ME_Cursor *start = NULL, *end = NULL; > + int nChars; > + > if (!This->reOle) > return CO_E_RELEASED; > + TRACE("%p\n", pbstr); > + if (!pbstr) > + return E_INVALIDARG; > > - FIXME("not implemented\n"); > - return E_NOTIMPL; > + ME_GetSelection(This->reOle->editor, &start, &end); > + nChars = ME_GetCursorOfs(end) - ME_GetCursorOfs(start); > + if (!nChars) > + { > + *pbstr = NULL; > + return S_OK; > + } > + > + *pbstr = SysAllocStringLen(NULL, nChars); > + if (!*pbstr) > + return E_OUTOFMEMORY; > + /* FIXME: a '\r' should be appended at the end of a story */ > + ME_GetTextW(This->reOle->editor, *pbstr, nChars, start, nChars, 0); Actually, perhaps you could fix the FIXME. GetTextW already has the ability to add \r\n, so extending this to add just \r shouldn't be too difficult. Also, in the tests, you leak the BSTRs. Huw.

2 17

Re: vbscript: Use VariantChangeType in to_int.
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8043 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [3/3] msi/tests: Add CLSID registry tests for mixed package.
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8042 Your paranoid android. === w2000pro (32 bit install) === The test timed out === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out

1 0

Re: [2/3] msi/tests: Add non-existence value tests for mixed package. (try 2)
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8041 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Dmitry Timoshkov July 21, 2014

July 21, 2014

Shuai Meng <mengshuaicalendr(a)gmail.com> wrote: > + switch(V_VT(arg)) { > + case VT_UI1: > + case VT_I2: > + case VT_I4: > + case VT_I8: > + case VT_R4: > + case VT_R8: > + case VT_BOOL: > + case VT_EMPTY: > + case VT_CY: > + V_BOOL(res) = VARIANT_TRUE; > + break; This list is far from being complete. It seems that it should also contain at least VT_UI2, VT_UI4, VT_UI8, VT_I1, VT_INT, VT_UINT. VT_VECTOR, VT_ARRAY and VT_BYREF modifers probably also should be taken into account. -- Dmitry.

3 6

Re: [PATCH 5/5] ws2_32: Add an interactive test for interface change notifications (resend 2).
by Marvin July 18, 2014

July 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8031 Your paranoid android. === w7u (32 bit sock) === sock.c:618: Test failed: oob_server (b20): not at the OOB mark: 1

1 0

Re: [2/4] server: Support sending process and thread security descriptors for the "new_process" request in the protocol.
by Alexandre Julliard July 17, 2014

July 17, 2014

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > + int inherit_all; /* inherit all handles from parent */ > + unsigned int create_flags; /* creation flags */ > + int socket_fd; /* file descriptor for process socket */ > + obj_handle_t exe_file; /* file handle for main exe */ > + unsigned int process_access; /* access rights for process object */ > + unsigned int process_attr; /* attributes for process object */ > + unsigned int thread_access; /* access rights for thread object */ > + unsigned int thread_attr; /* attributes for thread object */ > + cpu_type_t cpu; /* CPU that the new process will use */ > + data_size_t process_sd_size; /* size of the process security descriptor */ > + data_size_t thread_sd_size; /* size of the thread security descriptor */ > + data_size_t info_size; /* size of startup info */ > + data_size_t env_size; /* size of the environment */ > + VARARG(process_sd,security_descriptor,process_sd_size); /* security descriptor to set on the process */ > + VARARG(thread_sd,security_descriptor,thread_sd_size); /* security descriptor to set on the thread */ > + VARARG(info,startup_info,info_size); /* startup information */ > + VARARG(env,unicode_str,env_size); /* environment for new process */ There's no reason to add the environment size. Also you need to validate all the sizes before using them. And please avoid reformatting lines that you are not changing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Marvin July 17, 2014

July 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8022 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [7/8] msi/tests: Add more registry tests.
by Alexandre Julliard July 15, 2014

July 15, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/msi/tests/install.c | 90 ++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 83 insertions(+), 7 deletions(-) It doesn't work here on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M msi.dll -p msi_test.exe.so install && touch install.ok install.c:5712: Test failed: value test1 should found, got 2 install.c:5720: Test failed: value test1 shouldn't found install.c:5751: Test failed: 32-bit component key not removed install.c:5754: Test failed: 64-bit component key not removed install.c:5773: Test failed: value test1 should found, got 2 install.c:5781: Test failed: value test1 shouldn't found install.c:5812: Test failed: 32-bit component key not removed install.c:5815: Test failed: 64-bit component key not removed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback. (try2)
by Alexandre Julliard July 15, 2014

July 15, 2014

Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> writes: > --- > dlls/wined3d/directx.c | 568 +++++++++++++++++++++++-------------------------- > 1 file changed, 269 insertions(+), 299 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d8.dll -p d3d8_test.exe.so device && touch device.ok err:d3d:resource_init Out of adapter memory wine: Unhandled page fault on read access to 0x69766574 at address 0x6862ab1c (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x69766574 in 32-bit code (0x6862ab1c). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6862ab1c ESP:0032fa50 EBP:0032fb08 EFLAGS:00010202( R- -- I - - - ) EAX:68667f05 EBX:68678e50 ECX:00000000 EDX:69766564 ESI:68667f05 EDI:0032fab8 Stack dump: 0x0032fa50: 68667f05 00000000 00000000 0032fab8 0x0032fa60: 00000000 00000000 00000280 000001e0 0x0032fa70: 00000000 00000000 00000000 00000000 0x0032fa80: 00000000 00000000 00060048 68667229 0x0032fa90: 00139670 68668b04 00139688 0032fab8 0x0032faa0: 00000000 00132818 0032fad8 00134650 Backtrace: =>0 0x6862ab1c test_swapchain+0x28c() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:261] in d3d8_test (0x0032fb08) 1 0x68644593 func_device+0x832() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:6461] in d3d8_test (0x0032fd48) 2 0x6862a22f main+0x37e(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:584] in d3d8_test (0x0032fe18) 3 0x68667e20 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0032fe58) 4 0x7b85f65c call_process_entry+0xb() in kernel32 (0x0032fe78) 5 0x7b8606a3 start_process+0x62(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1097] in kernel32 (0x0032feb8) 6 0x7bc7fac0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 7 0x7bc82a6d call_thread_func+0x7c(entry=0x7b860640, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2630] in ntdll (0x0032ffa8) 8 0x7bc7fa9e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 9 0x7bc53f0e start_process+0x1d(kernel_start=0x7b860640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2856] in ntdll (0x0032ffe8) 10 0x680316dd wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 11 0x6803179b wine_switch_to_stack+0x2a(func=0x7bc53ef0, arg=0x7b860640, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff81e868) 12 0x7bc59a09 LdrInitializeThunk+0x238(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2910] in ntdll (0xff81e8a8) 13 0x7b866ea3 __wine_kernel_init+0xa02() [/home/julliard/wine/wine/dlls/kernel32/process.c:1269] in kernel32 (0xff81f7a8) 14 0x7bc5a903 __wine_process_init+0x192() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3119] in ntdll (0xff81f838) 15 0x6802ede8 wine_init+0x2c7(argc=0x3, argv=0xff81fd74, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xff81f898) 16 0x7bf00d6c main+0x7b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff81fcd8) 17 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x6862ab1c test_swapchain+0x28c [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:261] in d3d8_test: call *0x10(%edx) 261 hr = IDirect3DSwapChain8_GetBackBuffer(swapchain3, 0, 0, &backbuffer); -- Alexandre Julliard julliard(a)winehq.org

4 10

Re: [PATCH 2/2] vbscript/tests: Added tests for the subtype of TypeName(try 5)
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8004 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Abs(try 9)
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8003 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] ddraw: Add validation to SetPriority / GetPriority.
by Henri Verbeet July 15, 2014

July 15, 2014

On 15 July 2014 16:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static HRESULT WINAPI ddraw_surface7_SetPriority(IDirectDrawSurface7 *iface, DWORD Priority) > +static HRESULT WINAPI ddraw_surface7_SetPriority(IDirectDrawSurface7 *iface, DWORD priority) > { > struct ddraw_surface *surface = impl_from_IDirectDrawSurface7(iface); > + DWORD managed = DDSCAPS2_TEXTUREMANAGE | DDSCAPS2_D3DTEXTUREMANAGE; > HRESULT hr; > > - TRACE("iface %p, priority %u.\n", iface, Priority); > + TRACE("iface %p, priority %u.\n", iface, priority); > > wined3d_mutex_lock(); > - hr = wined3d_surface_set_priority(surface->wined3d_surface, Priority); > + /* No need to check for offscreen plain surfaces or mipmap sublevels. SetPriority > + * calls on such surfaces segfault on Windows. */ > + if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed)) > + { > + WARN("Called on non-managed texture returning DDERR_INVALIDPARAMS.\n"); > + hr = DDERR_INVALIDPARAMS; > + } > + else > + hr = wined3d_surface_set_priority(surface->wined3d_surface, priority); > wined3d_mutex_unlock(); > > return hr; > } The existing code already had this of course, but note that wined3d_surface_set_priority() returns the previous priority.

1 0

Re: Re: [2/2] ddraw: add dsurface dimension tests, try 11
by Patrick Rudolph July 15, 2014

July 15, 2014

Hi Henri, thanks for reviewing. >> + /* 6: Test maximum surface height */ >> + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, >> DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS}, >> + /* 7: Test maximum surface width */ >> + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, >> DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS}, > It would perhaps also be useful to verify that e.g. a 1 by 0xffff > surface actually is allowed. I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon... Regards, Patrick

3 2

Re: [8/8] msi: Avoid Wow6432Node usage in registry table handling.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8000 Your paranoid android. === w2000pro (32 bit install) === The test timed out === wxppro (32 bit install) === The test timed out

1 0

Re: [7/8] msi/tests: Add more registry tests.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7999 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out === w8 (32 bit install) === The test timed out

1 0

Re: [PATCH 5/5] d3d8/tests: Get rid of struct nvertex.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7993 Your paranoid android. === w8 (32 bit device) === device.c:2398: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3040: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

2 1

Re: mshtml: Fixed typos in HTMLTable_QI.
by Alexandre Julliard July 15, 2014

July 15, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmltable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok wine: Unhandled page fault on read access to 0x00000004 at address 0x558bae66 (thread 0069), starting debugger... Unhandled exception: page fault on read access to 0x00000004 in 32-bit code (0x558bae66). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:558bae66 ESP:0032f7d0 EBP:0032f808 EFLAGS:00210202( R- -- I - - - ) EAX:028c05c4 EBX:55977e38 ECX:0bcebd00 EDX:00000000 ESI:0032f8cc EDI:686b0350 Stack dump: 0x0032f7d0: 028c05c4 686b0350 00000010 55923438 0x0032f7e0: 028c0558 0032f8cc 00000010 028c0558 0x0032f7f0: 028c0574 683e2b20 558bae0b 686c8a40 0x0032f800: 686b0350 0032f8cc 0032f828 5589c3b5 0x0032f810: 028c0558 686b0350 0032f8cc 686c8a40 0x0032f820: 686b0360 00000000 0032f848 5587658d Backtrace: =>0 0x558bae66 HTMLTable_QI+0x66(iface=0x28c0558, riid=0x686b0350, ppv=0x32f8cc) [/home/julliard/wine/wine/dlls/mshtml/htmltable.c:924] in mshtml (0x0032f808) 1 0x5589c3b5 HTMLDOMNode_QueryInterface+0x24(iface=0x28c0568, riid=0x686b0350, ppv=0x32f8cc) [/home/julliard/wine/wine/dlls/mshtml/htmlnode.c:474] in mshtml (0x0032f828) 2 0x5587658d HTMLElement_QueryInterface+0x2c(iface=<couldn't compute location>, riid=<couldn't compute location>, ppv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/../../include/mshtml.h:15891] in mshtml (0x0032f848) 3 0x55854e3c DispatchEx_QueryInterface+0x2b(iface=<couldn't compute location>, riid=<couldn't compute location>, ppv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/dispex.c:1316] in mshtml (0x0032f878) 4 0x6863f0e5 _test_ifaces+0x54(line=<is not available>, iface=<is not available>, iids=0x686c85e0) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:552] in mshtml_test (0x0032f8e8) 5 0x6863f604 _test_elem_type+0x43(line=0x198f, unk=0x28c0558, type=ET_TABLE) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:1034] in mshtml_test (0x0032f918) 6 0x68641178 _test_elem_collection+0x4f7(line=0x198f, unk=<is not available>, elem_types=0x686a76a0, exlen=0x1e) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:2153] in mshtml_test (0x0032fa98) 7 0x68650746 test_elems+0x95(doc=0x28b2b38) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:6543] in mshtml_test (0x0032fc88) 8 0x686470e7 run_domtest+0x2f6(str=<is not available>, test=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:8099] in mshtml_test (0x0032fd08) 9 0x686556e6 func_dom+0x115() [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:8126] in mshtml_test (0x0032fd48) 10 0x6862d96f main+0x37e(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:584] in mshtml_test (0x0032fe18) 11 0x686a0850 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fe58) 12 0x7b85f65c call_process_entry+0xb() in kernel32 (0x0032fe78) 13 0x7b8606a3 start_process+0x62(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1097] in kernel32 (0x0032feb8) 14 0x7bc7fac0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 15 0x7bc82a6d call_thread_func+0x7c(entry=0x7b860640, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2630] in ntdll (0x0032ffa8) 16 0x7bc7fa9e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 17 0x7bc53f0e start_process+0x1d(kernel_start=0x7b860640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2856] in ntdll (0x0032ffe8) 18 0x680316dd wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 19 0x6803179b wine_switch_to_stack+0x2a(func=0x7bc53ef0, arg=0x7b860640, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff808918) 20 0x7bc59a09 LdrInitializeThunk+0x238(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2910] in ntdll (0xff808958) 21 0x7b866ea3 __wine_kernel_init+0xa02() [/home/julliard/wine/wine/dlls/kernel32/process.c:1269] in kernel32 (0xff809858) 22 0x7bc5a903 __wine_process_init+0x192() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3119] in ntdll (0xff8098e8) 23 0x6802ede8 wine_init+0x2c7(argc=0x3, argv=0xff809e24, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xff809948) 24 0x7bf00d6c main+0x7b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff809d88) 25 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x558bae66 HTMLTable_QI+0x66 [/home/julliard/wine/wine/dlls/mshtml/htmltable.c:924] in mshtml: call *0x4(%edx) 924 IUnknown_AddRef((IUnknown*)*ppv); -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 1/2] vbscript: Implemented Abs(try 8)
by Piotr Caban July 15, 2014

July 15, 2014

On 07/15/14 04:55, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + HRESULT hres; > + VARIANT dst; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + hres = VarAbs(arg, &dst); > + if FAILED(hres) > + return hres; Please use parenthesis around if condition; > + if(!res) > + return DISP_E_BADVARTYPE; You have already written a test that shows this is incorrect (Call Abs(-4)). You also need to call VariantClear if dst is not used. > + return VariantCopy(res, &dst); Please change it to: *res = dst; return S_OK;

1 0

Re: [PATCH 2/5] ddraw/tests: Get rid of struct sVertexT.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7990 Your paranoid android. === w8 (32 bit visual) === visual.c:1659: Test failed: Got color 00000000, expected 000000ff or near visual.c:1665: Test failed: Got color 00000000, expected 000000ff or near visual.c:1671: Test failed: Got color 00000000, expected 00000080 or near visual.c:1677: Test failed: Got color 00000000, expected 00000080 or near visual.c:2635: Test failed: unexpected colortable on offscreen surface

1 0

Re: [PATCH] rpcrt4: fixed memory leak on error exit (Coverity)
by Dmitry Timoshkov July 15, 2014

July 15, 2014

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -941,6 +941,7 @@ static size_t rpcrt4_ip_tcp_get_top_of_tower(unsigned char *tower_data, > } > else > { > + freeaddrinfo(ai); > ERR("unexpected protocol family %d\n", ai->ai_family); > return 0; > } This will introduce use after free (by ERR() statement). -- Dmitry.

1 0

Re: [PATCH 1/5] ddraw/tests: Get rid of struct sVertex.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7989 Your paranoid android. === w8 (32 bit visual) === visual.c:2633: Test failed: unexpected colortable on offscreen surface

1 0

Re: [PATCH 2/2] vbscript/tests: Added tests for the subtype of TypeName(try 4) )
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7988 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Abs(try 8)
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7987 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [4/9] wined3d: replace vendor specific callbacks with generic code that uses vendor specific renderer string tables (try3)
by Henri Verbeet July 14, 2014

July 14, 2014

On 11 July 2014 20:44, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > +#ifndef NUMELMS > +#define NUMELMS(array) (sizeof(array)/sizeof((array)[0])) > +#endif If you really want this kind of thing it would be called ARRAY_SIZE, but I'd prefer just writing it out.

1 0

Re: [PATCH 3/4] vbscript: Implemented Abs(try 7)
by Piotr Caban July 14, 2014

July 14, 2014

Hi, On 07/11/14 05:49, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + if(!res) > + return S_OK; > + > + return VarAbs(arg,res); > } You're not handling res==NULL case correctly. E.g. Call Abs("string") should fail. Thanks, Piotr

2 4

Are there automated tests that verify that Wine's drawing operations produce the same visual output as in Windows?
by Alexander Almaleh July 14, 2014

July 14, 2014

While testing the Polygon() function for my bug report - https://bugs.winehq.org/show_bug.cgi?id=36891, I used a test program that performs a Polygon() operation on a memory device context, and then saves it to a bitmap - i.e. a *.bmp file. I then compared the bitmaps produced under Windows and Wine using a program I wrote in Qt, that just compares width/height, and then makes a pixel-by-pixel comparison (and the Polygon() function did indeed produce a slightly different bitmap). Since this process can be easily automated, I'm wondering if such a framework is already being used? If not, I could probably make a sample test program and image comparison tool, if anyone is interested. It would be fairly easily to spot all kinds of bugs in the drawing functions using such a testing system.

2 3

Re: [1/2] kernel32: Implement GEO_PARENT for GetGeoInfo()
by Marvin July 14, 2014

July 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid android. === wxppro (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === wvistau64 (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w2008s64 (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w7u (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === wvistau64 (64 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w2008s64 (64 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0

1 0

Link download/MS scheint es nicht mehr zu geben
by H. John July 13, 2014

July 13, 2014

Sehr geehrte Herren, leider ist mir folgendes passiert, was mache ich falsch, bzw. hat vielleicht MS wieder die Finger im Spiel!?! Hier der Ausdruck: sh winetricks mdac28 ------------------------------------------------------ You are using a 64-bit WINEPREFIX. If you encounter problems, please retest in a clean 32-bit WINEPREFIX before reporting a bug. ------------------------------------------------------ Executing w_do_call mdac28 Executing load_mdac28 Executing mkdir -p /home/gogo/.cache/winetricks/mdac28 Downloading http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… to /home/gogo/.cache/winetricks/mdac28 --2014-07-13 15:39:35-- http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… Auflösen des Hostnamen »download.microsoft.com (download.microsoft.com)«... fehlgeschlagen: Der Name oder der Dienst ist nicht bekannt. wget: kann die Host-Adresse »download.microsoft.com« nicht auflösen ------------------------------------------------------ Downloading http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… failed ------------------------------------------------------ Vielleicht könnte mir jemand auf die Sprünge Helfen. Vielen Dank Heiner

1 1

Re: [1/3] rsaenh/tests: Make the tests pass in Windows <= NT4
by Dmitry Timoshkov July 13, 2014

July 13, 2014

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + if (!result && GetLastError() == NTE_BAD_FLAGS) /* <= NT4 */ > + { > + ok(broken(1), "Failed to support CRYPT_USERDATA flag\n"); > + result = CryptHashData(hHash, pbData, sizeof(pbData), 0); > + } Wouldn't it be simpler to create a variable 'crypt_flags' that includes CRYPT_USERDATA (among others if needed), and clear CRYPT_USERDATA in the flags once the test detects a failure? That way the failure handling should be performed only once: crypt_flags = CRYPT_USERDATA | ...; result = CryptHashData(hHash, pbData, sizeof(pbData), crypt_flags); if (!result && GetLastError() == NTE_BAD_FLAGS) /* <= NT4 */ { ok(broken(1), "Failed to support CRYPT_USERDATA flag\n"); crypt_flags &= ~CRYPT_USERDATA; result = CryptHashData(hHash, pbData, sizeof(pbData), crypt_flags); } ok(result, "%08x\n", GetLastError()); -- Dmitry.

1 0

Re: comctl32/listview: preserve custom colors between subitems
by Nikolay Sivov July 13, 2014

July 13, 2014

Please add a test for that.

1 0

Re: dxdiag: Do not omit mandatory argument to WriteFile.
by Lauri Kenttä July 12, 2014

July 12, 2014

I'm sorry if I missed something, but at least MSDN clearly states that this is usually an optional argument. http://msdn.microsoft.com/en-us/library/windows/desktop/aa365747%28v=vs.85%… For example, "lpNumberOfBytesWritten [out, optional]" "Use NULL for this parameter if this is an asynchronous operation to avoid potentially erroneous results." "This parameter can be NULL only when the lpOverlapped parameter is not NULL." -- Lauri Kenttä Reply-To: wine-devel(a)winehq.org

2 2

Re: dxdiag: Do not omit mandatory argument to WriteFile.
by Lauri Kenttä July 12, 2014

July 12, 2014

I'm sorry if I missed something, but at least MSDN clearly states that this is usually an optional argument. http://msdn.microsoft.com/en-us/library/windows/desktop/aa365747%28v=vs.85%… For example, "lpNumberOfBytesWritten [out, optional]" "Use NULL for this parameter if this is an asynchronous operation to avoid potentially erroneous results." "This parameter can be NULL only when the lpOverlapped parameter is not NULL." -- Lauri Kenttä

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 5)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7943 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: cabinet: Implement GetDllVersion
by Bruno Jesus July 11, 2014

July 11, 2014

On Fri, Jul 4, 2014 at 3:29 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > A little bit useless, but we never know... Missed the attachment. Also the description does not seem very convicing (grin). Best regards, Bruno

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 4)
by Guillaume Charifi July 11, 2014

July 11, 2014

On Wed, Jun 18, 2014 at 6:21 AM, Guillaume Charifi wrote: > UP after more than 1 month without any feedback. As you can see from Marvin's email it looks like one of your tests is not passing in Windows 2000: https://testbot.winehq.org/JobDetails.pl?Key=7942 The error 0x80029c4a means "Error Loading Type Library/DLL". So that operation does not seem to be supported in W2K, you can use broken() to address that, look for examples in the same test file. Best regards, Bruno Thanks, I did not know the broken() macro, I am fixing the fix. Regards

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 4)
by Bruno Jesus July 11, 2014

July 11, 2014

On Wed, Jun 18, 2014 at 6:21 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > UP after more than 1 month without any feedback. As you can see from Marvin's email it looks like one of your tests is not passing in Windows 2000: https://testbot.winehq.org/JobDetails.pl?Key=7942 The error 0x80029c4a means "Error Loading Type Library/DLL". So that operation does not seem to be supported in W2K, you can use broken() to address that, look for examples in the same test file. Best regards, Bruno

1 0

Re: [PATCH] gdiplus: Set outer pointer to NULL when image loading functions fail. (try 4)
by Vincent Povirk July 11, 2014

July 11, 2014

Looks good to me, thanks.

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 4)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7942 Your paranoid android. === w2000pro (32 bit typelib) === typelib.c:5491: Test failed: got: 80029c4a

1 0

New WineHQ Server
by Jeremy White July 11, 2014

July 11, 2014

Hi Folks, As you probably saw, we have deployed a new server to replace our 5 year old work horse. This new server will hopefully hold us for the next 5 years. It's got good specs; 6 core Xeon, 32G of RAM (easily expandable to 128), raid 10 (also easily expandable). In a particularly nice development, this server was purchased by the Software Freedom Conservancy using funds provided by a donor. This donor doesn't want a particularly big fuss made out of it, and so prefers that I not announce a name publicly. I'd like to thread this needle somewhat carefully, as *I* think it's a remarkably generous gift. So I propose that, at our next convenient opportunity, we all lift a glass in appreciation of anonymous donors everywhere! Cheers, Jeremy

4 3

Re: [PATCH 4/4] vbscript/tests: Added tests for the subtype of TypeName(try 3)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7937 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscript: Implemented Abs(try 7)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7936 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0