July 2014 - Wine-Devel - list.winehq.org

Re: [website] German translation for release 1.7.22
by Rico Schüller July 24, 2014

July 24, 2014

On 16.07.2014 00:24, Julian Rüger wrote: > + <p>Der Quelltext ist ab sofort <a href="http://prdownloads.sourceforge.net/wine/wine-1.7.22.tar.bz2">verfügbar</a>. > +15 Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. There is a 15 too much...

2 1

Re: [PATCH] riched20: Implement ITextSelection::GetChar.
by Huw Davies July 23, 2014

July 23, 2014

On Tue, Jul 22, 2014 at 06:11:07PM +0800, Jactry Zeng wrote: > --- > dlls/riched20/richole.c | 13 +++++++++-- > dlls/riched20/tests/richole.c | 51 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 62 insertions(+), 2 deletions(-) > Before you start implementing the ITextSelection methods, have you thought about how the ITextRange returned by ITextDocument::GetStoryRanges would work? It seems to me it would be useful to have a text range object that could be used by both, rather than implementing two lots of ITextRange methods. Huw.

2 4

Re: winetest: Consistently use strict and warnings in the main CGI scripts.
by Alexandre Julliard July 22, 2014

July 22, 2014

Francois Gouget <fgouget(a)codeweavers.com> writes: > diff --git a/winetest/winetest.cgi b/winetest/winetest.cgi > index 8c72e02..61dba49 100755 > --- a/winetest/winetest.cgi > +++ b/winetest/winetest.cgi > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/perl -w Any reason for adding this? I thought you wanted to remove them... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msi/tests: Add non-existence value tests for mixed package. (try 2)
by Alexandre Julliard July 22, 2014

July 22, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This is part 1 of 2 of retrying `[7/8] msi/tests: Add more registry > tests.' (Patch 105588). > In this try, I divided the previous patch into two pieces because the > test was failed on Alexandre's 64-bit environment due to some uncertain > reason. With this series we can figure out failure points. If part 1 > (this patch) is failed, existing table is broken. Otherwise, additional > entries trigger failures. Of course now it's no longer failing, even with all the patches ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

imagehlp: Implement (parts of) BindImageEx
by Bernhard Reiter July 22, 2014

July 22, 2014

Okay, on to the implementation. Grateful for any reviews!

1 0

Re: quartz: Destroy BaseFilter after child class.
by Austin English July 21, 2014

July 21, 2014

On Mon, Jul 21, 2014 at 12:04 PM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > For the AsyncReader, this is a use after free on the critical section > again. > > The NullRenderer doesn't have any pins, so that change is mostly > cosmetical to align it with the other classes. > > The Parser change fixes a memory leak in addition to the use after free, > because AVISplitter_Release manually decrements the refCount and calls > Parser_Destroy instead of using Parser_Release -- so the filter's > members were never released in this code path. > > > You forgot the patch. Cheers, -Austin

1 0

imagehlp/tests: Add test for BindImageEx
by Bernhard Reiter July 21, 2014

July 21, 2014

Still struggling to get my first patch ready to be committed. I've removed all the typecasts I was able to, fixed variable names, and tried to initialize variables whereever required, as told by people on #winehackers. Having been told on that channel to only post to wine-patches@ after having the patch reviewed on this list, I'd be grateful for a (hopefully final) review. Bernhard

2 1

Re: [PATCH] vbscript: Implemented IsNumeric(try 2)
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8046 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)
by Huw Davies July 21, 2014

July 21, 2014

On Thu, Jul 03, 2014 at 04:45:42PM +0800, Jactry Zeng wrote: > index 6f2d579..2553b50 100644 > --- a/dlls/riched20/richole.c > +++ b/dlls/riched20/richole.c > @@ -783,11 +783,31 @@ static HRESULT WINAPI ITextSelection_fnInvoke( > static HRESULT WINAPI ITextSelection_fnGetText(ITextSelection *me, BSTR *pbstr) > { > ITextSelectionImpl *This = impl_from_ITextSelection(me); > + ME_Cursor *start = NULL, *end = NULL; > + int nChars; > + > if (!This->reOle) > return CO_E_RELEASED; > + TRACE("%p\n", pbstr); > + if (!pbstr) > + return E_INVALIDARG; > > - FIXME("not implemented\n"); > - return E_NOTIMPL; > + ME_GetSelection(This->reOle->editor, &start, &end); > + nChars = ME_GetCursorOfs(end) - ME_GetCursorOfs(start); > + if (!nChars) > + { > + *pbstr = NULL; > + return S_OK; > + } > + > + *pbstr = SysAllocStringLen(NULL, nChars); > + if (!*pbstr) > + return E_OUTOFMEMORY; > + /* FIXME: a '\r' should be appended at the end of a story */ > + ME_GetTextW(This->reOle->editor, *pbstr, nChars, start, nChars, 0); Actually, perhaps you could fix the FIXME. GetTextW already has the ability to add \r\n, so extending this to add just \r shouldn't be too difficult. Also, in the tests, you leak the BSTRs. Huw.

2 17

Re: vbscript: Use VariantChangeType in to_int.
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8043 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [3/3] msi/tests: Add CLSID registry tests for mixed package.
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8042 Your paranoid android. === w2000pro (32 bit install) === The test timed out === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out

1 0

Re: [2/3] msi/tests: Add non-existence value tests for mixed package. (try 2)
by Marvin July 21, 2014

July 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8041 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Dmitry Timoshkov July 21, 2014

July 21, 2014

Shuai Meng <mengshuaicalendr(a)gmail.com> wrote: > + switch(V_VT(arg)) { > + case VT_UI1: > + case VT_I2: > + case VT_I4: > + case VT_I8: > + case VT_R4: > + case VT_R8: > + case VT_BOOL: > + case VT_EMPTY: > + case VT_CY: > + V_BOOL(res) = VARIANT_TRUE; > + break; This list is far from being complete. It seems that it should also contain at least VT_UI2, VT_UI4, VT_UI8, VT_I1, VT_INT, VT_UINT. VT_VECTOR, VT_ARRAY and VT_BYREF modifers probably also should be taken into account. -- Dmitry.

3 6

Re: [PATCH 5/5] ws2_32: Add an interactive test for interface change notifications (resend 2).
by Marvin July 18, 2014

July 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8031 Your paranoid android. === w7u (32 bit sock) === sock.c:618: Test failed: oob_server (b20): not at the OOB mark: 1

1 0

Re: [2/4] server: Support sending process and thread security descriptors for the "new_process" request in the protocol.
by Alexandre Julliard July 17, 2014

July 17, 2014

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > + int inherit_all; /* inherit all handles from parent */ > + unsigned int create_flags; /* creation flags */ > + int socket_fd; /* file descriptor for process socket */ > + obj_handle_t exe_file; /* file handle for main exe */ > + unsigned int process_access; /* access rights for process object */ > + unsigned int process_attr; /* attributes for process object */ > + unsigned int thread_access; /* access rights for thread object */ > + unsigned int thread_attr; /* attributes for thread object */ > + cpu_type_t cpu; /* CPU that the new process will use */ > + data_size_t process_sd_size; /* size of the process security descriptor */ > + data_size_t thread_sd_size; /* size of the thread security descriptor */ > + data_size_t info_size; /* size of startup info */ > + data_size_t env_size; /* size of the environment */ > + VARARG(process_sd,security_descriptor,process_sd_size); /* security descriptor to set on the process */ > + VARARG(thread_sd,security_descriptor,thread_sd_size); /* security descriptor to set on the thread */ > + VARARG(info,startup_info,info_size); /* startup information */ > + VARARG(env,unicode_str,env_size); /* environment for new process */ There's no reason to add the environment size. Also you need to validate all the sizes before using them. And please avoid reformatting lines that you are not changing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Marvin July 17, 2014

July 17, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8022 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [7/8] msi/tests: Add more registry tests.
by Alexandre Julliard July 15, 2014

July 15, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/msi/tests/install.c | 90 ++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 83 insertions(+), 7 deletions(-) It doesn't work here on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M msi.dll -p msi_test.exe.so install && touch install.ok install.c:5712: Test failed: value test1 should found, got 2 install.c:5720: Test failed: value test1 shouldn't found install.c:5751: Test failed: 32-bit component key not removed install.c:5754: Test failed: 64-bit component key not removed install.c:5773: Test failed: value test1 should found, got 2 install.c:5781: Test failed: value test1 shouldn't found install.c:5812: Test failed: 32-bit component key not removed install.c:5815: Test failed: 64-bit component key not removed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback. (try2)
by Alexandre Julliard July 15, 2014

July 15, 2014

Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> writes: > --- > dlls/wined3d/directx.c | 568 +++++++++++++++++++++++-------------------------- > 1 file changed, 269 insertions(+), 299 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d8.dll -p d3d8_test.exe.so device && touch device.ok err:d3d:resource_init Out of adapter memory wine: Unhandled page fault on read access to 0x69766574 at address 0x6862ab1c (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x69766574 in 32-bit code (0x6862ab1c). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6862ab1c ESP:0032fa50 EBP:0032fb08 EFLAGS:00010202( R- -- I - - - ) EAX:68667f05 EBX:68678e50 ECX:00000000 EDX:69766564 ESI:68667f05 EDI:0032fab8 Stack dump: 0x0032fa50: 68667f05 00000000 00000000 0032fab8 0x0032fa60: 00000000 00000000 00000280 000001e0 0x0032fa70: 00000000 00000000 00000000 00000000 0x0032fa80: 00000000 00000000 00060048 68667229 0x0032fa90: 00139670 68668b04 00139688 0032fab8 0x0032faa0: 00000000 00132818 0032fad8 00134650 Backtrace: =>0 0x6862ab1c test_swapchain+0x28c() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:261] in d3d8_test (0x0032fb08) 1 0x68644593 func_device+0x832() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:6461] in d3d8_test (0x0032fd48) 2 0x6862a22f main+0x37e(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:584] in d3d8_test (0x0032fe18) 3 0x68667e20 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0032fe58) 4 0x7b85f65c call_process_entry+0xb() in kernel32 (0x0032fe78) 5 0x7b8606a3 start_process+0x62(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1097] in kernel32 (0x0032feb8) 6 0x7bc7fac0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 7 0x7bc82a6d call_thread_func+0x7c(entry=0x7b860640, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2630] in ntdll (0x0032ffa8) 8 0x7bc7fa9e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 9 0x7bc53f0e start_process+0x1d(kernel_start=0x7b860640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2856] in ntdll (0x0032ffe8) 10 0x680316dd wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 11 0x6803179b wine_switch_to_stack+0x2a(func=0x7bc53ef0, arg=0x7b860640, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff81e868) 12 0x7bc59a09 LdrInitializeThunk+0x238(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2910] in ntdll (0xff81e8a8) 13 0x7b866ea3 __wine_kernel_init+0xa02() [/home/julliard/wine/wine/dlls/kernel32/process.c:1269] in kernel32 (0xff81f7a8) 14 0x7bc5a903 __wine_process_init+0x192() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3119] in ntdll (0xff81f838) 15 0x6802ede8 wine_init+0x2c7(argc=0x3, argv=0xff81fd74, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xff81f898) 16 0x7bf00d6c main+0x7b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff81fcd8) 17 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x6862ab1c test_swapchain+0x28c [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:261] in d3d8_test: call *0x10(%edx) 261 hr = IDirect3DSwapChain8_GetBackBuffer(swapchain3, 0, 0, &backbuffer); -- Alexandre Julliard julliard(a)winehq.org

4 10

Re: [PATCH 2/2] vbscript/tests: Added tests for the subtype of TypeName(try 5)
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8004 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Abs(try 9)
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8003 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] ddraw: Add validation to SetPriority / GetPriority.
by Henri Verbeet July 15, 2014

July 15, 2014

On 15 July 2014 16:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static HRESULT WINAPI ddraw_surface7_SetPriority(IDirectDrawSurface7 *iface, DWORD Priority) > +static HRESULT WINAPI ddraw_surface7_SetPriority(IDirectDrawSurface7 *iface, DWORD priority) > { > struct ddraw_surface *surface = impl_from_IDirectDrawSurface7(iface); > + DWORD managed = DDSCAPS2_TEXTUREMANAGE | DDSCAPS2_D3DTEXTUREMANAGE; > HRESULT hr; > > - TRACE("iface %p, priority %u.\n", iface, Priority); > + TRACE("iface %p, priority %u.\n", iface, priority); > > wined3d_mutex_lock(); > - hr = wined3d_surface_set_priority(surface->wined3d_surface, Priority); > + /* No need to check for offscreen plain surfaces or mipmap sublevels. SetPriority > + * calls on such surfaces segfault on Windows. */ > + if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed)) > + { > + WARN("Called on non-managed texture returning DDERR_INVALIDPARAMS.\n"); > + hr = DDERR_INVALIDPARAMS; > + } > + else > + hr = wined3d_surface_set_priority(surface->wined3d_surface, priority); > wined3d_mutex_unlock(); > > return hr; > } The existing code already had this of course, but note that wined3d_surface_set_priority() returns the previous priority.

1 0

Re: Re: [2/2] ddraw: add dsurface dimension tests, try 11
by Patrick Rudolph July 15, 2014

July 15, 2014

Hi Henri, thanks for reviewing. >> + /* 6: Test maximum surface height */ >> + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, >> DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS}, >> + /* 7: Test maximum surface width */ >> + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, >> DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS}, > It would perhaps also be useful to verify that e.g. a 1 by 0xffff > surface actually is allowed. I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon... Regards, Patrick

3 2

Re: [8/8] msi: Avoid Wow6432Node usage in registry table handling.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8000 Your paranoid android. === w2000pro (32 bit install) === The test timed out === wxppro (32 bit install) === The test timed out

1 0

Re: [7/8] msi/tests: Add more registry tests.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7999 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out === w8 (32 bit install) === The test timed out

1 0

Re: [PATCH 5/5] d3d8/tests: Get rid of struct nvertex.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7993 Your paranoid android. === w8 (32 bit device) === device.c:2398: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3040: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

2 1

Re: mshtml: Fixed typos in HTMLTable_QI.
by Alexandre Julliard July 15, 2014

July 15, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmltable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok wine: Unhandled page fault on read access to 0x00000004 at address 0x558bae66 (thread 0069), starting debugger... Unhandled exception: page fault on read access to 0x00000004 in 32-bit code (0x558bae66). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:558bae66 ESP:0032f7d0 EBP:0032f808 EFLAGS:00210202( R- -- I - - - ) EAX:028c05c4 EBX:55977e38 ECX:0bcebd00 EDX:00000000 ESI:0032f8cc EDI:686b0350 Stack dump: 0x0032f7d0: 028c05c4 686b0350 00000010 55923438 0x0032f7e0: 028c0558 0032f8cc 00000010 028c0558 0x0032f7f0: 028c0574 683e2b20 558bae0b 686c8a40 0x0032f800: 686b0350 0032f8cc 0032f828 5589c3b5 0x0032f810: 028c0558 686b0350 0032f8cc 686c8a40 0x0032f820: 686b0360 00000000 0032f848 5587658d Backtrace: =>0 0x558bae66 HTMLTable_QI+0x66(iface=0x28c0558, riid=0x686b0350, ppv=0x32f8cc) [/home/julliard/wine/wine/dlls/mshtml/htmltable.c:924] in mshtml (0x0032f808) 1 0x5589c3b5 HTMLDOMNode_QueryInterface+0x24(iface=0x28c0568, riid=0x686b0350, ppv=0x32f8cc) [/home/julliard/wine/wine/dlls/mshtml/htmlnode.c:474] in mshtml (0x0032f828) 2 0x5587658d HTMLElement_QueryInterface+0x2c(iface=<couldn't compute location>, riid=<couldn't compute location>, ppv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/../../include/mshtml.h:15891] in mshtml (0x0032f848) 3 0x55854e3c DispatchEx_QueryInterface+0x2b(iface=<couldn't compute location>, riid=<couldn't compute location>, ppv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/dispex.c:1316] in mshtml (0x0032f878) 4 0x6863f0e5 _test_ifaces+0x54(line=<is not available>, iface=<is not available>, iids=0x686c85e0) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:552] in mshtml_test (0x0032f8e8) 5 0x6863f604 _test_elem_type+0x43(line=0x198f, unk=0x28c0558, type=ET_TABLE) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:1034] in mshtml_test (0x0032f918) 6 0x68641178 _test_elem_collection+0x4f7(line=0x198f, unk=<is not available>, elem_types=0x686a76a0, exlen=0x1e) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:2153] in mshtml_test (0x0032fa98) 7 0x68650746 test_elems+0x95(doc=0x28b2b38) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:6543] in mshtml_test (0x0032fc88) 8 0x686470e7 run_domtest+0x2f6(str=<is not available>, test=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:8099] in mshtml_test (0x0032fd08) 9 0x686556e6 func_dom+0x115() [/home/julliard/wine/wine/dlls/mshtml/tests/dom.c:8126] in mshtml_test (0x0032fd48) 10 0x6862d96f main+0x37e(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:584] in mshtml_test (0x0032fe18) 11 0x686a0850 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fe58) 12 0x7b85f65c call_process_entry+0xb() in kernel32 (0x0032fe78) 13 0x7b8606a3 start_process+0x62(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1097] in kernel32 (0x0032feb8) 14 0x7bc7fac0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 15 0x7bc82a6d call_thread_func+0x7c(entry=0x7b860640, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2630] in ntdll (0x0032ffa8) 16 0x7bc7fa9e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 17 0x7bc53f0e start_process+0x1d(kernel_start=0x7b860640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2856] in ntdll (0x0032ffe8) 18 0x680316dd wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 19 0x6803179b wine_switch_to_stack+0x2a(func=0x7bc53ef0, arg=0x7b860640, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff808918) 20 0x7bc59a09 LdrInitializeThunk+0x238(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2910] in ntdll (0xff808958) 21 0x7b866ea3 __wine_kernel_init+0xa02() [/home/julliard/wine/wine/dlls/kernel32/process.c:1269] in kernel32 (0xff809858) 22 0x7bc5a903 __wine_process_init+0x192() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3119] in ntdll (0xff8098e8) 23 0x6802ede8 wine_init+0x2c7(argc=0x3, argv=0xff809e24, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xff809948) 24 0x7bf00d6c main+0x7b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff809d88) 25 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x558bae66 HTMLTable_QI+0x66 [/home/julliard/wine/wine/dlls/mshtml/htmltable.c:924] in mshtml: call *0x4(%edx) 924 IUnknown_AddRef((IUnknown*)*ppv); -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 1/2] vbscript: Implemented Abs(try 8)
by Piotr Caban July 15, 2014

July 15, 2014

On 07/15/14 04:55, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + HRESULT hres; > + VARIANT dst; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + hres = VarAbs(arg, &dst); > + if FAILED(hres) > + return hres; Please use parenthesis around if condition; > + if(!res) > + return DISP_E_BADVARTYPE; You have already written a test that shows this is incorrect (Call Abs(-4)). You also need to call VariantClear if dst is not used. > + return VariantCopy(res, &dst); Please change it to: *res = dst; return S_OK;

1 0

Re: [PATCH 2/5] ddraw/tests: Get rid of struct sVertexT.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7990 Your paranoid android. === w8 (32 bit visual) === visual.c:1659: Test failed: Got color 00000000, expected 000000ff or near visual.c:1665: Test failed: Got color 00000000, expected 000000ff or near visual.c:1671: Test failed: Got color 00000000, expected 00000080 or near visual.c:1677: Test failed: Got color 00000000, expected 00000080 or near visual.c:2635: Test failed: unexpected colortable on offscreen surface

1 0

Re: [PATCH] rpcrt4: fixed memory leak on error exit (Coverity)
by Dmitry Timoshkov July 15, 2014

July 15, 2014

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -941,6 +941,7 @@ static size_t rpcrt4_ip_tcp_get_top_of_tower(unsigned char *tower_data, > } > else > { > + freeaddrinfo(ai); > ERR("unexpected protocol family %d\n", ai->ai_family); > return 0; > } This will introduce use after free (by ERR() statement). -- Dmitry.

1 0

Re: [PATCH 1/5] ddraw/tests: Get rid of struct sVertex.
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7989 Your paranoid android. === w8 (32 bit visual) === visual.c:2633: Test failed: unexpected colortable on offscreen surface

1 0

Re: [PATCH 2/2] vbscript/tests: Added tests for the subtype of TypeName(try 4) )
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7988 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Abs(try 8)
by Marvin July 15, 2014

July 15, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7987 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [4/9] wined3d: replace vendor specific callbacks with generic code that uses vendor specific renderer string tables (try3)
by Henri Verbeet July 14, 2014

July 14, 2014

On 11 July 2014 20:44, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > +#ifndef NUMELMS > +#define NUMELMS(array) (sizeof(array)/sizeof((array)[0])) > +#endif If you really want this kind of thing it would be called ARRAY_SIZE, but I'd prefer just writing it out.

1 0

Re: [PATCH 3/4] vbscript: Implemented Abs(try 7)
by Piotr Caban July 14, 2014

July 14, 2014

Hi, On 07/11/14 05:49, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + if(!res) > + return S_OK; > + > + return VarAbs(arg,res); > } You're not handling res==NULL case correctly. E.g. Call Abs("string") should fail. Thanks, Piotr

2 4

Are there automated tests that verify that Wine's drawing operations produce the same visual output as in Windows?
by Alexander Almaleh July 14, 2014

July 14, 2014

While testing the Polygon() function for my bug report - https://bugs.winehq.org/show_bug.cgi?id=36891, I used a test program that performs a Polygon() operation on a memory device context, and then saves it to a bitmap - i.e. a *.bmp file. I then compared the bitmaps produced under Windows and Wine using a program I wrote in Qt, that just compares width/height, and then makes a pixel-by-pixel comparison (and the Polygon() function did indeed produce a slightly different bitmap). Since this process can be easily automated, I'm wondering if such a framework is already being used? If not, I could probably make a sample test program and image comparison tool, if anyone is interested. It would be fairly easily to spot all kinds of bugs in the drawing functions using such a testing system.

2 3

Re: [1/2] kernel32: Implement GEO_PARENT for GetGeoInfo()
by Marvin July 14, 2014

July 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid android. === wxppro (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === wvistau64 (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w2008s64 (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w7u (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === wvistau64 (64 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w2008s64 (64 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0

1 0

Link download/MS scheint es nicht mehr zu geben
by H. John July 13, 2014

July 13, 2014

Sehr geehrte Herren, leider ist mir folgendes passiert, was mache ich falsch, bzw. hat vielleicht MS wieder die Finger im Spiel!?! Hier der Ausdruck: sh winetricks mdac28 ------------------------------------------------------ You are using a 64-bit WINEPREFIX. If you encounter problems, please retest in a clean 32-bit WINEPREFIX before reporting a bug. ------------------------------------------------------ Executing w_do_call mdac28 Executing load_mdac28 Executing mkdir -p /home/gogo/.cache/winetricks/mdac28 Downloading http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… to /home/gogo/.cache/winetricks/mdac28 --2014-07-13 15:39:35-- http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… Auflösen des Hostnamen »download.microsoft.com (download.microsoft.com)«... fehlgeschlagen: Der Name oder der Dienst ist nicht bekannt. wget: kann die Host-Adresse »download.microsoft.com« nicht auflösen ------------------------------------------------------ Downloading http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… failed ------------------------------------------------------ Vielleicht könnte mir jemand auf die Sprünge Helfen. Vielen Dank Heiner

1 1

Re: [1/3] rsaenh/tests: Make the tests pass in Windows <= NT4
by Dmitry Timoshkov July 13, 2014

July 13, 2014

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + if (!result && GetLastError() == NTE_BAD_FLAGS) /* <= NT4 */ > + { > + ok(broken(1), "Failed to support CRYPT_USERDATA flag\n"); > + result = CryptHashData(hHash, pbData, sizeof(pbData), 0); > + } Wouldn't it be simpler to create a variable 'crypt_flags' that includes CRYPT_USERDATA (among others if needed), and clear CRYPT_USERDATA in the flags once the test detects a failure? That way the failure handling should be performed only once: crypt_flags = CRYPT_USERDATA | ...; result = CryptHashData(hHash, pbData, sizeof(pbData), crypt_flags); if (!result && GetLastError() == NTE_BAD_FLAGS) /* <= NT4 */ { ok(broken(1), "Failed to support CRYPT_USERDATA flag\n"); crypt_flags &= ~CRYPT_USERDATA; result = CryptHashData(hHash, pbData, sizeof(pbData), crypt_flags); } ok(result, "%08x\n", GetLastError()); -- Dmitry.

1 0

Re: comctl32/listview: preserve custom colors between subitems
by Nikolay Sivov July 13, 2014

July 13, 2014

Please add a test for that.

1 0

Re: dxdiag: Do not omit mandatory argument to WriteFile.
by Lauri Kenttä July 12, 2014

July 12, 2014

I'm sorry if I missed something, but at least MSDN clearly states that this is usually an optional argument. http://msdn.microsoft.com/en-us/library/windows/desktop/aa365747%28v=vs.85%… For example, "lpNumberOfBytesWritten [out, optional]" "Use NULL for this parameter if this is an asynchronous operation to avoid potentially erroneous results." "This parameter can be NULL only when the lpOverlapped parameter is not NULL." -- Lauri Kenttä Reply-To: wine-devel(a)winehq.org

2 2

Re: dxdiag: Do not omit mandatory argument to WriteFile.
by Lauri Kenttä July 12, 2014

July 12, 2014

I'm sorry if I missed something, but at least MSDN clearly states that this is usually an optional argument. http://msdn.microsoft.com/en-us/library/windows/desktop/aa365747%28v=vs.85%… For example, "lpNumberOfBytesWritten [out, optional]" "Use NULL for this parameter if this is an asynchronous operation to avoid potentially erroneous results." "This parameter can be NULL only when the lpOverlapped parameter is not NULL." -- Lauri Kenttä

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 5)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7943 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: cabinet: Implement GetDllVersion
by Bruno Jesus July 11, 2014

July 11, 2014

On Fri, Jul 4, 2014 at 3:29 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > A little bit useless, but we never know... Missed the attachment. Also the description does not seem very convicing (grin). Best regards, Bruno

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 4)
by Guillaume Charifi July 11, 2014

July 11, 2014

On Wed, Jun 18, 2014 at 6:21 AM, Guillaume Charifi wrote: > UP after more than 1 month without any feedback. As you can see from Marvin's email it looks like one of your tests is not passing in Windows 2000: https://testbot.winehq.org/JobDetails.pl?Key=7942 The error 0x80029c4a means "Error Loading Type Library/DLL". So that operation does not seem to be supported in W2K, you can use broken() to address that, look for examples in the same test file. Best regards, Bruno Thanks, I did not know the broken() macro, I am fixing the fix. Regards

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 4)
by Bruno Jesus July 11, 2014

July 11, 2014

On Wed, Jun 18, 2014 at 6:21 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > UP after more than 1 month without any feedback. As you can see from Marvin's email it looks like one of your tests is not passing in Windows 2000: https://testbot.winehq.org/JobDetails.pl?Key=7942 The error 0x80029c4a means "Error Loading Type Library/DLL". So that operation does not seem to be supported in W2K, you can use broken() to address that, look for examples in the same test file. Best regards, Bruno

1 0

Re: [PATCH] gdiplus: Set outer pointer to NULL when image loading functions fail. (try 4)
by Vincent Povirk July 11, 2014

July 11, 2014

Looks good to me, thanks.

1 0

Re: oleaut32: Fix TLB dependencies lookup (retry 4)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7942 Your paranoid android. === w2000pro (32 bit typelib) === typelib.c:5491: Test failed: got: 80029c4a

1 0

New WineHQ Server
by Jeremy White July 11, 2014

July 11, 2014

Hi Folks, As you probably saw, we have deployed a new server to replace our 5 year old work horse. This new server will hopefully hold us for the next 5 years. It's got good specs; 6 core Xeon, 32G of RAM (easily expandable to 128), raid 10 (also easily expandable). In a particularly nice development, this server was purchased by the Software Freedom Conservancy using funds provided by a donor. This donor doesn't want a particularly big fuss made out of it, and so prefers that I not announce a name publicly. I'd like to thread this needle somewhat carefully, as *I* think it's a remarkably generous gift. So I propose that, at our next convenient opportunity, we all lift a glass in appreciation of anonymous donors everywhere! Cheers, Jeremy

4 3

Re: [PATCH 4/4] vbscript/tests: Added tests for the subtype of TypeName(try 3)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7937 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscript: Implemented Abs(try 7)
by Marvin July 11, 2014

July 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7936 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0