July 2014 - Wine-Devel - list.winehq.org

Re: wininet: Call WSAStartup/WSACleanup to mime the Windows behavior
by Thomas Faber July 6, 2014

July 6, 2014

Hey Bruno, > +static void init_ws2_32(void) > +{ > + static int once; > + if (once++) return; > + hws2_32 = GetModuleHandleA("ws2_32.dll"); > + pWSAStartup = (void *)GetProcAddress(hws2_32, "WSAStartup"); > + pWSACleanup = (void *)GetProcAddress(hws2_32, "WSACleanup"); > +} > + > +static void free_ws2_32(void) > +{ > + FreeLibrary(hws2_32); > +} GetModuleHandle doesn't increase the reference count so you probably shouldn't call FreeLibrary. > + /* initialize winsock DLL here as expected by some broken applications */ > + if (!winsock_init++) > + { > + char buffer[128]; > + init_ws2_32(); > + pWSAStartup(MAKEWORD( 1, 1 ), buffer); > + } I believe Windows initializes with version 2. At least that's what my old test says (line 105): https://code.reactos.org/browse/reactos/trunk/rostests/apitests/wininet/Int… (free to use under LGPL... I can make it explicit in the source file, or help with getting it in Winetest format if desired) By the way, the same applies to winhttp in case you're interested: https://code.reactos.org/browse/reactos/trunk/rostests/apitests/winhttp/Win… Thanks! -Thomas

6 7

Re: [PATCH 3/3] winecoreaudio.drv: Use AUHAL API instead of AudioQueue
by Francois Gouget July 5, 2014

July 5, 2014

On Fri, 27 Jun 2014, Andrew Eikum wrote: [...] > + if(This->wrap_bufsize_frames < *nframes){ > + free(This->wrap_buffer); > + This->wrap_buffer = malloc(data->mBuffers[0].mDataByteSize); > + This->wrap_bufsize_frames = *nframes; Does the AUHAL API require that we use malloc() / free() here (and in the other locations dealing with wrap_buffer) or could this be switched to HeapAlloc() / HeapFree()? If we're free to use the latter doing so would be more consistent with the rest of Wine. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Sufficently advanced incompetence is indistinguishable from malice.

2 1

Re: [PATCH 4/4] vbscript/tests: Added tests for the subtype of TypeName(try 2)
by Marvin July 4, 2014

July 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7857 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscript: Implemented Abs(try 6)
by Marvin July 4, 2014

July 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7856 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] vbscript: Implemented Sgn(try 6)
by Marvin July 4, 2014

July 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7855 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] vbscript: Implemented VarType(try 6)
by Marvin July 4, 2014

July 4, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7854 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: oleaut32: Implement ICreateTypeLib2_fnSet*CustData ICreateTypeLib2_fnSet*HelpStringContext
by Andrew Eikum July 4, 2014

July 4, 2014

This patch looks mostly good, but see below for a couple fixes. Also, it should be split. You could split it into one patch for the CustData functions and one for HelpStringContext. You should also write some tests for them. They'd be best in test_CreateTypeLib(), which is a really big function. Basically, it sets and retrieves a bunch of typelib stuff, then saves and re-loads the typelib from disk, and then retrieves everything again to verify it saved correctly. The HelpStringContext test should be very easy to write, but the CustData functions are a little bit more complicated. Be sure to run the tests on the testbot before submitting. There are often differences between Windows versions that you'll need to allow for. Just out of curiosity, do you have an application that actually uses these functions, or are you implementing them simply for completeness? On Fri, Jul 04, 2014 at 01:03:44AM +0200, Guillaume Charifi wrote: > static HRESULT WINAPI ICreateTypeInfo2_fnSetVarCustData(ICreateTypeInfo2 *iface, > UINT index, REFGUID guid, VARIANT *varVal) > { > + TLBGuid *tlbguid; > + > ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface); > - FIXME("%p %u %s %p - stub\n", This, index, debugstr_guid(guid), varVal); > - return E_NOTIMPL; > + TLBVarDesc *pVDesc = &This->vardescs[index]; > + > + TRACE("%p %u %s %p\n", This, index, debugstr_guid(guid), varVal); > + > + if (!guid || !varVal) > + return E_INVALIDARG; > + > + if(index >= This->cFuncs) > + return E_INVALIDARG; > + This should be cVars. > static HRESULT WINAPI ICreateTypeInfo2_fnSetImplTypeCustData(ICreateTypeInfo2 *iface, > UINT index, REFGUID guid, VARIANT *varVal) > { > + TLBGuid *tlbguid; > + > ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface); > - FIXME("%p %u %s %p - stub\n", This, index, debugstr_guid(guid), varVal); > - return E_NOTIMPL; > + TLBImplType *pRDesc = &This->impltypes[index]; > + > + TRACE("%p %u %s %p\n", This, index, debugstr_guid(guid), varVal); > + > + if (!guid || !varVal) > + return E_INVALIDARG; > + > + if(index >= This->cFuncs) > + return E_INVALIDARG; > + And this should be cImplTypes. Andrew

1 0

Re: regsvr32: Add Unicode support (try 7)
by Frédéric Delanoy July 4, 2014

July 4, 2014

On Fri, Jul 4, 2014 at 2:51 PM, Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > Changelog: Convert programs/regsvr32/regsvr32.c to Unicode (try 7). > > This version removes the MultiByteToWideChar calls from version six and instead makes use of a modified resource string. All non-relevant changes have been removed from this version. > > If you would like me to modify all of the po files, I am happy to do so. Just let me know. :) The po file changes are auto-generated, so no need to include them in the patch (as anything auto-generated). Frédéric

1 0

Wine freetext search no longer working
by Hugh McMaster July 3, 2014

July 3, 2014

As of 29 June 2014, the freetext source code search option at http://source.winehq.org/search is not working. The error message is "Unexpected return value 2 from Glimpse". A quick search on the internet reveals the following from http://lxr.sourceforge.net/en/troubleshooting.shtml: Unexpected return value x from Glimpse Glimpse was unable to complete the free-text search query. If x is 2, files are inaccessible. These usually are the auxiliary caches, which may be missing or have incorrect access rights. The relevant directory is defined by the 'glimpsedir' or 'glimpsedirbase' configuration parameters. There is no problem with the identifier search option. -- Hugh McMaster

2 3

Re: [PATCH 2/4] vbscript: Implemented Sgn(try 5)
by Piotr Caban July 3, 2014

July 3, 2014

Hi, +Sub testSgnError(strings, error_num) + on error resume next + + Call Err.clear() + Call Sgn(strings) + Call ok(Err.number = error_num, "Err.number = " & Err.number) +End Sub + +Call testSgnError(Null, 445) This test fails on windows. Tests needs to pass both on windows and on wine. + if(V_VT(arg) == VT_NULL) { + FIXME("Null argument not supported\n"); + return E_NOTIMPL; + } Please fix the indentation here. Cheers, Piotr

2 2