July 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] vbscript/tests: Added tests for the subtype of TypeName(try 4) )
by Marvin July 14, 2014

July 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7988 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Abs(try 8)
by Marvin July 14, 2014

July 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7987 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [4/9] wined3d: replace vendor specific callbacks with generic code that uses vendor specific renderer string tables (try3)
by Henri Verbeet July 14, 2014

July 14, 2014

On 11 July 2014 20:44, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > +#ifndef NUMELMS > +#define NUMELMS(array) (sizeof(array)/sizeof((array)[0])) > +#endif If you really want this kind of thing it would be called ARRAY_SIZE, but I'd prefer just writing it out.

1 0

Re: [PATCH 3/4] vbscript: Implemented Abs(try 7)
by Piotr Caban July 14, 2014

July 14, 2014

Hi, On 07/11/14 05:49, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + if(!res) > + return S_OK; > + > + return VarAbs(arg,res); > } You're not handling res==NULL case correctly. E.g. Call Abs("string") should fail. Thanks, Piotr

2 4

Are there automated tests that verify that Wine's drawing operations produce the same visual output as in Windows?
by Alexander Almaleh July 14, 2014

July 14, 2014

While testing the Polygon() function for my bug report - https://bugs.winehq.org/show_bug.cgi?id=36891, I used a test program that performs a Polygon() operation on a memory device context, and then saves it to a bitmap - i.e. a *.bmp file. I then compared the bitmaps produced under Windows and Wine using a program I wrote in Qt, that just compares width/height, and then makes a pixel-by-pixel comparison (and the Polygon() function did indeed produce a slightly different bitmap). Since this process can be easily automated, I'm wondering if such a framework is already being used? If not, I could probably make a sample test program and image comparison tool, if anyone is interested. It would be fairly easily to spot all kinds of bugs in the drawing functions using such a testing system.

2 3

Re: [1/2] kernel32: Implement GEO_PARENT for GetGeoInfo()
by Marvin July 13, 2014

July 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid android. === wxppro (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === wvistau64 (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w2008s64 (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w7u (32 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === wvistau64 (64 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0 === w2008s64 (64 bit locale) === locale.c:3904: Test failed: got 0 locale.c:3905: Test failed: got locale.c:3963: Test failed: got 0, count 0

1 0

Link download/MS scheint es nicht mehr zu geben
by H. John July 13, 2014

July 13, 2014

Sehr geehrte Herren, leider ist mir folgendes passiert, was mache ich falsch, bzw. hat vielleicht MS wieder die Finger im Spiel!?! Hier der Ausdruck: sh winetricks mdac28 ------------------------------------------------------ You are using a 64-bit WINEPREFIX. If you encounter problems, please retest in a clean 32-bit WINEPREFIX before reporting a bug. ------------------------------------------------------ Executing w_do_call mdac28 Executing load_mdac28 Executing mkdir -p /home/gogo/.cache/winetricks/mdac28 Downloading http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… to /home/gogo/.cache/winetricks/mdac28 --2014-07-13 15:39:35-- http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… Auflösen des Hostnamen »download.microsoft.com (download.microsoft.com)«... fehlgeschlagen: Der Name oder der Dienst ist nicht bekannt. wget: kann die Host-Adresse »download.microsoft.com« nicht auflösen ------------------------------------------------------ Downloading http://download.microsoft.com/download/4/a/a/4aafff19-9d21-4d35-ae81-02c48d… failed ------------------------------------------------------ Vielleicht könnte mir jemand auf die Sprünge Helfen. Vielen Dank Heiner

1 1

Re: [1/3] rsaenh/tests: Make the tests pass in Windows <= NT4
by Dmitry Timoshkov July 12, 2014

July 12, 2014

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + if (!result && GetLastError() == NTE_BAD_FLAGS) /* <= NT4 */ > + { > + ok(broken(1), "Failed to support CRYPT_USERDATA flag\n"); > + result = CryptHashData(hHash, pbData, sizeof(pbData), 0); > + } Wouldn't it be simpler to create a variable 'crypt_flags' that includes CRYPT_USERDATA (among others if needed), and clear CRYPT_USERDATA in the flags once the test detects a failure? That way the failure handling should be performed only once: crypt_flags = CRYPT_USERDATA | ...; result = CryptHashData(hHash, pbData, sizeof(pbData), crypt_flags); if (!result && GetLastError() == NTE_BAD_FLAGS) /* <= NT4 */ { ok(broken(1), "Failed to support CRYPT_USERDATA flag\n"); crypt_flags &= ~CRYPT_USERDATA; result = CryptHashData(hHash, pbData, sizeof(pbData), crypt_flags); } ok(result, "%08x\n", GetLastError()); -- Dmitry.

1 0

Re: comctl32/listview: preserve custom colors between subitems
by Nikolay Sivov July 12, 2014

July 12, 2014

Please add a test for that.

1 0

Re: dxdiag: Do not omit mandatory argument to WriteFile.
by Lauri Kenttä July 12, 2014

July 12, 2014

I'm sorry if I missed something, but at least MSDN clearly states that this is usually an optional argument. http://msdn.microsoft.com/en-us/library/windows/desktop/aa365747%28v=vs.85%… For example, "lpNumberOfBytesWritten [out, optional]" "Use NULL for this parameter if this is an asynchronous operation to avoid potentially erroneous results." "This parameter can be NULL only when the lpOverlapped parameter is not NULL." -- Lauri Kenttä Reply-To: wine-devel(a)winehq.org

2 2