August 2014 - Wine-Devel - list.winehq.org

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)
by Marvin Aug. 23, 2014

Aug. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8634 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Marvin Aug. 23, 2014

Aug. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8633 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] wined3d: Also update the container in wined3d_surface_update_desc().
by Stefan Dösinger Aug. 22, 2014

Aug. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-22 12:32, schrieb Henri Verbeet: > This fixes a bug exposed by commit > 415b8037206b1d4c104d9623037458739f6cfdf5. In particular, > wined3d_resource_update_draw_binding() uses the multisample type to > determine to appropriate draw binding, and since we never updated > that for the container, we could end up with an incorrect draw > binding after a device reset. Why not move this call to the texture entirely? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9yAyAAoJEN0/YqbEcdMwkEsP/juiBeX/o8Pj7hLFs/svF7/U 5fIjBxWSnSq/+WA0/g4OkoIPJoTp+qXjj3irv3r8JCZVTDR455pMDnBZ0yTa+jQa VEF9HvELIurpZz6qOP2UTISD2u2VizzTG74AO8dM+gGYTtX4kPa1+H3QdY7BA2nN XxWW7wGvH5sCzxPh8yx7m8p+vSKzlUQnSuNRoFK+RFLL/VtSeUBsk5OVwuv99LGw lc7DsNH7yKsfG+V5rXyWmgZQsTJDqnlaS+3t5XlqBfdBYuv5JbreUDwdlelbBcmi MWqOdFGVxw60TM7Ra/FXITse9J62lhxjZMyP5nc8nrDp9o6Ci7ynFAzev4FsK6qz eTYj+WRwmsiIKMFPKzx69vz90/ZjdhKM68LPmVythfcB4Cx3YekhME/e7QX0+wZE VBNhZB6VnP7B6BO3tPl8RxMOFzLuFmpgzH2UZevhQVOQximH343CzU0ejf5t0o5Z vkjryDR7QxWE73Ru1p+Sx2b0c81eQtzG+SeDKyjDLLJbVCvFWytj6khUuekupPzF VKHn///AO14pYD1qgRFN4g/FblS792WbXsufV4xDpEsfokoV7E/t8f8vDAoR7FFi rDoP290L95rc9t3ltFW1bVaiKKRrT6mslPZ6e9wR1un7kC9AlfeOiQn8sAVUT3O5 zl9+g1wfTHod4Mi7Sr5J =PO4N -----END PGP SIGNATURE-----

2 1

Re: [PATCH 3/5] wined3d: Get rid of wined3d_device_color_fill().
by Stefan Dösinger Aug. 22, 2014

Aug. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-22 12:32, schrieb Henri Verbeet: > + if (desc.pool != WINED3D_POOL_DEFAULT && desc.pool != WINED3D_POOL_SYSTEM_MEM) > + { > + WARN("Color-fill not allowed on surfaces in pool %#x.\n", desc.pool); > + return D3DERR_INVALIDCALL; > + } I realize that this just keeps existing code in place, but as far as I can see this check is redundant. There's already a somewhat strange check right above this one that tests if the surface is a render target or in WINED3D_POOL_DEFAULT. Unless I missed a way to create a non-default pool render target testing only for WINED3D_POOL_DEFAULT should be enough. The patch also works only as long as we keep the D3DUSAGE_RENDERTARGET check in wined3d_device_set_rendertarget_view and not move it to wined3d_rendertarget_view_create. Is that your intention? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9yX4AAoJEN0/YqbEcdMw5i4P/Ao5NQVk+CMZtE6wAenF/YIx V/NuOHczkC1qnXt74CkZe96o/HukbpoyyQ3uKlDnEzgwN8OrJUfwL3kVq6N9llqu MaYGH0a4P/Ib+ZROouuolNcOFSsgjyHvTnZmHQUONhpzURnmLNdUzoKyfrZTKrwe XtIk4prgEMny5W9Oae0eniYHeVv3Gyvg1jtSoviO/KT/fys5Bb+3xW1Voi7ARPWj Ylm+D61JIQotblAcJVon4JElegbS4ENnziRSJM2774VaCaEpFOkCJ+0e3ZDzgqBQ SjGbuLURL48HHYHKzCBEy9zpTiWr40cLjwm/h6f35koHl3IjHofFuxQPxOLqVDFt L/BsdTUNKFL6EkvalC5ObdFUvgkX+1tx60h4vllue1sFbBIZRkISARoc1Q+HAwJE 4B2Ktwlwy0w2fuy8Ml7j3X8g+wqyPkCpaoFcKtauELFBkY/eqn+HFmoRAJTa2oMb ps3d79EbeRPEVhh9NOOqAAkMuA+ztr52uEbKgq7PS0PzcFIvyECTBWxSnAEjw+d8 CKRk6HGC/v8Jo4Vqw/SzDTYRM/bO5sdvgMulux0zSAJuBZe+YGIcl2d0akT6MYQf 615tmoVbSfR3FY2e7SaMXqfXMLMEZzkQWjRy0A+Zs1+sPycobS3/Q7YjOmhW6goC KQGqfd79P2SuiuAbvlue =h6dU -----END PGP SIGNATURE-----

2 1

Tesing list, ignore
by Jeremy Newman Aug. 21, 2014

Aug. 21, 2014

I'm a test post. Move along....

1 1

Re: [PATCH 5/5] wined3d: Use rendertarget views for color output instead of surfaces.
by Stefan Dösinger Aug. 21, 2014

Aug. 21, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-21 09:55, schrieb Henri Verbeet: > + if (swapchain_desc->backbuffer_count && FAILED(hr = wined3d_rendertarget_view_create_from_surface( > + surface_from_resource(wined3d_texture_get_sub_resource(swapchain->back_buffers[0], 0)), > + NULL, &wined3d_null_parent_ops, &device->back_buffer_view))) > + { > + ERR("Failed to create rendertarget view, hr %#x.\n", hr); > + goto err_out; > + } Having an implicit back buffer render target view managed by wined3d seems a bit odd. Why not let the client libraries create and set the render target view after device creation? That would be similar to what a d3d10 app does after D3D10CreateDeviceAndSwapChain. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9huWAAoJEN0/YqbEcdMwvxMQAIcE7cZnRLTTgECUoxQMWkA5 hobDWConkMr0LGeCMt0Aw98UPsq5n7V/qivYdayudgWbt2YkrRnKq6+d7SIuaWBd QnA0q3CRpWa/v4BKfsXN7t2OKnDwwYCeQoW+qqBpentNEblxVAdh4Rh+/AQZ1Oim PjWdi0Nl31VPnRTQq/GpiHFNY87T9l46hsd5W1GfxY8gPuNxBn0P1xDDsYqG8IxQ 3GH5gw3YIk/JTlvX0nSHQbo05WCgxlGUJ+i7LMotlNth0itEBPOI8EqefEwTdfVO a/6O9xdt7FCNuZSb9yA9nCvn65D8k9hJxYjltF2aouLlbbtuV9CeuNrsxQhqWRA4 vKH5agUKa7dH8aGEaEKk1nrcO9r1U//wGVT1jaZRyWaPx2+o/J/RPIGwEx/HZtyv jInN2QpVSQo4YqSRLHB6geJ3K5OvTAVI4X4QtFXiFQ6IABTmsjlIdxF30fFSmOos +45ohC/GguOJKgvApgWix7xRAX7N1U3QaDsNyaQofJ6hDY7EdMW5Ptz58qBqUv6x 4P6PJ+m4BS5yj+hIsOC1HlwQnMRn4JexTfsg4E/mB5Laa3RONQ8x5aX00G3gs6Sv FozirZyoP4n3d7X0nRkRf4qljlW8SsssWhy7paTLgtLJwdFwy97wWLubdZuljeeg GxCvkXAnRBScDk9IE4z4 =UuRt -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/2] mshtml: Added IHTMLLinkElement::rev property implementation.
by Marvin Aug. 21, 2014

Aug. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8616 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5751: Test failed: hasFeature failed: 80070057 === wxppro (32 bit dom) === dom.c:5751: Test failed: hasFeature failed: 80070057

1 0

Re: [PATCH 1/2] mshtml: Added IHTMLDocument5::get_implementation implementation.
by Marvin Aug. 21, 2014

Aug. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8615 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5720: Test failed: hasFeature failed: 80070057 === wxppro (32 bit dom) === dom.c:5720: Test failed: hasFeature failed: 80070057

1 0

Re: [1/5] ntdll/tests: Add tests for FILE_PIPE_INFORMATION. (try 2)
by Marvin Aug. 21, 2014

Aug. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8610 Your paranoid android. === w8 (32 bit pipe) === pipe.c:546: Test failed: can't open pipe, GetLastError: e7 pipe.c:622: Test failed: can't open pipe, GetLastError: e7

1 0

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.
by Alexandre Julliard Aug. 20, 2014

Aug. 20, 2014

Sebastian Lackner <sebastian(a)fds-team.de> writes: > +#define check_pipe_handle_state(handle, r, c) \ > + do \ > + { \ > + memset(&fpi, 0x55, sizeof(fpi)); \ > + if (handle == INVALID_HANDLE_VALUE) break; \ > + res = pNtQueryInformationFile(handle, &iosb, &fpi, sizeof(fpi), (FILE_INFORMATION_CLASS)23); \ > + ok(!res, "NtQueryInformationFile returned %x\n", res); \ > + ok(fpi.ReadMode == r, "ReadMode == %x\n", fpi.ReadMode); \ > + ok(fpi.CompletionMode == c, "CompletionMode == %x\n", fpi.CompletionMode); \ > + } \ > + while (0) Please use a function instead of a macro for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Piotr Caban Aug. 20, 2014

Aug. 20, 2014

On 08/19/14 17:56, Shuai Meng wrote: > Change log: > checked the type of returned variant instead of printing it. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 2 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > The patch will not apply cleanly in current git. I've sent a patch that adds support for VAR_TIMEVALUEONLY and VAR_DATEVALUEONLY flags to VarDateFromUdateEx function. I think it will be nicer to use this function here. Thanks, Piotr

1 0

Wine test analysis August 6
by Jeremy White Aug. 19, 2014

Aug. 19, 2014

Henri asked me to share my daily link; this page: www.winehq.org/~jwhite/latest.html should redirect you to the latest results of my cron job that analyzes test results. My cron job is hopefully only a temporary tool used to shame people into fixing the tests. It's main features: 1. Limits results only to believed 'good' test bot VMs (which is basically all the production ones, minus the win 8 vm) 2. Looks for patterns (e.g. apparently fixed, sporadically failing, consistently failing) 3. Holds an annotation line The goal is to have 0 failures. My first step in that is to have each failure annotated, so we know who to blame <grin>. The 'good' news is that we are back down under 30 - looks like just 27 failures right now. There are five failures not annotated in any way, and my link for them was blue, so they might be new and easy: http://test.winehq.org/data/tests/shlwapi:ordinal.html http://test.winehq.org/data/tests/comctl32:button.html http://test.winehq.org/data/tests/kernel32:change.html http://test.winehq.org/data/tests/user32:listbox.html http://test.winehq.org/data/tests/user32:win.html Any takers? Cheers, Jeremy

3 2

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)
by Marvin Aug. 19, 2014

Aug. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8592 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Marvin Aug. 19, 2014

Aug. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8591 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: d3d10_1.idl: Added some missing constants.
by Henri Verbeet Aug. 19, 2014

Aug. 19, 2014

In my copy of the PSDK these are guarded by _D3D10_1_CONSTANTS, although it's not entirely clear to me if that actually does anything, since it's only used there, inside d3d10_1.idl.

2 1

Re: [1/2] wbemprox: Implement __SystemSecurity::GetSD.
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8576 Your paranoid android. === wvistau64 (64 bit query) === query: unhandled exception c0000005 at 0000000077336B27 === w2008s64 (64 bit query) === query: unhandled exception c0000005 at 0000000077C76B27

1 0

Re: [PATCH 7/7] vbscript: Implemented Log(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8570 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/7] vbscript: Implemented Exp(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8569 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/7] vbscript: Implemented Atn(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8568 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/7] vbscript: Implemented Tan(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8567 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] vbscript: Implemented Sin(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8566 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] vbscript: Implemented Cos(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8565 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Sqr(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8564 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: ddraw/tests: Correct test condition (PVS-Studio)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8529 Your paranoid android. === w2000pro (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00A10028) === wxppro (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00B50028) === wvistau64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02C70028) === w2008s64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02B90028) === w7u (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(01B70028) === w8 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(019F0000) === wvistau64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(00000000029F0040) === w2008s64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(00000000031A0040)

5 5